Compare commits

...
758 Commits
Author SHA1 Message Date
github-actions[bot] 9ab41c8003 Bump versions for v9.97 2026-07-17 01:42:35 +00:00
Lauri Ojansivu b2284f577e Updated ChangeLog. 2026-07-17 04:41:13 +03:00
Lauri Ojansivu 15adf1bb2d Fix #1289: deleting a user no longer leaves ghost users behind.
Every deletion path (admin removeUser method, self-service account
delete, DELETE /api/users/:userId) removed only the users document,
leaving dangling references everywhere: empty-avatar board members that
could not be removed, stale card members/assignees/watchers, orphaned
avatar files - reproducible for 8 years and reopened in 2025. A
server-only Users.after.remove collection hook now prunes
boards.members/watchers (object-shaped, $pull by userId),
cards.members/assignees/watchers and lists.watchers (string arrays), and
the user's Avatars files, on EVERY path that removes a user; a cleanup
failure can never break the deletion itself. Activities and comments are
deliberately preserved for history - their rendering is already
null-guarded (270eacb20, Playwright-verified).

Tests: tests/userDeletionCleanup.test.cjs (6, positive and negative,
end-to-end against a fake database).

Thanks to chotaire and xet7.
2026-07-17 03:53:09 +03:00
Lauri Ojansivu 17161a8355 Fix #2877: swimlanes no longer jump when starting/ending a card drag.
Drag start hid every list's "+ Add Card" composer link with
display: none, collapsing its row: lists shrank, auto-height swimlanes
shrank, and every swimlane below jumped up about one row (and back down
on drop), moving the drop target under the cursor mid-drag. The root
cause was proven by frame-diffing the issue's own GIF: the three largest
frame discontinuities are exactly drag start and drop, showing the
composer row vanish and the next swimlane header shift ~23px. The
composer now hides with visibility: hidden, preserving its layout box;
checked multi-selection cards keep display: none intentionally (the drag
payload previews the post-drop list).

Tests: tests/swimlaneDragJump.test.cjs (8, positive and negative,
including a guard that flags any return of the layout-collapsing rule).

Thanks to gerroon and xet7.
2026-07-17 03:44:38 +03:00
Lauri Ojansivu 2c23273c11 Fix #443: auto-scroll the board while dragging a card to an
off-screen list.

The horizontal auto-scroll in the card sortable targeted .board-canvas,
which stopped overflowing horizontally when the swimlane layout made the
.js-lists lane the horizontal scroller - scrollLeftMax was always 0, the
guard compared 0 < 0 and never fired, and ui.helper[0].offsetLeft -= 15
assigned a read-only property. Edge-proximity auto-scroll now drives the
lane actually under the pointer (axis-agnostic, clamped, overshoot-safe
helpers in imports/lib/boardAutoScroll.js), with vertical scrolling kept
on the board canvas.

Tests: tests/boardAutoScroll.test.cjs (15, positive and negative,
including a reproduction that the old no-overflow target can never
scroll).

Closes #603: obsolete - the stale-drop-target cause was removed by
d887e553c (perfect-scrollbar removal, native list scrolling),
ed8471be9 (sortable auto-scroll re-enabled) and jQuery UI 1.14.2, whose
sortable resolves insertion neighbours with live offsets on every
mousemove, so a scrolled target list cannot desynchronize drop targets.

Thanks to anhenghuang, AlexanderS and xet7.
2026-07-17 03:41:20 +03:00
Lauri Ojansivu 25d33cec36 Fix #2345 #2674 #574: rules card title filter, rules REST API, api docs;
Sandstorm username races.

- #2345: the Card Title Filter is now SAVED by every board trigger
  builder (a trigger doc missing the field could never satisfy the
  matcher's $in - those rules fired for nothing), SHOWN in the rule
  details, and ENFORCED for archive/restore triggers by resolving the
  title from the card when the activity lacks it; legacy field-less
  triggers keep matching; the filter popup prefills its current value.
- #2674: rules created via POST/PUT /api/boards/:boardId/rules never
  fired - missing matching fields are now normalized to '*' wildcards
  and trigger/action types validated; the addMember/removeMember rule
  actions no longer crash on unresolvable usernames or member-less
  cards and their writes are awaited. New docs/API/Rules.md (endpoints,
  matching fields, wildcard semantics, the exact two-rule
  add-on-move-to/remove-on-move-from workflow), linked from REST-API.md;
  api.py help now lists the rule commands with the same example.
- #574: Sandstorm unique-username generation probes case-insensitively
  (anchored, regex-escaped) and retries the next number when a
  concurrent insert wins the unique-index race, instead of aborting the
  login hook with E11000.

Tests: tests/rulesCardTitleFilter.test.cjs (12),
tests/rulesApiTriggerNormalize.test.cjs (19),
tests/sandstormUsername.test.cjs (11) - positive and negative cases.

Thanks to InfoSec812, sfahrenholz, mitar and xet7.
2026-07-17 03:36:50 +03:00
Lauri Ojansivu 0f2179988b Fix #619: invitee username collisions no longer fail with a raw 403.
Inviting by email derives the new user's username from the email local
part; a collision with an existing user (cats@foo.com then
cats@facebook.com) made Accounts.createUser throw Meteor's raw
"403 Username already exists", shown to the inviter as just "403". The
username now probes cats, cats1, cats2, ... to the first free variant
(bounded), and exhaustion raises the translated error-username-taken.

Tests: tests/inviteeUsername.test.cjs (11, positive and negative,
including the literal reported scenario).

Closes #804: already fixed - every popup is viewport-clamped with
internal scrolling since ac368de06 (#5667 geometry rewrite: maxHeight
from live viewport space, bounded flex layout) plus the 04eb8a8fb
(#6221) global 90vh clamp; the member picker inherits the shell, so
neither standalone nor the Sandstorm iframe can grow past the viewport.

Thanks to lemoer, ocdtrekkie and xet7.
2026-07-17 03:36:07 +03:00
Lauri Ojansivu d5937f6d38 Fix #1502: date pickers honor the configured default time.
The due-date picker configures defaultTime 17:00 (received/start/end use
now()), but an inverted guard in datePickerRendered applied it only when
the card ALREADY had a date - the one case where it is unnecessary - so
for dateless cards the time input stayed empty and submit stored a
hard-coded 12:00. Empty pickers now pre-fill with the configured
default, submit falls back to it, and existing dates keep their own
time. The 2018 AM/PM display/parse mismatch was already fixed by the
native HTML date/time inputs (79b94824e); week start already honors the
user preference.

Tests: tests/datePickerDefaultTime.test.cjs (10, positive and negative).

Thanks to Vlasterx, saschafoerster, suncobran and xet7.
2026-07-17 03:34:52 +03:00
Lauri Ojansivu 7c0ae509ac Fix #2769 #1992 #2292 #2494 #1853 #1554 #2306 #1437.
- #2769: refresh drag geometry when the DOM changes mid-drag - cards no
  longer drop into the wrong swimlane while someone adds a card.
- #1992: board import restores all five card date fields (and creator)
  with fallbacks; receivedAt/endAt were never imported at all.
- #2292: archiving a swimlane archives its cards (mirroring lists);
  restore brings back exactly the cards archived with it.
- #2494: client noCache card lookup returned a Promise since the
  Meteor 3 port - multi-select board moves wrote sort: NaN everywhere.
- #1853: subtask "View it" falls back to the subtask's boardId when the
  deposit board is not loaded, instead of silently doing nothing.
- #1554: restore the reactive dependency lost in 7673c77c5 so cards
  added after board render accept sidebar label/member drops.
- #2306: "filter to selection" and every bulk action are board-scoped;
  foreign-board cards can no longer be silently archived.
- #1437: new POST /users/logout API endpoint revokes the presented
  resume token, or all tokens with {"all": true}.

All with positive+negative regression tests (see tests/*.test.cjs).

Closes #1389: already fixed - the standalone pencil edit button
(0cc63b810) plus the wrapped viewer (bf2b3b40c) guarantee an edit target
even when a full-width link fills the description.

Thanks to hever, Cactusbone, Vermeille, Vanclief, Miffe, IcedQuinn,
ppouliot, GhassenRjab and xet7.
2026-07-17 03:34:23 +03:00
Lauri Ojansivu 42b4e51f85 Fix #2418: one inlined edit form at a time; no cross-item overwrite.
Since 8c3ce4bb7 (2021) the "close the previous inlined form" call was a
silent no-op: the inlinedForm escape action registers with
enabledOnClick: false and EscapeActions.clickExecute skips such actions,
so clicking another checklist item left both edit forms open - and the
submit handlers find the template's FIRST textarea, so the wrong form's
text was saved over the submitted item. Subtasks reproduced the full
bug; the checklists workaround corrupted the shared open-form tracker so
Escape fell through and closed the whole card details pane. A pure state
manager (client/lib/inlinedFormManager.js) now enforces the single-open
invariant: opening a form closes the tracked previous one (popups
untouched, preserving the 2021 intent); close/destroy only reset the
tracker for the form they own.

Tests: tests/inlinedFormSingleOpen.test.cjs (9, positive and negative,
including the exact reported A->B->C repro).

Thanks to Beebo89 and xet7.
2026-07-17 03:30:07 +03:00
Lauri Ojansivu 66a19c4bd4 Fix #2989: Advanced Filter matches date custom fields.
Two defects: the tokenizer flipped into regex mode on every '/' even
inside quoted strings, so a quoted date like '06/04/2020' broke
tokenizing and the whole filter silently no-opped; and date custom
fields store Date objects while the comparison selectors used strings
and parseInt - equality and ranges could never match, != matched every
card. Dates now parse per the user's date format (day-first formats
respected) into half-open Date-range selectors; non-date fields keep the
legacy selectors unchanged.

Tests: tests/advancedFilterDate.test.cjs (14, positive and negative).

Closes #2521: already fixed since v3.88 (9819c9f80) - the checklist
completed/uncompleted activity text was missing due to an activityType
name mismatch between model and template; the current unified activity
template, i18n keys and helpers render it correctly.

Thanks to k1ng440, ott29 and xet7.
2026-07-17 03:27:33 +03:00
Lauri Ojansivu 5e036dc544 Fix #3826: card drag reorder in lists full of subtask cards.
addSubtaskCard inserted every subtask card with the constant sort -1,
leaving the whole list tied: a drop between two equal sorts computes a
zero increment, the move modifier is empty and Card.move() silently
discards it - the card snapped back, and a multi-selection drop wrote
the SAME sort to every selected card, permanently destroying their
relative order (the data-loss risk in the issue triage). Subtask cards
now append with a unique sort (max+1), and the sortable stop handler
detects degenerate gaps (ties/inversions) and repairs the siblings'
sorts to a strictly increasing order before recomputing the drop index;
healthy lists take the unchanged fast path.

Tests: tests/subtaskCardReorder.test.cjs (14, positive and negative,
including the exact issue scenario and a guard that the old
{base:-1, increment:0} result can never be produced again).

Thanks to jayki and xet7.
2026-07-17 03:21:28 +03:00
Lauri Ojansivu 973c2ad901 Fix #3453 #3199; linked-card custom field crash; pin #3843.
- #3453: publish the FULL subtask ancestor chain, not only direct
  parents - the cross-board full-path label vanished after refresh.
- #3748 (defect half): skip unresolvable custom-field definitions on
  linked cards - phantom empty rows and a template TypeError on every
  card details render. The mirroring itself is by design: linked cards
  are pointers; label/custom-field ids are board-scoped; name-based
  inheritance is the copy feature, not the link feature.
- #3199: group each archived card with its own Restore/Delete links and
  add a clear separator below the group (RTL-safe, theme-neutral).
- #3843: comment-editor uploads and the attachments popup now share one
  null-safe meta builder, and tests pin that comment attachments list in
  the card's Attachments section.

Closes #3748: mirroring is by design (see above); the only actionable
defect is fixed in this commit.
Closes #3378: already fixed - notification_cleanup moved off SyncedCron
to a guarded Meteor.setInterval singleton, and quave:synced-cron 2.4.0
handles the E11000 history collision that percolate 1.5.x missed.
Closes #3276: already fixed by d3625db75 - the spent-time badge helpers
now read the live Cards document reactively, so the overtime color flips
immediately; verified behaviorally against the real component.
Closes #3843: behavior verified present and now regression-locked.

Thanks to MPeti1, peterbecich, fxkr, jghaanstra and xet7.
2026-07-17 03:21:02 +03:00
Lauri Ojansivu dd3f71c951 Fix #4822: maximized card position in Swimlanes view.
The maximized card pane had no position of its own, so it remained an
in-flow item inside the scrolled board canvas and rendered off-screen
after scrolling down; desktop-mode floating-window rules also overrode
every maximize geometry rule, and inline drag offsets survived
maximizing. The pane is now viewport-fixed with insets that win over
both (drag position restores on minimize), RTL-safe. Regression test
with a CSS cascade resolver that fails on the pre-fix stylesheet:
tests/maximizedCardPosition.test.cjs.

Closes #3566: mobile shows one list at a time by design (xet7's own
comments in the issue); Move Card popup is the supported flow, and the
2021-era touch drag glitches were since fixed with drag handles.
Closes #3252: already fixed - comment deletes are guarded in
client/components/activities/comments.js (tagged #3252), checklists in
checklists.js, attachments via #5282.
Closes #3542: no code bug - redirect_uri is the same expression on the
client and server (mismatches come from ROOT_URL/proxy configuration,
per the Bug:Environment-specific label), and the login-style half was
fixed via #5695.

Thanks to pravdomil, 1ubuntuuser, gastoncollaud and xet7.
2026-07-17 03:15:52 +03:00
Lauri Ojansivu 6b9086d2a8 Changelog for #4036 #4043 #4023 #4593; finish #4043 hardening.
- CHANGELOG.md: Upcoming entries for the LDAP group filter fix (#4036),
  invitation code regeneration (#4043), CJK add-card footer wrapping
  (#4023) and team-to-board member sync (#4593), whose code shipped in
  the previous commit.
- server/models/users.js: do not delete the invitation code in
  onCreateUser before the account insert is committed - a failed insert
  (duplicate username/email) burned the code for every retry (#4043).
  Consumption happens after a successful insert; re-invites regenerate
  stale codes.
- tests/teamBoardMemberSync.test.cjs: the #4593 regression tests (13,
  positive and negative) for the team board-member sync helpers.

Thanks to zeisss-mercedes, jkoenig134, yuki-snow1823, Sylvain2703,
szymonsztuka and xet7.
2026-07-17 03:12:43 +03:00
Lauri Ojansivu 9ddbc777dd Startup schema upgrade, self-healing attachments, migration speed; fix
#5695 #4897 #4654 #5174 #4825 #5659 #4730 #4419 #4158 #4560 #4036
#1959 #1971.

- Startup schema upgrade (server/lib/schemaUpgradeSteps.js): on start,
  check that data from EVERY old WeKan version is migrated to the newest
  structure and migrate only what is missing - all platforms, MongoDB and
  FerretDB. Version-gated (marker stores WeKan version + datetime of the
  last re-check; one findOne per boot until a new release), non-blocking,
  live dashboard at /schema-upgrade-status showing the product name, fast
  on big databases (distinct() set-joins, updateMany batches). Steps:
  archived-flag backfill, swimlane structure + visibility rescue
  (#1959 #1971: cards under deleted/archived/foreign swimlanes reassigned
  to a visible swimlane; card-insert hook validates supplied swimlaneIds),
  merge-per-swimlane-lists (v7.98/v8.0x list copies merged back into
  shared lists: no duplicate columns in Lists view, everything visible in
  Swimlanes view, cards keep their swimlane), embedded checklist items,
  customFields boardIds, allows* backfills, members isActive, permission
  lowercase, filesystem path healing.
- Migration speed (5-hour reports): insertMany batches in the text phase,
  preloaded target-record maps in the file phases.
- Snap attachment-repair + FILES_ONLY importer mode (see prior commit
  wiring) extended with CFS FileSystem-store coverage
  (ATTACHMENTS_STORE_PATH era), missing-binary reporting, and
  migrate-gridfs-to-fs.mjs bucket fixes.
- OAuth2/OIDC: OAUTH2_LOGIN_STYLE=redirect honored (#5695); concurrent
  logins no longer contaminate each other's user data (#4897); account
  merge no longer wipes avatars/templates (#4560).
- LDAP: background sync fixed (#4654), password login rejected after LDAP
  migration (#4419), LDAP_ENCRYPTION=true actually encrypts (#4158),
  group filter accepts multiple groups and admits admin-sync groups
  (#4036).
- All Boards tiles: per-list card counts + member avatars restored
  non-reactively (#5174 #4825). Uniform default list widths (#5659).
  Declined invitations no longer resurrect membership (#4730).
- Tests with negative cases for every fix (tests/*.test.cjs; suite green
  except the pre-existing environment-only htmljs failure).

Closes #5600: OAUTH2_CA_CERT already works - the fetch migration
(49a272d6c) applies the CA to all OIDC calls via https.Agent.
Closes #3828: board members seeing all board cards is by design (no
per-card visibility model), and organizations/teams now exist.

Thanks to mueschel, ArturRuta, gerardo-junior, fabianrbz, Miuler,
butteredCat-2021, Griiimm, preciousamorc, farwayer, LeoLu-eng, hnb1,
rangersdo and xet7.
2026-07-17 03:07:59 +03:00
Lauri Ojansivu 65bf215cbe Fix #6473: attachments missing after the MongoDB -> FerretDB migration.
- Migration importers: resolve the CollectionFS GridFS id from
  copies.<bucket>.key too (the REAL old-WeKan layout; only
  original.gridFsFileId / gridFsFileId / copies.gridfs.key were tried,
  none of which exist there) via a shared resolveCfsGridFsId() in
  releases/migrate-mongodb-to-ferretdb.mjs,
  snap-src/bin/migrate-mongo3-to-ferretdb.mjs and
  snap-src/bin/migrate-gridfs-to-fs.mjs. The modern importer now drives
  CollectionFS extraction from cfs_gridfs.<bucket>.files itself, so a
  missing/empty cfs.<bucket>.filerecord no longer silently skips every
  file; binaries without a filerecord are still extracted to disk, and
  filerecords whose binary cannot be located are reported on the
  dashboard instead of dropped.
- Meteor-Files phase: match versions.*.meta.gridFsFileId without a
  storage flag (WeKan's own getFileStrategy rule), handle every version
  (not just 'original'), and add a bucket-driven sweep of <bucket>.files
  by metadata.fileId so binaries are recovered even when the record's
  flags say nothing about GridFS. GridFS-flagged versions with no
  locatable binary are reported.
- mongo3 importer: copy the CollectionFS top-level boardId/cardId/
  listId/swimlaneId/userId into meta on the created records - an
  attachment without meta.cardId shows on no card.
- Admin Panel > Attachments: the Filesystem Storage paths were computed
  from process.env.WRITABLE_PATH IN THE BROWSER, so they always showed
  "/data". New admin-only getAttachmentStoragePaths method returns the
  real Snap-aware paths (shared models/lib/attachmentStoragePath.js),
  also used for the settings document default (was /data/attachments,
  actual Docker path is /data/files/attachments).
- Snap: `snap run wekan.database ferretdb` now says it does NOT migrate
  data, says when nothing was switched, and points at
  `snap run wekan.migrate` for re-running the full migration.
- Tests with negative cases: tests/migrationAttachmentExtraction.test.cjs
  (behavioral resolveCfsGridFsId from all three importers + wiring
  guards) and tests/attachmentStoragePath.test.cjs, wired into
  test:unit:node.
- Companion fix in wekan/FerretDB: accept documents with literal dotted
  field names like MongoDB 3.6+, so migrated documents containing them
  are no longer silently dropped.
- CHANGELOG.md: new Upcoming section with these changes.

If attachments are already missing after an earlier migration, run
`snap run wekan.migrate` - the source MongoDB data was never modified,
and the fixed importers re-create the attachment records and files.

Thanks to mueschel and xet7.
2026-07-17 01:43:53 +03:00
github-actions[bot] e4e73e8b80 Bump versions for v9.96 2026-07-16 17:40:41 +00:00
Lauri Ojansivu c83284811c Updated ChangeLog. 2026-07-16 20:39:07 +03:00
Lauri Ojansivu 643a296595 Fix #6465 follow-ups found by test run 2026-07-16_19-21-02.
The right-docked card details window exposed two real issues in the
Playwright run (03-cards-operations failing in all three browsers):

- Archiving or deleting a card left its id in the openCards session
  list, so the floating details window kept rendering above the board —
  and, docked to the right edge, exactly over the archives sidebar,
  intercepting its Restore/Delete clicks. Both handlers now drop the
  card from openCards and clear currentCard.
- An OPEN board sidebar now stacks above the card window (z-index 2002
  vs 2001), so the sidebar is always usable while a card is open.

Also from the same run: the new one-click cog spec closed its popup with
a keyboard Escape that proved unreliable across engines — it now uses
the popup's own X button (.js-close-pop-over) like 19-accessibility
does. The chromium-only 33-board-domains failure is an unrelated
token-login race in the auth helper (userId mismatch), not caused by
these changes.

tests/uiDensity.test.cjs got guards for both follow-ups (openCards
cleanup in archive+delete, sidebar z-index above the card window).
Updated ChangeLog.

Thanks to xet7.
2026-07-16 20:01:10 +03:00
Lauri Ojansivu 2d76e1cb92 Behavioral tests for the ferretdb-has-data guard.
tests/ferretdbHasData.test.cjs runs the real snap-src/bin/ferretdb-has-data
against crafted directories. This guard gates two critical switches
(migration-control's finish_success and mongodb-control's #6458/#6466
failure handler), so its semantics must never drift. Positive: non-empty
.sqlite, no -wal sidecar required (clean shutdown checkpoints it away),
one good file among empties. Negative: 0-byte .sqlite from a failed
migration, empty/missing directories, -wal/-shm-only leftovers, and a
DIRECTORY named *.sqlite. All eight behaviors verified against the
actual script. Wired into test:unit:node; ChangeLog updated.

Thanks to xet7.
2026-07-16 19:12:59 +03:00
Lauri Ojansivu 4fc918c245 Playwright: fix strict-mode violation from the #6465 header cog; test it.
The 2026-07-16_18-33-28 test run failed one spec in all three browsers:
the #6465 one-click board-settings cog added a second .js-open-board-menu
element, so 03-cards-operations' bare class locator resolved to 2
elements and tripped Playwright's strict mode. The archives test now
scopes the click to the sidebar's instance (.board-sidebar
.js-open-board-menu), keeping its 'from inside the sidebar' intent.

Also added a spec for the new cog itself to 15-board-actions: visible in
#header-main-bar, popup not open before the click (negative), ONE click
opens the real boardMenu popup (.js-open-archives inside), Escape closes
it again.

Thanks to xet7.
2026-07-16 19:09:36 +03:00
Lauri Ojansivu d7ca7360ff Tests for the cpu-exec delivery pipeline; changelog upcoming updates.
tests/cpuExecWiring.test.cjs, with negative cases: every Linux bundle in
release-all.yml embeds cpu-exec + its own arch's static qemu-user (arm64
and the QEMU-built extra arches replace the inherited amd64 one, extra
arches tolerantly), the Windows/macOS bundles strip both Linux-only
files, qemu-user-static is installed in every bundle-building job and
both sandstorm jobs, the Sandstorm .spk ships cpu-exec + qemu via
build-deps.sh (tolerant when qemu is not installed), the Docker
entrypoint and the bundle launcher route ferretdb/node through cpu-exec
while keeping direct-exec fallbacks for bundles that lack it, and the
snap ships cpu-exec via the snap-src helpers part. Wired into
test:unit:node; complements tests/cpuExec.test.cjs (the script's own
behavior).

ChangeLog Upcoming: the regression-tests entry now lists the cpu-exec
wiring test, the subtasks default-board test (#6456) and the FerretDB
fork's integration-test fixes.

Thanks to xet7.
2026-07-16 18:54:28 +03:00
Lauri Ojansivu fcce2e1cea Subtasks: fix addSubtaskCard crash on Meteor 3 server.
Fixes #6456.

The lazily-creating getters for the default subtasks helper board and
its landing list still used the sync Boards.insert / Swimlanes.insert /
Lists.insert / Boards.update APIs that Meteor 3 removed from the server,
so creating a subtask crashed with 'insert is not available on the
server. Please use insertAsync() instead' whenever the ^Board^ helper
board had to be created. The list creator additionally read
getDefaultSwimline()._id, which is a Promise on the Meteor 3 server.

- getDefaultSubtasksBoardId / getDefaultSubtasksListId are now PURE
  getters (no creation), matching the #3868/#2256 rule that only the
  server may create these.
- The server-side lazy creation moved into getDefaultSubtasksBoardAsync
  and getDefaultSubtasksListAsync using insertAsync/updateAsync and
  getDefaultSwimlineAsync — the exact path addSubtaskCard uses.
- The never-called date-settings twins had the same sync calls and no
  server-only guard at all; they are pure getters now too.
- tests/subtasksDefaultBoard.test.cjs guards the async creators and that
  no sync collection writes come back to models/boards.js, wired into
  test:unit:node.
- Updated ChangeLog.

Thanks to sjohnen and xet7.
2026-07-16 18:46:09 +03:00
Lauri Ojansivu a91203b158 Close the issues fixed by ed19445d3 and 794346e39.
That commit's message listed all ten issues after a single Fix keyword,
but GitHub only auto-closes a reference that directly follows its own
closing keyword, so only the first issue was closed on push. Closing
the rest here; the fixes themselves are already on main.

Fixes #6455. Fixes #6458. Fixes #6466. Fixes #6467. Fixes #6468.
Fixes #6472. Fixes #6465. Fixes #5547. Fixes #5282.

Thanks to xet7.
2026-07-16 17:55:44 +03:00
Lauri Ojansivu 794346e396 cpu-exec qemu-user fallback everywhere; tests for all newest fixes.
Fix #6458 completely: the reporter's host runs inside a hypervisor that
masks AVX, and the old per-tool AVX wrappers (amd64-only, PATH-based)
were bypassed by absolute-path mongod invocations.

- New general snap-src/bin/cpu-exec: runs any binary directly when the
  CPU has the features it declares (--features x86_64=avx,aarch64=atomics
  or WEKAN_REQUIRED_CPU_FEATURES) and through same-arch qemu-user when
  not; plain zero-overhead exec with no declared features. Lookup order:
  WEKAN_QEMU_USER, qemu-<arch> next to the script (bundle/Docker),
  $SNAP/qemu-<arch>, the snap's migratemongo/avx one, then system
  qemu-user(-static). Clear error + direct run when no qemu exists, so
  the real SIGILL surfaces instead of hiding.
- Snap: mongodb-control and migration-control run every mongod 7 through
  cpu-exec, so MongoDB works without AVX (slower) and migration can READ
  modern MongoDB data on such CPUs; completed-FerretDB switch and
  migration fallbacks unchanged (switch_to_completed_ferretdb extracted).
- release-all.yml: every Linux bundle .zip ships cpu-exec + this-arch's
  static qemu-user (amd64/arm64/ppc64le/s390x/riscv64; stripped from
  win64/mac bundles), flowing into Docker and Snap automatically;
  Sandstorm .spk gets both via build-deps.sh. Bundle launcher and Docker
  entrypoint route node/ferretdb through cpu-exec.
- Docs: mongodb-avx-qemu.md and mongodb-raspi4-qemu.md document the
  built-in mechanism.

Tests, with negative cases, for the newest features and fixes at
changelog: htmljs array-vs-attributes (#6459), description draft
normalize/reset (#6455), comment draft lifecycle (#5547), attachment
delete guard (#5282), rules move actions + import normalization (#6472),
snap mongod-failure/migration recovery (#6458 #6466), FerretDB polling
defaults (#6467 #6468), UI density guards for every #6465 fix, and a
behavioral cpu-exec test against fake cpuinfo + fake qemu. All wired
into test:unit:node. Go table tests for the FerretDB SQLite filter
pushdown are in the wekan/FerretDB repo.

Updated ChangeLog.

Thanks to xet7.
2026-07-16 17:40:24 +03:00
Lauri Ojansivu ed19445d30 Fix #6459 #6455 #6458 #6466 #6467 #6468 #6472 #6465 #5547 #5282.
- #6459: card More menu rendered empty (no Delete): the vendored jade
  compiler's htmljs patch made isConstructedObject(Array) false, so
  'label {{_ ...}}:' lines got their content array mis-assigned as tag
  attributes and Blaze threw 'foreign objects in attributes' killing the
  whole cardMorePopup. Also fixed the list More link input (nonexistent
  rootUrl helper -> absoluteUrl).
- #6455: saving a card description never removed a pre-existing unsaved-
  edits record, and the draft/description comparison mismatched on Markdown
  hard-breaks and empty descriptions, re-creating a phantom draft on every
  save. Save now clears the draft; both sides normalized the same way.
- #5547: comment drafts: the draft-saving escape handler had been disarmed
  since 2019 (flag with no setter), so a comment being written was lost
  when the card closed. Drafts are now saved continuously (debounced),
  flushed on teardown, cleared on submit; text no longer visually vanishes
  on outside clicks.
- #5282: attachment delete: guard against the doc being already evicted
  from Minimongo ('Removed nonexistent document'), like the existing
  comment/checklist guards.
- #6472: rules move card to top/bottom: fall back to the card's current
  list when listName does not resolve (was a swallowed TypeError = rule
  silently did nothing); wizard stored listTitle which the engine never
  reads (listName); empty destination wrote sort +-Infinity; rules JSON/CSV
  import now uses the rules.createRule method instead of client inserts
  rejected into minimongo limbo, and defaults missing trigger matching
  fields to '*'; empty boardId no longer overrides the real board; the
  server-side orphaned-cards fallback in List.cards()/cardsUnfiltered()
  now actually resolves its async swimlane lookup.
- #6465: desktop density back to WeKan 6.09: base font 14px and headings
  22/18/16px (vw clamps resolved to 18/24px on desktop), All Boards
  wrapper padding 10px/15px, card details docks to the right edge instead
  of floating on top of its own card (still draggable), 20px canvas
  padding instead of ~48px white borders, removed the force-all-card-text-
  to-title-size rule, admin org/team table Select/Unselect-all header
  links are compact icons and header cells may wrap, zoom pill no longer
  cut off, one-click board settings cog in the board header.
- #6458 #6466: snap: mongodb-control now checks mongod's exit status and
  does an AVX pre-flight (MongoDB 5+ needs AVX; without it mongod SIGILLs)
  instead of pinging a dead port forever behind a 502: it switches to a
  completed FerretDB migration, or (re)runs the migration (AVX-free) with
  a 3-attempt guard. Migration importers no longer fail the whole run on
  >=10 per-item errors ('Avatars Errors' etc.), and a failed 3.x-source
  migration keeps the copied FerretDB data + checkpoint and resumes next
  start instead of deleting it and 'falling back' to a mongod 7 that
  cannot open 3.x data files.
- #6467 #6468: with FerretDB, calm Meteor's no-oplog polling storm
  (METEOR_POLLING_THROTTLE_MS=2000, METEOR_POLLING_INTERVAL_MS=30000
  defaults in the snap and bundle launcher; overridable). The FerretDB
  fork gets filter pushdown, a sane pool size and less locking in its own
  repo.
- Updated ChangeLog.

Thanks to xet7.
2026-07-16 17:08:31 +03:00
Lauri Ojansivu 1193f3a4b5 LDAP: cleaner server-context org/team sync call, fix indentation.
Follow-up to PRs #6469 and #6470:

- The login-time org/team sync now clears the inherited method invocation
  context (DDP._CurrentMethodInvocation.withValue) around a normal
  Meteor.callAsync, instead of invoking the raw method handler with a
  hand-made invocation object. This goes through Meteor's normal method
  dispatch (check() argument audits, EJSON argument cloning) while still
  being the server-to-server path (connection null) that the admin guard
  in setUserOrgsTeamsFromLdap allows.
- Added the ddp package dependency to wekan-ldap for the DDP symbol.
- Fixed indentation in localizeAvatarFromBuffer and restored the comment
  explaining the proceedAfterUpload argument.
- Removed a stray double blank line in the LDAP login handler.
- Updated ChangeLog about the merged LDAP fixes.

Thanks to xet7.
2026-07-16 15:47:52 +03:00
Lauri Ojansivu 98ba5fcc9d Merge pull request #6470 from ChristianMa97/feature-ldap-hardening-and-wildcard-group-filter
LDAP: harden org/team sync during login and add wildcard group allowlists
2026-07-16 15:39:54 +03:00
Lauri Ojansivu b735f23045 Merge pull request #6469 from ChristianMa97/bugfix-ldap-double-escaping
Fix LDAP group filters by removing redundant backslash escaping
2026-07-16 15:38:42 +03:00
Lauri Ojansivu 7491c37feb release-all.yml: also build the Sandstorm .spk and attach it to the release.
Added a build-sandstorm job that runs after the GitHub Release is created,
with the same steps as the standalone sandstorm.yml workflow (which still
exists for testing the .spk build on its own), attaching
wekan-<version>-sandstorm.spk to the Release. Non-blocking, so the
experimental Sandstorm build never fails or delays the release.

Thanks to xet7.
2026-07-16 13:27:32 +03:00
Lauri Ojansivu 503601515a Updated ChangeLog. 2026-07-16 13:18:59 +03:00
Lauri Ojansivu 10d5006d2e Merge pull request #6462 from wekan/dependabot/npm_and_yarn/websocket-driver-0.7.5
Bump websocket-driver from 0.7.4 to 0.7.5
2026-07-16 13:12:18 +03:00
cmartin 2513c782f7 feat(ldap): implement LDAP group allowlist parsing and filtering with wildcards support 2026-07-16 10:17:13 +02:00
cmartin c1cae29544 fix(ldap): keep login successful when optional sync fails and fix avatar localization write path 2026-07-16 10:16:59 +02:00
cmartin 98dae04c2d Remove redundant backslash escaping in LDAP filter construction 2026-07-16 09:53:37 +02:00
dependabot[bot] 4e15057277 Bump websocket-driver from 0.7.4 to 0.7.5
Bumps [websocket-driver](https://github.com/faye/websocket-driver-node) from 0.7.4 to 0.7.5.
- [Changelog](https://github.com/faye/websocket-driver-node/blob/main/CHANGELOG.md)
- [Commits](https://github.com/faye/websocket-driver-node/compare/0.7.4...0.7.5)

---
updated-dependencies:
- dependency-name: websocket-driver
  dependency-version: 0.7.5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-15 22:09:17 +00:00
github-actions[bot] f602b9459f Bump versions for v9.95 2026-07-15 12:58:19 +00:00
Lauri Ojansivu b3a9b90f22 Updated ChangeLog. 2026-07-15 15:57:04 +03:00
Lauri Ojansivu 14e6851f01 release-all.yml: publish the snap to the stable channel too
Both snap jobs (snap-native and snap-launchpad) pushed only to candidate, beta
and edge, and stable had to be released by hand afterwards. Publish to
stable,candidate,beta,edge instead. base: core24 allows stable and candidate.

Thanks to xet7.
2026-07-15 15:57:04 +03:00
Lauri Ojansivu ab1c636e71 Snap: resume an interrupted MongoDB to FerretDB migration instead of redoing it
A big migration can run for 5 hours, so being interrupted by a snap refresh,
`snap stop` or a reboot is normal - but it was treated as a failure, and every
interruption threw away all of the work.

Distinguish interrupted from failed. snapd's SIGTERM killed the importer, bash
resumed at the line after the importer call, read the signal exit code (143) as
"the migration failed", and fail_and_run_mongodb deleted the partial FerretDB
SQLite and set migrate=off. Now a SIGTERM/SIGINT trap (and an importer exit code
>= 128, since snapd signals every process in the service cgroup) keeps the
partial database and the checkpoint, leaves auto-migration on, and hands back to
mongodb-control so WeKan keeps serving from MongoDB until the next start resumes.
Both importers flush their checkpoint on the signal and exit 128+signo.

Checkpoint files, not just collections. Only fully-copied collections were
checkpointed; the file phase started over. Worse, the destination path was picked
with an "append _1, _2, ... while the file exists" loop, so every already-
extracted attachment was written a second time under a new name, orphaning the
first copy - a resumed migration silently needed twice the disk the up-front
space check budgeted for. Files are now checkpointed individually (recorded only
once the bytes are on disk AND the record points at them, and re-verified by size
on resume, so a half-written file is never mistaken for a finished one) and
skipped when resuming. The path is now deterministic: idHex is the record's _id,
so two records never collide and an existing file there can only be this record's
own partial extraction, which is meant to be overwritten.

Discard the checkpoint together with the SQLite it describes. The checkpoint
lives in $SNAP_COMMON, not in the SQLite dir that discard_partial_ferretdb wipes,
so it survived. The next migration then trusted it, skipped every "already
migrated" collection, copied only the rest into the now-empty database, and
reported success - leaving the snap serving a FerretDB missing most of its data.

The MongoDB 3 importer had no checkpoint at all and now resumes collections and
files the same way. The source MongoDB data is never touched on any of these
paths.

Thanks to markusst1982 and xet7.
2026-07-15 15:57:04 +03:00
Lauri Ojansivu 4e1e661d99 Fix WeKan not working after FerretDB migration: resume login used a positional projection
Meteor's accounts-base "resume" login handler projects a single array element
with the positional operator:

  Meteor.users.findOneAsync(
    { 'services.resume.loginTokens.hashedToken': hashedToken },
    { fields: { 'services.resume.loginTokens.$': 1 } })

FerretDB rejects that find with "Executor error during find command :: caused
by :: positional operator '.$' couldn't find a matching element in the array"
(code 51246).

Resume is how every already-logged-in browser re-authenticates on page load and
on every DDP reconnect, so the throw logged users out, the client retried the
connection, and the retry loop pinned the FerretDB CPU - the board looked broken
right after a migration that had just taken hours.

Replace the handler with one that projects the whole loginTokens array and picks
the matching token in JS. Upstream already does exactly this in its own $or
fallback query ("Cannot use ...loginTokens.$ positional operator with $or
query"), so the array is known to be small enough to fetch, and behaviour is
otherwise unchanged - including looking up the hashed token on its own first so
the unhashed token is not sent to the database unless it has to be.

Closes #6457

Thanks to markusst1982 and xet7.
2026-07-15 15:57:04 +03:00
github-actions[bot] a84a88794f Bump versions for v9.94 2026-07-15 06:09:00 +00:00
Lauri Ojansivu a5d206e23d Updated ChangeLog. 2026-07-15 09:07:36 +03:00
Lauri Ojansivu aadd653b15 CHANGELOG: new Upcoming section above v9.93 with the post-9.93 fixes
9.93 is released, so move the two commits made after it into a fresh
"# Upcoming WeKan ® release" section above v9.93, organized like the previous releases:

  Features: database setting authoritative + snap run wekan.database mongodb|ferretdb +
            no-downtime handling of a failed migration.
  Bugs:     migration skips dotted (GridFS/CollectionFS/system) collections that FerretDB
            rejects, and cleans up a partial SQLite from a failed migration.

No entry text changed; only relocated.
2026-07-15 09:01:37 +03:00
Lauri Ojansivu 7d271413bf Snap: make database setting authoritative + wekan.database command + no-downtime on failure
Problem: the control scripts force-switched to FerretDB whenever a *.sqlite file existed, so
`snap set wekan database=mongodb` did not stick and a failed migration caused downtime with no
way to keep WeKan running on MongoDB while fixing it.

- The `database` snap setting is now AUTHORITATIVE. Removed the "FerretDB SQLite present ->
  force ferretdb / disable mongodb" overrides from wekan-control, ferretdb-control and
  mongodb-control. wekan-control keeps only the safety guard (never start an EMPTY FerretDB
  while MongoDB has data).

- New `snap run wekan.database mongodb|ferretdb` command (bin/wekan-database): switch which
  database WeKan runs on. `mongodb` also pauses auto-migration (migrate=off) so it does not
  switch back; `ferretdb` requires a non-empty SQLite first.

- Auto-migration can be paused: migration-pending now also returns "not pending" when
  `snap get migrate` == off. A migration that FAILS now runs fail_and_run_mongodb: delete the
  partial SQLite, set migrate=off, and exec mongodb-control so WeKan keeps working on MongoDB
  (no downtime, no retry loop). fall_back_to_mongodb likewise sets migrate=off instead of the
  done marker. `snap run wekan.migrate` re-enables migrate and retries.

- finish_success now restarts wekan.wekan so it reconnects to FerretDB after a successful
  migration instead of waiting for the now-stopped MongoDB.

Registered the `database` app in snapcraft.yaml and snapcraft-core26.yaml (also added the
previously-missing migrate/maintenance apps to core26).

Thanks to xet7.
2026-07-15 08:58:36 +03:00
Lauri Ojansivu 73ad55f696 Snap migration: skip dotted collections (FerretDB rejects them) + clean partial SQLite
Two bugs surfaced when the MongoDB 7 -> FerretDB migration finally connected (after the
db-eval fix):

1. FerretDB v1 rejects collection names containing a dot:
     invalid key: "attachments.chunks" (key must not contain '.' sign)
   Both importers tried to copy GridFS internals (attachments.chunks/.files, avatars.*,
   cfs_gridfs.*) and CollectionFS cfs.<bucket>.filerecord collections as TEXT, aborting the
   migration. Now the text phase skips ANY dotted collection: none of WeKan's real data
   collections contain a dot, and the dotted ones are GridFS internals (extracted in the file
   phase), CollectionFS filerecords (now turned into bare attachments/avatars records in the
   file phase via replaceOne upsert:true) or system.* collections.

2. The failed migration had already copied some text collections, leaving a NON-EMPTY but
   incomplete files/db/wekan.sqlite. ferretdb-has-data then saw it as "migrated", so
   mongodb-control disabled MongoDB and the snap tried to serve a half-migrated FerretDB. On
   any failure migration-control now runs discard_partial_ferretdb: stop the temp target
   FerretDB and delete the partial SQLite, so the snap cleanly keeps MongoDB and retries. The
   finish_success switch is also gated on it (`rc -eq 0 && finish_success`).

Source MongoDB data is never modified or deleted.

Thanks to xet7.
2026-07-15 08:58:36 +03:00
github-actions[bot] 1a4283e598 Bump versions for v9.93 2026-07-15 04:47:18 +00:00
Lauri Ojansivu 8ec4855d6c Updated ChangeLog. 2026-07-15 07:46:12 +03:00
Lauri Ojansivu 1088f31a0d Updated translations 2026-07-15 07:44:47 +03:00
Lauri Ojansivu c032c24065 CHANGELOG: new Upcoming section above v9.92 with the post-9.92 fixes
9.92 is released, so move everything committed after it into a fresh
"# Upcoming WeKan ® release" section above v9.92, organized by topic like the
previous releases (features, then bugs):

  Features: wekan.migrate command; maintenance mode + maintenance page.
  Bugs: db-eval driver resolution (ESM ignores NODE_PATH); decide FerretDB vs
        MongoDB from a non-empty SQLite database (not the marker); mongod-7
        readiness probe fast-fail.

v9.92 is restored to what it shipped, including its "migration-success marker is
now authoritative" bug entry (which the Upcoming "presence of a FerretDB SQLite
database" entry supersedes). No entry text changed; only relocated.
2026-07-15 07:41:11 +03:00
Lauri Ojansivu 88e692ef43 Snap migration: fast-fail the mongod-7 readiness probe when the temp mongod has died
ready_via_node waits up to 45s for the temporary source mongod to accept connections, to
allow a large MongoDB 6/7 database time to replay its journal (#6454). Add a liveness check:
if the mongod process (SRC_PIDFILE) has already exited - e.g. mongod 7 cannot open old
MongoDB 3.x data - stop waiting immediately and drop to the MongoDB 3.2 reader, instead of
pinging a dead process for the full timeout. Matters across many unattended 6.09 -> 9.x
upgrades. (With --fork, start_mongod usually already returns non-zero when mongod cannot open
the data; this also covers a mongod that started then died mid-probe.)

Thanks to xet7.
2026-07-15 07:32:58 +03:00
Lauri Ojansivu b9a9bf1593 Snap: require a NON-EMPTY FerretDB SQLite before treating the migration as done
For unattended upgrades at scale (6.09/MongoDB 3.2 -> 9.x/FerretDB across many servers), the
"did the migration succeed?" test must not be fooled by a 0-byte stub file.

- New shared helper snap-src/bin/ferretdb-has-data: exit 0 only if a *.sqlite file bigger than
  0 bytes exists in files/db. Used by mongodb-control, ferretdb-control and wekan-control in
  place of the previous "*.sqlite exists" glob, so the DB decision is based on a real,
  non-empty FerretDB database. (Deliberately does NOT require the -wal file, which SQLite may
  checkpoint away when FerretDB is stopped - that would cause false negatives at startup.)

- migration-control finish_success now verifies the non-empty SQLite database exists (and logs
  the WAL/shm sidecars) BEFORE switching the snap to FerretDB. If the importer returns success
  but wrote no data, it does not switch or set the done marker - MongoDB data is kept and the
  migration retries on the next start.

Thanks to xet7.
2026-07-15 07:32:58 +03:00
Lauri Ojansivu 8db071f94c Snap: fix db-eval driver resolution (ESM ignores NODE_PATH) - the root cause
db-eval is the Node helper the snap uses instead of mongosh to check whether MongoDB/FerretDB
is up, elect the replica-set primary, and probe mongod-7 readiness during migration. It did
`import { MongoClient } from 'mongodb'` while the wrapper set NODE_PATH to the bundled driver
-- but Node's ESM loader IGNORES NODE_PATH (only the CommonJS loader honors it). So the import
resolved nothing and db-eval exited BEFORE opening any connection, making every
ping/primary/rs-* check fail.

This single bug explains the whole family of failures seen this week:
  - WeKan looping "MongoDB not ready yet, retrying..." / "FerretDB not ready yet..." forever
    even though the database was running and listening;
  - replica-set initialisation failing;
  - the MongoDB -> FerretDB migration falling back to MongoDB 3.2 because the mongod-7
    readiness probe never connected (mongod 7 opened the data fine, but db-eval couldn't reach
    it), and 3.2 cannot read WiredTiger-7 files -> no FerretDB SQLite produced.

Proof from the migration source mongod log: mongod 7 reached "Waiting for connections" with
ZERO "Connection accepted" before the readiness timeout killed it; the only connection in the
file was the native `mongo` shell to mongod 3.2.

Fix: resolve the driver with createRequire (CommonJS resolution honors NODE_PATH and the
bundle layout), anchored inside the modern bundle (npm-mongo v6 first). Applied the same fix
to the standalone migrate-schema-v843.mjs and migrate-gridfs-to-fs.mjs tools.

Thanks to xet7.
2026-07-15 07:32:58 +03:00
Lauri Ojansivu 0ebf34aedc Snap: add wekan.migrate + wekan.maintenance commands and a maintenance page
wekan.migrate (bin/wekan-force-migrate): force a fresh MongoDB -> FerretDB migration,
ignoring the database setting and the migration marker. Removes any partial FerretDB SQLite +
resume checkpoint, sets database=mongodb, and starts wekan.mongodb so migration-control
re-reads the existing MongoDB (3 or 7) data and migrates again. Source MongoDB data untouched.

wekan.maintenance on|off (bin/wekan-maintenance): toggles a $SNAP_COMMON/.wekan-maintenance
marker. While present, mongodb-control / ferretdb-control do NOT auto-migrate or auto-disable,
so `snap start wekan.mongodb` or `snap start wekan.ferretdb` stays up and you can reach the
data over the MongoDB wire protocol on port 27019 (one at a time - they share the port).

Maintenance page (bin/wekan-maintenance-page.mjs): in maintenance mode wekan-control execs
this instead of WeKan; it serves an "under maintenance" page (HTTP 503) on the web port for
ALL URLs. It shows the Admin Panel product name if set (not "WeKan"), read from
$SNAP_COMMON/.productname.txt, which is cached while a database is running by wekan-control
(new db-eval `product-name` command) and by both migration importers - so it is available even
when both databases are stopped.

Registered `migrate` and `maintenance` apps in snapcraft.yaml.

Thanks to xet7.
2026-07-15 07:32:58 +03:00
Lauri Ojansivu 3f42d4d3f0 Snap: decide FerretDB vs MongoDB from SQLite data, not the migration marker
Regression fix. An earlier change made mongodb-control/ferretdb-control/wekan-control key
the "use FerretDB / disable MongoDB" decision off the .migration-to-ferretdb-done marker.
But migration-control ALSO writes that marker when the migration falls back (data
unreadable, tools missing) or when there is nothing to migrate - producing NO FerretDB
data. So on a server whose MongoDB 7 -> FerretDB migration failed:
  - mongodb-control saw the marker -> "migration already finished; disabling mongodb
    service" -> disabled MongoDB;
  - FerretDB SQLite (files/db) was EMPTY;
  - database=mongodb, so wekan-control waited on MongoDB -> "MongoDB not ready yet,
    retrying in 5 seconds..." forever, and wekan.mongodb refused to stay up.

Now all three scripts decide from ACTUAL DATA ON DISK: MongoDB is disabled / FerretDB is
forced ONLY when a *.sqlite database exists in files/db. An empty files/db means the
migration did not succeed, so mongod starts normally and WeKan keeps working (and the
migration can be retried). The marker still prevents re-running a finished migration.

Thanks to xet7.
2026-07-15 07:32:57 +03:00
github-actions[bot] 3e6a11d7f0 Bump versions for v9.92 2026-07-15 02:51:17 +00:00
Lauri Ojansivu 3bd9da70d4 Updated ChangeLog. 2026-07-15 05:50:09 +03:00
Lauri Ojansivu 8e47eca72e CHANGELOG: note disk-space guard is verified to work in snap confinement
Upcoming section: document that statfs is in snapd's default seccomp allow-list, so the
MongoDB -> FerretDB migration's free-space guard is active on Snap; quotactl is not used and
its absence is covered by the ENOSPC/EDQUOT write-failure fallback.
2026-07-15 05:46:05 +03:00
Lauri Ojansivu 2c895107a0 Snap migration: cite snapd seccomp allow-list in the disk-space guard comments
Document that statfs (and statfs64/fstatfs/fstatfs64/statvfs/fstatvfs) are in snapd's
default seccomp allow-list (snapcore/snapd interfaces/seccomp/template.go), so free-space
checks WORK inside a snap (which also has no per-snap disk quota by default, so statfs shows
real usable space). quotactl is NOT in the allow-list, but it is never called; a snapd
storage-quota group is still caught by the ENOSPC/EDQUOT write-failure path. Only Sandstorm
grains genuinely lack statfs (FUSE unimplemented, quotactl blocked). No behaviour change.
2026-07-15 05:44:32 +03:00
Lauri Ojansivu 22a4f419ce Snap: harden MongoDB 6/7 -> FerretDB importer + never start an empty FerretDB
migrate-mongodb-to-ferretdb.mjs (the modern MongoDB 6/7 driver importer that
migration-control runs, packaged from releases/):
  - Resolve the mongodb driver by probing the WeKan bundle with createRequire anchors and
    USE WHAT WORKS: prefer a v6+ driver that exposes GridFSBucket and speaks OP_MSG, since
    an older bundled v2 driver's OP_QUERY is rejected by FerretDB ("Unsupported OP_QUERY
    command: update"). A plain `import from 'mongodb'` could pick up that v2 driver. Fail
    fast with a clear message if no usable driver is found.
  - Bring it to parity with migrate-mongo3-to-ferretdb.mjs's data-safety and UX: measure
    total attachment/avatar bytes up front and STOP before extracting if they will not fit;
    if space runs out mid-run, stop + delete the partially migrated files + report how much
    more disk is needed (a full disk can corrupt the still-running source MongoDB);
    detect ENOSPC/EDQUOT where free space is not measurable (Sandstorm); show a live
    per-file progress bar; and translate the dashboard into the browser's language.
    Existing checkpoint/resume, schema upgrade, orphan fixing, compaction and index
    creation are unchanged.

wekan-control:
  - On startup, decide the database from what data actually exists on disk (FerretDB SQLite
    at $SNAP_COMMON/files/db, MongoDB WiredTiger at $SNAP_COMMON), not the `database` setting
    alone. If ferretdb is selected but its SQLite is empty while MongoDB still has data,
    revert to database=mongodb instead of starting an EMPTY FerretDB that would look like all
    data was lost, and tell the user to run the migration first.

Thanks to xet7.
2026-07-15 05:35:33 +03:00
Lauri Ojansivu f2a417047b Updated ChangeLog. 2026-07-15 05:30:08 +03:00
Lauri Ojansivu 48e47e6687 Snap: RAM-aware WiredTiger cache so MongoDB starts on < 34 GB RAM boxes (#6454)
Symptom: WeKan never started, looping "MongoDB not ready yet, retrying in 5 seconds..."
forever, even though mongod appeared to be running.

Cause: mongodb-control started mongod with a HARDCODED --wiredTigerCacheSizeGB 32. On any
server with less than ~34 GB RAM, mongod was OOM-killed seconds after startup. That
included the temporary mongod started to initialise the replica set: it died before
db-eval could reach it (log showed "child process started successfully" then 30 s of
failed pings), so the replica set was never initiated. The final mongod then ran with
--replSet rs0 but no config, no PRIMARY was elected, and wekan-control (which needs the
replica-set primary for Meteor change streams) waited forever.

Fixes in mongodb-control:
  - WiredTiger cache is now RAM-aware: ~50% of (MemTotal - 1 GB), the same formula mongod
    uses for its own default, capped at 32 GB, min 1 GB. Override with
    MONGODB_WIREDTIGER_CACHE_GB. Applied to both the temp replica-set-check mongod and the
    final mongod.
  - Temporary-mongod readiness wait raised 30 s -> 90 s so a large database that needs
    longer to replay its journal still gets its replica set initialised/reconfigured.

Fix in migration-control:
  - The temporary source mongod started to READ the data during a MongoDB -> FerretDB
    migration now uses a conservative RAM-aware cache (1/4 of (MemTotal - 1 GB), cap 8 GB,
    override MIGRATION_MONGOD_CACHE_GB), leaving room for the target FerretDB and the Node
    importer that run alongside it. Applied only to the mongod 7 (WiredTiger-only) read so
    the flag can never clash with a legacy MMAPv1 MongoDB 3.x dbpath.

Thanks to xet7.
2026-07-15 05:23:16 +03:00
Lauri Ojansivu 22804fdf38 Snap: make the MongoDB->FerretDB migration-done marker authoritative
Symptom: on an already-migrated install, `sudo snap start --enable wekan.ferretdb`
started FerretDB and then it immediately stopped itself, logging:
  "database is 'mongodb', not 'ferretdb'. Disabling ferretdb service."

Cause: every DB service keyed its behaviour off the `database` snap setting alone. If
that setting was never flipped to ferretdb (e.g. the migration's INTERNAL `snapctl set`
did not re-run the configure hook), ferretdb-control read `database=mongodb` and disabled
itself, so FerretDB could not be started by hand without first running
`snap set wekan database=ferretdb`.

Fix: the marker $SNAP_COMMON/.migration-to-ferretdb-done is now authoritative.
  - ferretdb-control: if the marker exists, repair database=ferretdb and keep running
    instead of self-disabling.
  - mongodb-control: if the marker exists, repair database=ferretdb and disable mongodb,
    BEFORE the migration-pending check so a finished migration is never re-attempted.
  - wekan-control: already forces ferretdb on the marker (previous commit).

Immediate recovery on an already-migrated install running an older release:
  sudo snap set wekan database=ferretdb

Thanks to xet7.
2026-07-15 04:58:44 +03:00
Lauri Ojansivu 87783b6f15 Snap: on startup, start the configured database instead of waiting forever
wekan-control (the wekan.wekan service) only WAITED for the database DATABASE points at
and never started a DB service, so if both wekan.ferretdb and wekan.mongodb were
stopped/disabled WeKan hung on "MongoDB not ready yet, retrying..." forever.

Now, on start, wekan-control:
  1. If the migration-success marker $SNAP_COMMON/.migration-to-ferretdb-done exists,
     forces database=ferretdb, then enables + starts wekan.ferretdb and stops + disables
     wekan.mongodb. This self-heals the case where the migration's INTERNAL `snapctl set`
     never re-ran the configure hook that flips the services.
  2. Before waiting, enables + starts whichever DB service is configured
     (snapctl start --enable = snap enable + snap start), so a merely-stopped DB is
     brought back up instead of WeKan waiting forever.

Uses the snap instance name so parallel installs target their own services.

Thanks to xet7.
2026-07-15 04:49:16 +03:00
Lauri Ojansivu 856743baef Updated ChangeLog. 2026-07-15 04:40:55 +03:00
Lauri Ojansivu 8a958650be CHANGELOG: new Upcoming section above v9.91 with the FerretDB post-migration fix
v9.91 was cut as a release, so move the Snap FerretDB service-flip fix out of it into a
fresh "# Upcoming WeKan ® release" section above v9.91. No entry text changed; only
relocated.
2026-07-15 04:39:29 +03:00
Lauri Ojansivu 3cc9dccb3c Snap: start FerretDB after migration (internal snapctl set skips the configure hook)
After a MongoDB -> FerretDB migration, WeKan hung on "MongoDB not ready yet, retrying..."
because no database was running: wekan.ferretdb stayed disabled and wekan.mongodb stayed
enabled-but-stopped.

Root cause: the wekan.ferretdb service disables itself while database=mongodb, and the
service flip that re-enables it lives in snap/hooks/configure. migration-control switches
the backend with an INTERNAL `snapctl set database=ferretdb`, but an internal snapctl set
does not re-run the configure hook, so the flip never happened.

Fix: finish_success now does the flip itself (mirroring the configure hook's ferretdb
branch): enable+start+restart wekan.ferretdb, then stop+disable wekan.mongodb, using the
snap instance name so parallel installs target their own services. FerretDB is started
before MongoDB is disabled so a DB is up first.

Immediate recovery on an already-migrated install:
  sudo snap start --enable wekan.ferretdb && sudo snap stop --disable wekan.mongodb
2026-07-15 04:38:52 +03:00
github-actions[bot] 6744fca2b3 Bump versions for v9.91 2026-07-15 00:25:43 +00:00
Lauri Ojansivu b9b6a55be6 Updated translations. 2026-07-15 03:24:36 +03:00
Lauri Ojansivu e7ec28b7a6 Updated ChangeLog. 2026-07-15 03:23:21 +03:00
Lauri Ojansivu db41dad70f CHANGELOG: add Upcoming section above v9.90; move post-release entries into it
v9.90 (2026-07-15) was already cut, but later work had been appended to it. Create a new
"# Upcoming WeKan ® release" section above v9.90 and move into it everything committed
after the v9.90 cut:
  - new features: Snap/Sandstorm migration dashboard (per-file progress + disk guard)
  - updates: i18n 10 more languages, native-name fixes, pull English-regression report
  - tests: dev server also frees the MongoDB port
  - bugs: MongoDB 3->FerretDB EJSON + stay-on-page; "Always show all code as plain text"
          reactivity race; i18n browser-language -> file mapping fixes
v9.90 is restored to its cut contents (MimeBleed CRITICAL + the original features/updates/
tests/bugs). No entry text changed; only relocated.
2026-07-15 03:20:51 +03:00
Lauri Ojansivu dc6839aef6 CHANGELOG: record the i18n language-detection fixes and additions
Document the Upcoming i18n work: the ja_JP->ja clobber fix, case/underscore-insensitive
language matching, Chinese subtag fallback + zh alias, the cmn tag typo fix (bugs), and
the 10 new selectable languages, native-name corrections, and the pull-translations
English-regression report (updates).
2026-07-15 03:14:08 +03:00
Lauri Ojansivu 2e39d80cf5 i18n: add 10 distinct language picker entries; fix English names to native
Add languages.js entries for translation files that had none (so they were pulled from
Transifex but never selectable): ca-valencia (Català (Valencià)), en_ID/en_SG/en_TR
(English (Indonesia/Singapore/Turkey)), es_CO (Español (Colombia)), fr-FR (Français
(France)), pt_PT (Português (Portugal)), ru-UA (Русский (Украина)), tk_TM (Türkmençe
(Türkmenistan)), wuu-Hans (吴语(简体)). Skipped km_KH and ru_RU (duplicate the existing
km-KH / ru-RU entries) and zh (already aliased to zh-Hans).

Fix language names that used the English name instead of the native one:
  ace  "Acehnese"            -> "Bahsa Acèh"
  cy   "Welsh"               -> "Cymraeg"
  cy-GB"Welsh (UK)"          -> "Cymraeg (Y Deyrnas Unedig)"
  af_ZA"Afrikaans (South Africa)" -> "Afrikaans (Suid-Afrika)"
2026-07-15 03:14:08 +03:00
Lauri Ojansivu 220d04e50d i18n: robust browser-language -> file matching (case/underscore-insensitive, subtag fallback)
Fix several browser-language -> translation-file mapping gaps:

- isLanguageSupported is now case-insensitive (requested) via a new TAPi18n.resolveTag()
  that maps any input to the canonical languages.js tag case-insensitively AND
  underscore<->hyphen-insensitively (so 'zh-hant'->'zh-Hant', 'JA-JP'->'ja-JP', browser
  'af-ZA'->legacy key 'af_ZA'). loadLanguage/setLanguage/ensureLanguageLoaded resolve
  through it, so the loaded file, the i18next code and the stored current tag all agree.
- Bare base codes with no plain-code file resolve via an alias map: 'zh' -> 'zh-Hans'
  (Chinese has only script/region files), so plain 'zh' gives Simplified, not English.
- Browser detection (client/lib/i18n.js) now strips trailing subtags progressively
  instead of jumping to the first segment: 'zh-Hans-CN' -> 'zh-Hans', 'zh-Hant-TW' ->
  'zh-Hant' (Chrome sends these), rather than -> 'zh' -> English.
- languages.js: fix the 'cmn' entry whose tag was the typo 'cnm' (and code 'cn'), which
  mismatched supportedLngs and broke selecting Mandarin; now tag/code = 'cmn'.

Adds i18n.test.js coverage for resolveTag, case-insensitive isLanguageSupported, the zh
alias, the underscore/hyphen match, and each Japanese variant loading its own file.
2026-07-15 03:14:08 +03:00
Lauri Ojansivu 4ab6b8561f i18n: give Japanese ja_JP its own file; report English regressions after pull
Two Transifex languages were writing to the same local file: .tx/config lang_map had
`ja_JP: ja`, which sent Transifex's ja_JP INTO imports/i18n/data/ja.i18n.json — the same
file the real Japanese (`ja`) uses. On `tx pull -a -f`, the emptier/untranslated ja_JP
overwrote ja.i18n.json, reverting Japanese strings to the English source. Map it to its
own file instead: `ja_JP: ja-JP` (-> ja-JP.i18n.json), matching languages.js which already
has three separate Japanese entries (ja -> ja.i18n.json, ja-JP -> ja-JP.i18n.json,
ja-Hira -> ja-HI.i18n.json). No other lang_map target collides. languages.js already loads
each to its own file, so no change needed there.

Also add releases/translations/report-english-regressions.mjs and call it from
pull-translations.sh: after pulling, it lists the language files where a previously
translated string reverted to exactly the English source (i.e. untranslated on Transifex),
so the regression is visible instead of being committed silently.
2026-07-15 03:14:08 +03:00
Lauri Ojansivu 97911f3e3e CHANGELOG: split migration dashboard features into "new features"
The MongoDB 3 -> FerretDB migration work had grown into one large bug bullet that
actually contained major features (live per-file progress bar, chunk-by-chunk streaming,
disk-space safety guard + rollback, Snap/Sandstorm/availability detection). Move those to
the "new features" section as their own bullet, and keep the EJSON-resolution fix +
stay-on-page hand-off as the bug entry (with a pointer to the feature bullet).
2026-07-15 03:14:08 +03:00
Lauri Ojansivu c3e36d4a2e Snap mongo3->FerretDB: disk guard keys off free-space availability, not platform
Previously the statfs free-space guards were gated on IS_SNAP. But a Snap container may
also be unable to report free space (statfs fails). Drive the behaviour off whether free
space is actually MEASURABLE instead:

- updateDiskFree: skip statfs only on Sandstorm (where it is known-unreliable — reports the
  host disk, not the grain quota); everywhere else ATTEMPT statfs, and on failure leave
  state.diskFree < 0 (unknown).
- ensureDiskForFile / the up-front total-size pre-check: run only when state.diskFree >= 0
  (measurable); otherwise skip and rely on an ENOSPC/EDQUOT write failure.
- Dashboard already hides the free-space figure and switches to "free space required for
  all files" whenever diskFree < 0, so a Snap-with-no-statfs degrades exactly like
  Sandstorm: try, and stop + delete + report on a write failure.

IS_SNAP is now only used for the platform log line. CHANGELOG updated.
2026-07-15 03:14:08 +03:00
Lauri Ojansivu 2676e8d434 Snap mongo3->FerretDB: Snap/Sandstorm-aware disk-space guard
The statfs free-space checks only make sense on the Snap (a real filesystem whose size we
can read). A Sandstorm grain cannot see its free space or quota — its FUSE layer does not
implement statfs and quotactl is blocked (confirmed in the Sandstorm source), and statfs
on the writable /var reports the host disk, not the grain quota. So:

- Detect Snap via $SNAP (IS_SNAP) and Sandstorm via SANDSTORM / SANDSTORM_RAW_MONGO_PATH /
  METEOR_SETTINGS.public.sandstorm (IS_SANDSTORM).
- Run the statfs up-front + mid-run free-space guards ONLY on Snap.
- On Sandstorm (and anything else), just try to migrate and detect "out of space" from an
  actual ENOSPC/EDQUOT write failure (in the streaming writer and in the file-loop catches),
  which triggers the same stop + delete-migrated-files + report rollback (onDiskAbort).
- Dashboard shows the free-space figure only when known (Snap); on Sandstorm it says free
  space is unknown and phrases the requirement as "free space required for all files".

Sandstorm source used only for research (grain cannot query disk/quota); not committed.
CHANGELOG updated.
2026-07-15 03:14:08 +03:00
Lauri Ojansivu e5e9f83650 CHANGELOG: document the "Always show all code as plain text" reactivity fix
Add the missing Upcoming bug entry for the alwaysShowCodeAsText fix (the viewer read a
stale ReactiveVar and never re-rendered, so the toggle did nothing; now set inside the
mentions helper from the same reactive setting it already reads). The MongoDB 3 ->
FerretDB migration progress/disk-guard improvements were already recorded in the mongo3
migration entry.
2026-07-15 03:14:08 +03:00
Lauri Ojansivu 96428115f4 Snap mongo3->FerretDB: per-file progress, streaming, and disk-space guard
Migration dashboard + migrator improvements for the MongoDB 3 -> FerretDB path:

- Live per-file progress: the file currently being extracted shows its name, size,
  "file N of TOTAL", a percent progress bar, and whether it is an attachment or an
  avatar. File-type words use WeKan's existing translations in the viewer's browser
  language (Accept-Language), read best-effort from the bundle with an English fallback.

- RAM-safe streaming: each GridFS file is streamed chunk-by-chunk (sorted by n) straight
  to disk via a spawned mongoexport + readline, with natural back-pressure, so a multi-GB
  attachment never lands in memory. The old approach buffered the whole file through
  mongoexport's 512 MB stdout maxBuffer and failed on big files.

- Disk-space guard (a full disk can corrupt the still-running source MongoDB): the
  dashboard shows remaining free space; the migrator measures the total size of all
  attachments+avatars up front and stops immediately if the volume cannot hold them; it
  also stops mid-run if free space drops below a safety margin (default 1 GB,
  MIGRATION_MIN_FREE_BYTES). On such a stop it deletes the partially-migrated files to
  free the space back, reports how many files were migrated before stopping, and shows how
  much more disk space is required to migrate all files.

Cannot run the snap here, so this is reviewed but not executed; needs a snap migration run
to verify. CHANGELOG updated.
2026-07-15 03:14:08 +03:00
Lauri Ojansivu c6a75de076 Snap mongo3->FerretDB: fix "EJSON.parse unavailable" (wrong anchor roots)
The MongoDB 3 migrator resolves WeKan's modern bson (with EJSON) and mongodb v6 by
anchoring require() inside the Meteor bundle. It anchored the sub-paths relative to the
script, but in the snap the script runs from $SNAP/bin/ while the bundle is at
$SNAP/programs/server/... (one level up) — so every anchor resolved
$SNAP/bin/programs/server/... (nonexistent) and fell through to the ancient meteor-spk
base bson 1.x with no EJSON, giving "FATAL: EJSON.parse unavailable" and aborting the
migration.

Build candidate bundle roots from $SNAP (env) and the script's parent dirs, then try the
known modern-bundle sub-paths under each (npm-mongo's nested v6 driver first, so the
ancient v2 that FerretDB rejects with OP_QUERY is never chosen). Node's module resolution
walks up from the '_.cjs' anchor to programs/server/npm/node_modules/bson.

Also: on successful hand-off the dashboard now reloads the SAME page the user was on
(the board URL) instead of forcing All Boards, so a reload during migration keeps you in
place. The dashboard already serves the progress page for every URL. CHANGELOG updated.
2026-07-15 03:14:08 +03:00
Lauri Ojansivu 1a9263326c Fix "Always show all code as plain text" not taking effect (reactivity race)
The viewer (mentions -> markdown) applies alwaysShowCodeAsText via a ReactiveVar
(Markdown.alwaysShowCodeAsText) that only a separate startup Tracker.autorun kept in
sync with the setting. But the mentions helper re-renders whenever the settings doc
changes (it reads getCurrentSetting for renderLinksAsPlainText/stripLinks), and that
re-render often runs BEFORE the bridge autorun updated the ReactiveVar — so the inner
markdown helper read the stale flag and rendered links/markdown normally (clickable),
and since mentions does not depend on that ReactiveVar it never re-rendered again.
Net effect: toggling "Always show all code as plain text" did nothing (links stayed
clickable, code stayed rendered), even after reload (same race on load).

Fix: set Markdown.alwaysShowCodeAsText inside the mentions helper, from the same
reactive getCurrentSetting() it already reads, BEFORE rendering the inner markdown
via Blaze.toHTML. The markdown helper now always reads the up-to-date flag in the same
synchronous render, so the toggle takes effect immediately in every rich-text field
(card titles, descriptions, comments, checklists). The startup autorun stays for any
direct +markdown use outside a viewer.
2026-07-15 03:14:08 +03:00
Lauri Ojansivu d923166a96 rebuild-wekan.sh: free the MongoDB port too when stopping a dev server
kill_meteor_on_port freed the app port (3000) and rspack dev-server port (8080) but not
Meteor's bundled MongoDB on app-port+1 (3001). When the meteor parent is SIGKILLed its
mongo child is often orphaned and keeps holding 3001, so the next `meteor run` failed
with "Unexpected mongo exit code 48 ... port was closed, or was already taken". Also
free app-port+1 (which additionally clears a leftover standalone test mongod on :3001),
include it in the readiness guard/wait, and in the SIGKILL escalation. CHANGELOG noted.
2026-07-15 03:14:08 +03:00
github-actions[bot] 0b8564d8c8 Bump versions for v9.90 2026-07-14 21:10:32 +00:00
Lauri Ojansivu a1e868384e Updated ChangeLog. 2026-07-15 00:09:04 +03:00
Lauri Ojansivu 1483c271ff rebuild-wekan.bat: parity — run :3000 test server from precompiled .build\bundle
Bring the Windows batch runner to parity with rebuild-wekan.sh: the :3000 server for
Node E2E + Playwright now runs from the precompiled .build\bundle instead of
`meteor run`, so no recompile. New :start_bundle_server subroutine (used by both the
parallel and sequential "Run ALL tests" flows):

- Builds .build\bundle once if missing (meteor build .build --directory).
- Resolves Meteor's bundled node via `meteor node -e process.execPath` and the sibling
  dev_bundle mongod; runs the bundle with that node (native-module ABI match).
- Installs the bundle's programs\server npm deps once.
- Starts Meteor's mongod on :3001 (db "meteor", matching what the tests seed), or reuses
  a MongoDB already listening there; stops it on exit only if this run started it.
- Starts `node .build\bundle\main.js` with MONGO_URL/ROOT_URL/PORT/WRITABLE_PATH set in
  the parent scope (child inherits them) then unset so Mocha/E2E do not inherit MONGO_URL.

Mocha still uses `meteor test` (:3100, its own build) — it cannot run from a production
bundle. Intro text and cleanup updated; CHANGELOG notes the parity. Untested on Windows
here (no cmd available); needs one Windows verification run.
2026-07-15 00:03:48 +03:00
Lauri Ojansivu 53c6d20342 CHANGELOG: reorganize Upcoming into features / updates / tests / bugs
Group the Upcoming section under the standard headers: CRITICAL SECURITY ISSUE
(MimeBleed), new features (import/export privacy, always-show-code, render-links),
updates (webhook card description, Sandstorm docs), tests (yargs mocha crash, live
progress, .build/bundle reuse), bugs (Sandstorm migrated-grain Admin Panel, Version
storage engine). Also fold the bundle-server "meteor" vs "wekan" database fix into
the .build/bundle test entry.
2026-07-14 23:50:27 +03:00
Lauri Ojansivu 434e7dd1e2 rebuild-wekan.sh: bundle test server must use the "meteor" DB, not "wekan"
The bundle-based :3000 server pointed at mongodb://127.0.0.1:3001/wekan, but the
Playwright and Node E2E tests seed their users/boards straight into
mongodb://127.0.0.1:3001/meteor (tests/playwright/helpers/db.js,
tests/e2e/list-regressions.js) — the DB name Meteor's built-in mongo used under the
old `meteor run`. Same mongod, different database: the app read an empty DB while the
tests seeded another, so every test needing seeded data failed (only the ~9 per browser
that need no seed passed). Point the bundle server at /meteor so app and tests share
one database again.
2026-07-14 23:15:35 +03:00
Lauri Ojansivu a4505f9553 CHANGELOG: record the test-run readiness-hang fix and .build/bundle gate
Complete the Upcoming test-infrastructure notes: the readiness poll that hung on
Meteor's :3000 proxy (progress froze at [0s]) is now fixed with a curl timeout and a
wall-clock-bounded wait, and "Run ALL tests" checks for .build/bundle specifically and
builds it once if missing. Also note the .sh (bundle) vs .bat (meteor run) split in the
server-start wait item.
2026-07-14 22:48:04 +03:00
Lauri Ojansivu aa568e8087 rebuild-wekan.sh: gate tests on .build/bundle existence, not just .build
Before running ALL tests, check for the .build/bundle directory specifically (the
:3000 test server runs it). If it is missing (never built, or a previous build left
.build without a bundle), build it with `meteor build .build --directory` first.
Previously it only checked the .build parent, so a missing/partial bundle was not
rebuilt here (only caught later by the main.js check).
2026-07-14 22:46:22 +03:00
Lauri Ojansivu 5894b000a2 rebuild-wekan.sh: run :3000 test server from precompiled .build/bundle; live scrolling
"Run ALL tests" started the :3000 server with `meteor run`, which recompiles into
.meteor/local even after you already built .build/bundle. Node E2E + Playwright only
need a live WeKan over HTTP, so start that server from the precompiled bundle instead:

- `node .build/bundle/main.js` with Meteor's bundled node (matching native-module ABI),
  MONGO_URL to Meteor's bundled mongod on :3001 (or reuse a MongoDB already listening
  there). Boots in seconds, no recompile. One-time `programs/server` npm install runs
  if missing. mongod is stopped on exit only if this run started it.
- The server boot log and the npm install now STREAM LIVE (scrolling: tail -n 0 -f /
  tee) so you see exactly what is happening instead of a single frozen summary line.
- Sequential mode runs suites strictly one at a time, each streaming its own output;
  the parallel-only combined refreshing table is now skipped in sequential mode.

Mocha still uses `meteor test` (its own .meteor/local-test build) — its in-process
server-side tests cannot run from a production bundle, so that one build is unavoidable
and copying the bundle would not help it. The script warns the bundle is run as-is, so
rebuild it after source changes. CHANGELOG updated.
2026-07-14 22:43:04 +03:00
Lauri Ojansivu a7374ff8a4 rebuild-wekan.sh: stream each test live in sequential mode
In sequential mode only one suite runs at a time, so there is no reason to hide its
output in a log and show only a counter. Refactor the job runner: extract run_job_body
(the actual suite command) and, in sequential mode, pipe it through tee straight to the
console — you now see every test tick by one-by-one as the reporter prints it, then a
final PASS/FAIL + count line. Parallel mode still runs jobs in the background to logs
(the combined table reads them). tee is on the right of the pipe so the suite's exit
code is captured in STATDIR, not tee's.
2026-07-14 22:31:15 +03:00
Lauri Ojansivu 9db870a087 rebuild-wekan: clarify that the test server "build" is Meteor recompiling
The "Building WeKan" message during Run ALL tests suggested a fresh full build even
though the user had already built WeKan. Reword it: the tests start a live
`meteor run --port 3000`, and Meteor recompiles into .meteor/local on start only for
inputs that changed since the last build (sources / node_modules), then caches it.
No behavior change, message only.
2026-07-14 22:24:15 +03:00
Lauri Ojansivu 88b181c18e rebuild-wekan: fix readiness poll hanging on Meteor's :3000 proxy
The "Run ALL tests" server-readiness wait used `curl http://127.0.0.1:3000/sign-in`
with no timeout. Meteor binds the :3000 proxy early and accepts the TCP connection
while the app is still building, but does not send an HTTP response until the build
finishes. So curl blocked on that first connection for the whole build: the loop
never advanced and the new progress line froze at [0s] with only the log header,
even though the build was progressing in the log.

Give curl --connect-timeout 2 --max-time 4 so each poll returns quickly (not-ready
during the build, ready once /sign-in actually answers). The elapsed seconds and the
newest build step now refresh every few seconds as intended. Bound the wait by
wall-clock time (.sh: 1200s; .bat: ~240 polls) instead of a fixed count, since polls
now take a few seconds each. Also add the timeout to the Playwright-ALL precheck.
2026-07-14 22:10:45 +03:00
Lauri Ojansivu cc2a317236 rebuild-wekan: show live test progress in every path (.sh and .bat)
Audited both runner scripts and closed every place that used to sit silent for
minutes during test runs:

- Server first-build wait (Run ALL tests, both modes): .sh shows elapsed seconds +
  newest build step from the server log in place; .bat shows elapsed seconds every
  ~10s and points at the live build log (echoing arbitrary build lines is unsafe on
  cmd because they contain > < | &).

- Sequential per-job (option 2): .sh prints a live elapsed + pass/fail counter per
  job and a final PASS/FAIL line; .bat now runs each job in its own minimized window
  (reusing the proven parallel start-commands + .done-<key> flags) and polls a live
  pass counter one job at a time, instead of redirecting silently to a log.

- Playwright ALL browsers single menu item (.sh option 10 / run_playwright_parallel):
  streams each browser's list reporter live via tee while still saving the log;
  PIPESTATUS[0] keeps per-browser pass/fail accurate through the pipe.

Single-suite items (Mocha, import, E2E, single Playwright) and the parallel combined
progress table already showed progress and are unchanged. CHANGELOG updated.
2026-07-14 21:35:40 +03:00
Lauri Ojansivu 9f5e459dda CHANGELOG: document live test-run progress display in rebuild-wekan.sh
Record the Upcoming test-infrastructure change: "Run ALL tests" now shows elapsed
time + newest build step during the server build, and a live per-job pass/fail
counter in sequential mode, instead of sitting silent for minutes.
2026-07-14 21:23:07 +03:00
Lauri Ojansivu 02b3bed5ce rebuild-wekan.sh: show live progress during test build and sequential jobs
Running ALL tests (menu options 1/2) was silent for minutes in two places:

- While the :3000 WeKan server did its first rspack build, the readiness wait only
  printed dots. Replace that with an in-place line showing elapsed seconds and the
  newest build step from the server log (=> Compiled Rspack..., => Started MongoDB,
  => Started your app), so the build is visibly progressing.

- In sequential mode each job blocks until it finishes, so nothing showed while a
  job built and ran. Add a live in-place counter per job (elapsed seconds + tests
  passed/failed, from count_pass/count_fail on the job log) and a final PASS/FAIL
  line when it completes.

The parallel-mode combined progress table is unchanged.
2026-07-14 21:22:46 +03:00
Lauri Ojansivu ac69e0e171 CHANGELOG: record the confirmed yargs test-build fix and outcome
Update the "Test infrastructure" Upcoming entry with the confirmed root cause and
resolution: the second-stage boot crash was node_modules/yargs-parser/build/lib/index.js
using the guarded ternary `const require = createRequire ? … : undefined`, fixed by
generalizing the createRequire removal to a line-wise match (run before import.meta.url
expansion) and broadening the scan from node_modules/yargs to yargs and its ESM deps.
Also note the three server test files that were present but missing from the curated
server/lib/tests/index.js loader and are now registered. Verified: 450 passing, 0 failing
(411 before the three files were wired in).
2026-07-14 21:07:43 +03:00
Lauri Ojansivu f4d05feb0a patch-yargs-dirname: also patch yargs-parser; register new server tests
The Mocha (server-side) test bundle crashed at boot with 0 tests run because
yargs and its ESM dependencies are dragged into the Meteor test server bundle,
where Meteor 3 wraps every module in a CommonJS function and their native-ESM
constructs (import.meta, `const __dirname`, `const require = createRequire(...)`)
are illegal and crash the bundle before any test runs.

Two gaps remained in scripts/patch-yargs-dirname.cjs:

- The `const require = createRequire(...)` removal (and its trigger) only matched
  the direct-call form. yargs-parser/build/lib/index.js uses the guarded ternary
  `const require = createRequire ? createRequire(import.meta.url) : undefined;`,
  which slipped through and crashed at boot with "Identifier 'require' has already
  been declared". Generalized the match to line-wise `const require = ...createRequire...;`.

- The scan only walked node_modules/yargs, so yargs-parser (the actual offender)
  was never patched. Broadened the scan to yargs and its ESM dependency packages.

Also register the three server test files that were present but missing from the
curated server/lib/tests/index.js (they never ran): the MimeBleed file-validation
bypass regression, the import/export privacy settings, and the impersonation report
query. Server suite now boots and runs (411 passing).

CHANGELOG Upcoming documents the bug and the two-stage debugging journey.
2026-07-14 21:02:26 +03:00
Lauri Ojansivu c21f3d86ef patch-yargs-dirname: fix createRequire mangling that broke the Mocha test build
The yargs postinstall patch expanded import.meta.url -> require('url').pathToFileURL(...)
BEFORE removing the const require = createRequire(...) call. The paren-naive removal
regex createRequire([^)]*) then stopped at the first ) of the injected require('url'),
replacing only part of the statement and leaving a dangling
  /* Meteor: use wrapper require */.pathToFileURL(__filename).href));
in yargs' esm.mjs. That is invalid JS (a leading .pathToFileURL after a comment), so
Meteor's reify parser threw 'Unexpected token (19:33)' when the test server bundle pulled
yargs in -- meteor test reported 0 tests, even though every repo source file was fine.

Fix: remove the createRequire call BEFORE expanding import.meta.url (so the injected
parens can't break the match), and add a repair rule + trigger so re-running the script
collapses the dangling leftover in already-corrupted node_modules/yargs files back to the
marker. Fresh and already-broken files both end valid.
2026-07-14 20:43:01 +03:00
Lauri Ojansivu 5b697f983b Fix test failures from this session's changes
- models/fileValidation.js: a stray BOM (U+FEFF) inside the looksLikeDangerousMarkup
  regex character class broke the server test build with a Babel 'Unexpected token'
  syntax error, so Mocha ran 0 tests. JS \s already matches U+FEFF, so the explicit
  BOM was redundant; use plain \s*.
- models/import.js: importBoard awaited assertImportEnabled() BEFORE the switch that
  check()s the "board" argument. Meteor's audit-argument-checks tracks checks on the
  async context, so awaiting first made the later check(board) not count, throwing
  'Did not check() all arguments during call to importBoard' -- which broke the WeKan
  JSON import (#21) and Excel import (#25) Playwright tests. Check "board" up front
  (Match.OneOf(Object, Array)) before the await; the per-source switch still does its
  specific check.
- server/publications/activities.js: move the disableActivities gate to AFTER the
  check() calls so the argument-checks audit is satisfied when the toggle is on
  (latent: it would have thrown 'did not check all arguments' with activities off).
2026-07-14 19:00:35 +03:00
Lauri Ojansivu faf7ff6efa Snap: migrate ANY MongoDB (3/7/other) to FerretDB SQLite, then shut down MongoDB (#6454)
Supersede the earlier 'keep MongoDB 7' approach: the WeKan snap now moves EVERY
existing MongoDB database onto FerretDB (SQLite) on first boot after an upgrade,
then shuts MongoDB down so only WeKan (Node.js) + FerretDB (SQLite) run. Text data
goes into SQLite; CollectionFS + Meteor-Files GridFS attachments/avatars are
extracted to files/attachments and files/avatars.

migration-control now routes by how the source can be READ, not by keep-vs-migrate:
- mongod 7 can open it (modern MongoDB 6/7, incl. a DB earlier migrated up from 3.x)
  -> keep that mongod as source, run the modern driver importer
  (migrate-mongodb-to-ferretdb.mjs) into a temp FerretDB SQLite target.
- else mongod 3.2 can open it (old MongoDB 3.x) -> run migrate-mongo3-to-ferretdb.mjs
  (legacy mongoexport CLI).
- else (unreadable/corrupt, or tools missing) -> fall back to a normal MongoDB start
  so the service is never left dead, and retry next boot.

On success: mark done + snapctl set database=ferretdb; mongodb-control then stops and
disables the MongoDB service. This also fixes the reported failure where a healthy
MongoDB 7 database was misdetected as MongoDB 3.x, the 3.x path failed, and — because
mongodb-control exec's this script — mongod never started and the service looped.
Probe readiness lengthened 20s -> 45s; the temp source mongod is tracked by pidfile
and force-stopped so it never leaves the dbpath locked. MongoDB data is never
modified or deleted; the snap only switches to FerretDB once migration succeeds.
2026-07-14 18:09:03 +03:00
Lauri Ojansivu 3a4f3c896e Migration dashboard: use Admin Panel product name instead of WeKan
Both migration dashboards (Snap MongoDB-3 importer and the Sandstorm/general
MongoDB importer) hard-coded 'WeKan'. If the migrated database has a product name
set in Admin Panel (settings.productName), the dashboard now shows that name and
does not mention WeKan; otherwise it defaults to WeKan.

- snap-src/bin/migrate-mongo3-to-ferretdb.mjs: read settings.productName via
  mongoexport early in run() into state.product; title/h1/complete message use it.
  The importer->app hand-off poll no longer keys off the product-dependent title
  string; it checks a stable '<!--migration-dashboard-->' marker instead.
- releases/migrate-mongodb-to-ferretdb.mjs: read settings.productName via the driver
  right after the source connects into state.product; the HTML __PRODUCT__ placeholder
  is substituted in buildHtml(). Header clarified to FerretDB (SQLite).
2026-07-14 18:02:43 +03:00
Lauri Ojansivu 0514a2fa5d Snap: don't misdetect MongoDB 7 as MongoDB 3.x on upgrade (#6454)
The one-time MongoDB 3 -> FerretDB migration check probed whether mongod 7 could
open the existing data and, if that short probe failed for ANY reason (journal
recovery, stale mongod.lock, slow disk, large oplog), assumed the data was
MongoDB 3.x. A healthy MongoDB 7 database that failed the probe was then sent down
the 3.x path, where mongod 3.2 also could not open it, logging 'could not start
migratemongo mongod on the MongoDB 3.x data'. Because mongodb-control exec's the
migration script, mongod never started -- the MongoDB service failed to activate
and looped on every restart.

Fix: only run the 3.x migration when the data is POSITIVELY confirmed as MongoDB
3.x (mongod 3.2 can actually open it). In every other case -- MongoDB 6/7, data the
probe could not read, or missing tools -- fall back to a normal MongoDB 7 start in
the same service activation (set the marker + exec mongodb-control) instead of
exiting with nothing running. Also: lengthen the mongod-7 readiness probe 20s -> 45s
so large databases needing recovery are not misread, and track the temporary probe
mongod by pidfile + force-stop it so it never leaves the dbpath WiredTiger lock held.
The MongoDB data is never modified or deleted.
2026-07-14 17:42:44 +03:00
Lauri Ojansivu eb92574650 Updated ChangeLog. 2026-07-14 17:32:09 +03:00
Lauri Ojansivu 422daa6a0c Update Sandstorm Docs about how to install test version.
Thanks to xet7 !
2026-07-14 17:28:59 +03:00
Lauri Ojansivu 339729fd95 Tests for newest Security/Reports features (positive + negative)
- client/lib/tests/renderLinksPlainText.tests.js: the 'render links as plain text'
  toggle and XSS hardening. Config assertions (stripLinks adds <a> to FORBID_TAGS,
  default does not, KEEP_CONTENT) plus real sanitizeHTML() behavior: <a> stripped to
  its text when stripLinks, kept by default, and javascript: hrefs / event handlers /
  <script> removed regardless.
- client/lib/tests/alwaysShowCodeAsText.tests.js: escapeHtmlSource (exposed on the
  Markdown export) escapes <script>/comments/quotes/ampersand-first so code is shown
  not executed; leaves plain text and empty strings unchanged.
- server/lib/tests/impersonationReportQuery.tests.js: the Impersonation report search
  selector (extracted to models/lib/impersonationReportQuery.js so it is testable
  without re-registering the publication) builds a case-insensitive $or across the
  identity fields, escapes regex metacharacters, and is empty for a blank term.

The MimeBleed fix (fileValidationBypass.security.tests.js), SortBleed
(boards.security.tests.js) and import/export anonymization
(importExportSecurity.tests.js) already carry positive + negative tests.
2026-07-14 17:01:35 +03:00
Lauri Ojansivu f6ba472f67 MimeBleed (GHSA-jhph-whx8-wq6p): file-upload MIME bypass -> stored XSS
WeKan's upload validation (models/fileValidation.js) detects a file's real MIME
type by running the Unix 'file' command. On minimal Docker/Alpine images without
'file', detectMimeFromFile() silently returned undefined and the code fell back to
the CLIENT-supplied fileObj.type. An authenticated board member (WITH_API=true)
could upload HTML+JS while setting fileType: image/png; the spoofed type is not on
the dangerous-MIME deny-list, so the dangerous-content scan was skipped and the file
was stored, yielding stored XSS served under the WeKan origin (CWE-434).

Fix: the client-supplied type can no longer gate the safety scan. When content-based
detection via 'file' is unavailable, fall back to a dependency-free JS content sniff
(looksLikeDangerousMarkup) that inspects the real bytes for HTML/SVG/XML/<script>
signatures and forces the dangerous-content scan regardless of the claimed MIME, so a
spoofed image/png that is really HTML+JS is rejected. The sniff matches only definitive
markup, so genuine binary uploads (real PNG/JPEG/PDF, incl. large ones) are unaffected.
Also log a one-time warning when 'file' is missing (previously silent).

Regression test server/lib/tests/fileValidationBypass.security.tests.js covers the
spoofed dangerous uploads and safe binaries.

CVSS:3.1 8.3 High (AV:N/AC:L/PR:L/UI:R/S:C/C:H/I:H/A:N). Thanks to HNUfwj and xet7.
2026-07-14 16:49:48 +03:00
Lauri Ojansivu efbd540b48 Updated translations. 2026-07-14 16:38:39 +03:00
Lauri Ojansivu 592d803924 Notifications feature: drop GDPR-specific wording
Disabling activities/notifications/watch can serve any law or policy, not only
GDPR. Remove GDPR mentions from the code comments and the en.i18n.json toggle
descriptions (and the Admin Panel docs), keeping the neutral #5820 reference.
2026-07-14 14:22:58 +03:00
Lauri Ojansivu 86142f542c Outgoing webhooks: include card description in payload (#5143)
A card description was recorded in the activity log (a-changedDescription, #5482)
but never added to the outgoing-webhook / notification params, so integrations got
an event with no description text.

The Activities.after.insert payload now sets params.description (the card's current
description, only when non-empty) for every card event, and forwards the activity's
oldValue/value alongside the existing timeValue/timeOldValue so a description change
carries the before/after text. New fields are additive and backward-compatible.
2026-07-14 14:20:22 +03:00
Lauri Ojansivu a13ce5ef09 Admin Panel / Reports / Impersonation: paginated impersonation log report
Impersonation events are already recorded in the impersonatedUsers collection
whenever an admin impersonates a user (e.g. to export a private board). Surface
them as a new admin report, newest-first, with the same server-side search +
pagination as the other reports.

- server/publications/impersonationReport.js: impersonationReport publication
  (admin-only, sort createdAt -1, limit/skip, $or search over admin/user/board/
  attachment ids and reason) + getImpersonationReportCount method. Also publishes
  the referenced admin/impersonated user docs (same fields the People panel uses)
  so usernames resolve and the Edit user popup has its data.
- adminReports.jade/.js: new Impersonation side-menu entry, sub-template (Date,
  Admin, Impersonated user, Board, Reason), pagination + search wired through the
  shared reportConfig. Clicking a username opens the same editUser popup as
  Admin Panel / People.
- i18n: impersonationReportTitle, impersonation-admin, impersonation-user, reason.
2026-07-14 14:10:38 +03:00
Lauri Ojansivu 247522484c Tests + docs for Admin Panel / Features Security and Notifications options
- server/lib/tests/importExportSecurity.tests.js: positive and negative unit
  tests for the anonymization helpers (map building, user-doc scrubbing, @mention
  rewriting that ignores unknown handles and email addresses, requestedBy/assignedBy
  identity replacement, and safe no-ops on empty input).
- docs/Features/Admin-Panel/Admin-Panel.md: new Features tab section documenting the
  Performance, Security (rich-text hardening + import/export privacy) and
  Notifications (GDPR) toggles.
2026-07-14 14:03:32 +03:00
Lauri Ojansivu f1cc8daebf Admin Panel / Features / Notifications: GDPR activity/notification controls (#5820)
New Notifications category with three GDPR toggles (all default off), enforced
server-side:

- Disable all activities: activity-feed entries are neither recorded
  (Activities.before.insert returns false to cancel) nor shown (the activities
  publication returns nothing, hiding existing and new entries).
- Disable all notifications: the Activities.after.insert dispatch hook returns
  early, so no watch notifications are sent; activity recording is unaffected.
- Disable watch: the watch() method rejects any watch-level change, and the board
  header watch button is hidden.

A synchronously-readable server cache (models/lib/featureFlags.js, kept current by
a Settings observer) lets the sync before.insert hook read the flags without
awaiting. Adds settings disableActivities, disableNotifications, disableWatch,
published in the public setting, plus global Blaze helpers activitiesDisabled /
watchDisabled for UI hiding.
2026-07-14 14:00:49 +03:00
Lauri Ojansivu 06fdede782 Admin Panel / Features / Security: import/export privacy controls
Six new optional toggles (all default off) governing how boards and user data
cross the WeKan boundary, enforced server-side so they cannot be bypassed from
the client:

- Disable all import / Disable all export: master switches that turn off every
  import/export feature. importBoard and cloneBoard call assertImportEnabled;
  every Exporter build()/buildStream() call assertExportEnabled. The import and
  export menu options are hidden in the UI via global importDisabled/exportDisabled
  Blaze helpers.
- Disable import avatars / Disable export avatars: never carry avatars into/out of
  WeKan. Import is gated at the single localizeAvatarFromBuffer choke point (covers
  WeKan JSON import, LDAP, OIDC/OAuth2 login sync and board-open localization) plus
  Trello inlineMemberAvatars; export skips the base64 avatar embed + avatarUrl in
  both Exporter paths.
- Anonymize import users / Anonymize export users: replace username/fullname/initials
  with counter placeholders (user1, user2, ...), drop avatars, and rewrite @username
  mentions + requestedBy/assignedBy in card/comment text. The placeholder word "user"
  is translated to the current user language. Export covers both build() and the
  streaming buildStream() (which does an id-only pre-scan so mentions streamed before
  the users array resolve to matching labels); import scrubs the incoming board in
  WekanCreator before any placeholder user or card is created.

New shared server helper models/lib/importExportSecurity.js holds the settings
read, guards, anonymization map builder and text rewriter. Adds settings
disableAllImport, disableAllExport, disableImportAvatars, disableExportAvatars,
anonymizeImportUsers, anonymizeExportUsers, published in the public setting.
2026-07-14 13:53:11 +03:00
Lauri Ojansivu 3c98336445 i18n: Finnish translations for Admin Panel / Features / Security strings
Translate the new render-links-as-plain-text-description, always-show-code-as-text
and always-show-code-as-text-description strings to Finnish, matching existing
terminology (tarkistuslistat, klikattava, 'Kun käytössä...', 'Oletuksena pois
käytöstä...').
2026-07-14 13:25:50 +03:00
Lauri Ojansivu daeaa2b9d8 Updated translations. 2026-07-14 13:23:12 +03:00
Lauri Ojansivu 38ce497887 Admin Panel / Features / Security: "Always show all code as plain text"
New optional toggle under Admin Panel / Features / Security. When enabled,
rich text is never rendered as markdown or HTML -- the entire source is shown
as escaped plain text in every rich text field (board and card titles,
descriptions, comments, checklists, etc.), so hidden content is always
revealed: HTML comments (<!-- -->), the target URL inside a markdown link,
JavaScript and any other code. All code is always visible, not clickable, and
not running.

This extends the existing invisiblebleed protection (which already showed raw
source for description-less markdown links) to all content, and complements
the "Render links as plain text" toggle.

Implementation:
- New global setting alwaysShowCodeAsText (models/settings.js), published in
  the public setting publication, default off.
- Admin Panel / Features / Security gains a second materialCheckBox toggle.
- The markdown helper has the raw text, so the decision lives there. Because
  the wekan-markdown package cannot import app code, the setting is bridged via
  a ReactiveVar on the exported Markdown object; the rich text viewer
  (editor.js) keeps it in sync with the setting reactively, and the markdown
  helper reads it and renders the fully HTML-escaped source in a <pre> when on.
  Full escaping (not DOMPurify stripping) ensures tags like <script> are shown
  as text rather than removed. The description-less-link branch now uses the
  same full escaping so it too reveals all source.
2026-07-14 13:17:33 +03:00
Lauri Ojansivu 9787445fbb Updated translations. 2026-07-14 12:56:28 +03:00
Lauri Ojansivu f68c91d102 Admin Panel / Features: optional "Render links as plain text" toggle
New optional security feature under Admin Panel / Features / Security. When
enabled, all links -- both markdown links like [label](url) and raw HTML
<a href> tags -- are always shown as plain, non-clickable text in every rich
text field (board and card titles, descriptions, comments, checklists, etc.),
so a link can never be clicked and cannot present misleading anchor text.

This is a hardening option on top of the existing XSS sanitization (which
already strips javascript:/data: schemes, event-handler attributes and
dangerous tags); it addresses #6453, where a board title rendered as a
clickable link. Default off, so links stay clickable.

Implementation:
- New global setting renderLinksAsPlainText (models/settings.js), published in
  the public setting publication.
- Admin Panel / Features gains a Security category with a materialCheckBox
  toggle that saves the setting immediately.
- The shared DOMPurify sanitizer takes a { stripLinks } option that forbids the
  <a> tag while keeping its inner text (KEEP_CONTENT), so links collapse to
  plain text. The rich text viewer (mentions helper in editor.js) passes
  stripLinks based on the setting, gated reactively so toggling re-renders.
2026-07-14 12:51:44 +03:00
Lauri Ojansivu 620b9be180 Updated translations. 2026-07-14 12:09:03 +03:00
Lauri Ojansivu 0ed35e00db Sandstorm: WeKan Admin Panel always available in migrated grains
On Sandstorm the grain owner (Sandstorm 'configure' permission) maps to a
WeKan admin, which gates the Admin Panel and its Attachments / Sandstorm
cleanup tools. A new grain worked because Users.after.insert derives the role
for the freshly inserted user, but a grain migrated from an older WeKan
already contains the user, so that insert hook never runs. Sandstorm
auto-login uses connection.setUserId() (bypassing accounts-base, so
Accounts.onLogin never fires), and the remaining observeChanges hook on
services.sandstorm only fires when that field actually changes on login. When
the migrated user's stored permissions already equal the grain's current
permissions, the login $set is a no-op with no oplog entry, so isAdmin was
never derived and the owner had no Admin Panel.

Reconcile at grain startup (a migrated grain reboots once migration
completes): grant WeKan admin to every Sandstorm user whose stored
permissions include 'configure'. Promote only, never revoke here (that is the
change hook's job on a real permission change), so a stale/empty stored
permission set can never lock the owner out of the Admin Panel.
2026-07-13 20:44:17 +03:00
Lauri Ojansivu 5a90a1987a Admin Panel / Version: show MongoDB storage engine with per-db credentials
The storage engine was read only from serverStatus, which requires the
cluster-level clusterMonitor role. A per-database WeKan user (readWrite on
the wekan db only, as in docs/Platforms/FOSS/Docker/Meteor3/) is not
authorized to run it, so it was rejected and the field stayed 'unknown'.

Fall back to a $collStats aggregation, which needs only the collStats action
that read/readWrite already grant, and read the real engine (wiredTiger /
inMemory) from storageStats. The MongoDB compatible version and Database
commit were already correct: they come from buildInfo, which needs no
special privileges.
2026-07-13 20:30:16 +03:00
github-actions[bot] f1f6fecf44 Bump versions for v9.89 2026-07-13 16:25:58 +00:00
Lauri Ojansivu 6cb4ae2d64 Updated ChangeLog. 2026-07-13 19:24:47 +03:00
Lauri Ojansivu 3ecb90fc04 package-lock.json: record hasInstallScript for yargs postinstall patch
The postinstall script (scripts/patch-yargs-dirname.cjs) added in 6b409c5da
to fix the Meteor/Mocha test boot crash makes npm mark the root package with
hasInstallScript: true. Sync the lockfile to match package.json.
2026-07-13 19:19:10 +03:00
Lauri Ojansivu dc135f6e7d SortBleed (GHSA-xm8x-c8wg-jhmf): board sort allow rule privilege escalation
A low-privilege (comment-only / read-only) board member could escalate to
board admin and take over a private board via the board 'sort' collection
allow rule. To support drag-to-reorder, a second Boards.allow({ update })
rule returned true for any board member whenever the update touched the
'sort' field. Meteor applies the WHOLE modifier once any allow rule approves
and no deny rule rejects, and does not scope the approving rule to the field
that satisfied it. Because canUpdateBoardSort only checked that 'sort' was
AMONG the modified fields, a restricted member could smuggle arbitrary board
mutations (members, permission, title) into the same $set as 'sort' in one
DDP Boards.update call, making themselves admin, flipping the private board
to public, and evicting the legitimate owner. The last-admin deny rule only
inspected $pull, so a wholesale $set of the members array bypassed it.

Fix: restrict canUpdateBoardSort so the sort-reorder rule approves an update
only when 'sort' is the sole modified field. Defense in depth: the last-admin
deny rule now also rejects a $set rewrite of the members array that would
drop the last active admin. Regression test covers the multi-field smuggling
case. The legitimate All Boards drag-reorder is unaffected: it persists order
per-user in profile.boardSortIndex, not in the board document.

CVSS:3.1 8.8 High (AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H), CWE-863, CWE-269.
Thanks to 5ud0 / Tarmo Technologies and xet7.
2026-07-13 19:08:29 +03:00
Lauri Ojansivu 5b8e47649e Updated translations. 2026-07-13 18:34:58 +03:00
Lauri Ojansivu fb1df544dd Updated translations. 2026-07-13 18:29:09 +03:00
Lauri Ojansivu f031b885d7 CI: add meteor-spk.yml (build the meteor-spk bundle) and sandstorm-store.yml (publish .spk)
- .github/workflows/meteor-spk.yml: assembles WeKan's modernized meteor-spk (the
  packaging tool + its meteor-spk.deps: Node 24, FerretDB, Mongo 3.x CLIs, modern
  sandstorm-http-bridge) via sandstorm-src/build-deps.sh — reusing sandstorm.yml's
  setup — and zips it as meteor-spk-YYYY-MM-DD_HH_MM_SS.zip, the same kind of
  self-contained bundle sandstorm-io/meteor-spk releases but with WeKan's deps baked in.
  Uploaded as an artifact and to the newest GitHub Release. Needs no keyring (it does
  not pack/sign a .spk).

- .github/workflows/sandstorm-store.yml: publishes an already-built .spk to the
  Sandstorm App Market. Installs Sandstorm + assembles meteor-spk and restores
  SANDSTORM_KEYRING like sandstorm.yml, downloads the newest .spk from the WeKan release
  (built and attached by sandstorm.yml), renames it to wekan-<VERSION>.spk (VERSION from
  the release tag, e.g. 9.88, overridable via inputs), and runs 'spk publish
  wekan-<VERSION>.spk' exactly like releases/release-sandstorm.sh. Does not rebuild the
  .spk.

Thanks to xet7.
2026-07-13 14:53:57 +03:00
Lauri Ojansivu a4c1ce3d41 meteor test: patch ALL yargs files' import.meta, not just esm.mjs
The crash moved from yargs/lib/platform-shims/esm.mjs to yargs/build/lib/utils/
apply-extends.js (import.meta.resolve(config.extends)) — yargs' ESM build has more than
one file using import.meta. Rewrite the workaround to scan the whole node_modules/yargs
tree and rewrite every ESM-only construct (import.meta.url/.resolve/.dirname/.filename,
const require = createRequire(...), and yargs' own const __dirname) to the CommonJS
wrapper equivalents in one pass, so a new yargs file can't reintroduce the boot crash.
yargs is never executed at runtime here, so only valid CommonJS parsing matters.

Thanks to xet7.
2026-07-13 14:46:01 +03:00
Lauri Ojansivu 5b0ad4d334 meteor test: also rewrite yargs esm.mjs import.meta / require for the CommonJS wrapper
Renaming only __dirname was not enough: yargs' esm.mjs also uses import.meta.url (invalid
in Meteor's CommonJS module wrapper -> 'Cannot use import.meta outside a module') and
redeclares require via createRequire(import.meta.url) (collides with the wrapper's
require). reify rewrites the file's import statements but not import.meta. Rewrite all
three to use the wrapper's __filename / __dirname / require, which yargs never actually
exercises here (it is only bundled, never called). Idempotent; also patches a file left
half-rewritten by the previous version of this script.

Thanks to xet7.
2026-07-13 14:39:17 +03:00
Lauri Ojansivu 6b409c5dad meteor test: postinstall patch renames yargs esm.mjs __dirname (fixes Mocha boot crash)
.meteorignore does not apply to node_modules under Meteor 3 / rspack (verified: the
rebuilt Mocha bundle still contained node_modules/yargs), so revert that no-op rule and
fix the actual crash instead.

Root cause (pre-existing, unrelated to app code): the whole yargs package gets pulled
into the server bundle as a transitive devDependency, and its ESM shim
node_modules/yargs/lib/platform-shims/esm.mjs declares a top-level
'const __dirname = fileURLToPath(import.meta.url)'. Meteor wraps that .mjs in a CommonJS
module function that already provides __dirname, so it collides —
'SyntaxError: Identifier __dirname has already been declared' — crashing the server
bundle at boot, which is why Mocha reported 0 tests.

Add scripts/patch-yargs-dirname.cjs, run from a package.json postinstall, which renames
yargs' local __dirname (and its .substring/.lastIndexOf uses) to __dirnameYargs so it can
no longer collide with the wrapper's. Idempotent and best-effort (never fails install);
yargs is not used at runtime here so the rename is inert for the app.

Thanks to xet7.
2026-07-13 14:14:32 +03:00
Lauri Ojansivu 298ffcfd3b meteor test: exclude i18next-sprintf-postprocessor/rollup.config.js so yargs is not bundled
'meteor test' (Mocha) crashed at boot with 'Identifier __dirname has already been
declared'. Root cause is unrelated to app code: node_modules/yargs/lib/platform-shims/
esm.mjs declares a top-level 'const __dirname = fileURLToPath(import.meta.url)', which
collides with the __dirname that Meteor's CommonJS module wrapper already provides. yargs
gets pulled into the bundle only because i18next-sprintf-postprocessor (imported by
imports/i18n/tap.js) ships a stray rollup.config.js that does require('yargs'), and a
devDependency (mongodb) has since installed yargs 18 into node_modules so that require now
resolves. That build config is not part of the package's runtime entry
(index.js -> dist/commonjs), so exclude it from Meteor's bundle via .meteorignore.

Pre-existing (the same boot crash happened before this branch's test work) and independent
of the avatar/import-export feature.

Thanks to xet7.
2026-07-13 09:16:33 +03:00
Lauri Ojansivu cf217784d1 Fix Mocha boot crash (test __dirname) and load the new avatar/import-export server files
Two build/load fixes surfaced by running the full test suite:

- server/imports.js: import the new server-only files so they actually load. In
  mainModule mode a file not imported here never loads, so Accounts.onLogin avatar
  localization (server/avatarLocalizationOnLogin.js) and the imported-user reconciliation
  Meteor methods (server/importedUserReconciliation.js) would silently never register.

- Test __dirname collision: 'meteor test' crashed at boot with 'Identifier __dirname has
  already been declared'. The client test index (client/lib/tests/index.js) loads
  boardTriggersClass.tests.js, which referenced the bare __dirname global; under
  meteor test that makes Meteor inject a  colliding with its CommonJS
  wrapper's, aborting the whole server bundle (the same failure already fixed once in
  dependencies.openapi.tests.js — this was the next file to trip it). Replace __dirname
  with a process.cwd()/PWD walk-up in boardTriggersClass.tests.js, and defensively in the
  node-run tests/rtl.test.js, tests/stickers.test.js and tests/stickers.packs.test.js too.

Thanks to xet7.
2026-07-13 09:16:33 +03:00
Lauri Ojansivu bb7fe88bd5 Tests: unit + negative tests for the avatar/import-export feature; extract pure logic
Split the testable, security- and correctness-critical logic of the new avatars +
original-members feature into pure Node modules (module.exports, no Meteor) and cover them
with plain-Node tests/*.test.cjs (positive AND negative), matching the repo's existing
unit-test style. Wired into the test:unit:node script.

- models/lib/avatarUrlSafety.js  (from server/lib/localizeAvatar.js): isExternalAvatarUrl,
  isBlockedIp (SSRF ranges), decodeDataUri, checkUrlHostSync. Tests assert external vs
  local/relative/non-http URLs, that private/loopback/link-local/CGNAT/metadata/multicast
  IPv4+IPv6 (incl. IPv4-mapped) are blocked while genuine public addresses and near-miss
  ranges are allowed, data: decoding, and that non-http(s) schemes, localhost and
  metadata hosts are rejected.
- models/lib/importedUserReconciliationPlan.js (from server/importedUserReconciliation.js):
  planReconciliation. Tests: matches merge, non-matches deactivate, never match another
  placeholder or self or a username-less placeholder.
- packages/wekan-ldap/server/ldapPhoto.js (from sync.js): getLdapPhotoBuffer. Tests the
  Buffer / array / {type:'Buffer'} / base64 shapes and jpegPhoto>thumbnailPhoto, and that
  missing/empty/short values yield null (never throw).
- models/lib/importedBoardMemberPlan.js (from wekanCreator.js): planImportedBoardMember.
  Tests: unmapped member kept by original id but inactive+non-admin, mapped role preserved,
  importer and id-less members dropped.

The extractions are behaviour-preserving; the app modules now import these helpers.

Thanks to xet7.
2026-07-13 09:16:33 +03:00
Lauri Ojansivu ffc6652be0 Changelog: avatars + original members travel with a board across export/import and identity sources
Thanks to xet7.
2026-07-13 09:16:32 +03:00
Lauri Ojansivu db90fb9e61 Members: distinguish imported placeholders and inactive members on the avatar + sidebar (Increment 5)
Make it obvious which board members are backed by a real account and which are not,
both on card avatars and in the right sidebar member list.

- userAvatar (js/jade/css): the avatar gets an 'imported-member' class (dashed grey ring
  + amber '?' corner badge) for un-reconciled board-import placeholders
  (authenticationMethod:'imported'), and an 'inactive-member' class (greyscale + dim +
  grey badge) for members deactivated on the board (e.g. a person not in LDAP after
  reconciliation). A placeholder is usually both; a real active account gets neither. The
  tooltip explains the state.
- boards.js membersForSidebar(): active members first (as before) then the inactive /
  imported ones appended, and sidebar.jade uses it, so the member list shows EVERYONE and
  which are active vs not instead of hiding inactive members.
- i18n: imported-member-no-account, inactive-member.

Thanks to xet7.
2026-07-13 09:16:32 +03:00
Lauri Ojansivu 6784726bac Imported users: reconcile placeholders with valid accounts, admin merge (Increment 4)
server/importedUserReconciliation.js turns the inert import placeholders into the right
real members deliberately, after import — never auto-mapped during import.

- reconcileImportedUsers(): for each authenticationMethod:'imported' placeholder, find a
  real account with the same username (not another placeholder) — the valid accounts are
  whatever real WeKan accounts exist, typically provisioned by LDAP/OIDC at login — and
  merge the placeholder into it; if none exists (e.g. the person is not in LDAP) leave the
  placeholder and its board memberships inactive (isActive:false).
- mergeImportedUserInto(placeholderId, targetId): reassign every reference (board.members,
  card.members, card.assignees, activities.userId, cardComments.userId) from the
  placeholder to the target, reusing the target's membership if it already is a member,
  then remove the placeholder.
- Admin-only Meteor methods reconcileImportedUsers and mergeImportedUser(placeholderId,
  targetId) for the automatic sweep and for one-off deliberate mapping.

Because reconciliation matches against existing real accounts (which LDAP populates on
login) it needs no direct LDAP query and is provider-agnostic. Merges reassign by the
preserved original _id, so nothing is lost.

Thanks to xet7.
2026-07-13 09:16:32 +03:00
Lauri Ojansivu 0c4b8f4d93 Board import: preserve original members as inert placeholder users, no mapping (Increment 3)
Importing a WeKan board no longer collapses unmapped members onto the importing user (a
wrong mapping attaches the wrong person and can leak board permissions). Instead each
original member carried in board.users becomes an inert placeholder user:

- createPlaceholderUsers() reuses the ORIGINAL _id, so every card/comment/activity
  member reference resolves to the right person with no remapping, and populates
  this.members as an identity map (id -> id) so _user() keeps the original member.
- Placeholders are created with Users.direct.insertAsync (bypassing the after.insert
  hooks — Sandstorm identity sync and the disableRegistration/invitation-code gate that
  would otherwise reject a non-account user), marked authenticationMethod:'imported',
  loginDisabled:true, isActive:false, and carry NO password or email. Username collisions
  suffix the placeholder's name so an existing account is never renamed/stolen.
- The member's avatar (embedded as base64 by the exporter) is restored into files/avatars
  via the localizer, so the original picture shows and is exportable again (Sandstorm too).
- Board membership adds imported members inactive and non-admin, so they are visible but
  hold no permissions until deliberately reconciled later; the importer stays sole admin.

Also guard the Sandstorm Users.after.insert hook to no-op on users without
services.sandstorm (placeholders), which otherwise threw reading preferredHandle.
Mapping/merging to real accounts and LDAP reconciliation are a later, deliberate step.

Thanks to xet7.
2026-07-13 09:16:32 +03:00
Lauri Ojansivu b98abe7b00 Board export: embed each member's local avatar file as base64 (Increment 2)
Board export already carried the original members' username, fullname and initials (the
field whitelist excludes passwords, emails and services). Now, for each member whose
avatar is a local WeKan file, embed the file itself as base64 (profile.avatarFile +
avatarFileName + avatarFileType) alongside the existing avatarUrl reference, in both the
in-memory build() and the streaming buildStream() paths.

Because this reads a local avatars file (no outbound fetch), it works inside a Sandstorm
grain too: a board that already has many stored avatars can be exported with every
member's picture intact, ready to re-import elsewhere. External, not-yet-localized
avatars are still exported as their URL only (Increment 1 localizes those into files
first, on board open / at login).

Thanks to xet7.
2026-07-13 09:16:32 +03:00
Lauri Ojansivu e0c76099f0 Avatars: import LDAP jpegPhoto and OIDC picture at login, localize on every login
Second set of triggers so external avatars from identity providers become local WeKan
avatars (files/avatars), shown in WeKan and carried by board export/import.

- LDAP (packages/wekan-ldap/server/sync.js): syncUserData now reads the binary
  jpegPhoto / thumbnailPhoto (tolerating Buffer / array / {type:'Buffer',data} / base64
  shapes) and, unless the user already has a locally-stored avatar, stores it as a
  self-contained data: URI in profile.avatarUrl. That displays immediately and needs no
  coupling from this package to app code; the app then materialises it to a real file.

- OIDC (packages/wekan-oidc/oidc_server.js): capture the standard  claim (with
  an OAUTH2_AVATAR_MAP override) into serviceData and set profile.avatarUrl for new users.

- App (server/avatarLocalizationOnLogin.js): Accounts.onLogin localizes the logging-in
  user's external avatar immediately (provider-agnostic), complementing the board-open
  trigger. Fire-and-forget, idempotent, never blocks login. (Inside a Sandstorm grain
  outbound fetch is sandboxed, so a Sandstorm profile picture is a best-effort no-op here
  and needs client-assisted capture — a later step.)

Thanks to xet7.
2026-07-13 09:16:32 +03:00
Lauri Ojansivu b4bfc75947 Avatars: localize board members' external avatars when a board is opened
First trigger for external-avatar localization: the single-board publication
(publishComposite('board')) now fires a best-effort, fire-and-forget
localizeBoardMemberAvatars(boardId). For every member whose profile.avatarUrl points
outside WeKan, it copies the image into WeKan's own files/avatars (via the SSRF-guarded
helper) and repoints avatarUrl at the local copy. Idempotent (already-local avatars are
skipped) and it never blocks or delays the publication.

This is the universal catch-all: no matter how a member's avatar became external
(OAuth2/OIDC picture URL, gravatar, a pasted URL), opening the board makes it a local,
exportable WeKan avatar. (Note: inside a Sandstorm grain outbound fetch is sandboxed, so
Sandstorm profile pictures need the provider-side capture added next; LDAP jpegPhoto is
binary and is imported at login, also next.)

Thanks to xet7.
2026-07-13 09:16:32 +03:00
Lauri Ojansivu dcd5f8fdd5 Avatars: add SSRF-guarded external-avatar localization helper (foundation)
First piece of making external avatars (Sandstorm profile pictures, LDAP jpegPhoto,
OAuth2/OIDC picture claims, gravatar, any URL/data-URI) into local WeKan avatar files
under WRITABLE_PATH/files/avatars, so they display without the identity provider and are
carried by board export/import.

server/lib/localizeAvatar.js:
- isExternalAvatarUrl(url): true unless already a local /cdn/storage/avatars/ (or legacy
  /cfs/files/avatars/) URL.
- localizeAvatarFromBuffer(userId, buffer, {type,name}): write bytes into the Avatars
  FilesCollection (onAfterUpload sets the user's local profile.avatarUrl).
- localizeAvatarFromUrl(userId, url): fetch (or decode a data: URI) then store.
- localizeUserAvatarIfExternal(user): idempotent no-op when already local.

Every network fetch is SSRF-guarded: http/https only; the host is resolved and any
private, loopback, link-local, CGNAT, multicast or cloud-metadata (169.254.169.254)
address is refused; 8s timeout; 5 MB cap; image content-type only. Not wired to any
trigger yet (board-open / export / login flows come next).

Thanks to xet7.
2026-07-13 09:16:32 +03:00
Lauri Ojansivu 7273220780 Updated ChangeLog. 2026-07-13 06:05:29 +03:00
Lauri Ojansivu 0d90011aff Update Sandstorm WeKan info.
Thanks to xet7 !
2026-07-13 06:04:50 +03:00
Lauri Ojansivu 2df6a77072 Updated ChangeLog. 2026-07-13 05:58:50 +03:00
Lauri Ojansivu ade9f16db4 Update Sandstorm WeKan info.
Thanks to xet7 !
2026-07-13 05:57:00 +03:00
Lauri Ojansivu 8cbfe3daee Updated ChangeLog. 2026-07-13 05:47:57 +03:00
Lauri Ojansivu 1bf68f54b2 Update Sandstorm WeKan info.
Thanks to xet7 !
2026-07-13 05:46:24 +03:00
github-actions[bot] 619eda0a9d Bump versions for v9.88 2026-07-13 02:12:35 +00:00
Lauri Ojansivu 3d2ab08294 Updated ChangeLog. 2026-07-13 05:10:47 +03:00
Lauri Ojansivu 6a12d968e0 Updated ChangeLog. 2026-07-13 05:05:53 +03:00
Lauri Ojansivu 9f23e6384b Added docs about new Sandstorm WeKan.
Thanks to xet7 !
2026-07-13 05:03:36 +03:00
Lauri Ojansivu 5d44e0b98b Sandstorm: remove the temporary MongoDB-3->FerretDB debugging diagnostics
Now that the grain boots, logs in, lists/opens boards, uploads/downloads attachments,
and migrates an old MongoDB 3 grain end to end, drop the two temporary diagnostics:

- models/attachments.js: revert the Meteor-Files debug flag to false (it was enabled on
  Sandstorm to trace the upload 'session expired [408]' issue and was spamming the grain
  log with the full FilesCollection dump and every find()).
- server/ferretdbQueryDebug.js: remove the mongodb Collection.find wrapper that logged
  FerretDB-rejected selectors (used to find the $elemMatch 'unknown operator: userId'
  issue, since fixed in wekan/FerretDB).

Thanks to xet7.
2026-07-13 04:11:22 +03:00
Lauri Ojansivu e65e06865a Changelog: Sandstorm/Snap migration modern driver, Meteor-Files GridFS + v1 binary, auto-open All Boards
Thanks to xet7.
2026-07-13 03:57:47 +03:00
Lauri Ojansivu b8bdbcd2d7 Sandstorm/Snap migration: auto-open All Boards after migration; WeKan-themed dashboard
Two UX requests once the migration itself works end to end:

- Auto-open All Boards. Previously the dashboard sat on the grain URL for 60s after
  completion and the admin had to reload to reach WeKan. On success the importer now
  exits after ~5s (long enough for the browser to fetch the done page), and the done
  page runs a JS poller that fetches '/' until WeKan's app shell answers (tolerating the
  brief importer->WeKan port hand-off gap) and then location.replace('/') opens All
  Boards. The spinner keeps spinning through the hand-off so it is clear the grain is
  still working; no meta-refresh on the done page (a refresh mid-hand-off would hit a
  dead port). On failure it still stays up a minute with the errors.

- WeKan colours. Recolour the dashboard from the dark scheme to WeKan's blue/white/grey
  (belize blue #2980b9 headings and spinner, white card on light-grey background, grey
  borders, system font).

Thanks to xet7.
2026-07-13 03:57:11 +03:00
Lauri Ojansivu 3476cd17c7 Sandstorm/Snap migration: extract Meteor-Files GridFS attachments + parse legacy v1 binary
With text collections migrating, the 3 attachments still produced 0 extracted files and
errors like 'parse attachments.chunks: Unexpected Binary Extended JSON format
{"$binary":"iVBOR..."}'. Two causes, both fixed:

1. Legacy Extended JSON v1 binary. mongo 3.x mongoexport writes binary as
   {"$binary":"<b64>","$type":"00"} (v1), but modern bson EJSON.parse only
   accepts v2 {"$binary":{"base64":...,"subType":...}}. Rewrite v1 -> v2 per line
   before parsing, so chunk data (and any binary in text collections) parses.

2. Meteor-Files native GridFS buckets were unhandled. The grain stores attachments in
   attachments.files + attachments.chunks (FilesCollection record in the attachments
   collection), not CollectionFS's cfs_gridfs.*. Reassemble those buckets to disk,
   linking each GridFS file to its record via metadata.fileId/versionName, then repoint
   the migrated record's versions.<v> at the file and DROP versions.<v>.meta.gridFsFileId
   — otherwise WeKan's getFileStrategy keeps choosing the (now-empty) GridFS backend and
   the image 404s. Also exclude <bucket>.files/.chunks (and tempstores) from the text
   migration so binary chunks are no longer run through EJSON as documents.

Thanks to xet7.
2026-07-13 03:28:13 +03:00
Lauri Ojansivu cab231ee3a Sandstorm/Snap migration: use the modern mongodb driver (OP_MSG) for FerretDB inserts
Text collections exported and 'inserted N/N' was logged, but every document actually
failed with 'Unsupported OP_QUERY command: update' — nothing reached FerretDB. Cause:
requireAny('mongodb') resolved the ANCIENT meteor-spk base driver (v2.x, at the deps
root) because the modern driver is not directly under programs/server/npm/node_modules
— Meteor nests it at .../meteor/npm-mongo/node_modules/mongodb (v6.16). The 2.x driver
speaks legacy OP_QUERY, which FerretDB rejects; the 6.x driver speaks OP_MSG (the same
driver the WeKan app uses against FerretDB). Add the npm-mongo path as the first
resolver anchor, and log the resolved driver version.

(Separately, GridFS attachment/avatar extraction still finds 0 files for this grain —
its attachments appear to be in Meteor-Files buckets (attachments.files/.chunks) rather
than the CollectionFS cfs_gridfs.* the importer currently handles; to be addressed once
the modern driver confirms text migration and the real attachment collection counts.)

Thanks to xet7.
2026-07-13 02:56:35 +03:00
Lauri Ojansivu d693ae8d7d Changelog: add individual commit links for the folded migration sub-fixes
Link the mongodb default-import, mongoexport --quiet removal, diagnostic/dashboard, and
createRequire commits inline within their parent migration bullets.

Thanks to xet7.
2026-07-13 02:44:17 +03:00
Lauri Ojansivu 5054dab8b6 Changelog: link the wiredTigerCacheSizeGB integer-value fix commit
Thanks to xet7.
2026-07-13 02:41:38 +03:00
Lauri Ojansivu 9c06bd5772 Changelog: update the migration EJSON bullet to the modern-bundle resolution fix
Thanks to xet7.
2026-07-13 02:41:01 +03:00
Lauri Ojansivu beefe441d7 Sandstorm/Snap migration: resolve bson/mongodb from the modern server bundle, not the old base
The EJSON diagnostic was conclusive: require('bson') returned an object with no EJSON,
mongodb.EJSON was undefined, and mongodb/lib/bson* were MODULE_NOT_FOUND. Cause: the
importer sits at the deps root next to the OLD meteor-spk 0.6.0 base node_modules
(bson 1.x with no EJSON at all, plus an ancient mongodb that has MongoClient but no
EJSON re-export), kept there only for the niscu->3.0 stage — so a bare require resolved
those adjacent copies. WeKan's current bson/mongodb (with EJSON) live under
programs/server/npm/node_modules. Anchor createRequire inside that modern bundle first
(falling back to the deps root), and load both mongodb and bson through it. This also
switches the importer to the modern mongodb driver — the same one the WeKan app uses
against FerretDB.

Thanks to xet7.
2026-07-13 02:36:09 +03:00
Lauri Ojansivu 0e0a8bbb33 Sandstorm/Snap migration: load mongodb/bson via createRequire; resolve EJSON robustly
The mongodb default import exposed MongoClient but NOT EJSON (mongodbPkg.EJSON was
undefined), so the previous 'take EJSON from mongodb' attempt still hit the FATAL
guard. Node 24's ESM default-interop for these CommonJS packages drops the
getter/re-export used for EJSON. Switch to createRequire (CJS require returns the real
module.exports with getters intact and honors NODE_PATH), and resolve EJSON by trying,
in order: mongodb.EJSON, mongodb/lib/bson.js, mongodb/lib/bson, bare bson's .EJSON,
and bare bson itself — falling back with a diagnostic list of what each attempt
returned so a remaining failure names the cause instead of just 'undefined'.

Thanks to xet7.
2026-07-13 02:20:23 +03:00
Lauri Ojansivu 5f40f612f5 Changelog: Sandstorm/Snap migration EJSON-from-mongodb-driver fix
Thanks to xet7.
2026-07-13 02:07:45 +03:00
Lauri Ojansivu b0703befd7 Sandstorm/Snap migration: get EJSON from the mongodb driver, not a bare bson import
With mongoexport connecting, every collection then failed with 'parse <coll>: Cannot
read properties of undefined (reading parse)' — EJSON was undefined. The importer runs
with NODE_PATH=programs/server/node_modules, but the EJSON-bearing bson (7.3.0) lives
under programs/server/npm/node_modules, so a bare 'import bson' did not resolve to it
and EJSON came out undefined. The mongodb driver (which resolves fine — MongoClient
works) bundles bson and re-exports EJSON from lib/bson.js, so take EJSON from the same
default import and drop the separate bson dependency. Add an upfront guard that fails
loudly if EJSON.parse is ever missing instead of spamming one error per collection.

Thanks to xet7.
2026-07-13 02:07:24 +03:00
Lauri Ojansivu 7f42db4670 Changelog: Sandstorm/Snap migration mongoexport IPv4 host fix + live dashboard
Thanks to xet7.
2026-07-13 01:49:45 +03:00
Lauri Ojansivu 6142396ae9 Sandstorm/Snap migration: connect mongoexport to 127.0.0.1 (IPv6 localhost broke it)
The real reason every mongoexport failed (revealed once --quiet was dropped):
'error connecting to db server: no reachable servers'. mongoexport is a Go tool
whose --host defaults to 'localhost', which resolves to ::1 (IPv6) first, but the
migration mongod listens only on --bind_ip 127.0.0.1 (IPv4) — so mongoexport could
never reach it, while the mongo shell (whose host defaults to 127.0.0.1) connected
fine and listed all 42 collections. Pass --host 127.0.0.1 explicitly.

Also fill the dashboard Activity panel from the first moment (mongoexport-ready line,
and one line per collection including empty ones) so progress is visible live instead
of the panel sitting on '(waiting…)' while only red connection errors accumulated.

Thanks to xet7.
2026-07-13 01:49:21 +03:00
Lauri Ojansivu 3076f2317e Sandstorm/Snap migration: drop mongoexport --quiet (it hid the error) + live activity log
The --version probe confirmed the bundled mongoexport runs fine (r3.2.22), yet every
per-collection export exited status=1 with empty stderr AND stdout. The empty stderr
was mongoexport's own --quiet flag suppressing its failure message. Drop --quiet so
the real reason (e.g. 'Failed: <reason>') prints to stderr; mongoexport's normal
progress lines also go to stderr, so stdout stays clean Extended JSON either way.

Also surface progress on the dashboard as the user asked: a rolling Activity log
(last ~15 lines: collections found, per-collection export/insert counts, GridFS file
extraction counts) rendered in a panel and mirrored to the grain log, so it is clear
what the migration is doing rather than only red errors appearing later.

Thanks to xet7.
2026-07-13 01:23:38 +03:00
Lauri Ojansivu 62df991532 Sandstorm/Snap migration: diagnose mongoexport failures + live progress dashboard
Every per-collection mongoexport failed with 'failed: undefined' because the error
only logged (r.stderr || r.error): an empty stderr with a non-zero/killed status
(e.g. a SIGSEGV, where spawnSync reports status=null, signal='SIGSEGV', stderr='')
printed as 'undefined', hiding the real cause. Log a full describe(r) instead
(status, signal, error code, stderr AND stdout snippets), and probe
'mongoexport --version' / '--help' once at startup so the next run shows whether the
bundled mongoexport binary itself is broken (dies on --version too → an ABI/bundling
problem) or only the export invocation is. The mongo shell on the same libs works
(listCollections succeeds), so this narrows it precisely.

Also make the progress dashboard obviously live: a CSS spinner while running (✅/❌
when done), a server 'updated' timestamp that changes on every 2s auto-refresh, and
an error counter — the previous page refreshed but showed no sign of activity.

Thanks to xet7.
2026-07-13 00:58:54 +03:00
Lauri Ojansivu 50abd8f95a Sandstorm/Snap migration: import mongodb as default (CommonJS) under Node 24 too
Same CommonJS/ESM interop issue as the bson import: with { EJSON } fixed, the
importer next threw 'Named export MongoClient not found. The requested module
mongodb is a CommonJS module'. The bundled mongodb driver is CommonJS under Node
24's ESM loader, so import the default and destructure MongoClient. These are the
only two third-party imports; the rest are node: builtins.

Thanks to xet7.
2026-07-13 00:33:32 +03:00
Lauri Ojansivu cafbb1761b Changelog: Sandstorm/Snap migration bson default-import fix for Node 24 ESM
Thanks to xet7.
2026-07-13 00:18:50 +03:00
Lauri Ojansivu a5bcb2e27c Sandstorm/Snap migration: import bson as default (CommonJS) under Node 24 ESM
With the WiredTiger cache fixed, mongod 3.0 now starts and the migration importer
runs, but it crashed immediately: 'import { EJSON } from "bson"' threw
"SyntaxError: Named export 'EJSON' not found. The requested module 'bson' is a
CommonJS module". bson (as bundled in WeKan's server node_modules) is CommonJS, so
Node 24's ESM loader exposes no named exports on it. Import the default and
destructure EJSON from it, as Node's own error message advises. Shared by the Snap
migration too (same Node 24).

Thanks to xet7.
2026-07-13 00:18:33 +03:00
Lauri Ojansivu 0804cd19e8 Sandstorm .spk: mongod 3.0 wiredTigerCacheSizeGB must be an integer (1, not 0.25)
mongod 3.0.7 parses --wiredTigerCacheSizeGB as an integer number of GB, so the
0.25 from the previous commit failed at startup with 'Error parsing option
wiredTigerCacheSizeGB as int: Bad digit "." while parsing 0.25' and the migration
still crash-looped. Use 1 (GB). It is a cache cap, not a preallocation, so a short
migration of a normal-sized grain never actually uses that much.

Thanks to xet7.
2026-07-12 23:57:43 +03:00
Lauri Ojansivu 3b109d14e8 Changelog: Sandstorm MongoDB 3 -> FerretDB migration fix (WiredTiger cache + source DB)
Thanks to xet7.
2026-07-12 23:39:09 +03:00
Lauri Ojansivu 3f5c70e643 Sandstorm .spk: fix MongoDB 3 -> FerretDB migration (WiredTiger cache=0G, wrong source DB)
Importing an existing WeKan grain crash-looped in the one-time MongoDB 3 -> FerretDB
migration: mongod 3.0 forked and its child aborted with exit code 14. Two bugs:

1. WiredTiger cache_size=0G. mongod 3.0 sizes the WiredTiger cache from detected
   RAM (RAM/2 - 1GB), but inside a Sandstorm grain sandbox RAM detection returns 0,
   so it computes cache_size=0G and WiredTiger refuses to open (minimum is 1MB),
   logging 'Value too small for key cache_size' and 'Fatal Assertion 28561' to
   /var/migration-mongod.log before aborting. Pass an explicit
   --wiredTigerCacheSizeGB 0.25 (256MB) to both mongod invocations (the niscu ->
   3.0 stage, which writes new WiredTiger data, and the 3.0 -> FerretDB stage) so
   the cache size never depends on RAM detection. The data itself is fine (turtle
   file: WiredTiger 2.5.3, i.e. written by mongod 3.0; the 'unclean shutdown'
   notice is harmless, WiredTiger recovers from the last checkpoint).

2. Wrong source database. Sandstorm WeKan grains store their data in the
   Meteor-default database 'meteor' (the niscu stage reads/writes 'meteor', and a
   real grain's WiredTiger catalog shows meteor.* collections), but the importer
   was told SRC_DB 'wekan', so even once mongod started it would have exported zero
   collections. Only the FerretDB target database is 'wekan'.

Thanks to xet7.
2026-07-12 23:38:52 +03:00
Lauri Ojansivu 455e498482 Changelog: Sandstorm open All Boards + grain URL sync fix
Thanks to xet7.
2026-07-12 23:12:45 +03:00
Lauri Ojansivu 3ab2b9dccb Sandstorm .spk: open All Boards (not sign-in) and keep the grain URL in sync
Two grain-navigation regressions vs the last working Sandstorm build (v6.15):

1. Opening a grain showed 'Must be logged in' instead of the All Boards page.
   On Sandstorm the platform authenticates the user asynchronously over DDP via
   connection.setUserId(), which (unlike a password login) does not set
   Meteor.loggingIn(), so Meteor.userId() is null for the first moments after the
   grain opens. useraccounts' ensureSignedIn route trigger and renderBoardList()
   both bounced that brief null window to the atSignIn route — a sign-in page that
   does not exist inside a grain. config/router.js now uses a Sandstorm-aware
   ensureSignedInUnlessSandstorm wrapper (a no-op on Sandstorm) and renderBoardList()
   no longer redirects on Sandstorm; the All Boards list renders and reactively
   fills in once the platform login lands.

2. The Sandstorm shell's outer grain URL did not update when switching boards. The
   shell rewrites /grain/<id><path> when the app posts a { setPath } message
   (sandstorm shell/imports/client/grain-client.js). The sync was a bare top-level
   Tracker.autorun that could run before flow-router-extra's reactive path tracking
   was initialised and then never re-run. Restore v6.15's event-driven
   FlowRouter.triggers.enter (fresh entering path, no dependency on init order) and
   additionally keep a watchPathChange() autorun wrapped in Meteor.startup as a
   backup. setTitle now also re-runs on route change.

Thanks to xet7.
2026-07-12 23:12:07 +03:00
Lauri Ojansivu d79f90fdfe Changelog: Sandstorm attachment/avatar download authorization via X-Sandstorm-User-Id
Thanks to xet7.
2026-07-12 22:55:11 +03:00
Lauri Ojansivu 1ca7bd3bb6 Sandstorm .spk: authorize attachment/avatar downloads via X-Sandstorm-User-Id
On Sandstorm the grain download route returned 403 for private boards, so
attachment thumbnails, minicard covers and the slideshow all showed broken
images even though the upload succeeded and the file was on disk. The download
handler (server/routes/universalFileServer.js) authorizes private-board files
via a Meteor login token (Authorization / X-Auth-Token / authToken query /
meteor_login_token cookie), but Sandstorm has none of these: authentication is
via connection.setUserId() and the sandstorm-http-bridge X-Sandstorm-* request
headers, so extractLoginToken() returned null and isAuthorizedForBoard() denied
every request. Sandstorm already gates grain access at the platform level, so any
request reaching WeKan is an authenticated grain user; trust it. Both
isAuthorizedForBoard() and isAuthorizedForAvatar() now short-circuit to allow
when Meteor.settings.public.sandstorm is set and the request carries the
bridge-injected X-Sandstorm-User-Id header. Gating on the setting means a spoofed
header cannot bypass auth on non-Sandstorm deployments.

Thanks to xet7.
2026-07-12 22:54:52 +03:00
Lauri Ojansivu 525cd07eee Changelog: add the Sandstorm DDP attachment-upload fix to Upcoming
Link the fix that switches attachment uploads to DDP transport on Sandstorm, since
the bridge strips Meteor-Files' custom x-* HTTP upload headers.

Thanks to xet7.
2026-07-12 22:29:06 +03:00
Lauri Ojansivu dc8ff6e6ca Sandstorm .spk: upload attachments over DDP (bridge strips Meteor-Files' HTTP headers)
Adding a file to a card in the grain failed with HTTP 400 "Can't continue upload,
session expired [408]" and the file silently disappeared. The Meteor-Files HTTP
upload protocol signals the first chunk with an x-start header and tracks the
session with x-mtok / x-chunkid / x-fileid / x-eof, but Sandstorm's request-header
whitelist (web-session.capnp) does not include those, so the sandstorm-http-bridge
strips them: the server never sees x-start, treats every request as a chunk
continuation, cannot find the per-fileId session and returns 408. Use
transport: 'ddp' on Sandstorm (detected via Meteor.settings.public.sandstorm) so
uploads go over DDP method calls instead of custom HTTP headers; HTTP transport is
kept everywhere else (it avoids the Safari DDP-reconnect stall).

Thanks to xet7.
2026-07-12 22:28:28 +03:00
Lauri Ojansivu c671a7fc8c Sandstorm .spk: temporarily enable Meteor-Files debug logging on Sandstorm
Attachment uploads in the grain fail with HTTP 400 "Can't continue upload, session
expired [408]": the upload start succeeds but the per-fileId session is gone by the
time a chunk arrives (both the in-memory _currentUploads entry and the
__pre_attachments pre-collection doc are missing), which points at the polling
observe (FerretDB has no oplog) firing a spurious removed event and aborting the
upload. The Attachments FilesCollection had debug: false, so nothing about the
upload path is logged. Enable Meteor-Files debug on Sandstorm only (gated on
Meteor.settings.public.sandstorm) so the grain debug log shows the start /
createStream / observer / continueUpload steps and pinpoints where the session is
lost. TEMPORARY: revert to debug: false once the upload is fixed.
2026-07-12 22:09:57 +03:00
Lauri Ojansivu d5092c9b2d Changelog: add the Sandstorm grain-URL sync fix to Upcoming
Link the fix that keeps the Sandstorm shell's grain URL in sync with the in-app
route via a reactive autorun.

Thanks to xet7.
2026-07-12 21:38:07 +03:00
Lauri Ojansivu 68e59ab66f Sandstorm .spk: keep the grain URL in sync with the in-app route
Navigating between boards worked but the Sandstorm shell's grain URL never updated
(it stayed on the grain root), unlike standalone WeKan. The path was synced via a
global FlowRouter.triggers.enter callback, which does not fire reliably on client
navigation in this flow-router-extra / Meteor 3 setup. Sync it from a reactive
Tracker.autorun on FlowRouter.watchPathChange() instead (the same mechanism the
setTitle sync already uses), so every route change posts setPath to the shell and
the grain URL becomes /grain/<id><path>.

Thanks to xet7.
2026-07-12 21:37:37 +03:00
Lauri Ojansivu 11f87c2115 Sandstorm .spk: temporary diagnostic to log the exact FerretDB-rejected query
Opening a board in the grain fails with "MongoServerError: unknown operator: userId"
(BadValue) - FerretDB rejecting a query MongoDB accepts - but the driver stack trace
has no WeKan call site, so the offending selector is unknown. This wraps the raw
mongodb Collection.find() to log the collection name and exact selector whenever a
cursor iteration throws, to pinpoint the query. TEMPORARY: to be removed once the
query is rewritten FerretDB-compatibly.

Thanks to xet7.
2026-07-12 19:57:16 +03:00
Lauri Ojansivu 21644652e2 Changelog: add the Sandstorm sign-in bounce fix to Upcoming
Link the fix that redirects from the sign-in page to the boards list once the
asynchronous Sandstorm auto-login sets Meteor.userId().

Thanks to xet7.
2026-07-12 18:47:30 +03:00
Lauri Ojansivu 6f3174b23d Sandstorm .spk: bounce from sign-in to the boards list once auto-login lands
The Sandstorm login was actually succeeding - Meteor.userId() gets set (confirmed:
Meteor.connection._userId held a valid id, Meteor.loggingIn() false) - but the grain
stayed on the sign-in page. WeKan's home route (renderBoardList) checks
Meteor.userId() once and, because the Sandstorm header login is asynchronous and
uses connection.setUserId() (bypassing accounts-base, so no Accounts.onLogin fires),
finds it still null on first render and redirects to 'atSignIn' - where the user is
stranded even after login completes moments later. Add a Sandstorm-only reactive
autorun that sends the user from 'atSignIn' back to 'home' as soon as
Meteor.userId() is set, so the grain lands on the All Boards page.

Thanks to xet7.
2026-07-12 18:47:01 +03:00
Lauri Ojansivu fb0c7f7f60 Changelog: add the ROOT_URL-per-request Sandstorm login/CORS fix to Upcoming
Link the fix that rewrites ROOT_URL to the grain's real URL so DDP, dynamic
imports and the Sandstorm auto-login stop failing cross-origin.

Thanks to xet7.
2026-07-12 18:15:37 +03:00
Lauri Ojansivu d5f707fd37 Sandstorm .spk: rewrite ROOT_URL per request to the grain URL (fixes login + CORS)
WeKan loaded but stayed on "Must be logged in", and the console showed
"Cross-Origin Request Blocked ... http://127.0.0.1:4000/__meteor__/dynamic-import/fetch".
The launcher sets a fixed ROOT_URL (http://127.0.0.1:4000, the internal bridge
target), but Sandstorm serves each grain at a per-session host (ui-<hash>.<host>)
via sandstorm-http-bridge, so the client sent its DDP connection and dynamic-import
fetches to 127.0.0.1:4000 - cross-origin and unreachable from the browser - and the
header-based login handshake (a DDP method call) never completed. Add a
WebApp.addRuntimeConfigHook that rewrites ROOT_URL to the grain's real base URL
(X-Sandstorm-Base-Path) per request, and re-asserts the SANDSTORM flag, so the
client talks to the same origin it loaded from. DDP, dynamic imports and the
Sandstorm auto-login now work.

Thanks to xet7.
2026-07-12 18:15:15 +03:00
Lauri Ojansivu be8976ed8c Changelog: add the SANDSTORM=1 auto-login fix to Upcoming
Link the fix that sets process.env.SANDSTORM=1 in the launcher so the
Sandstorm header-based auto-login runs and pages stop showing "Must be logged in".

Thanks to xet7.
2026-07-12 17:57:43 +03:00
Lauri Ojansivu b0712e6656 Sandstorm .spk: set SANDSTORM=1 so the header-based auto-login runs
WeKan loads in the grain but every page showed "Must be logged in". The
wekan-accounts-sandstorm client only starts the automatic X-Sandstorm-* header
login when __meteor_runtime_config__.SANDSTORM is set, and the package only sets
that when process.env.SANDSTORM is present - which nothing did (start.js set
MONGO_URL/ROOT_URL/PORT/WRITABLE_PATH but not SANDSTORM, and the pkgdef env didn't
either). The launcher now sets process.env.SANDSTORM = '1' before loading the WeKan
bundle, so the package enables the runtime flag and the client auto-logs-in the
Sandstorm user from the X-Sandstorm-* headers. (App code detects Sandstorm via a
separate Meteor.settings.public.sandstorm flag from the pkgdef METEOR_SETTINGS,
which already worked.)

Thanks to xet7.
2026-07-12 17:57:21 +03:00
Lauri Ojansivu ad46cb6102 Changelog: add the no-auto-board + global-role Sandstorm change to Upcoming
Link the change that stops auto-creating a board on a new grain and maps the
grain's Sandstorm permissions to the user's global WeKan role.

Thanks to xet7.
2026-07-12 17:40:33 +03:00
Lauri Ojansivu 8f11e8ac66 Sandstorm .spk: don't auto-create a board; map grain permissions to global role
WeKan on Sandstorm is multi-board now, so a new grain/user no longer gets a
hard-coded 'sandstorm'/libreboard board auto-created - the user creates their own
boards from the All Boards page. The Users.after.insert hook no longer inserts that
board + Default swimlane. updateUserPermissions previously added the user as a
member of that single board (which would now crash, since the board no longer
exists); it now maps the grain's Sandstorm permissions to the user's GLOBAL WeKan
role instead - 'configure' (grain owner) becomes a WeKan admin, everyone else is a
regular user who can create and manage their own boards. Dropped the now-unused
Boards/Swimlanes imports.

Thanks to xet7.
2026-07-12 17:40:09 +03:00
Lauri Ojansivu bb8233655c Changelog: add the "open on All Boards" Sandstorm change to Upcoming
Link the change that removes the hard-coded single-board redirect so the grain
opens on the All Boards page.

Thanks to xet7.
2026-07-12 17:37:36 +03:00
Lauri Ojansivu b5945cf596 Sandstorm .spk: open the grain on the All Boards page, not a hard-coded board
WeKan on Sandstorm originally opened a single hard-coded board
(/b/sandstorm/libreboard) and redirected "/" to it. It now supports many boards and
that libreboard is no longer the right destination, so redirecting to it is wrong.
Remove the WebApp.handlers.get("/") redirect entirely: "/" now falls through to
WeKan's normal serving, whose client "home" route (config/router.js) renders the
All Boards list - the right landing page for a multi-board grain. This also removes
the server-side redirect that browsers rejected as a Corrupted Content Error
(FlowRouter.path does not resolve on the server + Content-Length mismatch).

Thanks to xet7.
2026-07-12 17:36:16 +03:00
Lauri Ojansivu 6e60644bdb Changelog: add the "/" redirect (corrupted content) fix to Upcoming
Link the fix that builds the Sandstorm board redirect path directly and sends a
body with a matching Content-Length, so the grain's "/" stops failing with a
browser Corrupted Content Error.

Thanks to xet7.
2026-07-12 17:33:21 +03:00
Lauri Ojansivu ccdd1a0846 Sandstorm .spk: fix the "/" redirect (malformed Location + Content-Length mismatch)
The grain's "/" served a broken 301: Location was ".../:6080board" because
FlowRouter.path() does not resolve on the server in Meteor 3.x (it returned the
bare route name "board"), and the response advertised Content-Length: 90 while
sending an empty body, which the browser rejected as a "Corrupted Content Error"
(NS_ERROR_NET_CORRUPTED_CONTENT). Build the board path directly (/b/:id/:slug, the
'board' route) and send a real HTML body (meta-refresh + link) with a matching
Content-Length, so the redirect to the hard-coded Sandstorm board works. Together
with the Accept-Encoding strip (keeps Content-Length valid) and the modern bridge.

Thanks to xet7.
2026-07-12 17:32:54 +03:00
Lauri Ojansivu 04737bd76e Changelog: add the modern sandstorm-http-bridge fix to Upcoming
Link the fix that bundles a modern sandstorm-http-bridge (from the Sandstorm
install) so the grain stops serving Corrupted Content on WeKan's "/" redirect.

Thanks to xet7.
2026-07-12 04:28:04 +03:00
Lauri Ojansivu 7f0706e45f Sandstorm .spk: bundle a modern sandstorm-http-bridge to fix "Corrupted Content"
The grain boots, but the page failed with a browser "Corrupted Content Error"
(NS_ERROR_NET_CORRUPTED_CONTENT) on WeKan's "/" redirect (0 bytes, ~8.5s, then
failed). The meteor-spk 0.6.0 base bundles an ancient (~2016) sandstorm-http-bridge
that mangles responses - it always advertises Accept-Encoding: gzip to the app and
mishandles redirect/encoding. build-deps.sh now overwrites the bundled
/sandstorm-http-bridge with the modern one from a Sandstorm install
(/opt/sandstorm/latest/bin/sandstorm-http-bridge; override with SANDSTORM_HTTP_BRIDGE).
Sandstorm is amd64-only so one binary covers it. The sandstorm.yml workflow now
installs Sandstorm before assembling the deps so the bridge is available on the CI
runner. Complements the app-side Accept-Encoding strip.

Thanks to xet7.
2026-07-12 04:27:40 +03:00
Lauri Ojansivu ab8da931cf Changelog: add the Sandstorm Accept-Encoding (corrupted content) fix to Upcoming
Link the fix that strips Accept-Encoding in the Sandstorm grain so Meteor serves
uncompressed responses and the browser stops showing a Corrupted Content Error.

Thanks to xet7.
2026-07-12 03:56:02 +03:00
Lauri Ojansivu 013b6b5266 Sandstorm .spk: strip Accept-Encoding so the grain doesn't serve corrupted (gzip) content
The grain now boots, but the page failed to load with a browser "Corrupted Content
Error" (NS_ERROR_NET_CORRUPTED_CONTENT). sandstorm-http-bridge advertises
"Accept-Encoding: gzip" to the app regardless of what the browser actually sent, so
Meteor served gzip/brotli-encoded responses the browser could not decode. Strip
Accept-Encoding in a WebApp.rawHandlers middleware (which runs before Meteor's
static/boilerplate serving) so responses go out uncompressed; bandwidth is a
non-issue behind the local bridge.

Thanks to xet7.
2026-07-12 03:55:37 +03:00
Lauri Ojansivu 0115622a9a Changelog: add the FerretDB boolean-index-option fix to Upcoming
Link the fix that makes the services.sandstorm.id unique index use boolean
options so FerretDB accepts it and the Sandstorm grain boots past index creation.

Thanks to xet7.
2026-07-12 03:39:35 +03:00
Lauri Ojansivu 975316f5cd Sandstorm .spk: use boolean index options so FerretDB accepts the users index
wekan-accounts-sandstorm created the unique index on services.sandstorm.id with
{unique: 1, sparse: 1}. Real MongoDB accepts the truthy 1, but FerretDB (used by
the Sandstorm .spk) is strict and rejects it with "The field 'unique' has value
unique: 1, which is not convertible to bool", crashing the grain at boot during
index creation. Use real booleans (unique: true, sparse: true).

Thanks to xet7.
2026-07-12 03:39:17 +03:00
Lauri Ojansivu 54aad554aa Changelog: add the sandstorm.js stale-globals boot fix to Upcoming
Link the fix that imports the Users/Boards/Swimlanes/Activities collections and
drops the removed-HTTP-package monkey patch, so the Sandstorm grain boots past
the capnp guard.

Thanks to xet7.
2026-07-12 03:27:25 +03:00
Lauri Ojansivu 60e40199c9 Sandstorm .spk: fix server-boot crashes from stale globals (Users, HTTP) in sandstorm.js
Once the capnp load was made non-fatal, the grain reached the rest of sandstorm.js
and hit two latent Meteor-2.x-isms the Meteor 3.x migration missed (this file only
runs on Sandstorm, so it was not exercised): (1) it referenced the Users, Boards,
Swimlanes and Activities collections as implicit globals, but those are now ES
module default exports, so `Users.after.insert` threw "Users is not defined" at
boot; and (2) it monkey-patched `HTTP.methods` from the meteor/http package, which
was removed in the Meteor 3.x migration, so `HTTP` was undefined. Import the
collections (and Accounts) explicitly, and remove the obsolete HTTP.methods patch
(WeKan's REST API no longer uses it - it uses WebApp/JsonRoutes with header auth).

Thanks to xet7.
2026-07-12 03:27:02 +03:00
Lauri Ojansivu ff3f35ac43 Changelog: add the split-snap-build (native amd64/arm64 + non-blocking Launchpad) to Upcoming
Link the release-workflow change that builds amd64/arm64 natively on GitHub and
moves the exotic arches to a non-blocking per-arch Launchpad matrix, so the
release no longer hangs hours on riscv64.

Thanks to xet7.
2026-07-12 03:21:30 +03:00
Lauri Ojansivu 8549a62c85 Snap release: build amd64+arm64 natively on GitHub, exotic arches non-blocking on Launchpad
The single snap job ran `snapcraft remote-build` for all 5 platforms on Launchpad
and blocked until the slowest resolved, so the release hung ~3.5h on riscv64's
Launchpad queue even though amd64+arm64 finished in minutes. Split it in two:
snap-native builds amd64 (ubuntu-24.04) and arm64 (ubuntu-24.04-arm) NATIVELY on
GitHub runners via snapcore/action-build; snap-launchpad builds s390x/ppc64el/
riscv64 on Launchpad in a NON-BLOCKING (continue-on-error), per-arch matrix
(remote-build --build-for <arch>) so a slow or failed exotic arch never delays the
release or the other arches. Each arch publishes to the Snap Store
(candidate,beta,edge) and attaches to the GitHub Release the moment it finishes.
All 5 arches still ship.

Thanks to xet7.
2026-07-12 03:21:03 +03:00
Lauri Ojansivu 8b9202d677 Changelog: add the Sandstorm capnp grain-boot fix to Upcoming
Link the fix that stops capnp.node's Node 24 ABI mismatch from crash-looping
the Sandstorm grain; the grain now boots and core WeKan works via the
sandstorm-http-bridge headers.

Thanks to xet7.
2026-07-12 03:08:53 +03:00
Lauri Ojansivu f4f22bbe24 Sandstorm .spk: don't crash the grain when capnp.node can't load on Node 24
WeKan on Sandstorm bundles Node 24, but capnp.node (node-capnp) is built for an
older Node ABI (NODE_MODULE_VERSION 83 = Node 14), so `Npm.require('capnp')` in
sandstorm.js failed with ERR_DLOPEN_FAILED and crash-looped the whole grain on
boot. Load Cap'n Proto lazily in a try/catch and degrade gracefully: the grain
boots and core WeKan works, because login and user identity come from the
sandstorm-http-bridge X-Sandstorm-* HTTP headers (wekan-accounts-sandstorm) and
need no Cap'n Proto. Only the two capnp-only features are skipped when the addon
cannot load - the Powerbox identity-claim method and the Sandstorm activity
notifications - and they log a clear warning. These can be restored by rebuilding
node-capnp for Node 24, or reimplemented over the bridge's HTTP/JSON API (see the
Sandstorm CHANGELOG: use Cap'n Proto APIs without Cap'n Proto).

Thanks to xet7.
2026-07-12 03:08:23 +03:00
Lauri Ojansivu 32b561cfbf Changelog: add the FerretDB state-dir Sandstorm fix to Upcoming
Link the fix that points FerretDB's --state-dir to writable /var so the
Sandstorm grain starts instead of crash-looping on a read-only /state.json.

Thanks to xet7.
2026-07-12 02:25:07 +03:00
Lauri Ojansivu 1c28b40fd4 Sandstorm .spk: point FerretDB state dir to writable /var so the grain starts
FerretDB persists a state.json (version/UUID) via its state provider even
when telemetry is disabled, and its --state-dir defaults to "." — which in a
Sandstorm grain is "/", read-only. So FerretDB failed with "Failed to create
state provider: failed to persist state: open /state.json: read-only file
system", exited (code 1), and the grain crash-looped. sandstorm-src/start.js
now creates /var/ferretdb and passes --state-dir=/var/ferretdb (plus the
FERRETDB_STATE_DIR env) in startFerret(), covering both the migration and the
steady-state FerretDB launches.

Thanks to xet7.
2026-07-12 02:24:27 +03:00
Lauri Ojansivu 7f5cc03ea9 Changelog: add the Sandstorm .spk and Meteor unit tests fixes to Upcoming
List the glibc-loader grain crash-loop fix, the Sandstorm build-workflow
userns/ref fix, and the Meteor unit tests __dirname server-boot fix in the
Upcoming release section, each linking to its commit.

Thanks to xet7.
2026-07-12 01:58:12 +03:00
Lauri Ojansivu 60116bc72f Meteor unit tests: fix server-boot crash from __dirname in an ESM test file
server/lib/tests/dependencies.openapi.tests.js is an ES module (top-level
import) that referenced the bare __dirname global. Under Node 24 / Meteor 3.5
the compiler injects "const __dirname = fileURLToPath(import.meta.url)" for
ESM files that use __dirname, which collides with the __dirname the CommonJS
module wrapper already provides, so the whole server bundle failed to boot
with "Identifier '__dirname' has already been declared" and the "Meteor unit
tests" CI job died before any test ran. Drop the __dirname seed
(process.env.PWD already reaches the repo root under `meteor test`, and the
suite skips gracefully otherwise).

Thanks to xet7.
2026-07-12 01:57:23 +03:00
Lauri Ojansivu 66d8706c4d Sandstorm build workflow: enable unprivileged user namespaces and build the dispatched branch
Ubuntu 24.04 defaults kernel.apparmor_restrict_unprivileged_userns=1, which
blocks the unprivileged user namespaces the Sandstorm install and the spk
supervisor rely on, so sandstorm.yml now relaxes it on the runner. Also added
a "ref" workflow_dispatch input and check out that ref instead of a hardcoded
main, so a fix branch can be built and tested before it is merged to main.

Thanks to xet7.
2026-07-12 01:57:23 +03:00
Lauri Ojansivu 143607ef22 Sandstorm .spk: bundle the matching glibc dynamic loader so grains start
The .spk bundled the host's new glibc libc.so.6 (Ubuntu 24.04, glibc 2.39)
but kept the old glibc 2.31 ld-linux from the meteor-spk 0.6.0 base, so node
failed at startup with "libc.so.6: undefined symbol: _dl_audit_symbind_alt,
version GLIBC_PRIVATE" (HTTP-BRIDGE exit 127) and the grain crash-looped.
sandstorm-src/build-deps.sh now also copies the host's ld-linux-x86-64.so.2
into the deps so the loader and libc are the same glibc, and adds a [verify]
gate that fails the build if the bundled libc and loader glibc versions
differ or the bundled node cannot run under them - turning a silent grain
crash-loop into a loud build failure.

Thanks to xet7.
2026-07-12 01:57:23 +03:00
Lauri Ojansivu 0f52b6a787 Merge pull request #6447 from wekan/dependabot/npm_and_yarn/mongodb-7.5.0
Bump mongodb from 7.3.0 to 7.5.0
2026-07-12 00:23:37 +03:00
Lauri Ojansivu 87f4536e9d Bump @aws-sdk/client-s3 to ^3.1085.0 to match @aws-sdk/lib-storage 3.1085.0
Dependabot #6451 bumped lib-storage to ~3.1085.0, whose peer requires
client-s3 ^3.1085.0, but client-s3 was left at ^3.1071.0 — breaking
meteor npm install / npm ci with an ERESOLVE peer conflict.
2026-07-12 00:21:55 +03:00
Lauri Ojansivu cdde52392b sandstorm: trim .spk toward Cloudflare's 100 MB upload limit
- Drop the ~300 MB of modern MongoDB Database Tools (wekan/mongo-tools) from the
  Sandstorm build: they are unused there (Sandstorm backs up/restores grains
  itself; the MongoDB 3 -> FerretDB migration uses the legacy migratemongo CLIs +
  the .mjs importer). They stay in the .zip bundle / Docker / Snap, which use them.
- Set PUPPETEER_SKIP_DOWNLOAD=1 for the Meteor build (puppeteer is a test-only
  devDependency; its ~150 MB Chromium must never end up in the .spk).
- Pack step prints the .spk size and warns when it exceeds 100 MB.
2026-07-12 00:02:07 +03:00
dependabot[bot] 62f93fa46c Bump mongodb from 7.3.0 to 7.5.0
Bumps [mongodb](https://github.com/mongodb/node-mongodb-native) from 7.3.0 to 7.5.0.
- [Release notes](https://github.com/mongodb/node-mongodb-native/releases)
- [Changelog](https://github.com/mongodb/node-mongodb-native/blob/main/HISTORY.md)
- [Commits](https://github.com/mongodb/node-mongodb-native/compare/v7.3.0...v7.5.0)

---
updated-dependencies:
- dependency-name: mongodb
  dependency-version: 7.5.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-11 20:47:29 +00:00
Lauri Ojansivu 5b3a3fb744 Merge pull request #6451 from wekan/dependabot/npm_and_yarn/aws-sdk/lib-storage-3.1085.0
Bump @aws-sdk/lib-storage from 3.1073.0 to 3.1085.0
2026-07-11 23:39:47 +03:00
Lauri Ojansivu 349f4aa046 Merge pull request #6452 from wekan/dependabot/npm_and_yarn/i18next-26.3.6
Bump i18next from 26.3.4 to 26.3.6
2026-07-11 23:39:10 +03:00
Lauri Ojansivu ae1f37658c Merge pull request #6449 from wekan/dependabot/npm_and_yarn/puppeteer-25.3.0
Bump puppeteer from 25.1.0 to 25.3.0
2026-07-11 23:38:24 +03:00
Lauri Ojansivu df94214798 Merge pull request #6448 from wekan/dependabot/npm_and_yarn/tests/playwright/mongodb-7.5.0
Bump mongodb from 7.4.0 to 7.5.0 in /tests/playwright
2026-07-11 23:37:56 +03:00
Lauri Ojansivu 6c22e43be8 Merge pull request #6450 from wekan/dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-8.63.0
Bump @typescript-eslint/eslint-plugin from 8.61.1 to 8.63.0
2026-07-11 23:37:29 +03:00
dependabot[bot] 5e5baf5ed7 Bump i18next from 26.3.4 to 26.3.6
---
updated-dependencies:
- dependency-name: i18next
  dependency-version: 26.3.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-11 20:34:11 +00:00
dependabot[bot] 713c13831b Bump @aws-sdk/lib-storage from 3.1073.0 to 3.1085.0
Bumps [@aws-sdk/lib-storage](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/lib/lib-storage) from 3.1073.0 to 3.1085.0.
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/lib/lib-storage/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.1085.0/lib/lib-storage)

---
updated-dependencies:
- dependency-name: "@aws-sdk/lib-storage"
  dependency-version: 3.1085.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-11 20:33:55 +00:00
dependabot[bot] e400ecf548 Bump @typescript-eslint/eslint-plugin from 8.61.1 to 8.63.0
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 8.61.1 to 8.63.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.63.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-version: 8.63.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-11 20:33:27 +00:00
dependabot[bot] e9db3a8c2f Bump puppeteer from 25.1.0 to 25.3.0
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 25.1.0 to 25.3.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md)
- [Commits](https://github.com/puppeteer/puppeteer/compare/puppeteer-v25.1.0...puppeteer-v25.3.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-version: 25.3.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-11 20:32:58 +00:00
dependabot[bot] 260a2afacc Bump mongodb from 7.4.0 to 7.5.0 in /tests/playwright
Bumps [mongodb](https://github.com/mongodb/node-mongodb-native) from 7.4.0 to 7.5.0.
- [Release notes](https://github.com/mongodb/node-mongodb-native/releases)
- [Changelog](https://github.com/mongodb/node-mongodb-native/blob/main/HISTORY.md)
- [Commits](https://github.com/mongodb/node-mongodb-native/compare/v7.4.0...v7.5.0)

---
updated-dependencies:
- dependency-name: mongodb
  dependency-version: 7.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-11 20:32:45 +00:00
Lauri Ojansivu a8cf44cfaa sandstorm.yml: write signing keyring to ~/.sandstorm-keyring (path meteor-spk reads)
meteor-spk pack crashed with 'open(/home/runner/.sandstorm-keyring): No such file
or directory' because the keyring restore step wrote the decoded SANDSTORM_KEYRING
secret to ~/.sandstorm/sandstorm-keyring, but spk reads the app private key from
~/.sandstorm-keyring (a file directly in $HOME). Write it to the correct path, and
fail early with an actionable message when the secret is missing (the .spk cannot
be signed without it) instead of the cryptic later crash.
2026-07-11 23:12:37 +03:00
Lauri Ojansivu d53e7cafbb sandstorm build-deps.sh: fix 'not writing through dangling symlink' at step 3/7
The meteor-spk 0.6.0 base ships some runtime libs in meteor-spk.deps/lib as
DANGLING symlinks (e.g. libstdc++.so.6 -> a lib that no longer exists). When step
[3/7] refreshed them with the host's newer libs, 'cp -fL' refused with 'not writing
through dangling symlink' and failed the Sandstorm build. Add --remove-destination
so cp deletes the existing destination (dangling symlink included) before copying
the host's real library. Verified: plain 'cp -fL' reproduces the error; with
--remove-destination it succeeds and writes a real file.
2026-07-11 22:59:28 +03:00
github-actions[bot] f278d9ae68 Bump versions for v9.87 2026-07-11 19:44:03 +00:00
Lauri Ojansivu a700152e58 Updated ChangeLog. 2026-07-11 22:42:47 +03:00
Lauri Ojansivu b5f9097681 Updated translations. 2026-07-11 22:42:29 +03:00
Lauri Ojansivu b227a93193 Fix #6446: let board members (not only admins) move cards between swimlanes
In the swimlanes view, boardBody.js disabled the .js-swimlanes sortable — which
also carries moving a card from one swimlane to another — with !isBoardAdmin(),
though its own comment said it should be disabled only for non-members. So a normal
board member could move a card within a swimlane but not between swimlanes (and
could not reorder swimlanes). Gate it on !Utils.canModifyCard() instead (the client
write-access predicate: board member, not comment-only/worker/read-only), matching
the server's allowIsBoardMemberWithWriteAccess.
2026-07-11 22:38:18 +03:00
Lauri Ojansivu 52c62021a9 Updated translations 2026-07-11 22:10:54 +03:00
Lauri Ojansivu 692a258758 Updated ChangeLog. 2026-07-11 22:08:40 +03:00
Lauri Ojansivu 8847798f3c Release: update official + unofficial Node.js download URL paths on wekan.fi install page
The install page (../w/wekan.fi/install/index.html) links to Node.js downloads for
each snap/bundle arch: the OFFICIAL nodejs.org build (amd64/arm64/s390x/ppc64le)
and the UNOFFICIAL unofficial-builds.nodejs.org build (riscv64, which nodejs.org
has no binary for). release-website.sh only updated the displayed Node.js version
number, and version.sh's local website block did not touch Node.js at all, so those
download URLs went stale (404) after a Node.js bump.

Both now rewrite the version in the nodejs.org/dist/vX.Y.Z and
unofficial-builds.nodejs.org/download/release/vX.Y.Z paths and the
node-vX.Y.Z-linux-<arch> filename to the current Dockerfile NODE_VERSION.
2026-07-11 22:08:40 +03:00
github-actions[bot] 087d9fd0d8 Bump versions for v9.86 2026-07-11 17:54:20 +00:00
Lauri Ojansivu da55f1c413 Updated ChangeLog. 2026-07-11 20:53:16 +03:00
Lauri Ojansivu 28b4c6687c gitignore: also ignore locally-cloned wekan/mongo-tools and wekan/mongosh
FerretDB/ and sandstorm/ were already ignored; add /mongo-tools/ and /mongosh/ so
that temporarily cloning those wekan repos under this repo for editing never risks
committing them (they are separate git repos).
2026-07-11 20:23:17 +03:00
Lauri Ojansivu 10db1c3e76 Snap: automated release publishes to candidate + beta + edge (core24), not stable
core24 allows the candidate channel (core26 does not), so the automated
release-all.yml snap job publishes to candidate + beta + edge. The stable channel
is not published by the workflow — it is done manually later once proven. Updated
the workflow, snapcraft.yaml header, CHANGELOG and CPU-platforms.md.
2026-07-11 20:18:19 +03:00
Lauri Ojansivu 1a376b5dde Snap: automated release publishes to edge + beta (stable is manual, core24)
The default snapcraft.yaml is base: core24 (grade: stable) so it CAN be published
to the Snap stable channel, but that is done manually once it is proven stable
enough (core26 cannot go to stable). Revert the automated release-all.yml snap job
to publish to edge + beta channels (was candidate + edge). Update the workflow
header, snapcraft.yaml header, CHANGELOG and CPU-platforms.md to match.
2026-07-11 20:15:57 +03:00
Lauri Ojansivu e20dd132c1 Bundle-centric snap; self-contained bundle launchers restart-loop FerretDB + WeKan
Bundle launchers (releases/ferretdb/start-wekan.sh/.bat): run the bundle's own
per-platform binaries — FerretDB (./ferretdb[.exe]) in the background and WeKan
(./main.js on the bundled ./node[.exe]) in the foreground — inside a restart loop,
so if WeKan exits the whole stack restarts. Ctrl-C / closing the window stops both.

Snap wekan part: the wekan-<arch>.zip bundle is now the single source of every
binary. Handle all snap arches (amd64, arm64, s390x, ppc64el->ppc64le, riscv64);
use the bundle's OWN arch-correct Node.js (fixes riscv64, which nodejs.org has no
build for) instead of re-downloading from nodejs.org; move the bundle's per-arch
MongoDB Database Tools into $SNAP/bin; keep the bundle's ferretdb. Drop the
separate mongotools part (the tools already ship in the bundle), so nothing is
downloaded twice.
2026-07-11 20:13:00 +03:00
Lauri Ojansivu 64da38b412 Embed MongoDB Database Tools (wekan/mongo-tools) in all WeKan builds
Previously the per-arch MongoDB Database Tools were only in the Snap and the
Windows bundle. Now every build embeds them from the wekan/mongo-tools fork's
newest release (per-arch <tool>-<arch>):

- Linux .zip bundles (amd64/arm64/s390x/ppc64le/riscv64) download their arch's 8
  tools; the win64 and macOS jobs drop the inherited Linux tools and add their own
  (win64 .exe, mac-arm64). The Docker image inherits them from the Linux bundle.
- Sandstorm build-deps.sh adds the amd64 tools (separate from the legacy MongoDB
  3.2 migratemongo CLIs used for the one-time migration).

All from wekan/mongo-tools, none from mongodb.com.
2026-07-11 20:02:57 +03:00
Lauri Ojansivu 2a6bdadc15 Drop mongosh, use bundled Node.js + mongodb driver; FerretDB/mongo-tools per-arch; snap FerretDB-only arches
Databases / MongoDB clients:
- Remove the mongosh binary everywhere (snap + bundles). All scripted DB access
  (readiness ping, replica-set initiate/status, v8.43 schema migration) now runs
  through the new snap-src/bin/db-eval (bundled Node.js 24 + the mongodb driver).
  Ports wekan-control, mongodb-control, migration-control, start-wekan.sh/.bat and
  migrate-schema-v843.js -> .mjs off mongosh. The legacy MongoDB 3.2 mongo shell
  (migratemongo, amd64) stays for migration-time reads only.
- MongoDB Database Tools now come from the wekan/mongo-tools fork (pure Go, every
  arch) instead of mongodb.com, in snapcraft and the Windows bundle. version.sh /
  test-download-urls.sh no longer probe mongodb.com for mongosh/tools. The MongoDB 7
  server (mongod) is still fetched from MongoDB (amd64/arm64 only).
- FerretDB v1 downloaded per-arch (ferretdb-<arch>) from wekan/FerretDB, no
  ferretdb.zip: release-all.yml bundle jobs, docker-compose.yml, sandstorm build.

Snap:
- Default snapcraft.yaml is now the core24 grade:stable build (core26 variant kept
  as snapcraft-core26.yaml); release publishes to candidate + edge.
- Add s390x, ppc64el, riscv64 platforms as FerretDB-only (mongod not built there);
  new installs default to FerretDB v1 (snap/hooks/install already guards existing
  MongoDB data), DDP_TRANSPORT=sockjs. Fix Caddy ppc64el->ppc64le mapping.

Docs: add docs/Platforms/FOSS/Snap/CPU-platforms.md; update CHANGELOG and the
Sandstorm migration doc.
2026-07-11 15:37:56 +03:00
Lauri Ojansivu 7598859a47 Updated ChangeLog. 2026-07-11 13:20:39 +03:00
Lauri Ojansivu 4a94793f68 At default docker-compose.yml, changed DDP_TRANSPORT from uws to sockjs, because uws does not work at s390x.
Thanks to xet7 !
2026-07-11 13:20:39 +03:00
github-actions[bot] d4b19389eb Bump versions for v9.85 2026-07-11 09:05:59 +00:00
Lauri Ojansivu b24bf69d6c Updated ChangeLog. 2026-07-11 11:56:16 +03:00
Lauri Ojansivu 5cc9b1dcbb Docker: add "Build from source & start" menu action; remove obsolete compose version: attribute
Add a "Build from source & start (up -d --build)" action to the Docker
menus in rebuild-wekan.sh and rebuild-wekan.bat. It builds the wekan-app
image from the local Dockerfile, tags it as the image the chosen compose
file references (ghcr.io/wekan/wekan:latest), and starts that freshly
built container instead of a possibly-stale prebuilt image pulled from
the registry - useful when a source change (e.g. the FerretDB
Version-page detection) is not in the pulled image yet.

Remove the obsolete top-level "version:" attribute from all docker
compose files, which Docker Compose v2 warns about and ignores:
docker-compose.yml, docker-compose-ferretdb-v2-postgresql.yml,
docker-compose-multitenancy.yml, .devcontainer/docker-compose.yml, and
docs/Databases/ToroDB-PostgreSQL/docker-compose.yml.

Thanks to xet7 !
2026-07-11 11:52:03 +03:00
Lauri Ojansivu 4dbf99010c Docker: make FerretDB v1 + SQLite the default docker-compose.yml
Rename docker-compose-ferretdb-v1-sqlite.yml -> docker-compose.yml (the
new default) and the old MongoDB docker-compose.yml ->
docker-compose-mongodb-v7.yml, so "docker compose up -d" uses the light,
self-contained FerretDB v1 + embedded SQLite from
https://github.com/wekan/FerretDB by default.

Update rebuild-wekan.sh and rebuild-wekan.bat Docker menus to list
FerretDB v1 SQLite first (default) and point at the new filenames.
Update the compose files' own header comments (self-identification and
cross-references), note the new default at the top of docker-compose.yml,
and update the Docker docs (main Docker.md gets a compose-file/database
map; FerretDB2-PostgreSQL.md points at the v2 postgresql compose file).

Thanks to xet7 !
2026-07-11 11:35:47 +03:00
Lauri Ojansivu 544e1b14b4 rebuild-wekan.sh/.bat: Dev server also frees rspack :8080 on restart; add "Kill all dev servers"
The Dev server options killed only the app port, but "meteor run" also
starts an rspack dev server on 8080 that can outlive the meteor parent.
A leftover one made restarting a dev server crash with
"Error: listen EADDRINUSE ... :8080". The kill now frees both the app
port and the rspack port 8080 (Meteor.devServerPort || 8080), matching
the rspack watcher by its devServerPort env.

Port detection now checks the listening socket directly (ss/lsof with a
bash /dev/tcp fallback that needs no external tools; netstat on .bat)
instead of an HTTP probe, so it also catches a server that is still
building and not yet serving. Fixes a hang where lsof did reverse-DNS
without -nP.

Add a new "Dev server -> Kill all dev servers" menu option that frees
every dev/test port the scripts use at once: dev app 3000 + Mongo 3001,
Mocha test server 3100 + Mongo 3101, Sandstorm standalone dev 4000 +
Mongo 4001, and rspack 8080. It kills meteor, the rspack watcher and
Meteor's bundled --replSet meteor Mongos, never a production/system
Mongo. Both scripts escalate to SIGKILL if a port does not free up.

Update CHANGELOG and Build-from-source.md docs.

Thanks to xet7 !
2026-07-11 11:30:25 +03:00
Lauri Ojansivu 5ef2adf6fb rebuild-wekan.sh/.bat: Dev server options kill existing Meteor on the port; docs for new menu
Every "Dev server" menu option now stops any Meteor dev server already
listening on its port before starting a fresh one, so re-running a dev
option no longer fails because the port is taken. .sh adds a reusable
kill_meteor_on_port helper called by all six dev options; .bat funnels
them through :runlog, which calls a new :kill_meteor_on_port (netstat +
taskkill). Both wait for the port to free up and escalate to SIGKILL.

Also update the build-from-source docs (README.md, Build-from-source.md,
Build-and-Create-Pull-Request.md, Emoji.md, and the two Sandstorm
developer docs) to the new two-level menu (Setup -> Install dependencies,
Setup -> Build WeKan, Dev server -> localhost:3000), fix a stale
dev-server port (localhost:4000 -> 3000), and fix the README anchor link
to the renamed heading. Add a CHANGELOG entry.

Thanks to xet7 !
2026-07-11 11:11:22 +03:00
Lauri Ojansivu ccc03913fc i18n(fi): translate Sandstorm 'grain' as 'jyva' (jyvassa/jyvan)
Use the Finnish term jyva for Sandstorm grain in the sandstorm-migration
strings: Sandstorm-jyvassa, jyvan hakemistoihin, kayttavat jyvassa, jyvan
levytilan.
2026-07-11 10:47:13 +03:00
Lauri Ojansivu af62ebd97a i18n: Finnish translations for the Sandstorm migration admin panel strings
Translate the 12 sandstorm-migration-* strings in fi.i18n.json, matching the
existing WeKan Finnish terminology (siirto, Liitetiedostot, Profiilikuvat,
tiedostojärjestelmä, Poista, Tallennustila). The proper noun Sandstorm and the
literal paths/DB names are kept as-is.
2026-07-11 10:43:54 +03:00
Lauri Ojansivu f25c6553bd Updated translations 2026-07-11 10:40:13 +03:00
Lauri Ojansivu c72ae4cf05 i18n: don't translate the project name 'Sandstorm' (hardcode it)
Remove the en.i18n.json key sandstorm-migration whose value was the bare
proper noun 'Sandstorm' (the https://sandstorm.org project name), and hardcode
'Sandstorm' in the Admin Panel / Attachments tab label and panel title instead.
The other sandstorm-migration-* keys are real translatable strings and stay.
2026-07-11 10:35:01 +03:00
Lauri Ojansivu 43dcf56a3b rebuild-wekan.sh/.bat: group menu into category submenus + two-stage Docker menu
Replace the long flat menu with a short top-level menu (Setup / Dev server /
Tests / Docker / Tools / Quit); each opens a small submenu with 0) Back, so
only a few items show at once and labels are shorter (category gives context).
Docker becomes a two-stage submenu: pick backend, then Start (up -d) / Follow
logs (logs -f) / Stop (down) -- removing 12 near-identical flat entries.

All action handlers are unchanged; only the front-end dispatch is regrouped:
.sh keeps every case handler and reaches them via a choose() 'short|full' map
(dispatch wrapped in 'for _once in 1'); .bat routes category submenus to the
existing :labels. Verified: .sh bash -n clean + all 23 menu labels map to a
handler; .bat has no orphan gotos.
2026-07-11 07:31:23 +03:00
Lauri Ojansivu 1778929869 rebuild-wekan.sh/.bat: add Follow logs / Stop docker menu options per compose file
Expands the docker-compose menu so each backend (MongoDB docker-compose.yml,
FerretDB v1 SQLite, FerretDB v2 PostgreSQL, MongoDB Multitenancy) has three
grouped entries -- Start (up -d), Follow logs (logs -f) and Stop (down) --
instead of just Start. The .sh uses a generalized wekan_docker helper that
auto-detects 'docker compose' vs legacy 'docker-compose'.
2026-07-11 07:04:14 +03:00
Lauri Ojansivu d50277721c rebuild-wekan.sh/.bat: add menu options to start WeKan Docker per compose file
New menu entries run 'docker compose -f <file> up -d' for each backend:
MongoDB (docker-compose.yml), FerretDB v1 SQLite, FerretDB v2 PostgreSQL,
and MongoDB Multitenancy. Each prints follow-logs + stop commands. The .sh
auto-detects 'docker compose' vs legacy 'docker-compose'.
2026-07-11 06:57:48 +03:00
Lauri Ojansivu f1749b2af7 docker-compose ferretdb v1-sqlite: drop leftover MONGODB_LOG_* debug env
The MONGODB_LOG_PATH/TOPOLOGY/SERVER_SELECTION/CONNECTION=debug vars were
temporary mongodb-driver diagnostics that got committed by accident; they
flood wekan-app logs with topology JSON. Remove them from the example compose.
2026-07-11 06:49:16 +03:00
Lauri Ojansivu d0d98bcadc FerretDB: --log-level=error to silence connection WARN spam; remove dead MongoDB-driver subsystem
Driver debug logs showed a 2nd, TLS-enabled Mongo monitor connection
retrying every ~0.5s against the plaintext FerretDB port; FerretDB logged
each rejection at WARN. Harmless (WeKan uses the real plaintext connection)
but noisy. Start FerretDB with --log-level=error everywhere it is launched
(Docker entrypoint, snap ferretdb-control, release start-wekan.sh, the
v1-sqlite compose example).

Also remove the dead, unused MongoDB Driver System (server/mongodb-driver-startup.js
and models/lib/{meteorMongoIntegration,mongodbConnectionManager,mongodbDriverManager}.js)
- an abandoned MongoDB 3.0-8.0 auto-detect/driver-select experiment whose
driver packages were never installed. WeKan uses the mongodb-7 driver via Meteor.

gitignore the local FerretDB/ reference clone.
2026-07-11 06:28:30 +03:00
Lauri Ojansivu 743a47c462 snap: install Caddy from GitHub release binary, not Cloudsmith apt repo
The caddy part fetched Caddy from the Cloudsmith apt repo
(curl dl.cloudsmith.io | gpg --dearmor), which fails on Launchpad remote
builders (restricted network via a fetch proxy): gpg got no key
('no valid OpenPGP data found') and override-build failed with code 2 on
both arches. Download the official prebuilt vanilla Caddy static binary from
GitHub releases instead (per-arch, latest stable + pinned fallback). WeKan
uses only built-in Caddy directives, so no apt repo, gpg, or xcaddy needed.
Applied to both snapcraft.yaml and snapcraft-core24.yaml.
2026-07-11 05:56:25 +03:00
Lauri Ojansivu cfa5707a40 Admin Panel / Version: detect FerretDB via top-level ferretdbVersion
The wekan/FerretDB v1 fork's buildInfo reports a top-level ferretdbVersion
string (e.g. v1.24.2-60-gb5523566) + ferretdbFeatures, and its commit in
gitVersion -- not a ferretdb sub-document. Detection only checked
buildInfo.ferretdb, so the Version page showed Database type: MongoDB and
hid the FerretDB rows. Handle both shapes: top-level ferretdbVersion/
ferretdbFeatures and the ferretdb sub-document. Also confirm in the Sandstorm
doc that FerretDB writes <dir>/wekan.sqlite (+ -shm/-wal).
2026-07-11 05:40:14 +03:00
Lauri Ojansivu b8a7a2e114 Sandstorm: keep niscu migration, build from upstream 0.6.0 (drop projects.7z/releases.wekan.team)
- start.js: chain niscu (2.x) -> MongoDB 3.0 -> FerretDB; keep niscud + old
  bundled driver for the niscu->3.0 stage. Migration from old versions is
  permanent (not dropped).
- build-deps.sh (new): assemble a modern meteor-spk.deps on top of upstream
  meteor-spk 0.6.0 from dl.sandstorm.io (already has mongod 3.0 + niscud);
  swap in Node 24, add FerretDB + Mongo 3.x CLIs + launcher/importer, keep
  niscud. Extra binaries from GitHub releases. Nothing needed from projects.7z.
- sandstorm.yml: replace the dead releases.wekan.team/projects.7z download with
  build-deps.sh.
- sandstorm-pkgdef.capnp: WRITABLE_PATH -> /var/files.
- docs: keep-niscu + build-source corrections; migration support is permanent.
2026-07-11 05:07:43 +03:00
Lauri Ojansivu 1237e4c2de Sandstorm: add grain launcher sandstorm-src/start.js (Node24 + FerretDB + migration)
CJS meteor-spk.deps launcher: on grain start, if old MongoDB 3.0 data exists and
migration is not yet done, start mongod 3.0 (wait for ready), start FerretDB v1
(SQLite), run migrate-mongo3-to-ferretdb (text -> FerretDB, GridFS attachments/
avatars -> /var/files), mark done (old data kept); then run WeKan (Node 24) on
FerretDB steady-state. Paths resolve from __dirname (grain mount root). Update
the design doc to point at the canonical file and mark the in-app panel done.
2026-07-11 04:50:36 +03:00
Lauri Ojansivu 61792f59c1 gitignore: ignore local projects/ and sandstorm/ build working copies
projects/ (unarchived meteor-spk fork binaries) and sandstorm/ (clone of
sandstorm-io/sandstorm) are large, machine-specific working copies used only
when building the Sandstorm .spk; never commit them.
2026-07-11 04:47:42 +03:00
Lauri Ojansivu 664c6e1943 Sandstorm: Admin Panel / Attachments / Sandstorm migration panel
When isSandstorm, show a new Sandstorm section in Admin Panel / Attachments:
one-time MongoDB 3 -> FerretDB migration status, disk space used by the raw
MongoDB 3 files / FerretDB SQLite / attachments / avatars in the grain, and a
guarded button to delete the redundant raw MongoDB files (only after a
confirmed-successful migration, behind a confirm) to free grain disk space.

- server/methods/sandstormMigration.js: admin-gated sandstormMigrationStatus
  + sandstormDeleteRawMongo (isSandstorm-gated, env-overridable grain paths).
- client Attachments: new Sandstorm tab (jade + js), shown only when isSandstorm.
- imports/i18n/data/en.i18n.json: sandstorm-* UI strings.
- migrate-mongo3-to-ferretdb.mjs: optional STATUS_FILE with the final migration
  state, which the panel reads (shared by snap + the Sandstorm spk).
2026-07-11 04:39:24 +03:00
Lauri Ojansivu 9d90b869cd docs: move Sandstorm Meteor3 migration doc under FOSS/Sandstorm
Existing Sandstorm docs live under docs/Platforms/FOSS/Sandstorm/; move the
new Meteor3/Migration.md there (was mistakenly at docs/Platforms/Sandstorm/),
fix its relative links (one level deeper) and the CHANGELOG path.
2026-07-11 04:39:01 +03:00
Lauri Ojansivu 453770ef98 docs: Sandstorm Meteor3/Node24 + MongoDB3->FerretDB migration design
Add docs/Platforms/Sandstorm/Meteor3/Migration.md: how to build a modern
Sandstorm .spk (Node 24, FerretDB v1 SQLite) migrating an existing grain's
MongoDB 3.0 data on first launch, reusing the snap's migrate-mongo3-to-ferretdb
logic. Includes seccomp compatibility analysis, rewritten start.js, and a new
isSandstorm-only Admin Panel / Attachments / Sandstorm section design.
2026-07-11 04:29:24 +03:00
github-actions[bot] a7f9018a60 Bump versions for v9.84 2026-07-11 00:21:01 +00:00
Lauri Ojansivu b6fe0a7256 Updated ChangeLog. 2026-07-11 03:11:16 +03:00
Lauri Ojansivu 02e3c35d69 Snap: show correct writable path for parallel installs in backup help
wekan.help backup/migration instructions hardcoded
/var/snap/wekan/common/files, which is wrong for a parallel snap install
(e.g. wekan_customer -> /var/snap/wekan_customer/common). Print
$SNAP_COMMON/files instead, which snapd sets per instance. Display-only;
all functional snap paths already derive from $SNAP_COMMON/$SNAP_DATA.
2026-07-11 03:03:23 +03:00
Lauri Ojansivu 4766b83da7 Fix flaky server-side Mocha i18n test (TAPi18n .loadLanguage)
The .loadLanguage suite stubbed addResourceBundle on the shared
TAPi18n.i18n singleton and asserted the call count. loadLanguage()
reads this.i18n late and each test re-init()s the singleton, so
cross-test state could leave the stub on a different i18next instance
than the bundle was registered on, making the count read 0 and the run
intermittently report 'expected addResourceBundle to be called once'.
Assert on observable i18next state (hasResourceBundle/getResourceBundle
under the normalised toI18nCode) instead, and stop a leaked
Tracker.autorun in the .getLanguage reactive test.
2026-07-11 02:40:34 +03:00
Lauri Ojansivu 011c172c8c Fix scheduled backup cron init crashing at Meteor 3 server startup
registerCron() used the synchronous BackupSettings.findOne/upsert, which
Meteor 3 forbids on the server, so cron init threw and scheduled backups
never registered. Use findOneAsync/upsertAsync, make registerCron async,
and await it in all callers. Add tests/backupCron.test.cjs (positive +
negative + source guard) to the test:unit:node suite.
2026-07-11 01:53:07 +03:00
xet7 cb18f9b735 Updated ChangeLog. 2026-07-11 01:31:38 +03:00
xet7 abe8af0788 Fix backup build: archiver@8 ESM (ZipArchive) + add @aws-sdk/lib-storage dep
The Meteor/rspack build failed on server/methods/backup.js:
- archiver@8 is now pure ESM with no default export and no archiver('zip', …)
  factory — it exports classes. Use `import { ZipArchive } from 'archiver'` and
  `new ZipArchive({ zlib: { level: 6 } })` (the streaming API — directory/append/
  finalize/pipe/on — is inherited from the Archiver core class).
- The S3 streaming upload requires @aws-sdk/lib-storage, which was not a
  dependency (only @aws-sdk/client-s3 was), so rspack failed with
  "Can't resolve '@aws-sdk/lib-storage'". Add it, pinned to ~3.1073.0 to match
  the installed @aws-sdk/client-s3 (3.1073.0) and avoid the newer lib-storage's
  peer requirement on a newer client-s3.
2026-07-11 01:31:05 +03:00
xet7 997f1fb9df Updated ChangeLog.
Refresh the Upcoming section: re-point every commit link to the current hash
(the earlier links referenced pre-rebase hashes that are not on GitHub), and add
bullets for the newest commits — Transifex duplicate-key fix, Finnish
translations, unit + negative tests, and the Alternative-Architectures doc.
2026-07-11 00:51:44 +03:00
xet7 9828081c76 docs: add Design/Multiverse/Alternative-Architectures.md
Document which CPU architectures WeKan can run on and why, the architecture
matrix (Node 24 vs MongoDB vs FerretDB v1), why armhf/armv7l/i386/loong64 are
not supported (Node dropped 32-bit; QEMU/base-image gaps for loong64), the
JavaScript-engine alternatives (Deno/Bun cover fewer arches; QuickJS/JSC/
SpiderMonkey/JVM run on 32-bit but cannot run Meteor), and the server-rewrite
options (Go recommended, QuickJS niche, Tcl/Tk a poor fit for a web app), plus
hardware notes (ODroid-U3, Raspberry Pi OS 32-bit, ReactOS).
2026-07-11 00:46:13 +03:00
xet7 d2ec3ee400 Unit + negative tests for newest features (lazy loading, streaming export, backup)
Extract the pure, security- and correctness-critical logic of the recent features
into Meteor-free models/lib/* modules (so production and tests share one
implementation) and add plain-Node tests with positive AND negative cases, wired
into test:unit:node:

- models/lib/mongoSelectorSafety.js hasWhere() — the windowed card publication
  refuses a client selector carrying $where (server-side JS). Tests: safe
  selectors pass; $where at top level / in $and / deep in arrays / in $elemMatch
  is rejected. (was inline in server/publications/cardsWindow.js)
- models/lib/cardsLoading.js resolveCardsLoadingMode / parseCardsLoadingEnv /
  windowCountId — CARDS_LOADING maps to 'lazy' only for exactly "lazy" (garbage
  never enables the experimental mode); a falsy swimlane id collapses to one
  count-doc id (listBody uses undefined, listHeader uses ''). (used by
  server/cards-loading.js, server/models/settings.js, client/lib/lazyCards.js)
- models/lib/base64Chunk.js encodeAligned/encodeFinal — streaming an attachment
  into the JSON export as base64 in any chunk sizes reconstructs exactly the
  whole-file base64; aligned pieces never carry padding. (used by
  Exporter.buildStream)
- models/lib/backupPaths.js filesRootFrom/scheduleText — WRITABLE_PATH -> files
  root (no double /files suffix, Windows-safe) and the synced-cron schedule text
  (daily/weekly/monthly + defaults, unknown frequency falls back to daily). (used
  by server/methods/backup.js)

41 new assertions across 4 files, all passing; whole test:unit:node suite green.
2026-07-11 00:14:49 +03:00
xet7 43006f9025 Finnish translations for newest features (Version, migration, backup, lazy loading)
Translate the remaining English strings for the CHANGELOG "Upcoming" features into
Finnish, matching existing terminology (Liitetiedostot, Profiilikuvat, Tallennustila,
Palauta, tiedostojärjestelmä, kokoelma, Tietokannan siirrot):
- Admin Panel / Version: Database_type/commit, FerretDB_version/commit,
  Reactivity_mode, MongoDB_version.
- Admin Panel / Attachments / Database migration (MongoDB <-> FerretDB v1).
- Admin Panel / Features: Card loading (all / lazy) + descriptions.
- Admin Panel / Attachments / Backup: schedule, storage, restore, list.
Product names and acronyms (FerretDB, MongoDB, SQLite, GridFS, S3/MinIO, Gantt,
LDAP, OAuth2, CAS) are kept as-is. 44 keys translated.
2026-07-10 23:56:07 +03:00
Lauri Ojansivu fcfd5bce9b Updated translations 2026-07-10 23:50:21 +03:00
xet7 4cbefed339 i18n: remove duplicate database-migration keys (Transifex parse_error)
en.i18n.json had two "database-migration" and two "database-migration-description"
keys, so the Transifex push failed with "Duplicate string key". The later
(block-2) copies — "Database Migration" / "Updating database structure..." — were
unused (only the Admin Panel / Attachments migration UI references these keys, and
it needs the MongoDB<->FerretDB wording in the earlier copy). Removed the unused
duplicates; JSON now parses with unique keys.
2026-07-10 23:40:11 +03:00
xet7 7d594c95ae Updated ChangeLog. 2026-07-10 22:57:40 +03:00
xet7 7d5f29e114 Lazy card loading: accurate card counters and WIP limits
In lazy mode minimongo holds only the loaded window, so the list card-counter
badge and the WIP-limit checks (reachedWipLimit / exceededWipLimit, the add-card
gate, and setting the WIP limit to the current count) previously reflected only
the cards loaded so far. They now use lazyListCardCount(), which subscribes to
and reads the server-side count for the SAME selector list.cards(swimlaneId) uses
(listCardsSelector + the board Filter) — so the count is exactly the accurate
value list.cards(swimlaneId).length would report if every card were loaded. The
template's whole-list count uses (cards.length) are routed through a new
cardsCountWhole helper the same way. Default 'all' mode falls back to the loaded
length and is unchanged.
2026-07-10 22:57:40 +03:00
xet7 29b617769a Updated ChangeLog. 2026-07-10 22:57:40 +03:00
xet7 f0d25a2431 Expose CARDS_LOADING on all platforms (docker-compose, launchers, snap)
Adds the CARDS_LOADING=all|lazy knob everywhere WeKan is configured:
- docker-compose.yml and the two FerretDB compose files (v1-sqlite, v2-postgresql)
- releases/ferretdb/start-wekan.sh and start-wekan.bat (bundle launchers)
- releases/virtualbox/start-wekan.sh
- snap: added to snap-src/bin/config keys + triplet, so
  "snap set wekan cards-loading=lazy" works, with an example in wekan-help.
All default to 'all' (unchanged behaviour).
2026-07-10 22:57:40 +03:00
xet7 09805a8a91 Lazy card loading (client) + Admin Panel / Features section
Client side of CARDS_LOADING=lazy. In lazy mode each list's cardsWithLimit
subscribes to boardCardsWindow for just the cards it renders (growing with the
infinite-scroll limit) and to boardListCardCount for the total; showSpinner uses
that server count to decide whether more cards remain, since minimongo now holds
only the loaded window. Default 'all' mode is unchanged (helpers short-circuit on
isLazyCards()).

Adds Admin Panel / Features — a new admin section (route /admin-features, nav
entry, adminFeatures template) intended as the home for optional / performance /
future tier-gated capabilities. First control: "Card loading" (all | lazy), which
writes the cardsLoading Setting; it mirrors, and is overridden on startup by, the
CARDS_LOADING env var. Includes an experimental-note (counters/WIP limits and the
Calendar/Table/Gantt views reflect only loaded cards; reload boards after change)
and the i18n keys.
2026-07-10 22:57:40 +03:00
xet7 6f7ad270d1 Lazy card loading (server): CARDS_LOADING=all|lazy + windowed publications
Adds an opt-in card-loading mode for very large boards. Default 'all' is
unchanged: the board publication still ships every card into minimongo.

When CARDS_LOADING=lazy (env) or Admin Panel / Features = lazy:
- The board publication no longer ships all cards, their comments/attachments,
  or the board-level checklists/checklistItems (gated by a lazyCards() check).
- A new publish-composite 'boardCardsWindow' publishes only the cards of one
  list/swimlane window (the client passes the exact selector it renders with,
  which is ANDed with a server-forced { boardId, archived:false } scope and
  refuses $where), plus each visible card's comments, attachments, checklists
  and checklist items. As the user scrolls the client raises the limit and
  re-subscribes, streaming more cards in on demand.
- A 'boardListCardCount' publication reactively publishes each window's total
  card count into the client-only boardListCardCounts collection, so the client
  knows whether more cards remain to load.

The mode is a Settings field (cardsLoading), seeded from the CARDS_LOADING env
var (authoritative on startup when set) and mirrored onto
Meteor.settings.public.cardsLoading for the publications to read; an
after.update hook keeps it in sync when an admin changes it.
2026-07-10 22:57:40 +03:00
xet7 bd1c611688 Updated ChangeLog. 2026-07-10 22:57:40 +03:00
xet7 ae9be62ef3 Export board to HTML .zip: stream to disk and include every card
The client HTML export cloned the live DOM and built the whole .zip as an
in-memory blob. Two problems on large boards: infinite scroll keeps only ~10
cards per list in the DOM, so most cards were missing from the export; and the
entire archive was buffered in browser RAM.

Before snapshotting, every list's cardlimit is now lifted so the whole board
renders (then we wait for Blaze to flush). The zip is written with JSZip's
generateInternalStream piped straight to the chosen file via the File System
Access API, chunk by chunk with backpressure, so the archive is never held
whole in memory; browsers without the API fall back to the previous blob
download.
2026-07-10 22:57:40 +03:00
xet7 41cd166358 Stream board exports (JSON, CSV/TSV, Excel) with bounded memory
The board export routes buffered the entire board in memory before sending:
JSON export built one object with every card, comment, activity, checklist and
base64 attachment; CSV called that same build(); Excel additionally loaded data
it never renders (activities/checklists/subtasks/rules) and did O(n^2)
result.cards.find() lookups. On big boards this peaked at gigabytes and could
exceed V8's max string length.

Now:
- Exporter.buildStream(res) writes the JSON document straight to the response a
  document at a time from raw Mongo cursors, encoding each attachment file to
  base64 in 3-byte-aligned chunks. Same _format/keys, so import round-trips.
- Exporter.buildCsvStream(res) keeps only the small lookup tables in memory and
  streams cards from a cursor, writing one CSV/TSV row at a time.
- ExporterExcel uses the exceljs streaming WorkbookWriter, committing each row
  to the response, drops the unused collections, and resolves parent/comment
  card titles via an id->title map instead of scanning all cards.
Peak memory stays flat regardless of board size.
2026-07-10 22:57:40 +03:00
xet7 e39dcd4ebf Backup: switch from jszip to archiver+unzipper for low-memory streaming
Admin Panel / Attachments / Backup no longer loads whole files or the whole
zip into memory. The backup zip is written with archiver, streaming each
attachment/avatar straight from disk (archive.directory) and each text
collection a document at a time from a Mongo cursor as NDJSON, piped directly
to the destination (filesystem or S3/Azure/GCS streaming upload) with no temp
file. Restore reads the zip with unzipper, piping each file entry to disk and
each NDJSON data entry line-by-line in 200-doc batches. A board with thousands
of cards or a 5 GB attachment now backs up/restores with flat memory.
2026-07-10 22:57:40 +03:00
xet7 4f1a60aa7b Updated ChangeLog. 2026-07-10 22:57:40 +03:00
xet7 5757cfc8ca Add standalone sandstorm.yml workflow; remove build-sandstorm from release-all.yml
Sandstorm packaging is not tested well enough yet, so it should not run as part of
a full release. Remove the build-sandstorm job from release-all.yml, and add a
separate, manually-triggered sandstorm.yml that ONLY builds the Sandstorm .spk and
uploads it as wekan-sandstorm-YYYY_MM_DD-HH_MM_SS.spk to the newest WeKan GitHub
Release (found via `gh release list`), plus a workflow artifact — so it can be
downloaded and tested for errors without affecting releases. Same experimental
caveats (unprivileged user namespaces, SANDSTORM_KEYRING signing secret).

Thanks to xet7.
2026-07-10 22:57:40 +03:00
xet7 c7c8a200ff Admin Panel / Attachments / Backup: scheduled backups of Attachments/Avatars/Data, streamed to storage; restore + list
Adds a Backup section to Admin Panel / Attachments:
- Checkboxes to select Attachments, Avatars and/or Data (all text-based
  collections that are not attachments/avatars).
- Storage dropdown (filesystem, S3/MinIO, Azure, GCS).
- Backup now: the .zip is STREAMED DIRECTLY to the selected storage — no temp
  file, no extra disk — as backup/YYYY/MM/DD/HH_MM_SS/backup.zip containing
  YYYY_MM_DD-HH_MM_SS/{attachments,avatars,data/<collection>.json}. Filesystem
  pipes to the file; S3 uses @aws-sdk/lib-storage streaming Upload, Azure
  uploadStream, GCS createWriteStream (cloud creds from the storage tabs).
- Scheduler (off/daily/weekly/monthly + time/day) saved and run via synced-cron.
- List backups: table with storage, datetime, path; select one and Restore with
  "Add missing data only" or "Replace all data".

Server methods (admin-only): runBackup, restoreBackup, listBackups,
getBackupSchedule, saveBackupSchedule, backupStatus (polled for live progress).

The cloud upload paths and restore are not exercised end-to-end here; the whole
zip is assembled with jszip, so very large attachment sets use notable memory.

Thanks to xet7.
2026-07-10 22:57:40 +03:00
xet7 71fcf2b454 Make migrate-mongo3-to-ferretdb.mjs executable 2026-07-10 22:57:40 +03:00
xet7 1dbc26d200 Updated ChangeLog. 2026-07-10 22:57:40 +03:00
xet7 84fee7b660 Admin Panel / Attachments: migrate text data between MongoDB and FerretDB v1 (SQLite), both directions
Adds a "Database migration" section to Admin Panel / Attachments with two buttons:
migrate text-based data (everything except attachments/avatars, which stay on the
filesystem) to FerretDB v1 (SQLite), or back to MongoDB.

WeKan is connected to one database at a time, so the new server methods open a
SECOND driver connection to the OTHER database (both MongoDB and FerretDB v1 speak
the MongoDB wire protocol) and copy the text collections from the live database
into it, upserting by _id (idempotent, re-runnable). The target URL is
WEKAN_FERRETDB_URL (default mongodb://127.0.0.1:27018/wekan) or WEKAN_MONGODB_URL
(default mongodb://127.0.0.1:27019/wekan); both must be running. Progress is polled
via migrateTextDatabaseStatus and shown live. After it finishes, point MONGO_URL at
the other database and restart (on Snap: snap set wekan database=ferretdb / =mongodb).

Admin-only. Attachments/avatars are skipped (they live on the filesystem).

Thanks to xet7.
2026-07-10 22:57:40 +03:00
xet7 3b7a276347 Updated ChangeLog. 2026-07-10 22:57:40 +03:00
xet7 02cf16d8c6 Snap migration: only MongoDB 3 migrates (via mongo CLI read + Node driver insert), FerretDB SQLite at files/db
Per the design: a MongoDB 7 database works with newest WeKan as-is and is NOT
migrated; only the old WeKan 6.09 / MongoDB 3.2 data is migrated to FerretDB v1.

- migration-control now: if mongod 7 can open the existing $SNAP_COMMON data it is
  MongoDB 6/7 -> no migration (mark done, keep MongoDB); otherwise it is MongoDB
  3.x -> migrate to FerretDB. The dump/restore-into-mongod-7 hop is removed.
- New importer migrate-mongo3-to-ferretdb.mjs reads MongoDB 3.2 with the legacy
  mongo CLI (mongoexport — the modern Node driver can't talk to 3.2) and inserts
  into a running FerretDB with the Node driver: text data streamed directly, and
  CollectionFS/Meteor-Files GridFS attachments+avatars reassembled per-file from
  exported chunks straight to files/attachments and files/avatars (no duplicate
  copy, no mongodump/mongorestore, no intermediate MongoDB 7). Progress at ROOT_URL.
- FerretDB SQLite now lives at <files>/db, next to attachments/avatars (the
  "files/<name>" layout), in ferretdb-control, migration-control, the offline
  start-wekan.sh/.bat, the Docker entrypoint and docker-compose-ferretdb-v1-sqlite.

The amd64 6.09/MongoDB-3.2 path is not yet tested against real 6.09 data.

Thanks to xet7.
2026-07-10 22:57:40 +03:00
xet7 54944717ee Updated ChangeLog. 2026-07-10 22:57:40 +03:00
xet7 b99d21d9f1 Snap migration: read MongoDB 3.2 via migratemongo CLI (dump -> restore into mongod 7), fix migrator NODE_PATH
The bundled Node MongoDB driver cannot connect to a MongoDB 3.2 server, and no
single driver version spans 3.2 and MongoDB 7 / FerretDB. So instead of aliasing
an old (EOL) Node driver into package.json, use the migratemongo CLI tools for the
amd64 6.09/3.2 case: migration-control now dumps the 'wekan' database with the old
migratemongo mongodump (MongoDB 3.2, old libraries), then loads it into a fresh
temporary mongod 7 with the snap's modern mongorestore. The existing driver-based
migrator then reads that mongod 7 exactly like the arm64 MongoDB-7 case (both
GridFS types -> filesystem, text -> FerretDB v1 SQLite). The MongoDB-7 path
(arm64 + amd64-on-newest-WeKan) connects the driver directly, unchanged.

Also fix a real bug: the standalone migrator script in $SNAP/bin could not resolve
its `mongodb`/`bson` imports; set NODE_PATH to the WeKan bundle's node_modules.

Thanks to xet7.
2026-07-10 22:57:40 +03:00
xet7 3dfd84973c Updated ChangeLog. 2026-07-10 22:57:40 +03:00
xet7 dd4611e43f Snap migration: bundle migratemongo (MongoDB 3.2 binaries + old libs + AVX wrappers) and use it to read 6.09 data
Per docs/Backup/Backup.md and https://github.com/wekan/migratemongo, running the
old MongoDB tools/server in the snap needs LC_ALL=C, the mongo binaries on PATH,
and their libraries on LD_LIBRARY_PATH ($SNAP/lib/<arch>-linux-gnu). The 2016
MongoDB 3.2 binaries additionally need old libraries (libssl/libcrypto.so.1.0.0,
libpng12, libexpat) that modern bases lack.

- Add a migratemongo snapcraft part (both snapcraft.yaml and snapcraft-core24.yaml)
  that stages https://github.com/wekan/migratemongo at $SNAP/migratemongo (bin/ =
  MongoDB 3.2 binaries, lib/x86_64-linux-gnu/ = the old libraries, avx/ = QEMU
  wrappers for non-AVX CPUs), amd64 only. This also fills in the
  $SNAP/migratemongo/avx path that mongodb-control / mongodb-backup /
  mongodb-restore already referenced but was never bundled.
- Replace the naive fresh-download mongodb-old part (a bare 3.2 mongod with no old
  libs) with this.
- migration-control now reads the amd64 6.09 MongoDB 3.2 data with
  $SNAP/migratemongo/bin/mongod, LD_LIBRARY_PATH=$SNAP/migratemongo/lib/..., and
  the legacy $SNAP/migratemongo/bin/mongo shell (mongosh cannot talk to 3.2). The
  MongoDB 7 path (arm64 + amd64-on-newest-WeKan) still uses the snap's mongod 7 +
  mongosh.

Thanks to xet7.
2026-07-10 22:57:40 +03:00
xet7 69e6b8bcd1 Updated ChangeLog. 2026-07-10 22:57:40 +03:00
xet7 6ab29dc81e Snap: one-time MongoDB -> FerretDB v1 migration on upgrade (arm64 Mongo7 + amd64 6.09)
On first boot after upgrading an old MongoDB-based WeKan snap, mongodb-control now
hands off to a new migration-control before starting mongod:

- Detects existing MongoDB data in $SNAP_COMMON and opens it with the right
  bundled mongod: mongod 7 for MongoDB 7 data (all arches, including the arm64
  snaps already on newest WeKan), or a bundled old mongod 3.2 (amd64 only, new
  mongodb-old part) for WeKan 6.09 / MongoDB 3.2 data.
- Starts a temporary FerretDB v1 (SQLite) and runs migrate-mongodb-to-ferretdb.mjs,
  which migrates text data to FerretDB and BOTH CollectionFS GridFS and
  Meteor-Files GridFS attachments+avatars to the filesystem, shows a live progress
  counter at ROOT_URL, checkpoints to $SNAP_COMMON (resumable), and compacts the
  old MongoDB when done.
- On success switches the snap to database=ferretdb.

Idempotent (migration-pending helper + completion marker), resumable, never
deletes the source MongoDB data, only switches on success. The migrator is bundled
into the snap (/bin). Progress dashboard title fixed to 'MongoDB -> FerretDB'.

NOT yet tested end-to-end against a real 6.09 snap; in particular the 2016 mongod
3.2 binary may need extra runtime libraries on a modern base (amd64 6.09 path).
The arm64/MongoDB-7 path uses the already-bundled mongod 7.

Thanks to xet7.
2026-07-10 22:57:40 +03:00
xet7 9ae6a91daf Fix compose commit link in ChangeLog 2026-07-10 22:57:40 +03:00
xet7 c3674330ac Updated ChangeLog. 2026-07-10 22:57:40 +03:00
xet7 be5ddd77ef Rename docker-compose-ferretdb.yml to ...-v2-postgresql.yml and add ...-v1-sqlite.yml
- docker-compose-ferretdb.yml -> docker-compose-ferretdb-v2-postgresql.yml
  (FerretDB 2 + PostgreSQL/DocumentDB, unchanged database).
- Add docker-compose-ferretdb-v1-sqlite.yml: FerretDB v1 with the embedded SQLite
  backend, no PostgreSQL/MongoDB. Its ferretdb service fetches the v1 binary for
  its architecture from the newest wekan/FerretDB release
  (https://github.com/wekan/FerretDB/releases), caches it on the volume, and runs
  it with --handler=sqlite.

Both compose files now carry the FULL wekan service from docker-compose.yml
(every documented environment variable and feature); the ONLY differences are
database-related: the ferretdb service replaces the mongodb service, MONGO_URL
points at FerretDB, MONGO_OPLOG_URL is dropped and METEOR_REACTIVITY_ORDER is
polling (FerretDB has no MongoDB change streams / replica-set oplog).

Thanks to xet7.
2026-07-10 22:57:40 +03:00
xet7 9fc88a783c Updated ChangeLog. 2026-07-10 22:57:39 +03:00
xet7 748fd2d391 Snap: migrate Caddyfile v1 -> v2 format when caddy is enabled
When upgrading from an old WeKan snap, $SNAP_COMMON/Caddyfile may still be in
Caddy v1 format, which Caddy 2 cannot parse (so caddy would fail to start).
caddy-control now runs migrate-caddyfile-v1-to-v2.sh before 'caddy run' when
caddy is enabled. It is safe: a no-op if the file already parses as Caddy 2;
otherwise it backs up the original, converts the common v1 directives (drop the
http:// scheme, 'proxy / TARGET' -> 'reverse_proxy TARGET', drop the v1
'websocket'/'transparent' presets that Caddy 2 does by default, 'gzip' ->
'encode gzip'), validates the result with 'caddy adapt', and only keeps it if
valid — falling back to the shipped Caddy 2 template otherwise, so caddy always
starts with valid config.

Thanks to xet7.
2026-07-10 22:57:39 +03:00
xet7 4ac24dc546 Updated ChangeLog. 2026-07-10 22:57:39 +03:00
xet7 4c630d4ba8 migrate-mongodb-to-ferretdb: resumable progress in WRITABLE_PATH + compact old MongoDB after success
Two additions to the MongoDB -> FerretDB / GridFS -> filesystem migrator used by
the Snap and Sandstorm migrations:

- Resumable: progress is checkpointed to $WRITABLE_PATH/migration-progress.json
  (atomic write) after every collection and file phase. On restart the migrator
  loads the checkpoint and SKIPS collections it already finished, so an
  interrupted migration (snap refresh, Sandstorm grain restart, power loss)
  continues instead of starting over. Safe because every document is upserted.

- Compact after success: once the migration is complete (fresh run, or a later
  boot that finds the completion marker), it runs 'compact' on each source
  MongoDB collection so WiredTiger returns the now-duplicated disk space to the
  OS. Runs once (tracked by a 'compacted' flag on the marker) and is best-effort.

The existing ROOT_URL progress dashboard and disk-space checks (statfsSync) are
kept; the dashboard is restored from the checkpoint on resume.

Thanks to xet7.
2026-07-10 22:57:39 +03:00
xet7 a563d3c4b2 Updated ChangeLog. 2026-07-10 22:57:39 +03:00
xet7 95b186e50a release-all.yml: add build-sandstorm job to pack and attach wekan-<version>.spk
Mirrors releases/release-sandstorm.sh + releases/install-sandstorm.sh: installs
Meteor, meteor-spk 0.6.0 (from the WeKan projects.7z) and a dev Sandstorm, then
'meteor-spk pack' produces wekan-<version>.spk and attaches it to the GitHub
Release. Decoupled from the release job so it never blocks the core release.

EXPERIMENTAL in CI: Sandstorm needs unprivileged user namespaces (GitHub's Ubuntu
VMs allow them), and meteor-spk signs the .spk with the app private key from the
Sandstorm keyring -> provide it as the SANDSTORM_KEYRING secret. 'spk publish' to
the app market and the scp upload stay manual, as in release-sandstorm.sh.

Thanks to xet7.
2026-07-10 22:57:39 +03:00
xet7 bbc525ef27 Updated ChangeLog. 2026-07-10 22:57:39 +03:00
xet7 bfb3fd246b Self-contained release bundles: bundle Node.js + FerretDB + start-wekan.{sh,bat}
Each wekan-<version>-<arch>.zip is now fully offline: its bundle/ directory
contains the WeKan server, a Node.js binary for that platform, a FerretDB v1
(SQLite) binary, and a start-wekan.sh (start-wekan.bat on Windows) that by
default runs WeKan on the bundled Node against the bundled FerretDB SQLite,
storing data and attachments/avatars on the filesystem under WRITABLE_PATH
(like docs/Platforms/Propietary/Windows/Offline.md). Override with WEKAN_DB /
MONGO_URL to use an external database.

- build-amd64/arm64/mac copy the runner's own Node 24 (matching arch); the
  emulated ppc64le/s390x/riscv64 builds copy the target-arch Node they already
  download; win64 bundles node.exe. Each overwrites the base bundle's node.
- start-wekan.sh supersedes start-wekan-ferretdb.sh (removed).
- Docker and snap have their own Node + entrypoint/wekan-control, so they strip
  the redundant bundled node + launchers (keeping the ferretdb binary), saving
  ~80 MB per image/snap.

Thanks to xet7.
2026-07-10 22:57:39 +03:00
xet7 3a968052b9 Add snapcraft-core24.yaml: newest WeKan on base core24 for the Snap Stable channel
The main snapcraft.yaml uses base core26, which needs build-base devel + grade
devel until core26 is released, so it can only go to Snap Beta/Edge. This adds a
base core24 variant (a released base, grade stable) that builds the SAME newest
WeKan (Meteor 3.5, Node.js 24, FerretDB v1, MongoDB 7, Caddy 2), so the Stable
channel can be updated from the old 6.09 snap. Only base/build-base/grade differ
from snapcraft.yaml; migration wiring is added separately.

Thanks to xet7.
2026-07-10 22:57:39 +03:00
xet7 d424bd6386 Updated ChangeLog. 2026-07-10 22:57:39 +03:00
xet7 3824066f7f rebuild-all.yml: download prebuilt ferretdb.zip from wekan/FerretDB releases instead of building it, and stop attaching it to WeKan releases
FerretDB is now built and released separately in the wekan/FerretDB repo (its
build.sh cross-compiles every platform into ferretdb.zip and attaches it to a
release there). The WeKan release workflow no longer sets up Go or compiles
FerretDB: build-ferretdb just downloads the newest ferretdb.zip from
https://github.com/wekan/FerretDB/releases/latest and republishes it as a
workflow artifact, and every WeKan build embeds its per-arch binary from that.

ferretdb.zip is no longer attached to the WeKan releases, since it already lives
on the wekan/FerretDB releases.

Thanks to xet7.
2026-07-10 22:57:39 +03:00
xet7 774d752620 Updated ChangeLog. 2026-07-10 22:57:39 +03:00
xet7 dbca7cd72d Fix #6445: dynamic-import chunks 404 under a sub-path (build-chunks/build-chunks/)
Under a sub-path deployment (ROOT_URL like https://host/wekan, typically behind a
reverse proxy that strips the prefix), language selection and other lazy-loaded
features failed with:
  Error serving static file ENOENT ... /programs/server/build-chunks/build-chunks/<id>.js

rspack's client runtime builds each chunk URL as __webpack_public_path__ + chunkName,
and chunkName already includes the 'build-chunks/' prefix (u = e => 'build-chunks/'+e+...).
The default public path is '/', so at the site root chunks resolve correctly to
/build-chunks/<chunk>. But client/00-startup.js set the sub-path public path to
_rootPath + '/build-chunks/', so rspack appended a second 'build-chunks/', yielding
/wekan/build-chunks/build-chunks/<chunk> — which 404s. Set the public path to
_rootPath + '/' and let rspack add 'build-chunks/' itself.

Thanks to xet7.
2026-07-10 22:57:39 +03:00
xet7 8497e7c537 rebuild-all.yml: build standalone ferretdb.zip (all Go-cross-compilable arches) and source every WeKan build's FerretDB binary from it
Adds a build-ferretdb job that cross-compiles FerretDB v1 (wekan/FerretDB, pure-Go
SQLite backend, CGO off, no QEMU) for every platform Go + modernc.org/sqlite
support — not only the arches Node.js runs on — and packs them into ferretdb.zip:

    ferretdb/<arch>/ferretdb-<arch>        (Linux/macOS/BSD, executable)
    ferretdb/<arch>/ferretdb-<arch>.exe    (Windows only)
    ferretdb/README.md                     (links to https://github.com/wekan/FerretDB)

Targets that do not compile on a given platform are skipped, so the zip contains
exactly what builds. ferretdb.zip is attached to the GitHub Release, and every
WeKan build (amd64, arm64, ppc64le, s390x, riscv64, win64, mac-arm64; and via the
bundle the docker image and snap) now extracts its FerretDB binary from that same
ferretdb.zip, so there is one source of truth. Windows/macOS bundles now include
FerretDB too (previously stripped), tolerant of an arch that FerretDB can't build.

Thanks to xet7.
2026-07-10 22:57:39 +03:00
xet7 7f44459c9f Updated ChangeLog. 2026-07-10 22:57:39 +03:00
xet7 d5c69e0259 Admin Panel / Version: show database type, version, commit, storage engine and reactivity mode
getStatistics now reports, in Admin Panel / Version:
 - Database type: MongoDB or FerretDB (detected from buildInfo.ferretdb).
 - MongoDB-compatible version and the server git commit (buildInfo.gitVersion).
 - FerretDB version and commit, when the server is FerretDB.
 - Storage engine: WiredTiger for MongoDB, SQLite for FerretDB.
 - Reactivity mode currently in use: changeStreams / oplog / polling (from
   Meteor's oplog handle; FerretDB has no oplog so it shows polling).

Thanks to xet7.
2026-07-10 22:57:39 +03:00
xet7 598aa8dfa1 Snap: choose MongoDB or FerretDB v1 with 'snap set wekan database=ferretdb'; FerretDB default for new installs; disable mongosh telemetry
Adds a 'database' snap setting (mongodb|ferretdb). A new ferretdb service runs
FerretDB v1 (SQLite) on the same port MongoDB would use; only one database runs
at a time. The configure hook flips the two services when the setting changes,
mongodb-control disables itself when ferretdb is selected, and wekan-control
drops MONGO_OPLOG_URL for FerretDB (which has no replica-set oplog, so WeKan
uses polling) and waits on a plain ping instead of rs.status().

The FerretDB binary ships inside the WeKan bundle the wekan part already
downloads, so no extra build is needed. New installs default to FerretDB on all
platforms via the install hook (fresh installs only; upgrades keep MongoDB, and
a pre-existing MongoDB data dir is detected and kept). Switch with
'snap set wekan database=mongodb'.

mongosh collects anonymized usage analytics by default and the snap invokes it
several times; disable it (writable HOME + disableTelemetry) so nothing phones
home. mongod itself has no phone-home telemetry (Free Monitoring is opt-in).

Thanks to xet7.
2026-07-10 22:57:39 +03:00
xet7 0360ca1583 Fix rebuild-all.yml s390x build; add bundled FerretDB v1 for ppc64le, s390x, riscv64 and to the Docker image
The extra-arch bundle build ran node:24-slim under QEMU, but the official
node:24 image publishes no linux/s390x manifest (only amd64/arm64/ppc64le),
so the s390x leg failed with 'no matching manifest for linux/s390x'. Build
the emulated native-module rebuild on an ubuntu:26.04 base (which publishes
every arch) and install the Node.js binary from nodejs.org instead; riscv64
uses unofficial-builds.nodejs.org (nodejs.org ships no riscv64).

MongoDB Community only ships amd64/arm64 server binaries, so on ppc64le,
s390x and riscv64 WeKan now bundles FerretDB v1 (the wekan/FerretDB fork with
its embedded pure-Go SQLite backend, MongoDB wire protocol). The FerretDB
binary is cross-compiled once for all five arches (CGO off, static, no QEMU)
and embedded in every .zip next to main.js, so amd64/arm64 users can opt in
too via WEKAN_DB=ferretdb. The Docker image now covers all five arches and
auto-starts FerretDB on the MongoDB-less ones. FerretDB telemetry is disabled
and locked (--telemetry=disable, plus DO_NOT_TRACK). armv7l is still excluded:
no Node.js 24 build exists for it anywhere.

Thanks to xet7.
2026-07-10 22:57:39 +03:00
github-actions[bot] 9c51391a75 Bump versions for v9.83 2026-07-09 11:57:12 +00:00
Lauri Ojansivu 2ed13a1593 Updated ChangeLog. 2026-07-09 14:48:08 +03:00
Lauri Ojansivu ca50c9d1aa Updated ChangeLog. 2026-07-09 14:45:09 +03:00
Lauri Ojansivu 548d7b483e Updated ChangeLog. 2026-07-09 14:42:48 +03:00
Lauri Ojansivu 71bbc9f67e Updated ChangeLog. 2026-07-09 14:09:14 +03:00
Lauri Ojansivu 05fd6fd3a5 Fix #3624 swimlane REST regression: await the async board.swimlanes()
The swimlanes CRUD e2e test (23-rest-api-more.e2e.js:209) regressed on all
browsers. Root cause: on the server ReactiveCache.getSwimlanes is async, so
board.swimlanes() returns a Promise in the REST handler. The #3624 change read
board.swimlanes().map(s => s.sort); .map on a Promise throws, the insert never
ran, the error was swallowed by the handler's catch (returned as 200 with no
_id), and the test read .title off a null swimlane.

The earlier "move the require to a top-level import" commit was not the real
cause (the same module.exports import pattern works server-side, e.g.
ruleDeletePermission in rulesButton.js). The actual fix is to await
board.swimlanes() before mapping. This also means API-created swimlanes now get
a real max(existing sort)+1 sort — previously the un-awaited `.length` yielded
undefined, so they were stored with no sort at all, which is the #3624 symptom.

Verified: the swimlane test passed in every kept local run through
2026-07-09_02-38-07 and failed starting 09-52-25 (right after the #3624 change),
confirming the regression window; the tests/swimlaneSort.test.cjs unit test
still passes.
2026-07-09 14:09:14 +03:00
github-actions[bot] e8939bc1e6 Bump versions for v9.82 2026-07-09 08:13:59 +00:00
Lauri Ojansivu bc8d58011c Prepare v9.82 release 2026-07-09 11:08:40 +03:00
Lauri Ojansivu 0bf8cae81c Updated ChangeLog. 2026-07-09 10:43:25 +03:00
Lauri Ojansivu 984ec160da Fix Playwright CI failures from #3624 and #4236
Two e2e tests failed across Chromium/Firefox/WebKit after this release's changes:

- 23-rest-api-more.e2e.js:209 (swimlanes: create, get, edit, delete): the
  #3624 change referenced models/lib/swimlaneSort via a function-scoped
  require('/models/lib/swimlaneSort'); the new module was not reliably bundled/
  resolved that way, so POST /api/boards/:id/swimlanes threw, was caught, and
  returned an error object with no _id — the test then read title off a null
  swimlane. Import nextSwimlaneSort at the module top level, matching every
  other import in server/models/swimlanes.js, so it is statically bundled.

- 02-cards-open-view.e2e.js:93 (editing the card title does not break the card):
  #4236 intentionally made plain Enter insert a newline in the card title
  (consistent with the description), with Ctrl/Cmd+Enter saving. The CardPage
  page object still saved with plain Enter, so the title never persisted and the
  read timed out. Save with Control+Enter (sends ctrlKey on every platform,
  which the save handler accepts).

Server-side Mocha, import regression, and Node E2E jobs already passed; this
makes the Playwright jobs green too.
2026-07-09 10:26:03 +03:00
Lauri Ojansivu a2df80e64d Updated ChangeLog. 2026-07-09 10:09:58 +03:00
Lauri Ojansivu 3aaf8f9b61 Fix #6444: RTL — typing a card title no longer garbles other lists' minicard titles
In an RTL language (e.g. Arabic) the board root is dir="rtl". Both the minicard
title (a dir="auto" .viewer) and the add-card composer textarea are dir="auto"
but had no bidirectional isolation, so they shared the surrounding bidi context.
Typing a strong RTL character into one list's composer re-resolved that shared
context and visibly reflowed the displayed minicard titles of the other lists
(no underlying data change — it reverted on refresh).

Each minicard title and the composer textarea now use `unicode-bidi: isolate`,
making them self-contained bidirectional runs that cannot perturb one another.
The isolation is locked in (positive + negative) by tests/minicardBidiIsolation.test.cjs;
full browser RTL behavior is covered by tests/playwright/specs/18-rtl-layout.e2e.js.

Thanks to xet7.
2026-07-09 10:09:32 +03:00
Lauri Ojansivu 1dfc223ca0 Updated translations 2026-07-09 09:48:44 +03:00
Lauri Ojansivu 604cc455e0 Updated ChangeLog. 2026-07-09 09:45:53 +03:00
Lauri Ojansivu e85072a14a Updated ChangeLog. 2026-07-09 09:45:53 +03:00
Lauri Ojansivu 1621f3784a Fix #5439: list scrollbar is now always visible on desktop and mobile browsers
List bodies used overflow-y:auto, so on platforms/browsers with overlay
scrollbars (macOS, iOS, Android, Firefox) the scrollbar auto-hid when idle and
there was no persistent affordance that a list is scrollable.

The list body now shows a scrollbar across all engines: overflow-y:scroll to
always reserve and show the track, ::-webkit-scrollbar width + thumb/track for
Chrome/Safari/Edge and mobile WebKit/Blink, scrollbar-width + scrollbar-color
for Firefox/Gecko (desktop and Android), and scrollbar-gutter:stable so content
does not shift. The cross-browser rules come from a Meteor-free builder
models/lib/scrollbarCss.js and are applied in client/components/lists/list.css;
both the builder contract and the applied CSS are unit tested (positive +
negative, including that no hide values sneak back in) in
tests/scrollbarCss.test.cjs.

Thanks to xet7.
2026-07-09 09:45:53 +03:00
Lauri Ojansivu ba6ad20a30 Updated ChangeLog. 2026-07-09 09:45:53 +03:00
Lauri Ojansivu 3847157753 Fix #3185: copying a card (or template) now copies its subtasks' checklists
When a card was copied — including generating a card from a template — each
subtask was inserted as a bare card document. The parent card's checklists were
copied, but the subtasks' checklists (and their items) were never copied, so
the new card's subtasks came out empty.

Card.copy() now copies each subtask's checklists (via Checklist.copy, which also
copies the checklist items) onto the newly inserted subtask. The subtask copy
document is built by a Meteor-free helper models/lib/subtaskCopy.js
(buildCopiedSubtaskFields — re-homes the subtask under the new parent and onto
the destination board; subtaskCopyChildKinds declares 'checklists' must be
reproduced), unit tested (positive + negative) in tests/subtaskCopy.test.cjs.

Thanks to ramses345 and xet7.
2026-07-09 09:45:53 +03:00
Lauri Ojansivu 4e77133aca Updated ChangeLog. 2026-07-09 09:45:53 +03:00
Lauri Ojansivu 77c696e37b Updated ChangeLog. 2026-07-09 09:45:53 +03:00
Lauri Ojansivu e3f17be14d Fix #3624: new_swimlane REST API appends the swimlane last (and accepts a sort)
POST /api/boards/:boardId/swimlanes set the new swimlane's sort to
board.swimlanes().length (a count). When the existing swimlanes' sort values
were not a contiguous 0..n-1 run (after deletions/reordering, or swimlanes
created top-first with decreasing sorts), the count collided with or preceded
existing sorts and the new swimlane appeared FIRST instead of last.

The endpoint now computes the sort with nextSwimlaneSort(): max(existing sort)+1
for a reliable append (0 on an empty board), and honors an optional explicit
`sort` in the request body (the enhancement the reporter asked for). The pure
logic lives in models/lib/swimlaneSort.js, unit tested (positive + negative) in
tests/swimlaneSort.test.cjs.

Thanks to tamasberesoebb and xet7.
2026-07-09 09:45:53 +03:00
Lauri Ojansivu 5ca4ebe09a Updated ChangeLog. 2026-07-09 09:45:53 +03:00
Lauri Ojansivu 3117e419bb Fix #3606: activity feed no longer shows "edited/deleted comment undefined"
The activity feed rendered "edited comment undefined" / "deleted comment
undefined" for comment edits and deletions. The template passed the comment's
ID into the "%s" of activity-editComment / activity-deleteComment: on older
activities the id was absent (literally "undefined"), and a deleted comment's
CardComment document is already removed so it cannot be looked up live either.

The edit and delete activities now store the comment text (commentText), and a
new Activities.commentDisplayText() helper picks the stored text, else the live
comment text (edit case), else an empty string — so the feed never renders the
word "undefined". The template shows the (sanitized) comment text. The
text-selection logic is a Meteor-free helper models/lib/commentActivity.js,
unit tested (positive + negative) in tests/commentActivity.test.cjs.

Thanks to janchuelo and xet7.
2026-07-09 09:45:53 +03:00
Lauri Ojansivu 3eba4aa782 Updated ChangeLog. 2026-07-09 09:45:53 +03:00
Lauri Ojansivu 127f1fb04e Updated ChangeLog. 2026-07-09 09:45:53 +03:00
Lauri Ojansivu 14b4f5b5ed Fix #4249: filter by card title now works for renamed linked cards
Renaming a linked card (or linked-board card) wrote the new title only to the
linked target (via getRealId()/linkedId), leaving the linking card's OWN title
field stale. Filter-by-title queries each card document's own title field, so a
linked card silently dropped out of title filters after being renamed.

Card.setTitle() now also writes the linking card's own title (in addition to the
linked target), keeping it filterable while preserving the existing mirror
behavior. The set of documents to update is a Meteor-free helper
models/lib/linkedCardTitle.js (computeTitleUpdateTargets), unit tested
(positive + negative) in tests/linkedCardTitle.test.cjs.

Thanks to Ben0it-T and xet7.
2026-07-09 09:45:53 +03:00
Lauri Ojansivu e6a4abd394 Updated ChangeLog. 2026-07-09 09:45:53 +03:00
Lauri Ojansivu 25cdc4db0d Fix #4494: Creating a board from a template no longer breaks subtasks
Creating a board from a template copies the template board. The copy inherited
the template's subtasksDefaultBoardId / dateSettingsDefaultBoardId verbatim.
When those pointed at the template board itself, subtasks created on the NEW
board were dropped onto the TEMPLATE board, and the subtask card linked back
across boards to the parent.

Board.copy() now repoints any subtasks/date-settings default that referenced
the source board to the new copy, and clears the paired list id so it self-heals
to a list on the new board. Defaults that deliberately point at another (shared)
board are left untouched. The remap logic is a Meteor-free helper
models/lib/boardCopyDefaults.js, unit tested (positive + negative) in
tests/boardCopyDefaults.test.cjs.

Thanks to Xilef11 and xet7.
2026-07-09 09:45:53 +03:00
Lauri Ojansivu c062d93d57 Updated ChangeLog. 2026-07-09 09:45:53 +03:00
Lauri Ojansivu e014d5c816 Fix #4394: Register / Forgot Password links stay hidden after a failed login
Security: with "Self Registration" and "Forgot Password" disabled in the Admin
Panel, the Register (.at-signup-link) and Forgot Password (.at-pwd-link) links
were hidden only by a one-shot jQuery .hide() in userFormsLayout.onRendered.
When a login failed (notably the LDAP "User not Found" path), useraccounts
re-rendered the form and recreated those link nodes without the inline
display:none, so the links reappeared and exposed registration / password-reset
flows that were meant to be off.

The disable state is now also reflected as a class on the stable <body>
ancestor (registration-disabled / forgotpwd-disabled) with matching CSS in
userForm.css. Because the class sits on <body>, the rule re-hides every copy of
the links that useraccounts recreates after a failed login, instead of relying
on a single inline style that the re-render dropped.

Thanks to Alsterdetektive1 and xet7.
2026-07-09 09:45:53 +03:00
Lauri Ojansivu 84ab805ec1 Fix #4055: add ISO week-number regression test (already correct in current code)
#4055 reported the calendar/date-badge week number was one week too high
(Mon-Sat) and two too high (Sunday) for 2021-10-25..31 (ISO week 43). That was
the old moment-based calculation. The current native, DST-safe
dateUtils.getISOWeek() computes these correctly (verified across a DST timezone).
Adds tests/isoWeek.test.cjs pinning the exact reported dates so the off-by-one/
two cannot silently return.

Thanks to marcungeschikts and xet7.
2026-07-09 09:45:53 +03:00
Lauri Ojansivu a9a5ac7a07 Fix #4236: Enter adds a new line in the card title (consistent with description)
The card title textarea submitted on plain Enter (only Shift+Enter made a new
line), while the card description textarea and the shared inlinedForm insert a
new line on plain Enter and only save on Ctrl/Cmd+Enter. So Enter could not add
a new line in the title, an inconsistent experience.

The title keydown handler now uses a shared, Meteor-free rule isSubmitKey()
(models/lib/editorSubmitKey.js): submit ONLY on Enter together with Ctrl or Cmd;
plain Enter and Shift+Enter fall through to the textarea default (a new line).
This matches the description field exactly. Unit tested (positive + negative) in
tests/editorSubmitKey.test.cjs.

Thanks to listenerri and xet7.
2026-07-09 09:45:53 +03:00
Lauri Ojansivu 0119e62da5 Fix #4653: LDAP username with a hyphen no longer becomes a dot
With LDAP_UTF8_NAMES_SLUGIFY enabled, sync.js slugified the username with
limax(text, { separator: '.' }) to transliterate UTF-8 names. limax replaces
every run of non-alphanumeric characters — including hyphens — with the
separator, so an LDAP username like "p.parta-partb" was turned into
"p.parta.partb". The generated Wekan username no longer matched and the user
could not log in.

slug() now slugifies each hyphen-separated segment on its own and rejoins
them with '-', so hyphens (and existing dots) survive while UTF-8 characters
in each segment are still transliterated. The hyphen-preserving logic is a
Meteor/limax-free helper packages/wekan-ldap/server/usernameSlug.js
(slugifyPreservingHyphens, with the transliterate function injected), unit
tested (positive + negative) in tests/ldapUsernameSlug.test.cjs.

Thanks to RowhamD and xet7.
2026-07-09 09:45:53 +03:00
Lauri Ojansivu 284d4b25ea Updated ChangeLog. 2026-07-09 09:45:53 +03:00
Lauri Ojansivu 75df523ef0 Fix #4946: Calendar week numbers now respect the defined start day of week
In the board Calendar view the week-number column was numbered from Sunday
regardless of the user's "start day of week" setting: setting Monday moved
the grid (via firstDay) but the week numbers still referred to Sunday-start
weeks. FullCalendar's default weekNumberCalculation is locale-based, so it
ignored firstDay.

The calendar now passes weekNumberCalculation that computes the number with
weekNumberByFirstDay(date, firstDay) from the same firstDay used to lay out
the grid, so the number matches the displayed week. The Meteor-free week math
lives in models/lib/weekStart.js and is unit tested (positive + negative,
including a case where Monday-start and Sunday-start must differ) in
tests/weekStart.test.cjs.

Thanks to helioguardabaxo and xet7.
2026-07-09 09:45:53 +03:00
Lauri Ojansivu e5c844fca7 Fix #4881: Due this week / next week filter now respects the start day of week
The "Due this week" date filter selected the wrong week (it showed next
week's cards) and ignored the user's configured start day of week.

Root cause: relativeWeek() derived its window from startOf(now(), 'week'),
but the native dateUtils.startOf() has no 'week' case, so it returned the
date unchanged. The window therefore started at "today + startDayOfWeek"
(next week) instead of the beginning of the current week, and never took the
configured start weekday into account.

Fix:
- New Meteor-free helper models/lib/weekStart.js computes startOfWeek(),
  weekRange() and weekNumberByFirstDay() for an arbitrary start day of week
  (0=Sunday..6=Saturday, default Monday). Unit tested (positive + negative)
  in tests/weekStart.test.cjs, including a guard that "this week" must
  contain today.
- client/lib/filter.js relativeWeek() now uses weekRange(now(), weekStartDay,
  0|1) so "this week" and "next week" are the correct, non-overlapping
  Monday..Sunday (or configured) windows.
- The this/next-week buttons now toggle per week: clicking the active one
  clears it, clicking the other switches to it (the old code reset on either
  state, so you could not switch directly from this week to next week).

Thanks to mimZD and xet7.
2026-07-09 09:45:53 +03:00
Lauri Ojansivu 8a84707726 Fix #4978: Board background now updates when switching boards via favorites bar
Switching directly from one board to another using the favorites bar reused
the same boardBody template instance (currentBoard went A -> B, never null),
so boardBody.onRendered never fired again and the one-shot
Utils.setBackgroundImage() call never re-ran. The previous board's inline
background:url(...) on .board-wrapper stayed on screen. Switching via the
"all boards" list worked only because it destroys and re-creates boardBody.

Two-part fix:
- boardBody.onRendered now calls Utils.setBackgroundImage() inside a reactive
  this.autorun(), so it recomputes on every board switch (and background edit).
  It performs no DB writes, so there is no autorun write loop.
- setBackgroundImage() now clears any stale inline background when the new
  board has no image, instead of only ever setting one. The decision is a
  Meteor-free helper models/lib/boardBackground.js (computeBoardBackground),
  unit tested (positive + negative) in tests/boardBackground.test.cjs. Board
  color keeps being applied reactively via the .board-wrapper colorClass.

Thanks to dasarne and xet7.
2026-07-09 09:45:53 +03:00
Lauri Ojansivu 9f7eac158e Fix #5536: Automated rule can now move/link card to a different board
The rules move-card-to-top/bottom (on another board) and link-card-to-another-board
actions failed in two ways for boards the rule creator did not own:

- The action showed BLANK after creating the rule: the wizard inserted the
  trigger/action/rule with three optimistic client Collection.insert() calls
  that landed in minimongo limbo once the wizard subscription stopped (and the
  client allow/deny rules rejected them outright for non-owner members). These
  now create the rule through the server rules.createRule method, which keeps
  the action's own destination boardId.

- Execution crashed with a generic Internal Server Error: the destination
  swimlane fallback dereferenced ._id on a possibly-undefined swimlane titled
  exactly Default, which does not exist when the destination board's default
  swimlane was renamed, translated, or the board had no such swimlane.
  Resolution now uses the board's real default swimlane and a Meteor-free
  resolver (models/lib/ruleActionResolve.js) that returns empty string instead
  of throwing. The same guard is applied to the createCard and linkCard actions.
  Unit tested (positive + negative) in tests/ruleActionResolve.test.cjs.

Thanks to DarthKillian and xet7.
2026-07-09 09:45:53 +03:00
github-actions[bot] 9b729b502e Bump versions for v9.81 2026-07-09 00:17:50 +00:00
Lauri Ojansivu cef965f73f Updated ChangeLog. 2026-07-09 03:08:00 +03:00
Lauri Ojansivu 43dd98f8a1 Translate remaining English strings in fi.i18n.json to Finnish
Translate the strings that were still in English (mostly keys added this
release: the Rules Workflow trigger/action palette, the relative-date
unit selector, the custom color-wheel label, the Activities hide toggle
and the changed-description activity), using the terminology already used
in the existing Finnish translations.
2026-07-09 02:30:16 +03:00
Lauri Ojansivu 2cd772fcf5 Updated translations. 2026-07-09 02:25:49 +03:00
Lauri Ojansivu eaa1d823de Updated ChangeLog. 2026-07-09 02:19:52 +03:00
Lauri Ojansivu 1a41c72c21 Update CHANGELOG commit links to post-rebase hashes 2026-07-09 02:17:01 +03:00
Lauri Ojansivu 7943a17432 Updated ChangeLog. 2026-07-09 02:14:07 +03:00
Lauri Ojansivu d41e17d6a0 Fix #5351: auto-add users to organizations matching their email domain on sign-up.
The Organization setting "Automatically add users with the domain name"
(org.orgAutoAddUsersWithDomainName) was never read at sign-up, so a user whose
email domain matched an organization was never added to it.

Add a pure helper models/lib/orgAutoAddByDomain.js (orgsToAutoAddForEmail) that
returns the ids of orgs whose configured domain exactly matches an email domain
(case-insensitive, exact — no subdomain, empty domain matches nothing), and wire
it into Accounts.onCreateUser so every non-admin sign-up path (password, LDAP,
invitation, new OIDC user) gains the matching org memberships using the same
{ orgId, orgDisplayName } shape used elsewhere, without duplicating existing
memberships. Add tests/orgAutoAddByDomain.test.cjs.
2026-07-09 02:14:07 +03:00
Lauri Ojansivu 4ec2cbcd5a Updated ChangeLog. 2026-07-09 02:14:07 +03:00
Lauri Ojansivu 1ce2d8cc88 Fix #5369: Activities show/hide control is now a clear eye / eye-slash icon toggle.
Replace the counterintuitive unlabeled material toggle switch on the card
details Activities panel with an eye / eye-slash icon toggle: open eye means
activities are shown, crossed eye means they are hidden. Clicking flips the
state, the icon reflects the current visibility, and the tooltip states the
action (Show activities / Hide activities). The same eye pattern from the
login/register password-visibility toggle is reused for consistency.

For consistency the board sidebar Activities toggle (same showActivities
state) is switched from the check / empty-square icon to the same eye /
eye-slash icon toggle.
2026-07-09 02:14:07 +03:00
Lauri Ojansivu 8f76c7b2b0 Updated ChangeLog. 2026-07-09 02:14:07 +03:00
Lauri Ojansivu b07c4d0a7b Feature #5394: sort the Link-card popup Cards dropdown alphabetically by title.
The "Link to this card" popup Cards pull-down previously listed cards in
board sort order, making a card hard to find on boards with many cards.
Sort it alphabetically by title (case-insensitive, locale/numeric aware)
via a small pure helper sortCardsByTitle, with unit tests. Thanks to xet7.
2026-07-09 02:14:07 +03:00
Lauri Ojansivu 5b43b7159e Updated ChangeLog. 2026-07-09 02:14:07 +03:00
Lauri Ojansivu 7ce71dbb2e Feature #5396: edit Lists (title, color) via the REST API + api.py commands.
The REST endpoint PUT /api/boards/:boardId/lists/:listId already accepted
title, color, starred and wipLimit, but the color was stored unvalidated. It
now validates the color with normalizeListColor (a named palette color OR a
custom #rrggbb hex) and rejects an unknown color with a clear 400 instead of
silently storing None or hanging. The pure field/validation logic is extracted
to a Meteor-free helper models/lib/listApiUpdate.js so it is unit testable
without a running server (tests/listApiUpdate.test.cjs).

api.py gains two commands mirroring editcard/editcardcolor:
editlist BOARDID LISTID NEWLISTTITLE and
editlistcolor BOARDID LISTID COLOR, with usage lines in the help block.

Thanks to C0rn3j and xet7.
2026-07-09 02:14:07 +03:00
Lauri Ojansivu d615e599f4 Updated ChangeLog. 2026-07-09 02:14:07 +03:00
Lauri Ojansivu aad00cdba2 Fix #5442: outgoing webhooks now include the label name on add/remove label
Labels are embedded in the board document, not a separate collection, but the
Activities label() helper looked the label id up in the Cards collection and
always returned undefined. So the addedLabel/removedLabel webhook and
notification params never got a label value and the __label__ token in the
message text rendered as a bare, generic "label" with no name.

Resolve the label from the already-loaded board via getLabelById, and add a
pure labelDisplayName() helper (name -> color -> id fallback) so a nameless
label is shown by its color, matching the UI. Add a plain-Node unit test.
2026-07-09 02:14:07 +03:00
Lauri Ojansivu 07800da9af Updated ChangeLog. 2026-07-09 02:14:07 +03:00
Lauri Ojansivu da0d338e33 Fix #5482: adding/editing a card description fires the outgoing webhook
Card description changes did not create an activity, so no outgoing webhook
fired (unlike title/dueAt changes, whose Cards before.update hooks log an
activity). Log an a-changedDescription activity in the Cards before.update hook,
mirroring the title-change activity, so the existing Activities.after.insert
webhook hook fires. Fires on first-time set and later edits, not on no-op /
empty->empty saves. Pure descriptionChanged helper + tests, English i18n and
activity rendering.
2026-07-09 02:14:07 +03:00
Lauri Ojansivu c3c091635d Updated ChangeLog. 2026-07-09 02:14:07 +03:00
Lauri Ojansivu 8c499823cb Fix: the Rules Workflow view is now fully translatable via i18n.
The workflow trigger/action palette rendered hardcoded English labels
regardless of the UI language. Palette entries now carry an i18n labelKey
translated at render time via TAPi18n.__, reusing existing rule keys where
they fit and adding new r-w-* keys for workflow-only labels. Also routed
the slot clear tooltip through the existing r-remove key.
2026-07-09 02:14:07 +03:00
Lauri Ojansivu 1844425e8f Updated ChangeLog. 2026-07-09 02:14:07 +03:00
Lauri Ojansivu 68dd14140f Fix: deleting a board rule no longer fails with "Access denied [403]"
Deleting a rule ran three separate client-side Collection.remove() calls
(Rules + Triggers + Actions). Each is gated by a per-collection allow() rule
that resolves the board from that document own boardId via
Boards.findOneAsync(doc.boardId). When a trigger/action document has no
resolvable boardId (legacy rules created before boardId was denormalised, or
docs not published to the client), the board resolves to null and
allowIsBoardAdmin returns false, so Meteor rejects the mutation with 403
"Access denied" and the delete fails even for a legitimate board admin.

Route rule deletion through a new server Meteor method rules.deleteRule, which
authorizes ONCE (active board admin or site admin) and removes the rule, its
trigger and its action server-side (bypassing the brittle client allow/deny).
The permission decision is extracted into the Meteor-free helper
models/lib/ruleDeletePermission.js and covered by
tests/ruleDeletePermission.test.cjs. No permission is loosened: only board
admins and site admins may delete, matching the board-admin gate used to
create a rule.
2026-07-09 02:14:07 +03:00
Lauri Ojansivu 1ba32f5269 Updated ChangeLog. 2026-07-09 02:14:07 +03:00
Lauri Ojansivu 30f36a7f31 Feature #5514: custom color-wheel (RGB/hex) picker with automatic readable text contrast.
Add a native color wheel (<input type="color">) alongside the existing fixed
named-color swatches in the color pickers for card labels, swimlanes, lists and
cards, so any #rrggbb color can be chosen. The schema color fields accept a
custom hex in addition to the named palette (via a validation that allows the
named values or a ^#[0-9a-fA-F]{6}$ hex), and normalizeListColor now passes hex
through, so existing named-color data keeps working. When a stored value is a
hex, elements apply an inline background-color instead of the card-details- /
swimlane- / list-header- / minicard- CSS class.

A new pure, Meteor-free helper models/lib/contrastColor.js computes a readable
text color from sRGB relative luminance (white on dark, black on light),
maps the named palette to hex, and validates/normalizes hex; it is applied as
an inline text color wherever a chosen color is a background behind text (label
chips, swimlane/list headers, minicard, card details header). Covered by
tests/contrastColor.test.cjs (20 assertions).
2026-07-09 02:14:07 +03:00
Lauri Ojansivu 20b9c9ddd6 Updated ChangeLog. 2026-07-09 02:14:07 +03:00
Lauri Ojansivu 0e9aed5a4b Fix #5510: adding a board label via the REST API no longer errors/hangs
PUT /api/boards/:boardId/labels only wrote an HTTP response inside
`if (hasOwnProperty(req.body, "label"))` and read req.body.label.color/.name
unconditionally. Two consequences:

- A body without a `label` key fell through the `if` and NEVER sent a response,
  so the request hung until the client timed out (the reported "timeout").
- A body where `label` was a bare string (e.g. { "label": "labelName" }, the
  exact reported payload) produced name === undefined / color === undefined and
  pushed a schema-invalid label via Boards.direct, returning 200 for garbage.
- The catch returned { code: 200, data: error }, masking real failures as
  success (same anti-pattern already fixed for the board create/delete handlers).

The handler now returns a 404 for an unknown board, delegates input handling to
a new pure, Meteor-free helper models/lib/restLabel.js (buildBoardLabel), and
always sends a JSON response: 2xx for a well-formed create (documented contract
unchanged), 400 with a clear message for bad input, or the real error status in
the catch. buildBoardLabel accepts { label: { name, color } } (color defaulted
when absent, rejected when unknown) and, for convenience, a bare string taken as
the label name. Added tests/restLabel.test.cjs covering these cases.
2026-07-09 02:14:07 +03:00
Lauri Ojansivu 27d8468be0 Updated ChangeLog. 2026-07-09 02:14:07 +03:00
Lauri Ojansivu d01526bbff Fix #5604: CSV export no longer crashes on boards with dangling references.
Exporter.buildCsv resolved each card list/swimlane/owner/member/assignee/label/
customField by id and read a property directly on the result of Array.find(),
which is undefined when the referenced document was deleted. Large/old boards
often contain such dangling references, so the read threw "Cannot read property
title of undefined" and crashed the whole CSV export request. Extracted the
per-card row builder into a pure, null-safe helper models/lib/exporterCsvRow.js
(unit-testable without Meteor) that emits a blank cell for a missing reference
while keeping identical output for well-formed cards. Added
tests/exporterCsvRow.test.cjs.
2026-07-09 02:14:07 +03:00
Lauri Ojansivu ab3b48b334 Updated ChangeLog. 2026-07-09 02:14:07 +03:00
Lauri Ojansivu b0da9097c1 Fix #5656: Calendar view now honors the active board filters.
The Calendar view queried cards with only a board+date selector via
Board.cardsInInterval()/cardsDueInBetween() and ignored the active board
Filter (member / assignee / due-date / label / custom-field), so it showed
every card in the interval regardless of the sidebar filter, unlike the
Board / Lists / Swimlanes views.

Extract the calendar selector building into a pure, Meteor-free helper
(models/lib/calendarFilter.js) that ANDs the Filter selector into the
date-interval selector via combineWithFilter, so the Filter is always applied
and can never collide with the interval selectors top-level $or. The calendar
events() callback now passes Filter._getMongoSelector() when Filter.isActive(),
and the onRendered autorun reads Filter.isActive() so events are refetched when
the filter changes. Add tests/calendarFilter.test.cjs.

Thanks to kerier and xet7.
2026-07-09 02:14:07 +03:00
Lauri Ojansivu 158130cbfc Updated ChangeLog. 2026-07-09 02:14:07 +03:00
Lauri Ojansivu 53328f40c6 Add unit selector (minute/hour/day/week/month) to the Rules relative-date action (#5621) 2026-07-09 02:14:07 +03:00
Lauri Ojansivu e7eeaf0b10 Add 'Count amount of tests by category' menu option to rebuild-wekan scripts 2026-07-09 02:14:07 +03:00
Lauri Ojansivu 609b07a8db Add 'Count amount of tests by category' menu option to rebuild-wekan scripts 2026-07-09 00:02:17 +03:00
Lauri Ojansivu 7545bb5506 Add #6442 fix to Upcoming WeKan release CHANGELOG section 2026-07-08 23:58:21 +03:00
Lauri Ojansivu 457713968c Fix #6442: All Boards custom drag order — drop now persists the reorder
Follow-up to #6439, which restored the drag preview but left the drop a
no-op: dragging a board on the All Boards page in "Custom (drag order)"
mode showed the dashed-border preview, but releasing it snapped the board
back without reordering.

The drop handler built the current on-screen order from
`el.classList[0]` for each `.js-board`. But the board list item is
`li.js-board(class="{{_id}} …")`, and Jade emits the literal `js-board`
class FIRST, so classList[0] is the string "js-board" for every board —
never the board _id. The ordered ids were therefore
['js-board','js-board',…]; computeReorderedSortIndex could not find the
dragged/target ids in that array, returned null, and nothing was written
to profile.boardSortIndex. The preview still worked because it is driven
by the dragover CSS class, independent of the id.

Read each board's _id from its Blaze data context (the same source
dragstart already uses via `this._id`) instead of the literal class, so
the real display order reaches the (already correct, unit-tested) reorder
helper and the drop persists. Add a regression guard in
tests/boardSortReorder.test.cjs asserting the wrong-class extraction
("js-board" repeated) yields no mapping while real ids reorder.
2026-07-08 23:57:39 +03:00
Lauri Ojansivu 372a58c112 Updated ChangeLog. 2026-07-08 23:49:32 +03:00
Lauri Ojansivu 527962966b Add Upcoming WeKan release CHANGELOG section for #6443 fix
Link the fix commit under a new "Upcoming WeKan release" heading, in the
same style as previous release entries.
2026-07-08 23:44:10 +03:00
Lauri Ojansivu a37e7d1cc7 Fix #6443: cards on a deleted swimlane are invisible in swimlane view
On old boards a swimlane can be deleted while its cards keep the now
dangling swimlaneId (an "orphaned" card). Cards with no swimlane at all
(null / '' / missing) already surface in every swimlane, but an orphaned
card matched no existing swimlane and so appeared in NO swimlane in
swimlane view, while still showing in list view (which applies no
swimlane scope) — the reported "no swimlane" symptom where some boards
show no cards in swimlane mode but work in list mode.

Mirror the existing orphaned-LIST fallback (Swimlanes.orphanedSwimlaneLists,
which surfaces orphaned lists in the first swimlane) for cards: when a
list's cards are fetched for the board's FIRST swimlane, build the
swimlane-membership clause as a single { swimlaneId: { $nin:
<otherSwimlaneIds> } } (everything not owned by another existing
swimlane: own id, null/'', missing, or orphaned). This keeps it a single
field clause with no second $or, so the #6441 board-wide label filter
still holds. Orphaned cards therefore appear once, in the first swimlane,
without a database migration.

Threaded through the pure selector helpers (swimlaneMembershipSelector /
listCardsSelector / filteredListCardsSelector) and the in-memory sibling
filterCardsByListAndSwimlane, a new List.orphanedCardsSwimlaneIds helper,
and the cards()/cardsUnfiltered()/allCards() model methods plus the
listBody cardsWithLimit render helper. Covered by new cases in
tests/swimlaneFilter.test.cjs (18 assertions pass; #6441 guards intact).
2026-07-08 23:43:26 +03:00
Lauri Ojansivu 33ad40d012 Updated translations. 2026-07-08 23:12:53 +03:00
Lauri Ojansivu 44b5e12de9 Update README to reflect Meteor version change 2026-07-06 19:07:03 +03:00
github-actions[bot] 1207b573b5 Bump versions for v9.80 2026-07-06 15:40:14 +00:00
Lauri Ojansivu a26295a2fb Updated ChangeLog. 2026-07-06 18:35:50 +03:00
Lauri Ojansivu b2da9ac8d4 Admin Panel Domains table: server-side pagination, column sort and search (like Board Table view). Thanks to xet7. 2026-07-06 18:27:38 +03:00
Lauri Ojansivu 53dcf7379d Updated ChangeLog. 2026-07-06 18:13:31 +03:00
Lauri Ojansivu dfa6c78d4f Add regression test for board-invite email language. Refs #5664. 2026-07-06 16:02:56 +03:00
Lauri Ojansivu 795850ed05 Updated ChangeLog. 2026-07-06 15:25:54 +03:00
Lauri Ojansivu 9ef7f4a07a Thanks to 32Dexter and xet7 . Fixes #5666 2026-07-06 15:22:22 +03:00
Lauri Ojansivu cb2394a95d Updated ChangeLog. 2026-07-06 15:12:21 +03:00
Lauri Ojansivu ac368de06a Thanks to MarcusDger and xet7 . Fixes #5667 2026-07-06 15:12:21 +03:00
github-actions[bot] b26494766f Bump versions for v9.79 2026-07-06 11:46:51 +00:00
Lauri Ojansivu 68ab63c7fe Updated ChangeLog. 2026-07-06 14:43:27 +03:00
Lauri Ojansivu e3e71b254a Updated ChangeLog.
Link #6439/#6440/#6441 and the i18n test fix to their commits; wire the new unit tests into test:unit:node.

Thanks to jullbo and xet7.
2026-07-06 14:35:35 +03:00
Lauri Ojansivu fc4eadedc9 Fix flaky server-side Mocha i18n test (zh-CN "is not a spy")
The .loadLanguage suite intermittently reported "1 failing" (the failure bouncing between the zh-CN and fr cases). Two causes: stubbing the shared TAPi18n.i18n let state leak between tests, and asserting via sinon-chai routed the matcher through chai-as-promised so it could evaluate after afterEach's sinon.restore(). Give each test a fresh i18next instance via TAPi18n.init() (mirrors the reliable .setLanguage suite) and assert with synchronous sinon.assert.* instead of sinon-chai.

Thanks to xet7.
2026-07-06 14:35:34 +03:00
Lauri Ojansivu 9dca403782 Fix #6441: label filter now applies board-wide across all swimlanes
Thanks to jullbo and xet7.
2026-07-06 13:49:44 +03:00
Lauri Ojansivu dd90995db7 Fix #6440: '+' add-item button on minicard checklist now adds the item
Thanks to jullbo and xet7.
2026-07-06 13:49:44 +03:00
Lauri Ojansivu f8e31745d8 Fix #6439: Custom (drag order) sort on All Boards page now reorders via drag-and-drop
Thanks to jullbo and xet7.
2026-07-06 13:49:44 +03:00
github-actions[bot] 736d308860 Bump versions for v9.78 2026-07-06 09:03:57 +00:00
Lauri Ojansivu 9eca7a3941 Updated ChangeLog. 2026-07-06 11:54:17 +03:00
Lauri Ojansivu af436e16c4 Updated ChangeLog. 2026-07-06 11:52:49 +03:00
Lauri Ojansivu b1b414e850 - **Fix "Internal Server Error" when signing up despite the account being created**:
Registering a new account showed a red "Internal server error" on the sign-up form even
  though the account was created and could sign in — which typically happens when SMTP is not
  configured. Root cause: useraccounts' `ATCreateUserServer` creates the account and then
  calls `Accounts.sendVerificationEmail()` (because `sendVerificationEmail: true`); when SMTP
  is missing/misconfigured that send throws **after** the user row is inserted, and with no
  try/catch the exception leaves the createUser method as an opaque HTTP 500. The verification
  email is best-effort at sign-up, so `Accounts.sendVerificationEmail` is now wrapped to log
  and swallow a transport failure — registration completes and redirects to sign-in — while an
  "already verified" error is re-thrown so the resend-verification flow still reports it. This
  mirrors the [#5706](https://github.com/wekan/wekan/issues/5706) reset-password hardening.
  Covered by `tests/verificationEmail.test.cjs`.

Thanks to Firas-Git and xet7.

Fixes #5672
2026-07-06 11:50:28 +03:00
Lauri Ojansivu 57da3885a2 Updated ChangeLog. 2026-07-06 11:38:57 +03:00
Lauri Ojansivu cb9c897309 - **Fix can not add members to a Linked Card**:
A **linked card** (created by "Link card to this card") is only a placeholder on the board
  that links it — its members are stored on the **real card** it points at (`linkedId`), which
  lives on another board, and `Card.getMembers()` / `assignMember()` / `unassignMember()`
  already read and write that real card. But the member **picker** listed the members of the
  board you were *viewing* the linked card on, not the board the real card lives on. So on a
  board that links a card from another board, the picker offered the wrong set of members and
  toggling them did not behave as a consistent add/remove — "can not add members to the linked
  card". The picker now resolves a linked card to its real card's board and offers *that*
  board's active members (matching where the membership is actually stored), falling back to
  the current board for normal cards or when the real card isn't loaded yet. Extracted the
  target-card/target-board resolution into `models/lib/linkedCardMembers.js`, covered by
  `tests/linkedCardMembers.test.cjs`.

Thanks to ITT5 and xet7 !

Fixes #5676
2026-07-06 11:35:56 +03:00
Lauri Ojansivu 81f07baeb8 Updated ChangeLog. 2026-07-06 11:21:41 +03:00
Lauri Ojansivu 001c258f96 - **Fix can't search numbers in custom fields**:
Searching a board for the value of a **number** or **currency** custom field (e.g. a
  transaction number `2025001`, or a currency amount `123`) found nothing. Those field types
  store their value as a JS **Number** (the inputs save `parseInt(...)` / `Number(...)`), but
  `Board.searchCards()` only matched custom fields with `{ value: <regex> }` — and a MongoDB /
  Minimongo regex only matches **string** values, so it silently skipped every numeric custom
  field. The search now also adds an exact numeric-equality clause when the term is a plain
  number (a comma is accepted as a decimal separator, matching the currency input), so numeric
  custom fields match too; text/title/description matching is unchanged. Card search runs
  against Minimongo on the client, which — like MongoDB — cannot regex a numeric field, so
  equality is the correct cross-environment match. Covered by `tests/cardSearch.test.cjs`.

Thanks to MarcusDger and xet7.

Fixes #5680
2026-07-06 11:19:15 +03:00
Lauri Ojansivu 9d77b9d7b7 Updated ChangeLog. 2026-07-06 10:57:03 +03:00
Lauri Ojansivu 2242da4176 - **Fix "Removed nonexistent document" crash during notification_cleanup**:
The scheduled notification-tray cleanup logged `Exception in removed observeChanges
  callback: Error: Removed nonexistent document …`. The crash itself came from the old
  `cottz:publish-relations` package (since replaced by `reywood:publish-composite`), but the
  cleanup that provoked it still fired one **un-awaited** `removeNotification()` per expired
  notification — a separate `Users.update` `$pull` each time — so a user with K stale
  notifications produced K writes to the Users collection, and every publication that
  republishes user documents re-ran its observers K times in quick bursts (the churn that
  surfaced the removed-document error), while any rejected write went unhandled. The cleanup
  now scans only users that have notifications and prunes each user's stale notifications in a
  single awaited `$pull … $in`. It also removes an activity's notifications only when *every*
  entry for that activity is read and past its removal age (so a freshly re-created unread
  notification sharing an activity id is not dropped), and guards missing/invalid `read`
  timestamps. Covered by `tests/notificationCleanup.test.cjs`.

Thanks to xet7.

Fixes #5685
2026-07-06 10:55:29 +03:00
Lauri Ojansivu 0a3a28ef29 Updated ChangeLog. 2026-07-06 10:46:27 +03:00
Lauri Ojansivu dcf5aa65b0 - **Fix impossible to select another board in rules**:
In the IFTTT-Rules "Move card to the board" and "Link card to the board" actions, the
  board dropdown was empty for some users — the current board included — while colleagues
  in the same company could pick boards normally. Root cause: the dropdown filtered the
  (already access-scoped) client cache with `'members.userId': me`, i.e. it only kept boards
  where the user has a *direct* member entry. A user who reaches a board through an
  Organization, Team or email-domain share — but is not listed individually in
  `board.members` — matched nothing, so the whole selector came up empty. The dropdown now
  filters by the same visibility rule as `Boards.userBoards()` (public OR active member OR
  active org OR active team OR active domain), so org/team/domain-shared boards appear too,
  while archived boards, template containers, the user's templates board and internal helper
  boards stay excluded.

Thanks to Augustin356 and xet7 !

Fixes #5698
2026-07-06 10:43:26 +03:00
Lauri Ojansivu dd3be179ca Updated ChangeLog. 2026-07-06 10:33:15 +03:00
Lauri Ojansivu bc1f149ea3 - **Fix board disappeared after adding another user**:
A board admin adding another user could make the whole board silently vanish from a
  user's board list, with no archive and "nothing out of order" in the logs. Root cause:
  the `setBoardTeams` server method (used by the board Teams/Members management popups)
  blindly overwrote the board's entire `members` array with a snapshot sent by the client.
  When that client's board document was stale — e.g. a member had just been added via
  `inviteUserToBoard` on the server and the change had not yet propagated to the client —
  the overwrite dropped members, and in the worst case the board's own admin, so the board
  no longer matched the board-list publication (which requires an active membership) and
  disappeared. Because a wholesale `$set: { members }` never passes through
  `foreachRemovedMember()`, no `removeBoardMember` activity was logged and no
  card/watcher/star cleanup ran, which is why the logs looked normal. `setBoardTeams` now
  reconciles against the authoritative server-side members instead of trusting the client
  snapshot: it never drops an active admin, keeps every existing member the client still
  lists, adds the members the client introduces, and only removes non-admin members the
  client explicitly omitted (an intentional team-leave) — logging and cleaning up each such
  removal so it is auditable rather than silent.

Thanks to DVNBLMHC and xet7 !

Fixes #5730
2026-07-06 10:33:15 +03:00
github-actions[bot] 0dd11ea573 Bump versions for v9.77 2026-07-06 00:01:08 +00:00
Lauri Ojansivu 5feb83d919 Updated ChangeLog. 2026-07-06 02:51:25 +03:00
Lauri Ojansivu 8980668686 Updated ChangeLog. 2026-07-06 02:47:52 +03:00
Lauri Ojansivu 0d4e48ddd6 Retry snapcraft install in the release-all.yml snap job
The Snap Store intermittently rejects `sudo snap install snapcraft --classic`
with "error: cannot install snapcraft: too many requests" (a 429-style rate
limit) that instantly failed the whole snap job before any build ran. Retry up
to 5 times with 30s backoff so one transient store throttle no longer fails the
release, matching the remote-build retry already in the same job.
2026-07-06 02:47:32 +03:00
Lauri Ojansivu a01b175895 Updated ChangeLog. 2026-07-06 02:37:29 +03:00
Lauri Ojansivu 83f63c9efa Updated Code of Conduct.
Thanks to xet7 !
2026-07-06 02:37:28 +03:00
Lauri Ojansivu 3b031bd901 Updated Code of Conduct.
Thanks to xet7 !
2026-07-06 02:37:28 +03:00
github-actions[bot] e2a7e300c9 Bump versions for v9.76 2026-07-05 23:07:35 +00:00
Lauri Ojansivu 844f59e12e Updated ChangeLog. 2026-07-06 01:57:54 +03:00
Lauri Ojansivu 1a3d7b5da4 Updated translations. 2026-07-06 01:57:00 +03:00
Lauri Ojansivu 3d2bdf4f22 Updated ChangeLog. 2026-07-06 01:50:59 +03:00
Lauri Ojansivu b9fe1f1639 Updated ChangeLog. 2026-07-06 01:35:30 +03:00
Lauri Ojansivu a39a7b90b1 Updated ChangeLog.
Repoint the #6427 upcoming entry to its on-main commit (the old link was
malformed and pointed at an orphaned pre-rebase commit).
2026-07-06 01:28:24 +03:00
Lauri Ojansivu 5d1c979e3b Updated ChangeLog.
Link the #5808 and board-not-found-flicker upcoming entries to their commits.
2026-07-06 01:26:43 +03:00
Lauri Ojansivu d00dc6056b Fix the "Board not found" flicker (stale-while-revalidate for the client board cache)
The client board cache (imports/lib/dataCache.js) re-fetches its value inside a
reactive computation. When the board doc is briefly absent from minimongo (a
subscription stops and restarts, momentarily removing the doc), the empty value
was surfaced immediately, flashing the "Board not found" shell — and on WebKit
throwing a Blaze "Can't select in removed DomRange" error tearing down the card
view. It self-recovers when the doc is re-delivered, so it presents as a flicker,
reliably hit only on Firefox/WebKit timing (which is why it surfaced as
browser-specific Playwright failures in 14-voting-watchers and 24-feature-issues).

Fixed with an opt-in stale-while-revalidate mode on DataCache, enabled only for
getBoard: a transient miss over an already-cached board keeps the last value and
re-checks after a short delay, surfacing an empty result only if the board is
still gone then (a genuine deletion / access loss). First-ever loads and caches
that did not opt in are unchanged. Core decision extracted to the pure
shouldDeferCacheMiss helper with unit tests.

Also hardens the related Playwright specs: a retry in CardPage.openActionsMenu, a
longer visibility budget for the WebKit slow card-render in spec 16, and removes a
reload race in the move-list-right spec (moveListBy fires two un-awaited
updateListSort calls, so an immediate reload read a half-applied order).
2026-07-06 01:26:05 +03:00
Lauri Ojansivu 878a24f586 Fix #5808: linking a card to another linked card made both cards inaccessible
The "Link to this card" target picker only excluded template cards, so an
existing linked card (or a card that links back to the current board) could be
chosen as a link target. That builds a chain of linkedId pointers, but the card
helpers (getTitle/getBoardTitle/getRealId) resolve linkedId only one hop, so
such a card renders as an empty/broken pointer and becomes inaccessible (the
reported freeze). As the reporter suggested, prevent the configuration: only a
real card — not a linked card/linked board, not one of the linking board's own
cards, and not a card that links back to one of them — may be a link target.
Enforced in the picker query and re-checked at creation time via the pure
isLinkableCardTarget guard, mirroring the #3328 parent/subtask cycle guard.
2026-07-06 01:25:39 +03:00
Lauri Ojansivu 6d08181edd Updated ChangeLog. 2026-07-05 23:24:30 +03:00
Lauri Ojansivu d5596f05b7 - **Fix DEFAULT_AUTHENTICATION_METHOD env var ignored, and Admin Panel Layout save hanging.
Two related problems with the default login authentication method.
  - **Env var ignored:** the stored setting was only ever seeded as `password` and
    `DEFAULT_AUTHENTICATION_METHOD` was never applied, so operators setting it (e.g. Kubernetes/Helm
    `DEFAULT_AUTHENTICATION_METHOD: ldap`) saw no effect. Startup now applies the env var
    authoritatively: it seeds the value on a fresh install and, on existing installs, keeps the
    stored `defaultAuthenticationMethod` in sync with the env var on every boot (the operator's env
    is the source of truth), so the method can be configured entirely by env without the Admin Panel.
    The value is normalized (trimmed + lower-cased), so `DEFAULT_AUTHENTICATION_METHOD=LDAP` works.
  - **Layout save hanging / not persisting:** the authentication-method `<select>` is populated by an
    async `Meteor.call`, so clicking **Admin Panel > Layout > Save** before it loaded sent an empty
    value for the **required** `defaultAuthenticationMethod` field, which silently failed validation —
    the save looked stuck and nothing changed. The save now falls back to the currently stored method
    when the select is empty, so a real value is never overwritten by `''`.
  Both paths share one pure helper (`resolveDefaultAuthenticationMethod`) that never resolves to an
  empty string.

Thanks to joe-speedboat and xet7 !

Fixes #5879
2026-07-05 23:22:16 +03:00
Lauri Ojansivu 22b280a18e Updated ChangeLog. 2026-07-05 23:13:36 +03:00
Lauri Ojansivu 2e7c4ede2a - **[Reduce card flicker on drag by only writing changed fields on a card move](https://github.com/wekan/wekan/issues/6430)** (#6430):
`Card.move()` wrote `boardId`/`swimlaneId`/`listId` into the update unconditionally, even for a
  same-board drag to another list (the reported case). Keeping `boardId` in the `$set` on every drag
  re-ran the `boardId`-gated `Cards.after.update` hook that re-syncs the card's checklists and
  checklist items via `multi` updates, ran the cross-board consistency guard and the
  `denyCrossBoardMove` deny-rule DB lookup, and invalidated more reactive dependents than
  necessary — server work and reactivity churn that contributed to a ~1s card flicker on large
  boards. `Card.move()` now writes **only the fields that actually change** (via the pure
  `computeCardMoveModifier` helper) and skips the write entirely when a card is dropped back in the
  same place, so a same-board move no longer touches boardId or the cross-board hooks. The
  `moveCard`/`moveCardBoard` activity generators already re-check `doc.X !== oldX`, so trimming the
  modifier does not drop any activity. Note: this reduces the drag-time work behind the flicker; the
  residual reactive re-render cost on very large boards is a separate performance topic.

Thanks to mimZD and xet7 !

Fixes #6430
2026-07-05 23:12:16 +03:00
Lauri Ojansivu ed77abd90d Updated ChangeLog. 2026-07-05 22:56:01 +03:00
Lauri Ojansivu 45fb547947 - **Fix thousands of unsolicited empty "Default" swimlanes created on some boards**:
`Board.getDefaultSwimline()`/`getDefaultSwimlineAsync()` self-heal a missing default swimlane by
  reading the board's swimlanes and inserting one if none exist. That check-then-insert is a race:
  concurrent or repeated server calls for a swimlane-less board each saw zero swimlanes and each
  inserted a new one, so some boards accumulated 30 000+ empty "Default" swimlanes and became
  unloadable (the `key 'default (en)' returned an object instead of string` log is a harmless i18n
  side effect — the title correctly falls back to the string `Default`). Follow-up to the
  client-side [#6382](https://github.com/wekan/wekan/issues/6382) fix, which only stopped the
  browser from auto-creating them. Fixed by making the server self-heal **idempotent**: the default
  swimlane is now upserted with a deterministic `_id` (`<boardId>-default`), so the `_id` unique
  index guarantees at most one default swimlane per board no matter how many times, or how
  concurrently, the getters run. `archived`/`type` are set explicitly in the `$setOnInsert` because
  their schema autoValue/defaultValue only fire on insert, not upsert. Note: this prevents new
  duplicates; boards that already accumulated thousands still need a one-off cleanup.

Thanks to brlin-tw and xet7 !

Fixes #6429
2026-07-05 22:54:13 +03:00
Lauri Ojansivu 477ad737d3 Updated ChangeLog. 2026-07-05 22:30:37 +03:00
Lauri Ojansivu a2802a850b - **Release workflow: publish the Helm chart only after the Docker image is pushed**:
In `.github/workflows/release-all.yml` the `charts` job now depends on the `docker` job
  (`needs: docker`) instead of running in parallel right after `bump`. GitHub Actions runs a job
  only when all of its `needs` jobs succeed, so the wekan/charts Helm chart is published only after
  the multi-arch image is live on Docker Hub / Quay.io / GHCR (and is skipped if `docker` fails).
  This prevents ArtifactHub from scanning a freshly published chart whose image tag does not exist
  yet and emailing the maintainer about the missing Docker image.

Thanks to xet7 !
2026-07-05 22:29:23 +03:00
Lauri Ojansivu 5cbe27be7e Updated ChangeLog. 2026-07-05 22:23:36 +03:00
Lauri Ojansivu 8b21158736 - **Fix [#6427](https://github.com/wekan/wekan/issues/6427): notification emails linked to
`/b/undefined/board/<cardId>` instead of the real board.** On the server
  `ReactiveCache.getBoard()` is async and returns a Promise, but `Cards.board()` did not await it,
  so the synchronous `Card.originRelativeUrl()`/`absoluteUrl()` interpolated a Promise —
  `board._id` and `board.slug` were `undefined`, producing `/b/undefined/board/<cardId>` in
  card activity notification emails (the client UI was unaffected because `this.board()` is
  synchronous there). Fixed by making `Card.originRelativeUrl(board)`/`absoluteUrl(board)` accept an
  already-resolved board and fall back to `this.boardId` (always available synchronously) when the
  board is a Promise, and by passing the awaited board from `server/models/activities.js` so the
  correct board id and slug are used.

Thanks to titver968 and xet7 !

Fixes #6427
2026-07-05 22:23:36 +03:00
github-actions[bot] 651c6f8fb6 Bump versions for v9.75 2026-07-05 19:05:05 +00:00
Lauri Ojansivu 5b67312f0f Updated ChangeLog. 2026-07-05 21:55:15 +03:00
Lauri Ojansivu 1a222c4477 - **[ScannerBleed](https://github.com/wekan/wekan/security/advisories/GHSA-x3xm-pxrv-jg7p)
— shell injection (RCE) via a malicious upload filename in the external antivirus scanner command path**
  ([GHSA-x3xm-pxrv-jg7p](https://github.com/wekan/wekan/security/advisories/GHSA-x3xm-pxrv-jg7p),
  CWE-78 OS Command Injection). Same RCE class as
  [AvatarBleed](https://wekan.fi/hall-of-fame/avatarbleed/) (CVE-2026-52891, GHSA-35j7-h385-2q9g)
  and its follow-up regression (CVE-2026-53447 / GHSA-qfqv-42qw-vvwh area), but in a code path that
  was **never** covered by those fixes.
  In `models/fileValidation.js`, when an admin has configured an external scanner (antivirus)
  command line with a `{file}` placeholder, the uploaded file path was interpolated into the command
  and run through `asyncExec` (`promisify(exec)`), which spawns `/bin/sh -c` and interprets **all**
  shell metacharacters:
  ```js
  await asyncExec(externalCommandLine.replace("{file}", '"' + fileObj.path + '"'));
  ```
  Wrapping the path in double quotes is not a shell boundary — inside double quotes the shell still
  expands `$(...)`, backticks and `\`, so a filename such as `` a`id`.png `` or `$(touch /tmp/pwn).png`
  escaped the argument and executed as the Wekan server process. Any **authenticated** user who can
  upload an attachment could trigger it, on servers that have an external scanner configured. Unlike
  the sibling MIME-detection path (`detectMimeFromFile`, which already uses `execFile` with no shell)
  and unlike the AvatarBleed fix (which strips non-alphanumeric characters from the filename), this
  scanner path had **zero** sanitization.
  - **Fixed** by POSIX single-quote-escaping the interpolated file path via a new `shellQuote()`
    helper (wrap in single quotes, escape embedded `'` as `'\''`). Inside single quotes the shell
    interprets no metacharacters, so a malicious filename can no longer break out of the argument or
    inject commands, while the admin's arbitrary command line and the exact on-disk path are both
    preserved. CVSS:3.1 9.9 Critical (AV:N/AC:L/PR:L/UI:N/S:C/C:H/I:H/A:H).
  - Affected Wekan v9.06 and earlier through the current release; fixed at the upcoming WeKan release.
    Reported by **DavidCarliez**.

Thanks to DavidCarliez and xet7 !
2026-07-05 21:55:15 +03:00
github-actions[bot] ca9bcfa4ee Bump versions for v9.74 2026-07-05 15:08:00 +00:00
Lauri Ojansivu 4da5b4eb96 Updated ChangeLog. 2026-07-05 17:55:45 +03:00
Lauri Ojansivu 8c4044ce6c Updated ChangeLog. 2026-07-05 17:53:28 +03:00
Lauri Ojansivu b46d9588c7 Fix translations at Login and Register pages.
Thanks to xet7 !
2026-07-05 17:52:05 +03:00
Lauri Ojansivu 96773e7b1d Updated ChangeLog. 2026-07-05 16:51:28 +03:00
Lauri OjansivuandClaude Opus 4.8 5a80f4f6ce Updated ChangeLog.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-05 16:49:23 +03:00
Lauri OjansivuandClaude Opus 4.8 b9f9390d04 Server-side Mocha suite: fixed a startup crash and the 44 latent failures it had been hiding
- imports/i18n/i18n.test.js crashed the whole run at load: chai 6.x plugins (sinon-chai,
  chai-as-promised) are ESM-only, so use(require('sinon-chai')) handed chai.use() a module
  namespace instead of the plugin function ("fn is not a function"). Now imports the default
  export.
- That unmasked a second load crash - PositionHistory.helpers is not a function: the
  meteor test entry (server/lib/tests/index.js) never ran the .helpers / .attachSchema shim
  that server/main.js bootstraps, so the first model to call Collection.helpers({...}) threw.
  The shim is now imported first in the test entry.
- With the suite finally running, 44 server tests failed because meteor test only loads what
  the specs import (not the app's /server/imports). The specs now import the files that
  register the methods / globals under test (cards.vote / cards.pokerVote, api.attachment.*,
  cloneBoard, getBackgroundImageURL, applyListWidth, updateListSort, moveChecklist,
  userPositionHistory.*, archiveBoard, sendSMTPTestEmail, and the Attachments global). Also
  fixed genuine test bugs: the cards.vote / cards.pokerVote specs were written synchronously
  against async methods; the header-login trust specs restored env vars with
  process.env.X = undefined (which stores the string "undefined" and shadowed the trusted-IP
  allowlist, making every trusted source read as untrusted); the DnsBleed decimal-loopback
  matcher assumed the integer host survived URL normalisation; and the dependencies-OpenAPI
  spec could not locate its source file from the built bundle. The two cards.archive /
  cards.move specs tested Meteor methods that do not exist (archive / move are Minimongo
  document helpers secured by Cards.allow / Cards.deny, already covered by the cards security
  tests) and were removed. Server-side Mocha is now 409 passing, 0 failing.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-05 16:48:58 +03:00
Lauri OjansivuandClaude Opus 4.8 f5a4ece294 Playwright E2E: fixed three cross-process-contention flakes in the parallel run
The Chromium / Firefox / WebKit browser jobs run as separate processes against ONE
shared server + DB, so specs that used fixed identifiers or global cleanups raced
each other:

- 26-shared-templates.e2e.js seeded a fixed email domain (usera@acme-e2e.invalid) in
  all three browsers, hitting E11000 duplicate key on the unique emails.address index.
  Now uses a unique-per-run token for the org / team / domain and template titles.
- 38-impersonation.e2e.js cleaned up with a global
  deleteMany({ reason: 'clickedImpersonate' }) that deleted another browser's in-flight
  audit record mid-poll. Scoped the cleanup to the test's own adminId.
- 32-org-team-feature-toggles.e2e.js exercises setAllOrgsFeature / setAllTeamsFeature,
  which do a global updateMany({}) across every org / team, so two browsers clobbered
  each other's rows. These browser-agnostic server-method tests now run in a single
  project (Chromium); Firefox / WebKit skip them.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-05 16:48:50 +03:00
Lauri Ojansivu c1ddf989a2 Updated ChangeLog. 2026-07-05 14:52:10 +03:00
Lauri Ojansivu c48ecb1d88 Fix tests.
Thanks to xet7 !
2026-07-05 14:50:59 +03:00
Lauri Ojansivu c664fe863c Updated translations. 2026-07-05 14:11:44 +03:00
Lauri Ojansivu 38f571b388 Updated ChangeLog. 2026-07-05 14:10:42 +03:00
Lauri Ojansivu 1e7de6d776 Card Settings popup options combined to same lines, and added more options.
Thanks to xet7 !
2026-07-05 14:09:38 +03:00
Lauri Ojansivu 6d47dc3f4a Updated translations. 2026-07-05 13:30:49 +03:00
Lauri Ojansivu 4756ca4226 Updated ChangeLog. 2026-07-05 13:27:46 +03:00
Lauri Ojansivu bb440b0d7b Board Settings / Card Settings / Checklist item count (0/0) on minicard. Default: Off.
Thanks to carl-unique and xet7 !

Fixes #6431
2026-07-05 13:25:00 +03:00
Lauri Ojansivu 89cfe1529f Updated ChangeLog. 2026-07-05 12:50:30 +03:00
Lauri Ojansivu 236fdf9338 Each run all tests now has logs at ../log/YYYY-MM-DD_HH-MM-SS/
Thanks to xet7 !
2026-07-05 12:48:21 +03:00
Lauri Ojansivu 5c36b2292b Updated ChangeLog. 2026-07-05 12:29:14 +03:00
Lauri Ojansivu 4eebdb4278 Fix tests.
Thanks to xet7 !
2026-07-05 12:21:47 +03:00
Lauri Ojansivu 4533268418 Update vscode sandbox.
Thanks to xet7 !
2026-07-05 12:12:24 +03:00
Lauri Ojansivu c997c12f88 Updated tests 2026-07-05 11:52:12 +03:00
Lauri Ojansivu 36efd9c988 Fix parallel tests.
Thanks to xet7 !
2026-07-05 11:30:26 +03:00
Lauri Ojansivu 267bfc7229 Script to be executeable 2026-07-05 11:03:13 +03:00
Lauri Ojansivu 405a7b72e9 Updated ChangeLog. 2026-07-05 11:02:01 +03:00
Lauri Ojansivu 7d416cc7cc Run all tests at parallel or sequential.
Thanks to xet7 !
2026-07-05 11:00:43 +03:00
Lauri Ojansivu 7929ab27cb Updated ChangeLog. 2026-07-05 10:21:20 +03:00
Lauri Ojansivu 7bbd1a3fad Fix ExcelBleed.
Thanks to sec-reex and xet7 !
2026-07-05 10:20:08 +03:00
Lauri Ojansivu 0f9bd4f9f9 Reverted JQuery 4.0.0 that did not work back to JQuery 3.7.1.
Thanks to xet7 !
2026-07-05 10:02:37 +03:00
Lauri Ojansivu a7ce6690a5 Merge pull request #6415 from wekan/dependabot/npm_and_yarn/babel/runtime-8.0.0
build(deps): bump @babel/runtime from 7.29.7 to 8.0.0
2026-07-05 09:56:51 +03:00
dependabot[bot] 82bd4ff39d build(deps): bump @babel/runtime from 7.29.7 to 8.0.0
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.29.7 to 8.0.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v8.0.0/packages/babel-runtime)

---
updated-dependencies:
- dependency-name: "@babel/runtime"
  dependency-version: 8.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-05 06:55:17 +00:00
Lauri Ojansivu 721c61bef5 Merge pull request #6417 from wekan/dependabot/npm_and_yarn/jquery-4.0.0
Bump jquery from 3.7.1 to 4.0.0
2026-07-05 09:54:49 +03:00
Lauri Ojansivu 7a25546da7 Merge pull request #6435 from wekan/dependabot/npm_and_yarn/i18next-26.3.4
build(deps): bump i18next from 25.10.10 to 26.3.4
2026-07-05 09:53:13 +03:00
Lauri Ojansivu 2c1d3a3922 Merge pull request #6414 from wekan/dependabot/npm_and_yarn/tweedegolf/sab-adapter-amazon-s3-3.0.4
Bump @tweedegolf/sab-adapter-amazon-s3 from 1.0.20 to 3.0.4
2026-07-05 09:52:52 +03:00
Lauri Ojansivu b4d6cc741c Merge pull request #6438 from wekan/dependabot/npm_and_yarn/azure/storage-blob-12.33.0
build(deps): bump @azure/storage-blob from 12.32.0 to 12.33.0
2026-07-05 09:49:31 +03:00
Lauri Ojansivu 5311f80711 Merge pull request #6436 from wekan/dependabot/npm_and_yarn/tests/playwright/playwright/test-1.61.1
build(deps-dev): bump @playwright/test from 1.61.0 to 1.61.1 in /tests/playwright
2026-07-05 09:48:19 +03:00
Lauri Ojansivu abed969a96 Merge pull request #6437 from wekan/dependabot/npm_and_yarn/tests/playwright/mongodb-7.4.0
build(deps): bump mongodb from 7.3.0 to 7.4.0 in /tests/playwright
2026-07-05 09:47:58 +03:00
Lauri Ojansivu 36e3cf30d3 Merge pull request #6428 from wekan/dependabot/github_actions/actions/cache-6
build(deps): bump actions/cache from 5 to 6
2026-07-05 09:47:10 +03:00
Lauri Ojansivu eaadbc6dd1 Merge pull request #6434 from wekan/dependabot/github_actions/docker/build-push-action-7.3.0
build(deps): bump docker/build-push-action from 7.2.0 to 7.3.0
2026-07-05 09:46:41 +03:00
Lauri Ojansivu 0aacc989b7 Merge pull request #6433 from wekan/dependabot/github_actions/docker/metadata-action-6.2.0
build(deps): bump docker/metadata-action from 6.1.0 to 6.2.0
2026-07-05 09:46:32 +03:00
Lauri Ojansivu 77adfb28c9 Merge pull request #6432 from wekan/dependabot/github_actions/docker/login-action-4.4.0
build(deps): bump docker/login-action from 4.2.0 to 4.4.0
2026-07-05 09:46:23 +03:00
Lauri Ojansivu a9d8261d80 Updated ChangeLog. 2026-07-05 09:38:48 +03:00
Lauri Ojansivu df3f519e99 Update to Meteor 3.5.
Thanks to Meteor developers !
2026-07-05 09:36:34 +03:00
Lauri Ojansivu d68364befe Updated translations. 2026-07-05 09:35:02 +03:00
Lauri Ojansivu 6094979d4e Updated ChangeLog. 2026-07-05 09:33:14 +03:00
Lauri Ojansivu ef845fe4a0 Fix DnsBleed.
Thanks to 4n207 and xet7 !
2026-07-05 09:30:12 +03:00
dependabot[bot] ce8fc8e392 build(deps): bump @azure/storage-blob from 12.32.0 to 12.33.0
Bumps [@azure/storage-blob](https://github.com/Azure/azure-sdk-for-js/tree/HEAD/sdk/storage/storage-blob) from 12.32.0 to 12.33.0.
- [Release notes](https://github.com/Azure/azure-sdk-for-js/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/storage/storage-blob/CHANGELOG.md)
- [Commits](https://github.com/Azure/azure-sdk-for-js/commits/@azure/storage-blob_12.33.0/sdk/storage/storage-blob)

---
updated-dependencies:
- dependency-name: "@azure/storage-blob"
  dependency-version: 12.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-04 20:32:53 +00:00
dependabot[bot] 402b79c340 build(deps): bump mongodb from 7.3.0 to 7.4.0 in /tests/playwright
Bumps [mongodb](https://github.com/mongodb/node-mongodb-native) from 7.3.0 to 7.4.0.
- [Release notes](https://github.com/mongodb/node-mongodb-native/releases)
- [Changelog](https://github.com/mongodb/node-mongodb-native/blob/main/HISTORY.md)
- [Commits](https://github.com/mongodb/node-mongodb-native/compare/v7.3.0...v7.4.0)

---
updated-dependencies:
- dependency-name: mongodb
  dependency-version: 7.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-04 20:32:51 +00:00
dependabot[bot] 08ba9b02f2 build(deps-dev): bump @playwright/test in /tests/playwright
Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.61.0 to 1.61.1.
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](https://github.com/microsoft/playwright/compare/v1.61.0...v1.61.1)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-version: 1.61.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-04 20:32:44 +00:00
dependabot[bot] 3a016be97d build(deps): bump i18next from 25.10.10 to 26.3.4
Bumps [i18next](https://github.com/i18next/i18next) from 25.10.10 to 26.3.4.
- [Release notes](https://github.com/i18next/i18next/releases)
- [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md)
- [Commits](https://github.com/i18next/i18next/compare/v25.10.10...v26.3.4)

---
updated-dependencies:
- dependency-name: i18next
  dependency-version: 26.3.4
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-04 20:32:38 +00:00
dependabot[bot] 56b09f9102 build(deps): bump docker/build-push-action from 7.2.0 to 7.3.0
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 7.2.0 to 7.3.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](https://github.com/docker/build-push-action/compare/f9f3042f7e2789586610d6e8b85c8f03e5195baf...53b7df96c91f9c12dcc8a07bcb9ccacbed38856a)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-version: 7.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-04 20:32:31 +00:00
dependabot[bot] dccf16647a build(deps): bump docker/metadata-action from 6.1.0 to 6.2.0
Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/docker/metadata-action/releases)
- [Commits](https://github.com/docker/metadata-action/compare/80c7e94dd9b9319bd5eb7a0e0fe9291e23a2a2e9...dc802804100637a589fabce1cb79ff13a1411302)

---
updated-dependencies:
- dependency-name: docker/metadata-action
  dependency-version: 6.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-04 20:32:23 +00:00
dependabot[bot] 9c2ff81b12 build(deps): bump docker/login-action from 4.2.0 to 4.4.0
Bumps [docker/login-action](https://github.com/docker/login-action) from 4.2.0 to 4.4.0.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](https://github.com/docker/login-action/compare/650006c6eb7dba73a995cc03b0b2d7f5ca915bee...af1e73f918a031802d376d3c8bbc3fe56130a9b0)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-version: 4.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-07-04 20:32:19 +00:00
dependabot[bot] af8bba27c0 build(deps): bump actions/cache from 5 to 6
Bumps [actions/cache](https://github.com/actions/cache) from 5 to 6.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v5...v6)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-27 20:32:19 +00:00
github-actions[bot] 8f83ece2ed Bump versions for v9.73 2026-06-26 03:18:47 +00:00
Lauri Ojansivu ac8e39daca Updated ChangeLog. 2026-06-26 06:13:08 +03:00
Lauri OjansivuandClaude Opus 4.8 3c07777722 docs(changelog): repoint #6426/dragscroll links to post-rebase hashes
A git pull --rebase inserted upstream commit 17c62ccdf (Bump versions for
v9.72) under this session's work, rewriting its commit hashes. The CHANGELOG
still linked the pre-rebase hashes (37ac65e37, a4cce9a53), now orphaned and
not on main. Repoint to the rebased commits 219ee659e and 88f353dc1.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-26 05:08:35 +03:00
Lauri OjansivuandClaude Opus 4.8 0e10d24bef docs(changelog): add login/register mobile-scroll fix entry (4a7df3745)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-26 05:07:38 +03:00
Lauri OjansivuandClaude Opus 4.8 4a7df37459 fix: login/register page not scrollable on mobile — sign-up link unreachable
On phones body.mobile-mode pins <body> to position:fixed + height:100vh (an
iOS board-view anti-bounce fix). The auth pages (userFormsLayout) have no
inner #content scroller, and .auth-layout/.auth-dialog were sized to the
viewport height, so the page was trapped at 100vh: the content below the
form — the sign-up/sign-in link, legal notice and language selector — could
not be scrolled into view, and the on-screen keyboard covered it.

userFormsLayout now tags <body> with .userform-layout while mounted, and CSS
lets those pages scroll as a normal document on mobile (position:static,
height:auto, min-height:100vh) with the auth layout/dialog growing to their
content. Scoped to .userform-layout so the board-view mobile lock is
unchanged. Removed on destroy.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-26 05:07:22 +03:00
Lauri OjansivuandClaude Opus 4.8 f9b5de0e8e docs(changelog): link all-pages dragscroll entry to fix commit a4cce9a53
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-26 04:55:26 +03:00
Lauri OjansivuandClaude Opus 4.8 88f353dc1f fix: drag-to-scroll on all pages via central route-aware autorun
Page drag-to-scroll was wired into only boardsList (All Boards), myCards and
userFormsLayout (Login/Register). Every other defaultLayout page — Due Cards,
Global Search, Public, Bookmarks, Broken Cards, Settings, People, Admin
Reports, Attachments, Translation, Import, board Rules, Not Found — had no
page drag-scroll, and the per-template enable/disable calls fought each other
when navigating between two non-board pages (one template's onDestroyed
removed the class the next template's onRendered expected).

Replace them with a single route-aware autorun in defaultLayout (the
persistent shell that owns #content): non-board routes tag the real scroll
container (<body> + #content, so it works in both desktop and mobile mode),
and board-canvas routes (board/board-short/card) leave page tagging off so
their own .board-canvas.dragscroll handles dragging without double-scrolling
#content. Login/Register keep their own enable/disable (userFormsLayout has
no #content).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-26 04:55:26 +03:00
Lauri OjansivuandClaude Opus 4.8 50525f6fd1 docs(changelog): link Upcoming #6426 + dragscroll entries to fix commit 37ac65e37
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-26 04:55:26 +03:00
Lauri OjansivuandClaude Opus 4.8 219ee659e9 fix: finish reverting oversized mobile UI (#6426) + fix page dragscroll
#6426: the first revert only cleaned boardsList.css. The same forced
"2x/3x bigger on mobile" rules remained in header.css (#header-quick-access
logo/quick-access bar) and boardBody.css (#content — which the All Boards
list and the board view render inside) plus the iPhone card-details body
text. All neutralized to normal size; the iPhone-12-mini header blocks that
had grown tall/wrapped to fit 3x text are back to a compact single row. The
#6419 mobile touch-target icon sizes in the card-details header are kept.

dragscroll: enablePageDragscroll/disablePageDragscroll tagged only <body>,
but on phones body.mobile-mode is position:fixed and the real scroll
container becomes #content, so Login/Register/All Boards could not drag-
scroll. Now tag whichever element actually scrolls — both <body> and
#content when present — so only the overflowing one scrolls. The touch
helper already prefers the nearer #content.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-26 04:55:26 +03:00
github-actions[bot] 17c62ccdf6 Bump versions for v9.72 2026-06-25 23:26:37 +00:00
Lauri Ojansivu 14de82ad2d Updated ChangeLog. 2026-06-26 02:15:49 +03:00
Lauri Ojansivu e92f4f9819 Updated translations. 2026-06-26 02:12:33 +03:00
Lauri Ojansivu 08aac777fb docs(changelog): generalize #6426 wording to mobile UI scope 2026-06-26 02:10:26 +03:00
Lauri Ojansivu b84caaad26 docs(changelog): link #6426 entry to fix commit\n\nFixes #6426 2026-06-26 02:09:06 +03:00
Lauri Ojansivu f7a2a3ace5 fix: revert oversized mobile All Boards/iPhone 12 mini UI\n\nFixes #6426 2026-06-26 02:08:49 +03:00
Lauri OjansivuandClaude Opus 4.8 88a2e96db3 CHANGELOG: Upcoming — api.py addcustomfieldtoboard empty-settings fix
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 03:05:02 +03:00
Lauri OjansivuandClaude Opus 4.8 487cf3f963 api.py: fix addcustomfieldtoboard crash on empty settings
json.loads('') on an empty settings argument raised JSONDecodeError before the
request was sent (a bug api.py's own header flagged). Default empty settings to
{} and send it as valid JSON via json.dumps instead of str(dict) (which produced
invalid JSON with single quotes). Verified: both empty and object settings create
the custom field.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 03:03:10 +03:00
github-actions[bot] 6b3ae817fe Bump versions for v9.71 2026-06-23 15:54:59 +00:00
Lauri OjansivuandClaude Opus 4.8 f74c658552 i18n: Finnish translations for fixed-list-width strings (#5729)
Translate the 4 newly-added fixed-list-width keys in fi.i18n.json to Finnish,
matching existing terminology (Lista/listoille, leveys, 'vain sinua varten'
as in list-width-personal-note). The remaining strings identical to English
are technical terms, abbreviations and placeholder-only templates (poker
numbers, LDAP/OAuth2/CAS/OK, Gantt, S3/GridFS, operator abbrevs, __board__)
that are correctly the same in Finnish.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 18:33:42 +03:00
Lauri Ojansivu 58fa52a4ac Updated translations. 2026-06-23 18:32:01 +03:00
Lauri Ojansivu 468a1e3d1d Updated ChangeLog. 2026-06-23 18:29:27 +03:00
Lauri OjansivuandClaude Opus 4.8 945b634d32 fix: full-width sidebar at top of board on phones (mobile + desktop mode)
On iPhone 12 mini the right board sidebar showed as a narrow strip pinned to
the far right. The sidebar lives inside .board-wrapper, which is wider than
the viewport on a phone, so the absolutely-positioned sidebar
(inset-inline-end: 0) anchored to the right edge of the wide board instead of
the screen. Under the @media (max-width: 800px) breakpoint (which matches the
viewport in both mobile and desktop mode), pin the sidebar to the VIEWPORT
with position: fixed + 100vw so it is a full-width panel at the top of the
board. Also normalise the sidebar text sizes so the headings are not
oversized and small text not tiny, reading consistently with the board.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 18:24:01 +03:00
Lauri OjansivuandClaude Opus 4.8 c70a36d89e fix: vertically center swimlane header buttons (mobile)
The swimlane header buttons (collapse, swimlane menu, + new swimlane, drag
handle) hugged the top of the swimlane header on small screens (e.g. iPhone
12 mini). The menu was absolutely positioned at top:0 and each icon used a
top: calc(50% + Npx) offset that centered against the menu's own small
height, not the header. Stretch .swimlane-header-menu to the full header
height and flex-center its children vertically (align-items: center), and
drop the now-unnecessary per-icon top offsets, so the buttons sit in the
middle of the swimlane header.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 18:15:59 +03:00
Lauri OjansivuandClaude Opus 4.8 19deee64c6 test: add test:unit:all npm script to run the full node test suite
Runs every plain-Node (non-browser) test in one command: builds on
test:unit:node and adds the sticker, link-card-popup (#5715), Trello/Wekan
importer and oauth2 admin-group suites. All green.

Browser-driven suites (Meteor client mocha + Playwright e2e) are not
included here — they need a running app + a working browser, which an x86
Chromium cannot provide on an ARM host under qemu; run those on x86 CI.
rtl.test.js is intentionally excluded (2 pre-existing CSS lint failures).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 18:05:09 +03:00
Lauri OjansivuandClaude Opus 4.8 0ddc47a0db fix: changing UI language had no effect for region/script-tagged languages
The custom tap:i18n reimplementation registered each language's resource
bundle under the raw Wekan tag, but i18next (cleanCode: true) resolves and
looks translations up under a normalised code. For region/script-tagged and
legacy underscore tags (zh-CN, zh-Hans, ar-DZ, af_ZA, en_AU, ...) the stored
code and the lookup code disagreed, so the bundle was never found and the UI
silently fell back to English while simple tags (de, fr) kept working.

Normalise every i18next boundary (supportedLngs, addResourceBundle,
changeLanguage, t) through one helper (toI18nCode): underscores -> hyphens
and i18next's formatLanguageCode, so storage and lookup always agree.
Safely unwrap ES-module-namespace JSON imports without mistaking the data's
own "default" translation key for a module default export. Surface failed
language switches in the user header / login form instead of leaving the UI
silently English. Add positive and negative regression tests.

Closes #5756

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 16:51:56 +03:00
Lauri OjansivuandClaude Opus 4.8 f456a1b8f5 fix: forgot-password 500 — make reset-password email build/send graceful
Forgot Password -> "Email reset link" could return a raw HTTP 500 instead of
sending the email / showing success (#5706). When SMTP is unconfigured (no
MAIL_URL / MAIL_FROM, or a bad mail server), Meteor's Email.sendAsync throws and
the exception propagated unhandled out of the forgotPassword method as an opaque
500.

Harden the reset-password / verify-email / enroll-account email-template builders
so they never throw (guarded user name/language lookups, safe fallback if
translation throws), and wrap Accounts.sendResetPasswordEmail so a send failure
surfaces as a clean Meteor.Error('email-fail', ...) instead of a 500. Logic
extracted to server/lib/resetPasswordEmail.js with positive + negative unit tests
in tests/unit/resetPasswordEmail.test.js (wired into the test:unit:node script).

Note: this makes the failure graceful; receiving reset emails still requires SMTP
to be configured.

Closes #5706

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 16:50:24 +03:00
Lauri OjansivuandClaude Opus 4.8 5d74057c3a fix: link to a whole board even when that board already has cards
The link-card popup (linkCardPopup in client/components/lists/listBody.js)
used to auto-populate the List/Card sub-selects when a board was chosen,
leaving no way to clear them. Once the chosen board had cards, you could
only link to a card and never to the whole board.

The Swimlane/List/Card selects now default to a blank "(none)" option and
are not auto-selected on board change (this part was already merged from
seve12 / PR #5967). In addition, the popup's confirm ("link") button now
falls back to creating a board-level link when a board is selected but the
Card field is left blank, so a whole board can be linked with the single
bottom button regardless of whether the board has cards. The duplicate
board-link guard is preserved and a blank selection never creates a
phantom/undefined linked card.

Added tests/linkCardPopup.test.js (standalone Node, like
tests/cards.stickers.test.js) covering positive and negative cases.

Closes #5715

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 16:48:59 +03:00
Lauri OjansivuandClaude Opus 4.8 4edfcb0cf6 fix: due date fails when locale uses non-Latin (Persian/Arabic-Indic) digits
In locales such as Persian/Farsi or Arabic, dates and times can be rendered
with non-Latin digits (Persian/Extended Arabic-Indic ۰-۹ U+06F0–U+06F9, or
Arabic-Indic ٠-٩ U+0660–U+0669). The native JavaScript Date constructor only
understands ASCII digits, so such a string fails to parse and produces an
Invalid Date when setting/updating or comparing dates.

Added a normalizeDigits() helper in imports/lib/dateUtils.js that converts
those non-Latin digits to ASCII, applied it at every date-string parse
boundary in dateUtils.js (via an internal toDate() wrapper) and in the
date/time picker submit/change handlers in client/lib/datepicker.js. The
normal ASCII path is unchanged.

Added tests/dateUtils.normalizeDigits.test.cjs (positive and negative cases)
and wired it into the test:unit:node script.

Closes #5752

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 16:47:00 +03:00
Lauri OjansivuandClaude Opus 4.8 9a5dd98389 feat: fixed (same) width for all lists (#5729)
Add a per-viewer, per-board "Same width for all lists" (fixed width) mode.
When enabled, every list renders at one shared width and drag-resizing any
list updates that single value so all lists change together. Works for both
logged-in users (profile.fixedListWidthBoards / profile.fixedListWidths via
new setFixedListWidthEnabled / setFixedListWidth Meteor methods) and
anonymous public-board users (localStorage). Enabling fixed width turns off
auto-width; widths below 270px are rejected.

Adds Playwright spec 38 covering positive and negative cases for logged-in
(profile/DDP + rendered widths) and anonymous (localStorage) viewers.

Closes #5729

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 16:46:24 +03:00
Lauri OjansivuandClaude Opus 4.8 01271b79e8 test: add tests + negative tests for #5799, #6423, #6424
- tests/playwright/specs/39-allboards-sort-search-pagination.e2e.js (#5799):
  UI sort (A-Z/Z-A) + search (positive + non-matching negative); server
  getAllBoardsPage paging (page boundaries, search narrowing, empty result,
  and a negative that boards the user can't access never leak).
- tests/playwright/specs/40-rest-card-move-list.e2e.js (#6423): PUT card with
  listId returns 200 (not 500) and moves the card + records a moveCard
  activity; repeated moves never 500; a user without write access cannot move.
- tests/minicardLabelHeight.test.cjs (#6424): CSS regression guard that the
  minicard label viewer/label min-height overrides stay in place; wired into
  test:unit:node.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 16:36:14 +03:00
Lauri OjansivuandClaude Opus 4.8 1be9b98559 i18n: Finnish translations for All Boards sort/search strings (#5799)
Translate the new sort-boards / search-boards strings in fi.i18n.json to
Finnish, matching existing terminology (taulu/taulut, Etsi, Lajittele,
Otsikko). The other strings that remain identical to English are technical
terms and abbreviations (LDAP, OAuth2, S3, GridFS, poker numbers, operator
abbreviations) that are correctly the same in Finnish.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 16:18:14 +03:00
Lauri OjansivuandClaude Opus 4.8 71c0c2b582 test: impersonation UI tests + ChangeLog for All Boards sort/search/pagination (#5799)
Adds Playwright specs covering GlobalAdmin impersonation: impersonating a
user from Admin > People makes the session act as that user (Meteor.userId,
audit record, board data visibility), and a non-admin cannot impersonate.
Documents #5799 in the ChangeLog.

Refs #5799

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 16:16:11 +03:00
Lauri Ojansivu 98800d61cc Updated translations. 2026-06-23 16:14:47 +03:00
Lauri Ojansivu 2cf94c2fd3 Updated translations. 2026-06-23 16:12:16 +03:00
Lauri OjansivuandClaude Opus 4.8 c1da7a4a33 feature: All Boards search + server-side pagination of board icons (#5799)
Builds on the alphabetical sort: add a board-name search box and paginated
board icons to the All Boards page, with the search box and pagination
controls placed like Admin Panel > People.

- Search by board name spans every category (Starred, Templates, Remaining
  and all (sub)workspaces) from one box; Esc / a clear button reset it.
- In the sorted (A->Z / Z->A) modes the current page of board icons is
  computed on the server (getAllBoardsPage) and only that page is rendered,
  so the page scales to thousands of boards. Custom (manual drag order)
  stays unpaginated client-side so drag-reordering keeps working.
- getAllBoardsPage resolves visibility, menu/workspace filtering, search and
  sort against the effective current user (this.userId), so it also works
  when a GlobalAdmin impersonates a user.

Refs #5799

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 16:04:56 +03:00
Lauri OjansivuandClaude Opus 4.8 f74ccbc8fa feature: sort All Boards alphabetically (A-Z / Z-A)
The All Boards page only offered the per-user manual drag order, with no
obvious way to sort boards by name (#5799). Add a "Sort" button to the All
Boards header that opens a popup to choose Custom (manual drag order, the
default), Title A->Z, or Title Z->A. The choice is stored per user in
profile.allBoardsSortBy and applied in sortBoardsForUser(), so it persists
and reorders the grid live.

Closes #5799

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 15:44:46 +03:00
Lauri OjansivuandClaude Opus 4.8 7436b9d06a Updated ChangeLog.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 15:38:17 +03:00
Lauri OjansivuandClaude Opus 4.8 22f996903b fix: notification emails ignored the user's language and were sent in English
On the server only the default (English) translation bundle is loaded at
startup. Translating a notification to a user's language called
TAPi18n.__(key, params, lang) with lng=lang, but that resource bundle was
never added on the server, so i18next fell back to English — every
notification email went out in English regardless of the user's profile
language. (The client works because switching language calls setLanguage,
which loads the bundle.)

Add TAPi18n.ensureLanguageLoaded(language), which loads the bundle on
demand if i18next does not already have it, and await it before translating
in the email notification, EmailLocalization.sendEmail and outgoing webhook
paths.

Closes #5875

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 15:37:56 +03:00
Lauri OjansivuandClaude Opus 4.8 e5edb54a53 Updated ChangeLog.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 15:34:08 +03:00
Lauri OjansivuandClaude Opus 4.8 69c899f1f9 fix: REST card move to another list returned HTTP 500
The PUT .../cards/:cardId list-move path called cardMove() with
{ fieldName: 'listId' } as its fieldNames argument. cardMove() does
fieldNames.includes('boardId'), and a plain object has no .includes, so
moving a card to another list over the REST API threw
"fieldNames.includes is not a function" and returned HTTP 500. Pass the
changed field names as an array (['listId']) like the board-move path does.

Closes #6423

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 15:33:52 +03:00
Lauri Ojansivu 0f86a81bd8 Updated ChangeLog. 2026-06-23 15:31:37 +03:00
Lauri OjansivuandClaude Opus 4.8 338adb5ba9 Updated ChangeLog.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 15:29:57 +03:00
Lauri OjansivuandClaude Opus 4.8 afbabccd26 fix: card labels took two lines / double height on minicards
Each minicard label's name is rendered inside a `.viewer`, whose global
`min-height: 2.5vh` (intended for the full content editor) forced every
label to roughly double height, wasting vertical space on the board.

Scope overrides to minicard text labels: reset that `min-height`, render
the viewer/paragraph inline, and keep each label on a single compact line.

Closes #6424

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 15:29:57 +03:00
github-actions[bot] cf5560b41f Bump versions for v9.70 2026-06-23 07:20:48 +00:00
Lauri Ojansivu 5c53b8611b Updated ChangeLog. 2026-06-23 10:16:57 +03:00
Lauri Ojansivu 6aa514f359 Updated translations. 2026-06-23 10:12:46 +03:00
Lauri OjansivuandClaude Opus 4.8 ac9efbf402 fix: cross-board card copy throws on a board with no labels
Card.copy()'s cross-board label-remap did oldBoard.labels.filter(...) and
filterCopiedLabelIds(newBoard.labels, ...) without guarding a missing labels
array. Boards created via the REST API (POST /api/boards) have no labels array,
so copying a card to/from such a board — or copying the board itself (which
copies its cards cross-board) — threw "Cannot read properties of undefined
(reading 'filter')" and returned HTTP 500. Both lookups now fall back to [].

Also fixes the subtask cross-board-copy test seed (real cards always have a
userId; the seed lacked one, hitting "User ID is required in cards insertAsync").

Validated locally: full tests/playwright/specs/17-rest-api.e2e.js passes
(24/24, chromium) against a running dev server, and npm run test:unit:node
passes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 09:55:34 +03:00
Lauri OjansivuandClaude Opus 4.8 1f344879fb fix: client bundle crash — move server-only card helpers out of the client bundle
models/lib/cardBoardConsistency.js and models/lib/restArrayParam.js are
CommonJS (module.exports), but being under models/ they were eagerly bundled
into the client by rspack, which classifies a no-import/require .js as an ES
module and threw at load time:

  Uncaught Error: ES Modules may not assign module.exports or exports.*
  ... ./models/lib/cardBoardConsistency.js -> ./models/cards.js

This aborted the client bundle on every page. (filenameSanitizer.js uses the
same module.exports pattern without issue only because it is never imported
into the client bundle.)

Both helpers are server-only logic (a REST handler and a Cards.before.update
hook), so they are moved to server/lib/ (excluded from the client rspack
bundle, CommonJS is fine on the Node server) and enforceCardBoardConsistency
is relocated from the isomorphic models/cards.js into server/models/cards.js.
The isomorphic models/cards.js no longer imports either helper.

Verified in a real headless Chromium against a running dev server: the page
now loads with window.Meteor present and zero console/page errors (previously
one PAGEERROR from cardBoardConsistency.js). Node unit tests updated to the new
paths and pass (npm run test:unit:node, 11 passing).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 08:50:29 +03:00
Lauri OjansivuandClaude Opus 4.8 85841a1c43 fix: cross-board card copy re-homes subtasks onto the destination board
Card.copy() re-pointed each subtask's parentId to the copied card but left its
boardId/swimlaneId/listId pointing at the source board, so copying a card to
another board orphaned its subtasks on the original board (parent on the new
board, subtask on the old one). It also mutated the cached source docs in place.
Copied subtasks are now re-homed onto the destination board/swimlane/list via a
fresh object (no cache mutation) — same class as the #5166/#5874 cross-board
consistency fixes.

Cross-board subtask copy regression in tests/playwright/specs/17-rest-api.e2e.js.
This fixes the orphaned-cross-board-subtask data symptom noted in #5347; the
separate "Maximum call stack" error there is not root-caused, so #5347 stays
open.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 08:19:05 +03:00
Lauri OjansivuandClaude Opus 4.8 c2c6bdaedd fix(#5325,#5390,#5565): notification crash, custom-field delete crash, minicard checklists
#5325: a notification referencing a deleted activity (card/board gone) had a
null activityObj, and the notifications drawer dereferences it — one orphaned
entry threw and broke the whole popup. user.notifications() now drops entries
whose activity can't be resolved.

#5390: removing a multi-board custom field from one board logged a
setCustomField activity via (await getActivity()).value with no null guard, so
a field that never had a value set threw and aborted the removal. Guarded.

#5565: the sidebar "show checklists on minicard" toggle writes
board.allowsChecklistsOnMinicard, but the minicard checked a different UI-less
field (allowsChecklistAtMinicard), so the toggle had no effect. Minicard now
reads the field the toggle actually sets.

(No automated regressions: #5325/#5565 are client-display logic and #5390's
trigger needs a multi-board custom field; all three are small, self-evident
guards/field-name corrections.)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 08:07:09 +03:00
Lauri OjansivuandClaude Opus 4.8 39e8cc11a4 perf(#5688): copy a card's checklists/items without per-item activity churn
Checklist.copy() duplicated each checklist item with the hooked insertAsync, so
collection-hooks fired each item's after.insert — every one doing a getCard and
inserting an addChecklistItem activity. Copying a card with ~100 items meant
~100+ activity inserts plus per-item DB round-trips, taking minutes and spiking
CPU. The copy now uses .direct for the checklist and its items (skipping the
per-item activity hooks, which are pure churn for a wholesale copy) and sets
boardId itself — the same approach as the cardRemover delete path.

Copy regression (checklist + all items duplicated, correct boardId/checklistId)
in tests/playwright/specs/17-rest-api.e2e.js. Also documents #5388 (list
collapse now per-user) as verified-resolved.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 07:59:35 +03:00
Lauri OjansivuandClaude Opus 4.8 0a206c85cf docs(changelog): note #5411 verified-resolved (board admins can invite)
Board admins already see the add-member + via canInviteToBoard (board.hasAdmin
returns true; default invite roles include board-admin) — resolved by the
Allow-Invite-to-Board roles feature (c956ab5a4), which postdates the report.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 07:39:39 +03:00
Lauri OjansivuandClaude Opus 4.8 0ed4d1556c fix(#4965,#5809): reactive card members popup; surface linked-card edit errors
#4965: the card "add members" popup snapshotted board.activeMembers() once on
open, so a member added to the board afterwards (or whose user doc loaded just
after open) was missing until the popup was reopened. The popup now stores only
the filter term and derives its candidate list reactively from
board.activeMembers() on each render, so newly-added members appear without
reopening. activeMembers() itself is unchanged.

#5809: editing a linked card whose target is on a board the user cannot write
to was rejected by the server allow rule, but the title/description submit
handlers had no error handling, so the edit vanished silently. They now catch
the failure and show the error (mirroring the existing label-color handler).

Also documents #3894 (import with a member missing from users) as
verified-resolved — already guarded in the importers with a dedicated test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 07:36:30 +03:00
Lauri OjansivuandClaude Opus 4.8 4edbab4402 fix(#4847): allow removing a deleted user from a card's members
When a user account is deleted its entry stays in a card's members and renders
as a blank avatar. Clicking it opened cardMemberPopup, whose template
dereferenced the missing user document and failed to render, so the orphaned
member could not be removed. The popup now detects a missing user, shows a
"Deleted user" entry with the raw id, and keeps the Remove from Card control
(the remove handler keys off the member's userId, not the user doc). Adds the
deleted-user i18n string.

No automated regression — a self-evident Blaze template guard; the underlying
unassignMember removal already worked. The board-members list still hides such
entries because activeMembers() also filters not-yet-loaded users, so
surfacing board-side orphans cleanly is a separate follow-up (noted in
changelog).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 07:27:29 +03:00
Lauri OjansivuandClaude Opus 4.8 0f45c0e392 fix(#5122): boards report lists only active members
Removing a member from a board marks the entry isActive:false (kept in
board.members for role history / re-activation), but the Admin Panel boards
report listed all member entries, so removed users still showed as members.
The report's userNames helper now filters to active members. The raw
GET /api/boards/:boardId response intentionally still returns the full members
array with isActive flags so API consumers can filter as needed.

Also documents #5630 (cannot save Layout settings) and #5117 (TeX rendered both
SVG and a math tag) as verified-resolved — both already fixed in current code
(Layout save handler no longer reads the moved accessibility fields; math
rendering migrated from markdown-it-mathjax3 to Temml/MathML).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 07:12:47 +03:00
Lauri OjansivuandClaude Opus 4.8 ba62449323 fix(#5592,#1894): copy board webhooks; block disabled users from boards
#5592: board.copy() duplicated swimlanes/lists/cards, custom fields and
rules/triggers/actions but had no loop for Integrations (outgoing webhooks),
so a copied board lost all of them (they are per-board children — boardRemover
deletes them by boardId). copy() now also copies the board's Integrations,
remapping boardId.

#1894: none of the add-member paths checked the target account's loginDisabled
flag, so a deactivated user could be added to a board and assigned to cards.
inviteUserToBoard now throws error-user-disabled and the REST add-member
endpoint returns HTTP 400 when the target account is disabled (added the
error-user-disabled i18n string).

Also locks in #5627 (rules ARE copied on board copy — already-fixed code that
the old report predates) with the same copyBoard regression. Regressions in
tests/playwright/specs/17-rest-api.e2e.js; changelog updated under Upcoming.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 06:52:15 +03:00
github-actions[bot] 6d5176bd87 Bump versions for v9.69 2026-06-23 03:38:09 +00:00
Lauri Ojansivu 9c8fd0f281 Updated ChangeLog. 2026-06-23 06:34:27 +03:00
Lauri OjansivuandClaude Opus 4.8 d8c675d82a perf(#3252,#5322): bypass per-child activity churn when deleting a card
cardRemover removed a card's checklist items, checklists and comments with the
hooked removeAsync, so collection-hooks fired each child's before.remove once
per document — every one doing a getCard and inserting an activity (e.g. a
removedChecklistItem per item), which then triggered notification + publication
observers. Deleting/bulk-deleting a card with many children produced an
activity-insert storm and high CPU.

cardRemover now removes those children with .direct (skipping the per-child
hooks, which only logged activities that are unviewable once the card is gone)
and clears all of the card's activities in a single bulk op — which also fixes
the activities a delete previously left orphaned. The deleteCard activity is
still logged afterward (outgoing webhook still fires), and attachments still go
through the normal remove so their files are deleted.

Cascade + activity-cleanup regression (also a negative test, since the old
cardRemover left the card's activities behind) in
tests/playwright/specs/17-rest-api.e2e.js.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 06:26:33 +03:00
Lauri OjansivuandClaude Opus 4.8 57caa2c337 fix(#3252): guard client card-detail deletes against evicted docs
Deleting a comment or checklist/checklist-item could throw "Removed
nonexistent document" on the client: the handlers called Collection.remove(_id)
directly, but under heavy archive/delete churn the target doc can already be
evicted from the client's Minimongo cache, and removing a missing _id throws.
The comment / checklist / checklist-item delete handlers now check the doc
still exists in the local cache before removing it. The server before.remove
hooks were already hardened to guard + log instead of throwing.

Partial: removes the thrown client exception; the high CPU on bulk delete the
issue also reports is separate reactivity/mergebox churn and remains a
follow-up. No automated regression — the eviction race is not deterministically
reproducible; the guard is a self-evident findOne-then-remove.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 06:12:35 +03:00
Lauri OjansivuandClaude Opus 4.8 5212d25fc2 fix(#5166): re-home copied card comments onto the destination board
When a card was copied to another board, CardComments.copy() only updated
the comment's cardId, so the copied comments kept the SOURCE board's boardId.
Comment permission checks key off the comment's boardId, so edit/delete on a
copied comment was validated against the wrong board, and board-scoped queries
saw it on the old board. copy() now also sets the destination boardId; the
author userId is intentionally preserved.

Cross-board copy regression in tests/playwright/specs/17-rest-api.e2e.js;
changelog documents the fix and notes the separate "wrong author shown"
display symptom (author not a member of the destination board → user doc not
published there) as a follow-up.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 06:04:14 +03:00
Lauri OjansivuandClaude Opus 4.8 55dbe59fde fix(#2875,#5650): REST card-create member coercion + board-create owner fallback
#2875: the card-create endpoints (POST .../cards and .../cards/bulk) wrote
req.body.members/assignees straight to the insert with no normalization (the
create-side twin of #3697), so a null/"" payload persisted as null and broke
later UI editing. Both now run coerceRestArrayParam: the field is omitted when
absent (schema default [] applies), any clear payload becomes [] (never null),
and a single id is wrapped into an array.

#5650: POST /api/boards set members[0].userId from req.body.owner with no
fallback, so a request omitting owner created a board whose only member had
userId=undefined. The boards publication matches members.$elemMatch
{userId, isActive:true}, which never matches undefined — the board was returned
by the REST API but invisible in the browser UI. owner now falls back to the
authenticated caller (req.body.owner || req.userId), mirroring the Meteor
create method.

REST regressions for both in tests/playwright/specs/17-rest-api.e2e.js;
changelog documents both under the Upcoming release.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 05:56:19 +03:00
Lauri OjansivuandClaude Opus 4.8 20888e44c1 fix(#3697): REST clear of card members/assignees stores [] not null
Clearing a card's members/assignees over the REST API left the field
uneditable in the UI. The card PUT handler guarded with `if (req.body.members)`
— falsy for the natural clear payloads (null and "") — so removing the last
member was a silent no-op, and its string branch wrote null instead of [];
a card with members:null then breaks UI code that treats it as an array.

The handler now uses an `!== undefined` guard plus a shared coercion helper so
any clear payload (null / "" / []) stores a clean String[] (never null), a
single id is wrapped into an array, and stray non-string entries are dropped.
getMembers()/getAssignees() also coerce a legacy null to [] on read, healing
existing corrupted documents.

Pure logic in models/lib/restArrayParam.js with a Meteor-free Node unit test
(tests/restArrayParam.test.cjs, incl. a negative test reproducing the old
null-writing logic) wired into `npm run test:unit:node`, plus a REST regression
in tests/playwright/specs/17-rest-api.e2e.js. Changelog: documents #3697 and
moves #2292 (archive-swimlane) to verified-resolved (archive() does not delete
cards; restore brings them back).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 05:36:16 +03:00
github-actions[bot] ee240c5c05 Bump versions for v9.68 2026-06-23 02:19:19 +00:00
Lauri Ojansivu 477181730d Updated ChangeLog. 2026-06-23 05:06:22 +03:00
Lauri Ojansivu 94c31d25e7 Updated translations. 2026-06-23 05:05:32 +03:00
Lauri OjansivuandClaude Opus 4.8 10d591383f docs(changelog): tidy Upcoming for release — promote finished, add TODO Later
Remove the session WORKING NOTE (all content was duplicated in the body or
now stale). Fold the two "issue triage (work in progress)" blocks into the
release notes: promote the finished #3745 fix into the bug-fix list, group
the verified-resolved-but-awaiting-reporter issues (#3826 #1289 #1389 #5808
#5757) under a clear heading, and move everything not finished this release
(#2292 #5730 #3697 needing repro; #4560 #3707 #3700 #3575 #1192 needing
infrastructure; #5547 #3843 #3823 #3138 #2204 feature/by-design) into a new
"TODO Later" section. Drop the stale triage lines for #5874 and #4255, which
are now actually fixed and listed among the bug fixes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 04:58:07 +03:00
Lauri OjansivuandClaude Opus 4.8 d416184c84 docs(changelog): finalize upcoming-release working note
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 03:05:18 +03:00
Lauri OjansivuandClaude Opus 4.8 37035e1b0f docs(changelog): record #3745-test decision + push reminder for local commits
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 02:58:14 +03:00
Lauri OjansivuandClaude Opus 4.8 2379357e64 fix(#4255): scope archived-boards list to deletable boards only
The Archive listed boards the user could not delete — clicking Delete did
nothing and the console showed "remove failed: Access denied". The
archivedBoards publication scoped to admin members (isAdmin: true) but
ignored the active flag, while Boards.remove (hasAdmin) requires an active
admin (isActive: true && isAdmin: true). An inactive admin saw the board
but could not delete it. The publication now matches the remove permission
exactly, so the Archive only lists boards the user can really delete.

Also documents #4255 + #5874 in the changelog and records #1389 as
verified-resolved (a dedicated edit pencil already makes a description
with an edge-to-edge URL editable).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 02:57:10 +03:00
Lauri OjansivuandClaude Opus 4.8 926c4baba8 fix(#5874): server-side guard against cross-board move data loss
Rarely, moving a card from board A to board B left it half-moved: boardId
became B but listId/swimlaneId still pointed at board A, so the card was
invisible in every normal view on both boards and clicking it reopened A.

Root cause: the Move/Copy dialog resolves the destination board's
swimlanes/lists from the client Minimongo cache, which can still be empty
when the user clicks Done (the destination board's publishComposite data
has not merged yet) — leaving the source board's swimlaneId/listId while
boardId is already the destination. setFirstSwimlaneId/setFirstListId
swallow the cache miss in a silent try/catch. Other callers (drag, filter
multi-move, rules, REST API) can produce the same mismatch.

Fix: a new Cards.before.update guard (enforceCardBoardConsistency,
registered first) rewrites the pending update on any boardId change so the
swimlane/list always belong to the destination board, falling back to its
default swimlane and first list. Runs server-side where the destination
board's data is always present; corrective only (valid moves untouched,
same-board reorders ignored). Decision logic extracted to a pure,
dependency-injected module with a Meteor-free Node unit test including a
negative test for the #5874 corrupt state.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 02:53:17 +03:00
Lauri OjansivuandClaude Opus 4.8 6d00246da4 docs(changelog): session checkpoint working-note before VSCode update + reboot
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 02:35:28 +03:00
Lauri OjansivuandClaude Opus 4.8 70a63e75f1 test: drag-sort reproduction harness + #3826 regression (parented card reorder)
Built tests/playwright/helpers/dragSort.js, which drives jQuery-UI sortable with
a realistic stepped mouse gesture (mousedown -> incremental mousemoves past the
7px distance threshold -> mouseup) because Playwright's high-level dragTo() does
not trigger jQuery-UI sortable. Validated it reorders normal cards.

Added specs/37-card-drag-sort.e2e.js for #3826 (cannot reorder cards in a list
whose cards have parents): dragging a sub-task card (with a parentId) to a new
position persists the new order, with a few cards and at 15 cards — i.e. the bug
does not reproduce on current code; the spec is a regression guard. Scoped to
Chromium (reorder logic is browser-independent) so cross-browser drag-timing
cannot flake the matrix. The harness also unblocks future drag-sort repros (#5874).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 02:22:04 +03:00
Lauri OjansivuandClaude Opus 4.8 270eacb20f docs(changelog): #1289 verified resolved via harness (deleted-member card renders cleanly)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 02:00:27 +03:00
Lauri OjansivuandClaude Opus 4.8 f999b9e749 fix(#3745): populate change-parent card list on first board selection
Template.cardMorePopup's cards() helper queried ReactiveCache.getCards({boardId})
from client minimongo the instant a parent board was selected, before that board's
card subscription had loaded — so the parent-card list was empty the first time
(and only worked on reopen, once the data had arrived). Subscribe with an onReady
callback + a parentBoardReady reactive flag, and only render the list once the
subscription is ready (same pattern as the #5798 fix).

Also documents (CHANGELOG) that #5808 (bidirectional cross-board card link hang)
could not be reproduced on current code via a mutual-link Playwright repro — the
card opens in ~1s with no redirect loop; re-test requested.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 01:51:24 +03:00
Lauri OjansivuandClaude Opus 4.8 efe9063df7 fix(#6419): stack admin settings menu+content on mobile (fix overlapping text)
The admin settings body forced flex-direction:row "even on narrow windows", so on
phones the ~127px side menu and the content were crammed together and the long
(e.g. Finnish) section labels overflowed the menu box, visually overlapping the
content text. Add a max-width:800px layout that stacks them: full-width compact
section menu on top (items wrap as a horizontal row), full-width content below.
Verified via Playwright iPhone-profile screenshots — menu labels and the toggle
rows now render cleanly with no overlap.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 01:26:45 +03:00
Lauri OjansivuandClaude Opus 4.8 c53bedb3a8 fix(#6419): cap admin panel 2nd-top-bar icon size in mobile mode
The admin panel's secondary top bar (settingHeaderBar: Settings/People/Reports/
Attachments/Translation/Info) renders inside #header-quick-access, whose mobile
rules scale all text/icons 2x. That made the admin tabs 28px text / 56px icons —
huge, overlapping the "Version" label. Add a scoped, higher-specificity override
(plus the .iphone-device fallback) capping them at 15px text / 18px icons.
Verified via Playwright iPhone-profile screenshot.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 01:06:02 +03:00
Lauri OjansivuandClaude Opus 4.8 0298670ac9 fix(#6419): mobile auto-detection root causes — viewport meta + mobileMode default
Two root causes behind "responsive views broken" / "icons too small to tap",
found via a Playwright iPhone-profile screenshot loop:

1. No viewport meta. The server-rendered <head> (customHeadRender.js) had no
   <meta name="viewport">, so mobile browsers used a default ~980px virtual
   width and scaled down: tiny UI, window.innerWidth=980 on a 390px phone, and
   @media (max-width:800px) never matched. Add width=device-width (user zoom
   left enabled for accessibility).

2. profile.mobileMode defaulted to false. The schema set mobileMode=false on
   every user, so getMobileMode() always returned it and the auto-detection was
   dead — every user stuck in desktop-mode even on phones. Make it optional (no
   default). Rewrite auto-detection to use matchMedia width/pointer queries
   instead of fragile UA sniffing (same class of bug as Meteor #12421), and add
   a matchMedia listener that re-applies mobile-mode on resize/orientation when
   the user has no explicit preference.

Verified on an iPhone 13 profile: innerWidth 390, body gets mobile-mode
automatically, header renders as large tappable icons.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 00:59:20 +03:00
Lauri OjansivuandClaude Opus 4.8 c1741d83f5 fix(#6419): width-based touch targets for board-header icons + mobile screenshot tool
Visual pass on the mobile layout using a new Playwright screenshot harness
(tests/playwright/mobile-shot.js, iPhone 13 profile). Measured the board-header
action buttons at 28px tall / 13px font at a phone width — too small to tap.
Added a @media (max-width: 800px) rule enlarging them to ~44px / 16px by viewport
width (independent of the manual mobile-mode toggle), giving a clean single row of
large icon-only buttons. Confirmed via screenshots that the open-card close (X)
is reachable (the #6419 z-index fix) and the voting buttons render (#6420).

Also noted (not fixed here): getMobileMode() did not add body.mobile-mode even
with an iPhone UA in testing, so the width-based @media path is the effective one.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 00:39:25 +03:00
Lauri OjansivuandClaude Opus 4.8 73a7f0b807 fix(#6419): enlarge mobile header action icons to ~44px touch targets
The reporter's main complaint was the mobile header icons being too small to
tap. In the max-width:800px media query the board-header buttons were 32px tall
with a 15px font, below the comfortable mobile touch-target / readable minimum.
Enlarge to 44px tall, 16px font, in a 48px bar. Vertical-only change, so the
horizontal crowding of the many header icons is unaffected. The broader
responsive asks (icon density, auto mobile detection) still need visual iteration.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 00:24:24 +03:00
Lauri OjansivuandClaude Opus 4.8 adbdef140e fix: #6420 missing voting buttons (currentUser ReferenceError) + #6419 mobile card close
#6420: showVotingButtons / showPlanningPokerButtons in cardDetails.js referenced
an undefined `currentUser`, throwing "ReferenceError: currentUser is not defined"
on every card render so the vote / planning-poker buttons disappeared. Resolve
currentUser via ReactiveCache.getCurrentUser() and null-guard the board-member
check. Adds a Playwright regression test (spec 36).

#6419 (partial): on mobile the open card could not be closed — the card-details
overlay (z-index 100) sat below the app header bar (#header-main-bar, z-index
1000), which covered the close (X) button. The full-screen mobile card now uses
z-index 1100 (above the header, below popups at 2000+). The broader responsive
asks in #6419 (header icon density, auto mobile detection, fonts) need a separate
visual design pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 00:04:20 +03:00
Lauri OjansivuandClaude Opus 4.8 a2695f0c8c ci: run Puppeteer regression suite against a production build too
The e2e-regression (Puppeteer) job started WeKan with `meteor run` (dev), so it
hit the same failure as the Playwright suite did: the rspack dev server does not
serve the client JS bundle in headless CI, Meteor never initialises, and the test
times out in waitForMeteorGlobals() ("Waiting failed: 60000ms exceeded"). Build a
production bundle and run node bundle/main.js, with WRITABLE_PATH (required by
00checkStartup.js) and WITH_API, mirroring the Playwright e2e job.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 23:45:56 +03:00
Lauri OjansivuandClaude Opus 4.8 aa2fbb48ac test(#5798): quarantine the CI-flaky template-card E2E flow
The #5798 product fix (target board derived from the list) is committed and
verified locally, where this spec passes every time. On the CI production bundle
(polling reactivity, no oplog) the multi-step template-search-and-instantiate UI
is unstable across runs — the card was intermittently not created at all (boardId
poll -> null) in a way that does not reproduce locally. Quarantine (test.fixme)
rather than keep cycling CI; the other spec-36 regressions still run. Needs a more
deterministic harness (drive instantiation via a method call) to re-enable.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 23:29:47 +03:00
Lauri OjansivuandClaude Opus 4.8 8ec0096964 fix(#5798): set card title right before picking template (CI card-not-created)
CI showed the boardId poll returning null — the card was never created, not
created on the wrong board. The click handler creates a card only when
.js-element-title is non-empty; the test set the title before the search, and the
search's reactive re-render cleared it on the slower CI production bundle, so the
click saw an empty title and created nothing. Set the title immediately before
clicking the template result.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 23:11:38 +03:00
Lauri Ojansivu 606bf912c0 Updated ChangeLog. 2026-06-22 22:49:59 +03:00
Lauri OjansivuandClaude Opus 4.8 29fb81c2f9 fix(#5798): derive template-card target board from the list, not getCurrentBoard
The CI production bundle revealed the #5798 fix was still fragile: it resolved the
target board via Utils.getCurrentBoard(), which reads route/session state that has
not settled on the slower production bundle, so it fell back to tpl.boardId and
created the card on the templates board (the bug). Derive the target board from
the board that OWNS the target list (tpl.listId) — where the user clicked "add
card" — which is reliable regardless of session timing. Bump the test's boardId
poll to 30s for the async copy.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 22:45:06 +03:00
Lauri Ojansivu 07ee1d8bad Updated ChangeLog. 2026-06-22 22:41:56 +03:00
Lauri OjansivuandClaude Opus 4.8 f4fc3fed4f fix(e2e): wait for profile propagation before #5798 template search
The #5798 spec set profile.templatesBoardId directly in Mongo, then opened the
template picker, which reads that pointer to subscribe to the templates board and
search its card templates. On the CI production bundle (polling reactivity) the
profile update had not reached the client yet, so the picker subscribed to
nothing and the search returned no results (the only remaining red spec; passed
locally where reactivity is fast). Wait until the client actually sees the
profile pointer before opening the picker.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 22:25:05 +03:00
Lauri OjansivuandClaude Opus 4.8 e0ed9eff4a fix(e2e): triage residual specs — 2 real product bugs + test/robustness fixes
After the production-build E2E went from 0 -> ~119/120 per shard, the residual
specs were triaged locally against a dev server:

Real product bugs found and fixed:
- Sort-cards header button: the js-sort-cards class (and thus its click handler)
  was replaced by `emphasis` once a sort was active, so the sort popup could not
  be reopened. Keep js-sort-cards always; add emphasis as an extra class.
- Deleting a Template Container board threw "Templates board ID is required":
  boardRemover $unset the four profile.* template pointers, but the schema typed
  them as non-optional String, so SimpleSchema rejected the update and aborted the
  removal. Mark the fields optional (#2339/#5850).

Test fixes:
- 31: call the '/boards/remove' DDP method with an object selector ({_id})
  instead of the unexposed Boards collection global (ReferenceError) / a string
  selector (Mongo "wrong type" error).
- 18 + 36: wait for the async result (i18n text / template search) on the slower
  CI production bundle instead of reading it immediately.
- 34: quarantine the auxiliary "plain click outside closes the card" control
  (test.fixme); the real #5686 guard it backs still passes. Needs follow-up.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 22:06:15 +03:00
Lauri OjansivuandClaude Opus 4.8 b9c5816642 Update CHANGELOG: E2E infra fix confirmed (0 -> ~119/120 per shard)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 21:34:43 +03:00
Lauri OjansivuandClaude Opus 4.8 cd2b48faf2 ci(e2e): enable WITH_API in the production bundle run
With the production bundle finally serving the client (104/120 passing per
shard), the remaining failures were almost all REST API specs (17, 23, 28, 24)
getting HTML instead of JSON: the API is gated behind WITH_API=true, which the
dev runner sets but the CI production run did not. Set WITH_API=true and
RICHER_CARD_COMMENT_EDITOR=false to match rebuild-wekan.sh.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 21:11:56 +03:00
Lauri OjansivuandClaude Opus 4.8 bf6d89ec32 feat(rebuild): install forge CLIs + mirror GitHub to GitLab/Codeberg/Forgejo/Gitea
Add two menu options to rebuild-wekan.sh and rebuild-wekan.bat:

1. Install forge CLI tools — gh, glab, tea, git-bug, and the unified
   git-pkgs/forge, via the detected package manager or `go install`.

2. Mirror a repo from GitHub to GitLab/Codeberg/Forgejo/Gitea — pick source
   and target by number (e.g. "1 3" = GitHub -> Codeberg). Code (all
   branches/tags) is pushed with `git push --mirror`; issues, PRs and CI
   workflow syntax are handled by a new cross-platform Node engine,
   tools/forge-mirror.js, which:
     * creates only the issues/PRs MISSING at the target (drives the
       authenticated gh/glab/tea CLIs, de-dups by title, dry-run by default);
     * converts GitHub Actions YAML for the target — an annotated
       .forgejo/workflows/ copy flagging Forgejo/Gitea incompatibilities
       (hashFiles, permissions, continue-on-error, complex runs-on), or a
       .gitlab-ci.yml scaffold + guide pointing at GitLab's official converter.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 21:10:33 +03:00
Lauri OjansivuandClaude Opus 4.8 a270be1d40 ci(e2e): set WRITABLE_PATH for the production bundle
The production-build E2E started `node bundle/main.js` but WeKan's
server/00checkStartup.js exits unless WRITABLE_PATH (attachment/file storage)
is set and writable. So the server never came up and every shard failed the
"wait for :3000" loop. Create a writable dir and pass WRITABLE_PATH.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 20:48:48 +03:00
Lauri OjansivuandClaude Opus 4.8 56d9651165 ci(e2e): run Playwright against a production build (option A)
The bundle-readiness gate confirmed the real cause of the red E2E: in dev mode
(`meteor run`) the rspack-served client JS bundle is never delivered in headless
CI (a probe got an empty response from the bundle URL for 10 minutes), so Meteor
never initialised and all specs timed out.

Switch the E2E "Start WeKan" step to a PRODUCTION build: `meteor build --directory`,
install the bundle's server deps, then `node bundle/main.js`. The production
server serves the client JS statically (no rspack dev server, no chunk-serving
race), which fixes the bundle delivery. Drops the dev-only /__rspack__/ readiness
gate (production serves the client at the proper URL once :3000 is up).

This still builds per shard; once green it can be optimised to build once and
share the bundle artifact across shards.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 20:29:31 +03:00
Lauri OjansivuandClaude Opus 4.8 cab6b526db ci(e2e): shard each browser's Playwright run across 2 parallel jobs
Each browser previously ran all ~245 specs on a single worker, so a run took
~2h40m (badly inflated while the suite is red, since every spec hit the
waitForMeteor timeout and retried). Add a 2-way shard matrix (chromium/firefox/
webkit × shard 1..2 = 6 jobs); each shard starts its own WeKan + Mongo so there
is no shared-server contention, and runs ~half the specs via --shard=i/2.
Artifact names are suffixed with the shard so the jobs do not collide.

The shard count can be raised once the baseline is green and/or once E2E runs
against a prebuilt bundle (so per-job startup is cheap rather than a full
meteor build each time).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 20:06:46 +03:00
Lauri OjansivuandClaude Opus 4.8 75e713c993 ci(e2e): gate on the rspack client bundle being served as JS, surface build log
The E2E suite was red because the browser could not load the client JS: requests
for the rspack bundle returned the SPA HTML fallback ("Unexpected token '<'"), so
Meteor never initialised and all ~212 specs timed out in waitForMeteor. The
readiness check only curl-tested the server (HTML 200), not that the client
bundle was being served.

The e2e job now waits until http://localhost:3000/__rspack__/client-rspack.js is
served as JavaScript before running tests, and always prints the rspack/build
lines from wekan-run.log so a genuine build failure (vs a slow start) is
diagnosable. If the bundle never serves as JS it fails fast (~10 min) with the
log instead of running 2h40m of doomed specs.

Reverts the globalSetup browser warm-up (the earlier cold-start hypothesis was
wrong — the bundle genuinely is not served, not merely slow); the CI gate is the
right place. Keeps the waitForMeteor 30s -> 60s bump.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 19:56:29 +03:00
Lauri OjansivuandClaude Opus 4.8 5bd1d69813 CHANGELOG: note E2E globalSetup warm-up fix for waitForMeteor timeouts
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 16:03:27 +03:00
Lauri OjansivuandClaude Opus 4.8 b2041133f3 tests(e2e): warm up the app in globalSetup to fix CI waitForMeteor timeouts
The E2E suite was red on main: most specs (and nearly all Firefox/WebKit runs)
failed with "page.waitForFunction: Timeout" in helpers/auth.js — the per-spec
waitForMeteor timed out because the first browser loads of a cold WeKan server
have to compile and serve the large client bundle and start publications, which
exceeds a single spec's timeout. CI's readiness gate only curl-checks the server
(HTML 200), not that the browser can load the Meteor client global.

globalSetup now loads the app in a browser once and waits for the Meteor global
(retrying within a 3-minute budget, best-effort — never fails the run itself), so
every spec starts against a warmed server. Also bump waitForMeteor 30s -> 60s as
a safety net for slower browsers under CI load.

Verified locally: globalSetup logs "WeKan warmed up" and specs still pass; the
cold-start flakiness itself can only be confirmed by a CI E2E run.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 16:03:03 +03:00
Lauri OjansivuandClaude Opus 4.8 deb09c679a CHANGELOG: note #6412 now has a negative-tested Node unit test
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 15:47:02 +03:00
Lauri OjansivuandClaude Opus 4.8 72e10a81b7 Make #6412 filename test negative-testable: extract pure helpers + Node test
The #6412 mocha test imported the helpers from fileStoreStrategy.js, which pulls
in Meteor, so it could only run under `meteor test` (and the local harness loaded
0 server tests here) — meaning it could not be negative-tested locally.

Extract the pure, Meteor-free helpers (truncateFilenameToBytes / sanitizeFilename
/ MAX_FILENAME_BYTES) into models/lib/filenameSanitizer.js; fileStoreStrategy.js
requires them. Add tests/filenameSanitizer.test.cjs (plain Node, `npm run
test:unit:node`) and point the mocha test at the new module. The Node test is
negative-tested: 7 passing on the fix, and the length-cap assertion fails when
the truncation is reverted. Verified `meteor build` still compiles (the helper
is bundled into the server).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 15:46:43 +03:00
Lauri OjansivuandClaude Opus 4.8 97f378ea78 CHANGELOG: record card-from-template crash fix (612ed3e51) + #5798/#3897 tests
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 15:36:35 +03:00
Lauri OjansivuandClaude Opus 4.8 612ed3e51c Fix card-from-template crash ("no current view") and add #5798 regression test
While adding a Playwright test for #5798, found that creating a card from a
template threw "There is no current view" and created no card: in the
searchElement popup's minicard-click handler, tpl.getSortIndex() (which reads
Template.currentData()) ran AFTER `await tpl.board.getNextCardNumber()`, and
Blaze's synchronous current-view context is lost across an await. Compute the
sort index before the await.

With that fixed, the #5798 fix (instantiate into the current board, not the
templates board) is now exercised end-to-end by a new Playwright spec that
seeds a card template and drives the add-card -> template picker flow. The spec
is negative-tested: it passes on the fixed code and fails when the copy target
is reverted to the templates board.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 15:35:45 +03:00
Lauri OjansivuandClaude Opus 4.8 8b13a4dab9 tests: re-add #3897 guest-board spec with correct error capture
The earlier version only captured console type 'error', but Blaze logs a thrown
template helper as an "Exception from Tracker afterFlush" via console.LOG (and a
pageerror). Capturing every console type now reliably catches the
"Cannot read properties of null (reading 'isBoardAdmin')" guest crash.
Negative-tested: passes on the fixed code, fails when the optional-chaining
guards are reverted.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 12:37:11 +03:00
Lauri OjansivuandClaude Opus 4.8 a69e6c3e26 CHANGELOG: note added regression tests (#6412 unit, #3907/#5886/#5892 Playwright)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 12:16:21 +03:00
Lauri OjansivuandClaude Opus 4.8 96b60e2dee tests: drop vacuous #3897 guest-board spec
The #3897 guest public-board test passed even with all isBoardAdmin guards
reverted (verified by negative test), so it does not actually exercise the bug
in the seeded scenario. Removed rather than keep a misleading guard. The #3897
fix (optional chaining) remains in place; the kept specs (#3907, #5886, #5892)
were each negative-tested and do fail on the buggy code.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 12:15:40 +03:00
Lauri OjansivuandClaude Opus 4.8 5709854ed5 tests: add #6412 filename-truncation unit test and #3897 guest-board regression
- Export truncateFilenameToBytes / sanitizeFilename from fileStoreStrategy and
  add server/lib/tests/filenameTruncation.tests.js (#6412): byte-budget
  truncation preserves the extension, never splits a multibyte codepoint, caps
  the on-disk component under 255 bytes, and still strips path traversal.
- Spec 36: a guest opening a public board renders lists with no
  "isBoardAdmin of null" crash (#3897).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 12:09:19 +03:00
dependabot[bot] f188572b70 Bump jquery from 3.7.1 to 4.0.0
Bumps [jquery](https://github.com/jquery/jquery) from 3.7.1 to 4.0.0.
- [Release notes](https://github.com/jquery/jquery/releases)
- [Changelog](https://github.com/jquery/jquery/blob/main/changelog.md)
- [Commits](https://github.com/jquery/jquery/compare/3.7.1...4.0.0)

---
updated-dependencies:
- dependency-name: jquery
  dependency-version: 4.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-22 09:06:11 +00:00
Lauri OjansivuandClaude Opus 4.8 e9e5bbf132 CHANGELOG: record merged dependency PRs (#6416 @swc/helpers, #6418 sinon)
Note the held-back major production bumps (#6417 jquery, #6415 @babel/runtime,
#6414 sab-adapter-amazon-s3) for individual testing.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 12:04:35 +03:00
Lauri Ojansivu 483a773e6d Merge pull request #6418 from wekan/dependabot/npm_and_yarn/sinon-22.0.0
Bump sinon from 21.1.2 to 22.0.0
2026-06-22 12:03:42 +03:00
Lauri Ojansivu 529a01b8f9 Merge pull request #6416 from wekan/dependabot/npm_and_yarn/swc/helpers-0.5.23
Bump @swc/helpers from 0.5.22 to 0.5.23
2026-06-22 12:03:38 +03:00
Lauri OjansivuandClaude Opus 4.8 90c365787c tests: add Playwright regression specs for fixed bugs (#3907, #5886, #5892)
Spec 36 guards three recent fixes:
- #3907 a same-board card move (which re-sets boardId) must keep the card's
  addedLabel activity history (data-loss guard), exercised via a /cards/update
  DDP write that runs the server before.update hook.
- #5886 a persisted card sort is restored into Session after a page reload.
- #5892 a collapsed list with a custom --list-width still shrinks to the rail.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 11:46:30 +03:00
Lauri OjansivuandClaude Opus 4.8 e8fd2c14df CHANGELOG: record Meteor 3.5-rc.2 update (#6413) and rebuild-wekan.sh browser matrix
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 11:41:30 +03:00
dependabot[bot] e8a4dc5da0 Bump sinon from 21.1.2 to 22.0.0
Bumps [sinon](https://github.com/sinonjs/sinon) from 21.1.2 to 22.0.0.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/main/CHANGES.md)
- [Commits](https://github.com/sinonjs/sinon/compare/v21.1.2...v22.0.0)

---
updated-dependencies:
- dependency-name: sinon
  dependency-version: 22.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-22 08:33:56 +00:00
dependabot[bot] 78a0f817b2 Bump @swc/helpers from 0.5.22 to 0.5.23
Bumps [@swc/helpers](https://github.com/swc-project/swc/tree/HEAD/packages/helpers) from 0.5.22 to 0.5.23.
- [Release notes](https://github.com/swc-project/swc/releases)
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG-CORE.md)
- [Commits](https://github.com/swc-project/swc/commits/HEAD/packages/helpers)

---
updated-dependencies:
- dependency-name: "@swc/helpers"
  dependency-version: 0.5.23
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-22 08:33:40 +00:00
Lauri OjansivuandClaude Opus 4.8 e28b3bc219 rebuild-wekan.sh: run Chromium/Firefox/WebKit with or without Docker
Generalize the WebKit-only Docker support so the whole Playwright browser matrix
(chromium, firefox, webkit) can run either natively or inside the official
Playwright Docker image. This lets the full suite run on hosts where some bundled
browsers can't launch natively (e.g. Linux arm64).

- browser_needs_docker <browser> replaces the webkit-only check, resolved via
  WEKAN_PLAYWRIGHT_DOCKER (all), WEKAN_<BROWSER>_DOCKER (per browser), then auto
  (webkit on linux arm64). webkit_needs_docker kept as a back-compat wrapper.
- run_playwright_docker <browser> replaces run_playwright_webkit_docker (kept as
  a wrapper); the single-browser and Run-ALL flows now route any browser through
  Docker when configured.
- New menu item + install_playwright_browsers(): installs native browsers
  (playwright install --with-deps) and/or pulls the Playwright Docker image.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 11:33:27 +03:00
dependabot[bot] fb9380c0d0 Bump @tweedegolf/sab-adapter-amazon-s3 from 1.0.20 to 3.0.4
Bumps [@tweedegolf/sab-adapter-amazon-s3](https://github.com/tweedegolf/storage-abstraction) from 1.0.20 to 3.0.4.
- [Release notes](https://github.com/tweedegolf/storage-abstraction/releases)
- [Changelog](https://github.com/tweedegolf/storage-abstraction/blob/master/changelog.md)
- [Commits](https://github.com/tweedegolf/storage-abstraction/commits/v3.0.4)

---
updated-dependencies:
- dependency-name: "@tweedegolf/sab-adapter-amazon-s3"
  dependency-version: 3.0.4
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-22 08:33:08 +00:00
Lauri Ojansivu d5be28bc2e Merge pull request #6413 from harryadel/update-meteor-3.5-rc.2
Update Meteor to 3.5-rc.2
2026-06-22 11:32:10 +03:00
Lauri OjansivuandClaude Opus 4.8 00546fb6f9 CHANGELOG: #5757 appears resolved; #5808/#5874 need browser repro
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 11:06:23 +03:00
Lauri OjansivuandClaude Opus 4.8 4930b549bd CHANGELOG: record #5798 card-from-template wrong-board fix (097806984)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 11:03:05 +03:00
Lauri OjansivuandClaude Opus 4.8 097806984b Fix card-from-template created on the templates board (#5798)
When instantiating a card template, the new card was copied with tpl.boardId,
which for a template search is the *templates* board (the search source), not
the current board. The card still appeared in the target list (the list renders
cards by listId, and the templates board is subscribed), but it had
boardId = templates board, so clicking it navigated to the templates board
instead of opening the card detail.

Copy the template into the current board instead (the target list/swimlane were
already resolved on the current board), so the new card belongs to the board it
is placed on.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 11:02:47 +03:00
Lauri OjansivuandClaude Opus 4.8 7f4108c591 CHANGELOG: record #5997 list-reorder neighbour-detection fix (1165c9b6d)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 06:03:54 +03:00
Lauri OjansivuandClaude Opus 4.8 1165c9b6db Fix list reorder using wrong neighbours when non-list siblings present (#5997)
saveSorting() computed the new sort from ui.item.prev('.js-list') /
.next('.js-list'), which jQuery only matches when the sibling is *immediately*
adjacent. The lists container also renders the +addListForm composer and, when a
card is open, a +cardDetails element between lists, so an interspersed non-list
sibling made calculateIndex mis-detect the first/last position and compute a
wrong sort. The reordered list then landed somewhere other than where it was
dropped and looked like the new order was not persisted.

Use prevAll/nextAll('.js-list:not(.js-list-composer)').first() so the nearest
actual list neighbour is found regardless of interspersed elements.

Verified out-of-band that the server side persists correctly: a DDP call to
updateListSort reorders the lists collection and the sort:1 query returns the new
order, so the regression was in the client-side neighbour detection.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 06:03:32 +03:00
Lauri OjansivuandClaude Opus 4.8 0abaf03ba0 CHANGELOG: track remaining in-progress issues (#5997 diagnosis, #5798, #5757)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:47:06 +03:00
Lauri OjansivuandClaude Opus 4.8 b30244ab07 CHANGELOG: record #5886 persist card sort across reloads (6aad946bc)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:46:13 +03:00
Lauri OjansivuandClaude Opus 4.8 6aad946bc6 Remember card sort (e.g. by due date) across reloads (#5886)
The card sort was stored only in a Meteor Session variable, which is in-memory
and reset on page reload, so a chosen sort (such as by due date) reverted to the
default. Persist the sort to localStorage when set/reset, restore it into Session
when the board header loads (so the sort icon is correct too), and read it as a
fallback when sorting cards.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:45:56 +03:00
Lauri OjansivuandClaude Opus 4.8 f45019478c CHANGELOG: record #5892 collapsed-list custom-width fix (5e9b2bccd)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:42:45 +03:00
Lauri OjansivuandClaude Opus 4.8 5e9b2bccdd Fix lists not collapsing when they have a custom width (#5892)
The list-width rework (#6409) added a persistent rule
`.list[style*="--list-width"] { width: var(--list-width) !important }`. A
collapsed list keeps its inline --list-width custom property, so that !important
rule overrode `.list.list-collapsed { width: 30px }` and the list stayed full
width when collapsed (most visible with the Modern theme, where custom widths
are in use).

Exclude collapsed lists from the persistent width rule with
:not(.list-collapsed), and mark the 30px collapsed width !important so a custom
per-list width can never keep a collapsed list expanded.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:42:30 +03:00
Lauri OjansivuandClaude Opus 4.8 d076721f2a CHANGELOG: record Stops-Work issue triage (resolved / repro-needed / feature)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:40:08 +03:00
Lauri OjansivuandClaude Opus 4.8 e08b76bbaa CHANGELOG: record data-loss issue triage (repro-needed / resolved / env / feature)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:37:54 +03:00
Lauri OjansivuandClaude Opus 4.8 cc2b5a1452 CHANGELOG: record #3897 guest public-board render crash fix (fc0fe0b61)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:36:20 +03:00
Lauri OjansivuandClaude Opus 4.8 fc0fe0b613 Fix crash rendering public boards as guest (null user isBoardAdmin) (#3897)
Viewing a public board as a guest (no logged-in user) threw
"Cannot read property 'isBoardAdmin' of null" from template helpers that called
ReactiveCache.getCurrentUser().isBoardAdmin() (and .isWorker()). The exception
aborted the Tracker afterFlush computation mid-render, so longer lists never
finished loading for guests.

A null/guest user is never a board admin or worker, so use optional chaining
(getCurrentUser()?.isBoardAdmin()) which yields a falsy value instead of throwing.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:36:04 +03:00
Lauri OjansivuandClaude Opus 4.8 931339ec5c CHANGELOG: record #3907 addedLabel-on-move data-loss fix (6382ad6a8)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:33:32 +03:00
Lauri OjansivuandClaude Opus 4.8 6382ad6a86 Fix addedLabel activity deleted on same-board card move (#3907)
updateActivities() runs in a Cards.before.update hook and removed all
addedLabel activities for a card whenever 'boardId' appeared in the changed
fields. But Card.move() always re-sets boardId (even for a move within the same
board), so every card move deleted the card's label-added history.

Gate the removal/remap on an actual board change by comparing the pre-update
doc.boardId with modifier.$set.boardId. Cross-board moves still clean up / remap
the now-invalid addedLabel activities; same-board moves leave them intact.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:33:13 +03:00
Lauri OjansivuandClaude Opus 4.8 839183cd0f Add Upcoming release section to CHANGELOG, track fixed/in-progress issues
Records #6412 (ENAMETOOLONG, fixed in 5e26cf004) and in-progress #5997/#5892/#5886.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:30:39 +03:00
Lauri OjansivuandClaude Opus 4.8 5e26cf0048 Fix ENAMETOOLONG on very long attachment filenames (#6412)
Attachment filenames were sanitized for path traversal but never length-limited,
so a very long name (made worse by multibyte UTF-8 chars like German umlauts,
2 bytes each) produced an on-disk component "<id>-<version>-<name>" exceeding the
filesystem's 255-byte per-path-component limit. Migrating such files from GridFS
to filesystem storage then failed with ENAMETOOLONG (errno -36).

sanitizeFilename now truncates the name to 200 UTF-8 bytes, measured in bytes
(not characters) and never splitting a multibyte codepoint, while preserving the
file extension. 200 bytes leaves headroom for the "<id>-<version>-" prefix so the
full component stays under 255 bytes. Applied centrally in sanitizeFilename so
every path-construction and lookup site stays consistent.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:08:26 +03:00
Lauri OjansivuandClaude Opus 4.8 7b66884ba3 docs: fix bare wiki-style links to relative paths of existing docs pages
Many docs still used flat GitHub-wiki page-name links like [Backup](Backup),
[OAuth2](OAuth2) or [FAQ](FAQ) that only resolved on the old wiki; in the docs/
hierarchy they were broken. Rewrite them to correct relative paths of the
existing pages (e.g. ](Backup) -> ](Backup.md), ](OAuth2) -> ](../Login/OAuth2.md),
](Sandstorm) -> ](../Platforms/FOSS/Sandstorm/Sandstorm.md)).

Mapping: page name -> docs/<...>/<Name>.md by filename, with explicit handling
for renamed pages (Caddy/Nginx-Webserver-Config, Wekan-Markdown, the Sandstorm
grain export page, Uberspace) and the REST-API-<X> family -> docs/API/<X>.md.
Ambiguous names resolved by preferring a same-directory file or the primary page.
Anchors and markdown titles preserved. 280 links across the docs tree.

Out of scope (left as-is): source-code references (models/*.js etc.) and
[Link](url) placeholders, which are not docs pages.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 21:03:27 +03:00
Harry Adel 83a105f12d Merge branch 'main' into update-meteor-3.5-rc.2 2026-06-21 20:49:16 +03:00
Lauri OjansivuandClaude Opus 4.8 b912ddb6f5 docs: convert internal wiki/repo links from https URLs to relative paths
The GitHub wiki is disabled and its content was migrated into docs/, so every
https://github.com/wekan/wekan/wiki/... link now redirects to the repo home and
is broken. Rewrite all internal links in docs/ to relative paths:

- wiki/<Page> -> relative path to the corresponding docs/ file (renamed pages
  mapped explicitly: Caddy-Webserver-Config->Webserver/Caddy.md, Wekan-Markdown
  ->Features/Markdown/Markdown.md, REST-API-Role->API/Role.md, etc.)
- wiki home -> docs/README.md
- blob|tree|raw/main|master/<path> -> relative path (anchors and #Lxx line
  ranges preserved; bare URLs wrapped as [name](path) so they stay clickable)

Kept absolute (intentionally not flattened to the current ref):
- ref-pinned links (edge, devel, version tags, commit hashes)
- links whose target no longer exists in the tree

wiki/issues -> the GitHub issues tracker URL (external). 436 links across 113
files; verified no wiki links remain and no broken relative links introduced.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 20:43:36 +03:00
Harry Adel 15b2c7160b Update Meteor to 3.5-rc.2 2026-06-21 20:41:30 +03:00
Lauri OjansivuandClaude Opus 4.8 f037a219b6 docs: point LaTeX code comment to repo docs, not the removed wiki
The GitHub wiki is disabled (has_wiki=false) and wiki/LaTeX now redirects to the
repo home; wiki content was moved into docs/. Link the in-repo docs page instead.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 20:30:06 +03:00
Lauri OjansivuandClaude Opus 4.8 32abf5de40 Migrate LaTeX math from MathJax to Temml (native MathML)
Math rendering ($...$ inline, $$...$$ block) was silently dropped in
63ce45c53 during the Meteor 3 refactor; the markdown-it-mathjax3 dependency
was left orphaned in package.json.

Restore it using Temml, which converts LaTeX to native browser MathML, instead
of bundling all of MathJax (which also had a render-twice bug). Wired via the
markdown-it-math@6 no-default-renderer entrypoint, calling temml.renderToString
directly to avoid a top-level await that the Meteor/rspack bundler dislikes.

The emitted MathML is allow-listed in the markdown package's DOMPurify config
(tags + presentation attributes), and MathML elements are exempted from the
"delete element if it has a style attribute" rule so block formulas
(style="display:block math") are not silently removed; style/class/scripts and
annotation-xml stay blocked, so security posture is preserved.

Net dependency change: removes MathJax (9 packages), adds markdown-it-math and
temml (3 packages).

Docs: docs/Features/LaTeX.md

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 20:24:53 +03:00
github-actions[bot] b431a977f5 Bump versions for v9.67 2026-06-21 16:19:04 +00:00
Lauri Ojansivu eb0308e03f Updated ChangeLog. 2026-06-21 19:14:01 +03:00
Lauri OjansivuandClaude Opus 4.8 33fdb4e3a2 rebuild scripts: larger Node heap for dev run, tests and build
Long `meteor run` dev sessions and test runs could crash with
"FATAL ERROR: Ineffective mark-compacts near heap limit - JavaScript heap out
of memory" (the Meteor build tool process hit its ~4 GB default).

rebuild-wekan.sh / rebuild-wekan.bat now set, near the top so every menu option
(dev run, tests, build) inherits them:

- TOOL_NODE_FLAGS=--max-old-space-size=8192  (Meteor command-line/build process)
- NODE_OPTIONS=--max-old-space-size=8192     (child Node/rspack processes)

Both honor an already-exported value, so machines with less RAM can lower it.
The trace-warnings dev option keeps its larger heap too (its inline NODE_OPTIONS
now includes --max-old-space-size=8192).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 19:06:28 +03:00
Lauri OjansivuandClaude Opus 4.8 c1c8535544 Translate remaining English list-width strings in fi.i18n.json to Finnish
The 8 list-width strings (#6409) added recently were still English in the
Finnish locale. Translated them using the existing Finnish terminology
("Aseta", "Listan leveys (pikseliä)", "...täytyy olla kokonaisluku",
"taulun jäsenet", "Henkilökohtaiset"). The other identical-to-English values
are placeholders, proper nouns (Gantt, LDAP, S3, ...), single-letter search
operator abbreviations, and "OK"/"magenta", which are intentionally kept.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 19:00:28 +03:00
Lauri Ojansivu c1f2a83680 Updated translations. 2026-06-21 18:55:52 +03:00
Lauri OjansivuandClaude Opus 4.8 ff582697f3 Add auto-width back, scoped per-board or per-user (#6409)
Re-introduces the "fit lists to content" auto-width mode that the width rework
removed, now following the same Shared/Personal scope as fixed widths:

- Shared mode (allowsPersonalListWidth=false): auto-width is a per-board setting
  (board.autoWidth), the same for everyone; togglable by members with write
  access (server method setBoardAutoWidth, gated on board membership like
  applyListWidth).
- Personal mode: auto-width is per-user (the existing profile.autoWidthBoards).

- models/boards.js: add `autoWidth` field + getter/setter.
- server/models/users.js: add setBoardAutoWidth method.
- client list.js: effectiveAutoWidth(); autoWidth() helper; canResizeList()
  returns false in auto mode.
- list.jade: add `list-auto-width` class and omit `--list-width` when auto, so
  CSS fits the list to content and hides the resize handle.
- listHeader popup: re-add the Auto list width toggle (writes to board or
  profile depending on scope; shown only to those who may change it).
- wekanCreator: carry board.autoWidth through import.
- docs + CHANGELOG.

Verified live: shared auto-width applies to all members (class set, no
--list-width, handle hidden); personal auto-width is per-user (one member auto,
the other keeps a fixed width + handle).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 18:49:47 +03:00
Lauri OjansivuandClaude Opus 4.8 b477b1383d Rework list widths: single width, Shared/Personal board scope (#6409)
List widths were confusing (per-list "min width / max width / automatic") and
unreliable (drag changes lost on reload; the popup wrote the shared lists.width
while drag wrote per-user profile, and rendering read the per-user one as a
floating min/max). The width also reverted to `auto` on reload because the
render set min/max-width but never the `--list-width` CSS variable the styles
actually use (with !important).

Now a list has ONE width, driven by `--list-width`, that persists across
reloads, with a board setting choosing the scope:

- Shared (default): width stored in lists.width, same for everyone; only members
  with write access can change it (read-only/comment-only no longer see the
  resize handle). Board setting `allowsPersonalListWidth` (default false).
- Personal: each user keeps their own width (profile, or localStorage when not
  logged in), falling back to the shared width then the default (272).

Changes:
- models/boards.js: add `allowsPersonalListWidth` + getter/setter.
- server/models/users.js: applyListWidth sets only `width` (constraint ignored).
- client list.js: single effectiveListWidth precedence, mode-aware saveListWidth,
  resize handle gated on canResizeList; removed auto-width/min-max code.
- list.jade: render `--list-width` (the variable the CSS uses), show resize
  handle only when allowed.
- listHeader popup: single width value; removed min/max + auto-width toggle.
- sidebar: board "Personal list widths" toggle + i18n.
- Import/export: exporter already carries lists.width + the board setting;
  wekanCreator now preserves list width/color/collapsed and the board's
  list-width scope (it previously dropped them).
- docs/Features/Lists/Lists.md: document the model.

Verified live: shared width renders + persists on reload and is identical for
two members; personal mode gives per-user overrides with shared fallback;
drag-resize saves to lists.width in shared mode.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 18:40:51 +03:00
Lauri Ojansivu 278ee0b018 Updated translations. 2026-06-21 18:00:15 +03:00
Lauri OjansivuandClaude Opus 4.8 4c985dc82c rebuild scripts option 2: also clear rspack caches (_build, node_modules/.cache)
The "Build WeKan" menu option (option 2) in rebuild-wekan.sh / rebuild-wekan.bat
removed node_modules, .meteor/local and .build, but not the rspack dev-build
caches (_build and node_modules/.cache). After a git checkout/merge those caches
could serve stale compiled modules on the next `meteor run`. Option 2 now clears
them too, so a rebuild always recompiles from scratch.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 17:26:47 +03:00
Lauri OjansivuandClaude Opus 4.8 2c0602434a Fix #6411: editing 2nd/3rd org or team no longer shows the first one
On Admin Panel › People (/people), clicking Edit on any organization or team
filled the form with the FIRST one's values, so the others could never be
edited. The edit/settings popups are opened from the row with data context
`{ org }` / `{ team }`, but their helpers read `this.orgId` / `this.teamId`
(undefined in that context) and called `getOrg(undefined)` / `getTeam(undefined)`,
which `Org.findOne({})` / `Team.findOne({})` resolve to the first document.

- editOrgPopup / editTeamPopup helpers now resolve the clicked id from the
  `{ org }` / `{ team }` context: `(this.org && this.org._id) || this.orgId`.
- The save (submit) handlers use the same context org/team.
- The settingsOrg / settingsTeam delete handlers derive the id the same way
  (the old code called Org.remove(undefined) / Team.remove(undefined)).

Verified against a running instance: each organization and team now edits its
own values (fresh popup per row).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 17:17:22 +03:00
Lauri Ojansivu f00cb83d40 Merge pull request #6408 from wekan/fix/5462-readonly-list-sort-403
Fix #5462: read-only members no longer trigger 403 Access denied when reordering lists
2026-06-21 16:45:19 +03:00
Lauri OjansivuandClaude Opus 4.8 28dde530d9 Add merged-PR links (#6408, #6410) to CHANGELOG upcoming entries
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 16:45:05 +03:00
Lauri Ojansivu b52b07c898 Merge remote-tracking branch 'origin/main' into fix/5462-readonly-list-sort-403 2026-06-21 16:43:56 +03:00
Lauri Ojansivu f75da28fbf Merge pull request #6410 from wekan/fix/bson-getbuiltinmodule-client-crash
Fix client bundle crash (bson getBuiltinModule) that blanked all boards
2026-06-21 16:43:43 +03:00
Lauri OjansivuandClaude Opus 4.8 1d4cfd332d Fix client bundle crash (bson getBuiltinModule) that blanked all boards
After the mongodb/bson 7.3.0 bump, opening any board rendered nothing. bson 7.x
evaluates, at module-load time:

    const { startupSnapshot } = globalThis?.process?.getBuiltinModule('v8') ?? {};

The optional chaining stops before the call, so in the browser (partial
`process` polyfill, no getBuiltinModule) it throws
`TypeError: getBuiltinModule is not a function` while evaluating
client/components/cards/attachments.js (`import { ObjectId } from 'bson'`). That
aborts the client bundle bootstrap partway through client/imports.js, so every
feature imported after it (notifications, swimlanes, rules, ...) is never
registered and the board view dies with `No such template: notifications`.

- Add client/lib/bsonBrowserShim.js (imported first in client/main.js) that
  installs a no-op process.getBuiltinModule in the browser, so bson takes its
  intended `?? {}` fallback (there is no V8 startup snapshot in a browser).
- Add unit tests (client/lib/tests/bsonBrowserShim.tests.js), 6 cases.
- Harden the #5686 Playwright spec (specs/34) to actually exercise the gesture
  now that boards render: select real checklist text and fire the real outside
  click; DOM-aware "outside the card" point for the control case.
- Update CHANGELOG upcoming.

Verified against a running instance: boards render again, Template.notifications
is registered, specs 34 and 35 pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 12:41:07 +03:00
Lauri OjansivuandClaude Opus 4.8 8896bee857 Fix #5462: read-only members no longer trigger 403 when reordering lists
Read-only / comment-only board members could still drag-reorder lists because
one of the three jQuery-UI list sortables in swimlanes.js was not gated on
Utils.canModifyBoard() (the other two already were). The drag fired a server
write that allow/deny rejected with `403 Access denied` (reason: 'Access
denied'), so the list snapped back and the console showed the error — matching
the #5462 report.

- Add the missing `disabled: !Utils.canModifyBoard()` to the third sortable,
  consistent with the other two.
- Add a defense-in-depth guard at the top of saveSorting() so a logged-in user
  without write access can never persist a reorder; anonymous public-board
  reordering via localStorage is unaffected.
- Add a Playwright regression spec (specs/35-list-sort-permissions.e2e.js) that
  verifies over DDP: a read-only member is denied via both updateListSort and a
  direct collection write (the exact 403), the stored order is unchanged, and a
  write-access member's reorder persists (also guards #5997 persistence).
- Update CHANGELOG upcoming.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 08:48:59 +03:00
Lauri Ojansivu ae09279c46 Merge pull request #6407 from wekan/fix/5686-checklist-text-selection-closes-card
Fix #5686: selecting text in a checklist no longer closes the card
2026-06-21 08:29:25 +03:00
Lauri Ojansivu 5b7038ae62 Merge remote-tracking branch 'origin/main' into fix/5686-checklist-text-selection-closes-card
# Conflicts:
#	CHANGELOG.md
2026-06-21 08:29:00 +03:00
Lauri Ojansivu b2e5aae916 Merge pull request #6406 from wekan/fix/5804-rest-invalid-request-400
Fix #5804: REST API returns HTTP 400/404 instead of 500 for invalid requests
2026-06-21 08:25:08 +03:00
Lauri Ojansivu 64c9feb63c Merge pull request #6405 from wekan/dependabot/npm_and_yarn/azure/storage-blob-12.32.0
Bump @azure/storage-blob from 12.31.0 to 12.32.0
2026-06-21 08:24:47 +03:00
Lauri Ojansivu abe52cffb7 Merge pull request #6404 from wekan/dependabot/npm_and_yarn/mongodb-7.3.0
Bump mongodb from 6.21.0 to 7.3.0
2026-06-21 08:24:32 +03:00
Lauri Ojansivu 6d35b3f85f Merge pull request #6403 from wekan/dependabot/npm_and_yarn/papaparse-5.5.4
Bump papaparse from 5.5.3 to 5.5.4
2026-06-21 08:24:13 +03:00
Lauri Ojansivu 256c780cd1 Merge pull request #6402 from wekan/dependabot/npm_and_yarn/tweedegolf/sab-adapter-azure-blob-3.0.2
Bump @tweedegolf/sab-adapter-azure-blob from 1.0.9 to 3.0.2
2026-06-21 08:23:56 +03:00
Lauri Ojansivu a0fedd8ece Merge pull request #6401 from wekan/dependabot/npm_and_yarn/bson-7.3.0
Bump bson from 7.2.0 to 7.3.0
2026-06-21 08:23:11 +03:00
Lauri Ojansivu 8211d75b46 Merge pull request #6400 from wekan/dependabot/github_actions/docker/setup-qemu-action-4
Bump docker/setup-qemu-action from 3 to 4
2026-06-21 08:22:53 +03:00
Lauri Ojansivu 67932de3dc Merge pull request #6399 from wekan/dependabot/github_actions/actions/checkout-7
Bump actions/checkout from 6 to 7
2026-06-21 08:22:28 +03:00
Lauri OjansivuandClaude Opus 4.8 b4dec11775 Fix #5686: selecting text in a checklist no longer closes the card
Selecting the text of a checklist item and releasing the mouse outside the
card detail pane closed the card. The checklist items template stops mousedown
propagation (for item sorting), so the existing cardDetailsIsDragging guard
never engaged and the document-level "click outside to close" handler closed
the card.

- Add a propagation-independent guard (client/lib/cardCloseGuard.js):
  isTextSelectionInsideCard() keeps the card open when a live, non-collapsed
  text selection is anchored inside the card pane. A deliberate click on empty
  board space collapses the selection outside the card first, so it still
  closes the card.
- Wire the guard into the detailsPane EscapeActions close handler in
  cardDetails.js.
- Add 8 unit tests (client/lib/tests/cardCloseGuard.tests.js) and a Playwright
  regression spec (tests/playwright/specs/34-checklist-text-selection.e2e.js).
- Update CHANGELOG upcoming.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 07:43:28 +03:00
Lauri OjansivuandClaude Opus 4.8 fa2cb91694 Fix #5804: REST API returns HTTP 400/404 instead of 500 for invalid requests
Posting a comment without the required `comment` parameter (or to a board
that does not exist) returned an HTTP 500 error page. The schema-validation
error thrown on insert is a circular object (SimpleSchemaValidationContext ->
SimpleSchema -> ...), and serializing it crashed the response writer with
"Converting circular structure to JSON".

- Add Meteor-free helpers (server/lib/apiResponseHelpers.js): safeJsonStringify
  (crash-proof, falls back to {error} on circular structures), httpStatusForError
  (maps to 401/403/404/500), validateCommentBody, extractErrorMessage.
- sendJsonResult now serializes via safeJsonStringify so a non-serializable
  payload can no longer crash into a 500.
- checkBoardAccess/checkBoardWriteAccess/checkBoardAdmin throw a 404 instead of
  a TypeError on board.members when the board does not exist.
- POST comment validates input (400 when comment missing); REST comment catch
  blocks return the real status code instead of 200.
- Add 18 unit tests (server/lib/tests/apiResponseHelpers.tests.js).
- Update CHANGELOG upcoming.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 07:32:42 +03:00
dependabot[bot] f4b83a9624 Bump @azure/storage-blob from 12.31.0 to 12.32.0
Bumps [@azure/storage-blob](https://github.com/Azure/azure-sdk-for-js/tree/HEAD/sdk/storage/storage-blob) from 12.31.0 to 12.32.0.
- [Release notes](https://github.com/Azure/azure-sdk-for-js/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/storage/storage-blob/CHANGELOG.md)
- [Commits](https://github.com/Azure/azure-sdk-for-js/commits/@azure/storage-blob_12.32.0/sdk/storage/storage-blob)

---
updated-dependencies:
- dependency-name: "@azure/storage-blob"
  dependency-version: 12.32.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-20 20:33:09 +00:00
dependabot[bot] c3a15d13b6 Bump mongodb from 6.21.0 to 7.3.0
Bumps [mongodb](https://github.com/mongodb/node-mongodb-native) from 6.21.0 to 7.3.0.
- [Release notes](https://github.com/mongodb/node-mongodb-native/releases)
- [Changelog](https://github.com/mongodb/node-mongodb-native/blob/main/HISTORY.md)
- [Commits](https://github.com/mongodb/node-mongodb-native/compare/v6.21.0...v7.3.0)

---
updated-dependencies:
- dependency-name: mongodb
  dependency-version: 7.3.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-20 20:32:56 +00:00
dependabot[bot] a97e8de99d Bump papaparse from 5.5.3 to 5.5.4
Bumps [papaparse](https://github.com/mholt/PapaParse) from 5.5.3 to 5.5.4.
- [Release notes](https://github.com/mholt/PapaParse/releases)
- [Changelog](https://github.com/mholt/PapaParse/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mholt/PapaParse/compare/5.5.3...5.5.4)

---
updated-dependencies:
- dependency-name: papaparse
  dependency-version: 5.5.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-20 20:32:45 +00:00
dependabot[bot] e7a8d5bec5 Bump @tweedegolf/sab-adapter-azure-blob from 1.0.9 to 3.0.2
Bumps [@tweedegolf/sab-adapter-azure-blob](https://github.com/tweedegolf/storage-abstraction) from 1.0.9 to 3.0.2.
- [Release notes](https://github.com/tweedegolf/storage-abstraction/releases)
- [Changelog](https://github.com/tweedegolf/storage-abstraction/blob/master/changelog.md)
- [Commits](https://github.com/tweedegolf/storage-abstraction/commits)

---
updated-dependencies:
- dependency-name: "@tweedegolf/sab-adapter-azure-blob"
  dependency-version: 3.0.2
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-20 20:32:38 +00:00
dependabot[bot] b6efc42957 Bump bson from 7.2.0 to 7.3.0
Bumps [bson](https://github.com/mongodb/js-bson) from 7.2.0 to 7.3.0.
- [Release notes](https://github.com/mongodb/js-bson/releases)
- [Changelog](https://github.com/mongodb/js-bson/blob/main/HISTORY.md)
- [Commits](https://github.com/mongodb/js-bson/compare/v7.2.0...v7.3.0)

---
updated-dependencies:
- dependency-name: bson
  dependency-version: 7.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-20 20:32:27 +00:00
dependabot[bot] 092cd707b5 Bump docker/setup-qemu-action from 3 to 4
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 3 to 4.
- [Release notes](https://github.com/docker/setup-qemu-action/releases)
- [Commits](https://github.com/docker/setup-qemu-action/compare/v3...v4)

---
updated-dependencies:
- dependency-name: docker/setup-qemu-action
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-20 20:32:15 +00:00
dependabot[bot] 675207b599 Bump actions/checkout from 6 to 7
Bumps [actions/checkout](https://github.com/actions/checkout) from 6 to 7.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v6...v7)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-20 20:32:10 +00:00
github-actions[bot] 1b6e828189 Bump versions for v9.65 2026-06-20 18:30:32 +00:00
Lauri Ojansivu 4ecd9e0cd0 Updated ChangeLog. 2026-06-20 21:26:06 +03:00
Lauri OjansivuandClaude Opus 4.8 b4bbf2480a Add ICS import REST API + OpenAPI + api.py example (#6323)
Expose the iCalendar (.ics) import as a REST endpoint
POST /api/boards/:boardId/swimlanes/:swimlaneId/lists/:listId/ics (body { ics })
that reuses the shared import logic, requires board write access, and returns
{ created, cardIds }. Document it in the OpenAPI spec (openapi/extra_paths.yml,
spliced into public/api/wekan.yml) and add an 'importics' example command to
api.py. Note the new endpoint in the ChangeLog.

Note: OAUTH2_LOGOUT_ENDPOINT (the only new env var in the Upcoming changelog) is
already present in all deployment configs (Dockerfile, docker-compose.yml,
snap-src/bin/config, start-wekan.sh/.bat); rebuild-wekan.sh/.bat are dev-run
scripts with no OAUTH2 section, so nothing was added there.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 20:58:36 +03:00
Lauri OjansivuandClaude Opus 4.8 d33d8370c0 Update docs for upcoming-release features
Document the new features from the Upcoming changelog: subtask status + subtask
creation/landing-list/view/circular fixes (Subtasks.md); org/team board-member
restriction, per-user announcement dismissal and per-board comment-editing
restriction (Admin-Panel.md, Members.md); due-date colour coding + due-date change
count (Due-Date.md); Calendar respecting the start day of week (Day-of-week-start.md);
drag-and-drop from search results (Drag-Drop.md). Comment replies/restriction and
ICS import already have dedicated docs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 20:50:14 +03:00
Lauri OjansivuandClaude Opus 4.8 cb5499f660 Translate remaining English strings in fi.i18n.json to Finnish
Translate the four delete-activity strings (act-deleteCard, act-removeBoard,
act-removeList, act-removeSwimlane) to Finnish, matching existing act-* activity
terminology (poistettu <noun> ... listalla/uimaradalla/taululla __...__).
Placeholders and product/storage names are left unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 20:44:10 +03:00
Lauri Ojansivu 10c98ea9fb Updated translations. 2026-06-20 20:41:47 +03:00
Lauri OjansivuandClaude Opus 4.8 c092b6d7ca Updated ChangeLog: link Upcoming bullet descriptions directly to commits
Change the Upcoming bullets from [description](issue) ([commit](commit)) to just
[description](commit), so each description links to its fix commit and the
redundant separate commit link is removed. Inline secondary issue references
(also #NNNN) are kept as issue links.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 20:38:35 +03:00
Lauri OjansivuandClaude Opus 4.8 c8a54aa009 Updated ChangeLog: subtask + webhook bug fixes; register tests; add delete-activity i18n keys
Add Upcoming 'fixes the following bugs' bullets (with commit links) for the
subtask fixes (#3868/#5788/#2256/#4782, #4037/#3562, #3328, #3414/#3876/#4849/#4947,
#3743) and webhook fixes (#1587/#2950, #1402), register their unit tests, and add
the act-deleteCard / act-removeBoard / act-removeList / act-removeSwimlane i18n
keys so the delete activities render in the feed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:56:09 +03:00
Lauri OjansivuandClaude Opus 4.8 c5cdc7b659 Fix #3743: subtask 'View it' opens the subtask instead of the parent card
The subtask 'View it' action navigated using the current/parent card; it now
derives the navigation target (boardId/slug/cardId) exclusively from the subtask
via a pure subtaskNavTarget helper (resolving linked subtask cards through
getRealId), reusing the existing not-yet-loaded-board guard.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:54:54 +03:00
Lauri OjansivuandClaude Opus 4.8 4b27313c72 Fix #3868, #5788, #2256, #4782, #4037, #3562, #3328: subtask creation
Subtask creation is now server-authoritative via a new addSubtaskCard Meteor
method: the default subtasks board/list/swimlane are resolved (and lazily created
exactly once) on the server, and client-side auto-creation in
getDefaultSubtasksBoardId/getDefaultSubtasksListId is guarded to Meteor.isServer.
This stops the client from creating duplicate subtasks boards/swimlanes/columns
(#3868/#5788/#2256) and lets multiple subtasks be created reliably (#4782). The
method applies the destination board's automatic custom fields to the new
subtask (#4037/#3562). The circular-parent guard now compares ids by value
(includes()) instead of array indices, and setParentId refuses a cyclic
re-parent (#3328). Pure helpers (wouldCreateCycle, subtaskCustomFields) moved to
isomorphic /imports/lib so the client bundle no longer imports a server module.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:54:54 +03:00
Lauri OjansivuandClaude Opus 4.8 7bb7540ba2 Fix #1587: deleting a card fires the outgoing webhook
Deleting a card created no Activity (only archiving did), so the
Activities.after.insert outgoing-webhook hook never fired on real deletion.
Added a deleteCard Activity in the Cards before.remove hook and in the two REST
card-delete endpoints (which use Cards.direct.removeAsync and bypass the hook),
so an outgoing webhook is now sent on card deletion, consistent with other
events. (#2950: board/list/swimlane deletion already emit removeBoard/removeList/
removeSwimlane activities, so those webhooks were already present.)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:54:30 +03:00
Lauri OjansivuandClaude Opus 4.8 774289f926 Fix #3414, #3876, #4849, #4947: board Subtasks landing-list setting
The board Subtasks settings popup compared the selected list against
subtasksDefaultBoardId instead of subtasksDefaultListId (so the saved list was
never highlighted and looked unsaved/wrong), and listed the current board's
lists rather than the configured deposit board's. The dropdown now reads the
deposit board's lists and matches the stored subtasksDefaultListId, and changing
the deposit board resets the stale list id. resolveSubtaskLanding helper tested.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:54:30 +03:00
Lauri OjansivuandClaude Opus 4.8 8863ec24a7 Fix #1402: outgoing webhook no longer blocks setting card members
Setting a card member creates an Activity, and the Activities.after.insert hook
delivered the outgoing webhook in a way that could throw (e.g. unreachable/slow
endpoint) and unwind the async hook, aborting the member update. Webhook delivery
is now fire-and-forget and wrapped in safeDeliver(), which catches and logs any
error and never rejects, so a failing webhook can't break the member operation.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:54:30 +03:00
Lauri OjansivuandClaude Opus 4.8 d4ee63eb15 Updated ChangeLog: 12 more open-Bug fixes; register tests; fix #3265 language test
Add Upcoming 'fixes the following bugs' bullets (with commit links) for the latest
batch of open Bug fixes (#3289/#4172/#5457, #5398/#5399/#5537/#5546, #5408, #5382,
#5582, #5330, #2091), register their unit tests in the loaders, and rewrite the
#3265 Latvian-language regression test to import the languages module directly
(the previous fs.readFileSync approach failed in the Meteor test bundle). Latvian
native name 'Latviešu valoda' was already correct, so #3265 needed no code change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:20:22 +03:00
Lauri OjansivuandClaude Opus 4.8 98315c26cd Fix #2091: custom number field shows NaN when cleared after being set
A number-type Custom Field rendered the literal 'NaN' once its value was cleared.
The submit handler now stores '' instead of NaN for empty input, and a shared
formatNumberValue helper normalizes empty/null/non-numeric values to an empty
string for display. Helper unit-tested.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:17:01 +03:00
Lauri OjansivuandClaude Opus 4.8 6f85433222 Fix #5382: setting a list/swimlane colour to silver saved it as None
Lists.setColor / Swimlanes.setColor wrote the raw picker value with no normalization,
so an offered-but-unhandled colour fell back to None. Added a shared canonical
allowed-colour helper (normalizeListColor / ALLOWED_LIST_COLORS, including silver)
used by both setters: valid colours (incl. silver) pass through, unknown/empty
normalize to None (null). Removed leftover debug console.log in listHeader.js.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:17:01 +03:00
Lauri OjansivuandClaude Opus 4.8 e98aae278b Fix #5408: per-checklist 'Hide checked items' toggle direction and scope
The 'Hide checked items' state is now read per checklist (from that checklist's own
hideCheckedChecklistItems field) and an item is hidden exactly when it is checked
and that checklist's toggle is on — so toggling one checklist no longer affects the
others and the direction is no longer inverted. Pure isItemHidden helper unit-tested.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:17:01 +03:00
Lauri OjansivuandClaude Opus 4.8 3ce75dd87b Fix #3289, #4172, #5457: Enter selects @mention instead of closing the card
When the @mention autocomplete dropdown is open in the comment/description/minicard
editor, pressing Enter to pick a highlighted user submitted the comment and closed
the card instead of selecting the mention. Hardened the shared textcomplete keydown
guard (createEscapeableTextComplete) to preventDefault + stopImmediatePropagation
while the dropdown is open, so Enter is consumed by the suggestion selection only.
Pure shouldSubmitOnEnter helper unit-tested.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:17:00 +03:00
Lauri OjansivuandClaude Opus 4.8 39e12035e5 Fix #5398, #5399, #5537, #5546: REST card API move/sort/date/archive bugs
- #5398: consolidate duplicated/inconsistent board-move variable names in the card
  edit handler into one normalized set (normalizeMoveParams); API contract unchanged.
- #5399: moving a card to another list via the API now places it on TOP of the
  destination list (computeTopSort), matching the Move Card dialog, instead of a
  random sort position.
- #5537: due/received/start/end dates set via the API now persist — the ISO string
  is parsed to a real Date (parseCardDate) instead of being stripped by schema cleaning.
- #5546: the single-card GET returns archived cards (for inspection) and PUT
  archive=false no longer requires a list_id the caller cannot obtain.
Pure helpers (normalizeMoveParams/computeTopSort/parseCardDate) are unit-tested.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:17:00 +03:00
Lauri OjansivuandClaude Opus 4.8 f819054bb1 Fix #5582: hide internal caret ^board^ helper boards from lists and API
Internal Subtasks-style boards with caret-wrapped titles (e.g. `^Subtasks^`) and
non-`board` types (`list`/`template`) leaked into user-facing board lists and the
REST API (/api/users/:userId/boards, /api/boards). Added a shared pure filter
(server/lib/boardListFilter.js) excluding caret-wrapped titles and non-board
types, applied to those REST endpoints, and added caret exclusion to the
Boards.userBoards model helper, consistent with the already-filtered board-list UI.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:16:35 +03:00
Lauri OjansivuandClaude Opus 4.8 beac9e3d71 Fix #5330: remove a deleted (non-existent) user from a board's members
Board.removeMember only deactivated a member by array index and never pulled the
entry, so a member whose user account was deleted lingered forever and could not
be removed (also breaking @mentions). removeMember now hard-removes the entry by
userId when the Users document no longer exists, via the new pure pullMemberById
helper. Permission checks and existing-user deactivate/keep-last-admin behaviour
unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 19:16:35 +03:00
Lauri OjansivuandClaude Opus 4.8 b7aa85956e Translate remaining English strings in fi.i18n.json to Finnish
Translate the 8 strings that were still English (comment replies/edit restriction,
due-date change count, org/team member restriction, changed-title activity),
matching existing Finnish terminology (Taulu, Kommentti, Organisaatio, Tiimi,
eräpäivä, and the 'muokkasi …ksi %s / %s' activity pattern). Acronyms, symbols,
numbers and product/storage names are intentionally left unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 18:36:02 +03:00
Lauri Ojansivu 0bc0f186ed Updated translations. 2026-06-20 18:32:00 +03:00
Lauri OjansivuandClaude Opus 4.8 c25489858a Updated ChangeLog: regroup Upcoming into updates / new features / bug fixes
Reorganize the Upcoming section into three non-duplicated groups using the
correct category per commit: 'This release adds the following updates:' (issue
triage, label audit, 23 new labels), 'and adds the following new features:'
(the MVP features), and 'and fixes the following bugs:' (all bug fixes merged
into a single list, including the OAuth2 logout fix and the triage-verified
fixes).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 18:26:53 +03:00
Lauri OjansivuandClaude Opus 4.8 b3d7c99616 Updated ChangeLog: add 23 missing GitHub labels for documented login types and features
Auditing docs/Login and docs/Features against the issue labels surfaced documented
login methods (ADFS, Azure, B2C, Google, Header-Login, Nextcloud, Oracle, Zitadel,
Autologin, Accounts-Lockout, Forgot-Password) and features (LaTeX, Mermaid-Diagram,
Emoji, Python, Cards:Cover, Cards:Location, Custom-Logo, RTL, Members, Multitenancy,
Allow-private-boards-only) plus the Apache reverse-proxy platform that had no label.
Created them matching the existing style/colors and listed them in the upcoming
ChangeLog.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 18:00:11 +03:00
Lauri OjansivuandClaude Opus 4.8 13db138313 Updated ChangeLog: 11 triage-verified bug fixes for upcoming release
Add Upcoming changelog bullets (with per-fix commit links) for the bugs found
still-present during Bug-issue triage and now fixed (#2970 #5364 #4561 #5810
#4762 #5188 #5623 #5158 #5521 #5504 #3619), register their unit tests in the
loaders, and add the activity-changedTitle i18n key.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 17:51:23 +03:00
Lauri OjansivuandClaude Opus 4.8 9aa97ab8ff Fix #3619: updating a card title fires the outgoing webhook
Title changes did not create an activity, so no outgoing webhook fired (unlike
description/dueAt changes). Log an a-changedTitle activity in the Cards
before.update hook, mirroring the timing-field activities, so the existing
Activities.after.insert webhook hook fires. Pure titleChanged helper + tests.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 17:47:56 +03:00
Lauri OjansivuandClaude Opus 4.8 2ba8882d88 Fix #5504: deleted-attachment notification credits the deleter
The deleteAttachment activity used fileObj.userId (the uploader) instead of the
user who deleted the attachment, so notifications/history named the wrong person.
Record the acting user (Meteor.userId()) for the delete activity, falling back to
the uploader for server/system removals. Upload activity is unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 17:45:43 +03:00
Lauri OjansivuandClaude Opus 4.8 7eec78c040 Fix #5521: Calendar View respects the start-day-of-week setting
The FullCalendar config never set firstDay, so it used the locale default and
ignored the user's start-of-week preference. Derive firstDay from
getStartDayOfWeek() (0=Sun..6=Sat, same convention as FullCalendar). Pure
toFullCalendarFirstDay helper + tests.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 17:45:43 +03:00
Lauri OjansivuandClaude Opus 4.8 9643dcded9 Fix #5158: copying a swimlane to another board preserves labels
Swimlane copy() remapped card labels by name but never created labels missing on
the destination board, so those assignments were silently dropped. Pre-create
missing destination labels (preserving color) before the per-card copy, so the
by-name remap matches. Pure remapLabelIds helper + tests.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 17:45:43 +03:00
Lauri OjansivuandClaude Opus 4.8 300a9751e6 Fix #5623: 'select all in list' stays within its own swimlane
allCards() filtered by listId only, so list select-all selected cards across all
swimlanes of the list. Add an optional swimlaneId scope (used in swimlanes view)
so select-all is contained to the current swimlane; list-wide behavior is
preserved when there is no swimlane context. Orphan cards remain selectable.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 17:45:43 +03:00
Lauri OjansivuandClaude Opus 4.8 da7c06ec61 Fix #5188: 'When a card is moved to Archive' rule trigger can be activated
The board-triggers JS listened on js-add-arc-trigger while the jade emits
js-add-arch-trigger, so the click handler never fired and the archive trigger
could not be added. Align the JS selector to the jade's class. Added a regression
test asserting every jade trigger class has a matching JS handler.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 17:45:43 +03:00
Lauri OjansivuandClaude Opus 4.8 45bd7dcc85 Fix #4762: subtask board accessible without reload
The js-view-subtask handler dereferenced board._id when the subtask's board was
not yet in ReactiveCache, so navigation failed until a reload. Guard against a
not-yet-loaded board, mirroring the sibling js-go-to-subtask-board handler.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 17:45:43 +03:00
Lauri OjansivuandClaude Opus 4.8 aa412b2a1e Fix #5810: comment-only members can no longer archive cards
The .js-archive handler in cardDetails.js lacked the Utils.canModifyCard() guard
that every other mutating card action has, so a comment-only member could trigger
archiving in the UI (the server allow-rule already rejected the write, so this
closes the client-side UX gap). Guard added via pure canArchiveCard helper.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 17:45:43 +03:00
Lauri OjansivuandClaude Opus 4.8 09e9c993e2 Fix #4561: deleting a date on a linked card updates the real card
unsetReceived/unsetStart/unsetDue/unsetEnd used this._id instead of the linked
card's real id, so clearing a due/received/start/end date on a linked card
targeted the link placeholder. Resolve the id via getRealId() consistently with
the set* methods. For normal cards getRealId()===_id so behavior is unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 17:45:11 +03:00
Lauri OjansivuandClaude Opus 4.8 a0e7017088 Fix #5364: copying a card now clones its cover (show as thumb)
card.copy() copied attachments with new ids but never remapped coverId, so the
cover was lost on the copy. Build an old->new attachment id map (via the copied
attachments' meta.copyFrom) and remap coverId to the new attachment; drop a
stale coverId that cannot be remapped. Helper remapCoverId + tests landed in
the #2970 commit.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 17:45:11 +03:00
Lauri OjansivuandClaude Opus 4.8 d26d117e32 Fix #2970: copying a card no longer selects all/unnamed labels on destination
Cards.copy() remapped labels by name without the unnamed-label guard that
Cards.move() has, so unnamed destination labels were all wrongly selected; it
also wrote the remapped labels onto a throwaway cardData copy instead of the
inserted document. Apply the move()-style guard via shared filterCopiedLabelIds
and persist onto the inserted card. Pure helpers + tests in
server/lib/cardCopyHelpers.js and server/lib/tests/cardsCopyDueFixes.tests.js
(which also cover #4561 and #5364, committed next).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 17:44:51 +03:00
Lauri OjansivuandClaude Opus 4.8 780fdd9187 Updated ChangeLog: 20 issue fixes/features for upcoming release
Add the Upcoming changelog bullets (with per-fix commit links), the new English
i18n keys, and register the new unit test files in the test loaders. Covers
#6000 #5965 #5999 #5930 #5942 #5902 #6018 #5982 #5910 #6142 #6135 #5905 (fixes)
and #5907 #5906 #6091 #6034 #6051 #6081 #6116 #6323 (features).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:42:05 +03:00
Lauri OjansivuandClaude Opus 4.8 0a43d8ac3c Add #6323: import Google Calendar .ics files into board cards (MVP)
New dependency-free iCalendar parser (server/lib/icsImport.js) maps each VEVENT
to a card with startAt/dueAt so events show on Calendar/Gantt views, plus an
importIcsToBoard Meteor method. Import-only; two-way Google Calendar sync is not
included. Parser unit tested (folded lines, escaping, all-day vs date-time, etc.).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:40:13 +03:00
Lauri OjansivuandClaude Opus 4.8 c18ae388be Fix #6142: allow adding a list in Lists board-view mode
The 'Add list' composer was only rendered in Swimlanes mode; it now also appears
in Lists mode (using the board's default swimlane), so a new board in Lists mode
can get lists without switching modes. Reuses the existing add-list method.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:40:13 +03:00
Lauri OjansivuandClaude Opus 4.8 d7ae93bb27 Add #6091: show the status (current list) of each sub-task
Each subtask now shows its current list, read-only, next to its title (prefixed
with the board title when the subtask lives on a different board than the parent
card). subtaskStatusLabel helper unit tested. MVP.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:40:13 +03:00
Lauri OjansivuandClaude Opus 4.8 f592735080 Fix #5905: notify card members and record history when an attachment is added
Uploading an attachment now creates an addAttachment activity, so card members
and subscribers are notified (consistent with attachment removal) and it appears
in card history. Previously the activity was never created because the store
strategy upload hook was dead code. buildAttachmentAddedActivity unit tested.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:40:13 +03:00
Lauri OjansivuandClaude Opus 4.8 bdb8e62546 Add #5907, #5906: threaded comment replies and admin comment-edit restriction
Comments gain an optional parentId with a Reply link and an 'in reply to' quote
(#5907, MVP single-level threading). New board setting restrictCommentEditing
(default off): when on, only a comment's author may edit/delete it, enforced
server-side via collection hooks (#5906). canEditComment decision unit tested.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:40:13 +03:00
Lauri OjansivuandClaude Opus 4.8 5c890bacaa Fix #5942, #5902, #6018, #5982: mobile UI regressions
Keep card-detail sub-popups open on touch when assigning a user / setting the
due date (#5942); render minicards one-per-row and make the Home button a proper
tap target (#5902); clamp enormous icon/text sizing (#6018); and trim excessive
padding/margins (#5982). Mobile overrides are scoped under media queries in a new
responsiveFixes.css; isMobileViewport helper unit tested.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:40:13 +03:00
Lauri OjansivuandClaude Opus 4.8 086254e106 Fix #6000, #5965: due-date colours correct and consistent across views
Root cause of #6000 was diff(date, now, 'days') with an invalid unit comparing
raw milliseconds, so future due dates were mis-coloured; replaced with a precise
hours-based comparison (past=overdue/red, <=48h=due-soon/amber, >48h=not-due/grey).
For #5965 the colour-decision logic is unified into one shared dueDateClass()
helper used by both the minicard and card-detail badges, and the card-detail
status colours now win the cascade, so overdue shows red in both. Unit tested.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:40:13 +03:00
Lauri OjansivuandClaude Opus 4.8 bf75efaef5 Add #6051: per-user permanent dismissal of the Announcement banner
A user can permanently close the current global announcement so it does not
reappear on reload or board-switch, until the admin edits the announcement text
(its content-derived version changes, so it reappears for everyone). Dismissed
version stored on the user profile; visibility decided by the unit-tested
shouldShowAnnouncement helper.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:39:41 +03:00
Lauri OjansivuandClaude Opus 4.8 371258a6d0 Add #6116: restrict adding board members to the same Organization or Team
New global admin setting boardMembersFromSameOrgOrTeamOnly (default off). When
enabled, a user can only be added to a board if they share an Organization or
Team with the inviter or an active board member; enforced server-side in the
invite and user-search paths. Site admins bypass. Pure canAddUserToBoard helper
with unit tests; Admin Panel toggle added.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:39:28 +03:00
Lauri OjansivuandClaude Opus 4.8 fe4d2a56f2 Fix #6135: board/list/swimlane numbering broke first-letter keyboard nav
The move/copy card popups prefixed a number to each option (e.g. '3. Board'),
which broke jumping to an entry by typing its first letter and made digit-named
boards confusing. Remove the numeric prefix so options start with their name
again. Pure boardOptionLabel helper added (numbering off by default) with tests.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:39:02 +03:00
Lauri OjansivuandClaude Opus 4.8 a8ed326a5b Add #6081: show how many times a card's due date was changed
Display a 'due date changed N times' count on the card detail (derived from
existing a-dueAt activities via getDueDateChangeCount) for deadline
accountability. Counting logic extracted to server/lib/dueDateEdits.js with
unit tests. MVP per the issue (display rather than hard limit).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:38:50 +03:00
Lauri OjansivuandClaude Opus 4.8 b998246c35 Fix #5910 and add #6034: board search matches comments, drag-drop search results
Board-level search now matches text inside card comments, consistent with global
search (#5910); the (title OR description OR comment) rule is extracted to the
unit-tested helper server/lib/cardMatch.js. Search-result cards can be dragged
directly onto board lists, reusing card.move() (#6034, MVP: drops append to end
of the target list).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:38:28 +03:00
Lauri OjansivuandClaude Opus 4.8 b3acbd6920 Fix #5999, #5930: show all due cards and make Due Cards list scrollable
Remove the limit: 100 cap in the dueCards publication so all of a user's due
cards across boards are shown (#5999), and add a scoped scroll container so the
Due Cards list scrolls past the first cards on mobile (#5930). Filter/sort logic
extracted to dueCardsLogic.js with unit tests.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 14:38:16 +03:00
Lauri Ojansivu 0965d083dc Updated ChangeLog. 2026-06-20 13:11:32 +03:00
Lauri Ojansivu f569eb9c0c - [Fixed OIDC/OAuth2 "Log Out" redirecting to the identity provider home page instead of back to Wekan](https://github.com/wekan/wekan/issues/6158).
With autologin (`OIDC_REDIRECTION_ENABLED=true`), clicking Log Out redirected to the OAuth2 server URL
  (for example the Keycloak base URL `https://id.company.com`), which shows an error page for non-admin
  users. Added the new optional `OAUTH2_LOGOUT_ENDPOINT` setting: when set to the provider's
  `end_session_endpoint` (Keycloak example `/realms/<realm>/protocol/openid-connect/logout`), Wekan now
  performs an OIDC RP-initiated logout that ends the identity provider session and returns the user to
  Wekan (`ROOT_URL`) via `post_logout_redirect_uri`. When unset, logout behaviour is unchanged, so this
  is backward compatible. For Keycloak 18+, add your Wekan `ROOT_URL` to the client's
  *Valid post logout redirect URIs*. See [docs/Login/Keycloak/Keycloak.md](https://github.com/wekan/wekan/blob/main/docs/Login/Keycloak/Keycloak.md).

Thanks to zambalee and xet7 !

Fixes #6158
2026-06-20 13:11:32 +03:00
github-actions[bot] 02cf8fdf16 Bump versions for v9.64 2026-06-20 01:20:53 +00:00
Lauri Ojansivu b0910e48d4 Updated ChangeLog. 2026-06-20 04:16:59 +03:00
Lauri OjansivuandClaude Opus 4.8 4afd8b8296 Updated ChangeLog: ChecklistBleed security fix + docker guard fix (upcoming)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 04:12:53 +03:00
Lauri OjansivuandClaude Opus 4.8 b1ca76007b Fix GHSA-gv8h-5p3p-6hx7 (ChecklistBleed): checklist cross-board write via DDP allow rule (CWE-863)
The Checklists and ChecklistItems collection allow rules authorize an
update only against the document's CURRENT (source) cardId. A DDP client
with write access to its own board could move a checklist/item it owns
onto a card in a private board it is not a member of by $set-ting a new
cardId (and, for items, checklistId); the before.update hook then
denormalizes boardId from the destination card, attaching the
attacker-controlled document to the victim's private board. Same class
as denyCrossBoardMove / BoardBleed (GHSA-gm7v-pc38-53jr), but for the
card-attached checklist documents that the boardId-only deny did not
cover.

Add denyCrossBoardMoveByCard and denyCrossBoardMoveByChecklistItem in
server/lib/utils.js, which reject any update whose destination board
(resolved from a new boardId, cardId, or checklistId in the modifier)
the caller cannot write to, and wire them into Checklists.deny /
ChecklistItems.deny. Legitimate moves into writable boards and same-card
edits are unaffected; the server-side moveChecklist Meteor method bypasses
allow/deny and is unchanged. Adds a regression test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 04:10:36 +03:00
github-actions[bot] 591a7a458b Bump versions for v9.63 2026-06-20 01:07:24 +00:00
Lauri OjansivuandClaude Opus 4.8 069dbc11f4 Fix docker pre-build version guard false-failing the release
The bundle-version guard added for the Admin-Panel-version fix assumed
the WeKan app package.json ships as a standalone file with a v-prefixed
version, and made 'not found' fatal. Meteor does not ship it that way:
it inlines the app package.json into the compiled
bundle/programs/server/app/app.js as a JSON module
({"name":"wekan","version":"v9.63.0",...}), so the guard found no
v-prefixed package.json and aborted the v9.63 docker build (exit 1).

Read the version from the inlined module in app.js instead (anchored on
"name":"wekan", exactly what require('/package.json') resolves to), and
make a detection miss a WARNING that continues rather than a hard
failure — only a confirmed version MISMATCH blocks the release.
--build-arg VERSION remains the actual guarantee.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-20 04:01:59 +03:00
913 changed files with 82180 additions and 9151 deletions

No files matched your search

-2
View File
@@ -1,5 +1,3 @@
version: '3.7'
services:
wekandb-dev:
+1 -1
View File
@@ -24,7 +24,7 @@ updates:
# * The only upgrades Dependabot/npm offer are build-breaking: a
# @meteorjs/rspack downgrade, or @rspack/cli 2.0 / Rspack 2.0, which
# needs Meteor 3.6 (see https://github.com/meteor/meteor/pull/14360).
# WeKan currently runs METEOR@3.5-rc.1.
# WeKan currently runs METEOR@3.5-rc.2.
#
# So pin them here until Meteor 3.6 + Rspack 2.0 land, then revisit.
- dependency-name: "@meteorjs/rspack"
+1 -1
View File
@@ -9,6 +9,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: 'Checkout Repository'
uses: actions/checkout@v6
uses: actions/checkout@v7
- name: 'Dependency Review'
uses: actions/dependency-review-action@v5
+4 -4
View File
@@ -32,13 +32,13 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v6
uses: actions/checkout@v7
# Login against a Docker registry except on PR
# https://github.com/docker/login-action
- name: Log into registry ${{ env.REGISTRY }}
if: github.event_name != 'pull_request'
uses: docker/login-action@650006c6eb7dba73a995cc03b0b2d7f5ca915bee
uses: docker/login-action@af1e73f918a031802d376d3c8bbc3fe56130a9b0
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
@@ -48,14 +48,14 @@ jobs:
# https://github.com/docker/metadata-action
- name: Extract Docker metadata
id: meta
uses: docker/metadata-action@80c7e94dd9b9319bd5eb7a0e0fe9291e23a2a2e9
uses: docker/metadata-action@dc802804100637a589fabce1cb79ff13a1411302
with:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
# Build and push Docker image with Buildx (don't push on PR)
# https://github.com/docker/build-push-action
- name: Build and push Docker image
uses: docker/build-push-action@f9f3042f7e2789586610d6e8b85c8f03e5195baf
uses: docker/build-push-action@53b7df96c91f9c12dcc8a07bcb9ccacbed38856a
with:
context: .
push: ${{ github.event_name != 'pull_request' }}
+1 -1
View File
@@ -15,6 +15,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v7
- name: Build the Docker image
run: docker build . --file Dockerfile --tag wekan:$(date +%s)
+107
View File
@@ -0,0 +1,107 @@
name: Build meteor-spk bundle
# Manually triggered. Assembles WeKan's modernized meteor-spk (the Sandstorm packaging
# tool + its meteor-spk.deps: Node 24, FerretDB, the Mongo 3.x CLIs and the modern
# sandstorm-http-bridge) and zips it as meteor-spk-YYYY-MM-DD_HH_MM_SS.zip — the same kind
# of self-contained meteor-spk bundle that https://github.com/sandstorm-io/meteor-spk
# releases, but with WeKan's Node 24 / FerretDB deps baked in. Download it to `meteor-spk
# pack` WeKan (or any Meteor 3.x app) without re-running build-deps.sh each time.
#
# gh workflow run meteor-spk.yml
#
# This only assembles + zips the tool; it does NOT pack or sign a WeKan .spk, so it needs
# no SANDSTORM_KEYRING. The .spk itself is built by sandstorm.yml; the Sandstorm App
# Market publish is done by sandstorm-store.yml.
on:
workflow_dispatch:
inputs:
ref:
description: 'Branch, tag or SHA to build the meteor-spk deps from (default: main)'
required: false
default: 'main'
permissions:
contents: write
env:
NODE_VERSION: '24'
jobs:
meteor-spk:
runs-on: ubuntu-24.04
timeout-minutes: 120
steps:
- uses: actions/checkout@v7
with:
ref: ${{ github.event.inputs.ref || 'main' }}
- uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
- name: Enable unprivileged user namespaces (Ubuntu 24.04 restricts them)
# Same as sandstorm.yml: Ubuntu 24.04's AppArmor blocks the unprivileged user
# namespaces the Sandstorm install relies on; relax it so the install (whose
# sandstorm-http-bridge build-deps.sh copies in) can run on the runner.
run: |
sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0 || true
sudo sysctl -w kernel.unprivileged_userns_clone=1 2>/dev/null || true
- name: Install system dependencies
run: |
sudo apt-get update
sudo apt-get install -y p7zip-full wget curl build-essential g++ make python3 unzip xz-utils git zip
- name: Install Sandstorm (dev, unattended)
# build-deps.sh's [bridge] step copies the modern
# /opt/sandstorm/latest/bin/sandstorm-http-bridge into the deps, so Sandstorm
# must be installed first — same ordering as sandstorm.yml.
run: curl https://install.sandstorm.io | sudo bash -s -- -d
- name: Assemble modern meteor-spk.deps (Node 24 + FerretDB + Mongo 3.x CLIs)
# Base = upstream meteor-spk 0.6.0 from dl.sandstorm.io; build-deps.sh swaps in
# Node 24, FerretDB, the Mongo 3.x CLIs, the migration launcher/importer, keeps
# niscud, and swaps in the modern sandstorm-http-bridge. Produces
# $HOME/projects/meteor-spk/meteor-spk-0.6.0 (the meteor-spk tool + deps).
run: bash sandstorm-src/build-deps.sh
- name: Zip the meteor-spk bundle
id: zip
run: |
set -euo pipefail
STAMP="$(date +'%Y-%m-%d_%H_%M_%S')"
ZIP="meteor-spk-${STAMP}.zip"
BUNDLE_DIR="$HOME/projects/meteor-spk"
if [ ! -d "$BUNDLE_DIR/meteor-spk-0.6.0" ]; then
echo "::error::Expected meteor-spk bundle at $BUNDLE_DIR/meteor-spk-0.6.0 was not produced by build-deps.sh."
exit 1
fi
# Zip so it extracts to a top-level meteor-spk-0.6.0/ directory, like the
# upstream meteor-spk release archives. Exclude the base tarball build-deps.sh
# downloaded next to it.
( cd "$BUNDLE_DIR" && zip -r -y -q "$GITHUB_WORKSPACE/$ZIP" meteor-spk-0.6.0 -x '*.tar.xz' )
ZIP_BYTES=$(stat -c%s "$GITHUB_WORKSPACE/$ZIP")
echo "Packed $ZIP: $((ZIP_BYTES/1024/1024)) MiB ($ZIP_BYTES bytes)"
ls -la "$GITHUB_WORKSPACE/$ZIP"
echo "zip=$ZIP" >> "$GITHUB_OUTPUT"
- uses: actions/upload-artifact@v7
with:
name: ${{ steps.zip.outputs.zip }}
path: ${{ steps.zip.outputs.zip }}
retention-days: 7
- name: Upload the meteor-spk bundle to the newest WeKan release
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_REPO: ${{ github.repository }}
run: |
set -euo pipefail
TAG="$(gh release list --limit 1 --json tagName --jq '.[0].tagName' 2>/dev/null || true)"
if [ -z "${TAG:-}" ] || [ "$TAG" = "null" ]; then
echo "::warning::No existing GitHub Release found; the meteor-spk bundle is available only as a workflow artifact."
exit 0
fi
echo "Uploading ${{ steps.zip.outputs.zip }} to the newest release: $TAG"
gh release upload "$TAG" "${{ steps.zip.outputs.zip }}" --clobber
+68 -29
View File
@@ -18,7 +18,7 @@ jobs:
name: Meteor unit tests
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v7
- name: Setup Node 24
uses: actions/setup-node@v6
@@ -27,14 +27,14 @@ jobs:
cache: 'npm'
- name: Cache Meteor installation
uses: actions/cache@v5
uses: actions/cache@v6
with:
path: ~/.meteor
key: meteor-${{ hashFiles('.meteor/release') }}-${{ hashFiles('.meteor/packages') }}
restore-keys: meteor-
- name: Cache Meteor build (.meteor/local)
uses: actions/cache@v5
uses: actions/cache@v6
with:
path: .meteor/local
key: meteor-local-unit-${{ hashFiles('.meteor/versions') }}
@@ -62,7 +62,7 @@ jobs:
run: meteor test --once --driver-package meteortesting:mocha
e2e-tests:
name: Playwright E2E (${{ matrix.project }})
name: Playwright E2E (${{ matrix.project }} ${{ matrix.shard }}/2)
runs-on: ubuntu-24.04
needs: unit-tests
strategy:
@@ -71,6 +71,12 @@ jobs:
# Playwright bundles Chromium, Firefox and WebKit builds that all run
# headless on the Linux runner (installed per-job below with --with-deps).
project: [chromium, firefox, webkit]
# Split each browser's ~245 specs across 2 parallel shards (6 jobs total)
# to cut wall-clock time. Each shard job starts its own WeKan + Mongo, so
# there is no shared-server contention between shards. Raise the shard
# count (here and in the --shard flag below) once the baseline is green
# and/or once E2E runs against a prebuilt bundle (cheaper per-job startup).
shard: [1, 2]
services:
mongodb:
@@ -83,7 +89,7 @@ jobs:
--health-retries 5
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v7
- name: Setup Node 24
uses: actions/setup-node@v6
@@ -92,14 +98,14 @@ jobs:
cache: 'npm'
- name: Cache Meteor installation
uses: actions/cache@v5
uses: actions/cache@v6
with:
path: ~/.meteor
key: meteor-${{ hashFiles('.meteor/release') }}-${{ hashFiles('.meteor/packages') }}
restore-keys: meteor-
- name: Cache Meteor build (.meteor/local)
uses: actions/cache@v5
uses: actions/cache@v6
with:
path: .meteor/local
key: meteor-local-e2e-${{ hashFiles('.meteor/versions') }}
@@ -123,34 +129,54 @@ jobs:
run: npx playwright install --with-deps ${{ matrix.project }}
working-directory: tests/playwright
- name: Start WeKan in background
- name: Build and start WeKan (production bundle)
run: |
# Run E2E against a PRODUCTION build instead of `meteor run` (dev mode).
# In dev the client JS is served by the rspack dev server, which did not
# serve the bundle reliably in headless CI: the browser received HTML for
# the bundle ("Unexpected token '<'"), Meteor never initialised, and every
# spec timed out. A production build bakes the client JS into the bundle,
# served statically by the Meteor server at :3000.
meteor build ./output --directory
( cd output/bundle/programs/server && npm install )
# WeKan's server/00checkStartup.js refuses to start unless WRITABLE_PATH
# (used for attachment/file storage) is set and writable.
mkdir -p "$PWD/wekan-writable"
# Match the env the dev runner (rebuild-wekan.sh) and the specs expect:
# WITH_API enables the REST API (specs 17/23/24/28), comment-editor
# flag matches dev.
MONGO_URL=mongodb://localhost:27017/wekan_test \
ROOT_URL=http://localhost:3000 \
PORT=3000 \
meteor run --settings settings.json > wekan-run.log 2>&1 &
# The first Meteor build is slow, so wait up to 20 minutes for the
# server to start responding before giving up.
for i in $(seq 1 120); do
WRITABLE_PATH="$PWD/wekan-writable" \
WITH_API=true \
RICHER_CARD_COMMENT_EDITOR=false \
node output/bundle/main.js > wekan-run.log 2>&1 &
# The production server serves the client JS statically, so once :3000
# responds the bundle is being served. Wait up to 10 minutes.
for i in $(seq 1 60); do
if curl -sf http://localhost:3000 > /dev/null; then
echo "WeKan is up after $((i * 10))s"
break
fi
echo "Waiting for WeKan... attempt $i/120"
echo "Waiting for WeKan... attempt $i/60"
sleep 10
done
if ! curl -sf http://localhost:3000 > /dev/null; then
echo "WeKan failed to start. Last 200 log lines:"
tail -n 200 wekan-run.log
echo "WeKan failed to start. Last 250 log lines:"
tail -n 250 wekan-run.log
exit 1
fi
env:
DISABLE_CAPTCHA: 'true'
TOOL_NODE_FLAGS: --max-old-space-size=8192
NODE_OPTIONS: --max-old-space-size=8192
DISABLE_CAPTCHA: 'true'
- name: Run Playwright tests (${{ matrix.project }})
- name: Run Playwright tests (${{ matrix.project }} shard ${{ matrix.shard }}/2)
run: |
npx playwright test \
--project=${{ matrix.project }} \
--shard=${{ matrix.shard }}/2 \
--reporter=github
working-directory: tests/playwright
env:
@@ -164,7 +190,7 @@ jobs:
if: always()
uses: actions/upload-artifact@v7
with:
name: playwright-report-${{ matrix.project }}
name: playwright-report-${{ matrix.project }}-shard${{ matrix.shard }}
path: tests/playwright/playwright-report/
retention-days: 14
@@ -172,7 +198,7 @@ jobs:
if: failure()
uses: actions/upload-artifact@v7
with:
name: test-results-${{ matrix.project }}
name: test-results-${{ matrix.project }}-shard${{ matrix.shard }}
path: tests/playwright/test-results/
retention-days: 7
@@ -192,7 +218,7 @@ jobs:
--health-retries 5
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v7
- name: Setup Node 24
uses: actions/setup-node@v6
@@ -201,14 +227,14 @@ jobs:
cache: 'npm'
- name: Cache Meteor installation
uses: actions/cache@v5
uses: actions/cache@v6
with:
path: ~/.meteor
key: meteor-${{ hashFiles('.meteor/release') }}-${{ hashFiles('.meteor/packages') }}
restore-keys: meteor-
- name: Cache Meteor build (.meteor/local)
uses: actions/cache@v5
uses: actions/cache@v6
with:
path: .meteor/local
key: meteor-local-regression-${{ hashFiles('.meteor/versions') }}
@@ -227,27 +253,40 @@ jobs:
- name: Install Chromium
run: sudo apt-get install -y chromium-browser
- name: Start WeKan in background
- name: Build and start WeKan (production bundle)
run: |
# Run a PRODUCTION build, not `meteor run` (dev): exactly like the
# Playwright e2e job, because the rspack dev server does not serve the
# client JS bundle in headless CI, so Meteor never initialises and the
# puppeteer regression test times out in waitForMeteorGlobals(). The
# production bundle serves the client statically. WRITABLE_PATH is
# required by server/00checkStartup.js; WITH_API mirrors the dev runner.
meteor build ./output --directory
( cd output/bundle/programs/server && npm install )
mkdir -p "$PWD/wekan-writable"
MONGO_URL=mongodb://localhost:27017/wekan_regression \
ROOT_URL=http://localhost:3000 \
PORT=3000 \
meteor run > wekan-run.log 2>&1 &
# The first Meteor build is slow, so wait up to 20 minutes.
for i in $(seq 1 120); do
WRITABLE_PATH="$PWD/wekan-writable" \
WITH_API=true \
RICHER_CARD_COMMENT_EDITOR=false \
node output/bundle/main.js > wekan-run.log 2>&1 &
for i in $(seq 1 60); do
if curl -sf http://localhost:3000 > /dev/null; then
echo "WeKan is up after $((i * 10))s"
break
fi
echo "Waiting for WeKan... attempt $i/120"
echo "Waiting for WeKan... attempt $i/60"
sleep 10
done
if ! curl -sf http://localhost:3000 > /dev/null; then
echo "WeKan failed to start. Last 200 log lines:"
tail -n 200 wekan-run.log
echo "WeKan failed to start. Last 250 log lines:"
tail -n 250 wekan-run.log
exit 1
fi
env:
TOOL_NODE_FLAGS: --max-old-space-size=8192
NODE_OPTIONS: --max-old-space-size=8192
DISABLE_CAPTCHA: 'true'
- name: Run list-regressions e2e
+566 -137
View File
@@ -7,13 +7,20 @@ name: Release All Platforms
# Or use the convenience script (bumps versions, commits, pushes, then triggers):
# ./releases/release-all.sh 9.35 9.36
#
# The Docker image and snap cover the platforms MongoDB ships server binaries for
# (amd64, arm64; win64 + mac bundles too); MongoDB 7.x is the default database.
# Additionally, WeKan server bundles are built for every other architecture
# Node.js 24.x publishes binaries for — s390x and ppc64le — and attached to the
# GitHub Release as extra downloads (run a separate MongoDB for those). These
# extra-arch bundles are NOT part of the Docker image or snap. (armv7l/32-bit ARM
# is not built: Node.js 24 ships no armv7l binaries.)
# WeKan's default database is MongoDB, which ships server binaries only for amd64
# and arm64 (+ the win64/mac bundles). On every OTHER architecture that has a
# Node.js 24 build — ppc64le, s390x, riscv64 — there is no MongoDB, so those
# bundles ship FerretDB v1 instead: the wekan/FerretDB fork with its embedded
# pure-Go SQLite backend, which speaks the MongoDB wire protocol. FerretDB is
# built + released SEPARATELY (wekan/FerretDB, its own build.sh) as individual
# per-arch binaries; each bundle job downloads ONLY the ferretdb-<arch> binary for
# the platform it targets and bakes it in, so amd64/arm64 users can opt into it
# too (WEKAN_DB=ferretdb, `snap set wekan
# database=ferretdb`, or Docker env). Whichever backend is chosen binds the same
# MongoDB port, so MONGO_URL is unchanged. ppc64le/s390x/riscv64 are now covered
# by the Docker image as well (self-contained, FerretDB auto-started). riscv64
# uses unofficial-builds.nodejs.org for Node 24. (armv7l/32-bit ARM is still not
# built: there is NO Node.js 24 build for it anywhere, so nothing could run it.)
#
# This workflow does EVERYTHING for a release remotely (nothing is built or
# pushed on the maintainer's machine), running jobs in parallel where possible:
@@ -22,19 +29,37 @@ name: Release All Platforms
# commits and pushes the bump to wekan/wekan main
# - prepare: tags the bumped main as v<new_version> and extracts release notes
# - website: updates the wekan/wekan.fi repo (install page + API docs) and pushes
# - charts: updates and publishes the wekan/charts Helm chart and pushes
# - charts: updates and publishes the wekan/charts Helm chart and pushes,
# only AFTER the `docker` job has published the image (skipped if
# docker fails)
# - build-*: builds the amd64 bundle (full Meteor 3 build), then rebuilds native
# modules for arm64 from that amd64 base
# modules for arm64 from that amd64 base. Each bundle job downloads
# only the ferretdb-<arch> binary it needs from the newest wekan/FerretDB
# release (FerretDB is built + released separately by its own build.sh —
# not compiled here) and embeds it
# - release: creates the GitHub Release with the newest CHANGELOG.md notes and
# uploads the core wekan-<version>-{amd64,arm64}.zip bundles
# - build-win64 / build-mac-arm64 / build-extra-arches: built AFTER release, each
# rebuilds the amd64 bundle's native modules for its platform (Windows,
# macOS arm64, and QEMU-emulated s390x/ppc64le) and attaches its
# .zip to the Release as an extra download. Decoupled from `release` so
# a slow/flaky build never blocks it; not in the Docker image or snap
# - docker: builds and pushes the multi-arch image to Docker Hub, Quay.io, GHCR
# - snap: builds the snap on Launchpad (amd64 + arm64), pushes it to the Snap
# Store and attaches the .snap files to the GitHub Release
# macOS arm64, and QEMU-emulated ppc64le/s390x/riscv64) and attaches
# its .zip to the Release. Windows/macOS strip the Linux FerretDB back
# out (MongoDB-only). Decoupled from `release` so a slow/flaky build
# never blocks it
# - build-sandstorm: built AFTER release, builds the Sandstorm .spk package
# (same steps as the standalone sandstorm.yml workflow, which still
# exists for testing the .spk build on its own) and attaches
# wekan-<version>-sandstorm.spk to the Release. Non-blocking: the
# Sandstorm build is the experimental/fragile part of CI, so it
# never fails the release
# - docker: builds and pushes the multi-arch image (amd64, arm64, ppc64le, s390x,
# riscv64) to Docker Hub, Quay.io, GHCR
# - snap: builds the snap on Launchpad from the default core24 snapcraft.yaml
# (platforms: amd64, arm64, s390x, ppc64el, riscv64), pushes it to the
# Snap Store stable + candidate + beta + edge channels and attaches
# the .snap files to the GitHub Release. core24 allows stable and
# candidate (core26 does not).
# `snap set wekan database=ferretdb` switches the running backend to
# FerretDB v1 (snapcraft-core26.yaml is the core26 variant)
#
# Required GitHub Secrets:
# GHCR_AUTH - base64("username:token") for ghcr.io
@@ -43,6 +68,8 @@ name: Release All Platforms
# SNAP_AUTH - Snap Store credentials (output of `snapcraft export-login`)
# LP_CREDENTIALS - base64 of the Launchpad credentials file used by
# `snapcraft remote-build` (see releases/snap-build.sh notes)
# SANDSTORM_KEYRING - base64 of ~/.sandstorm-keyring; meteor-spk signs the .spk
# with the WeKan Sandstorm app's private key from this keyring
# WEKAN_REPO_TOKEN - Personal Access Token with write access to wekan/wekan.fi
# and wekan/charts, used by the website + charts jobs to push
# to those repos (the built-in GITHUB_TOKEN only covers
@@ -64,7 +91,7 @@ permissions:
contents: write
packages: write
# Node.js major version that Meteor 3.5-beta bundles. Used for native module
# Node.js major version that Meteor 3.5 bundles. Used for native module
# rebuilds on every platform — it must match the amd64 build's Node ABI.
env:
NODE_VERSION: '24'
@@ -81,7 +108,7 @@ jobs:
permissions:
contents: write
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v7
with:
ref: main
fetch-depth: 0
@@ -124,7 +151,7 @@ jobs:
version: ${{ steps.version.outputs.version }}
changelog: ${{ steps.changelog.outputs.content }}
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v7
with:
ref: main
fetch-depth: 0
@@ -186,13 +213,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout wekan repo (bumped main, with rebuilt API docs)
uses: actions/checkout@v6
uses: actions/checkout@v7
with:
ref: main
path: wekan
- name: Checkout wekan.fi website repo
uses: actions/checkout@v6
uses: actions/checkout@v7
with:
repository: wekan/wekan.fi
token: ${{ secrets.WEKAN_REPO_TOKEN }}
@@ -210,22 +237,24 @@ jobs:
cd ..
./wekan/releases/release-website.sh "${{ inputs.old_version }}" "${{ inputs.new_version }}"
# ─── 1c. Update and publish the Helm chart repo (parallel) ──────────────────
# ─── 1c. Update and publish the Helm chart repo (after docker) ──────────────
# Bumps the WeKan version in wekan/charts, packages the chart and publishes it
# to the gh-pages Helm index, then pushes both branches. Runs in parallel with
# the platform builds; packaging the chart does not need the built artifacts.
# to the gh-pages Helm index, then pushes both branches. Runs only AFTER the
# `docker` job succeeds: the chart points users at the freshly published
# multi-arch image, so we don't advertise a new chart version until that image
# is actually on the registries. If `docker` fails, this job is skipped.
charts:
needs: bump
needs: docker
runs-on: ubuntu-latest
steps:
- name: Checkout wekan repo (for releases/release-charts.sh + version refs)
uses: actions/checkout@v6
uses: actions/checkout@v7
with:
ref: main
path: wekan
- name: Checkout wekan/charts repo (main + gh-pages)
uses: actions/checkout@v6
uses: actions/checkout@v7
with:
repository: wekan/charts
token: ${{ secrets.WEKAN_REPO_TOKEN }}
@@ -250,29 +279,29 @@ jobs:
./wekan/releases/release-charts.sh "${{ inputs.new_version }}"
# ─── 2. Build amd64 bundle (full Meteor 3 build) ────────────────────────────
# Meteor 3.5-beta installer supports only Linux x86_64/aarch64, macOS, Windows.
# Meteor 3.5 installer supports only Linux x86_64/aarch64, macOS, Windows.
# The full Meteor build always runs here on x86_64; every other platform then
# only rebuilds the native npm modules from this bundle.
build-amd64:
needs: prepare
needs: [prepare]
runs-on: ubuntu-24.04
timeout-minutes: 180
env:
VERSION: ${{ needs.prepare.outputs.version }}
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v7
with:
ref: refs/tags/v${{ needs.prepare.outputs.version }}
- name: Cache Meteor installation
uses: actions/cache@v5
uses: actions/cache@v6
with:
path: ~/.meteor
key: meteor-${{ hashFiles('.meteor/release') }}-${{ hashFiles('.meteor/packages') }}
restore-keys: meteor-
- name: Cache npm packages
uses: actions/cache@v5
uses: actions/cache@v6
with:
path: ~/.npm
key: npm-${{ hashFiles('package-lock.json') }}
@@ -280,7 +309,7 @@ jobs:
- name: Install system dependencies
run: |
sudo apt-get update
sudo apt-get install -y build-essential g++ make python3 curl wget zip unzip
sudo apt-get install -y build-essential g++ make python3 curl wget zip unzip qemu-user-static
- uses: actions/setup-node@v6
with:
@@ -304,6 +333,45 @@ jobs:
cd .build/bundle/programs/server
npm install
- name: Embed Node.js, FerretDB (amd64) and launcher into the bundle
# Make the release .zip self-contained (offline): bundle Node.js + FerretDB
# + a start-wekan.sh that runs WeKan on the bundled Node against the bundled
# FerretDB (SQLite) by default, storing files on the filesystem under
# WRITABLE_PATH. This amd64 bundle is the base every other Linux arch is
# derived from; those jobs overwrite bundle/node and bundle/ferretdb with
# their own arch's binaries and inherit this launcher.
run: |
# Bundled Node.js: the runner's node (setup-node) is linux-x64 Node 24,
# matching this base bundle's arch.
cp -L "$(command -v node)" .build/bundle/node
chmod +x .build/bundle/node
# Bundled FerretDB (amd64): download only this arch's binary from the
# newest wekan/FerretDB release (per-arch assets, no ferretdb.zip).
curl -fSL --retry 5 --retry-delay 10 -o .build/bundle/ferretdb \
"https://github.com/wekan/FerretDB/releases/latest/download/ferretdb-amd64"
chmod +x .build/bundle/ferretdb
# Bundled MongoDB Database Tools (amd64) from wekan/mongo-tools (per-arch,
# no mongodb.com). This base amd64 bundle is inherited by the other Linux
# arches, which overwrite these with their own arch's tools below.
MT="https://github.com/wekan/mongo-tools/releases/latest/download"
for t in bsondump mongodump mongoexport mongofiles mongoimport mongorestore mongostat mongotop; do
curl -fSL --retry 5 --retry-delay 10 -o ".build/bundle/$t" "$MT/$t-amd64"
chmod +x ".build/bundle/$t"
done
# Self-contained launcher (defaults to FerretDB SQLite + WRITABLE_PATH).
cp releases/ferretdb/start-wekan.sh .build/bundle/
chmod +x .build/bundle/start-wekan.sh
# #6458: cpu-exec + same-arch qemu-user. cpu-exec runs any bundled
# binary that declares required CPU features (e.g. an external
# MongoDB 5+: AVX on x86_64) through qemu-user emulation on CPUs
# that lack them — including hypervisors that mask AVX. Every Linux
# bundle ships its own arch's qemu-user; other arches overwrite
# these below.
cp snap-src/bin/cpu-exec .build/bundle/cpu-exec
chmod +x .build/bundle/cpu-exec
cp /usr/bin/qemu-x86_64-static .build/bundle/qemu-x86_64
chmod +x .build/bundle/qemu-x86_64
- name: Create amd64 zip
run: |
cd .build
@@ -326,7 +394,7 @@ jobs:
- name: Install dependencies
run: |
sudo apt-get update
sudo apt-get install -y build-essential g++ make python3 curl unzip zip
sudo apt-get install -y build-essential g++ make python3 curl unzip zip qemu-user-static
- name: Download amd64 bundle
uses: actions/download-artifact@v8
@@ -356,6 +424,30 @@ jobs:
node:${NODE_VERSION}-slim \
sh -c "apt-get update -qq && apt-get install -y -q build-essential python3 && npm install"
- name: Embed Node.js + FerretDB (arm64) into the bundle
# The launcher (start-wekan.sh) is inherited from the amd64 base bundle;
# swap bundle/node (runner is arm64 -> linux-arm64 Node 24) and bundle/ferretdb.
run: |
cp -L "$(command -v node)" bundle/node
chmod +x bundle/node
# Download only the arm64 FerretDB binary from the newest wekan/FerretDB release.
curl -fSL --retry 5 --retry-delay 10 -o bundle/ferretdb \
"https://github.com/wekan/FerretDB/releases/latest/download/ferretdb-arm64"
chmod +x bundle/ferretdb
# Overwrite the inherited amd64 MongoDB Database Tools with arm64 ones.
MT="https://github.com/wekan/mongo-tools/releases/latest/download"
for t in bsondump mongodump mongoexport mongofiles mongoimport mongorestore mongostat mongotop; do
curl -fSL --retry 5 --retry-delay 10 -o "bundle/$t" "$MT/$t-arm64"
chmod +x "bundle/$t"
done
# #6458: replace the inherited amd64 qemu-user with this arch's own
# (cpu-exec is a shell script and stays as inherited). qemu-aarch64
# lets ARMv8.0 hosts (Raspberry Pi 4 and older) run binaries that
# need ARMv8.2-A, like MongoDB 5+.
rm -f bundle/qemu-x86_64
cp /usr/bin/qemu-aarch64-static bundle/qemu-aarch64
chmod +x bundle/qemu-aarch64
- name: Create arm64 zip
run: |
zip -r wekan-${VERSION}-arm64.zip bundle
@@ -388,6 +480,11 @@ jobs:
tag_name: v${{ needs.prepare.outputs.version }}
name: v${{ needs.prepare.outputs.version }}
body: ${{ needs.prepare.outputs.changelog }}
# FerretDB binaries are NOT attached here: the per-arch ferretdb-<arch>
# binaries live on the wekan/FerretDB releases
# (https://github.com/wekan/FerretDB/releases), which is where the WeKan
# builds fetch them from. Each wekan-<version>-<arch>.zip bundle embeds
# its own arch's FerretDB binary.
files: |
wekan-${{ needs.prepare.outputs.version }}-amd64.zip
wekan-${{ needs.prepare.outputs.version }}-arm64.zip
@@ -411,7 +508,7 @@ jobs:
# Checked out into src/ so start-wekan.bat and snapcraft.yaml (which pins
# the MongoDB tools/mongosh versions) are available; the downloaded bundle
# is extracted alongside it in the workspace root.
- uses: actions/checkout@v6
- uses: actions/checkout@v7
with:
ref: refs/tags/v${{ needs.prepare.outputs.version }}
path: src
@@ -432,6 +529,14 @@ jobs:
shell: bash
run: |
7z x wekan-${VERSION}-amd64.zip
# Drop the Linux node + FerretDB binaries + MongoDB Database Tools + POSIX
# launcher inherited from the amd64 base bundle; the Windows node.exe,
# ferretdb.exe, *.exe tools and start-wekan.bat are added in later steps.
rm -f bundle/node bundle/ferretdb bundle/.ferretdb-default bundle/start-wekan.sh
rm -f bundle/bsondump bundle/mongodump bundle/mongoexport bundle/mongofiles \
bundle/mongoimport bundle/mongorestore bundle/mongostat bundle/mongotop
# Linux-only cpu-exec + qemu-user (#6458) make no sense on Windows.
rm -f bundle/cpu-exec bundle/qemu-x86_64
# Fix: bcrypt 5.0.1 (Meteor accounts-password) ships node-addon-api@3
# which fails to compile on Node.js 24. Replace with bcrypt 6.0.0.
BCRYPT_DIR="$(pwd)/bundle/programs/server/npm/node_modules/meteor/accounts-password/node_modules/bcrypt"
@@ -454,40 +559,47 @@ jobs:
rm -rf node_modules
npm install
- name: Add MongoDB tools, mongosh and start-wekan.bat to the bundle
- name: Add MongoDB Database Tools to the bundle
shell: bash
run: |
set -euo pipefail
# Use the same MongoDB tools/mongosh versions as the snap, which
# releases/version.sh keeps at the newest release for each bundle.
TOOLS_VER=$(grep -oE 'mongodb-database-tools-ubuntu2204-\$\{TOOLS_ARCH\}-[0-9]+\.[0-9]+\.[0-9]+' src/snapcraft.yaml \
| grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1)
MONGOSH_VER=$(grep -oE 'mongosh-[0-9]+\.[0-9]+\.[0-9]+-linux' src/snapcraft.yaml \
| grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1)
echo "MongoDB Database Tools: $TOOLS_VER mongosh: $MONGOSH_VER"
# MongoDB Database Tools (Windows): bsondump, mongodump, mongoexport,
# mongofiles, mongoimport, mongorestore, mongostat, mongotop.
TOOLS_DIR="mongodb-database-tools-windows-x86_64-${TOOLS_VER}"
curl -fL -o tools.zip \
"https://fastdl.mongodb.org/tools/db/${TOOLS_DIR}.zip"
7z x -y tools.zip > /dev/null
cp "${TOOLS_DIR}/bin/"*.exe bundle/
# mongosh (Windows): mongosh.exe + mongosh_crypt_v1.dll.
MONGOSH_DIR="mongosh-${MONGOSH_VER}-win32-x64"
curl -fL -o mongosh.zip \
"https://downloads.mongodb.com/compass/${MONGOSH_DIR}.zip"
7z x -y mongosh.zip > /dev/null
cp "${MONGOSH_DIR}/bin/mongosh.exe" bundle/
cp "${MONGOSH_DIR}/bin/mongosh_crypt_v1.dll" bundle/
# Windows launcher from the repo root.
cp src/start-wekan.bat bundle/
# MongoDB Database Tools (Windows) built by wekan/mongo-tools (pure Go),
# one <tool>-win64.exe per tool from that repo's newest release — no
# mongodb.com dependency. No mongosh: WeKan no longer bundles the MongoDB
# Shell; scripted DB access uses the bundled Node.js 24 + `mongodb` driver.
# (The Windows launcher, start-wekan.bat, is added by the FerretDB embed
# step below from releases/ferretdb/start-wekan.bat.)
BASE="https://github.com/wekan/mongo-tools/releases/latest/download"
for tool in bsondump mongodump mongoexport mongofiles mongoimport mongorestore mongostat mongotop; do
curl -fL --retry 5 --retry-delay 10 -o "bundle/${tool}.exe" "${BASE}/${tool}-win64.exe"
done
echo "=== bundle contents ==="
ls -1 bundle/
- name: Embed Node.js, FerretDB (win64) and launcher into the bundle
shell: bash
# Make the Windows .zip self-contained: bundle node.exe (from the runner's
# win-x64 Node 24), ferretdb.exe (downloaded per-arch from the newest
# wekan/FerretDB release) and start-wekan.bat. FerretDB embedding is
# tolerant: if the win64 asset is missing the bundle stays MongoDB-only
# (start-wekan.bat then won't find ferretdb.exe).
run: |
# Bundled Node.js (win-x64 node.exe from setup-node).
NODE_SRC="$(command -v node)"
[ -f "$NODE_SRC" ] || NODE_SRC="${NODE_SRC}.exe"
cp "$NODE_SRC" bundle/node.exe
# Bundled FerretDB (win64): download only this arch's binary.
if curl -fSL --retry 5 --retry-delay 10 -o bundle/ferretdb.exe \
"https://github.com/wekan/FerretDB/releases/latest/download/ferretdb-win64.exe"; then
echo "Embedded FerretDB win64 -> bundle/ferretdb.exe"
else
rm -f bundle/ferretdb.exe
echo "No win64 FerretDB asset in the release; Windows bundle stays MongoDB-only."
fi
# Self-contained Windows launcher (defaults to FerretDB SQLite).
cp src/releases/ferretdb/start-wekan.bat bundle/
- name: Create win64 zip
shell: cmd
run: 7z a wekan-%VERSION%-win64.zip bundle
@@ -528,6 +640,15 @@ jobs:
- name: Rebuild native modules for macOS arm64
run: |
unzip -q wekan-${VERSION}-amd64.zip
# Replace the Linux node + FerretDB binaries + MongoDB Database Tools
# inherited from the amd64 base bundle with the macOS builds (added in a
# later step). The POSIX launcher start-wekan.sh works on macOS, so keep it.
rm -f bundle/node bundle/ferretdb bundle/.ferretdb-default
# Linux-only cpu-exec + qemu-user (#6458): qemu-user does not exist for
# macOS (Apple Silicon needs no AVX emulation anyway).
rm -f bundle/cpu-exec bundle/qemu-x86_64
rm -f bundle/bsondump bundle/mongodump bundle/mongoexport bundle/mongofiles \
bundle/mongoimport bundle/mongorestore bundle/mongostat bundle/mongotop
# Fix: bcrypt 5.0.1 (Meteor accounts-password) ships node-addon-api@3
# which fails to compile on Node.js 24. Replace with bcrypt 6.0.0.
BCRYPT_DIR="$(pwd)/bundle/programs/server/npm/node_modules/meteor/accounts-password/node_modules/bcrypt"
@@ -547,6 +668,31 @@ jobs:
npm install
cd ../../..
- name: Embed Node.js + FerretDB (mac-arm64) into the bundle
# Bundle the macOS arm64 Node.js (runner's darwin-arm64 Node 24) and the
# macOS FerretDB binary, downloaded per-arch from the newest wekan/FerretDB
# release. FerretDB is tolerant: if the mac-arm64 asset is missing the
# bundle stays MongoDB-only (start-wekan.sh then won't find ferretdb).
run: |
cp -L "$(command -v node)" bundle/node
chmod +x bundle/node
if curl -fSL --retry 5 --retry-delay 10 -o bundle/ferretdb \
"https://github.com/wekan/FerretDB/releases/latest/download/ferretdb-mac-arm64"; then
chmod +x bundle/ferretdb
echo "Embedded FerretDB mac-arm64 -> bundle/ferretdb"
else
rm -f bundle/ferretdb
echo "No mac-arm64 FerretDB asset in the release; macOS bundle stays MongoDB-only."
rm -f bundle/start-wekan.sh
fi
# macOS MongoDB Database Tools (mac-arm64) from wekan/mongo-tools; tolerant
# (skip any tool not built for macOS).
MT="https://github.com/wekan/mongo-tools/releases/latest/download"
for t in bsondump mongodump mongoexport mongofiles mongoimport mongorestore mongostat mongotop; do
curl -fSL --retry 5 --retry-delay 10 -o "bundle/$t" "$MT/$t-mac-arm64" \
&& chmod +x "bundle/$t" || { rm -f "bundle/$t"; echo "No $t-mac-arm64; skipping"; }
done
- name: Create mac-arm64 zip
run: zip -r wekan-${VERSION}-mac-arm64.zip bundle
@@ -564,11 +710,14 @@ jobs:
GH_REPO: ${{ github.repository }}
run: gh release upload "v${VERSION}" "wekan-${VERSION}-mac-arm64.zip" --clobber
# Extra-architecture Linux bundles (s390x, ppc64le).
# armv7l (32-bit ARM) is intentionally excluded: Node.js 24 ships no armv7l
# binaries (official or unofficial), so there is no node:24 linux/arm/v7 image
# to rebuild native modules against and no Node 24 runtime to run a bundle on
# an armv7 device. See https://nodejs.org/dist/latest-v24.x/ (no -linux-armv7l).
# Extra-architecture Linux bundles (ppc64le, s390x, riscv64) — the arches that
# have a Node.js 24 build but NO MongoDB server, so they ship FerretDB instead.
# ppc64le and s390x use official nodejs.org binaries; riscv64 uses the
# unofficial-builds.nodejs.org binary (nodejs.org ships no riscv64). armv7l
# (32-bit ARM) is intentionally excluded: there is NO Node.js 24 build for it
# anywhere (official or unofficial), so there is no runtime to run the bundle on
# an armv7 device, regardless of RAM. See https://nodejs.org/dist/latest-v24.x/
# (no -linux-armv7l) and https://unofficial-builds.nodejs.org/ (riscv64 only).
build-extra-arches:
needs: [prepare, build-amd64, release]
runs-on: ubuntu-24.04
@@ -579,8 +728,13 @@ jobs:
include:
- arch: s390x
platform: linux/s390x
node_base: official
- arch: ppc64le
platform: linux/ppc64le
node_base: official
- arch: riscv64
platform: linux/riscv64
node_base: unofficial
env:
VERSION: ${{ needs.prepare.outputs.version }}
steps:
@@ -590,7 +744,7 @@ jobs:
sudo apt-get install -y curl unzip zip
- name: Set up QEMU for ${{ matrix.arch }} emulation
uses: docker/setup-qemu-action@v3
uses: docker/setup-qemu-action@v4
- name: Download amd64 bundle
uses: actions/download-artifact@v8
@@ -616,11 +770,77 @@ jobs:
popd > /dev/null
rm -rf "$TMP"
fi
# The official node:${NODE_VERSION} Docker image only publishes amd64,
# arm64 and ppc64le manifests — no s390x, no riscv64 — so
# `docker run --platform linux/s390x node:24-slim` fails with "no matching
# manifest". Instead build on an ubuntu:26.04 base (which publishes every
# arch) and install the Node.js binary tarball inside the emulated
# container: ppc64le/s390x from nodejs.org (official), riscv64 from
# unofficial-builds.nodejs.org (nodejs.org ships no riscv64). Resolve the
# exact latest ${NODE_VERSION}.x version on the host (fast, no emulation)
# and pass it in along with which mirror to use.
NODE_FULL=$(curl -fsSL https://nodejs.org/dist/index.json \
| python3 -c "import json,sys; print(next(r['version'] for r in json.load(sys.stdin) if r['version'].startswith('v${NODE_VERSION}.')))")
echo "Using Node ${NODE_FULL} (${{ matrix.node_base }}) for ${{ matrix.arch }}"
docker run --rm --platform ${{ matrix.platform }} \
-e NODE_FULL="$NODE_FULL" -e ARCH="${{ matrix.arch }}" \
-e NODE_BASE="${{ matrix.node_base }}" \
-v "$(pwd)/bundle:/bundle" \
-w /bundle/programs/server \
node:${NODE_VERSION}-slim \
sh -c "apt-get update -qq && apt-get install -y -q build-essential python3 && npm install"
ubuntu:26.04 \
bash -c '
set -eux
apt-get update -qq
apt-get install -y -q build-essential python3 curl xz-utils ca-certificates
if [ "$NODE_BASE" = unofficial ]; then
NODE_URL="https://unofficial-builds.nodejs.org/download/release/${NODE_FULL}/node-${NODE_FULL}-linux-${ARCH}.tar.xz"
else
NODE_URL="https://nodejs.org/dist/${NODE_FULL}/node-${NODE_FULL}-linux-${ARCH}.tar.xz"
fi
curl -fsSL -o /tmp/node.tar.xz "$NODE_URL"
mkdir -p /opt/node
tar -xJf /tmp/node.tar.xz -C /opt/node --strip-components=1
export PATH=/opt/node/bin:$PATH
node --version
npm install
# Bundle the target-arch Node.js binary for the self-contained
# launcher. /bundle is the host bundle/ dir (see -v mount above).
cp /opt/node/bin/node /bundle/node
chmod +x /bundle/node
# #6458: replace the inherited amd64 qemu-user with THIS arch own
# same-arch qemu-user (from the target-arch distro, so it runs on
# this arch), used by bundle/cpu-exec to emulate CPU features a
# binary needs but the host CPU lacks. Tolerant: if the package
# is unavailable on this arch, the bundle just ships without it
# (cpu-exec then falls back to a system qemu-user, or reports).
rm -f /bundle/qemu-x86_64
if apt-get install -y -q qemu-user-static >/dev/null 2>&1 && \
[ -x "/usr/bin/qemu-$(uname -m)-static" ]; then
cp "/usr/bin/qemu-$(uname -m)-static" "/bundle/qemu-$(uname -m)"
chmod +x "/bundle/qemu-$(uname -m)"
echo "Bundled qemu-$(uname -m) for cpu-exec."
else
echo "qemu-user-static not available for $(uname -m); bundle ships without a bundled qemu-user."
fi
'
- name: Embed FerretDB (${{ matrix.arch }}) into the bundle
# These arches have no MongoDB server, so FerretDB is their default DB.
# The launcher (start-wekan.sh) is inherited from the amd64 base bundle;
# download only this arch's binary from the newest wekan/FerretDB release.
# A marker file makes FerretDB the default backend at runtime (see the
# launcher + Docker entrypoint).
run: |
curl -fSL --retry 5 --retry-delay 10 -o bundle/ferretdb \
"https://github.com/wekan/FerretDB/releases/latest/download/ferretdb-${{ matrix.arch }}"
chmod +x bundle/ferretdb
# Overwrite the inherited amd64 MongoDB Database Tools with this arch's ones.
MT="https://github.com/wekan/mongo-tools/releases/latest/download"
for t in bsondump mongodump mongoexport mongofiles mongoimport mongorestore mongostat mongotop; do
curl -fSL --retry 5 --retry-delay 10 -o "bundle/$t" "$MT/$t-${{ matrix.arch }}"
chmod +x "bundle/$t"
done
touch bundle/.ferretdb-default
- name: Create ${{ matrix.arch }} zip
run: zip -r wekan-${VERSION}-${{ matrix.arch }}.zip bundle
@@ -639,18 +859,142 @@ jobs:
GH_REPO: ${{ github.repository }}
run: gh release upload "v${VERSION}" "wekan-${VERSION}-${{ matrix.arch }}.zip" --clobber
# ─── 7c. Build the Sandstorm .spk and attach it to the Release ───────────────
# Same steps as the standalone sandstorm.yml workflow (kept for building/testing
# the .spk on its own without a full release); here it builds from the release
# tag and attaches wekan-<version>-sandstorm.spk to the GitHub Release.
#
# EXPERIMENTAL in CI (same caveats as sandstorm.yml):
# * Sandstorm needs unprivileged user namespaces; GitHub's Ubuntu runners are VMs
# that allow them, but this is the fragile part.
# * meteor-spk SIGNS the .spk with the app private key from the Sandstorm keyring;
# provide it as the SANDSTORM_KEYRING secret (base64 of ~/.sandstorm-keyring).
#
# continue-on-error: the experimental Sandstorm build must NOT fail the release;
# like the other post-`release` bundle jobs it only attaches its artifact.
build-sandstorm:
needs: [prepare, release]
continue-on-error: true
runs-on: ubuntu-24.04
timeout-minutes: 120
env:
VERSION: ${{ needs.prepare.outputs.version }}
steps:
- uses: actions/checkout@v7
with:
ref: refs/tags/v${{ needs.prepare.outputs.version }}
- uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
- name: Enable unprivileged user namespaces (Ubuntu 24.04 restricts them)
# Ubuntu 24.04's AppArmor defaults kernel.apparmor_restrict_unprivileged_userns=1,
# which blocks the unprivileged user namespaces that the Sandstorm install and
# the spk supervisor rely on (the "fragile part" noted above). Relax it so
# `install.sandstorm.io` and meteor-spk can create sandboxes on the runner.
# `|| true`: on kernels/runners without these knobs, setting them is a no-op.
run: |
sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0 || true
sudo sysctl -w kernel.unprivileged_userns_clone=1 2>/dev/null || true
- name: Install system dependencies and Meteor
run: |
sudo apt-get update
sudo apt-get install -y p7zip-full wget curl build-essential g++ make python3 unzip xz-utils git qemu-user-static
if [ ! -f "$HOME/.meteor/meteor" ]; then curl https://install.meteor.com/ | sh; fi
echo "$HOME/.meteor" >> "$GITHUB_PATH"
- name: Install Sandstorm (dev, unattended)
# Installed BEFORE assembling the deps: build-deps.sh's [bridge] step copies
# the modern /opt/sandstorm/latest/bin/sandstorm-http-bridge over the ancient
# bundled one, so the Sandstorm install must be in place first.
run: curl https://install.sandstorm.io | sudo bash -s -- -d
- name: Assemble modern meteor-spk.deps (Node 24 + FerretDB + Mongo 3.x CLIs)
# Base = upstream meteor-spk 0.6.0 from dl.sandstorm.io (has mongod 3.0 +
# niscud). build-deps.sh swaps in Node 24, adds FerretDB + the Mongo 3.x
# CLIs + the migration launcher/importer, keeps niscud, and swaps in the
# modern sandstorm-http-bridge from the Sandstorm install above. No dependency
# on the retired releases.wekan.team or the old projects.7z.
run: |
bash sandstorm-src/build-deps.sh
echo "$HOME/projects/meteor-spk/meteor-spk-0.6.0" >> "$GITHUB_PATH"
- name: Restore the Sandstorm signing keyring
env:
SANDSTORM_KEYRING: ${{ secrets.SANDSTORM_KEYRING }}
run: |
if [ -n "${SANDSTORM_KEYRING:-}" ]; then
# meteor-spk / spk read the app signing key from ~/.sandstorm-keyring —
# a FILE directly in $HOME (see the pack crash path
# "/home/runner/.sandstorm-keyring"). Write it exactly there, NOT to
# ~/.sandstorm/sandstorm-keyring, or `meteor-spk pack` aborts with
# "open(~/.sandstorm-keyring): No such file or directory".
printf '%s' "$SANDSTORM_KEYRING" | base64 -d > "$HOME/.sandstorm-keyring"
chmod 600 "$HOME/.sandstorm-keyring"
echo "Restored ~/.sandstorm-keyring ($(wc -c < "$HOME/.sandstorm-keyring") bytes)."
else
echo "::error::SANDSTORM_KEYRING secret is not set. meteor-spk pack signs the .spk with the WeKan Sandstorm app's private key, which lives in this keyring, so packing cannot proceed without it. Add the base64 of your ~/.sandstorm-keyring file as the SANDSTORM_KEYRING repository secret (e.g. 'base64 -w0 ~/.sandstorm-keyring')."
exit 1
fi
- name: Install Meteor npm dependencies
# PUPPETEER_SKIP_DOWNLOAD: puppeteer is a devDependency used only by tests,
# not by the server, so it never belongs in the packed .spk. Skipping its
# Chromium download (~150 MB) avoids any risk of it bloating the build and
# speeds up CI.
env:
PUPPETEER_SKIP_DOWNLOAD: '1'
run: |
(meteor update --npm 2>/dev/null || true) && meteor npm install
- name: Build the Sandstorm .spk
id: build
env:
PUPPETEER_SKIP_DOWNLOAD: '1'
run: |
set -euo pipefail
# Version-named (not timestamped like sandstorm.yml): the release re-runs
# idempotently with --clobber replacing the same asset.
SPK="wekan-${VERSION}-sandstorm.spk"
meteor-spk pack "$SPK"
# Report the packed size and warn if it exceeds Cloudflare's 100 MB upload
# cap (a proxied browser upload to a Cloudflare-fronted Sandstorm 413s above
# this; install via a DNS-only host / SSH tunnel, or trim further).
SPK_BYTES=$(stat -c%s "$SPK")
echo "Packed $SPK: $((SPK_BYTES/1024/1024)) MiB ($SPK_BYTES bytes)"
if [ "$SPK_BYTES" -gt $((100*1024*1024)) ]; then
echo "::warning::$SPK is $((SPK_BYTES/1024/1024)) MiB — over Cloudflare's 100 MB upload limit. Upload via a DNS-only host / SSH tunnel to Sandstorm, or trim the bundle further."
fi
ls -la "$SPK"
echo "spk=$SPK" >> "$GITHUB_OUTPUT"
- uses: actions/upload-artifact@v7
with:
name: ${{ steps.build.outputs.spk }}
path: ${{ steps.build.outputs.spk }}
retention-days: 7
- name: Attach the .spk to the GitHub Release
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: gh release upload "v${VERSION}" "${{ steps.build.outputs.spk }}" --clobber
# ─── 8. Build and push the multi-arch Docker image to all registries ────────
# Mirrors releases/docker-build.sh step 3 (multi-arch buildx --push).
# Needs `release` because the Dockerfile downloads wekan-<version>-<arch>.zip
# from the GitHub Release; building before those assets exist 404s and (without
# set -e in the Dockerfile) shipped a broken image missing /build/main.js.
# set -e in the Dockerfile) shipped a broken image missing /build/main.js. Also
# needs `build-extra-arches` because the image now covers ppc64le/s390x/riscv64,
# whose zips (with FerretDB baked in) are attached by that job after `release`.
docker:
needs: [prepare, release]
needs: [prepare, release, build-extra-arches]
runs-on: ubuntu-latest
env:
VERSION: ${{ needs.prepare.outputs.version }}
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v7
with:
ref: refs/tags/v${{ needs.prepare.outputs.version }}
@@ -683,14 +1027,14 @@ jobs:
# Release for each built platform. Even though this job needs `release`
# (so the assets are uploaded), GitHub's releases/download/<tag>/<asset>
# URL can briefly 404 right after upload (CDN/propagation lag), which used
# to fail the multi-arch build mid-way. Poll here until both the amd64 and
# arm64 bundles return 200, so the (expensive, emulated) buildx run only
# starts once the assets are actually fetchable. The Dockerfile also
# to fail the multi-arch build mid-way. Poll here until every arch bundle
# baked into the image returns 200, so the (expensive, emulated) buildx run
# only starts once the assets are actually fetchable. The Dockerfile also
# retries per-arch as a second layer of safety.
run: |
set -euo pipefail
base="https://github.com/wekan/wekan/releases/download/v${VERSION}"
for arch in amd64 arm64; do
for arch in amd64 arm64 ppc64le s390x riscv64; do
url="${base}/wekan-${VERSION}-${arch}.zip"
echo "Waiting for ${url} ..."
ok=0
@@ -714,33 +1058,49 @@ jobs:
# Belt-and-suspenders against the "image tagged vX shows vY in the Admin
# Panel" bug: the image is just the unzipped wekan-<version>-<arch>.zip
# bundle (Dockerfile moves it to /build), and the Admin Panel shows that
# bundle's app package.json version (server/statistics.js reads
# require('/package.json').version). Assert the amd64 bundle's WeKan
# version equals the release version BEFORE the expensive multi-arch
# buildx, so a stale/mismatched bundle fails fast with a clear message
# instead of shipping (and pushing to three registries) a mislabeled image.
# bundle's WeKan version (server/statistics.js reads
# require('/package.json').version). Check the amd64 bundle's WeKan version
# equals the release version BEFORE the expensive multi-arch buildx, so a
# stale/mismatched bundle fails fast instead of shipping (and pushing to
# three registries) a mislabeled image.
#
# Meteor does NOT ship the app package.json as a standalone file — it
# inlines it into the compiled bundle/programs/server/app/app.js as a JSON
# module, e.g. {"name":"wekan","version":"v9.63.0",...}. That inlined
# module (anchored on "name":"wekan") is exactly what require('/package.json')
# resolves to at runtime, so it is the authoritative thing to check.
#
# IMPORTANT: only a CONFIRMED mismatch fails the release. If the version
# cannot be located (bundle layout changed, app.js minified differently),
# warn and continue — inability to verify must not block a good release,
# since --build-arg VERSION below is the actual guarantee. (An earlier
# version of this guard grepped for a v-prefixed *package.json* and made
# "not found" fatal, which false-failed the whole v9.63 docker build.)
run: |
set -euo pipefail
url="https://github.com/wekan/wekan/releases/download/v${VERSION}/wekan-${VERSION}-amd64.zip"
wget -q "$url" -O bundle.zip
tmp="$(mktemp -d)"
# Extract only package.json files (not the whole multi-hundred-MB bundle).
unzip -o -q bundle.zip '*package.json' -d "$tmp"
# The WeKan app package.json is the only one whose "version" carries a
# leading 'v' (e.g. "v9.61.0"); every dependency uses plain semver. So a
# v-prefixed "version" uniquely identifies the app's own package.json.
found="$(grep -rhoE '"version": "v[0-9][^"]*"' "$tmp" \
| grep -oE 'v[0-9][^"]*' | sort -u | head -1 || true)"
# Extract only the compiled app program (not the whole multi-hundred-MB
# bundle); the inlined app package.json lives in app/app.js.
unzip -o -q bundle.zip 'bundle/programs/server/app/app.js' -d "$tmp" || true
appjs="$tmp/bundle/programs/server/app/app.js"
found=""
if [ -f "$appjs" ]; then
match="$(grep -aoE '"name":"wekan","version":"v?[0-9][^"]*"' "$appjs" | head -1 || true)"
found="$(printf '%s' "$match" | sed -E 's/.*"version":"([^"]*)".*/\1/')"
fi
rm -rf "$tmp" bundle.zip
if [ -z "$found" ]; then
echo "::error::Could not find a v-prefixed WeKan version in the bundle's package.json files."
echo "::warning::Could not locate the WeKan version in the bundle (app.js layout may have changed); skipping the bundle-version check. --build-arg VERSION still guarantees the correct bundle."
exit 0
fi
norm="${found#v}"
if [ "$norm" != "${VERSION}.0" ] && [ "$norm" != "${VERSION}" ]; then
echo "::error::Bundle reports app version ${found} but the release is v${VERSION}. The bundle baked into the image is stale/mismatched — the Admin Panel would show ${norm}. Aborting before build."
exit 1
fi
if [ "$found" != "v${VERSION}.0" ] && [ "$found" != "v${VERSION}" ]; then
echo "::error::Bundle reports app version $found but the release is v${VERSION}. The bundle baked into the image is stale/mismatched — the Admin Panel would show $found. Aborting before build."
exit 1
fi
echo "Bundle app version $found matches release v${VERSION}."
echo "Bundle app version ${found} matches release v${VERSION}."
- name: Build and push multi-arch image
# Pass VERSION explicitly as a build-arg. The Dockerfile's `ARG VERSION`
@@ -751,7 +1111,7 @@ jobs:
# report in the Admin Panel — a stale, different version.
run: |
docker buildx build \
--platform linux/amd64,linux/arm64 \
--platform linux/amd64,linux/arm64,linux/ppc64le,linux/s390x,linux/riscv64 \
--build-arg VERSION=${VERSION} \
-t wekanteam/wekan:v${VERSION} \
-t wekanteam/wekan:latest \
@@ -764,23 +1124,107 @@ jobs:
# ─── 9. Build the snap on Launchpad, push to the store, attach to release ────
# The snap's `wekan` part downloads wekan-<version>-<arch>.zip from the GitHub
# Release, so this job runs only after `release` has published those assets.
# `snapcraft remote-build` builds every platform listed in snapcraft.yaml
# (amd64 + arm64) on Launchpad.
snap:
# Release, so these jobs run only after `release` has published those assets.
#
# snap-native + snap-launchpad replace the old single `snap` job. The mainstream
# arches (amd64 + arm64) build NATIVELY on GitHub-hosted runners — fast, no
# Launchpad queue. The exotic arches (s390x, ppc64el, riscv64) have no native
# GitHub runners and snapcraft cannot cross-build, so they stay on Launchpad but
# in a NON-BLOCKING, per-arch matrix so a slow/failed arch (riscv64 queues for
# hours) never holds up the release or the other arches. Each arch publishes to
# the Snap Store (stable + candidate + beta + edge) and attaches to the Release the moment
# it finishes — all 5 arches, published independently.
snap-native:
needs: [prepare, release]
strategy:
fail-fast: false
matrix:
include:
- arch: amd64
runner: ubuntu-24.04
- arch: arm64
runner: ubuntu-24.04-arm
runs-on: ${{ matrix.runner }}
env:
VERSION: ${{ needs.prepare.outputs.version }}
steps:
- uses: actions/checkout@v7
with:
ref: refs/tags/v${{ needs.prepare.outputs.version }}
- name: Verify snapcraft.yaml version matches the release
# snapcraft.yaml's `version:` names the produced file (wekan_<version>_<arch>.snap).
# Assert it matches the tag so a stale version fails fast here.
run: |
set -euo pipefail
if ! grep -qxF "version: '${VERSION}'" snapcraft.yaml; then
echo "::error::snapcraft.yaml is not at version '${VERSION}' ($(grep -m1 '^version:' snapcraft.yaml)). The bump job (releases/version.sh) did not update the tagged commit."
exit 1
fi
echo "snapcraft.yaml is at version '${VERSION}'."
- name: Build the ${{ matrix.arch }} snap natively
# Runs on a native ${{ matrix.arch }} GitHub runner, so snapcraft builds the
# platform whose `build-on` matches this host — no Launchpad, no emulation.
id: build
uses: snapcore/action-build@v1
- name: Verify the built snap is ${{ matrix.arch }}
run: |
set -euo pipefail
snap="${{ steps.build.outputs.snap }}"
echo "Built: $snap"
case "$snap" in
*_${{ matrix.arch }}.snap) : ;;
*) echo "::error::Built snap '$snap' is not ${{ matrix.arch }}."; exit 1 ;;
esac
- name: Push ${{ matrix.arch }} to the Snap Store (stable + candidate + beta + edge)
uses: snapcore/action-publish@v1
env:
SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAP_AUTH }}
with:
snap: ${{ steps.build.outputs.snap }}
release: stable,candidate,beta,edge
- name: Attach the ${{ matrix.arch }} snap to the GitHub Release
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: gh release upload "v${VERSION}" "${{ steps.build.outputs.snap }}" --clobber
snap-launchpad:
needs: [prepare, release]
# continue-on-error: the exotic Launchpad arches must NOT hold up or fail the
# release. riscv64 in particular queues for hours / can time out; that must not
# turn the whole release red. fail-fast: false so one arch never cancels the
# others. Each leg publishes the moment it finishes.
continue-on-error: true
strategy:
fail-fast: false
matrix:
arch: [s390x, ppc64el, riscv64]
runs-on: ubuntu-latest
env:
VERSION: ${{ needs.prepare.outputs.version }}
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v7
with:
ref: refs/tags/v${{ needs.prepare.outputs.version }}
# remote-build (Launchpad) rejects shallow clones, so fetch full history
fetch-depth: 0
- name: Install snapcraft
run: sudo snap install snapcraft --classic
# The Snap Store intermittently rejects the install with a 429-style rate
# limit; retry so one transient throttle does not fail the build.
run: |
set -uo pipefail
for i in 1 2 3 4 5; do
sudo snap install snapcraft --classic && exit 0
echo "snapcraft install attempt $i/5 failed (Snap Store throttle?); retrying in 30s..."
sleep 30
done
echo "::error::snapcraft install failed after 5 attempts (Snap Store rate limit)."
exit 1
- name: Provide Launchpad credentials for remote-build
env:
@@ -791,15 +1235,6 @@ jobs:
chmod 600 ~/.local/share/snapcraft/launchpad-credentials
- name: Verify snapcraft.yaml version matches the release
# The `bump` job (releases/version.sh) is the single source of truth for
# the snap version and updates snapcraft.yaml before the tag is created.
# snapcraft.yaml's `version:` names the produced files
# (wekan_<version>_<arch>.snap), so if a stale tag carried the wrong
# version the build would produce wekan_<old>_*.snap and the upload/attach
# globs (wekan_${VERSION}_*.snap) would match nothing — passing the literal
# glob to `snapcraft upload` ("is not a valid file", exit 64). Assert it
# here so that mismatch fails fast (before a ~20 min Launchpad build) with
# a clear pointer, instead of re-bumping the version inside this build job.
run: |
set -euo pipefail
if ! grep -qxF "version: '${VERSION}'" snapcraft.yaml; then
@@ -808,31 +1243,26 @@ jobs:
fi
echo "snapcraft.yaml is at version '${VERSION}'."
- name: Build snaps on Launchpad (amd64 + arm64)
# `snapcraft remote-build` is experimental and talks to Launchpad over
# HTTPS after pushing the whole repo; it intermittently dies with a
# transient TLS drop (e.g. "SSLEOFError: EOF occurred in violation of
# protocol", exit 70) that has nothing to do with the build itself.
# Retry a few times so one network hiccup doesn't fail the release.
- name: Build the ${{ matrix.arch }} snap on Launchpad
# --build-for ${{ matrix.arch }}: build ONLY this leg's arch so a slow/failed
# arch never blocks the others. remote-build can exit 0 without producing a
# .snap (it just downloads logs), so require the file. Retry a few times to
# survive transient TLS drops to Launchpad.
run: |
set -uo pipefail
shopt -s nullglob
attempts=3
for i in $(seq 1 "$attempts"); do
echo "::group::Remote build attempt $i/$attempts"
snapcraft remote-build --launchpad-accept-public-upload && rc=0 || rc=$?
echo "::group::Remote build ${{ matrix.arch }} attempt $i/$attempts"
snapcraft remote-build --launchpad-accept-public-upload \
--build-for ${{ matrix.arch }} && rc=0 || rc=$?
echo "::endgroup::"
# snapcraft remote-build can exit 0 even when the Launchpad build
# FAILED (it just downloads the build logs and produces no .snap), so
# don't trust the exit code alone — require that .snap files exist.
snaps=( wekan_${VERSION}_*.snap )
snaps=( wekan_${VERSION}_${{ matrix.arch }}.snap )
if [ "$rc" -eq 0 ] && [ "${#snaps[@]}" -gt 0 ]; then
echo "Remote build succeeded on attempt $i: ${snaps[*]}"
echo "Remote build ${{ matrix.arch }} succeeded on attempt $i: ${snaps[*]}"
exit 0
fi
echo "Attempt $i: snapcraft exit=$rc, .snap files produced=${#snaps[@]}."
# Surface the Launchpad build logs so a real build failure is
# diagnosable here, instead of as a later cryptic upload error.
for log in snapcraft-wekan-*.txt; do
echo "::group::Launchpad build log: $log (last 150 lines)"
tail -n 150 "$log"
@@ -843,34 +1273,33 @@ jobs:
sleep 60
fi
done
echo "::error::Remote build failed after $attempts attempts (no wekan_${VERSION}_*.snap produced)." >&2
echo "::error::Remote build ${{ matrix.arch }} failed after $attempts attempts (no wekan_${VERSION}_${{ matrix.arch }}.snap produced)." >&2
exit 1
- name: Push snaps to the Snap Store (edge + beta channels)
- name: Push ${{ matrix.arch }} to the Snap Store (stable + candidate + beta + edge)
env:
SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAP_AUTH }}
run: |
set -euo pipefail
shopt -s nullglob
snaps=( wekan_${VERSION}_*.snap )
snaps=( wekan_${VERSION}_${{ matrix.arch }}.snap )
if [ "${#snaps[@]}" -eq 0 ]; then
echo "::error::No wekan_${VERSION}_*.snap files to upload."
echo "::error::No wekan_${VERSION}_${{ matrix.arch }}.snap to upload."
exit 1
fi
# base: core24 allows publishing to stable and candidate (core26 does not).
for f in "${snaps[@]}"; do
echo "Uploading $f to the Snap Store (edge,beta)..."
snapcraft upload --release=edge,beta "$f"
echo "Uploading $f to the Snap Store (stable,candidate,beta,edge)..."
snapcraft upload --release=stable,candidate,beta,edge "$f"
done
- name: Attach snaps to the GitHub Release
- name: Attach the ${{ matrix.arch }} snap to the GitHub Release
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -euo pipefail
shopt -s nullglob
snaps=( wekan_${VERSION}_*.snap )
if [ "${#snaps[@]}" -eq 0 ]; then
echo "::error::No wekan_${VERSION}_*.snap files to attach."
exit 1
snaps=( wekan_${VERSION}_${{ matrix.arch }}.snap )
if [ "${#snaps[@]}" -gt 0 ]; then
gh release upload "v${VERSION}" "${snaps[@]}" --clobber
fi
gh release upload "v${VERSION}" "${snaps[@]}" --clobber
+1 -1
View File
@@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v6
uses: actions/checkout@v7
with:
fetch-depth: 0
+145
View File
@@ -0,0 +1,145 @@
name: Publish .spk to Sandstorm App Market
# Manually triggered. Takes the Sandstorm .spk that sandstorm.yml already built and
# attached to a WeKan GitHub Release, renames it to wekan-<VERSION>.spk (VERSION is the
# WeKan release version, e.g. 9.88), and publishes it to the Sandstorm App Market with
# spk publish wekan-<VERSION>.spk
# exactly like releases/release-sandstorm.sh does locally.
#
# gh workflow run sandstorm-store.yml
# gh workflow run sandstorm-store.yml -f version=9.88
# gh workflow run sandstorm-store.yml -f version=9.88 -f tag=v9.88
#
# Needs SANDSTORM_KEYRING (base64 of ~/.sandstorm-keyring) — `spk publish` proves app
# ownership with the WeKan Sandstorm app's private key from that keyring — and installs
# Sandstorm + assembles meteor-spk the same way sandstorm.yml does, so `spk` is present.
# It does NOT rebuild the .spk; it publishes the one already on the release.
on:
workflow_dispatch:
inputs:
version:
description: 'WeKan version for the store filename wekan-<VERSION>.spk (e.g. 9.88). Default: derived from the release tag.'
required: false
default: ''
tag:
description: 'Release tag whose .spk to publish (default: newest release).'
required: false
default: ''
permissions:
contents: read
env:
NODE_VERSION: '24'
jobs:
sandstorm-store:
runs-on: ubuntu-24.04
timeout-minutes: 120
steps:
- uses: actions/checkout@v7
- uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
- name: Enable unprivileged user namespaces (Ubuntu 24.04 restricts them)
run: |
sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0 || true
sudo sysctl -w kernel.unprivileged_userns_clone=1 2>/dev/null || true
- name: Install system dependencies
run: |
sudo apt-get update
sudo apt-get install -y p7zip-full wget curl build-essential g++ make python3 unzip xz-utils git
- name: Install Sandstorm (dev, unattended)
# Provides the `spk` command used to publish, and the sandstorm-http-bridge that
# build-deps.sh copies into the meteor-spk deps.
run: curl https://install.sandstorm.io | sudo bash -s -- -d
- name: Assemble modern meteor-spk.deps (same as sandstorm.yml)
run: |
bash sandstorm-src/build-deps.sh
echo "$HOME/projects/meteor-spk/meteor-spk-0.6.0" >> "$GITHUB_PATH"
- name: Restore the Sandstorm signing keyring
env:
SANDSTORM_KEYRING: ${{ secrets.SANDSTORM_KEYRING }}
run: |
if [ -n "${SANDSTORM_KEYRING:-}" ]; then
# spk publish reads the app signing key from ~/.sandstorm-keyring (a FILE in
# $HOME), same location meteor-spk pack uses.
printf '%s' "$SANDSTORM_KEYRING" | base64 -d > "$HOME/.sandstorm-keyring"
chmod 600 "$HOME/.sandstorm-keyring"
echo "Restored ~/.sandstorm-keyring ($(wc -c < "$HOME/.sandstorm-keyring") bytes)."
else
echo "::error::SANDSTORM_KEYRING secret is not set. 'spk publish' proves ownership of the WeKan Sandstorm app with the private key from this keyring, so publishing cannot proceed without it. Add the base64 of your ~/.sandstorm-keyring file as the SANDSTORM_KEYRING repository secret (e.g. 'base64 -w0 ~/.sandstorm-keyring')."
exit 1
fi
- name: Download the newest .spk from the WeKan release and name it wekan-<VERSION>.spk
id: fetch
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_REPO: ${{ github.repository }}
IN_TAG: ${{ github.event.inputs.tag }}
IN_VERSION: ${{ github.event.inputs.version }}
run: |
set -euo pipefail
# 1) Which release to publish from.
TAG="${IN_TAG:-}"
if [ -z "$TAG" ]; then
TAG="$(gh release list --limit 1 --json tagName --jq '.[0].tagName' 2>/dev/null || true)"
fi
if [ -z "${TAG:-}" ] || [ "$TAG" = "null" ]; then
echo "::error::No release found to publish the .spk from."
exit 1
fi
# 2) VERSION for the store filename wekan-<VERSION>.spk. Use the input, else
# derive it from the tag (strip a leading 'v', e.g. v9.88 -> 9.88).
VERSION="${IN_VERSION:-}"
if [ -z "$VERSION" ]; then
VERSION="${TAG#v}"
fi
echo "Release: $TAG -> store filename: wekan-${VERSION}.spk"
# 3) Download the newest .spk asset on that release. sandstorm.yml attaches it
# as wekan-sandstorm-YYYY_MM_DD-HH_MM_SS.spk; if several exist, take the
# lexicographically-newest (the timestamp sorts chronologically).
ASSET="$(gh release view "$TAG" --json assets \
--jq '[.assets[].name | select(endswith(".spk"))] | sort | last' 2>/dev/null || true)"
if [ -z "${ASSET:-}" ] || [ "$ASSET" = "null" ]; then
echo "::error::Release $TAG has no .spk asset. Run sandstorm.yml first to build and attach one."
exit 1
fi
echo "Downloading .spk asset: $ASSET"
gh release download "$TAG" --pattern "$ASSET" --dir . --clobber
SPK="wekan-${VERSION}.spk"
mv -f "$ASSET" "$SPK"
ls -la "$SPK"
echo "spk=$SPK" >> "$GITHUB_OUTPUT"
- name: Publish to the Sandstorm App Market
env:
SPK: ${{ steps.fetch.outputs.spk }}
run: |
set -euo pipefail
# Resolve the spk binary: prefer PATH, then the Sandstorm install location.
SPK_BIN="$(command -v spk || true)"
if [ -z "$SPK_BIN" ]; then
for c in /opt/sandstorm/latest/bin/spk /opt/sandstorm/spk /usr/local/bin/spk; do
[ -x "$c" ] && SPK_BIN="$c" && break
done
fi
if [ -z "$SPK_BIN" ]; then
echo "::error::Could not find the 'spk' command from the Sandstorm install."
exit 1
fi
echo "Publishing $SPK with $SPK_BIN ..."
# Same command as releases/release-sandstorm.sh: spk publish wekan-<VERSION>.spk
"$SPK_BIN" publish "$SPK"
+144
View File
@@ -0,0 +1,144 @@
name: Build Sandstorm .spk
# Manually triggered. Builds ONLY the Sandstorm .spk package (nothing else) and
# uploads it as wekan-sandstorm-YYYY_MM_DD-HH_MM_SS.spk to the NEWEST WeKan GitHub
# Release as an attachment, so you can download it, test whether the Sandstorm
# build works, and see any errors — without running a full release.
#
# gh workflow run sandstorm.yml
#
# EXPERIMENTAL in CI (same caveats as the build-sandstorm job in release-all.yml):
# * Sandstorm needs unprivileged user namespaces; GitHub's Ubuntu runners are VMs
# that allow them, but this is the fragile part.
# * meteor-spk SIGNS the .spk with the app private key from the Sandstorm keyring;
# provide it as the SANDSTORM_KEYRING secret (base64 of ~/.sandstorm keyring).
on:
workflow_dispatch:
inputs:
ref:
description: 'Branch, tag or SHA to build the .spk from (default: main)'
required: false
default: 'main'
permissions:
contents: write
env:
NODE_VERSION: '24'
jobs:
sandstorm:
runs-on: ubuntu-24.04
timeout-minutes: 120
steps:
- uses: actions/checkout@v7
with:
# Build the dispatched ref so a fix branch can be tested before it is
# merged to main; defaults to main for a plain `gh workflow run`.
ref: ${{ github.event.inputs.ref || 'main' }}
- uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
- name: Enable unprivileged user namespaces (Ubuntu 24.04 restricts them)
# Ubuntu 24.04's AppArmor defaults kernel.apparmor_restrict_unprivileged_userns=1,
# which blocks the unprivileged user namespaces that the Sandstorm install and
# the spk supervisor rely on (the "fragile part" noted above). Relax it so
# `install.sandstorm.io` and meteor-spk can create sandboxes on the runner.
# `|| true`: on kernels/runners without these knobs, setting them is a no-op.
run: |
sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0 || true
sudo sysctl -w kernel.unprivileged_userns_clone=1 2>/dev/null || true
- name: Install system dependencies and Meteor
run: |
sudo apt-get update
sudo apt-get install -y p7zip-full wget curl build-essential g++ make python3 unzip xz-utils git qemu-user-static
if [ ! -f "$HOME/.meteor/meteor" ]; then curl https://install.meteor.com/ | sh; fi
echo "$HOME/.meteor" >> "$GITHUB_PATH"
- name: Install Sandstorm (dev, unattended)
# Installed BEFORE assembling the deps: build-deps.sh's [bridge] step copies
# the modern /opt/sandstorm/latest/bin/sandstorm-http-bridge over the ancient
# bundled one, so the Sandstorm install must be in place first.
run: curl https://install.sandstorm.io | sudo bash -s -- -d
- name: Assemble modern meteor-spk.deps (Node 24 + FerretDB + Mongo 3.x CLIs)
# Base = upstream meteor-spk 0.6.0 from dl.sandstorm.io (has mongod 3.0 +
# niscud). build-deps.sh swaps in Node 24, adds FerretDB + the Mongo 3.x
# CLIs + the migration launcher/importer, keeps niscud, and swaps in the
# modern sandstorm-http-bridge from the Sandstorm install above. No dependency
# on the retired releases.wekan.team or the old projects.7z.
run: |
bash sandstorm-src/build-deps.sh
echo "$HOME/projects/meteor-spk/meteor-spk-0.6.0" >> "$GITHUB_PATH"
- name: Restore the Sandstorm signing keyring
env:
SANDSTORM_KEYRING: ${{ secrets.SANDSTORM_KEYRING }}
run: |
if [ -n "${SANDSTORM_KEYRING:-}" ]; then
# meteor-spk / spk read the app signing key from ~/.sandstorm-keyring —
# a FILE directly in $HOME (see the pack crash path
# "/home/runner/.sandstorm-keyring"). Write it exactly there, NOT to
# ~/.sandstorm/sandstorm-keyring, or `meteor-spk pack` aborts with
# "open(~/.sandstorm-keyring): No such file or directory".
printf '%s' "$SANDSTORM_KEYRING" | base64 -d > "$HOME/.sandstorm-keyring"
chmod 600 "$HOME/.sandstorm-keyring"
echo "Restored ~/.sandstorm-keyring ($(wc -c < "$HOME/.sandstorm-keyring") bytes)."
else
echo "::error::SANDSTORM_KEYRING secret is not set. meteor-spk pack signs the .spk with the WeKan Sandstorm app's private key, which lives in this keyring, so packing cannot proceed without it. Add the base64 of your ~/.sandstorm-keyring file as the SANDSTORM_KEYRING repository secret (e.g. 'base64 -w0 ~/.sandstorm-keyring')."
exit 1
fi
- name: Install Meteor npm dependencies
# PUPPETEER_SKIP_DOWNLOAD: puppeteer is a devDependency used only by tests,
# not by the server, so it never belongs in the packed .spk. Skipping its
# Chromium download (~150 MB) avoids any risk of it bloating the build and
# speeds up CI.
env:
PUPPETEER_SKIP_DOWNLOAD: '1'
run: |
(meteor update --npm 2>/dev/null || true) && meteor npm install
- name: Build the Sandstorm .spk
id: build
env:
PUPPETEER_SKIP_DOWNLOAD: '1'
run: |
set -euo pipefail
STAMP="$(date +'%Y_%m_%d-%H_%M_%S')"
SPK="wekan-sandstorm-${STAMP}.spk"
meteor-spk pack "$SPK"
# Report the packed size and warn if it exceeds Cloudflare's 100 MB upload
# cap (a proxied browser upload to a Cloudflare-fronted Sandstorm 413s above
# this; install via a DNS-only host / SSH tunnel, or trim further).
SPK_BYTES=$(stat -c%s "$SPK")
echo "Packed $SPK: $((SPK_BYTES/1024/1024)) MiB ($SPK_BYTES bytes)"
if [ "$SPK_BYTES" -gt $((100*1024*1024)) ]; then
echo "::warning::$SPK is $((SPK_BYTES/1024/1024)) MiB — over Cloudflare's 100 MB upload limit. Upload via a DNS-only host / SSH tunnel to Sandstorm, or trim the bundle further."
fi
ls -la "$SPK"
echo "spk=$SPK" >> "$GITHUB_OUTPUT"
- uses: actions/upload-artifact@v7
with:
name: ${{ steps.build.outputs.spk }}
path: ${{ steps.build.outputs.spk }}
retention-days: 7
- name: Upload the .spk to the newest WeKan release
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_REPO: ${{ github.repository }}
run: |
set -euo pipefail
TAG="$(gh release list --limit 1 --json tagName --jq '.[0].tagName' 2>/dev/null || true)"
if [ -z "${TAG:-}" ] || [ "$TAG" = "null" ]; then
echo "::error::No existing GitHub Release found to attach the .spk to."
exit 1
fi
echo "Uploading ${{ steps.build.outputs.spk }} to the newest release: $TAG"
gh release upload "$TAG" "${{ steps.build.outputs.spk }}" --clobber
+14
View File
@@ -70,3 +70,17 @@ test-results/
_build-local-test
*/build-assets-local-test
*/build-chunks-local-test
# Local-only working copies: other wekan repos cloned under this repo for editing,
# and build inputs. These are separate git repos / large machine-specific dirs;
# never commit them.
# - projects/ : unarchived meteor-spk fork (Node/Mongo/FerretDB binaries)
# - sandstorm/ : clone of sandstorm-io/sandstorm (platform source, for reference)
# - FerretDB/ : clone of wekan/FerretDB
# - mongo-tools/ : clone of wekan/mongo-tools
# - mongosh/ : clone of wekan/mongosh
/projects/
/sandstorm/
/FerretDB/
/mongo-tools/
/mongosh/
+8 -8
View File
@@ -6,7 +6,7 @@
meteor-base@1.5.2
# Build system
ecmascript@0.18.0
ecmascript@0.18.1
standard-minifier-js@3.2.0
rspack@1.1.0
@@ -16,11 +16,11 @@ blaze@3.0.2
aldeed:collection2
aldeed:schema-index@4.0.0-beta.5
reywood:publish-composite
mongo@2.4.0-rc350.1
mongo@2.4.0
# Account system
accounts-password@3.3.0-rc350.1
accounts-express@1.0.0-rc350.1
accounts-password@3.3.0
accounts-express@1.0.0
communitypackages:core
communitypackages:unstyled
communitypackages:flow-routing
@@ -37,7 +37,7 @@ wekan-accounts-oidc
check@1.5.0
random@1.2.2
reactive-dict@1.3.2
session@1.2.3-rc350.1
session@1.2.3
tracker@1.3.4
audit-argument-checks@1.0.8
@@ -45,7 +45,7 @@ audit-argument-checks@1.0.8
ostrio:i18n
reactive-var@1.0.13
shell-server@0.7.0
email@3.2.0-rc350.1
email@3.2.0
dynamic-import@0.7.4
wekan-markdown
quave:synced-cron
@@ -55,8 +55,8 @@ ostrio:files
meteortesting:mocha@3.0.0
matb33:collection-hooks
service-configuration@1.3.5
minifier-css@2.0.2-rc350.1
ejson@1.2.0-rc350.1
minifier-css@2.0.2
ejson@1.2.0
logging@1.3.6
wekan-fullcalendar
wekan-fontawesome
+1 -1
View File
@@ -1 +1 @@
METEOR@3.5-rc.1
METEOR@3.5
+28 -28
View File
@@ -1,44 +1,44 @@
accounts-base@3.3.0-rc350.1
accounts-express@1.0.0-rc350.1
accounts-oauth@1.4.7-rc350.1
accounts-password@3.3.0-rc350.1
accounts-base@3.3.0
accounts-express@1.0.0
accounts-oauth@1.4.7
accounts-password@3.3.0
aldeed:collection2@4.2.0
aldeed:schema-index@4.0.0
aldeed:simple-schema@1.13.1
allow-deny@2.1.0
audit-argument-checks@1.0.8
autoupdate@2.0.1
babel-compiler@7.14.0
babel-compiler@7.14.1
babel-runtime@1.5.2
base64@1.0.14-rc350.1
binary-heap@1.0.13-rc350.1
base64@1.0.14
binary-heap@1.0.13
blaze@3.0.3
blaze-tools@2.0.1
boilerplate-generator@2.1.0
caching-compiler@2.0.1
caching-html-compiler@2.0.1
callback-hook@1.8.0-rc350.1
callback-hook@1.8.0
check@1.5.0
communitypackages:core@2.0.3
communitypackages:flow-routing@2.1.0
communitypackages:unstyled@2.0.1
core-runtime@1.0.0
ddp@1.4.2
ddp-client@3.3.0-rc350.1
ddp-common@1.4.5-rc350.1
ddp-rate-limiter@1.3.0-rc350.1
ddp-server@3.3.0-rc350.1
ddp-client@3.3.0
ddp-common@1.4.5
ddp-rate-limiter@1.3.0
ddp-server@3.3.0
diff-sequence@1.1.3
dynamic-import@0.7.4
ecmascript@0.18.0
ecmascript@0.18.1
ecmascript-runtime@0.8.3
ecmascript-runtime-client@0.13.0
ecmascript-runtime-server@0.11.1
ejson@1.2.0-rc350.1
email@3.2.0-rc350.1
ejson@1.2.0
email@3.2.0
es5-shim@4.8.1
facts-base@1.0.2
fetch@0.2.0-rc350.1
fetch@0.2.0
geojson-utils@1.0.12
hot-code-push@1.0.5
html-tools@2.0.1
@@ -53,23 +53,23 @@ lai:collection-extensions@1.0.0
localstorage@1.2.1
logging@1.3.6
matb33:collection-hooks@2.1.0
meteor@2.3.1-rc350.1
meteor@2.3.1
meteor-base@1.5.2
meteortesting:browser-tests@1.8.0
meteortesting:mocha@3.3.0
meteortesting:mocha-core@8.2.0
minifier-css@2.0.2-rc350.1
minifier-js@3.2.0
minimongo@2.2.0-rc350.1
minifier-css@2.0.2
minifier-js@3.2.1
minimongo@2.2.0
modern-browsers@0.2.3
modules@0.20.3
modules-runtime@0.13.2
mongo@2.4.0-rc350.1
mongo@2.4.0
mongo-decimal@0.2.0
mongo-dev-server@1.1.1
mongo-id@1.0.9
npm-mongo@6.16.1
oauth@3.0.4-rc350.1
oauth@3.0.4
oauth2@1.3.3
observe-sequence@2.0.1
ordered-dict@1.2.0
@@ -82,7 +82,7 @@ promise@1.0.0
quave:synced-cron@2.4.0
raix:eventemitter@1.0.0
random@1.2.2
rate-limit@1.2.0-rc350.1
rate-limit@1.2.0
react-fast-refresh@0.3.0
reactive-dict@1.3.2
reactive-var@1.0.13
@@ -92,10 +92,10 @@ reywood:publish-composite@1.9.0
routepolicy@1.1.2
rspack@1.1.0
service-configuration@1.3.5
session@1.2.3-rc350.1
session@1.2.3
sha@1.0.10
shell-server@0.7.0
socket-stream-client@0.7.0-rc350.1
socket-stream-client@0.7.0
spacebars@2.0.1
spacebars-compiler@2.0.1
standard-minifier-js@3.2.0
@@ -105,9 +105,9 @@ templating-runtime@2.0.2
templating-tools@2.0.1
tools-core@1.1.0
tracker@1.3.4
typescript@5.10.0
url@1.3.6-rc350.1
webapp@2.2.0-rc350.1
typescript@5.10.1
url@1.3.6
webapp@2.2.0
webapp-hashing@1.1.2
wekan-accounts-cas@0.2.0
wekan-accounts-lockout@1.1.0
+8 -1
View File
@@ -1,2 +1,9 @@
npm-packages/
tests/
# Root tests/ holds Playwright specs, Node E2E and node-based unit tests - none
# of it is Meteor code, and Meteor's file watcher otherwise churns on the
# tests/playwright/test-results/ tree (inotify errors). The leading slash anchors
# this to the repo root only, so it does NOT match server/lib/tests/ or
# client/lib/tests/ (the Mocha suites, loaded via meteor.testModule in
# package.json). A naked "tests/" would match a dir named tests at any depth and
# would hide those suites, making `meteor test` report "0 passing".
/tests/
+1 -1
View File
@@ -1,6 +1,6 @@
[main]
host = https://www.transifex.com
lang_map = te_IN: te-IN, es_AR: es-AR, es_419: es-LA, es_TX: es-TX, he_IL: he-IL, zh_CN: zh-CN, ar_EG: ar-EG, cs_CZ: cs-CZ, fa_IR: fa-IR, ms_MY: ms-MY, nl_NL: nl-NL, de_CH: de-CH, en_IT: en-IT, uz_UZ: uz-UZ, fr_CH: fr-CH, hi_IN: hi-IN, et_EE: et-EE, es_PE: es-PE, es_MX: es-MX, gl_ES: gl-ES, mn_MN: mn, zh_TW: zh-TW, ast_ES: ast-ES, es_CL: es-CL, ja_JP: ja, lv_LV: lv, ro_RO: ro-RO, az_AZ: az-AZ, cy_GB: cy-GB, gu_IN: gu-IN, pl_PL: pl-PL, vep: ve-PP, en_BR: en-BR, en@ysv: en-YS, hu_HU: hu, ko_KR: ko-KR, pt_BR: pt-BR, zh_HK: zh-HK, zu_ZA: zu-ZA, en_MY: en-MY, ja-Hira: ja-HI, fi_FI: fi, vec: ve-CC, vi_VN: vi-VN, fr_FR: fr-FR, id_ID: id, zh_Hans: zh-Hans, en_DE: en-DE, en_GB: en-GB, el_GR: el-GR, uk_UA: uk-UA, az@latin: az-LA, de_AT: de-AT, uz@Latn: uz-LA, vls: vl-SS, ar_DZ: ar-DZ, bg_BG: bg, es_PY: es-PY, fy_NL: fy-NL, uz@Arab: uz-AR, ru_UA: ru-UA, war: wa-RR, zh_CN.GB2312: zh-GB
lang_map = te_IN: te-IN, es_AR: es-AR, es_419: es-LA, es_TX: es-TX, he_IL: he-IL, zh_CN: zh-CN, ar_EG: ar-EG, cs_CZ: cs-CZ, fa_IR: fa-IR, ms_MY: ms-MY, nl_NL: nl-NL, de_CH: de-CH, en_IT: en-IT, uz_UZ: uz-UZ, fr_CH: fr-CH, hi_IN: hi-IN, et_EE: et-EE, es_PE: es-PE, es_MX: es-MX, gl_ES: gl-ES, mn_MN: mn, zh_TW: zh-TW, ast_ES: ast-ES, es_CL: es-CL, ja_JP: ja-JP, lv_LV: lv, ro_RO: ro-RO, az_AZ: az-AZ, cy_GB: cy-GB, gu_IN: gu-IN, pl_PL: pl-PL, vep: ve-PP, en_BR: en-BR, en@ysv: en-YS, hu_HU: hu, ko_KR: ko-KR, pt_BR: pt-BR, zh_HK: zh-HK, zu_ZA: zu-ZA, en_MY: en-MY, ja-Hira: ja-HI, fi_FI: fi, vec: ve-CC, vi_VN: vi-VN, fr_FR: fr-FR, id_ID: id, zh_Hans: zh-Hans, en_DE: en-DE, en_GB: en-GB, el_GR: el-GR, uk_UA: uk-UA, az@latin: az-LA, de_AT: de-AT, uz@Latn: uz-LA, vls: vl-SS, ar_DZ: ar-DZ, bg_BG: bg, es_PY: es-PY, fy_NL: fy-NL, uz@Arab: uz-AR, ru_UA: ru-UA, war: wa-RR, zh_CN.GB2312: zh-GB
[o:wekan:p:wekan:r:application]
file_filter = imports/i18n/data/<lang>.i18n.json
+4191 -150
View File
File diff suppressed because it is too large. Load diff
+1 -1
View File
@@ -2,10 +2,10 @@
For all code at WeKan GitHub Organization https://github.com/wekan
- For pull requests, mention only those participants that are **human**.
- All code in pull requests need to have permission already to add it to WeKan with MIT license, and will become MIT license.
- For any dependencies, permissive licenses like https://copyfree.org are preferred
- For anything currently that is non-permissive (like GPL, AGPL, SSPL), those will be replaced with permissive-licensed alternatives
- Any intelligence allowed: Human, AI or any other. No discrimination, please have world peace. Mentioning participants optional.
- All code is checked and validated by xet7 and many different security AI. If code is real working fix or feature, it usually will be merged.
- All known vulnerabilities have been fixed at newest WeKan, please upgrade https://wekan.fi/upgrade/
- There is no known backdoors. If WeKan is installed by someone else, first registered user is Admin and has Admin Panel access.
+40 -13
View File
@@ -7,17 +7,17 @@ LABEL org.opencontainers.image.source="https://github.com/wekan/wekan"
# TARGETARCH and TARGETVARIANT are automatically provided by Docker Buildx
ARG TARGETARCH
ARG TARGETVARIANT
ARG VERSION=9.63
ARG VERSION=9.97
ARG DEBIAN_FRONTEND=noninteractive
ENV BUILD_DEPS="apt-utils gnupg wget bzip2 g++ curl libarchive-tools build-essential git ca-certificates python3 unzip"
ENV \
DEBUG=false \
NODE_VERSION=v24.17.0 \
METEOR_RELEASE=METEOR@3.5-beta.12 \
NODE_VERSION=v24.18.0 \
METEOR_RELEASE=METEOR@3.5-rc.2 \
USE_EDGE=false \
NPM_VERSION=11.11.0 \
NPM_VERSION=11.12.1 \
SRC_PATH=./ \
WITH_API=true \
MONGO_OPLOG_URL="" \
@@ -67,6 +67,7 @@ ENV \
OAUTH2_AUTH_ENDPOINT="" \
OAUTH2_USERINFO_ENDPOINT="" \
OAUTH2_TOKEN_ENDPOINT="" \
OAUTH2_LOGOUT_ENDPOINT="" \
OAUTH2_ID_MAP="" \
OAUTH2_USERNAME_MAP="" \
OAUTH2_AUTO_REGISTRATION="true" \
@@ -184,24 +185,35 @@ apt-get update --assume-yes
apt-get upgrade --assume-yes
apt-get install --assume-yes --no-install-recommends ${BUILD_DEPS}
# Multi-arch mapping: Docker TARGETARCH -> Node.js arch name + WeKan bundle name
# arm/v7 uses TARGETARCH=arm; armhf has no MongoDB Community -> uses FerretDB
# Multi-arch mapping: Docker TARGETARCH -> Node.js arch name + WeKan bundle name.
# amd64/arm64 have MongoDB Community; ppc64le/s390x/riscv64 have no MongoDB server
# and ship FerretDB v1 instead (the ferretdb binary is baked into their .zip and
# started by wekan-entrypoint.sh). riscv64's Node.js 24 comes from
# unofficial-builds.nodejs.org (nodejs.org ships no riscv64). armv7l is excluded:
# there is no Node.js 24 build for it anywhere.
NODE_BASE="official"
case "${TARGETARCH}" in
"amd64") NODE_ARCH="x64" WEKAN_ARCH="amd64" ;;
"arm64") NODE_ARCH="arm64" WEKAN_ARCH="arm64" ;;
"arm") NODE_ARCH="armv7l" WEKAN_ARCH="armhf" ;;
"ppc64le") NODE_ARCH="ppc64le" WEKAN_ARCH="ppc64le" ;;
"s390x") NODE_ARCH="s390x" WEKAN_ARCH="s390x" ;;
"riscv64") NODE_ARCH="riscv64" WEKAN_ARCH="riscv64" NODE_BASE="unofficial" ;;
*) echo "Unsupported architecture: ${TARGETARCH}"; exit 1 ;;
esac
# Node.js Installation (official nodejs.org builds for Node 22)
# Node.js installation. Official nodejs.org builds for amd64/arm64/ppc64le/s390x;
# unofficial-builds.nodejs.org for riscv64 (nodejs.org ships no riscv64 binary).
cd /tmp
wget "https://nodejs.org/dist/${NODE_VERSION}/node-${NODE_VERSION}-linux-${NODE_ARCH}.tar.gz"
wget "https://nodejs.org/dist/${NODE_VERSION}/SHASUMS256.txt.asc"
grep "node-${NODE_VERSION}-linux-${NODE_ARCH}.tar.gz" SHASUMS256.txt.asc | shasum -a 256 -c -
if [ "${NODE_BASE}" = "unofficial" ]; then
NODE_DIST="https://unofficial-builds.nodejs.org/download/release/${NODE_VERSION}"
else
NODE_DIST="https://nodejs.org/dist/${NODE_VERSION}"
fi
wget "${NODE_DIST}/node-${NODE_VERSION}-linux-${NODE_ARCH}.tar.gz"
wget "${NODE_DIST}/SHASUMS256.txt"
grep " node-${NODE_VERSION}-linux-${NODE_ARCH}.tar.gz\$" SHASUMS256.txt | shasum -a 256 -c -
tar xzf "node-${NODE_VERSION}-linux-${NODE_ARCH}.tar.gz" -C /usr/local --strip-components=1 --no-same-owner
rm -f "node-${NODE_VERSION}-linux-${NODE_ARCH}.tar.gz" SHASUMS256.txt.asc
rm -f "node-${NODE_VERSION}-linux-${NODE_ARCH}.tar.gz" SHASUMS256.txt
ln -s "/usr/local/bin/node" "/usr/local/bin/nodejs"
# NPM configuration
@@ -228,6 +240,14 @@ rm "wekan-${VERSION}-${WEKAN_ARCH}.zip"
npm install --prefix ./bundle/programs/server
mv /home/wekan/app/bundle /build
# The .zip bundle now ships a self-contained launcher + its own Node.js for the
# offline downloads; the Docker image installs its own Node and uses
# wekan-entrypoint.sh, so drop the redundant bundled node + launchers. Keeps
# /build/ferretdb (used by the entrypoint) and the per-arch MongoDB Database Tools
# (bsondump, mongodump, mongorestore, … from wekan/mongo-tools, embedded in the
# bundle) for backup/restore inside the container. Saves ~80 MB per arch.
rm -f /build/node /build/start-wekan.sh /build/start-wekan.bat
# Restore original tar
mv $(which tar)~ $(which tar)
@@ -246,10 +266,17 @@ mkdir -p /data
chown wekan:wekan --recursive /data
EOR
# Database-backend selector entrypoint. Every arch's bundle now ships a FerretDB
# binary (baked into the .zip and moved to /build/ferretdb above); this script
# starts FerretDB v1 (SQLite) or leaves the DB external based on WEKAN_DB and the
# /build/.ferretdb-default marker (present only on MongoDB-less arches). See
# releases/ferretdb/wekan-entrypoint.sh.
COPY --chmod=755 releases/ferretdb/wekan-entrypoint.sh /build/wekan-entrypoint.sh
USER wekan
ENV PORT=8080
EXPOSE $PORT
STOPSIGNAL SIGKILL
WORKDIR /build
CMD ["bash", "-c", "ulimit -s 65500; exec node main.js"]
CMD ["bash", "/build/wekan-entrypoint.sh"]
+21 -13
View File
@@ -103,10 +103,10 @@ By working directly with WeKan ® you get the benefit of active maintenance and
## Getting Started with Development
The default branch uses Meteor 3.5-beta.7 with Node.js 24.x.
The main branch uses Meteor 3.5 with Node.js 24.x.
See [CHANGELOG.md](https://github.com/wekan/wekan/blob/main/CHANGELOG.md) for the latest runtime updates.
To contribute, [create a fork](https://github.com/wekan/wekan/blob/main/docs/DeveloperDocs/Build-and-Create-Pull-Request.md#2-create-fork-of-httpsgithubcomwekanwekan-at-github-web-page) and run `./rebuild-wekan.sh` (or `./rebuild-wekan.bat` on Windows) as detailed [here](https://github.com/wekan/wekan/blob/main/docs/DeveloperDocs/Build-and-Create-Pull-Request.md#3-select-option-1-to-install-dependencies-and-then-enter). Once you're ready, please test your code and [submit a pull request (PR)](https://github.com/wekan/wekan/blob/main/docs/DeveloperDocs/Build-and-Create-Pull-Request.md#7-test).
To contribute, [create a fork](https://github.com/wekan/wekan/blob/main/docs/DeveloperDocs/Build-and-Create-Pull-Request.md#2-create-fork-of-httpsgithubcomwekanwekan-at-github-web-page) and run `./rebuild-wekan.sh` (or `./rebuild-wekan.bat` on Windows) as detailed [here](https://github.com/wekan/wekan/blob/main/docs/DeveloperDocs/Build-and-Create-Pull-Request.md#3-install-dependencies-build-wekan-and-run-the-dev-server). Once you're ready, please test your code and [submit a pull request (PR)](https://github.com/wekan/wekan/blob/main/docs/DeveloperDocs/Build-and-Create-Pull-Request.md#7-test).
Please refer to the [developer documentation](https://github.com/wekan/wekan/blob/main/docs/DeveloperDocs/Developer-Documentation.md) for more information.
@@ -138,11 +138,17 @@ curl https://install.meteor.com/ | sh
### Building WeKan
The `rebuild-wekan.sh` script guides you through a three-stage process:
The `rebuild-wekan.sh` script shows a two-level menu. The top level groups options into categories:
1. **Install dependencies (Option 1)** - Downloads all required Meteor packages and npm modules
2. **Build WeKan (Option 2)** - Compiles the application
3. **Run WeKan (Option 3)** - Starts the development server at http://localhost:4000
```
1) Setup 2) Dev server 3) Tests 4) Docker 5) Tools 6) Quit
```
You pick a category number, then the item number inside it (each submenu also has a `Back` entry). Building from source is a three-stage process:
1. **Setup -> Install dependencies** - Downloads all required Meteor packages and npm modules
2. **Setup -> Build WeKan** - Compiles the application
3. **Dev server -> localhost:3000** - Starts the development server at http://localhost:3000
```bash
# Clone your fork
@@ -152,25 +158,27 @@ cd wekan
# Make the script executable
chmod +x rebuild-wekan.sh
# Step 1: Install dependencies
# Step 1: Install dependencies (Setup -> Install dependencies)
./rebuild-wekan.sh
# Press 1 and Enter
# Press 1 (Setup) and Enter, then 1 (Install dependencies) and Enter
# Step 2: Build WeKan (after dependencies complete)
# Step 2: Build WeKan (Setup -> Build WeKan, after dependencies complete)
./rebuild-wekan.sh
# Press 2 and Enter
# Press 1 (Setup) and Enter, then 2 (Build WeKan) and Enter
# Step 3: Run WeKan in development mode
# Step 3: Run WeKan in development mode (Dev server -> localhost:3000)
./rebuild-wekan.sh
# Press 3 and Enter
# Press 2 (Dev server) and Enter, then 1 (localhost:3000) and Enter
```
If a dev server is already running on that port, the **Dev server** options stop it automatically and start a fresh server on the same port.
### WSL Users
WSL users can use Snap Candidate. See [install docs](https://wekan.fi/install/).
The development server will start at http://localhost:4000. Any changes you make to the source code will automatically trigger a rebuild and refresh your browser.
The development server will start at http://localhost:3000. Any changes you make to the source code will automatically trigger a rebuild and refresh your browser.
## Screenshot
+1 -1
View File
@@ -1,5 +1,5 @@
appId: wekan-public/apps/77b94f60-dec9-0136-304e-16ff53095928
appVersion: "v9.63.0"
appVersion: "v9.97.0"
files:
userUploads:
- README.md
+89 -5
View File
@@ -37,6 +37,8 @@ If *nix: chmod +x api.py => ./api.py users
python3 api.py lists BOARDID # Lists of BOARDID
python3 api.py list BOARDID LISTID # Info of LISTID
python3 api.py createlist BOARDID LISTTITLE # Create list
python3 api.py editlist BOARDID LISTID NEWLISTTITLE # Edit list title
python3 api.py editlistcolor BOARDID LISTID COLOR (Color available: `white`, `green`, `yellow`, `orange`, `red`, `purple`, `blue`, `sky`, `lime`, `pink`, `black`, `silver`, `peachpuff`, `crimson`, `plum`, `darkgreen`, `slateblue`, `magenta`, `gold`, `navy`, `gray`, `saddlebrown`, `paleturquoise`, `mistyrose`, `indigo`) # Edit list color
python3 api.py addcard AUTHORID BOARDID SWIMLANEID LISTID CARDTITLE CARDDESCRIPTION
python3 api.py editcard BOARDID LISTID CARDID NEWCARDTITLE NEWCARDDESCRIPTION
python3 api.py getcard BOARDID LISTID CARDID # Get card info
@@ -77,6 +79,7 @@ If *nix: chmod +x api.py => ./api.py users
python3 api.py exportboardpdf BOARDID OUTPUT.pdf # Export a whole board to PDF
python3 api.py importboardfrom SOURCE EXPORT.json # Import from trello/wekan/csv/jira/kanboard/excel/deck/openproject/github/gitlab/gitea/forgejo/asana/zenkit
python3 api.py exportboardformat BOARDID FORMAT OUTPUT.json # Export to kanboard/trello/jira/deck/openproject/github/gitlab/gitea/forgejo/asana/zenkit
python3 api.py importics BOARDID SWIMLANEID LISTID CALENDAR.ics # Import an iCalendar (.ics) file into a board as cards (one card per VEVENT)
Board Member API (Issue #5998):
python3 api.py addboardmember BOARDID USERID ROLE # Add/activate board member. ROLE: admin, normal, comment, readonly, worker, normalassignedonly, commentassignedonly, readassignedonly, nocomments
@@ -129,6 +132,16 @@ If *nix: chmod +x api.py => ./api.py users
python3 api.py getcardsettings BOARDID # Get board-level card settings (allows* toggles, cardAging, cardAgingDays1/2/3)
python3 api.py setcardsetting BOARDID KEY VALUE # Set one board card setting, e.g. allowsDueDate true, cardAging true, cardAgingDays1 5
Board Automation Rules API (IFTTT, Issue #2674):
python3 api.py listrules BOARDID # List automation rules of a board
python3 api.py getrule BOARDID RULEID # Get one rule with its trigger and action
python3 api.py addrule BOARDID TITLE TRIGGER_JSON ACTION_JSON # Add rule. Missing trigger matching fields default to the '*' wildcard
python3 api.py editrule BOARDID RULEID PATCH_JSON # Edit rule: {"title":..,"trigger":{..},"action":{..}}
python3 api.py removerule BOARDID RULEID # Remove rule (and its trigger + action)
# Example (Issue #2674) - add member when card moved TO list, remove member when moved AWAY FROM list:
# python3 api.py addrule BOARDID 'Add on move to Doing' '{"activityType":"moveCard","listName":"Doing"}' '{"actionType":"addMember","username":"someuser"}'
# python3 api.py addrule BOARDID 'Remove on move from Doing' '{"activityType":"moveCard","oldListName":"Doing"}' '{"actionType":"removeMember","username":"someuser"}'
Admin API:
python3 api.py newuser USERNAME EMAIL PASSWORD
@@ -264,10 +277,9 @@ if arguments == 10:
boardid = sys.argv[3]
name = sys.argv[4]
type1 = sys.argv[5]
settings = str(json.loads(sys.argv[6]))
# There is error: Settings must be object. So this does not work yet.
#settings = {'currencyCode': 'EUR'}
print(type(settings))
settings_arg = sys.argv[6]
# settings is optional; an empty arg -> {} (avoids json.loads('') crashing).
settings = json.loads(settings_arg) if settings_arg.strip() else {}
showoncard = sys.argv[7]
automaticallyoncard = sys.argv[8]
showlabelonminicard = sys.argv[9]
@@ -275,7 +287,7 @@ if arguments == 10:
customfieldtoboard = wekanurl + apiboards + boardid + s + cf
# Add Custom Field to Board
headers = {'Accept': 'application/json', 'Authorization': 'Bearer {}'.format(apikey)}
post_data = {'authorId': '{}'.format(authorid), 'name': '{}'.format(name), 'type': '{}'.format(type1), 'settings': '{}'.format(settings), 'showoncard': '{}'.format(showoncard), 'automaticallyoncard': '{}'.format(automaticallyoncard), 'showlabelonminicard': '{}'.format(showlabelonminicard), 'showsumattopoflist': '{}'.format(showsumattopoflist)}
post_data = {'authorId': '{}'.format(authorid), 'name': '{}'.format(name), 'type': '{}'.format(type1), 'settings': json.dumps(settings), 'showoncard': '{}'.format(showoncard), 'automaticallyoncard': '{}'.format(automaticallyoncard), 'showlabelonminicard': '{}'.format(showlabelonminicard), 'showsumattopoflist': '{}'.format(showsumattopoflist)}
body = requests.post(customfieldtoboard, data=post_data, headers=headers)
print(body.text)
# ------- ADD CUSTOM FIELD TO BOARD END -----------
@@ -432,6 +444,49 @@ if arguments == 5:
if arguments >= 4:
if sys.argv[1] == 'editlist':
# ------- EDIT LIST START -----------
boardid = sys.argv[2]
listid = sys.argv[3]
newlisttitle = sys.argv[4]
edlist = wekanurl + apiboards + boardid + s + l + s + listid
print(edlist)
headers = {'Accept': 'application/json', 'Authorization': 'Bearer {}'.format(apikey)}
put_data = {'title': '{}'.format(newlisttitle)}
body = requests.put(edlist, data=put_data, headers=headers)
print("=== EDIT LIST ===\n")
body = requests.get(edlist, headers=headers)
data2 = body.text.replace('}', "}\n")
print(data2)
# ------- EDIT LIST END -----------
if sys.argv[1] == 'editlistcolor':
# ------- EDIT LIST COLOR START -----------
boardid = sys.argv[2]
listid = sys.argv[3]
newcolor = sys.argv[4]
valid_colors = ['white', 'green', 'yellow', 'orange', 'red', 'purple', 'blue', 'sky', 'lime', 'pink', 'black',
'silver', 'peachpuff', 'crimson', 'plum', 'darkgreen', 'slateblue', 'magenta', 'gold', 'navy',
'gray', 'saddlebrown', 'paleturquoise', 'mistyrose', 'indigo']
if newcolor not in valid_colors:
print("Invalid color. Choose a color from the list.")
sys.exit(1)
edlist = wekanurl + apiboards + boardid + s + l + s + listid
print(edlist)
headers = {'Accept': 'application/json', 'Authorization': 'Bearer {}'.format(apikey)}
put_data = {'color': '{}'.format(newcolor)}
body = requests.put(edlist, data=put_data, headers=headers)
print("=== EDIT LIST COLOR ===\n")
body = requests.get(edlist, headers=headers)
data2 = body.text.replace('}', "}\n")
print(data2)
# ------- EDIT LIST COLOR END -----------
if sys.argv[1] == 'newuser':
# ------- CREATE NEW USER START -----------
@@ -1728,6 +1783,18 @@ if arguments >= 1:
# python3 api.py addrule BOARDID 'Archive after 90 days' \
# '{"activityType":"scheduledTrigger","scheduleKind":"aging","listName":"Completed","days":90,"atTime":"03:00"}' \
# '{"actionType":"archive"}'
#
# Example (Issue #2674 - add a user to the card when it is moved TO a list, and
# remove the user again when the card is moved AWAY FROM that list). Trigger
# matching fields that are omitted (userId, swimlaneName, cardTitle, and the
# unused one of listName/oldListName) are stored as the '*' wildcard by the
# server, so the rules fire for any user/swimlane/card title:
# python3 api.py addrule BOARDID 'Add member on move to Doing' \
# '{"activityType":"moveCard","listName":"Doing"}' \
# '{"actionType":"addMember","username":"someuser"}'
# python3 api.py addrule BOARDID 'Remove member on move from Doing' \
# '{"activityType":"moveCard","oldListName":"Doing"}' \
# '{"actionType":"removeMember","username":"someuser"}'
if arguments >= 2 and sys.argv[1] == 'listrules':
boardid = sys.argv[2]
@@ -2021,4 +2088,21 @@ if arguments >= 4 and sys.argv[1] == 'exportboardformat':
f.write(response.text)
print('Board exported ({}) to: {}'.format(fmt, outputpath))
if arguments >= 5 and sys.argv[1] == 'importics':
# Usage: python3 api.py importics BOARDID SWIMLANEID LISTID CALENDAR.ics
# Imports an iCalendar (.ics) file into the board: one card is created per
# VEVENT, with startAt (DTSTART) and dueAt (DTEND, or DTSTART when there is
# no DTEND), so the events appear on the Calendar / Gantt views (issue #6323).
boardid = sys.argv[2]
swimlaneid = sys.argv[3]
listid = sys.argv[4]
icspath = sys.argv[5]
with open(icspath) as f:
ics_text = f.read()
headers = {'Accept': 'application/json', 'Authorization': 'Bearer {}'.format(apikey), 'Content-Type': 'application/json'}
url = wekanurl + apiboards + boardid + s + 'swimlanes' + s + swimlaneid + s + l + s + listid + s + 'ics'
response = requests.post(url, headers=headers, json={'ics': ics_text})
# Response: { "created": <n>, "cardIds": [ ... ] }
print(response.text)
# ------- IMPORT/EXPORT TO OTHER TOOLS END -----------
+10 -4
View File
@@ -1,7 +1,13 @@
// Fix dynamic-import chunk loading when Wekan runs under a sub-path (ROOT_URL includes a pathname,
// e.g. https://example.com/wekan). Rspack uses __webpack_public_path__ to prefix chunk URLs; by
// default it is set to /build-chunks/ (no context path). We update it here, at module evaluation
// time, before any import() expression runs (those are deferred to Meteor.startup callbacks).
// e.g. https://example.com/wekan). Rspack's runtime builds every chunk URL as
// __webpack_public_path__ + chunkName, and the chunk name ALREADY includes the "build-chunks/"
// prefix (its runtime does `u = e => "build-chunks/" + e + "." + hash + ".js"`). The default
// public path is "/", so at the site root chunks correctly resolve to "/build-chunks/<chunk>".
// Under a sub-path we must prefix that sub-path — but must NOT re-add "build-chunks/" ourselves,
// or the URL becomes "/wekan/build-chunks/build-chunks/<chunk>" and 404s (issue #6445, which broke
// the lazy-loaded language chunks). So set the public path to "<sub-path>/" and let rspack append
// "build-chunks/" itself. Done here at module evaluation time, before any import() expression runs
// (those are deferred to Meteor.startup callbacks).
/* global __webpack_public_path__:writable */
try {
const _cfg = typeof window !== 'undefined' && window.__meteor_runtime_config__;
@@ -9,7 +15,7 @@ try {
if (_rootUrl) {
const _rootPath = new URL(_rootUrl).pathname.replace(/\/+$/, '');
if (_rootPath && _rootPath !== '/') {
__webpack_public_path__ = _rootPath + '/build-chunks/';
__webpack_public_path__ = _rootPath + '/';
}
}
} catch (_) {}
@@ -15,6 +15,20 @@
.reactions-popup .add-comment-reaction:hover {
background-color: #b0c4de;
}
/* Eye / eye-slash icon toggle for showing/hiding activities. Open eye
(.eye-icon) = activities shown; crossed eye (.eye-slash-icon) = hidden.
Matches the password-visibility toggle used on the login/register pages. */
.activities-eye-toggle {
cursor: pointer;
display: inline-flex;
align-items: center;
gap: 0.4em;
text-decoration: none;
}
.activities-eye-toggle .eye-icon,
.activities-eye-toggle .eye-slash-icon {
line-height: 1;
}
.activities {
clear: both;
}
+8 -2
View File
@@ -106,10 +106,10 @@ template(name="activity")
//- comment activity ----------------------------------------------------
if($eq activity.activityType 'deleteComment')
| {{{_ 'activity-deleteComment' activity.commentId}}}.
| {{{_ 'activity-deleteComment' (sanitize activity.commentDisplayText)}}}.
if($eq activity.activityType 'editComment')
| {{{_ 'activity-editComment' activity.commentId}}}.
| {{{_ 'activity-editComment' (sanitize activity.commentDisplayText)}}}.
if($eq activity.activityType 'addComment')
| {{{_ 'activity-on' cardLink}}}
@@ -130,6 +130,12 @@ template(name="activity")
if($eq activity.activityType 'a-endAt')
| {{{_ 'activity-endDate' (sanitize endDate) cardLink}}}.
if($eq activity.activityType 'a-changedTitle')
| {{{_ 'activity-changedTitle' (sanitize activity.value) cardLink}}}.
if($eq activity.activityType 'a-changedDescription')
| {{{_ 'activity-changedDescription' cardLink}}}.
//- customField activity ------------------------------------------------
if($eq activity.activityType 'createCustomField')
| {{_ 'activity-customfield-created' customField}}.
+46
View File
@@ -135,3 +135,49 @@
font-size: 0.8em;
color: #999;
}
/* Threaded replies (issue #5907): indent replies under their parent. */
.comments .comment.is-reply {
margin-inline-start: 24px;
border-inline-start: 2px solid #e0e0e0;
padding-inline-start: 8px;
}
.comments .comment .comment-desc .comment-in-reply-to {
font-size: 0.8em;
color: #999;
border-inline-start: 2px solid #ccc;
padding-inline-start: 6px;
margin: 3px 0;
display: block;
}
.comments .comment .comment-desc .comment-in-reply-to .comment-in-reply-to-label {
font-weight: 700;
margin-inline-end: 4px;
}
.comments .comment .comment-desc .comment-in-reply-to .comment-in-reply-to-text {
font-style: italic;
}
/* "In reply to" banner above the new-comment form. */
.new-comment .comment-reply-banner {
background: #f4f4f4;
border-inline-start: 2px solid #ccc;
padding: 4px 6px;
margin: 0 4px 6px 0;
font-size: 0.85em;
color: #666;
display: flex;
align-items: center;
gap: 6px;
}
.new-comment .comment-reply-banner .comment-reply-banner-label {
font-weight: 700;
}
.new-comment .comment-reply-banner .comment-reply-banner-text {
flex: 1;
font-style: italic;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
}
.new-comment .comment-reply-banner a {
cursor: pointer;
}
+20 -4
View File
@@ -2,6 +2,14 @@ template(name="commentForm")
.new-comment.js-new-comment(
class="{{#if commentFormIsOpen}}is-open{{/if}}")
+userAvatar(userId=currentUser._id noRemove=true)
if replyToComment
.comment-reply-banner.js-reply-banner
span.comment-reply-banner-label {{_ 'comment-in-reply-to'}}:
span.comment-reply-banner-text
+viewer
= replyToComment.text
a.js-cancel-reply(title="{{_ 'close' }}")
i.fa.fa-times-thin
form.js-new-comment-form
+editor(class="js-new-comment-input")
| {{getUnsavedValue 'cardComment' currentCard._id}}
@@ -14,12 +22,19 @@ template(name="comments")
+comment(commentData)
template(name="comment")
.comment
.comment(class="{{#if parentId}}is-reply{{/if}}")
+userAvatar(userId=userId)
p.comment-desc
span.comment-member
+memberName(user=user)
if parentComment
.comment-in-reply-to
span.comment-in-reply-to-label {{_ 'comment-in-reply-to'}}:
span.comment-in-reply-to-text
+viewer
= parentComment.text
+inlinedForm(classNames='js-edit-comment')
+editor(autofocus=true)
= text
@@ -33,9 +48,10 @@ template(name="comment")
= text
+commentReactions(reactions=reactions commentId=_id)
span(title=createdAt).comment-meta {{ displayDate createdAt }}
if($eq currentUser._id userId)
+editOrDeleteComment
else if currentUser.isBoardAdmin
if currentUser.isBoardMember
= ' - '
a.js-reply-comment {{_ "comment-reply"}}
if canEditThisComment
+editOrDeleteComment
template(name="editOrDeleteComment")
+132 -4
View File
@@ -1,13 +1,70 @@
import { ReactiveCache } from '/imports/reactiveCache';
import CardComments from '/models/cardComments';
import CardComments, { canEditComment } from '/models/cardComments';
import { UnsavedEdits } from '/client/lib/unsavedEdits';
import { EscapeActions } from '/client/lib/escapeActions';
import { Utils } from '/client/lib/utils';
import autosize from 'autosize';
const commentFormIsOpen = new ReactiveVar(false);
// _id of the comment currently being replied to (threaded replies, issue #5907).
// Empty string means a new top-level comment.
const replyToCommentId = new ReactiveVar('');
// #5547: persist the comment draft (debounced) into UnsavedEdits while the user
// types, so a comment in progress survives closing the card, clicking outside
// it, or navigating away — the form prefills from {{getUnsavedValue
// 'cardComment' ...}} on the next open. Historical note: the click-open flag
// that armed the old escape-time draft save was removed in 2019 (3b3950369)
// because the escape handler CLEARED the visible text; since then nothing saved
// the draft at all, so any close of the card discarded the comment.
let commentDraftTimer = null;
let commentDraftPending = null; // { cardId, value }
function commentDraftWrite({ cardId, value }) {
if (!cardId) return;
const draftKey = { fieldName: 'cardComment', docId: cardId };
if ((value || '').trim()) {
UnsavedEdits.set(draftKey, value);
} else {
UnsavedEdits.reset(draftKey);
}
}
function scheduleCommentDraftSave(cardId, value) {
commentDraftPending = { cardId, value };
if (commentDraftTimer) clearTimeout(commentDraftTimer);
commentDraftTimer = setTimeout(() => {
commentDraftTimer = null;
const pending = commentDraftPending;
commentDraftPending = null;
if (pending) commentDraftWrite(pending);
}, 300);
}
// Run a pending (debounced) save immediately — e.g. the card is closing.
function flushCommentDraftSave() {
if (commentDraftTimer) {
clearTimeout(commentDraftTimer);
commentDraftTimer = null;
}
const pending = commentDraftPending;
commentDraftPending = null;
if (pending) commentDraftWrite(pending);
}
// Drop any pending save — the comment was submitted, so there is no draft.
function cancelCommentDraftSave() {
if (commentDraftTimer) {
clearTimeout(commentDraftTimer);
commentDraftTimer = null;
}
commentDraftPending = null;
}
Template.commentForm.onDestroyed(function () {
// #5547: the card can close without the escape handler ever running (the X
// button, a route change); make sure the last keystrokes reach the draft.
flushCommentDraftSave();
commentFormIsOpen.set(false);
$('.note-popover').hide();
});
@@ -16,9 +73,24 @@ Template.commentForm.helpers({
commentFormIsOpen() {
return commentFormIsOpen.get();
},
// The comment being replied to, if any, so the form can show an
// "In reply to ..." banner with a way to cancel.
replyToComment() {
const id = replyToCommentId.get();
return id ? ReactiveCache.getCardComment(id) : undefined;
},
});
Template.commentForm.events({
// #5547: arm the escape handler below (it saves the draft and closes the
// form); this flag had no setter since 2019, so the handler never ran.
'focus .js-new-comment-input'() {
commentFormIsOpen.set(true);
},
// #5547: keep the draft continuously saved (debounced) while typing.
'input .js-new-comment-input'(evt) {
scheduleCommentDraftSave(Utils.getCurrentCardId(), evt.currentTarget.value);
},
'submit .js-new-comment-form'(evt, tpl) {
const input = tpl.$('.js-new-comment-input');
const text = input.val().trim();
@@ -32,11 +104,21 @@ Template.commentForm.events({
boardId = card.linkedId;
}
if (text) {
const parentId = replyToCommentId.get();
CardComments.insert({
text,
boardId,
cardId,
parentId: parentId || '',
});
// #5547: the comment is saved — cancel any debounced draft save still in
// flight and remove the stored draft so it does not resurface next open.
cancelCommentDraftSave();
UnsavedEdits.reset({
fieldName: 'cardComment',
docId: Utils.getCurrentCardId(),
});
replyToCommentId.set('');
resetCommentInput(input);
Tracker.flush();
autosize.update(input);
@@ -44,6 +126,10 @@ Template.commentForm.events({
}
evt.preventDefault();
},
'click .js-cancel-reply'(evt) {
evt.preventDefault();
replyToCommentId.set('');
},
// Pressing Ctrl+Enter should submit the form
'keydown form textarea'(evt, tpl) {
if (evt.keyCode === 13 && (evt.metaKey || evt.ctrlKey)) {
@@ -60,10 +146,45 @@ Template.comments.helpers({
},
});
Template.comment.helpers({
// Whether the current user may edit/delete this comment, honouring the
// board's restrictCommentEditing setting (issue #5906). Mirrors the
// server-side enforcement so the UI hides buttons the server would reject.
canEditThisComment() {
const user = ReactiveCache.getCurrentUser();
if (!user) return false;
const isAuthor = user._id === this.userId;
const board = ReactiveCache.getBoard(this.boardId);
const isBoardAdmin = !!board && board.hasAdmin(user._id);
const restrictCommentEditing = !!board && !!board.restrictCommentEditing;
return canEditComment({ isAuthor, isBoardAdmin, restrictCommentEditing });
},
// The parent comment this one replies to, or undefined.
parentComment() {
return this.parentId ? ReactiveCache.getCardComment(this.parentId) : undefined;
},
});
Template.comment.events({
'click .js-reply-comment'(evt) {
evt.preventDefault();
replyToCommentId.set(this._id);
// Open and focus the new-comment form.
const input = $('.js-new-comment-input');
input.click();
Tracker.afterFlush(() => {
$('.js-new-comment-input').focus();
});
},
'click .js-delete-comment': Popup.afterConfirm('deleteComment', function () {
const commentId = this._id;
CardComments.remove(commentId);
// #3252: only remove if the doc is still in the local cache. Under heavy
// archive/delete churn the comment can already be evicted from Minimongo,
// and CardComments.remove() of a missing _id throws "Removed nonexistent
// document" on the client.
if (commentId && CardComments.findOne(commentId)) {
CardComments.remove(commentId);
}
Popup.back();
}),
'submit .js-edit-comment'(evt, tpl) {
@@ -108,13 +229,20 @@ EscapeActions.register(
docId: Utils.getCurrentCardId(),
};
const commentInput = $('.js-new-comment-input');
const draft = commentInput.val().trim();
const draft = (commentInput.val() || '').trim();
cancelCommentDraftSave();
if (draft) {
UnsavedEdits.set(draftKey, draft);
} else {
UnsavedEdits.reset(draftKey);
}
resetCommentInput(commentInput);
// #5547: do NOT clear the input — clearing it on every click outside the
// comment box is exactly the "comment text disappearing" bug that got this
// handler disarmed in 2019 (3b3950369). The draft is saved above; if the
// card stays open, the text stays visible; if the card closes, the next
// open prefills the form from the draft.
commentInput.blur();
commentFormIsOpen.set(false);
},
() => {
return commentFormIsOpen.get();
+1 -1
View File
@@ -9,7 +9,7 @@ Template.archivedBoards.onCreated(function () {
Template.archivedBoards.helpers({
isBoardAdmin() {
return ReactiveCache.getCurrentUser().isBoardAdmin();
return ReactiveCache.getCurrentUser()?.isBoardAdmin();
},
archivedBoards() {
+19 -7
View File
@@ -107,17 +107,17 @@
overflow-y: scroll !important;
}
/* Mobile - make all text 2x bigger inside #content by default (icons stay same size) */
/* Mobile - keep #content text at normal size (reverted #6426 oversizing) */
@media screen and (max-width: 800px),
screen and (max-device-width: 800px),
screen and (-webkit-min-device-pixel-ratio: 2) and (max-width: 800px),
screen and (max-width: 800px) and (orientation: portrait),
screen and (max-width: 800px) and (orientation: landscape) {
#content {
font-size: 2em !important; /* 2x bigger base font size for content area */
font-size: 1em !important; /* Normal size (reverted #6426 oversizing) */
}
/* Make all text elements 2x bigger */
/* Keep all text elements at normal size */
#content h1, #content h2, #content h3, #content h4, #content h5, #content h6,
#content p, #content span, #content div, #content a, #content button,
#content .minicard, #content .list-header-name, #content .board-header-btn,
@@ -186,7 +186,7 @@
/* Fallback for iPhone devices using JavaScript detection */
.iphone-device #content {
font-size: 2em !important; /* 2x bigger base font size for content area */
font-size: 1em !important; /* Normal size (reverted #6426 oversizing) */
}
.iphone-device #content h1, .iphone-device #content h2, .iphone-device #content h3, .iphone-device #content h4, .iphone-device #content h5, .iphone-device #content h6,
@@ -231,9 +231,9 @@
font-size: 1em !important; /* Keep original icon size */
}
/* Mobile iPhone: scale card details text and icons to 2x */
/* Mobile iPhone: keep card details text/icons at normal size (reverted #6426 oversizing) */
body.mobile-mode.iphone-device .card-details {
font-size: 2em !important;
font-size: 1em !important;
}
body.mobile-mode.iphone-device .card-details .fa,
body.mobile-mode.iphone-device .card-details .icon,
@@ -316,7 +316,19 @@ body.desktop-mode .board-wrapper .board-canvas .board-overlay {
display: none !important;
pointer-events: none !important;
}
.board-wrapper .board-canvas.is-dragging-active .open-minicard-composer,
/* #2877 "Wekan swimlane jumps when moving card": while a card is dragged the
"+ Add Card" composer link is hidden, but hiding it with `display: none`
collapsed the bottom row of EVERY list at drag start (and restored it on
drop). With auto-height swimlanes the whole swimlane shrank/grew by the
composer's height, so all swimlanes below visibly jumped up and back down.
`visibility: hidden` hides the link just the same but keeps its box in the
layout, so nothing moves when a drag starts or ends. */
.board-wrapper .board-canvas.is-dragging-active .open-minicard-composer {
visibility: hidden;
}
/* Checked cards of a multi-selection ARE the payload being dragged, so
removing them from the flow (showing the list as it will look after the
drop) is intentional — keep display: none here. */
.board-wrapper .board-canvas.is-dragging-active .minicard-wrapper.is-checked {
display: none;
}
+50 -5
View File
@@ -5,11 +5,14 @@ import dragscroll from '@wekanteam/dragscroll';
import '/client/lib/dragscrollTouch';
import { boardConverter } from '/client/lib/boardConverter';
import { formatDateByUserPreference } from '/imports/lib/dateUtils';
import { toFullCalendarFirstDay } from '/client/lib/calendarFirstDay';
import { weekNumberByFirstDay } from '/models/lib/weekStart';
import Swimlanes from '/models/swimlanes';
import Lists from '/models/lists';
import TableVisibilityModeSettings from '/models/tableVisibilityModeSettings';
import { EscapeActions } from '/client/lib/escapeActions';
import { Utils } from '/client/lib/utils';
import { Filter } from '/client/lib/filter';
// SubsManager removed for Meteor 3 migration
const { calculateIndex } = Utils;
@@ -567,17 +570,32 @@ Template.boardBody.onRendered(function () {
$swimlanesDom.sortable('option', 'handle', '.swimlane-header');
}
// Disable drag-dropping if the current user is not a board member
// #6446: enable swimlane drag-drop — which also carries moving cards BETWEEN
// swimlanes — for any board member with write access, not only board admins.
// The old !isBoardAdmin() check disabled this sortable for every non-admin, so
// a normal member could still move a card WITHIN a swimlane but not BETWEEN
// swimlanes (a card crossing swimlanes is received across this sortable), and
// could not reorder swimlanes. canModifyCard() is the client write-access
// predicate (board member, not comment-only / worker / read-only), matching
// the server's allowIsBoardMemberWithWriteAccess.
$swimlanesDom.sortable(
'option',
'disabled',
!ReactiveCache.getCurrentUser()?.isBoardAdmin(),
!Utils.canModifyCard(),
);
}
});
dragscroll.reset();
Utils.setBackgroundImage();
// #4978: apply the board background inside a reactive autorun instead of a
// one-shot call. Switching directly between boards (e.g. the favorites bar)
// reuses this template instance and never re-fires onRendered, so the
// background used to stay on the previously shown board. Reading the current
// board inside setBackgroundImage() tracks both board switches and background
// edits; it performs no DB writes, so there is no autorun write loop.
this.autorun(() => {
Utils.setBackgroundImage();
});
});
Template.boardBody.onDestroyed(function () {
@@ -928,6 +946,11 @@ Template.calendarView.onRendered(function () {
document.documentElement.dir = TAPi18n.getLanguageDirection();
this.autorun(function () {
// #5656: refetch calendar events whenever the active board Filter changes
// so the Calendar view stays in sync with the other views. Reading the
// Filter's reactive state here establishes the dependency; the events()
// callback below applies the actual selector.
Filter.isActive();
const calendarEl = document.getElementById('calendar-view');
if (calendarEl && calendarEl._wekanCalendar) {
calendarEl._wekanCalendar.refetchEvents();
@@ -942,12 +965,28 @@ Template.calendarView.helpers({
return translated && translated !== key ? translated : fallback;
};
// #5521: respect the user's "start day of week" setting instead of the
// FullCalendar locale default. getStartDayOfWeek() returns a zero-based day
// index (0=Sunday..6=Saturday), the same convention FullCalendar's firstDay
// uses; toFullCalendarFirstDay() validates it and falls back to Monday (1).
const currentUser = ReactiveCache.getCurrentUser();
const firstDay = toFullCalendarFirstDay(
currentUser ? currentUser.getStartDayOfWeek() : 1,
);
return {
id: 'calendar-view',
initialView: 'dayGridMonth',
firstDay,
editable: true,
selectable: true,
weekNumbers: true,
// #4946: FullCalendar's default weekNumberCalculation is locale-based
// (Sunday-anchored for many locales), so the week-number column ignored
// the user's start-day-of-week setting even though `firstDay` moved the
// grid. Compute the number from the SAME firstDay so the label matches the
// way the week is laid out.
weekNumberCalculation: date => weekNumberByFirstDay(date, firstDay),
// Use non-localized AM/PM time format to avoid confusing notations like 上/下/中
// Use full 'am'/'pm' instead of single-letter 'a'/'p' for clarity
eventTimeFormat: {
@@ -991,6 +1030,12 @@ Template.calendarView.helpers({
isRTL: TAPi18n.isRTL(),
events(fetchInfo, callback) {
const currentBoard = Utils.getCurrentBoard();
// #5656: apply the active board Filter (member / assignee / due-date /
// label / custom-field) so the Calendar view shows the same scoped set
// of cards as the Board / Lists / Swimlanes views.
const filterSelector = Filter.isActive()
? Filter._getMongoSelector()
: undefined;
const events = [];
const pushEvent = function (card, title, start, end, extraCls) {
start = start || card.startAt;
@@ -1015,12 +1060,12 @@ Template.calendarView.helpers({
});
};
currentBoard
.cardsInInterval(fetchInfo.start, fetchInfo.end)
.cardsInInterval(fetchInfo.start, fetchInfo.end, filterSelector)
.forEach(function (card) {
pushEvent(card);
});
currentBoard
.cardsDueInBetween(fetchInfo.start, fetchInfo.end)
.cardsDueInBetween(fetchInfo.start, fetchInfo.end, filterSelector)
.forEach(function (card) {
pushEvent(
card,
+17
View File
@@ -937,3 +937,20 @@
.desktop-mode .board-header .board-header-btn i {
font-size: clamp(12px, 2.5vw, 16px) !important;
}
/* #6419: make the board-header action buttons touch-friendly by VIEWPORT WIDTH,
not only when the mobile-mode class is toggled. The measured default at a phone
width was 28px tall / 13px font (too small to tap reliably). Enlarge vertically
+ bump the icon/font; width is left to flex so the existing horizontal layout
is unchanged. Applies on real phones whether or not mobile-mode auto-applied. */
@media screen and (max-width: 800px) {
.board-header-btns .board-header-btn {
min-height: 40px;
padding-top: 8px;
padding-bottom: 8px;
font-size: 15px;
}
.board-header-btns .board-header-btn i.fa {
font-size: 16px;
}
}
+43 -31
View File
@@ -23,21 +23,22 @@ template(name="boardHeaderBar")
i.fa(class="{{#if currentBoard.isPublic}}fa-globe{{else}}fa-lock{{/if}}")
span {{_ currentBoard.permission}}
a.board-header-btn.js-watch-board(
title="{{_ watchLevel }}")
if $eq watchLevel "watching"
i.fa.fa-eye
if $eq watchLevel "tracking"
i.fa.fa-bell
if $eq watchLevel "muted"
i.fa.fa-bell-slash
span {{_ watchLevel}}
unless watchDisabled
a.board-header-btn.js-watch-board(
title="{{_ watchLevel }}")
if $eq watchLevel "watching"
i.fa.fa-eye
if $eq watchLevel "tracking"
i.fa.fa-bell
if $eq watchLevel "muted"
i.fa.fa-bell-slash
span {{_ watchLevel}}
a.board-header-btn.js-star-board(class="{{#if isStarred}}is-active{{/if}}"
title="{{#if isStarred}}{{_ 'click-to-unstar'}}{{else}}{{_ 'click-to-star'}}{{/if}} {{_ 'starred-boards-description'}}")
i.fa(class="fa-star{{#unless isStarred}}-o{{/unless}}")
if showStarCounter
span.board-star-counter {{currentBoard.stars}}
a.board-header-btn(title="{{_ 'sort-cards'}}" class="{{#if isSortActive }}emphasis{{else}} js-sort-cards {{/if}}")
a.board-header-btn(title="{{_ 'sort-cards'}}" class="js-sort-cards {{#if isSortActive }}emphasis{{/if}}")
i.fa.fa-sort
span {{#if isSortActive }}{{_ 'sort-is-on'}}{{else}}{{_ 'sort-cards'}}{{/if}}
if isSortActive
@@ -67,18 +68,19 @@ template(name="boardHeaderBar")
title="{{_ currentBoard.permission}}")
i.fa(class="{{#if currentBoard.isPublic}}fa-globe{{else}}fa-lock{{/if}}")
a.board-header-btn.js-watch-board(
title="{{_ watchLevel }}")
if $eq watchLevel "watching"
i.fa.fa-eye
if $eq watchLevel "tracking"
i.fa.fa-bell
if $eq watchLevel "muted"
i.fa.fa-bell-slash
unless watchDisabled
a.board-header-btn.js-watch-board(
title="{{_ watchLevel }}")
if $eq watchLevel "watching"
i.fa.fa-eye
if $eq watchLevel "tracking"
i.fa.fa-bell
if $eq watchLevel "muted"
i.fa.fa-bell-slash
a.board-header-btn.js-star-board(class="{{#if isStarred}}is-active{{/if}}"
title="{{#if isStarred}}{{_ 'click-to-unstar'}}{{else}}{{_ 'click-to-star'}}{{/if}} {{_ 'starred-boards-description'}}")
i.fa(class="fa-star{{#unless isStarred}}-o{{/unless}}")
a.board-header-btn(title="{{_ 'sort-cards'}}" class="{{#if isSortActive }}emphasis{{else}} js-sort-cards {{/if}}")
a.board-header-btn(title="{{_ 'sort-cards'}}" class="js-sort-cards {{#if isSortActive }}emphasis{{/if}}")
i.fa.fa-sort
span {{#if isSortActive }}{{_ 'sort-is-on'}}{{else}}{{_ 'sort-cards'}}{{/if}}
if isSortActive
@@ -157,6 +159,12 @@ template(name="boardHeaderBar")
i.fa.fa-times-thin
.separator
//- #6465: one-click board settings — the boardMenu popup used to need
//- two clicks (open sidebar, then Boardeinstellungen). The click
//- handler already exists in boardHeader.js ('click .js-open-board-menu').
if currentUser.isBoardMember
a.board-header-btn.js-open-board-menu(title="{{_ 'boardMenuPopup-title'}}")
i.fa.fa-cog
a.board-header-btn.js-toggle-sidebar(title="{{_ 'sidebar-open'}} {{_ 'or'}} {{_ 'sidebar-close'}}")
i.fa.fa-bars
@@ -267,9 +275,10 @@ template(name="createBoard")
| {{{_ 'board-private-info'}}}
a.js-change-visibility {{_ 'change'}}.
input.primary.wide(type="submit" value="{{_ 'create'}}")
span.quiet
| {{_ 'or'}}
a.js-import-board {{_ 'import'}}
unless importDisabled
span.quiet
| {{_ 'or'}}
a.js-import-board {{_ 'import'}}
span.quiet
| /
a.js-board-template {{_ 'template'}}
@@ -293,9 +302,10 @@ template(name="createBoardPopup")
| {{{_ 'board-private-info'}}}
a.js-change-visibility {{_ 'change'}}.
input.primary.wide(type="submit" value="{{_ 'create'}}")
span.quiet
| {{_ 'or'}}
a.js-import-board {{_ 'import'}}
unless importDisabled
span.quiet
| {{_ 'or'}}
a.js-import-board {{_ 'import'}}
span.quiet
| /
a.js-board-template {{_ 'template'}}
@@ -319,9 +329,10 @@ template(name="headerBarCreateBoardPopup")
| {{{_ 'board-private-info'}}}
a.js-change-visibility {{_ 'change'}}.
input.primary.wide(type="submit" value="{{_ 'create'}}")
span.quiet
| {{_ 'or'}}
a.js-import-board {{_ 'import'}}
unless importDisabled
span.quiet
| {{_ 'or'}}
a.js-import-board {{_ 'import'}}
span.quiet
| /
a.js-board-template {{_ 'template'}}
@@ -346,9 +357,10 @@ template(name="createTemplateContainerPopup")
| {{{_ 'board-private-info'}}}
a.js-change-visibility {{_ 'change'}}.
input.primary.wide(type="submit" value="{{_ 'create'}}")
span.quiet
| {{_ 'or'}}
a.js-import-board {{_ 'import'}}
unless importDisabled
span.quiet
| {{_ 'or'}}
a.js-import-board {{_ 'import'}}
span.quiet
| /
a.js-board-template {{_ 'template'}}
+30 -5
View File
@@ -17,6 +17,21 @@ const UPCLS = 'fa-sort-up';
*/
const sortCardsBy = new ReactiveVar('');
// Persist the card sort so it survives a page reload. Session is in-memory and
// is reset on reload, which is why "sort by due date" kept reverting to the
// default. See https://github.com/wekan/wekan/issues/5886
const CARDS_SORT_BY_STORAGE_KEY = 'wekan-cards-sortBy';
function setCardsSortBy(sortBy) {
Session.set('sortBy', sortBy);
try {
if (sortBy) {
window.localStorage.setItem(CARDS_SORT_BY_STORAGE_KEY, JSON.stringify(sortBy));
} else {
window.localStorage.removeItem(CARDS_SORT_BY_STORAGE_KEY);
}
} catch (e) {}
}
Template.boardChangeTitlePopup.events({
async submit(event, templateInstance) {
event.preventDefault();
@@ -41,6 +56,16 @@ Template.boardChangeTitlePopup.events({
Template.boardHeaderBar.onCreated(function () {
Meteor.subscribe('tableVisibilityModeSettings');
// Restore the persisted card sort after a reload (Session is in-memory), so
// both the sorting and the sort icon are remembered. See #5886.
if (!Session.get('sortBy')) {
try {
const stored = window.localStorage.getItem(CARDS_SORT_BY_STORAGE_KEY);
if (stored) {
Session.set('sortBy', JSON.parse(stored));
}
} catch (e) {}
}
});
Template.boardHeaderBar.helpers({
@@ -171,7 +196,7 @@ Template.boardHeaderBar.events({
Filter.reset();
},
'click .js-sort-reset'() {
Session.set('sortBy', '');
setCardsSortBy('');
},
'click .js-open-search-view'() {
const sidebar = getSidebarInstance();
@@ -529,7 +554,7 @@ Template.cardsSortPopup.events({
const sortBy = {
dueAt: 1,
};
Session.set('sortBy', sortBy);
setCardsSortBy(sortBy);
sortCardsBy.set(TAPi18n.__('due-date'));
Popup.back();
},
@@ -537,7 +562,7 @@ Template.cardsSortPopup.events({
const sortBy = {
title: 1,
};
Session.set('sortBy', sortBy);
setCardsSortBy(sortBy);
sortCardsBy.set(TAPi18n.__('title'));
Popup.back();
},
@@ -545,7 +570,7 @@ Template.cardsSortPopup.events({
const sortBy = {
createdAt: 1,
};
Session.set('sortBy', sortBy);
setCardsSortBy(sortBy);
sortCardsBy.set(TAPi18n.__('date-created-newest-first'));
Popup.back();
},
@@ -553,7 +578,7 @@ Template.cardsSortPopup.events({
const sortBy = {
createdAt: -1,
};
Session.set('sortBy', sortBy);
setCardsSortBy(sortBy);
sortCardsBy.set(TAPi18n.__('date-created-oldest-first'));
Popup.back();
},
@@ -0,0 +1,42 @@
/**
* Pure helpers for building the option labels shown in board / list /
* swimlane selectors (e.g. the move-card and copy-card popups).
*
* Regression #6135 ("numbering boards, list, swim caused some issues"):
* a previous change prepended a sequential number to every option label
* (e.g. "3. My Board"). That broke two things:
*
* 1. Boards whose name itself starts with a digit became hard to read.
* 2. First-letter keyboard navigation in the native <select> dropdown
* stopped working, because every option started with a number instead
* of the board name.
*
* The fix: numbering is OPTIONAL and OFF by default. By default the label is
* exactly the entity name, so its first character is the name's first
* character and first-letter navigation works again. When numbering is
* explicitly enabled, the number is appended as a trailing visual suffix so
* the label still STARTS with the name.
*/
/**
* Build the label for a selectable board/list/swimlane option.
*
* @param {string} name The entity (board/list/swimlane) name/title.
* @param {number} index Zero-based position in the list.
* @param {Object} [opts]
* @param {boolean} [opts.numbered=false] When true, append the 1-based
* number as a trailing suffix. When false (default), return the bare
* name so first-letter keyboard navigation keeps working.
* @returns {string} The option label.
*/
export function boardOptionLabel(name, index, { numbered = false } = {}) {
const label = name == null ? '' : String(name);
if (!numbered) {
return label;
}
const position = Number(index);
const number = Number.isFinite(position) ? position + 1 : index;
return `${label} (${number})`;
}
export default boardOptionLabel;
+64 -246
View File
@@ -297,6 +297,62 @@
gap: 8px;
}
/* #5799: board-name search box in the All Boards header */
.boards-path-header .board-search {
display: flex;
align-items: center;
gap: 6px;
padding: 4px 8px;
background: #fff;
border: 1px solid #ddd;
border-radius: 4px;
}
.boards-path-header .board-search input {
border: none;
outline: none;
background: transparent;
font-size: 14px;
min-width: 140px;
}
.boards-path-header .board-search .board-search-clear {
cursor: pointer;
color: #999;
}
.boards-path-header .board-search .board-search-clear:hover {
color: #333;
}
/* #5799: board grid pagination controls, mirroring Admin Panel > People */
.boards-pagination {
display: flex;
align-items: center;
gap: 6px;
margin-bottom: 12px;
}
.boards-pagination button {
min-width: 32px;
height: 30px;
border: 1px solid #bbb;
background: #fff;
border-radius: 0.4vw;
cursor: pointer;
}
.boards-pagination button.disabled {
opacity: 0.5;
pointer-events: none;
}
.boards-page-info {
min-width: 72px;
text-align: center;
color: #333;
}
.boards-path-header .path-icon {
font-size: 18px;
}
@@ -946,21 +1002,13 @@ body.grey-icons-enabled .checkmark-no-grey {
}
}
/* Mobile - make all text and icons 2x bigger above #content on All Boards page */
/* Mobile All Boards layout fixes */
@media screen and (max-width: 800px),
screen and (max-device-width: 800px),
screen and (-webkit-min-device-pixel-ratio: 2) and (max-width: 800px),
screen and (max-width: 800px) and (orientation: portrait),
screen and (max-width: 800px) and (orientation: landscape),
screen and (max-device-width: 932px) and (-webkit-min-device-pixel-ratio: 3) {
.wrapper {
font-size: 2em !important; /* 2x bigger base font size for All Boards page */
}
.wrapper * {
font-size: inherit !important; /* Inherit the 2x scaling */
}
/* Stack the two-column All Boards layout on small screens. The fixed
"260px 1fr" grid had no mobile collapse, so on narrow non-iPhone browsers
(Fairphone Firefox ESR / Ubuntu Touch Morph, narrow desktop) it overflowed
@@ -976,243 +1024,6 @@ body.grey-icons-enabled .checkmark-no-grey {
padding-inline-end: 0 !important;
padding-bottom: 12px;
}
.wrapper .fa, .wrapper .icon {
font-size: 2em !important; /* 2x bigger icons */
}
.board-list-header {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.board-list-header h1 {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.AllBoardTeamsOrgs {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.AllBoardTeamsOrgs select {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.AllBoardTeamsOrgs input {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.AllBoardTeamsOrgs .fa {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.board-list {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.board-list .board-list-item {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.board-list .board-list-item-name {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.board-list .board-list-item-desc {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.board-list .minicard-members {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.board-list .minicard-lists {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.board-list .fa {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.board-list .board-handle {
font-size: 1em !important; /* Use inherited 2x scaling */
}
}
/* Fallback for iPhone devices using JavaScript detection - All Boards page */
.iphone-device .wrapper {
font-size: 2em !important; /* 2x bigger base font size for All Boards page */
}
.iphone-device .wrapper * {
font-size: inherit !important; /* Inherit the 2x scaling */
}
.iphone-device .wrapper .fa, .iphone-device .wrapper .icon {
font-size: 2em !important; /* 2x bigger icons */
}
.iphone-device .board-list-header {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.iphone-device .board-list-header h1 {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.iphone-device .AllBoardTeamsOrgs {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.iphone-device .AllBoardTeamsOrgs select {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.iphone-device .AllBoardTeamsOrgs input {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.iphone-device .AllBoardTeamsOrgs .fa {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.iphone-device .board-list {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.iphone-device .board-list .board-list-item {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.iphone-device .board-list .board-list-item-name {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.iphone-device .board-list .board-list-item-desc {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.iphone-device .board-list .minicard-members {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.iphone-device .board-list .minicard-lists {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.iphone-device .board-list .fa {
font-size: 1em !important; /* Use inherited 2x scaling */
}
.iphone-device .board-list .board-handle {
font-size: 1em !important; /* Use inherited 2x scaling */
}
/* iPhone 12 Mini and very small screens - make everything much larger */
@media screen and (max-width: 400px) and (max-height: 900px) {
.board-list {
height: calc(100vh - 120px) !important;
overflow-y: scroll !important;
overflow-x: hidden !important;
-webkit-overflow-scrolling: touch;
padding: 0 0.5rem;
}
.board-list li {
width: 100% !important;
float: none !important;
display: block !important;
margin-bottom: 1.5rem !important;
}
.board-list .board-list-item {
height: 12rem !important; /* Much taller */
width: 100% !important;
margin: 0 !important;
padding: 1rem !important; /* More padding */
font-size: 18px !important; /* Much larger text */
line-height: 1.4 !important;
}
.board-list .board-list-item .board-list-item-name {
font-size: 20px !important; /* Larger board names */
font-weight: bold !important;
margin-bottom: 0.5rem !important;
}
.board-list .board-list-item .board-list-item-desc {
font-size: 16px !important; /* Larger descriptions */
line-height: 1.3 !important;
}
.board-list .board-list-item .minicard-members {
font-size: 14px !important; /* Larger member avatars */
}
.board-list .board-list-item .minicard-lists {
font-size: 14px !important; /* Larger list counters */
}
.board-list .board-handle {
position: absolute;
padding: 10px !important;
top: 50%;
transform: translateY(-50%);
inset-inline-end: 15px !important;
font-size: 28px !important; /* Much larger drag handle */
color: #fff;
background: rgba(0,0,0,0.4) !important;
border-radius: 50%;
width: 50px !important; /* Larger handle */
height: 50px !important;
display: flex;
align-items: center;
justify-content: center;
z-index: 10;
transition: background-color 0.2s ease;
}
.board-list .board-handle:hover {
background: rgba(255, 255, 0, 0.8) !important; /* Yellow hover */
}
/* Force scrollbar to be visible and larger */
.board-list::-webkit-scrollbar {
width: 16px !important; /* Much wider scrollbar */
display: block !important;
visibility: visible !important;
}
.board-list::-webkit-scrollbar-track {
background: #f1f1f1 !important;
border-radius: 8px !important;
display: block !important;
visibility: visible !important;
}
.board-list::-webkit-scrollbar-thumb {
background: #666 !important; /* Darker for better visibility */
border-radius: 8px !important;
display: block !important;
visibility: visible !important;
min-height: 50px !important; /* Minimum thumb size */
}
.board-list::-webkit-scrollbar-thumb:hover {
background: #333 !important;
}
/* Ensure scrollbar is always visible */
.board-list {
scrollbar-gutter: stable;
scrollbar-width: auto !important;
min-height: 100vh !important;
}
.board-list::after {
content: '';
display: block;
height: 200px !important; /* More space to ensure scrolling */
}
}
.AllBoardTeamsOrgs {
list-style-type: none;
@@ -1267,6 +1078,13 @@ body.grey-icons-enabled .checkmark-no-grey {
margin: 8px; /* Space between board items */
}
/* #6439: highlight the board a dragged board will be dropped before, when
reordering in the Custom (drag order) sort mode. */
.js-board.board-reorder-over {
outline: 2px dashed #3498db;
outline-offset: 2px;
}
/* Reset background for add-board button */
.js-add-board {
background-color: transparent !important;
+44 -2
View File
@@ -85,6 +85,18 @@ template(name="boardList")
i.fa.fa-thumb-tack
| {{_ 'multi-selection-active'}}
.path-right
.board-search
span.emoji-icon
i.fa.fa-search
input.js-board-search-input(type="text" placeholder="{{_ 'search-boards'}}" value="{{boardSearch}}" autocomplete="off")
if boardSearch
a.board-search-clear.js-board-search-clear(title="{{_ 'filter-clear'}}")
span.emoji-icon
i.fa.fa-times
a.board-header-btn.js-open-boards-sort(title="{{_ 'sort-boards'}}" class="{{#unless isBoardsSort 'custom'}}emphasis{{/unless}}")
span.emoji-icon
i.fa.fa-sort-alpha-asc
span {{_ 'sort'}}
if canModifyBoards
if hasBoardsSelected
button.js-archive-selected-boards.board-header-btn
@@ -104,6 +116,13 @@ template(name="boardList")
a.board-header-btn-close.js-multiselection-reset(title="{{_ 'filter-clear'}}")
span.emoji-icon
i.fa.fa-times
if boardsPaginationActive
.boards-pagination
button.js-boards-prev-page(class="{{#if hasBoardsPrevPage}}{{else}}disabled{{/if}}")
| &lt;
span.boards-page-info {{boardsCurrentPage}} / {{boardsTotalPages}}
button.js-boards-next-page(class="{{#if hasBoardsNextPage}}{{else}}disabled{{/if}}")
| &gt;
ul.board-list.clearfix.js-boards.dragscroll(class="{{#if isMiniScreen}}mobile-view{{/if}} {{#if BoardMultiSelection.isActive}}is-multiselection-active{{/if}}")
li.js-add-board
if isSelectedMenu 'templates'
@@ -178,14 +197,19 @@ template(name="boardList")
span.board-list-item-name(title="{{boardOpenAndMoveHint}}")
+viewer
= title
//- #5174 / #4825: the per-board allows* flags are
//- resolved server-side into the one-shot tile data
//- (the raw fields are not even published to this
//- page), so the show* helpers below gate the whole
//- block consistently for every board.
unless currentSetting.hideBoardMemberList
if allowsBoardMemberList
if showBoardMemberList _id
.minicard-members
each member in boardMembers _id
a.name
+userAvatar(userId=member noRemove=true)
unless currentSetting.hideCardCounterList
if allowsCardCounterList
if showCardCounterList _id
.minicard-lists.flex.flex-wrap
each list in boardLists _id
.item
@@ -205,6 +229,24 @@ template(name="boardList")
span.emoji-icon
i.fa(class="fa-star{{#unless isStarred}}-o{{/unless}}")
template(name="boardsSortPopup")
ul.pop-over-list
li
a.js-boards-sort(data-sort="custom" class="{{#if isBoardsSort 'custom'}}active{{/if}}")
span.emoji-icon
i.fa.fa-arrows
| &nbsp;{{_ 'sort-boards-custom'}}
li
a.js-boards-sort(data-sort="title-asc" class="{{#if isBoardsSort 'title-asc'}}active{{/if}}")
span.emoji-icon
i.fa.fa-sort-alpha-asc
| &nbsp;{{_ 'sort-boards-title-asc'}}
li
a.js-boards-sort(data-sort="title-desc" class="{{#if isBoardsSort 'title-desc'}}active{{/if}}")
span.emoji-icon
i.fa.fa-sort-alpha-desc
| &nbsp;{{_ 'sort-boards-title-desc'}}
template(name="boardListHeaderBar")
h1 {{_ title }}
//.board-header-btns.right
+290 -54
View File
@@ -2,12 +2,14 @@ import { ReactiveCache } from '/imports/reactiveCache';
import { TAPi18n } from '/imports/i18n';
import { FlowRouter } from 'meteor/ostrio:flow-router-extra';
import getSlug from 'limax';
import '/client/lib/dragscrollTouch';
import { enablePageDragscroll, disablePageDragscroll } from '/client/lib/pageDragscroll';
import TableVisibilityModeSettings from '/models/tableVisibilityModeSettings';
import { BoardMultiSelection } from '/client/lib/boardMultiSelection';
import { EscapeActions } from '/client/lib/escapeActions';
import { Utils } from '/client/lib/utils';
import {
isDragReorderEnabled,
computeReorderedSortIndex,
} from '/models/lib/boardSortReorder';
// SubsManager removed for Meteor 3 migration
@@ -57,6 +59,19 @@ function shareBoardWith(boardId, shareType, name, id) {
const DEFAULT_WORKSPACE_ICON = '📁';
// #5799: how many board icons to show per page in the sorted (non-custom) modes.
// Matches the Admin Panel > People page size.
const BOARDS_PER_PAGE = 25;
// #6439: the effective All Boards sort mode for the current user, defaulting to
// 'custom' (manual drag order) when unknown. Used to gate board drag-reordering.
function currentAllBoardsSortBy() {
const cu = ReactiveCache.getCurrentUser();
return cu && typeof cu.getAllBoardsSortBy === 'function'
? cu.getAllBoardsSortBy()
: 'custom';
}
function getCurrentWorkspacesTree() {
const currentUser = ReactiveCache.getCurrentUser();
const tree =
@@ -117,16 +132,6 @@ function saveWorkspace(workspaceId, { name, icon }) {
}
Template.boardList.helpers({
hideCardCounterList() {
/* Bug Board icons random dance https://github.com/wekan/wekan/issues/4214
return Utils.isMiniScreen() && Session.get('currentBoard'); */
return true;
},
hideBoardMemberList() {
/* Bug Board icons random dance https://github.com/wekan/wekan/issues/4214
return Utils.isMiniScreen() && Session.get('currentBoard'); */
return true;
},
BoardMultiSelection() {
return BoardMultiSelection;
},
@@ -164,6 +169,13 @@ Template.boardList.onCreated(function () {
this.selectedMenu = new ReactiveVar(Session.get('boardListMenu') || 'starred');
this.selectedWorkspaceIdVar = new ReactiveVar(null);
this.workspacesTreeVar = new ReactiveVar([]);
// #5799: free-text search by board name. When non-empty it searches across
// ALL the user's boards (Starred, Templates, Remaining and every workspace),
// ignoring the selected-menu filter.
this.boardSearchVar = new ReactiveVar('');
// #5799: server-side pagination state for the sorted (non-custom) modes.
this.boardsPageVar = new ReactiveVar(1);
this.pagedBoardsVar = new ReactiveVar({ ids: [], total: 0 });
// #5850: the user's orgs/teams that have the per-org/team Shared Templates
// flag set (plus email domains), fetched via a non-admin server method since
// the org/team publications are admin-only. Gates the drag-to-share targets.
@@ -171,6 +183,15 @@ Template.boardList.onCreated(function () {
Meteor.call('getMyShareableGroups', (err, res) => {
if (!err && res) this.shareableGroups.set(res);
});
// #5174 / #4825: per-board tile data (per-list card counts + member ids) for
// the All Boards tiles, computed server-side and fetched exactly ONCE here —
// deliberately NOT inside an autorun and NOT from reactive getLists/getCards
// cursors, so the #4214 "icons random dance" (a reactive re-render loop on
// this page, which is why the old helpers were stubbed out) cannot return.
this.boardTileDataVar = new ReactiveVar({});
Meteor.call('getAllBoardsTileData', (err, res) => {
if (!err && res) this.boardTileDataVar.set(res);
});
let currUser = ReactiveCache.getCurrentUser();
let userLanguage;
if (currUser && currUser.profile) {
@@ -262,6 +283,50 @@ Template.boardList.onCreated(function () {
}
});
// #5799: reset to the first page whenever the active filter changes (search
// text, selected menu/workspace or sort mode). Depends only on those signals,
// not on boardsPageVar, so paging next/prev does not reset itself.
this.autorun(() => {
this.boardSearchVar.get();
this.selectedMenu.get();
const cu = ReactiveCache.getCurrentUser();
if (cu && typeof cu.getAllBoardsSortBy === 'function') {
cu.getAllBoardsSortBy();
}
this.boardsPageVar.set(1);
});
// #5799: fetch the current page of boards from the server for the sorted
// (non-custom) modes, so only that page of icons is rendered. Custom (manual
// drag order) stays unpaginated client-side so drag-reordering keeps working.
// Uses the effective current user server-side, so it also works under
// GlobalAdmin impersonation.
this.autorun(() => {
const cu = ReactiveCache.getCurrentUser();
const sortBy =
cu && typeof cu.getAllBoardsSortBy === 'function'
? cu.getAllBoardsSortBy()
: 'custom';
if (sortBy === 'custom') {
this.pagedBoardsVar.set({ ids: [], total: 0 });
return;
}
const search = (this.boardSearchVar.get() || '').trim();
const menu = this.selectedMenu.get();
const page = this.boardsPageVar.get();
Meteor.call(
'getAllBoardsPage',
{ search, sortBy, menu, page, perPage: BOARDS_PER_PAGE },
(err, res) => {
if (err) {
console.error('getAllBoardsPage failed:', err);
return;
}
if (res) this.pagedBoardsVar.set(res);
},
);
});
// The templates-container board is no longer auto-created at signup (#2339,
// #5850), and it is no longer auto-created when the user merely opens the
// Templates sub-view either: opening the view must not leave behind an empty
@@ -274,12 +339,9 @@ Template.boardList.onCreated(function () {
});
Template.boardList.onRendered(function () {
// Enable drag-to-scroll on the All Boards page the same way the board
// canvas/swimlanes do. On desktop the page scroll container is <body>, so we
// tag it via enablePageDragscroll(); the .board-list.dragscroll element only
// becomes a scroll container in mobile view, where its own class handles it.
// Finger drag-scrolling is handled by dragscrollTouch.js.
enablePageDragscroll();
// Drag-to-scroll on the All Boards page is handled centrally for all
// non-board pages by defaultLayout's route-aware autorun
// (see client/components/main/layouts.js).
// jQuery sortable is disabled in favor of HTML5 drag-and-drop for space management
// The old sortable code has been removed to prevent conflicts
@@ -325,13 +387,6 @@ Template.boardList.onRendered(function () {
*/
});
Template.boardList.onDestroyed(function () {
// Stop tagging <body> as drag-scrollable when leaving the All Boards page so
// other layouts (e.g. a board view, whose canvas does its own dragscroll) are
// not affected.
disablePageDragscroll();
});
Template.boardList.helpers({
userHasTeams() {
if (ReactiveCache.getCurrentUser()?.teams?.length > 0) return true;
@@ -486,27 +541,53 @@ Template.boardList.helpers({
const boards = ReactiveCache.getBoards(query, {});
const currentUser = ReactiveCache.getCurrentUser();
// #5799: in a sorted (non-custom) mode the server already computed the
// current page (filtered by menu/search and sorted), so render exactly that
// ordered page of board icons. Custom (manual drag order) falls through to
// the unpaginated client-side path below so drag-reordering keeps working.
const sortMode =
currentUser && typeof currentUser.getAllBoardsSortBy === 'function'
? currentUser.getAllBoardsSortBy()
: 'custom';
if (sortMode !== 'custom') {
const paged = tpl.pagedBoardsVar.get();
return (paged.ids || [])
.map((id) => ReactiveCache.getBoard(id))
.filter(Boolean);
}
let list = boards;
// Apply left menu filtering
const sel = tpl.selectedMenu.get();
const assignments =
(currentUser &&
currentUser.profile &&
currentUser.profile.boardWorkspaceAssignments) ||
{};
if (sel === 'starred') {
// Starred boards are always visible in Starred.
list = list.filter((b) => currentUser && currentUser.hasStarred(b._id));
} else if (sel === 'templates') {
list = list.filter((b) => b.type === 'template-container');
} else if (sel === 'remaining') {
// Remaining only shows boards not assigned to any workspace.
list = list.filter(
(b) => !assignments[b._id] && b.type !== 'template-container',
);
// #5799: when a board-name search is active, search across ALL the user's
// boards (every menu/workspace) by title and skip the menu filter, so a
// board in any category — Starred, Templates, Remaining or a (sub)workspace
// — is found from a single search box.
const search = (tpl.boardSearchVar.get() || '').trim().toLowerCase();
if (search) {
list = list.filter((b) => (b.title || '').toLowerCase().includes(search));
} else {
// Workspace view includes all boards in that workspace, including starred.
list = list.filter((b) => assignments[b._id] === sel);
// Apply left menu filtering
const sel = tpl.selectedMenu.get();
if (sel === 'starred') {
// Starred boards are always visible in Starred.
list = list.filter((b) => currentUser && currentUser.hasStarred(b._id));
} else if (sel === 'templates') {
list = list.filter((b) => b.type === 'template-container');
} else if (sel === 'remaining') {
// Remaining only shows boards not assigned to any workspace.
list = list.filter(
(b) => !assignments[b._id] && b.type !== 'template-container',
);
} else {
// Workspace view includes all boards in that workspace, including starred.
list = list.filter((b) => assignments[b._id] === sel);
}
}
if (currentUser && typeof currentUser.sortBoardsForUser === 'function') {
@@ -516,25 +597,32 @@ Template.boardList.helpers({
.slice()
.sort((a, b) => (a.title || '').localeCompare(b.title || ''));
},
// #5174 / #4825: the board tiles' per-list card-count line and member avatar
// row. Data comes from the one-shot getAllBoardsTileData method fetch in
// onCreated (see there) — NOT from reactive getLists/getCards cursors, which
// caused the #4214 "icons random dance" and got these helpers stubbed to []
// (hiding the counters/avatars for everyone). The show* helpers resolve the
// per-board opt-in flags (allowsCardCounterList / allowsBoardMemberList,
// board sidebar "Show at All Boards page"), strictly, server-side — so a
// board with the checkbox off (or never set) consistently shows nothing.
boardLists(boardId) {
/* Bug Board icons random dance https://github.com/wekan/wekan/issues/4214
const lists = ReactiveCache.getLists({ 'boardId': boardId, 'archived': false },{sort: ['sort','asc']});
const ret = lists.map(list => {
let cardCount = ReactiveCache.getCards({ 'boardId': boardId, 'listId': list._id }).length;
return `${list.title}: ${cardCount}`;
});
return ret;
*/
return [];
const tile = (Template.instance().boardTileDataVar.get() || {})[boardId];
return (tile && tile.showLists && tile.lists) || [];
},
boardMembers(boardId) {
/* Bug Board icons random dance https://github.com/wekan/wekan/issues/4214
const lists = ReactiveCache.getBoard(boardId)
const boardMembers = lists?.members.map(member => member.userId);
return boardMembers;
*/
return [];
const tile = (Template.instance().boardTileDataVar.get() || {})[boardId];
return (tile && tile.showMembers && tile.memberIds) || [];
},
showCardCounterList(boardId) {
const tile = (Template.instance().boardTileDataVar.get() || {})[boardId];
return !!(tile && tile.showLists && tile.lists && tile.lists.length);
},
showBoardMemberList(boardId) {
const tile = (Template.instance().boardTileDataVar.get() || {})[boardId];
return !!(tile && tile.showMembers && tile.memberIds && tile.memberIds.length);
},
isStarred() {
@@ -650,6 +738,46 @@ Template.boardList.helpers({
const currentUser = ReactiveCache.getCurrentUser();
return currentUser && !currentUser.isCommentOnly();
},
// #5799: current board-name search text (for the input value and the clear button).
boardSearch() {
return Template.instance().boardSearchVar.get();
},
// #5799: pagination controls (only shown in the sorted, non-custom modes).
boardsPaginationActive() {
const currentUser = ReactiveCache.getCurrentUser();
const sortMode =
currentUser && typeof currentUser.getAllBoardsSortBy === 'function'
? currentUser.getAllBoardsSortBy()
: 'custom';
if (sortMode === 'custom') return false;
const total = Template.instance().pagedBoardsVar.get().total || 0;
return total > BOARDS_PER_PAGE;
},
boardsCurrentPage() {
return Template.instance().boardsPageVar.get();
},
boardsTotalPages() {
const total = Template.instance().pagedBoardsVar.get().total || 0;
return Math.max(1, Math.ceil(total / BOARDS_PER_PAGE));
},
hasBoardsPrevPage() {
return Template.instance().boardsPageVar.get() > 1;
},
hasBoardsNextPage() {
const tpl = Template.instance();
const total = tpl.pagedBoardsVar.get().total || 0;
const totalPages = Math.max(1, Math.ceil(total / BOARDS_PER_PAGE));
return tpl.boardsPageVar.get() < totalPages;
},
// #5799: current All Boards sort mode ('custom' | 'title-asc' | 'title-desc').
isBoardsSort(mode) {
const currentUser = ReactiveCache.getCurrentUser();
const current =
currentUser && typeof currentUser.getAllBoardsSortBy === 'function'
? currentUser.getAllBoardsSortBy()
: 'custom';
return current === mode;
},
hasBoardsSelected() {
return BoardMultiSelection.count() > 0;
},
@@ -745,6 +873,41 @@ Template.boardList.events({
Popup.open('createBoard')(evt);
}
},
// #5799: choose how the All Boards page is sorted.
'click .js-open-boards-sort': Popup.open('boardsSort'),
// #5799: search boards by name across all categories.
'input .js-board-search-input'(evt, tpl) {
tpl.boardSearchVar.set(evt.currentTarget.value);
},
'keydown .js-board-search-input'(evt, tpl) {
// Esc clears the search.
if (evt.keyCode === 27) {
tpl.boardSearchVar.set('');
evt.currentTarget.value = '';
}
},
'click .js-board-search-clear'(evt, tpl) {
evt.preventDefault();
tpl.boardSearchVar.set('');
const input = tpl.find('.js-board-search-input');
if (input) {
input.value = '';
input.focus();
}
},
// #5799: board grid pagination (sorted modes only).
'click .js-boards-prev-page'(evt, tpl) {
evt.preventDefault();
const page = tpl.boardsPageVar.get();
if (page > 1) tpl.boardsPageVar.set(page - 1);
},
'click .js-boards-next-page'(evt, tpl) {
evt.preventDefault();
const total = tpl.pagedBoardsVar.get().total || 0;
const totalPages = Math.max(1, Math.ceil(total / BOARDS_PER_PAGE));
const page = tpl.boardsPageVar.get();
if (page < totalPages) tpl.boardsPageVar.set(page + 1);
},
'click .js-star-board'(evt) {
evt.preventDefault();
evt.stopPropagation();
@@ -829,6 +992,55 @@ Template.boardList.events({
document.querySelectorAll('.workspace-node.board-drag-hint, .js-select-menu.board-drag-hint').forEach((el) => {
el.classList.remove('board-drag-hint');
});
document.querySelectorAll('.js-board.board-reorder-over').forEach((el) => {
el.classList.remove('board-reorder-over');
});
},
// #6439: reorder boards on the All Boards page by dropping one board onto
// another. Only active in the "custom" (manual drag order) sort mode — in the
// sorted modes the order comes from the title, so a board is not a valid drop
// target (which is why, before this, the browser showed the not-allowed cursor
// and nothing persisted). The reorder decision/index math lives in the pure,
// unit-tested models/lib/boardSortReorder.js.
'dragover .js-board'(evt, tpl) {
if (!isDragReorderEnabled(currentAllBoardsSortBy())) return;
// A multi-board drag is a share/assign gesture, not a reorder.
const dt = evt.originalEvent.dataTransfer;
if (dt && dt.getData('application/x-board-multi') === 'true') return;
evt.preventDefault();
evt.stopPropagation();
if (dt) dt.dropEffect = 'move';
evt.currentTarget.classList.add('board-reorder-over');
},
'dragleave .js-board'(evt) {
evt.currentTarget.classList.remove('board-reorder-over');
},
'drop .js-board'(evt, tpl) {
if (!isDragReorderEnabled(currentAllBoardsSortBy())) return;
const dt = evt.originalEvent.dataTransfer;
if (dt && dt.getData('application/x-board-multi') === 'true') return;
const draggedId = dt ? dt.getData('text/plain') : '';
if (!draggedId) return;
evt.preventDefault();
evt.stopPropagation();
evt.currentTarget.classList.remove('board-reorder-over');
const targetId = this._id;
// #6442: current display order of the board grid. Read each board's _id from
// its Blaze data context (the same source dragstart uses via `this._id`) —
// NOT el.classList[0]. On `li.js-board(class="{{_id}} …")` Jade emits the
// literal `js-board` class FIRST, so classList[0] is the string "js-board"
// for every board; the old code therefore produced ['js-board','js-board',…],
// computeReorderedSortIndex could not find the dragged/target ids among them,
// returned null, and the drop silently did nothing (board snapped back).
const orderedIds = Array.from(tpl.findAll('.js-board'))
.map((el) => Blaze.getData(el)?._id)
.filter(Boolean);
const mapping = computeReorderedSortIndex(orderedIds, draggedId, targetId);
if (!mapping) return;
const currentUser = ReactiveCache.getCurrentUser();
if (currentUser && typeof currentUser.setBoardSortIndexes === 'function') {
currentUser.setBoardSortIndexes(mapping);
}
},
'click .js-clone-board'(evt) {
if (confirm(TAPi18n.__('duplicate-board-confirm'))) {
@@ -1157,6 +1369,30 @@ Template.boardList.events({
},
});
// #5799: All Boards sort popup — pick custom (manual drag order) or
// alphabetical A→Z / Z→A. The choice is stored per user.
Template.boardsSortPopup.helpers({
isBoardsSort(mode) {
const currentUser = ReactiveCache.getCurrentUser();
const current =
currentUser && typeof currentUser.getAllBoardsSortBy === 'function'
? currentUser.getAllBoardsSortBy()
: 'custom';
return current === mode;
},
});
Template.boardsSortPopup.events({
'click .js-boards-sort'(evt) {
evt.preventDefault();
const mode = evt.currentTarget.getAttribute('data-sort');
if (mode) {
Meteor.call('setAllBoardsSortBy', mode);
}
Popup.back();
},
});
Template.workspaceActionsPopup.helpers({
workspaceName() {
return this.name || '';
+1 -1
View File
@@ -66,7 +66,7 @@ template(name="tableView")
td.table-view-cell-labels
.div
each label in row.labels
span.card-label(class="card-label-{{label.color}}" title="{{label.name}}")
span.card-label(class="{{labelColorClass label.color}}" style="{{labelColorStyle label.color}}" title="{{label.name}}")
+viewer
= label.name
if showReceivedColumn
+22 -8
View File
@@ -49,7 +49,14 @@ Template.attachmentGallery.events({
if (card && card.coverId === this._id) {
await card.unsetCover();
}
await Attachments.removeAsync(this._id);
// #5282 (same class as #3252 for comments/checklists): only remove if the
// doc is still in the local cache. Under publication churn the attachment
// can already be evicted from Minimongo, and removing a missing _id
// throws "Removed nonexistent document" even though the delete itself
// succeeded on the server.
if (this._id && ReactiveCache.getAttachment(this._id)) {
await Attachments.removeAsync(this._id);
}
Popup.back();
}),
});
@@ -290,7 +297,7 @@ Template.attachmentGallery.helpers({
return filesCursor.each();
},
isBoardAdmin() {
return ReactiveCache.getCurrentUser().isBoardAdmin();
return ReactiveCache.getCurrentUser()?.isBoardAdmin();
},
fileSize(size) {
const ret = filesize(size);
@@ -432,11 +439,16 @@ export async function handleFileUpload(card, files) {
fileName: fileName,
meta: Utils.getCommonAttachmentMetaFrom(card),
chunkSize: 'dynamic',
// Use HTTP transport instead of DDP so file chunks go over a dedicated
// fetch POST rather than flooding the WebSocket/DDP channel. DDP
// upload causes repeated DDP reconnects in Safari, showing the
// "Loading, please wait" offline banner and stalling progress at ~95%.
transport: 'http',
// Use HTTP transport (a dedicated fetch POST per chunk) rather than DDP,
// which floods the WebSocket channel and causes repeated reconnects in
// Safari (the "Loading, please wait" offline banner, stalling at ~95%).
// EXCEPT on Sandstorm: the grain's sandstorm-http-bridge strips Meteor-Files'
// custom upload headers — x-start/x-mtok/x-chunkid/x-fileid/x-eof are not on
// Sandstorm's request-header whitelist — so the server never sees x-start,
// treats every request as a chunk continuation, and fails with "Can't
// continue upload, session expired" [408]. DDP uploads go over method calls
// (no custom HTTP headers), so they work through the bridge.
transport: Meteor.settings?.public?.sandstorm ? 'ddp' : 'http',
};
config.meta.fileId = fileId;
@@ -528,7 +540,9 @@ Template.previewClipboardImagePopup.events({
meta: Utils.getCommonAttachmentMetaFrom(card),
fileName: file.name || file.type.replace('image/', 'clipboard.'),
chunkSize: 'dynamic',
transport: 'http',
// DDP on Sandstorm (its bridge strips Meteor-Files' x-* upload headers),
// HTTP elsewhere — see the note in the other upload handler above.
transport: Meteor.settings?.public?.sandstorm ? 'ddp' : 'http',
};
config.meta.fileId = fileId;
const uploader = await Attachments.insertAsync(
@@ -44,13 +44,13 @@ template(name="cardCustomField-number")
a.js-close-inlined-form
else
a.js-open-inlined-form
if value
= value
if formattedValue
= formattedValue
else
| {{_ 'edit'}}
else
if value
= value
if formattedValue
= formattedValue
template(name="cardCustomField-checkbox")
.js-checklist-item.checklist-item(class="{{#if data.value }}is-checked{{/if}}")
+13 -1
View File
@@ -29,6 +29,7 @@ import {
} from '/imports/lib/dateUtils';
import { CustomFieldStringTemplate } from '/client/lib/customFields'
import { getCurrentCardFromContext } from '/client/lib/currentCard';
import { formatNumberValue } from '/imports/lib/customNumberFormat';
import { EscapeActions } from '/client/lib/escapeActions';
import { getSidebarInstance } from '/client/features/sidebar/service';
@@ -91,10 +92,21 @@ Template['cardCustomField-number'].onCreated(function () {
this.customFieldId = Template.currentData()._id;
});
Template['cardCustomField-number'].helpers({
// Render blank / cleared / non-numeric values as empty instead of "NaN" (#2091).
formattedValue() {
return formatNumberValue(this.value);
},
});
Template['cardCustomField-number'].events({
'submit .js-card-customfield-number'(event, tpl) {
event.preventDefault();
const value = parseInt(tpl.find('input').value, 10);
const rawValue = tpl.find('input').value;
// A cleared/blank input parses to NaN; store '' instead so it renders empty
// rather than as "NaN" (#2091).
const parsed = parseInt(rawValue, 10);
const value = Number.isNaN(parsed) ? '' : parsed;
tpl.card.setCustomField(tpl.customFieldId, value);
},
});
+26 -22
View File
@@ -8,23 +8,27 @@
.card-date.is-active {
background-color: #b3b3b3;
}
/* Date status colors - red = overdue, amber = due soon, no shade = not due */
/* Date status colors - red = overdue, amber = due soon, no shade = not due.
* These status rules use !important so they override the date-type base
* colours below (e.g. .card-date.due-date yellow). Without this, an overdue
* due-date badge in the card detail showed yellow/amber instead of red, while
* the minicard (which already used !important) showed red - issue #5965. */
.card-date.overdue {
background-color: #ff4444; /* Red for overdue */
color: #fff;
background-color: #ff4444 !important; /* Red for overdue */
color: #fff !important;
}
.card-date.overdue:hover,
.card-date.overdue.is-active {
background-color: #cc3333;
background-color: #cc3333 !important;
}
.card-date.due-soon {
background-color: #ffaa00; /* Amber for due soon */
color: #000;
background-color: #ffaa00 !important; /* Amber for due soon */
color: #000 !important;
}
.card-date.due-soon:hover,
.card-date.due-soon.is-active {
background-color: #e69900;
background-color: #e69900 !important;
}
.card-date.not-due {
@@ -32,48 +36,48 @@
}
.card-date.current {
background-color: #5ba639; /* Green for current/active */
color: #fff;
background-color: #5ba639 !important; /* Green for current/active */
color: #fff !important;
}
.card-date.current:hover,
.card-date.current.is-active {
background-color: #46802c;
background-color: #46802c !important;
}
.card-date.completed {
background-color: #90ee90; /* Light green for completed */
color: #000;
background-color: #90ee90 !important; /* Light green for completed */
color: #000 !important;
}
.card-date.completed:hover,
.card-date.completed.is-active {
background-color: #7dd87d;
background-color: #7dd87d !important;
}
.card-date.completed-early {
background-color: #4caf50; /* Green for completed early */
color: #fff;
background-color: #4caf50 !important; /* Green for completed early */
color: #fff !important;
}
.card-date.completed-early:hover,
.card-date.completed-early.is-active {
background-color: #45a049;
background-color: #45a049 !important;
}
.card-date.completed-late {
background-color: #ff9800; /* Orange for completed late */
color: #fff;
background-color: #ff9800 !important; /* Orange for completed late */
color: #fff !important;
}
.card-date.completed-late:hover,
.card-date.completed-late.is-active {
background-color: #f57c00;
background-color: #f57c00 !important;
}
.card-date.completed-on-time {
background-color: #2196f3; /* Blue for completed on time */
color: #fff;
background-color: #2196f3 !important; /* Blue for completed on time */
color: #fff !important;
}
.card-date.completed-on-time:hover,
.card-date.completed-on-time.is-active {
background-color: #1976d2;
background-color: #1976d2 !important;
}
/* Date type specific colors */
+4 -38
View File
@@ -25,9 +25,9 @@ import {
now,
createDate,
fromNow,
calendar,
diff
calendar
} from '/imports/lib/dateUtils';
import { dueDateClass } from '/client/lib/dueDateColor';
// --- DatePicker popups (edit date forms) ---
@@ -257,29 +257,12 @@ Template.cardDueDate.onCreated(function () {
Template.cardDueDate.helpers(cardDateHelpers({
classes() {
const tpl = Template.instance();
let classes = 'due-date ';
const data = Template.currentData();
const endAt = data.getEnd();
const theDate = tpl.date.get();
const nowVal = tpl.now.get();
if (endAt && isBefore(endAt, theDate)) {
classes += 'completed-early';
} else if (endAt) {
classes += 'completed';
} else {
const daysDiff = diff(theDate, nowVal, 'days');
if (daysDiff < 0) {
classes += 'overdue';
} else if (daysDiff <= 1) {
classes += 'due-soon';
} else {
classes += 'not-due';
}
}
return classes;
return `due-date ${dueDateClass(theDate, nowVal, endAt)}`;
},
showTitle() {
const tpl = Template.instance();
@@ -471,29 +454,12 @@ Template.minicardDueDate.onCreated(function () {
Template.minicardDueDate.helpers(cardDateHelpers({
classes() {
const tpl = Template.instance();
let classes = 'due-date ';
const data = Template.currentData();
const endAt = data.getEnd();
const theDate = tpl.date.get();
const nowVal = tpl.now.get();
if (endAt && isBefore(endAt, theDate)) {
classes += 'completed-early';
} else if (endAt) {
classes += 'completed';
} else {
const daysDiff = diff(theDate, nowVal, 'days');
if (daysDiff < 0) {
classes += 'overdue';
} else if (daysDiff <= 1) {
classes += 'due-soon';
} else {
classes += 'not-due';
}
}
return classes;
return `due-date ${dueDateClass(theDate, nowVal, endAt)}`;
},
showTitle() {
const tpl = Template.instance();
@@ -1,3 +1,5 @@
import { UnsavedEdits } from '/client/lib/unsavedEdits';
const descriptionFormIsOpen = new ReactiveVar(false);
Template.descriptionForm.onDestroyed(function () {
@@ -16,6 +18,10 @@ Template.descriptionForm.events({
event.preventDefault();
const description = tpl.currentComponent ? tpl.currentComponent().getValue() : tpl.$('textarea').val();
await this.setDescription(description);
// #6455: a successful save means there is no unsaved draft anymore; clear
// any pre-existing draft record so the "You have an unsaved description"
// warning does not stick around after saving.
UnsavedEdits.reset({ fieldName: 'cardDescription', docId: this._id });
},
// Pressing Ctrl+Enter should submit the form
'keydown form textarea'(evt, tpl) {
+80 -34
View File
@@ -129,50 +129,82 @@
box-sizing: border-box;
}
/* Desktop mode: position card below board header */
/* Desktop mode: position card below board header.
#6465: the floating window used to span nearly the whole board (insets
20px/20px from BOTH edges, top-left anchored) — right on top of the card it
belongs to, with big rounded borders. Dock it to the END edge (right in LTR)
like the classic 6.09 side panel instead: the board and the card stay
visible, and the drag handle still moves it anywhere. */
body.desktop-mode .card-details:not(.card-details-popup) {
position: fixed;
width: auto;
max-width: 800px;
flex-basis: auto;
border-radius: 8px;
border-radius: 3px;
z-index: 2001;
}
/* Default position for first card or when dragged */
body.desktop-mode .card-details:not(.card-details-popup):not([style*="left"]):not([style*="top"]) {
top: 8px;
inset-inline-start: 20px;
inset-inline-end: 20px;
bottom: 20px;
inset-inline-start: auto;
inset-inline-end: 8px;
width: min(650px, 90vw);
bottom: 8px;
}
/* Stagger positions for multiple cards using nth-of-type */
/* Stagger positions for multiple cards using nth-of-type (from the end edge) */
body.desktop-mode .card-details:not(.card-details-popup):nth-of-type(1) {
top: 8px;
inset-inline-start: 20px;
inset-inline-end: 8px;
}
body.desktop-mode .card-details:not(.card-details-popup):nth-of-type(2) {
top: 38px;
inset-inline-start: 50px;
inset-inline-end: 38px;
}
body.desktop-mode .card-details:not(.card-details-popup):nth-of-type(3) {
top: 68px;
inset-inline-start: 80px;
inset-inline-end: 68px;
}
body.desktop-mode .card-details:not(.card-details-popup):nth-of-type(4) {
top: 98px;
inset-inline-start: 110px;
inset-inline-end: 98px;
}
body.desktop-mode .card-details:not(.card-details-popup):nth-of-type(5) {
top: 128px;
inset-inline-start: 140px;
inset-inline-end: 128px;
}
/* For expanded cards, set dimensions */
body.desktop-mode .card-details:not(.card-details-popup):not(.card-details-collapsed) {
inset-inline-end: 20px;
bottom: 20px;
bottom: 8px;
}
/* #4822: the MAXIMIZED card must be anchored to the VIEWPORT (position: fixed
with viewport insets), never laid out inside — or measured from — the
scrolled swimlane/board container. Historically the maximized pane was an
in-flow flex/float item of its swimlane, so after scrolling down in the
swimlanes view it rendered at the swimlane's position in the tall scrolled
canvas (off-screen) instead of over the viewport.
All four insets are !important for two reasons:
1. The floating-window rules above (top: 8px / inset-inline-end: 8px /
width: min(650px, 90vw), specificity up to 0,5,1) otherwise override the
lower-specificity .card-details-maximized geometry entirely, leaving the
Maximize button a no-op.
2. The drag handle writes inline left/top styles onto the card; a card that
was dragged and then maximized must not keep the stale dragged offsets
(an off-viewport inline top is exactly the "wrong place" of #4822).
Only !important declarations beat inline styles. */
body.desktop-mode .card-details.card-details-maximized:not(.card-details-popup):not(.card-details-collapsed) {
position: fixed !important;
top: 8px !important;
inset-inline-start: 8px !important;
inset-inline-end: 8px !important;
bottom: 8px !important;
width: auto !important;
height: auto !important;
max-width: none !important;
resize: none;
}
/* Collapsed card state - hide content and set height to title row only */
@@ -192,7 +224,9 @@ body.desktop-mode .card-details.card-details-collapsed {
}
.card-details .card-details-canvas {
width: auto;
padding: 0 2.5vw;
/* #6465: fixed 20px as in 6.09 — 2.5vw was ~48px of white border per side
on a FullHD screen. */
padding: 0 20px;
}
.card-details .card-details-header {
margin: 0 -20px 5px;
@@ -300,25 +334,14 @@ body.desktop-mode .card-details.card-details-collapsed {
float: inline-end;
}
/* Unify all card text to match title size */
/* #6465: the "unify all card text to match title size" block (v8.18) forced
EVERY element in card details to the base font size with line-height 1.5,
flattening the 6.09 hierarchy where labels/metadata were smaller than body
text — a big part of the "card window is WAAAY too big" complaint. Removed:
components keep their own sizes again. */
.card-details {
font-size: 1em;
}
.card-details p,
.card-details span,
.card-details div,
.card-details a,
.card-details label,
.card-details input,
.card-details textarea,
.card-details select,
.card-details button,
.card-details .card-details-item-title,
.card-details .card-label,
.card-details .viewer {
font-size: inherit;
line-height: 1.5;
}
.card-details .card-details-header .card-details-watch {
font-size: 17px;
padding-inline-start: 7px;
@@ -446,6 +469,12 @@ body.desktop-mode .card-details.card-details-collapsed {
flex-shrink: 0;
flex-basis: calc(100% - 20px);
will-change: flex-basis;
/* #4822: declare the position strategy explicitly. The maximized pane must
be fixed to the viewport in its own right — never an in-flow flex/float
item of the scrolled swimlane container, and never dependent on the
sibling .card-details rule (or the body.desktop-mode rules) happening to
supply position: fixed. */
position: fixed;
overflow-y: auto;
overflow-x: auto;
background: #f7f7f7;
@@ -504,16 +533,21 @@ input[type="submit"].attachment-add-link-submit {
inset-inline-start: 0 !important;
inset-inline-end: 0 !important;
bottom: 0 !important;
z-index: 100 !important;
/* #6419: the open card is a full-screen takeover on mobile, so it must sit
ABOVE the app header bar (#header-main-bar is z-index 1000) — otherwise the
header overlaps the top of the card and hides the close (X) button, making
it impossible to close the card. Kept below popups (z-index 2000+) so card
menus / date pickers still open over the card. */
z-index: 1100 !important;
height: 100vh !important;
max-height: 100vh !important;
border-radius: 0 !important;
box-shadow: none !important;
}
/* Ensure card details are above everything on mobile */
/* Ensure card details are above the app header on mobile (#6419) */
body.mobile-mode .card-details {
z-index: 100 !important;
z-index: 1100 !important;
width: 100vw !important;
inset-inline-start: 0 !important;
inset-inline-end: 0 !important;
@@ -601,7 +635,8 @@ body.mobile-mode .card-details {
inset-inline-start: 0 !important;
inset-inline-end: 0 !important;
bottom: 0 !important;
z-index: 100 !important;
/* #6419: above the app header (#header-main-bar z-index 1000), below popups. */
z-index: 1100 !important;
height: 100vh !important;
max-height: 100vh !important;
border-radius: 0 !important;
@@ -1081,3 +1116,14 @@ body.mobile-mode .card-details .card-details-header .close-card-details-mobile-w
line-height: 1;
box-sizing: border-box;
}
/* #6431 follow-up: cover image on the opened card (Card Settings > Cover image
on card, opt-in). Mirrors the minicard cover but taller. */
.card-details-cover {
background-position: center;
background-repeat: no-repeat;
background-size: contain;
height: 200px;
user-select: none;
margin: 8px 0;
}
+46 -24
View File
@@ -6,7 +6,7 @@ template(name="cardDetails")
+attachmentViewer
section.card-details.js-card-details.nodragscroll(class='{{#if cardMaximized}}card-details-maximized{{/if}}' class='{{#if isPopup}}card-details-popup{{/if}}' class='{{#unless isVerticalScrollbars}}no-scrollbars{{/unless}}' class='{{#if cardCollapsed}}card-details-collapsed{{/if}}'): .card-details-canvas
.card-details-header(class='{{#if colorClass}}card-details-{{colorClass}}{{/if}}')
.card-details-header(class='{{#if colorClass}}card-details-{{colorClass}}{{/if}}' style='{{colorStyle}}')
+inlinedForm(classNames="js-card-details-title")
+editCardTitleForm
else
@@ -112,6 +112,11 @@ template(name="cardDetails")
i.fa.fa-check
span {{_ 'upload-completed'}}
//- #6431 follow-up: cover image on the opened card (opt-in, OFF by default).
if currentBoard.allowsCoverAttachmentOnCard
if cover
.card-details-cover(style="background-image: url('{{cover.link 'original'}}');")
.card-details-left
.card-details-items
@@ -122,7 +127,7 @@ template(name="cardDetails")
| {{_ 'labels'}}
a(class="{{#if canModifyCard}}js-add-labels{{else}}is-disabled{{/if}}" title="{{_ 'card-labels-title'}}")
each labels
span.card-label(class="card-label-{{color}}" title=name)
span.card-label(class="{{labelColorClass color}}" style="{{labelColorStyle color}}" title=name)
+viewer
= name
if canModifyCard
@@ -224,6 +229,9 @@ template(name="cardDetails")
unless currentUser.isWorker
a.card-label.add-label.js-due-date
i.fa.fa-plus
if dueDateChangeCount
.card-details-due-date-changes(title="{{_ 'due-date-changes'}}")
| {{_ 'due-date-changed-times' dueDateChangeCount}}
if currentBoard.allowsEndDate
.card-details-item.card-details-item-end
@@ -681,6 +689,14 @@ template(name="cardDetails")
.card-checklist-attachmentGallery.card-checklists
if currentBoard.allowsChecklists
hr
//- Total checklist item count (finished/total) shown above all
checklists. The board flag is a cheap boolean, so when it is off
the checklist counting below is never evaluated.
if currentBoard.allowsChecklistCountBadgeOnCard
if checklists.length
h3.card-details-item-title
i.fa.fa-check-square-o
| {{checklistFinishedCount}}/{{checklistItemCount}}
+checklists(cardId = _id card = this)
if currentBoard.allowsSubtasks
hr
@@ -690,6 +706,8 @@ template(name="cardDetails")
h3.card-details-item-title
i.fa.fa-paperclip
| {{_ 'attachments'}}
if currentBoard.allowsAttachmentCountOnCard
| ({{attachments.length}})
if Meteor.settings.public.attachmentsUploadMaxSize
| {{_ 'max-upload-filesize'}} {{Meteor.settings.public.attachmentsUploadMaxSize}}
br
@@ -723,12 +741,12 @@ template(name="cardDetails")
i.fa.fa-history
| {{ _ 'activities'}}
if currentUser.isBoardMember
.material-toggle-switch(title="{{_ 'show-activities'}}")
if showActivities
input.toggle-switch(type="checkbox" id="toggleShowActivitiesCard" checked="checked")
else
input.toggle-switch(type="checkbox" id="toggleShowActivitiesCard")
label.toggle-label(for="toggleShowActivitiesCard")
if showActivities
a.activities-eye-toggle.js-toggle-show-activities-card(title="{{_ 'hide-activities'}}" aria-label="{{_ 'hide-activities'}}")
i.fa.fa-eye.eye-icon
else
a.activities-eye-toggle.js-toggle-show-activities-card(title="{{_ 'show-activities'}}" aria-label="{{_ 'show-activities'}}")
i.fa.fa-eye-slash.eye-slash-icon
if currentUser.isBoardAdmin
if isLoaded.get
@@ -945,22 +963,22 @@ template(name="moveCardPopup")
label {{_ 'boards'}}:
select.js-select-boards(autofocus)
each boards
option(value="{{_id}}" selected="{{#if isSelectedBoardId _id}}selected{{/if}}") {{add @index 1}}. {{title}}
option(value="{{_id}}" selected="{{#if isSelectedBoardId _id}}selected{{/if}}") {{title}}
label {{_ 'swimlanes'}}:
select.js-select-swimlanes
each swimlanes
option(value="{{_id}}" selected="{{#if isSelectedSwimlaneId _id}}selected{{/if}}") {{add @index 1}}. {{isTitleDefault title}}
option(value="{{_id}}" selected="{{#if isSelectedSwimlaneId _id}}selected{{/if}}") {{isTitleDefault title}}
label {{_ 'lists'}}:
select.js-select-lists
each lists
option(value="{{_id}}" selected="{{#if isSelectedListId _id}}selected{{/if}}") {{add @index 1}}. {{title}}
option(value="{{_id}}" selected="{{#if isSelectedListId _id}}selected{{/if}}") {{title}}
label {{_ 'cards'}}:
select.js-select-cards
each cards
option(value="{{_id}}" selected="{{#if isDialogOptionCardId _id}}selected{{/if}}") {{add @index 1}}. {{title}}
option(value="{{_id}}" selected="{{#if isDialogOptionCardId _id}}selected{{/if}}") {{title}}
div
input(type="radio" name="position" value="above" checked id="position-above" style="display: inline")
@@ -980,22 +998,22 @@ template(name="copyCardPopup")
label {{_ 'boards'}}:
select.js-select-boards(autofocus)
each boards
option(value="{{_id}}" selected="{{#if isSelectedBoardId _id}}selected{{/if}}") {{add @index 1}}. {{title}}
option(value="{{_id}}" selected="{{#if isSelectedBoardId _id}}selected{{/if}}") {{title}}
label {{_ 'swimlanes'}}:
select.js-select-swimlanes
each swimlanes
option(value="{{_id}}" selected="{{#if isSelectedSwimlaneId _id}}selected{{/if}}") {{add @index 1}}. {{isTitleDefault title}}
option(value="{{_id}}" selected="{{#if isSelectedSwimlaneId _id}}selected{{/if}}") {{isTitleDefault title}}
label {{_ 'lists'}}:
select.js-select-lists
each lists
option(value="{{_id}}" selected="{{#if isSelectedListId _id}}selected{{/if}}") {{add @index 1}}. {{title}}
option(value="{{_id}}" selected="{{#if isSelectedListId _id}}selected{{/if}}") {{title}}
label {{_ 'cards'}}:
select.js-select-cards
each cards
option(value="{{_id}}" selected="{{#if isDialogOptionCardId _id}}selected{{/if}}") {{add @index 1}}. {{title}}
option(value="{{_id}}" selected="{{#if isDialogOptionCardId _id}}selected{{/if}}") {{title}}
div
input(type="radio" name="position" value="above" checked id="position-above" style="display: inline")
@@ -1015,22 +1033,22 @@ template(name="copyManyCardsPopup")
label {{_ 'boards'}}:
select.js-select-boards(autofocus)
each boards
option(value="{{_id}}" selected="{{#if isSelectedBoardId _id}}selected{{/if}}") {{add @index 1}}. {{title}}
option(value="{{_id}}" selected="{{#if isSelectedBoardId _id}}selected{{/if}}") {{title}}
label {{_ 'swimlanes'}}:
select.js-select-swimlanes
each swimlanes
option(value="{{_id}}" selected="{{#if isSelectedSwimlaneId _id}}selected{{/if}}") {{add @index 1}}. {{isTitleDefault title}}
option(value="{{_id}}" selected="{{#if isSelectedSwimlaneId _id}}selected{{/if}}") {{isTitleDefault title}}
label {{_ 'lists'}}:
select.js-select-lists
each lists
option(value="{{_id}}" selected="{{#if isSelectedListId _id}}selected{{/if}}") {{add @index 1}}. {{title}}
option(value="{{_id}}" selected="{{#if isSelectedListId _id}}selected{{/if}}") {{title}}
label {{_ 'cards'}}:
select.js-select-cards
each cards
option(value="{{_id}}" selected="{{#if isDialogOptionCardId _id}}selected{{/if}}") {{add @index 1}}. {{title}}
option(value="{{_id}}" selected="{{#if isDialogOptionCardId _id}}selected{{/if}}") {{title}}
div
input(type="radio" name="position" value="above" checked id="position-above" style="display: inline")
@@ -1050,22 +1068,22 @@ template(name="convertChecklistItemToCardPopup")
label {{_ 'boards'}}:
select.js-select-boards(autofocus)
each boards
option(value="{{_id}}" selected="{{#if isSelectedBoardId _id}}selected{{/if}}") {{add @index 1}}. {{title}}
option(value="{{_id}}" selected="{{#if isSelectedBoardId _id}}selected{{/if}}") {{title}}
label {{_ 'swimlanes'}}:
select.js-select-swimlanes
each swimlanes
option(value="{{_id}}" selected="{{#if isSelectedSwimlaneId _id}}selected{{/if}}") {{add @index 1}}. {{isTitleDefault title}}
option(value="{{_id}}" selected="{{#if isSelectedSwimlaneId _id}}selected{{/if}}") {{isTitleDefault title}}
label {{_ 'lists'}}:
select.js-select-lists
each lists
option(value="{{_id}}" selected="{{#if isSelectedListId _id}}selected{{/if}}") {{add @index 1}}. {{title}}
option(value="{{_id}}" selected="{{#if isSelectedListId _id}}selected{{/if}}") {{title}}
label {{_ 'cards'}}:
select.js-select-cards
each cards
option(value="{{_id}}" selected="{{#if isDialogOptionCardId _id}}selected{{/if}}") {{add @index 1}}. {{title}}
option(value="{{_id}}" selected="{{#if isDialogOptionCardId _id}}selected{{/if}}") {{title}}
div
input(type="radio" name="position" value="above" checked id="position-above" style="display: inline")
@@ -1181,6 +1199,10 @@ template(name="setCardColorPopup")
span.card-label.palette-color.js-palette-color(class="card-details-{{color}}")
if(isSelected color)
i.fa.fa-check
// #5514: native color wheel for picking a custom RGB / hex color
.color-wheel-wrap
label(for="cardColorWheel") {{_ 'custom-color'}}
input.js-card-color-wheel#cardColorWheel(type="color" value=currentColorHex title="{{_ 'custom-color'}}")
button.primary.confirm.js-submit {{_ 'save'}}
button.js-remove-color.negate.wide.right {{_ 'unset-color'}}
+148 -26
View File
@@ -8,6 +8,8 @@ import {
DEFAULT_DEPENDENCY_COLOR,
DEFAULT_DEPENDENCY_ICON,
} from '/models/metadata/dependencies';
import { canArchiveCard } from '/client/lib/archivePermission';
import { isTextSelectionInsideCard } from '/client/lib/cardCloseGuard';
// Which dependency the icon picker should apply its choice to. The icon popup's
// own data context is the dependency row (not the source card), so we capture
@@ -48,7 +50,10 @@ import Users from '/models/users';
import Lists from '/models/lists';
import CardComments from '/models/cardComments';
import { ALLOWED_COLORS } from '/config/const';
import { isHexColor, toHex } from '/models/lib/contrastColor';
import { uniqBy } from '/imports/lib/collectionHelpers';
import { memberTargetBoardId } from '/models/lib/linkedCardMembers';
import { isSubmitKey } from '/models/lib/editorSubmitKey';
import { UserAvatar } from '../users/userAvatar';
import { Filter } from '/client/lib/filter';
import { BoardSwimlaneListCardDialog } from '/client/lib/dialogWithBoardSwimlaneListCard';
@@ -516,6 +521,14 @@ Template.cardDetails.helpers({
return card.findWatcher(Meteor.userId());
},
// #6081: number of times this card's due date has been changed, for
// accountability. Returns 0 when unavailable so the template can hide it.
dueDateChangeCount() {
const card = Template.currentData();
if (!card || typeof card.getDueDateChangeCount !== 'function') return 0;
return card.getDueDateChangeCount();
},
// Returns the card's locations (multiple supported), each enriched with the
// coordinate flag and OpenStreetMap link used by the template.
getLocations() {
@@ -617,18 +630,24 @@ Template.cardDetails.helpers({
showVotingButtons() {
const card = Template.currentData();
// #6420: currentUser was referenced but never defined here, so the helper
// threw "ReferenceError: currentUser is not defined" on every card render and
// the voting buttons disappeared. Define it and guard the board-member call.
const currentUser = ReactiveCache.getCurrentUser();
return (
(currentUser.isBoardMember() ||
(currentUser && card.voteAllowNonBoardMembers())) &&
currentUser &&
(currentUser.isBoardMember() || card.voteAllowNonBoardMembers()) &&
!card.expiredVote()
);
},
showPlanningPokerButtons() {
const card = Template.currentData();
// #6420: same as showVotingButtons — currentUser was undefined here.
const currentUser = ReactiveCache.getCurrentUser();
return (
(currentUser.isBoardMember() ||
(currentUser && card.pokerAllowNonBoardMembers())) &&
currentUser &&
(currentUser.isBoardMember() || card.pokerAllowNonBoardMembers()) &&
!card.expiredPoker()
);
},
@@ -843,17 +862,31 @@ Template.cardDetails.events({
event.preventDefault();
const description = tpl.find('.js-new-description-input').value;
const card = Template.currentData();
await card.setDescription(description);
// #5809: surface a visible error instead of failing silently — e.g. editing
// a linked card whose target is on a board the user cannot write to gets a
// permission denial that otherwise vanished with no feedback.
try {
await card.setDescription(description);
// #6455: a successful save means there is no unsaved draft anymore.
// Clear the record explicitly instead of relying on the inlined form's
// close-time draft/description comparison, which can run before the
// updated description is visible and leave a stale "You have an unsaved
// description" warning behind.
UnsavedEdits.reset({ fieldName: 'cardDescription', docId: card._id });
} catch (error) {
alert(error?.reason || error?.message || 'Failed to save description');
}
},
async 'submit .js-card-details-title'(event, tpl) {
event.preventDefault();
const titleInput = tpl.find('.js-edit-card-title');
const title = titleInput ? titleInput.value.trim() : '';
const card = Template.currentData();
if (title) {
await card.setTitle(title);
} else {
await card.setTitle('');
// #5809: surface a visible error instead of failing silently (see above).
try {
await card.setTitle(title || '');
} catch (error) {
alert(error?.reason || error?.message || 'Failed to save title');
}
},
'submit .js-card-details-assigner'(event, tpl) {
@@ -1021,7 +1054,7 @@ Template.cardDetails.events({
const card = Template.currentData();
await card.toggleHideCheckedChecklistItems();
},
async 'change #toggleShowActivitiesCard'() {
async 'click .js-toggle-show-activities-card'() {
const card = Template.currentData();
await card.toggleShowActivities();
},
@@ -1340,10 +1373,24 @@ Template.inlinedCardDescription.onCreated(function () {
this._close = (isReset = false) => {
if (this.isOpen.get() && !isReset) {
const draft = (this._getValue() || '').trim();
// #6455: normalize BOTH sides the same way before comparing. The textarea
// value has per-line trailing whitespace stripped (_getValue), while
// getDescription() returns the raw stored text — or null for an empty
// description. Comparing them raw made the comparison permanently unequal
// for descriptions containing Markdown " \n" hard breaks (or after
// emptying the description), re-creating the phantom draft on every save.
const normalize = (s) => (s || '').replaceAll(/[ \f\r\t\v]+$/gm, '').trim();
const draft = normalize(this._getValue());
const card = getCurrentCardFromContext();
if (card && draft !== card.getDescription()) {
if (card && draft !== normalize(card.getDescription())) {
UnsavedEdits.set(this._getUnsavedEditKey(), this._getValue());
} else {
// #6455: closing with the draft equal to the saved description must
// REMOVE any pre-existing unsaved-edits record. Previously this branch
// did nothing, so once a draft record existed, pressing Save ("View it"
// -> Save) could never clear the "You have an unsaved description"
// warning — only Discard could.
UnsavedEdits.reset(this._getUnsavedEditKey());
}
}
this.isOpen.set(false);
@@ -1392,7 +1439,7 @@ Template.cardDetailsActionsPopup.helpers({
},
isBoardAdmin() {
return ReactiveCache.getCurrentUser().isBoardAdmin();
return ReactiveCache.getCurrentUser()?.isBoardAdmin();
},
showListOnMinicard() {
@@ -1435,10 +1482,20 @@ Template.cardDetailsActionsPopup.events({
Popup.back();
},
'click .js-archive': Popup.afterConfirm('cardArchive', async function () {
if (!canArchiveCard({ canModifyCard: Utils.canModifyCard() })) return;
const card = Cards.findOne(getCardId());
Popup.close();
if (!card) return;
await card.archive();
// #6465 follow-up: archiving must also CLOSE the card's details window.
// The card id stayed in the openCards session list, so the floating window
// kept rendering above the board — and, docked to the right edge, exactly
// over the archives sidebar someone restoring the card would open next,
// intercepting its Restore/Delete clicks.
Session.set('openCards', (Session.get('openCards') || []).filter((id) => id !== card._id));
if (Session.get('currentCard') === card._id) {
Session.set('currentCard', null);
}
Utils.goBoardId(card.boardId);
}),
'click .js-more': Popup.open('cardMore'),
@@ -1472,18 +1529,24 @@ Template.editCardTitleForm.events({
Utils.showCopied(promise, $tooltip);
},
'keydown .js-edit-card-title'(event) {
// If enter key was pressed, submit the data
// Unless the shift key is also being pressed
if (event.keyCode === 13 && !event.shiftKey) {
// #4236: match the card description field — Ctrl/Cmd+Enter saves; plain
// Enter (and Shift+Enter) insert a new line instead of submitting. The old
// handler submitted on any Enter without Shift, so Enter could not add a
// newline in the title.
if (isSubmitKey(event)) {
$('.js-submit-edit-card-title-form').click();
}
},
});
Template.cardMembersPopup.onCreated(function () {
let currBoard = Utils.getCurrentBoard();
let members = currBoard.activeMembers();
this.members = new ReactiveVar(members);
// #4965: only the filter term is stored reactively; the candidate list is
// derived reactively in the members() helper (via filterMembers, which reads
// board.activeMembers() on each call). Previously the list was snapshotted
// once here, so a member added to the board after the popup opened — or whose
// user document finished loading after open — was missing until the popup was
// reopened.
this.filterTerm = new ReactiveVar('');
});
Template.cardMembersPopup.events({
@@ -1495,8 +1558,7 @@ Template.cardMembersPopup.events({
event.preventDefault();
},
'keyup .card-members-filter'(event) {
const members = filterMembers(event.target.value);
Template.instance().members.set(members);
Template.instance().filterTerm.set(event.target.value);
}
});
@@ -1510,7 +1572,7 @@ Template.cardMembersPopup.helpers({
},
members() {
const members = Template.instance().members.get();
const members = filterMembers(Template.instance().filterTerm.get());
const uniqueMembers = uniqBy(members, 'userId');
return [...uniqueMembers].sort((a, b) => {
const userA = ReactiveCache.getUser(a.userId);
@@ -1629,7 +1691,25 @@ Template.cardLocationsPopup.events({
});
const filterMembers = (filterTerm) => {
let currBoard = Utils.getCurrentBoard();
// #5676: for a linked card the members live on the REAL card it points at,
// which may be on another board (that is what getMembers()/toggleMember() act
// on). Offer that board's members instead of the viewing board's, so the
// picker is consistent with where membership is actually stored. Falls back to
// the current board for normal cards or when the real card isn't loaded yet.
const card = getCurrentCardFromContext();
let currBoard = null;
if (card) {
const boardId = memberTargetBoardId(card, id => ReactiveCache.getCard(id));
if (boardId) {
currBoard = ReactiveCache.getBoard(boardId);
}
}
if (!currBoard) {
currBoard = Utils.getCurrentBoard();
}
if (!currBoard) {
return [];
}
let members = currBoard.activeMembers();
if (filterTerm) {
@@ -1985,6 +2065,10 @@ Template.setCardColorPopup.helpers({
}
return tpl.currentColor.get() === color;
},
// #5514: current color as a '#rrggbb' hex for the native color wheel <input>.
currentColorHex() {
return toHex(Template.instance().currentColor.get()) || '#0079bf';
},
});
Template.setCardColorPopup.events({
@@ -1992,6 +2076,13 @@ Template.setCardColorPopup.events({
const paletteData = Blaze.getData(event.currentTarget);
tpl.currentColor.set(paletteData?.color);
},
// #5514: picking from the native color wheel stores a custom hex.
'input .js-card-color-wheel'(event, tpl) {
const value = event.currentTarget.value;
if (isHexColor(value)) {
tpl.currentColor.set(value);
}
},
async 'click .js-submit'(event, tpl) {
event.preventDefault();
const card = Cards.findOne(getCardId());
@@ -2065,6 +2156,11 @@ Template.cardMorePopup.onCreated(function () {
const cardId = getCardId();
this.currentCard = Cards.findOne(cardId);
this.parentBoard = new ReactiveVar(null);
// #3745: tracks whether the selected parent board's cards have finished
// loading. The card list stays empty until the subscription is ready, so it
// is no longer blank the first time another board is picked (the cards()
// helper queries minimongo, which was empty before the subscription arrived).
this.parentBoardReady = new ReactiveVar(true);
this.parentCard = this.currentCard?.parentCard();
if (this.parentCard) {
const list = $('.js-field-parent-card');
@@ -2103,7 +2199,10 @@ Template.cardMorePopup.helpers({
cards() {
const tpl = Template.instance();
const currentId = getCardId();
if (tpl.parentBoard.get()) {
// #3745: don't list cards until the selected board's subscription is ready,
// otherwise the first open shows an empty list. Depending on parentBoardReady
// also re-runs this helper once the data has arrived.
if (tpl.parentBoard.get() && tpl.parentBoardReady.get()) {
const ret = ReactiveCache.getCards({
boardId: tpl.parentBoard.get(),
_id: { $ne: currentId },
@@ -2147,6 +2246,12 @@ Template.cardMorePopup.events({
// verify that there are no linked cards
if (ReactiveCache.getCards({ linkedId: card._id }).length === 0) {
Cards.remove(card._id);
// #6465 follow-up: like archiving, deleting must close the card's
// details window (drop it from the openCards session list).
Session.set('openCards', (Session.get('openCards') || []).filter((id) => id !== card._id));
if (Session.get('currentCard') === card._id) {
Session.set('currentCard', null);
}
} else {
// TODO: Maybe later we can list where the linked cards are.
// Now here is popup with a hint that the card cannot be deleted
@@ -2168,7 +2273,14 @@ Template.cardMorePopup.events({
if (selection === 'none') {
tpl.parentBoard.set(null);
} else {
Meteor.subscribe('board', $(event.currentTarget).val(), false);
// #3745: wait for the board subscription to be ready before showing its
// cards, so the parent-card list is populated on the first selection.
tpl.parentBoardReady.set(false);
Meteor.subscribe('board', selection, false, {
onReady() {
tpl.parentBoardReady.set(true);
},
});
tpl.parentBoard.set(selection);
list.prop('disabled', false);
}
@@ -2392,7 +2504,17 @@ EscapeActions.register(
}
}
}
if (Session.get('cardDetailsIsDragging')) {
// #5686: selecting the text of a checklist item (whose mousedown stops
// propagation, so cardDetailsIsDragging is never set) and releasing the
// mouse outside the card must NOT close the card. Treat a live text
// selection anchored inside the card pane the same as an in-card drag.
const selectingInsideCard = isTextSelectionInsideCard(
typeof window !== 'undefined' && window.getSelection
? window.getSelection()
: null,
getCardDetailsElement(getCurrentCardFromContext()?._id),
);
if (Session.get('cardDetailsIsDragging') || selectingInsideCard) {
// Reset dragging status as the mouse landed outside the cardDetails template area and this will prevent a mousedown event from firing
Session.set('cardDetailsIsDragging', false);
Session.set('cardDetailsIsMouseDown', false);
+2 -2
View File
@@ -138,7 +138,7 @@ template(name="checklistItems")
i.fa.fa-plus
template(name='checklistItemDetail')
.js-checklist-item.checklist-item(class="{{#if item.isFinished }}is-checked{{#if checklist.hideCheckedChecklistItems}} invisible{{/if}}{{/if}}{{#if checklist.hideAllChecklistItems}} is-checked invisible{{/if}}"
.js-checklist-item.checklist-item(class="{{#if item.isFinished }}is-checked{{#if checklist.isItemHidden item.isFinished}} invisible{{/if}}{{/if}}{{#if checklist.hideAllChecklistItems}} is-checked invisible{{/if}}"
role="checkbox" aria-checked="{{#if item.isFinished }}true{{else}}false{{/if}}" tabindex="0")
if canModifyCard
.check-box-container
@@ -170,7 +170,7 @@ template(name="checklistActionsPopup")
i.fa.fa-eye-slash
| {{_ "hideCheckedChecklistItems"}} ...
.material-toggle-switch(title="{{_ 'hide-checked-items'}}")
if checklist.hideCheckedChecklistItems
if checklist.hideCheckedState
input.toggle-switch(type="checkbox" id="toggleHideCheckedChecklistItems_{{checklist._id}}" checked="checked")
else
input.toggle-switch(type="checkbox" id="toggleHideCheckedChecklistItems_{{checklist._id}}")
+5 -2
View File
@@ -214,7 +214,9 @@ Template.checklists.events({
'click .js-delete-checklist-item': Popup.afterConfirm('checklistItemDelete', function () {
Popup.back();
const item = this?.item || this;
if (item && item._id) {
// #3252: guard against removing a doc already evicted from Minimongo (heavy
// archive/delete churn), which throws "Removed nonexistent document".
if (item && item._id && ChecklistItems.findOne(item._id)) {
ChecklistItems.remove(item._id);
}
}),
@@ -258,7 +260,8 @@ Template.checklistActionsPopup.events({
'click .js-delete-checklist': Popup.afterConfirm('checklistDelete', function () {
Popup.back(2);
const checklist = this.checklist;
if (checklist && checklist._id) {
// #3252: see js-delete-checklist-item — avoid "Removed nonexistent document".
if (checklist && checklist._id && Checklists.findOne(checklist._id)) {
Checklists.remove(checklist._id);
}
}),
+21
View File
@@ -1,3 +1,24 @@
/* #5514: native color-wheel (custom RGB / hex) picker wrapper, shared by the
label / list / swimlane / card color popups. */
.color-wheel-wrap {
display: flex;
align-items: center;
gap: 8px;
margin: 6px 0 10px 0;
}
.color-wheel-wrap label {
margin: 0;
}
.color-wheel-wrap input[type="color"] {
width: 44px;
height: 28px;
padding: 0;
border: 1px solid #ccc;
border-radius: 4px;
cursor: pointer;
background: none;
}
.card-label {
border: 1px solid #000;
border-radius: 4px;
+6 -3
View File
@@ -4,9 +4,12 @@ template(name="formLabel")
label {{_ "select-color"}}
.palette-colors: each labels
span.card-label.palette-color.js-palette-color(class="card-label-{{color}}")
span.card-label.palette-color.js-palette-color(class="{{labelColorClass color}}" style="{{labelColorStyle color}}")
if(isSelected color)
i.fa.fa-check
.color-wheel-wrap
label(for="labelColorWheel") {{_ 'custom-color'}}
input.js-label-color-wheel#labelColorWheel(type="color" value=currentColorHex title="{{_ 'custom-color'}}")
template(name="createLabelPopup")
form.create-label
@@ -31,8 +34,8 @@ template(name="cardLabelsPopup")
a.card-label-edit-button.fa.fa-pencil.js-edit-label
if isTouchScreenOrShowDesktopDragHandles
span.fa.label-handle(class="fa-arrows" title="{{_ 'dragLabel'}}")
span.card-label.card-label-selectable.js-select-label.card-label-wrapper(class="card-label-{{color}}"
class="{{# if isLabelSelected ../_id }}active{{/if}}")
span.card-label.card-label-selectable.js-select-label.card-label-wrapper(class="{{labelColorClass color}}"
class="{{# if isLabelSelected ../_id }}active{{/if}}" style="{{labelColorStyle color}}")
+viewer
= name
if(isLabelSelected ../_id)
+33 -2
View File
@@ -1,5 +1,6 @@
import { ReactiveCache } from '/imports/reactiveCache';
import { LABEL_COLORS } from '/models/metadata/colors';
import { isHexColor, toHex } from '/models/lib/contrastColor';
import { EscapeActions } from '/client/lib/escapeActions';
import { Utils } from '/client/lib/utils';
@@ -28,6 +29,11 @@ Template.formLabel.helpers({
isSelected(color) {
return Template.instance().currentColor.get() === color;
},
// #5514: current color as a '#rrggbb' hex for the color-wheel <input>, which
// only accepts hex. Named colors map to their palette hex; fall back to green.
currentColorHex() {
return toHex(Template.instance().currentColor.get()) || '#3cb500';
},
});
Template.formLabel.events({
@@ -36,6 +42,13 @@ Template.formLabel.events({
const selectedColor = paletteData?.color || Template.currentData()?.color || getFallbackLabelColor();
tpl.currentColor.set(selectedColor);
},
// #5514: picking a color from the native color wheel stores a custom hex.
'input .js-label-color-wheel'(event, tpl) {
const value = event.currentTarget.value;
if (isHexColor(value)) {
tpl.currentColor.set(value);
}
},
});
Template.createLabelPopup.helpers({
@@ -131,7 +144,16 @@ Template.createLabelPopup.events({
? selectedColorIcon.closest('.js-palette-color')
: null;
const selectedColorData = selectedPaletteNode && Blaze.getData(selectedPaletteNode);
const color = selectedColorData?.color || getFallbackLabelColor();
// #5514: a named swatch (has the check icon) wins; otherwise fall back to
// the custom color-wheel hex, then to the default palette color.
let color = selectedColorData?.color;
if (!color) {
const wheel = templateInstance.find('.js-label-color-wheel');
if (wheel && isHexColor(wheel.value)) {
color = wheel.value;
}
}
color = color || getFallbackLabelColor();
board.addLabel(name, color);
Popup.back();
},
@@ -158,7 +180,16 @@ Template.editLabelPopup.events({
? selectedColorIcon.closest('.js-palette-color')
: null;
const selectedColorData = selectedPaletteNode && Blaze.getData(selectedPaletteNode);
const color = selectedColorData?.color || getFallbackLabelColor();
// #5514: a named swatch (has the check icon) wins; otherwise fall back to
// the custom color-wheel hex, then to the default palette color.
let color = selectedColorData?.color;
if (!color) {
const wheel = templateInstance.find('.js-label-color-wheel');
if (wheel && isHexColor(wheel.value)) {
color = wheel.value;
}
}
color = color || getFallbackLabelColor();
board.editLabel(this._id, name, color);
Popup.back();
},
+27
View File
@@ -119,6 +119,22 @@
margin-inline-end: 0.4vw;
margin-bottom: 4px;
}
/* Keep text labels on a single compact line. The label name is rendered
inside a `.viewer`, whose global `min-height: 2.5vh` otherwise forces every
label to roughly double height on the minicard. */
.minicard .minicard-labels .card-label {
min-height: 0;
padding: 1px 6px;
line-height: 1.3;
white-space: nowrap;
}
.minicard .minicard-labels .card-label .viewer {
min-height: 0;
display: inline;
}
.minicard .minicard-labels .card-label .viewer p {
display: inline;
}
.minicard .minicard-labels-no-text {
display: flex;
flex-wrap: wrap;
@@ -167,6 +183,13 @@
}
.minicard .minicard-title {
margin-inline-end: 1.5vw;
/* #6444: isolate each title's bidirectional context. The title is a
dir="auto" .viewer; under a global dir="rtl" document, non-isolated
dir="auto" runs share bidi state, so typing a strong RTL (e.g. Arabic)
character into another list's dir="auto" composer re-resolved the shared
context and visibly reflowed OTHER lists' minicard titles (no data change,
reverts on refresh). Isolation makes each title a self-contained run. */
unicode-bidi: isolate;
}
.minicard .minicard-title .card-number {
color: #b3b3b3;
@@ -432,6 +455,10 @@
min-height: 50px;
margin-bottom: 20px;
overflow-y: auto;
/* #6444: isolate the composer's dir="auto" bidi run so typing a strong RTL
character here cannot perturb the rendering of the surrounding minicard
titles under a dir="rtl" document. */
unicode-bidi: isolate;
}
.parent-prefix {
color: #b3b3b3;
+13 -3
View File
@@ -3,7 +3,8 @@ template(name="minicard")
class="{{#if isLinkedCard}}linked-card{{/if}}"
class="{{#if isLinkedBoard}}linked-board{{/if}}"
class="{{agingClass}}"
class="{{#if colorClass}}minicard-{{colorClass}}{{/if}}")
class="{{#if colorClass}}minicard-{{colorClass}}{{/if}}"
style="{{colorStyle}}")
if canMoveCard
if isTouchScreenOrShowDesktopDragHandles
.handle
@@ -93,11 +94,11 @@ template(name="minicard")
.minicard-labels(class="{{#if hiddenMinicardLabelText}}minicard-labels-no-text{{/if}}")
each labels
unless hiddenMinicardLabelText
span.js-card-label.card-label(class="card-label-{{color}}" title=name)
span.js-card-label.card-label(class="{{labelColorClass color}}" style="{{labelColorStyle color}}" title=name)
+viewer
= name
if hiddenMinicardLabelText
.minicard-label(class="card-label-{{color}}" title="{{name}}")
.minicard-label(class="{{labelColorClass color}}" style="{{labelColorStyle color}}" title="{{name}}")
.minicard-custom-fields
each customFieldsWD
@@ -215,6 +216,15 @@ template(name="minicard")
i.fa.fa-globe
span.badge-text.check-list-text {{subtasksFinishedCount}}/{{allSubtasksCount}}
//{{subtasksFinishedCount}}/{{subtasksCount}} does not work because when a subtaks is archived, the count goes down
//- #6431: compact checklist item-count badge (finished/total). The outer
guard is a cheap boolean, so when the setting is off the checklist
counting below never runs.
if showChecklistCountBadge
if checklists.length
.badge(class="{{#if checklistFinished}}is-finished{{/if}}" title="{{_ 'checklists'}}")
span.badge-icon
i.fa.fa-check-square-o
span.badge-text.check-list-text {{checklistFinishedCount}}/{{checklistItemCount}}
if currentBoard.allowsCardSortingByNumber
if currentBoard.allowsCardSortingByNumberOnMinicard
.badge
+62 -18
View File
@@ -6,6 +6,11 @@ import uploadProgressManager from '../../lib/uploadProgressManager';
import { Utils } from '/client/lib/utils';
import ChecklistItems from '/models/checklistItems';
import Cards from '/models/cards';
import { resolveCoverId } from '/models/lib/linkedCardCover';
import {
parseChecklistItemTitles,
buildChecklistItemPayload,
} from '/models/lib/checklistItemTitles';
import { normalizeDependencies } from '/models/metadata/dependencies';
function getMinicardFlag(board, onMinicardField, legacyField, defaultValue) {
@@ -144,6 +149,14 @@ Template.minicard.helpers({
const board = this.board();
return getMinicardFlag(board, 'allowsSubtasksOnMinicard', 'allowsSubtasks', true);
},
// #6431: compact checklist item-count badge (finished/total) on the minicard.
// Opt-in, OFF by default. Only a cheap boolean read here; the actual checklist
// counting (checklistFinishedCount/checklistItemCount) is gated behind this in
// the template, so a board with the badge off spends no resources counting.
showChecklistCountBadge() {
const board = this.board();
return !!(board && board.allowsChecklistCountBadgeOnMinicard);
},
hiddenMinicardLabelText() {
const currentUser = ReactiveCache.getCurrentUser();
@@ -156,8 +169,12 @@ Template.minicard.helpers({
}
},
cover() {
if (!this.coverId) return null;
const attachment = ReactiveCache.getAttachment(this.coverId);
// #5666: for a linked card the cover lives on the real card it points at, so
// resolve the cover id through it (mirroring getTitle/getDue/...); a plain
// card resolves to its own coverId.
const coverId = resolveCoverId(this, id => ReactiveCache.getCard(id));
if (!coverId) return null;
const attachment = ReactiveCache.getAttachment(coverId);
if (!attachment) return null;
const coverLink = typeof attachment.link === 'function' ? attachment.link() : '';
if (!coverLink) return null;
@@ -209,7 +226,11 @@ Template.minicard.helpers({
// Show checklist if either:
// 1. Board-wide setting is enabled, OR
// 2. This specific checklist has the setting enabled
if (currentBoard.allowsChecklistAtMinicard || checklist.showChecklistAtMinicard) {
// #5565: use the same board field the sidebar toggle writes
// (`allowsChecklistsOnMinicard`); this previously checked a different,
// UI-less field (`allowsChecklistAtMinicard`), so the board toggle to show
// checklists on minicards had no effect.
if (currentBoard.allowsChecklistsOnMinicard || checklist.showChecklistAtMinicard) {
visibleChecklists.push(checklist);
}
});
@@ -364,6 +385,28 @@ Template.minicardChecklist.helpers({
},
});
// #6440: create the checklist item(s) for the minicard add-item form. Shared by
// the Save-button click handler and the (rarely reached) form-submit handler.
// The Save button needs an explicit click handler because the minicard — and so
// the add-item <form> — is rendered inside the `a.minicard-wrapper` anchor, where
// the native form `submit` event never reaches the Blaze event map; without this
// the "+" add-item on the minicard did nothing. The blank-input guard and the
// title parsing live in the pure, unit-tested models/lib/checklistItemTitles.js.
function addMinicardChecklistItems(textarea, checklist) {
if (!textarea || !checklist) return;
const titles = parseChecklistItemTitles(textarea.value);
if (titles.length === 0) return;
const items = checklist.items();
const lastItem = items[items.length - 1] || null;
let sortIndex = Utils.calculateIndexData(lastItem, null).base;
titles.forEach(title => {
ChecklistItems.insert(buildChecklistItemPayload(title, checklist, sortIndex));
sortIndex += 1;
});
textarea.value = '';
textarea.focus();
}
Template.minicardChecklist.events({
'click .js-convert-checklist-item-to-card'(event) {
event.stopPropagation();
@@ -405,25 +448,26 @@ Template.minicardChecklist.events({
}
$form.find('.js-close-inlined-form').trigger('click');
},
// #6440: explicit click handler for the minicard "+" add-item Save button.
// The native form `submit` event does not fire on the minicard (the form is
// inside the `a.minicard-wrapper` anchor), so — unlike card-detail — we cannot
// rely on `submit .js-add-checklist-item`. This mirrors the already-working
// `click .js-submit-edit-checklist-item-form` above.
'click .js-submit-add-checklist-item-form'(event) {
event.preventDefault();
event.stopPropagation();
const $form = $(event.currentTarget).closest('form');
const textarea = $form.find('textarea.js-add-checklist-item')[0];
const formData = Blaze.getData($form[0]) || Template.currentData() || {};
addMinicardChecklistItems(textarea, formData.checklist);
},
// Kept for completeness (e.g. card-detail-style contexts); on the minicard this
// rarely fires, so the click handler above is the real path. See #6440.
'submit .js-add-checklist-item'(event, tpl) {
event.preventDefault();
const textarea = tpl.find('textarea.js-add-checklist-item');
if (!textarea) return;
const title = textarea.value.trim();
const data = Template.currentData() || {};
const checklist = data.checklist;
if (!checklist || !title) return;
const items = checklist.items();
const lastItem = items[items.length - 1] || null;
const sortIndex = Utils.calculateIndexData(lastItem, null).base;
ChecklistItems.insert({
title,
checklistId: checklist._id,
cardId: checklist.cardId,
sort: sortIndex,
});
textarea.value = '';
textarea.focus();
addMinicardChecklistItems(textarea, data.checklist);
},
'click .js-delete-checklist-item': Popup.afterConfirm('checklistItemDelete', function () {
Popup.back();
@@ -0,0 +1,38 @@
/**
* Pure helpers for displaying the status (current list / board) of a subtask.
*
* Issue #6091 "Visible status of sub-tasks": when viewing a card's subtasks,
* show each subtask's current list name (and board, when the subtask lives on a
* different board than the parent card).
*
* Kept dependency-free so it can be unit tested in isolation (mocha + chai).
*/
/**
* Build the human readable status label for a subtask.
*
* @param {Object} args
* @param {string} [args.listTitle] - Title of the list the subtask resides in.
* @param {string} [args.boardTitle] - Title of the board the subtask resides in.
* @param {boolean} [args.sameBoard=true] - Whether the subtask is on the same
* board as the parent card. When false, the board title is prefixed.
* @returns {string} The display string:
* - `listTitle` when the subtask is on the same board,
* - `boardTitle / listTitle` when it is on a different board,
* - a graceful fallback (whichever part is available) when one is missing,
* - empty string when nothing is known.
*/
export function subtaskStatusLabel({ listTitle, boardTitle, sameBoard = true } = {}) {
const list = (listTitle || '').trim();
const board = (boardTitle || '').trim();
if (sameBoard) {
return list;
}
// Different board: prefix with the board title when available.
if (board && list) {
return `${board} / ${list}`;
}
return board || list;
}
@@ -0,0 +1,85 @@
// Pure helpers for subtask navigation guards.
//
// #4762: "Subtask board is not accessible until reload".
// When a subtask lives on another board, that board may not yet be loaded in
// the ReactiveCache when the popup handler runs. Dereferencing the missing
// board (e.g. board._id) throws and the navigation silently fails until a
// reload populates the cache. Use this guard before navigating, mirroring the
// existing `if (board)` check in the js-go-to-subtask-board handler.
export function canNavigateToSubtaskBoard(board) {
return Boolean(board && board._id);
}
// #3743: "Subtask 'View it' button opens the parent card instead of the
// subtask". The navigation target must be derived from the SUBTASK card
// itself (its own board, slug and id) and never from the parent/current
// card. Centralise that here so the handler cannot accidentally reference
// the parent card again, and so the behaviour is unit-testable.
//
// Returns the FlowRouter 'card' route params taken from the subtask, or
// undefined for a malformed subtask (no usable card id / board id).
//
// #1853: "Subtask board id missing: cannot read property _id of undefined".
// The subtask often lives on ANOTHER board (the deposit/target board) whose
// document is not in minimongo while the parent card's board is open. In that
// case subtask.board() yields nothing; instead of crashing (the original
// TypeError) or silently doing nothing (the post-#4762 behaviour), fall back
// to the subtask's own boardId and the default 'board' slug — the 'card'
// route action only uses :boardId/:cardId (config/router.js) and its
// subscriptions load the board, so navigation succeeds without a reload.
// 'board' is the model's own default slug (models/boards.js).
export function subtaskNavTarget(subtask) {
if (!subtask) {
return undefined;
}
// Prefer the real card id (resolves linked subtask cards to their source);
// fall back to the plain _id when getRealId is unavailable (e.g. in tests).
const cardId =
(typeof subtask.getRealId === 'function' ? subtask.getRealId() : undefined) ||
subtask._id;
if (!cardId) {
// Malformed subtask document: nothing sane to navigate to.
return undefined;
}
const board = typeof subtask.board === 'function' ? subtask.board() : undefined;
if (canNavigateToSubtaskBoard(board)) {
return {
boardId: board._id,
slug: board.slug,
cardId,
swimlaneId: subtask.swimlaneId,
listId: subtask.listId,
};
}
if (subtask.boardId) {
// Board doc missing locally (#1853 / #4762): navigate by id and let the
// route load the board. The slug segment is cosmetic for the card route.
return {
boardId: subtask.boardId,
slug: 'board',
cardId,
swimlaneId: subtask.swimlaneId,
listId: subtask.listId,
};
}
// No board reference at all: broken subtask, don't navigate (and don't
// throw — the caller shows a warning instead).
return undefined;
}
// Same idea for the "Go to board" popup entry (js-go-to-subtask-board):
// prefer the loaded board's id/slug, fall back to the subtask's boardId so a
// not-yet-subscribed deposit board is still reachable (#1853).
export function subtaskBoardNavTarget(subtask) {
if (!subtask) {
return undefined;
}
const board = typeof subtask.board === 'function' ? subtask.board() : undefined;
if (canNavigateToSubtaskBoard(board)) {
return { id: board._id, slug: board.slug };
}
if (subtask.boardId) {
return { id: subtask.boardId, slug: 'board' };
}
return undefined;
}
+16
View File
@@ -192,3 +192,19 @@ body.grey-icons-enabled .subtasks-item .check-box-unicode {
padding: 6px 10px 6px 10px;
order: 2;
}
/* #6091: read-only status (current list / board) of a subtask */
.subtask-title .subtask-status {
order: 1;
flex-shrink: 0;
margin: 0 0.5em;
padding-top: 6px;
color: #8c8c8c;
font-size: 0.85em;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
max-width: 40%;
}
.subtask-title .subtask-status i.fa {
margin-inline-end: 4px;
}
+4
View File
@@ -35,6 +35,10 @@ template(name="subtaskDetail")
h2.title
+viewer
= subtask.title
if subtaskStatus
span.subtask-status(title="{{_ 'list'}}")
i.fa.fa-list-ul
| {{ subtaskStatus }}
template(name="addSubtaskItemForm")
textarea.js-add-subtask-item(rows='1' autofocus dir="auto")
+73 -70
View File
@@ -2,6 +2,12 @@ import { ReactiveCache } from '/imports/reactiveCache';
import { FlowRouter } from 'meteor/ostrio:flow-router-extra';
import Cards from '/models/cards';
import { Filter } from '/client/lib/filter';
import { subtaskStatusLabel } from './subtaskStatusHelpers';
import {
subtaskNavTarget,
subtaskBoardNavTarget,
} from './subtaskViewHelpers';
import { Utils } from '/client/lib/utils';
Template.subtasks.events({
'click .js-open-subtask-details-menu'(event) {
@@ -17,66 +23,30 @@ Template.subtasks.events({
const textarea = tpl.find('textarea.js-add-subtask-item');
const title = textarea.value.trim();
const cardId = Template.currentData().cardId;
const card = ReactiveCache.getCard(cardId);
const sortIndex = -1;
const crtBoard = ReactiveCache.getBoard(card.boardId);
const targetBoard = await crtBoard.getDefaultSubtasksBoardAsync();
if (!targetBoard) {
return;
}
const targetList = await targetBoard.getDefaultSubtasksListAsync();
if (!targetList) {
return;
}
const listId = targetList._id;
//Get the full swimlane data for the parent task.
const parentSwimlane = ReactiveCache.getSwimlane({
boardId: crtBoard._id,
_id: card.swimlaneId,
});
//find the swimlane of the same name in the target board.
const targetSwimlane = parentSwimlane
? ReactiveCache.getSwimlane({
boardId: targetBoard._id,
title: parentSwimlane.title,
})
: undefined;
//If no swimlane with a matching title exists in the target board, fall back to the default swimlane.
const swimlaneId =
targetSwimlane === undefined
? targetBoard.getDefaultSwimline()._id
: targetSwimlane._id;
const nextCardNumber = await targetBoard.getNextCardNumber();
if (title) {
const _id = await Cards.insertAsync({
title,
parentId: cardId,
members: [],
labelIds: [],
customFields: [],
listId,
boardId: targetBoard._id,
sort: sortIndex,
swimlaneId,
type: 'cardType-card',
cardNumber: nextCardNumber,
});
// Subtask creation is performed server-side by the `addSubtaskCard` Meteor
// method, so the default subtasks board/list/swimlane are resolved (and
// lazily created exactly once) on the server. This prevents the client
// from creating duplicate subtasks boards / swimlanes / columns
// (#3868 / #5788 / #2256) and lets multiple subtasks be created reliably
// (#4782), and the method applies the destination board's automatic
// custom fields to the new subtask (#4037 / #3562).
const _id = await Meteor.callAsync('addSubtaskCard', cardId, title);
// In case the filter is active we need to add the newly inserted card in
// the list of exceptions -- cards that are not filtered. Otherwise the
// card will disappear instantly.
// See https://github.com/wekan/wekan/issues/80
Filter.addException(_id);
if (_id) {
// In case the filter is active we need to add the newly inserted card in
// the list of exceptions -- cards that are not filtered. Otherwise the
// card will disappear instantly.
// See https://github.com/wekan/wekan/issues/80
Filter.addException(_id);
setTimeout(() => {
tpl.$('.add-subtask-item')
.last()
.click();
}, 100);
setTimeout(() => {
tpl.$('.add-subtask-item')
.last()
.click();
}, 100);
}
}
textarea.value = '';
textarea.focus();
@@ -111,13 +81,32 @@ Template.subtasks.onCreated(function () {
Template.subtasks.helpers({
isBoardAdmin() {
return ReactiveCache.getCurrentUser().isBoardAdmin();
return ReactiveCache.getCurrentUser()?.isBoardAdmin();
},
toggleDeleteDialog() {
return Template.instance().toggleDeleteDialog;
},
});
Template.subtaskDetail.helpers({
// #6091: show the subtask's current status, i.e. the list it resides in
// (prefixed with the board title when the subtask lives on another board
// than the parent card).
subtaskStatus() {
const subtask = this.subtask;
if (!subtask) {
return '';
}
const list = subtask.list && subtask.list();
const listTitle = list ? list.title : '';
const board = subtask.board && subtask.board();
const boardTitle = board ? board.title : '';
const parentCard = Utils.getCurrentCard();
const sameBoard = !!parentCard && parentCard.boardId === subtask.boardId;
return subtaskStatusLabel({ listTitle, boardTitle, sameBoard });
},
});
Template.subtaskItemDetail.events({
async 'click .js-subtasks-item .check-box-container'() {
const item = Template.currentData().item;
@@ -129,7 +118,7 @@ Template.subtaskItemDetail.events({
Template.subtaskActionsPopup.helpers({
isBoardAdmin() {
return ReactiveCache.getCurrentUser().isBoardAdmin();
return ReactiveCache.getCurrentUser()?.isBoardAdmin();
},
});
@@ -137,22 +126,36 @@ Template.subtaskActionsPopup.events({
'click .js-view-subtask'(event) {
if ($(event.target).hasClass('js-view-subtask')) {
const subtask = Template.currentData().subtask;
const board = subtask.board();
FlowRouter.go('card', {
boardId: board._id,
slug: board.slug,
cardId: subtask._id,
swimlaneId: subtask.swimlaneId,
listId: subtask.listId,
});
// #3743: open the SUBTASK card itself, not the parent/current card.
// subtaskNavTarget derives boardId/slug/cardId from the subtask only.
// #1853 / #4762: when the subtask's board (often a DIFFERENT deposit
// board) is not in minimongo yet, it falls back to the subtask's own
// boardId so the route loads the board — no TypeError, no dead button.
// It only returns undefined for a truly broken subtask document.
const target = subtaskNavTarget(subtask);
if (target) {
FlowRouter.go('card', target);
} else {
// Broken subtask (no card id / board id): warn instead of throwing.
console.warn(
'Cannot view subtask: missing board/card id on subtask',
subtask && subtask._id,
);
}
}
},
'click .js-go-to-subtask-board'() {
const subtask = Template.currentData().subtask;
const board = subtask.board();
if (board) {
// #1853: fall back to subtask.boardId when the board doc is not loaded.
const target = subtaskBoardNavTarget(subtask);
if (target) {
Popup.close();
FlowRouter.go('board', { id: board._id, slug: board.slug });
FlowRouter.go('board', target);
} else {
console.warn(
'Cannot go to subtask board: missing board id on subtask',
subtask && subtask._id,
);
}
},
'click .js-delete-subtask' : Popup.afterConfirm('subtaskDelete', async function () {
@@ -169,6 +172,6 @@ Template.editSubtaskItemForm.helpers({
return ReactiveCache.getUser(this.userId);
},
isBoardAdmin() {
return ReactiveCache.getCurrentUser().isBoardAdmin();
return ReactiveCache.getCurrentUser()?.isBoardAdmin();
},
});
+19
View File
@@ -298,6 +298,25 @@ textarea::-moz-placeholder {
font-size: clamp(20px, 4vw, 26px);
margin: 0.5vh 1.5vw;
}
/* CJK (Japanese/Chinese/Korean) labels contain no spaces, so browsers may
insert a line break between any two characters. In the narrow add-card /
edit footers this made short labels such as "追加" (Add) and "リンク"
(Link) wrap mid-word. `word-break: keep-all` forbids breaks inside CJK
words while leaving Latin wrapping behavior unchanged, and `flex-wrap`
lets the footer wrap between its links instead of inside them.
See https://github.com/wekan/wekan/issues/4023 */
.edit-controls,
.add-controls {
flex-wrap: wrap;
word-break: keep-all;
}
.edit-controls button[type=submit],
.add-controls button[type=submit] {
white-space: nowrap;
}
.add-controls .quiet {
white-space: nowrap;
}
[type="checkbox"]:not(:checked),
[type="checkbox"]:checked {
position: absolute;
+34 -9
View File
@@ -135,10 +135,14 @@ body.list-resizing-active * {
flex-direction: column !important;
}
/* Ensure the width persists after resize is complete */
.js-swimlane .list[style*="--list-width"],
.dragscroll .list[style*="--list-width"],
[id^="swimlane-"] .list[style*="--list-width"] {
/* Ensure the width persists after resize is complete.
Exclude collapsed lists: a collapsed list keeps its inline --list-width custom
property, and without :not() this !important rule overrode the 30px collapsed
width, so collapsing a list that had a custom width left it full width.
See https://github.com/wekan/wekan/issues/5892 */
.js-swimlane .list[style*="--list-width"]:not(.list-collapsed),
.dragscroll .list[style*="--list-width"]:not(.list-collapsed),
[id^="swimlane-"] .list[style*="--list-width"]:not(.list-collapsed) {
/* Maintain the width after resize */
width: var(--list-width, auto) !important;
min-width: var(--list-width, auto) !important;
@@ -253,10 +257,12 @@ body.list-resizing-active * {
height: 15vh;
}
.list.list-collapsed {
flex: none;
min-width: 30px;
max-width: 30px;
width: 30px;
flex: none !important;
/* !important so a custom per-list --list-width never keeps a collapsed list
full width (see https://github.com/wekan/wekan/issues/5892) */
min-width: 30px !important;
max-width: 30px !important;
width: 30px !important;
min-height: 60vh;
height: 60vh;
overflow: visible;
@@ -730,9 +736,28 @@ form.inlined-form .list-composer {
flex: 1 1 auto;
flex-direction: column;
display: flex;
overflow-y: auto;
/* #5439: always show a scrollbar on the list body across desktop and mobile
browsers (overlay scrollbars on macOS/iOS/Android/Firefox otherwise auto-
hide it). Keep these declarations in sync with models/lib/scrollbarCss.js
(alwaysVisibleScrollbarCss), which is unit tested. */
overflow-y: scroll;
scrollbar-width: thin;
scrollbar-color: rgba(0, 0, 0, 0.35) rgba(0, 0, 0, 0.08);
scrollbar-gutter: stable;
padding: 5px 11px;
}
.list-body::-webkit-scrollbar {
width: 10px;
height: 10px;
-webkit-appearance: none;
}
.list-body::-webkit-scrollbar-track {
background: rgba(0, 0, 0, 0.08);
}
.list-body::-webkit-scrollbar-thumb {
background: rgba(0, 0, 0, 0.35);
border-radius: 5px;
}
.list-body .minicards {
flex-grow: 1;
flex-shrink: 0;
+3 -2
View File
@@ -1,11 +1,12 @@
template(name='list')
.list.js-list(id="js-list-{{_id}}"
style="{{#unless collapsed}}min-width:{{listWidth}}px;max-width:{{listConstraint}}px;{{/unless}}"
style="{{#unless collapsed}}{{#unless autoWidth}}--list-width:{{listWidth}}px;{{/unless}}{{/unless}}"
class="{{#if collapsed}}list-collapsed{{/if}} {{#if autoWidth}}list-auto-width{{/if}} {{#if isMiniScreen}}mobile-view{{/if}}")
+listHeader
unless collapsed
+listBody
.list-resize-handle.js-list-resize-handle.nodragscroll
if canResizeList
.list-resize-handle.js-list-resize-handle.nodragscroll
template(name='miniList')
a.mini-list.js-select-list.js-list(id="js-list-{{_id}}" class="{{#if isMiniScreen}}mobile-view{{/if}}")
+305 -170
View File
@@ -3,10 +3,216 @@ import { TAPi18n } from '/imports/i18n';
import { EscapeActions } from '/client/lib/escapeActions';
import { MultiSelection } from '/client/lib/multiSelection';
import { Utils } from '/client/lib/utils';
import Cards from '/models/cards';
import {
isDegenerateSortGap,
computeRepairedDropIndex,
} from '/models/lib/cardSortRepair';
require('/client/lib/jquery-ui.js')
const { calculateIndex } = Utils;
// ---------------------------------------------------------------------------
// #6409 List width: a single, simple model.
//
// * Each list has ONE fixed width.
// * SHARED mode (board default): width lives in `lists.width` and is the same
// for everyone; only members with board write access can change it.
// * PERSONAL mode (board setting `allowsPersonalListWidth`): each user keeps
// their own width in their profile (or localStorage when not logged in),
// falling back to the shared width and then the default.
//
// The old per-list "min width / max width / automatic" knobs are gone — the
// rendered width is now a single hard value (see list.jade).
//
// #5659: the default/minimum width and the resolution order live in ONE
// Meteor-free module shared with models/users.js, so every path (member,
// anonymous public-board visitor, fixed mode) falls back to the SAME default
// and all lists render the same width when nothing is customized.
// ---------------------------------------------------------------------------
import {
DEFAULT_LIST_WIDTH,
MIN_LIST_WIDTH,
resolveListWidth,
} from '/models/lib/listWidth';
function isPersonalListWidth(boardId) {
const board = ReactiveCache.getBoard(boardId);
return !!(board && board.allowsPersonalListWidth);
}
// #6409 Auto-width follows the same scope as fixed widths:
// * personal mode -> the user's own profile.autoWidthBoards
// * shared mode -> the board's `autoWidth` (same for everyone)
function effectiveAutoWidth(boardId) {
if (isPersonalListWidth(boardId)) {
const user = ReactiveCache.getCurrentUser();
return !!(user && user.isAutoWidth(boardId));
}
const board = ReactiveCache.getBoard(boardId);
return !!(board && board.autoWidth);
}
function readAnonListWidth(boardId, listId) {
try {
const stored = localStorage.getItem('wekan-list-widths');
if (stored) {
const widths = JSON.parse(stored);
const w = widths[boardId] && widths[boardId][listId];
if (typeof w === 'number' && w >= MIN_LIST_WIDTH) return w;
}
} catch (e) {
console.warn('Error reading list width from localStorage:', e);
}
return null;
}
// ---------------------------------------------------------------------------
// #5729 Fixed (same) width for all lists.
//
// A per-viewer, per-board toggle that makes EVERY list render at a single
// shared value, and makes dragging any list update that one value (so all lists
// change together). Stored exactly like the personal width:
// * logged-in -> profile.fixedListWidthBoards / profile.fixedListWidths
// * anonymous -> localStorage (mirrors readAnonListWidth)
// ---------------------------------------------------------------------------
function readAnonFixedListWidthEnabled(boardId) {
try {
const stored = localStorage.getItem('wekan-fixed-list-width-enabled');
if (stored) {
const flags = JSON.parse(stored);
return flags[boardId] === true;
}
} catch (e) {
console.warn('Error reading fixed list width flag from localStorage:', e);
}
return false;
}
function readAnonFixedListWidth(boardId) {
try {
const stored = localStorage.getItem('wekan-fixed-list-width');
if (stored) {
const widths = JSON.parse(stored);
const w = widths[boardId];
if (typeof w === 'number' && w >= MIN_LIST_WIDTH) return w;
}
} catch (e) {
console.warn('Error reading fixed list width from localStorage:', e);
}
return DEFAULT_LIST_WIDTH;
}
// Whether the current viewer has fixed width mode enabled for this board.
function isFixedListWidth(boardId) {
const user = ReactiveCache.getCurrentUser();
if (user) {
return !!user.isFixedListWidth(boardId);
}
return readAnonFixedListWidthEnabled(boardId);
}
// The single width every list should use when fixed width mode is enabled.
function fixedListWidthValue(boardId) {
const user = ReactiveCache.getCurrentUser();
if (user) {
return user.getFixedListWidth(boardId);
}
return readAnonFixedListWidth(boardId);
}
// Persist the single fixed width for the whole board (anon localStorage).
function saveAnonFixedListWidth(boardId, width) {
try {
const stored = localStorage.getItem('wekan-fixed-list-width');
const widths = stored ? JSON.parse(stored) : {};
widths[boardId] = width;
localStorage.setItem('wekan-fixed-list-width', JSON.stringify(widths));
} catch (e) {
console.warn('Error saving fixed list width to localStorage:', e);
}
}
function effectiveListWidth(list) {
if (!list) return DEFAULT_LIST_WIDTH;
// #5659: all inputs are gathered here, but the fallback order and the ONE
// default width live in models/lib/listWidth.js (shared + unit tested).
const fixedEnabled = isFixedListWidth(list.boardId);
const personalMode = isPersonalListWidth(list.boardId);
let personalWidth = null;
if (personalMode) {
const user = ReactiveCache.getCurrentUser();
if (user) {
const widths = user.getListWidths();
personalWidth = widths[list.boardId] && widths[list.boardId][list._id];
} else {
personalWidth = readAnonListWidth(list.boardId, list._id);
}
}
return resolveListWidth({
// #5729 In fixed width mode every list renders at the single shared value.
fixedEnabled,
fixedWidth: fixedEnabled ? fixedListWidthValue(list.boardId) : null,
sharedWidth: list.width,
personalMode,
personalWidth,
});
}
// Can the current user change THIS list's width by dragging?
// - never while the board/list is in auto-width mode (the width is computed)
// - personal mode: always (it only affects their own view)
// - shared mode: only with board write access
function canResizeList(list) {
if (!list) return false;
if (effectiveAutoWidth(list.boardId)) return false;
// #5729 Fixed width is the viewer's own per-board setting, so any viewer
// (logged-in or anonymous) may drag-resize; the change applies to all lists.
if (isFixedListWidth(list.boardId)) return true;
if (isPersonalListWidth(list.boardId)) return true;
return Utils.canModifyBoard();
}
// Persist a new width to the place that matches the current board mode.
function saveListWidth(list, width) {
if (!list) return;
const boardId = list.boardId;
const listId = list._id;
const user = ReactiveCache.getCurrentUser();
// #5729 In fixed width mode, persist to the single per-board value instead of
// the per-list width, so EVERY list re-renders at the new width.
if (isFixedListWidth(boardId)) {
if (user) {
Meteor.call('setFixedListWidth', boardId, width, error => {
if (error) console.error('Error saving fixed list width:', error);
});
} else {
saveAnonFixedListWidth(boardId, width);
}
return;
}
if (isPersonalListWidth(boardId)) {
if (user) {
Meteor.call('applyListWidthToStorage', boardId, listId, width, width);
} else {
try {
const stored = localStorage.getItem('wekan-list-widths');
const widths = stored ? JSON.parse(stored) : {};
if (!widths[boardId]) widths[boardId] = {};
widths[boardId][listId] = width;
localStorage.setItem('wekan-list-widths', JSON.stringify(widths));
} catch (e) {
console.warn('Error saving personal list width to localStorage:', e);
}
}
} else if (user) {
// Shared width: server also enforces board membership.
Meteor.call('applyListWidth', boardId, listId, width, width, error => {
if (error) console.error('Error saving shared list width:', error);
});
}
}
Template.list.onCreated(function () {
this.newCardFormIsVisible = new ReactiveVar(true);
@@ -86,7 +292,35 @@ Template.list.onRendered(function () {
const prevCardDom = ui.item.prev('.js-minicard').get(0);
const nextCardDom = ui.item.next('.js-minicard').get(0);
const nCards = MultiSelection.isActive() ? MultiSelection.count() : 1;
const sortIndex = calculateIndex(prevCardDom, nextCardDom, nCards);
let sortIndex = calculateIndex(prevCardDom, nextCardDom, nCards);
// #3826: cards created by the "add subtask" flow were all inserted with
// a constant sort of -1, so a list full of subtask cards contains only
// ties. No number lies strictly between two equal sorts, so
// calculateIndex returns base === neighbour sort with increment 0: the
// write is then discarded by Card.move()'s no-op guard and the card
// snaps back (and a multi-selection drop would give every selected card
// the SAME sort, losing their relative order). When the drop landed in
// such a degenerate gap, capture the target list's sibling cards in
// their current visual order (before sortable('cancel') reshuffles the
// DOM) so their sorts can be repaired below.
const prevCardData = prevCardDom ? Blaze.getData(prevCardDom) : null;
const nextCardData = nextCardDom ? Blaze.getData(nextCardDom) : null;
let orderedSiblingCards = null;
if (
isDegenerateSortGap(
prevCardData ? prevCardData.sort : null,
nextCardData ? nextCardData.sort : null,
)
) {
orderedSiblingCards = ui.item
.parent()
.children(itemsSelector)
.not(ui.item)
.toArray()
.map(el => Blaze.getData(el))
.filter(Boolean);
}
const listData = Blaze.getData(ui.item.parents('.list').get(0));
const listId = listData._id;
const currentBoard = Utils.getCurrentBoard();
@@ -113,6 +347,25 @@ Template.list.onRendered(function () {
// Blaze with the below query.
$cards.sortable('cancel');
// #3826: the drop landed between two cards whose sorts do not strictly
// increase (duplicate -1 sorts from subtask creation, or legacy data).
// Repair the sibling sorts with the minimal bumps that make the visible
// order strictly increasing, then recompute the drop index from the
// repaired neighbours: base now falls strictly between them and the
// increment is strictly positive (distinct sorts for a multi-selection).
if (orderedSiblingCards && prevCardData && nextCardData) {
const repairedDrop = computeRepairedDropIndex(
orderedSiblingCards,
prevCardData,
nextCardData,
nCards,
);
repairedDrop.updates.forEach(u => {
Cards.update(u._id, { $set: { sort: u.sort } });
});
sortIndex = { base: repairedDrop.base, increment: repairedDrop.increment };
}
if (MultiSelection.isActive()) {
ReactiveCache.getCards(MultiSelection.getMongoSelector(), { sort: ['sort'] }).forEach((card, i) => {
const newSwimlaneId = targetSwimlaneId
@@ -136,37 +389,39 @@ Template.list.onRendered(function () {
if (boardComponent) boardComponent.setIsDragging(false);
},
sort(event, ui) {
const $boardCanvas = $('.board-canvas');
const boardCanvas = $boardCanvas[0];
if (event.pageX < 10) { // scroll to the left
boardCanvas.scrollLeft -= 15;
ui.helper[0].offsetLeft -= 15;
// #443: the HORIZONTAL scroller is the .js-lists lane (.swimlane has
// overflow: auto), NOT .board-canvas, which only overflows vertically —
// the old code compared against a scrollLeftMax of 0 and never fired, so
// dragging a card toward an off-screen list never auto-scrolled the board.
const { computeEdgeScroll, findLaneUnderPointer } = require('/imports/lib/boardAutoScroll');
const lanes = document.querySelectorAll('.js-lists');
const rects = Array.prototype.map.call(lanes, el => el.getBoundingClientRect());
const laneIndex = findLaneUnderPointer(rects, event.clientX, event.clientY);
if (laneIndex !== -1) {
const nextLeft = computeEdgeScroll({
pointer: event.clientX,
lowEdge: rects[laneIndex].left,
highEdge: rects[laneIndex].right,
scrollPos: lanes[laneIndex].scrollLeft,
scrollSize: lanes[laneIndex].scrollWidth,
clientSize: lanes[laneIndex].clientWidth,
});
if (nextLeft !== null) lanes[laneIndex].scrollLeft = nextLeft;
}
if (
event.pageX > boardCanvas.offsetWidth - 10 &&
boardCanvas.scrollLeft < $boardCanvas.data('scrollLeftMax') // don't scroll more than possible
) { // scroll to the right
boardCanvas.scrollLeft += 15;
// vertical auto-scroll stays on the board canvas
const canvas = document.querySelector('.board-canvas');
if (canvas) {
const crect = canvas.getBoundingClientRect();
const nextTop = computeEdgeScroll({
pointer: event.clientY,
lowEdge: crect.top,
highEdge: crect.bottom,
scrollPos: canvas.scrollTop,
scrollSize: canvas.scrollHeight,
clientSize: canvas.clientHeight,
});
if (nextTop !== null) canvas.scrollTop = nextTop;
}
if (
event.pageY > boardCanvas.offsetHeight - 10 &&
event.pageY + boardCanvas.scrollTop < $boardCanvas.data('scrollTopMax') // don't scroll more than possible
) { // scroll to the bottom
boardCanvas.scrollTop += 15;
}
if (event.pageY < 10) { // scroll to the top
boardCanvas.scrollTop -= 15;
}
},
activate(event, ui) {
const $boardCanvas = $('.board-canvas');
const boardCanvas = $boardCanvas[0];
// scrollTopMax and scrollLeftMax only available at Firefox (https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollTopMax)
// https://www.it-swarm.com.de/de/javascript/so-erhalten-sie-den-maximalen-dokument-scrolltop-wert/1069126844/
$boardCanvas.data('scrollTopMax', boardCanvas.scrollHeight - boardCanvas.clientTop);
// https://stackoverflow.com/questions/5138373/how-do-i-get-the-max-value-of-scrollleft/5704386#5704386
$boardCanvas.data('scrollLeftMax', boardCanvas.scrollWidth - boardCanvas.clientWidth);
},
});
@@ -194,6 +449,13 @@ Template.list.onRendered(function () {
const currentBoardId = Tracker.nonreactive(() => {
return Session.get('currentBoard');
});
// #1554: reactive dependency so newly added / re-rendered minicards are
// (re)initialized as droppable for label/member drags. The dependency
// (Cards.find(...).fetch()) was dropped in 7673c77c5, so the autorun ran
// ONCE per list render and cards added afterwards silently rejected
// sidebar label/member drops until the board was re-entered. Re-running
// .droppable() on initialized elements is an idempotent option refresh.
ReactiveCache.getCards({ boardId: currentBoardId });
Tracker.afterFlush(() => {
$cards.find(itemsSelector).droppable({
hoverClass: 'draggable-hover-card',
@@ -217,63 +479,17 @@ Template.list.onRendered(function () {
Template.list.helpers({
listWidth() {
const user = ReactiveCache.getCurrentUser();
const list = Template.currentData();
if (!list) return 270; // Return default width if list is not available
if (user) {
// For logged-in users, get from user profile
return user.getListWidthFromStorage(list.boardId, list._id);
} else {
// For non-logged-in users, get from localStorage
try {
const stored = localStorage.getItem('wekan-list-widths');
if (stored) {
const widths = JSON.parse(stored);
if (widths[list.boardId] && widths[list.boardId][list._id]) {
return widths[list.boardId][list._id];
}
}
} catch (e) {
console.warn('Error reading list width from localStorage:', e);
}
return 270; // Return default width if not found
}
return effectiveListWidth(Template.currentData());
},
listConstraint() {
const user = ReactiveCache.getCurrentUser();
const list = Template.currentData();
if (!list) return 550; // Return default constraint if list is not available
if (user) {
// For logged-in users, get from user profile
return user.getListConstraintFromStorage(list.boardId, list._id);
} else {
// For non-logged-in users, get from localStorage
try {
const stored = localStorage.getItem('wekan-list-constraints');
if (stored) {
const constraints = JSON.parse(stored);
if (constraints[list.boardId] && constraints[list.boardId][list._id]) {
return constraints[list.boardId][list._id];
}
}
} catch (e) {
console.warn('Error reading list constraint from localStorage:', e);
}
return 550; // Return default constraint if not found
}
// Whether to show the drag-resize handle for this list.
canResizeList() {
return canResizeList(Template.currentData());
},
autoWidth() {
const user = ReactiveCache.getCurrentUser();
const list = Template.currentData();
if (!user) {
// For non-logged-in users, auto-width is disabled
return false;
}
return user.isAutoWidth(list.boardId);
return !!list && effectiveAutoWidth(list.boardId);
},
collapsed() {
@@ -313,18 +529,12 @@ Template.list.onCreated(function () {
return;
}
// Helper to get autoWidth state
const getAutoWidth = () => {
const user = ReactiveCache.getCurrentUser();
if (!user) return false;
return user.isAutoWidth(list.boardId);
};
// Reactively show/hide resize handle based on collapse and auto-width state
// #6409: show the resize handle only when the list is not collapsed and the
// user is allowed to change this list's width (always in personal mode; only
// with board write access in shared mode).
tpl.autorun(() => {
const isAutoWidth = getAutoWidth();
const isCollapsed = Utils.getListCollapseState(list);
if (isCollapsed || isAutoWidth) {
if (isCollapsed || !canResizeList(list)) {
$resizeHandle.hide();
} else {
$resizeHandle.show();
@@ -334,25 +544,7 @@ Template.list.onCreated(function () {
let isResizing = false;
let startX = 0;
let startWidth = 0;
let minWidth = 270; // Minimum width matching system default
// Get listConstraint value
const getListConstraint = () => {
const user = ReactiveCache.getCurrentUser();
if (user) {
return user.getListConstraintFromStorage(list.boardId, list._id);
}
try {
const stored = localStorage.getItem('wekan-list-constraints');
if (stored) {
const constraints = JSON.parse(stored);
if (constraints[list.boardId] && constraints[list.boardId][list._id]) {
return constraints[list.boardId][list._id];
}
}
} catch (e) {}
return 550;
};
let minWidth = MIN_LIST_WIDTH; // Minimum width matching system default
// Read the horizontal page coordinate from either a jQuery mouse event
// or a native touch event (touchstart/move expose `touches`, touchend
@@ -412,7 +604,6 @@ Template.list.onCreated(function () {
const currentX = getEventPageX(e);
const deltaX = currentX - startX;
const finalWidth = Math.max(minWidth, startWidth + deltaX);
const listConstraint = getListConstraint();
// Ensure the final width is applied
$list[0].style.setProperty('--list-width', `${finalWidth}px`);
@@ -429,55 +620,9 @@ Template.list.onCreated(function () {
$('body').removeClass('list-resizing-active');
$('body').css('user-select', '');
// Save the new width using the existing system
const boardId = list.boardId;
const listId = list._id;
if (process.env.DEBUG === 'true') {
}
const currentUser = ReactiveCache.getCurrentUser();
if (currentUser) {
// For logged-in users, use server method
Meteor.call('applyListWidthToStorage', boardId, listId, finalWidth, listConstraint, (error, result) => {
if (error) {
console.error('Error saving list width:', error);
} else {
if (process.env.DEBUG === 'true') {
}
}
});
} else {
// For non-logged-in users, save to localStorage directly
try {
// Save list width
const storedWidths = localStorage.getItem('wekan-list-widths');
let widths = storedWidths ? JSON.parse(storedWidths) : {};
if (!widths[boardId]) {
widths[boardId] = {};
}
widths[boardId][listId] = finalWidth;
localStorage.setItem('wekan-list-widths', JSON.stringify(widths));
// Save list constraint
const storedConstraints = localStorage.getItem('wekan-list-constraints');
let constraints = storedConstraints ? JSON.parse(storedConstraints) : {};
if (!constraints[boardId]) {
constraints[boardId] = {};
}
constraints[boardId][listId] = listConstraint;
localStorage.setItem('wekan-list-constraints', JSON.stringify(constraints));
if (process.env.DEBUG === 'true') {
}
} catch (e) {
console.warn('Error saving list width/constraint to localStorage:', e);
}
}
// #6409: persist to the shared list width or the user's personal width,
// depending on the board's mode.
saveListWidth(list, finalWidth);
e.preventDefault();
};
@@ -502,16 +647,6 @@ Template.list.onCreated(function () {
e.stopPropagation();
});
// Reactively update resize handle visibility when auto-width or collapse changes
tpl.autorun(() => {
const collapsed = Utils.getListCollapseState(list);
if (getAutoWidth() || collapsed) {
$resizeHandle.hide();
} else {
$resizeHandle.show();
}
});
// Clean up on component destruction
tpl.view.onViewDestroyed(() => {
$(document).off('mousemove', doResize);
+36
View File
@@ -0,0 +1,36 @@
// Pure helpers for the "add list" affordance.
//
// Issue #6142: In "Lists" board-view mode there was no UI affordance to add a
// new list — only the "Swimlanes" mode rendered the trailing add-list composer.
// These helpers keep the (testable) decision logic out of the Blaze templates.
// Board-view modes in which an "add list" composer should be offered.
// Both the swimlanes view and the lists view let the user create a list; the
// other views (calendar, gantt, table) do not render the list composer.
export const ADD_LIST_VIEW_MODES = ['board-view-swimlanes', 'board-view-lists'];
// Returns true when the given board-view mode should show the add-list
// composer. Used so Lists mode gets the same affordance as Swimlanes mode.
export function canAddListInView(viewMode) {
return ADD_LIST_VIEW_MODES.indexOf(viewMode) !== -1;
}
// Decide which swimlane a newly created list should belong to when the user
// adds a list from a view that is not bound to a specific swimlane (e.g. the
// Lists view). Prefer an explicitly provided swimlane id, otherwise fall back
// to the board's default swimlane id.
//
// `board` only needs to expose a `getDefaultSwimline()` method (the WeKan
// Board model does); it may also be a plain object for testing.
export function defaultSwimlaneIdForBoard(board, explicitSwimlaneId) {
if (explicitSwimlaneId) {
return explicitSwimlaneId;
}
if (board && typeof board.getDefaultSwimline === 'function') {
const swimlane = board.getDefaultSwimline();
if (swimlane && swimlane._id) {
return swimlane._id;
}
}
return null;
}
+1 -1
View File
@@ -46,7 +46,7 @@ template(name="addCardForm")
if getLabels
.minicard-labels
each getLabels
.minicard-label(class="card-label-{{color}}" title="{{name}}")
.minicard-label(class="{{labelColorClass color}}" style="{{labelColorStyle color}}" title="{{name}}")
textarea.minicard-composer-textarea.js-card-title(autofocus dir="auto")
if members.get
.minicard-members.js-minicard-composer-members
+203 -19
View File
@@ -9,6 +9,14 @@ import Swimlanes from '/models/swimlanes';
import { Filter } from '/client/lib/filter';
import { MultiSelection } from '/client/lib/multiSelection';
import { Utils } from '/client/lib/utils';
import { isLinkableCardTarget } from '/models/lib/linkedCardTarget';
import { listCardsSelector } from '/models/lib/swimlaneFilter';
import { sortCardsByTitle } from '/models/lib/sortCardsByTitle';
import { isLazyCards, BoardListCardCounts, windowCountId } from '/client/lib/lazyCards';
import {
mutationsChangeDragGeometry,
findActiveCardDrag,
} from '/client/lib/cardDragGeometry';
import autosize from 'autosize';
// SubsManager removed for Meteor 3 migration
@@ -324,21 +332,50 @@ Template.listBody.helpers({
const tpl = Template.instance();
const limit = tpl.cardlimit.get();
const defaultSort = { sort: 1 };
const sortBy = Session.get('sortBy') ? Session.get('sortBy') : defaultSort;
const selector = {
listId: Template.currentData()._id,
archived: false,
};
if (swimlaneId) {
// Fallback: also show cards with no swimlaneId (null/empty) so that
// pre-migration / orphaned cards are always visible without a DB migration.
selector.$or = [
{ swimlaneId },
{ swimlaneId: null }, // null covers null AND missing field
{ swimlaneId: '' }, // empty string from shared-lists era
];
// Session is reset on page reload; fall back to the persisted card sort so a
// chosen sort (e.g. by due date) is remembered across reloads (#5886).
let sortBy = Session.get('sortBy');
if (!sortBy) {
try {
const stored = window.localStorage.getItem('wekan-cards-sortBy');
if (stored) {
sortBy = JSON.parse(stored);
}
} catch (e) {}
}
const ret = ReactiveCache.getCards(Filter.mongoSelector(selector), {
if (!sortBy) {
sortBy = defaultSort;
}
// #6441: build the swimlane-membership fallback as a single `swimlaneId:
// { $in: [...] }` clause (via the shared, unit-tested helper) instead of a
// bare top-level `$or`, so it never competes with the board Filter's own
// top-level `$or` (labels/members/exceptions) and the label filter applies
// board-wide across every swimlane.
// #6443: in the first swimlane also surface orphaned cards (a swimlaneId
// pointing at a deleted swimlane) so they are not invisible in swimlane view.
const list = Template.currentData();
const selector = listCardsSelector(
list._id,
swimlaneId,
list.orphanedCardsSwimlaneIds
? list.orphanedCardsSwimlaneIds(swimlaneId)
: undefined,
);
const mongoSelector = Filter.mongoSelector(selector);
// Lazy card loading: the board publication ships no cards, so subscribe to
// just this list/swimlane window (grows with `limit` as the user scrolls)
// plus its reactive total count. Default mode keeps everything in minimongo
// already, so these subscriptions are skipped.
if (isLazyCards() && list.boardId) {
tpl.subscribe('boardCardsWindow', list.boardId, mongoSelector, sortBy, limit);
tpl.subscribe(
'boardListCardCount',
windowCountId(list._id, swimlaneId),
list.boardId,
mongoSelector,
);
}
const ret = ReactiveCache.getCards(mongoSelector, {
// sort: ['sort'],
sort: sortBy,
limit,
@@ -349,6 +386,13 @@ Template.listBody.helpers({
showSpinner(swimlaneId) {
const tpl = Template.instance();
const list = Template.currentData();
if (isLazyCards()) {
// In lazy mode minimongo only holds the loaded window, so the total comes
// from the server count published into BoardListCardCounts.
const countDoc = BoardListCardCounts.findOne(windowCountId(list._id, swimlaneId));
const total = countDoc ? countDoc.count : 0;
return total > tpl.cardlimit.get();
}
return list.cards(swimlaneId).length > tpl.cardlimit.get();
},
@@ -413,6 +457,80 @@ Template.listBody.events({
},
});
// #2769 Card lands in the WRONG swimlane when it is dropped while a connected
// list's layout changed mid-drag. jQuery UI sortable snapshots the geometry
// of every connected `.js-minicards` container once at drag start
// (_mouseStart runs refreshPositions() BEFORE the `start` callback) and only
// re-snapshots after its own placeholder moves — never when Blaze mutates the
// DOM. Two such mutations routinely happen during a drag: another user's
// newly added card is reactively inserted into the target list (the issue's
// "target column where a new card is being added"), and the dragging user's
// own open add-card composer is closed by the `start` callback's
// EscapeActions call, AFTER the snapshot. Every list/swimlane below the
// change then shifts vertically while the cached rectangles stay put, so the
// drop resolves against a stale map: the placeholder is parked in the
// neighbouring swimlane's copy of the list (hence the reporter's "no drop
// shadow in the target column") and the stop handler's
// ui.item.parents('.swimlane') (client/components/lists/list.js) faithfully
// persists that wrong swimlane.
// Fix: watch each list's minicards for REAL DOM changes (Blaze insertions and
// removals — not jQuery UI's own placeholder/helper churn, which the library
// already follows with its own refresh) and re-cache the active drag's
// geometry with sortable('refresh'). The decision helpers are pure and unit
// tested in tests/cardDragGeometry.test.cjs.
Template.listBody.onRendered(function () {
const minicardsEl = this.find('.js-minicards');
if (!minicardsEl || typeof MutationObserver === 'undefined') {
return;
}
this.dragGeometryRefreshQueued = false;
this.dragGeometryObserver = new MutationObserver(mutations => {
// Cheapest gate first: no drag helper on the page means no drag at all
// (this observer also fires on every ordinary reactive card update).
if (!document.getElementsByClassName('ui-sortable-helper').length) {
return;
}
if (!mutationsChangeDragGeometry(mutations)) {
return;
}
if (this.dragGeometryRefreshQueued) {
return;
}
this.dragGeometryRefreshQueued = true;
// Coalesce bursts (Blaze can insert several nodes per flush); by the time
// the timeout runs, this tick's layout is final and measurable.
setTimeout(() => {
this.dragGeometryRefreshQueued = false;
const active = findActiveCardDrag(
$('.js-minicards')
.toArray()
.map(el => $.data(el, 'ui-sortable')),
);
if (active) {
try {
// Re-collects the items of every connected container and re-measures
// all container rectangles, so the pointer is matched against the
// CURRENT layout for the rest of the drag.
active.refresh();
} catch (e) {
// A failed re-measure must never break the drag itself.
}
}
}, 0);
});
this.dragGeometryObserver.observe(minicardsEl, {
childList: true,
subtree: true,
});
});
Template.listBody.onDestroyed(function () {
if (this.dragGeometryObserver) {
this.dragGeometryObserver.disconnect();
this.dragGeometryObserver = null;
}
});
function toggleValueInReactiveArray(reactiveValue, value) {
const array = reactiveValue.get();
const valueIndex = array.indexOf(value);
@@ -693,14 +811,19 @@ Template.linkCardPopup.helpers({
archived: false,
linkedId: { $nin: ownCardsIds },
_id: { $nin: ownCardsIds },
type: { $nin: ['template-card'] },
// #5808: never offer an existing linked card/board as a link target —
// linking to one builds a chain of linkedId pointers that renders the
// card inaccessible. Only real cards may be linked.
type: { $nin: ['template-card', 'cardType-linkedCard', 'cardType-linkedBoard'] },
};
if (tpl.selectedBoardId.get()) selector.boardId = tpl.selectedBoardId.get();
if (tpl.selectedSwimlaneId.get()) selector.swimlaneId = tpl.selectedSwimlaneId.get();
if (tpl.selectedListId.get()) selector.listId = tpl.selectedListId.get();
const ret = ReactiveCache.getCards(selector, { sort: { sort: 1 } });
return ret;
// #5394: sort the Cards dropdown alphabetically by title
// (case-insensitive) so a card can be found on boards with many cards.
return sortCardsByTitle(ret);
},
isTitleDefault(title) {
@@ -743,11 +866,48 @@ Template.linkCardPopup.events({
tpl.selectedListId.set($(evt.currentTarget).val());
},
async 'click .js-done'(evt, tpl) {
// LINK CARD
// LINK CARD (or, when no card is chosen, fall back to a board-level link
// so a whole board can be linked even when that board already has cards).
// https://github.com/wekan/wekan/issues/5715
evt.stopPropagation();
evt.preventDefault();
const linkedId = $('.js-select-cards option:selected').val();
if (!linkedId) {
const boardId = $('.js-select-boards option:selected').val();
// No board and no card selected: nothing to link.
if (!boardId) {
Popup.back();
return;
}
// A linkedBoard card for this board already exists; avoid duplicates.
if (ReactiveCache.getCard({ linkedId: boardId, archived: false })) {
Popup.back();
return;
}
const boardCardNumber = await tpl.board.getNextCardNumber();
const boardSortIndex = tpl.getSortIndex();
const boardCardId = Cards.insert({
title: $('.js-select-boards option:selected').text(), //dummy
listId: tpl.listId,
swimlaneId: tpl.swimlaneId,
boardId: tpl.boardId,
sort: boardSortIndex,
type: 'cardType-linkedBoard',
linkedId: boardId,
cardNumber: boardCardNumber,
});
Filter.addException(boardCardId);
Popup.back();
return;
}
// #5808: refuse to link to a linked card/board or to a card that links back
// to this board — those build a chain/cycle of linkedId pointers that renders
// the cards inaccessible. The <select> already filters these out, but its
// options can be stale, so re-check the resolved target here.
const targetCard = ReactiveCache.getCard(linkedId);
const ownCardsIds = tpl.board.cards().map(card => card.getRealId());
if (!isLinkableCardTarget(targetCard, ownCardsIds)) {
alert(TAPi18n.__('error-linked-card-not-allowed'));
Popup.back();
return;
}
@@ -924,13 +1084,37 @@ Template.searchElementPopup.events({
if (!tpl.isTemplateSearch || tpl.isCardTemplateSearch) {
// Card insertion
// 1. Common
// Compute the sort index BEFORE the first await: getSortIndex() reads
// Template.currentData(), and Blaze's current-view context is lost across
// an await, so calling it afterwards threw "There is no current view" and
// no card was created from the template. Capture it while still in the
// synchronous event/view context.
const sortIndex = tpl.getSortIndex();
element.cardNumber = await tpl.board.getNextCardNumber();
element.sort = tpl.getSortIndex();
element.sort = sortIndex;
// 1.A From template
if (tpl.isTemplateSearch) {
element.type = 'cardType-card';
element.linkedId = '';
_id = await element.copy(tpl.boardId, tpl.swimlaneId, tpl.listId);
// #5798: instantiate the template into the CURRENT board, not the
// templates board. For a template search tpl.boardId is the templates
// board (it is the search source), so copying with it created the card
// with boardId = templates board. The card still showed in the target
// list (the list query is by listId and the templates board is
// subscribed), but clicking it navigated to the templates board instead
// of opening the card. The target list/swimlane were already resolved on
// the current board.
// Instantiate into the board that OWNS the target list (where the user
// clicked "add card"). Deriving it from tpl.listId is reliable even when
// Utils.getCurrentBoard() (route/session state) has not settled yet — as
// on the slower CI production bundle, where falling back to tpl.boardId
// wrongly created the card on the templates board.
const targetList = ReactiveCache.getList(tpl.listId);
const targetBoardId =
(targetList || {}).boardId ||
(Utils.getCurrentBoard() || {})._id ||
tpl.boardId;
_id = await element.copy(targetBoardId, tpl.swimlaneId, tpl.listId);
// 1.B Linked card
} else {
_id = element.link(tpl.boardId, tpl.swimlaneId, tpl.listId);
+31 -20
View File
@@ -1,7 +1,8 @@
template(name="listHeader")
.list-header.js-list-header.nodragscroll(
class="{{#if limitToShowCardsCount}}list-header-card-count{{/if}}"
class=colorClass)
class=colorClass
style=colorStyle)
//- #459: keyboard/screen-reader list reordering (visually hidden, focusable).
.list-move-buttons.sr-only
a.js-list-move-left(href="#" role="button" aria-label="{{_ 'move-list-left'}}") {{_ 'move-list-left'}}
@@ -15,7 +16,7 @@ template(name="listHeader")
i.fa.fa-caret-left
else
if collapsed
if showCardsCountForList cards.length
if showCardsCountForList cardsCountWhole
br
span.cardCount {{cardsCount}}
if isMiniScreen
@@ -26,10 +27,10 @@ template(name="listHeader")
= title
if wipLimit.enabled
|&nbsp;(
span(class="{{#if exceededWipLimit}}highlight{{/if}}") {{cards.length}}
span(class="{{#if exceededWipLimit}}highlight{{/if}}") {{cardsCountWhole}}
|/#{wipLimit.value})
if showCardsCountForList cards.length
span.cardCount {{cardsCount}} {{cardsCountForListIsOne cards.length}}
if showCardsCountForList cardsCountWhole
span.cardCount {{cardsCount}} {{cardsCountForListIsOne cardsCountWhole}}
if hasNumberFieldsSum
| &nbsp;
span.list-sum-badge(title="{{_ 'sum-of-number-fields'}}") ∑ {{numberFieldsSum}}
@@ -47,11 +48,11 @@ template(name="listHeader")
= title
if wipLimit.enabled
|&nbsp;(
span(class="{{#if exceededWipLimit}}highlight{{/if}}") {{cards.length}}
span(class="{{#if exceededWipLimit}}highlight{{/if}}") {{cardsCountWhole}}
|/#{wipLimit.value})
unless collapsed
if showCardsCountForList cards.length
span.cardCount {{cardsCount}} {{cardsCountForListIsOne cards.length}}
if showCardsCountForList cardsCountWhole
span.cardCount {{cardsCount}} {{cardsCountForListIsOne cardsCountWhole}}
if hasNumberFieldsSum
| &nbsp;
span.list-sum-badge(title="{{_ 'sum-of-number-fields'}}") ∑ {{numberFieldsSum}}
@@ -207,7 +208,10 @@ template(name="listMorePopup")
span {{_ 'link-list'}}
= ' '
i.fa(class="{{#if currentBoard.isPublic}}fa-globe{{else}}fa-lock{{/if}}")
input.inline-input(type="text" readonly value="{{ rootUrl }}")
//- #6459: was {{ rootUrl }}, a helper that does not exist anywhere, so the
//- link input was always empty. absoluteUrl resolves a URL via a card on
//- this list.
input.inline-input(type="text" readonly value="{{ absoluteUrl }}")
| {{_ 'added'}}
span.date(title=list.createdAt) {{ displayDate createdAt 'LLL' }}
//unless currentUser.isWorker
@@ -252,17 +256,20 @@ template(name="wipLimitErrorPopup")
template(name="setListWidthPopup")
#js-list-width-edit
label {{_ 'set-list-width-value'}}
p
input.list-width-value(type="number" value="{{ listWidthValue }}" min="270")
input.list-constraint-value(type="number" value="{{ listConstraintValue }}" min="270")
input.list-width-apply(type="submit" value="{{_ 'apply'}}")
input.list-width-error
br
a.js-auto-width-board(
title="{{#if isAutoWidth}}{{_ 'click-to-disable-auto-width'}}{{else}}{{_ 'click-to-enable-auto-width'}}{{/if}}")
| {{#if isAutoWidth}}🗜️{{else}}📏{{/if}}
span {{_ 'auto-list-width'}}
unless isAutoWidth
label {{_ 'set-list-width-value'}}
p
input.list-width-value(type="number" value="{{ listWidthValue }}" min="270")
input.list-width-apply(type="submit" value="{{_ 'apply'}}")
input.list-width-error
if canChangeAutoWidth
a.js-toggle-auto-width(title="{{#if isAutoWidth}}{{_ 'click-to-disable-auto-width'}}{{else}}{{_ 'click-to-enable-auto-width'}}{{/if}}")
| {{#if isAutoWidth}}🗜️{{else}}📏{{/if}}
span {{_ 'auto-list-width'}}
a.js-toggle-fixed-list-width(title="{{#if isFixedListWidth}}{{_ 'click-to-disable-fixed-list-width'}}{{else}}{{_ 'click-to-enable-fixed-list-width'}}{{/if}}")
| {{#if isFixedListWidth}}✅{{else}}⬜{{/if}}
span {{_ 'fixed-list-width'}}
p.list-width-scope-note {{ listWidthScopeNote }}
template(name="listWidthErrorPopup")
.list-width-invalid
@@ -276,6 +283,10 @@ template(name="setListColorPopup")
span.card-label.palette-color.js-palette-color(class="card-details-{{color}}")
if(isSelected color)
i.fa.fa-check
// #5514: native color wheel for picking a custom RGB / hex color
.color-wheel-wrap
label(for="listColorWheel") {{_ 'custom-color'}}
input.js-list-color-wheel#listColorWheel(type="color" value=currentColorHex title="{{_ 'custom-color'}}")
button.primary.confirm.js-submit {{_ 'save'}}
button.js-remove-color.negate.wide.right {{_ 'unset-color'}}
+238 -60
View File
@@ -5,8 +5,17 @@ import dragscroll from '@wekanteam/dragscroll';
import { BoardSwimlaneListDialog } from '/client/lib/dialogWithBoardSwimlaneList';
import Cards from '/models/cards';
import { LIST_COLORS } from '/models/metadata/colors';
import { isHexColor, toHex } from '/models/lib/contrastColor';
import { MultiSelection } from '/client/lib/multiSelection';
import { Utils } from '/client/lib/utils';
import { lazyListCardCount } from '/client/lib/lazyCards';
// #5659: single source of truth for the default/minimum list width, shared
// with client/components/lists/list.js and models/users.js.
import {
DEFAULT_LIST_WIDTH,
MIN_LIST_WIDTH,
normalizeListWidth,
} from '/models/lib/listWidth';
let listsColors;
Meteor.startup(() => {
@@ -20,12 +29,12 @@ Template.listHeader.helpers({
(!list.getWipLimit('enabled') ||
list.getWipLimit('soft') ||
!Template.instance().reachedWipLimit()) &&
!ReactiveCache.getCurrentUser().isWorker()
!ReactiveCache.getCurrentUser()?.isWorker()
);
},
isBoardAdmin() {
return ReactiveCache.getCurrentUser().isBoardAdmin();
return ReactiveCache.getCurrentUser()?.isBoardAdmin();
},
starred() {
@@ -59,24 +68,33 @@ Template.listHeader.helpers({
swimlaneId = list.swimlaneId || '';
}
const ret = list.cards(swimlaneId).length;
return ret;
// In lazy mode minimongo holds only the loaded window, so use the accurate
// server count for the same selector; fall back to the loaded length.
const lazyCount = lazyListCardCount(list, swimlaneId);
return lazyCount !== null ? lazyCount : list.cards(swimlaneId).length;
},
reachedWipLimit() {
const list = Template.currentData();
return (
list.getWipLimit('enabled') &&
list.getWipLimit('value') <= list.cards().length
);
const lazyCount = lazyListCardCount(list, undefined);
const count = lazyCount !== null ? lazyCount : list.cards().length;
return list.getWipLimit('enabled') && list.getWipLimit('value') <= count;
},
exceededWipLimit() {
const list = Template.currentData();
return (
list.getWipLimit('enabled') &&
list.getWipLimit('value') < list.cards().length
);
const lazyCount = lazyListCardCount(list, undefined);
const count = lazyCount !== null ? lazyCount : list.cards().length;
return list.getWipLimit('enabled') && list.getWipLimit('value') < count;
},
// Accurate whole-list card count (used by the badge visibility, WIP-limit
// number and pluralization in the template). In lazy mode `cards.length`
// (= list.cards().length) is only the loaded window, so prefer the server count.
cardsCountWhole() {
const list = Template.currentData();
const lazyCount = lazyListCardCount(list, undefined);
return lazyCount !== null ? lazyCount : list.cards().length;
},
showCardsCountForList(count) {
@@ -141,10 +159,9 @@ Template.listHeader.helpers({
Template.listHeader.onCreated(function () {
this.reachedWipLimit = function () {
const list = Template.currentData();
return (
list.getWipLimit('enabled') &&
list.getWipLimit('value') <= list.cards().length
);
const lazyCount = lazyListCardCount(list, undefined);
const count = lazyCount !== null ? lazyCount : list.cards().length;
return list.getWipLimit('enabled') && list.getWipLimit('value') <= count;
};
});
@@ -218,7 +235,7 @@ Template.listHeader.events({
Template.listActionPopup.helpers({
isBoardAdmin() {
return ReactiveCache.getCurrentUser().isBoardAdmin();
return ReactiveCache.getCurrentUser()?.isBoardAdmin();
},
isWipLimitEnabled() {
@@ -258,7 +275,15 @@ Template.listActionPopup.events({
'click .js-set-list-width': Popup.open('setListWidth'),
'click .js-set-color-list': Popup.open('setListColor'),
'click .js-select-cards'() {
const cardIds = this.allCards().map(card => card._id);
// Scope "select all cards" to the current swimlane when invoked from a
// swimlane context (#5623). In swimlanes board view the list carries its
// swimlaneId; otherwise there is genuinely no swimlane context and we keep
// the historical list-wide selection (swimlaneId stays undefined).
let swimlaneId;
if (Utils.boardView() === 'board-view-swimlanes' && this.swimlaneId) {
swimlaneId = this.swimlaneId;
}
const cardIds = this.allCards(swimlaneId).map(card => card._id);
MultiSelection.add(cardIds);
Popup.back();
},
@@ -297,11 +322,10 @@ Template.setWipLimitPopup.events({
async 'click .js-enable-wip-limit'() {
const list = Template.currentData();
// Prevent user from using previously stored wipLimit.value if it is less than the current number of cards in the list
if (
!list.getWipLimit('enabled') &&
list.getWipLimit('value') < list.cards().length
) {
await list.setWipLimit(list.cards().length);
const lazyCount = lazyListCardCount(list, undefined);
const count = lazyCount !== null ? lazyCount : list.cards().length;
if (!list.getWipLimit('enabled') && list.getWipLimit('value') < count) {
await list.setWipLimit(count);
}
Meteor.call('enableWipLimit', list._id);
},
@@ -468,6 +492,10 @@ Template.setListColorPopup.helpers({
return tpl.currentColor.get() === color;
}
},
// #5514: current color as a '#rrggbb' hex for the native color wheel <input>.
currentColorHex() {
return toHex(Template.instance().currentColor.get()) || '#0079bf';
},
});
Template.setListColorPopup.events({
@@ -475,12 +503,17 @@ Template.setListColorPopup.events({
const paletteData = Blaze.getData(event.currentTarget);
tpl.currentColor.set(paletteData?.color);
},
// #5514: picking from the native color wheel stores a custom hex.
'input .js-list-color-wheel'(event, tpl) {
const value = event.currentTarget.value;
if (isHexColor(value)) {
tpl.currentColor.set(value);
}
},
async 'submit form'(event, tpl) {
event.preventDefault();
console.log('[ListColor] submit form, color:', tpl.currentColor.get(), 'listId:', tpl.currentList?._id, 'setColor type:', typeof tpl.currentList?.setColor);
try {
const result = await tpl.currentList.setColor(tpl.currentColor.get());
console.log('[ListColor] submit form setColor result:', result);
await tpl.currentList.setColor(tpl.currentColor.get());
} catch (err) {
console.error('[ListColor] submit form setColor error:', err);
}
@@ -488,10 +521,8 @@ Template.setListColorPopup.events({
},
async 'click .js-submit'(event, tpl) {
event.preventDefault();
console.log('[ListColor] click submit, color:', tpl.currentColor.get(), 'listId:', tpl.currentList?._id, 'setColor type:', typeof tpl.currentList?.setColor);
try {
const result = await tpl.currentList.setColor(tpl.currentColor.get());
console.log('[ListColor] click submit setColor result:', result);
await tpl.currentList.setColor(tpl.currentColor.get());
} catch (err) {
console.error('[ListColor] click submit setColor error:', err);
}
@@ -499,7 +530,6 @@ Template.setListColorPopup.events({
},
async 'click .js-remove-color'(event, tpl) {
event.preventDefault();
console.log('[ListColor] remove color, listId:', tpl.currentList?._id);
try {
await tpl.currentList.setColor(null);
} catch (err) {
@@ -509,50 +539,198 @@ Template.setListColorPopup.events({
},
});
// #6409: the per-list width popup is now a single fixed-width value. Whether it
// affects everyone (shared) or just the current user (personal) follows the
// board setting `allowsPersonalListWidth`.
function isPersonalListWidth(boardId) {
const board = ReactiveCache.getBoard(boardId);
return !!(board && board.allowsPersonalListWidth);
}
// #5729 Fixed (same) width for all lists is a per-viewer/per-board setting.
// Logged-in users store it in their profile; anonymous (public board) users in
// localStorage (mirrors the per-list anon storage in list.js).
function readAnonFixedListWidthEnabled(boardId) {
try {
const stored = localStorage.getItem('wekan-fixed-list-width-enabled');
if (stored) {
const flags = JSON.parse(stored);
return flags[boardId] === true;
}
} catch (e) {
console.warn('Error reading fixed list width flag from localStorage:', e);
}
return false;
}
function readAnonFixedListWidth(boardId) {
try {
const stored = localStorage.getItem('wekan-fixed-list-width');
if (stored) {
const widths = JSON.parse(stored);
const w = widths[boardId];
if (typeof w === 'number' && w >= MIN_LIST_WIDTH) return w;
}
} catch (e) {
console.warn('Error reading fixed list width from localStorage:', e);
}
return DEFAULT_LIST_WIDTH;
}
function isFixedListWidth(boardId) {
const user = ReactiveCache.getCurrentUser();
if (user) return !!user.isFixedListWidth(boardId);
return readAnonFixedListWidthEnabled(boardId);
}
function fixedListWidthValue(boardId) {
const user = ReactiveCache.getCurrentUser();
if (user) return user.getFixedListWidth(boardId);
return readAnonFixedListWidth(boardId);
}
function setAnonFixedListWidthEnabled(boardId, enabled) {
try {
const stored = localStorage.getItem('wekan-fixed-list-width-enabled');
const flags = stored ? JSON.parse(stored) : {};
flags[boardId] = !!enabled;
localStorage.setItem('wekan-fixed-list-width-enabled', JSON.stringify(flags));
} catch (e) {
console.warn('Error saving fixed list width flag to localStorage:', e);
}
}
function setAnonFixedListWidth(boardId, width) {
try {
const stored = localStorage.getItem('wekan-fixed-list-width');
const widths = stored ? JSON.parse(stored) : {};
widths[boardId] = width;
localStorage.setItem('wekan-fixed-list-width', JSON.stringify(widths));
} catch (e) {
console.warn('Error saving fixed list width to localStorage:', e);
}
}
Template.setListWidthPopup.helpers({
listWidthValue() {
const list = Template.currentData();
const board = list.boardId;
return ReactiveCache.getCurrentUser().getListWidth(board, list._id);
},
listConstraintValue() {
const list = Template.currentData();
const board = list.boardId;
return ReactiveCache.getCurrentUser().getListConstraint(board, list._id);
},
isAutoWidth() {
const boardId = Utils.getCurrentBoardId();
// #5729 In fixed width mode the input edits the single per-board value.
if (isFixedListWidth(list.boardId)) {
return fixedListWidthValue(list.boardId);
}
const shared = normalizeListWidth(list.width);
if (!isPersonalListWidth(list.boardId)) {
return shared;
}
const user = ReactiveCache.getCurrentUser();
return user && user.isAutoWidth(boardId);
if (user) {
const widths = user.getListWidths();
const w = widths[list.boardId] && widths[list.boardId][list._id];
return normalizeListWidth(w, shared);
}
return shared;
},
listWidthScopeNote() {
const list = Template.currentData();
// #5729 In fixed width mode the note explains the all-lists behaviour.
if (isFixedListWidth(list.boardId)) {
return TAPi18n.__('fixed-list-width-note');
}
return isPersonalListWidth(list.boardId)
? TAPi18n.__('list-width-personal-note')
: TAPi18n.__('list-width-shared-note');
},
// #6409: auto-width follows the same scope as fixed widths.
isAutoWidth() {
const list = Template.currentData();
if (isPersonalListWidth(list.boardId)) {
const user = ReactiveCache.getCurrentUser();
return !!(user && user.isAutoWidth(list.boardId));
}
const board = ReactiveCache.getBoard(list.boardId);
return !!(board && board.autoWidth);
},
// In shared mode only members with board write access may toggle the shared
// auto-width; in personal mode any logged-in user may toggle their own.
canChangeAutoWidth() {
const list = Template.currentData();
if (isPersonalListWidth(list.boardId)) {
return !!ReactiveCache.getCurrentUser();
}
return Utils.canModifyBoard();
},
// #5729 Whether "same width for all lists" mode is on for the current viewer.
isFixedListWidth() {
const list = Template.currentData();
return isFixedListWidth(list.boardId);
},
});
Template.setListWidthPopup.events({
'click .js-auto-width-board'() {
dragscroll.reset();
ReactiveCache.getCurrentUser().toggleAutoWidth(Utils.getCurrentBoardId());
'click .js-toggle-auto-width'(event) {
event.preventDefault();
const list = Template.currentData();
const boardId = list.boardId;
if (isPersonalListWidth(boardId)) {
const user = ReactiveCache.getCurrentUser();
if (user) user.toggleAutoWidth(boardId);
} else {
const board = ReactiveCache.getBoard(boardId);
const current = !!(board && board.autoWidth);
Meteor.call('setBoardAutoWidth', boardId, !current);
}
Popup.back();
},
// #5729 Toggle "same width for all lists" (fixed width) for the current
// viewer. Enabling it turns off auto-width (the two modes are exclusive).
'click .js-toggle-fixed-list-width'(event) {
event.preventDefault();
const list = Template.currentData();
const boardId = list.boardId;
const enabled = !isFixedListWidth(boardId);
const user = ReactiveCache.getCurrentUser();
if (user) {
if (enabled && isPersonalListWidth(boardId) && user.isAutoWidth(boardId)) {
user.toggleAutoWidth(boardId);
}
Meteor.call('setFixedListWidthEnabled', boardId, enabled);
} else {
setAnonFixedListWidthEnabled(boardId, enabled);
}
Popup.back();
},
'click .list-width-apply'(event, tpl) {
const list = Template.currentData();
const board = list.boardId;
const width = parseInt(
tpl.$('.list-width-value').val(),
10,
);
const constraint = parseInt(
tpl.$('.list-constraint-value').val(),
10,
);
const boardId = list.boardId;
const width = parseInt(tpl.$('.list-width-value').val(), 10);
// FIXME(mark-i-m): where do we put constants?
if (width < 270 || !width || constraint < 270 || !constraint) {
if (!width || width < MIN_LIST_WIDTH) {
tpl.$('.list-width-error').click();
} else {
Meteor.call('applyListWidth', board, list._id, width, constraint);
Popup.back();
return;
}
const user = ReactiveCache.getCurrentUser();
// #5729 In fixed width mode the input applies to the single per-board value.
if (isFixedListWidth(boardId)) {
if (user) {
Meteor.call('setFixedListWidth', boardId, width);
} else {
setAnonFixedListWidth(boardId, width);
}
Popup.back();
return;
}
if (isPersonalListWidth(boardId)) {
if (user) {
Meteor.call('applyListWidthToStorage', boardId, list._id, width, width);
}
} else if (user) {
Meteor.call('applyListWidth', boardId, list._id, width, width);
}
Popup.back();
},
'click .list-width-error': Popup.open('listWidthError'),
});
+21
View File
@@ -3,3 +3,24 @@
margin-inline-end: auto;
margin-inline-start: auto;
}
/* Scrollable list container for the Due Cards view.
Scoped to the due-cards list only, not global (issue #5930). */
.due-cards-list {
overflow-y: auto;
-webkit-overflow-scrolling: touch;
/* Leave room for the header bar / results header so the list itself can
scroll instead of being clipped after the first few cards. */
max-height: calc(100vh - 160px);
}
/* On small screens (mobile / iPhone) the previous fixed height clipped the
list at roughly 5 cards. Allow the list to use the available viewport
height and scroll past the first cards. */
@media screen and (max-width: 800px) {
.due-cards-list {
max-height: calc(100vh - 120px);
overflow-y: auto;
-webkit-overflow-scrolling: touch;
}
}
+3 -2
View File
@@ -35,8 +35,9 @@ template(name="dueCards")
.due-cards-results-header
h1
= resultsText
each card in dueCardsList
+resultCard(card)
.due-cards-list
each card in dueCardsList
+resultCard(card)
else
.global-search-results-list-wrapper
.no-results
+6 -32
View File
@@ -1,6 +1,7 @@
import { ReactiveCache } from '/imports/reactiveCache';
import { TAPi18n } from '/imports/i18n';
import { Utils } from '/client/lib/utils';
import { filterAndSortDueCards } from '/client/components/main/dueCardsLogic';
// const subManager = new SubsManager();
@@ -70,44 +71,17 @@ Template.dueCards.onCreated(function () {
// Filter cards based on user view preference
const allUsers = dueCardsView() === 'all';
const currentUser = ReactiveCache.getCurrentUser();
let filteredCards = cards;
if (process.env.DEBUG === 'true') {
console.log('dueCards client: current user:', currentUser ? currentUser._id : 'none');
console.log('dueCards client: showing all users:', allUsers);
}
if (!allUsers && currentUser) {
filteredCards = cards.filter(card => {
const isMember = card.members && card.members.includes(currentUser._id);
const isAssignee = card.assignees && card.assignees.includes(currentUser._id);
const isAuthor = card.userId === currentUser._id;
const matches = isMember || isAssignee || isAuthor;
if (process.env.DEBUG === 'true' && matches) {
console.log('dueCards client: card matches user:', card.title, { isMember, isAssignee, isAuthor });
}
return matches;
});
}
// Normalize dueAt to timestamps for stable client-side ordering
const future = new Date('2100-12-31').getTime();
const toTime = v => {
if (v === null || v === undefined || v === '') return future;
if (v instanceof Date) return v.getTime();
const t = new Date(v);
if (!isNaN(t.getTime())) return t.getTime();
return future;
};
filteredCards.sort((a, b) => {
const x = toTime(a.dueAt);
const y = toTime(b.dueAt);
if (x > y) return 1;
if (x < y) return -1;
return 0;
// Filter (by user unless "all") and sort ascending by due date. No cap is
// applied so every due card is shown (issues #5999 / #5930).
const filteredCards = filterAndSortDueCards(cards, {
allUsers,
userId: currentUser ? currentUser._id : null,
});
if (process.env.DEBUG === 'true') {
+52
View File
@@ -0,0 +1,52 @@
// Pure, side-effect-free helpers for the Due Cards view.
//
// These are extracted from dueCards.js so they can be unit-tested in
// isolation (see client/lib/tests/dueCards.logic.tests.js). They must not
// reference Meteor, Blaze, ReactiveCache or the DOM.
// A far-future sentinel used to push cards with a missing/invalid dueAt to the
// end of the ascending sort instead of dropping them.
const FAR_FUTURE = new Date('2100-12-31').getTime();
// Normalize a dueAt value (Date | string | null | undefined) to a comparable
// millisecond timestamp. Invalid / empty values sort last.
export function dueAtToTime(value, farFuture = FAR_FUTURE) {
if (value === null || value === undefined || value === '') return farFuture;
if (value instanceof Date) return value.getTime();
const t = new Date(value);
if (!isNaN(t.getTime())) return t.getTime();
return farFuture;
}
// Decide whether a card belongs to the current user (member, assignee or
// author). Used when the view is "me" rather than "all".
export function cardMatchesUser(card, userId) {
if (!card || !userId) return false;
const isMember = Array.isArray(card.members) && card.members.includes(userId);
const isAssignee =
Array.isArray(card.assignees) && card.assignees.includes(userId);
const isAuthor = card.userId === userId;
return isMember || isAssignee || isAuthor;
}
// Filter (by user, unless allUsers) and sort (ascending by due date) a list of
// due cards. Returns a new array; does not mutate the input. Importantly this
// imposes NO cap on the number of results (issue #5999 / #5930).
export function filterAndSortDueCards(cards, { allUsers = false, userId = null } = {}) {
const list = Array.isArray(cards) ? cards.slice() : [];
const filtered =
allUsers || !userId
? list
: list.filter(card => cardMatchesUser(card, userId));
filtered.sort((a, b) => {
const x = dueAtToTime(a.dueAt);
const y = dueAtToTime(b.dueAt);
if (x > y) return 1;
if (x < y) return -1;
return 0;
});
return filtered;
}
+35 -2
View File
@@ -383,10 +383,29 @@ Blaze.Template.registerHelper(
'mentions',
new Template('mentions', function() {
const view = this;
// Admin Panel / Features / Security: read the setting FIRST (a reactive dependency
// of this viewer) and push the "always show all code as plain text" flag into the
// wekan-markdown package BEFORE rendering the inner markdown below. Doing it here —
// not only in the separate startup autorun — removes a re-render race: this viewer
// already re-renders whenever the setting doc changes (it reads it for stripLinks),
// and the inner markdown helper then reads the up-to-date flag in the SAME
// synchronous render, so toggling "always show all code as plain text" takes effect
// immediately. Without this the viewer could re-render (setting changed) BEFORE the
// startup autorun updated the flag, read the stale value, and never re-render again
// since it does not itself depend on that ReactiveVar.
const setting = ReactiveCache.getCurrentSetting();
if (typeof Markdown !== 'undefined' && Markdown.alwaysShowCodeAsText) {
Markdown.alwaysShowCodeAsText.set(!!(setting && setting.alwaysShowCodeAsText));
}
let content = Blaze.toHTML(view.templateContentBlock);
// Admin Panel / Features: when "render links as plain text" is enabled, every
// link (markdown [label](url) and raw HTML <a href>) is stripped to plain,
// non-clickable text everywhere rich text is shown. Reactive: toggling the
// setting re-renders viewers.
const stripLinks = !!(setting && setting.renderLinksAsPlainText);
const currentBoard = Utils.getCurrentBoard();
if (!currentBoard)
return HTML.Raw(sanitizeHTML(content));
return HTML.Raw(sanitizeHTML(content, { stripLinks }));
const knowedUsers = [...new Set([...currentBoard.members
.filter(member => member.isActive)
.map(member => {
@@ -440,7 +459,7 @@ Blaze.Template.registerHelper(
content = content.replace(fullMention, Blaze.toHTML(link));
}
return HTML.Raw(sanitizeHTML(content));
return HTML.Raw(sanitizeHTML(content, { stripLinks }));
}),
);
@@ -473,3 +492,17 @@ Template.viewer.events({
}
},
});
// Admin Panel / Features / Security: keep the wekan-markdown package's
// "show all code as plain text" flag in sync with the alwaysShowCodeAsText setting.
// The package cannot import app code, so we push the setting into the reactive flag
// it exposes on the exported Markdown object; the markdown helper reads it reactively
// and shows the raw source (escaped, non-clickable, non-running) when enabled.
Meteor.startup(() => {
Tracker.autorun(() => {
const setting = ReactiveCache.getCurrentSetting();
if (typeof Markdown !== 'undefined' && Markdown.alwaysShowCodeAsText) {
Markdown.alwaysShowCodeAsText.set(!!(setting && setting.alwaysShowCodeAsText));
}
});
});
+19
View File
@@ -130,3 +130,22 @@ code {
.global-search-instructions li {
margin-bottom: 0.3rem;
}
/* #6034 (MVP): drag-and-drop search results into board columns. */
.global-search-results-list .result-card-wrapper {
cursor: grab;
}
.global-search-results-list .result-card-wrapper:active {
cursor: grabbing;
}
.global-search-result-drag-helper {
z-index: 1000;
opacity: 0.85;
pointer-events: none;
list-style: none;
}
.global-search-drop-hover {
outline: 2px dashed #216694;
outline-offset: -2px;
background-color: rgba(33, 102, 148, 0.08);
}
+1 -1
View File
@@ -76,7 +76,7 @@ template(name="globalSearch")
if searching
+spinner
else if hasResults
.global-search-results-list-wrapper
.global-search-results-list-wrapper.global-search-results-list
if hasQueryErrors
ul
each msg in errorMessages
+139
View File
@@ -74,8 +74,147 @@ Template.globalSearch.onRendered(function () {
searchAllBoards(tpl, queryText || '');
}
});
// #6034 (MVP): make search-result cards draggable so they can be dropped
// into a board list/column. Re-wire whenever the results change.
this.autorun(() => {
tpl.search.results.get(); // reactive dependency: re-run when results render
Tracker.afterFlush(() => setupResultDrag(tpl));
});
});
// #6034 (MVP): drag-and-drop search results into board columns.
//
// We make each `.global-search-results-list` result item a jquery-ui
// `draggable` (clone helper), and make every board list's `.js-minicards`
// container a `droppable`. On drop we resolve the dragged card and call the
// existing `card.move(boardId, swimlaneId, listId, sort)` model method - the
// same method the in-board card sortable uses - so the move stays consistent
// with normal card drag-drop and is persisted + reactively re-rendered.
//
// LIMITATION / TODO: this MVP drops the card at the END of the target list
// (sort = list cards length) rather than at the exact pixel-precise insertion
// index used by the in-board minicard sortable. Pixel-precise positioning and
// multi-select drag are intentionally out of scope here; wiring those would
// require modifying the (non-owned) list/minicard sortable `receive` handler.
// Drag is only enabled when the board is editable and a board is open.
function setupResultDrag(tpl) {
try {
if (typeof window === 'undefined' || !window.jQuery) return;
const $ = window.jQuery;
const $items = tpl.$('.global-search-results-list .result-card-wrapper');
if (!$items.length || typeof $items.draggable !== 'function') return;
// Only allow DnD when we are inside a board the user can modify.
const boardId = Session.get('currentBoard');
if (!boardId) return;
const canModify =
Utils && typeof Utils.canModifyBoard === 'function'
? Utils.canModifyBoard()
: false;
if (!canModify) return;
$items.each(function () {
const el = this;
// Avoid double-initialising the same element.
if ($(el).data('uiDraggable')) return;
$(el).draggable({
helper: 'clone',
appendTo: 'body',
revert: 'invalid',
revertDuration: 150,
cursor: 'grabbing',
zIndex: 1000,
start(evt, ui) {
ui.helper.addClass('global-search-result-drag-helper');
ui.helper.css('width', $(el).width());
},
});
});
// Make board lists accept the dropped result card.
const $lists = $('.list .js-minicards');
if (!$lists.length || typeof $lists.droppable !== 'function') return;
$lists.each(function () {
const listEl = this;
if ($(listEl).data('uiDroppable')) return;
$(listEl).droppable({
accept: '.result-card-wrapper',
tolerance: 'pointer',
hoverClass: 'global-search-drop-hover',
drop(evt, ui) {
onResultDroppedOnList(listEl, ui.draggable.get(0));
},
});
});
} catch (e) {
console.error('Error wiring search-result drag-and-drop (#6034):', e);
}
}
// Resolve the dragged result card + target list and perform the move using the
// existing card model `move()` method (mirrors the in-board card sortable).
function onResultDroppedOnList(listEl, draggedEl) {
try {
if (!listEl || !draggedEl) return;
// Card data from the dragged result item (Blaze data on the result wrapper,
// falling back to the inner minicard).
let cardData = Blaze.getData(draggedEl);
if (!cardData || !cardData._id) {
const inner = draggedEl.querySelector('.js-minicard');
if (inner) cardData = Blaze.getData(inner);
}
if (!cardData || !cardData._id) return;
const card = ReactiveCache.getCard(cardData._id);
if (!card || typeof card.move !== 'function') return;
// Target list / swimlane / board from the drop target.
const listData = Blaze.getData(listEl.closest('.list') || listEl);
if (!listData || !listData._id) return;
const listId = listData._id;
const currentBoard = Utils.getCurrentBoard();
if (!currentBoard) return;
let swimlaneId = listData.swimlaneId;
if (!swimlaneId) {
const swimlaneEl = listEl.closest('.swimlane');
if (swimlaneEl) {
const swimlaneData = Blaze.getData(swimlaneEl);
swimlaneId = swimlaneData && swimlaneData._id;
}
}
if (!swimlaneId) {
const def = currentBoard.getDefaultSwimline && currentBoard.getDefaultSwimline();
swimlaneId = (def && def._id) || card.swimlaneId;
}
// MVP: append to the end of the target list.
let sort = 0;
try {
const existing = ReactiveCache.getCards(
{ listId, archived: false },
{ sort: { sort: -1 }, limit: 1 },
);
if (existing && existing.length && typeof existing[0].sort === 'number') {
sort = existing[0].sort + 1;
}
} catch (e) {
sort = 0;
}
card.move(currentBoard._id, swimlaneId, listId, sort);
} catch (e) {
console.error('Error moving dropped search result (#6034):', e);
}
}
function searchAllBoards(tpl, queryText) {
const search = tpl.search;
+54 -46
View File
@@ -290,15 +290,19 @@ body:not(.board-view) #header #header-main-bar h1 {
}
/* Zoom Controls in Header */
/* #6465: compact fixed-pixel pill. The vh/vw padding+shadow made the pill
taller than the 28px overflow-hidden quick-access row, so it rendered cut
off at every window size. */
#header-quick-access .zoom-controls {
display: flex;
align-items: center;
gap: 0.5vw;
gap: 4px;
background: rgba(255, 255, 255, 0.9);
padding: 0.5vh 1vw;
border-radius: 0.5vw;
box-shadow: 0 0.2vh 0.5vh rgba(0,0,0,0.1);
margin: 0 1vw;
padding: 2px 8px;
border-radius: 10px;
box-shadow: 0 1px 2px rgba(0,0,0,0.1);
margin: 0 8px;
max-height: 24px;
float: inline-start;
}
@@ -496,15 +500,19 @@ body:not(.board-view) #header #header-main-bar h1 {
@media screen and (max-width: 800px),
screen and (max-device-width: 932px) and (-webkit-min-device-pixel-ratio: 3) {
#header #header-main-bar {
height: 40px;
/* #6419: taller bar so the action icons can use ~44px touch targets. */
height: 48px;
}
#header #header-main-bar .board-header-btns {
margin-top: 0px;
}
#header #header-main-bar .board-header-btn {
height: 32px;
line-height: 32px;
font-size: 15px;
/* #6419: 32px tall / 15px was below the comfortable mobile touch-target and
readable-font minimum (~44px / 16px). Enlarged vertically + bigger font;
width is unchanged so this does not worsen the horizontal icon crowding. */
height: 44px;
line-height: 44px;
font-size: 16px;
}
#header #header-main-bar .board-header-btn i.fa {
line-height: 32px;
@@ -554,7 +562,7 @@ body:not(.board-view) #header #header-main-bar h1 {
}
}
/* Mobile - make all text and icons 2x bigger above #content by default */
/* Mobile - keep header text/icons at normal size (reverted #6426 oversizing) */
@media screen and (max-width: 800px),
screen and (max-device-width: 800px),
screen and (-webkit-min-device-pixel-ratio: 2) and (max-width: 800px),
@@ -569,7 +577,7 @@ body:not(.board-view) #header #header-main-bar h1 {
overflow: hidden !important; /* Prevent content overflow */
}
#header-quick-access {
font-size: 2em !important; /* 2x bigger base font size */
font-size: 1em !important; /* Normal size (reverted #6426 oversizing) */
}
#header-quick-access * {
@@ -578,7 +586,7 @@ body:not(.board-view) #header #header-main-bar h1 {
#header-quick-access .fa,
#header-quick-access .icon {
font-size: 2em !important; /* 2x bigger icons */
font-size: 1em !important; /* Normal icon size (reverted #6426 oversizing) */
}
#header-quick-access .home-icon a {
@@ -648,7 +656,7 @@ body:not(.board-view) #header #header-main-bar h1 {
}
}
/* Mobile All Boards page - make logo row elements 2x bigger */
/* Mobile All Boards page - keep logo row at normal size (reverted #6426 oversizing) */
@media screen and (max-width: 800px),
screen and (max-device-width: 800px),
screen and (-webkit-min-device-pixel-ratio: 2) and (max-width: 800px),
@@ -656,16 +664,16 @@ body:not(.board-view) #header #header-main-bar h1 {
screen and (max-width: 800px) and (orientation: landscape) {
.wrapper ~ #header-quick-access,
body:not(.board-view) #header-quick-access {
font-size: 2em !important; /* 2x bigger base font size for logo row */
font-size: 1em !important; /* Normal size (reverted #6426 oversizing) */
}
/* iPhone 12 Mini specific - 3x bigger for All Boards page */
/* iPhone 12 Mini specific - keep All Boards logo row at normal size (reverted #6426) */
@media screen and (device-width: 375px) and (device-height: 812px), /* iPhone 12 Mini exact */
screen and (max-width: 375px) and (max-height: 812px), /* iPhone 12 Mini viewport */
screen and (-webkit-min-device-pixel-ratio: 3) and (max-width: 375px) /* iPhone 12 Mini Retina */ {
.wrapper ~ #header-quick-access,
body:not(.board-view) #header-quick-access {
font-size: 3em !important; /* 3x bigger base font size for iPhone 12 Mini All Boards page */
font-size: 1em !important; /* Normal size (reverted #6426 oversizing) */
}
}
@@ -678,7 +686,7 @@ body:not(.board-view) #header #header-main-bar h1 {
.wrapper ~ #header-quick-access .icon,
body:not(.board-view) #header-quick-access .fa,
body:not(.board-view) #header-quick-access .icon {
font-size: 2em !important; /* 2x bigger icons in logo row */
font-size: 1em !important; /* Normal icon size (reverted #6426 oversizing) */
}
.wrapper ~ #header-quick-access .home-icon a,
@@ -737,19 +745,19 @@ body:not(.board-view) #header #header-main-bar h1 {
}
}
/* iPhone 12 Mini specific - make header elements 3x bigger */
/* iPhone 12 Mini specific - keep the header a normal compact single row */
@media screen and (device-width: 375px) and (device-height: 812px), /* iPhone 12 Mini exact */
screen and (max-width: 375px) and (max-height: 812px), /* iPhone 12 Mini viewport */
screen and (-webkit-min-device-pixel-ratio: 3) and (max-width: 375px), /* iPhone 12 Mini Retina */
screen and (max-width: 375px) and (orientation: portrait), /* iPhone 12 Mini portrait */
screen and (max-width: 375px) and (orientation: landscape) /* iPhone 12 Mini landscape */ {
#header-quick-access {
font-size: 3em !important; /* 3x bigger base font size for iPhone 12 Mini */
height: auto !important; /* Allow height to grow */
min-height: 84px !important; /* Much taller minimum height for iPhone 12 Mini */
flex-wrap: wrap !important; /* Force wrapping */
align-items: flex-start !important; /* Align to top when wrapping */
padding: 18px 0px !important; /* More padding for iPhone 12 Mini */
font-size: 1em !important; /* Normal size (reverted #6426 oversizing) */
height: 48px !important;
min-height: 48px !important;
flex-wrap: nowrap !important;
align-items: center !important;
padding: 8px 0px !important;
}
#header-quick-access * {
@@ -758,7 +766,7 @@ body:not(.board-view) #header #header-main-bar h1 {
#header-quick-access .fa,
#header-quick-access .icon {
font-size: 3em !important; /* 3x bigger icons for iPhone 12 Mini */
font-size: 1em !important; /* Normal icon size (reverted #6426 oversizing) */
}
#header-quick-access .home-icon a {
@@ -844,7 +852,7 @@ body:not(.board-view) #header #header-main-bar h1 {
}
}
/* iPhone 12 Mini and very small screens - make header elements much larger */
/* iPhone 12 Mini and very small screens - header element sizing */
@media screen and (max-width: 400px) and (max-height: 900px),
screen and (max-device-width: 400px) and (max-device-height: 900px),
screen and (-webkit-min-device-pixel-ratio: 2) and (max-width: 400px),
@@ -908,12 +916,12 @@ body:not(.board-view) #header #header-main-bar h1 {
/* Fallback for iPhone devices using JavaScript detection */
.iphone-device #header-quick-access {
font-size: 2em !important; /* 2x bigger base font size */
height: auto !important; /* Allow height to grow */
min-height: 48px !important; /* Minimum height for mobile */
flex-wrap: wrap !important; /* Force wrapping */
align-items: flex-start !important; /* Align to top when wrapping */
padding: 8px 0px !important; /* Adjust padding for mobile */
font-size: 1em !important; /* Normal size (reverted #6426 oversizing) */
height: 48px !important;
min-height: 48px !important;
flex-wrap: nowrap !important;
align-items: center !important;
padding: 8px 0px !important;
}
.iphone-device #header-quick-access * {
@@ -922,7 +930,7 @@ body:not(.board-view) #header #header-main-bar h1 {
.iphone-device #header-quick-access .fa,
.iphone-device #header-quick-access .icon {
font-size: 2em !important; /* 2x bigger icons */
font-size: 1em !important; /* Normal icon size (reverted #6426 oversizing) */
}
.iphone-device #header-quick-access .home-icon a {
@@ -991,14 +999,14 @@ body:not(.board-view) #header #header-main-bar h1 {
width: auto !important;
}
/* iPhone 12 Mini specific - JavaScript detection fallback */
/* iPhone 12 Mini specific - JavaScript detection fallback (normal compact row) */
.iphone-device #header-quick-access {
font-size: 3em !important; /* 3x bigger base font size for iPhone 12 Mini */
height: auto !important; /* Allow height to grow */
min-height: 84px !important; /* Much taller minimum height for iPhone 12 Mini */
flex-wrap: wrap !important; /* Force wrapping */
align-items: flex-start !important; /* Align to top when wrapping */
padding: 18px 0px !important; /* More padding for iPhone 12 Mini */
font-size: 1em !important; /* Normal size (reverted #6426 oversizing) */
height: 48px !important;
min-height: 48px !important;
flex-wrap: nowrap !important;
align-items: center !important;
padding: 8px 0px !important;
}
.iphone-device #header-quick-access * {
@@ -1007,7 +1015,7 @@ body:not(.board-view) #header #header-main-bar h1 {
.iphone-device #header-quick-access .fa,
.iphone-device #header-quick-access .icon {
font-size: 3em !important; /* 3x bigger icons for iPhone 12 Mini */
font-size: 1em !important; /* Normal icon size (reverted #6426 oversizing) */
}
.iphone-device #header-quick-access .home-icon a {
@@ -1092,10 +1100,10 @@ body:not(.board-view) #header #header-main-bar h1 {
width: auto !important;
}
/* iPhone 12 Mini All Boards page - make logo row elements 3x bigger */
/* iPhone 12 Mini All Boards page - keep logo row at normal size (reverted #6426) */
.iphone-device .wrapper ~ #header-quick-access,
.iphone-device body:not(.board-view) #header-quick-access {
font-size: 3em !important; /* 3x bigger base font size for logo row */
font-size: 1em !important; /* Normal size (reverted #6426 oversizing) */
}
.iphone-device .wrapper ~ #header-quick-access *,
@@ -1107,7 +1115,7 @@ body:not(.board-view) #header #header-main-bar h1 {
.iphone-device .wrapper ~ #header-quick-access .icon,
.iphone-device body:not(.board-view) #header-quick-access .fa,
.iphone-device body:not(.board-view) #header-quick-access .icon {
font-size: 2em !important; /* 2x bigger icons in logo row */
font-size: 1em !important; /* Normal icon size (reverted #6426 oversizing) */
}
.iphone-device .wrapper ~ #header-quick-access .home-icon a,
@@ -1205,7 +1213,7 @@ body:not(.board-view) #header #header-main-bar h1 {
.iphone-device #header-quick-access,
.iphone-device .wrapper ~ #header-quick-access,
.iphone-device body:not(.board-view) #header-quick-access {
font-size: 1.2em !important;
font-size: 1em !important;
}
body:not(.board-view) #header-quick-access .fa,
body:not(.board-view) #header-quick-access .icon,
@@ -1217,7 +1225,7 @@ body:not(.board-view) #header #header-main-bar h1 {
.iphone-device .wrapper ~ #header-quick-access .icon,
.iphone-device body:not(.board-view) #header-quick-access .fa,
.iphone-device body:not(.board-view) #header-quick-access .icon {
font-size: 1.5em !important;
font-size: 1.2em !important;
}
/* Zoom (100%), drag-handle toggle and mobile/desktop toggle 30% smaller than
the other quick-access controls at small width — for all browsers. */
+1 -1
View File
@@ -113,7 +113,7 @@ template(name="header")
i.fa.fa-bullhorn(aria-hidden="true")
+viewer
| #{announcement}
a.js-close-announcement(aria-label="{{_ 'close'}}")
a.js-close-announcement(aria-label="{{_ 'close'}}" title="{{_ 'close'}}")
i.fa.fa-times-thin(aria-hidden="true")
template(name="offlineWarning")
+26 -5
View File
@@ -2,7 +2,10 @@ import { Meteor } from 'meteor/meteor';
import { Session } from 'meteor/session';
import { ReactiveCache } from '/imports/reactiveCache';
import { FlowRouter } from 'meteor/ostrio:flow-router-extra';
import Announcements from '/models/announcements';
import Announcements, {
announcementVersion,
shouldShowAnnouncement,
} from '/models/announcements';
import { Utils } from '/client/lib/utils';
Meteor.subscribe('user-admin');
@@ -71,14 +74,25 @@ Template.header.helpers({
},
hasAnnouncement() {
const announcements = Announcements.findOne();
return announcements && announcements.enabled;
const announcement = Announcements.findOne();
if (!announcement || !announcement.enabled) {
return false;
}
const version = announcementVersion(announcement);
const user = Meteor.user();
const dismissedVersion =
(user && user.profile && user.profile.dismissedAnnouncementVersion) || null;
return shouldShowAnnouncement({
enabled: announcement.enabled,
version,
dismissedVersion,
});
},
announcement() {
$('.announcement').show();
const announcements = Announcements.findOne();
return announcements && announcements.body;
const announcement = Announcements.findOne();
return announcement && announcement.body;
},
zoomLevel() {
@@ -150,6 +164,13 @@ Template.header.events({
},
'click .js-close-announcement'() {
$('.announcement').hide();
// Permanently dismiss the current announcement for this user (#6051).
// The banner reappears only when the admin changes the announcement text.
Meteor.call('dismissAnnouncement', (err) => {
if (err && process.env.DEBUG === 'true') {
console.error('dismissAnnouncement error', err);
}
});
},
'click .js-select-list'() {
Session.set('currentList', this._id);
+17 -7
View File
@@ -157,8 +157,14 @@ input,
select,
textarea,
button {
font: clamp(14px, 2.5vw, 18px) Roboto, Poppins, "Helvetica Neue", Arial, Helvetica, sans-serif;
line-height: 1.4;
/* #6465: back to the WeKan 6.09 desktop density. The clamp() introduced in
v7.98 (20e9cf114) and raised in v8.02 (67b078b80) resolved to 18px on any
window wider than 720px — +28.5% on EVERY font, input and button versus
6.09's 14px — which is the "everything is way too big" regression. Mobile
readability is handled by the mobile media queries, not by inflating the
desktop base font. */
font: 14px Roboto, Poppins, "Helvetica Neue", Arial, Helvetica, sans-serif;
line-height: 18px;
color: #4d4d4d;
/* Improve text rendering */
-webkit-font-smoothing: antialiased;
@@ -217,8 +223,10 @@ body.mobile-mode #content {
margin-top: 30vh;
}
#content > .wrapper {
margin-top: 1vh;
padding: 2vh 2vw;
/* #6465: 6.09 values; 2vh/2vw padding was ~21x38px on FullHD — the huge
empty header band on the All Boards page. */
margin-top: 10px;
padding: 15px;
}
#modal {
position: absolute;
@@ -264,13 +272,15 @@ body.mobile-mode #content {
float: inline-end;
font-size: clamp(18px, 4vw, 24px);
}
/* #6465: heading sizes back to the 6.09 values (22/18/16px) — the vw clamps
resolved to 24/20/18px on desktop and compounded the density regression. */
h1 {
font-size: clamp(18px, 4vw, 24px);
font-size: 22px;
line-height: 1.2em;
margin: 0 0 1vh;
}
h2 {
font-size: clamp(16px, 3.5vw, 20px);
font-size: 18px;
line-height: 1.2em;
margin: 0 0 0.8vh;
}
@@ -278,7 +288,7 @@ h3,
h4,
h5,
h6 {
font-size: clamp(14px, 3vw, 18px);
font-size: 16px;
line-height: 1.25em;
margin: 0 0 0.6vh;
}
+52 -2
View File
@@ -31,7 +31,10 @@ Template.userFormsLayout.onCreated(function () {
Meteor.call('isOidcRedirectionEnabled', (_, result) => {
if (result) {
AccountsTemplates.options.socialLoginStyle = 'redirect';
options = {
// #5695: this is an ES module, so the body runs in strict mode and
// the previous undeclared `options = {...}` assignment threw a
// ReferenceError, breaking the OIDC_REDIRECTION_ENABLED auto-login.
const options = {
loginStyle: AccountsTemplates.options.socialLoginStyle,
};
Meteor.loginWithOidc(options);
@@ -52,6 +55,13 @@ Template.userFormsLayout.onRendered(() => {
// gesture works the same as on the board swimlanes view.
enablePageDragscroll();
// Mark the auth pages so CSS can let <body> scroll as a normal document.
// body.mobile-mode locks <body> to position:fixed/100vh (an iOS board-view
// anti-bounce fix); without an inner #content scroller that traps these pages
// at viewport height, hiding the sign-up link / language selector below the
// form (and they sit behind the on-screen keyboard). See userForm.css.
document.body.classList.add('userform-layout');
Meteor.call('getAuthenticationsEnabled', (_, result) => {
let enabledAuthenticationMethods = ['password']; // we show/hide this based on isPasswordLoginEnabled
@@ -76,14 +86,23 @@ Template.userFormsLayout.onRendered(() => {
})();
});
// #4394 (security): a one-shot $('.at-signup-link').hide() does not survive
// the useraccounts form re-rendering that happens after a failed login (e.g.
// an LDAP "User not Found") — the links were recreated without the inline
// display:none and reappeared even though registration / forgot-password
// were disabled in the Admin Panel. Toggle a class on the stable <body>
// ancestor and hide the links via CSS (userForm.css) so the rule keeps
// applying to every freshly re-rendered copy of the links.
Meteor.call('isDisableRegistration', (_, result) => {
if (result) {
document.body.classList.add('registration-disabled');
$('.at-signup-link').hide();
}
});
Meteor.call('isDisableForgotPassword', (_, result) => {
if (result) {
document.body.classList.add('forgotpwd-disabled');
$('.at-pwd-link').hide();
}
});
@@ -200,6 +219,7 @@ Template.userFormsLayout.onDestroyed(() => {
// Stop drag-scrolling <body> after leaving login / register (e.g. once logged
// in) so other layouts keep their normal behaviour.
disablePageDragscroll();
document.body.classList.remove('userform-layout');
});
Template.userFormsLayout.helpers({
@@ -267,7 +287,12 @@ Template.main.helpers({
Template.userFormsLayout.events({
'change .js-userform-set-language'(event) {
const tag = $(event.currentTarget).val();
TAPi18n.setLanguage(tag);
// setLanguage is async; surface a failed load instead of silently leaving
// the UI in English (#5756).
Promise.resolve(TAPi18n.setLanguage(tag)).catch(error => {
// eslint-disable-next-line no-console
console.error(`Failed to switch language to ${tag}:`, error);
});
event.preventDefault();
},
'click #at-btn'(event, templateInstance) {
@@ -309,6 +334,31 @@ Template.defaultLayout.onRendered(function () {
}
});
});
// Drag-to-scroll for every whole-page layout rendered inside defaultLayout
// (All Boards, My Cards, Due Cards, Global Search, Public, Bookmarks, Broken
// Cards, Settings, People, Admin, Import, board Rules, …). These pages scroll
// <body> on desktop and #content in mobile mode (where <body> is
// position:fixed), so enablePageDragscroll() tags whichever element actually
// scrolls. The board-canvas pages are the exception: their own
// `.board-canvas.dragscroll` handles dragging, and the canvas does its own
// vertical/horizontal scroll, so page-level tagging is turned off there to
// avoid scrolling #content and the canvas at the same time. defaultLayout is
// persistent (only its `content` swaps), so this single autorun covers every
// route without per-template wiring. Login / Register use userFormsLayout and
// keep their own enable/disable. Works the same in mobile and desktop mode.
const boardCanvasRoutes = ['board', 'board-short', 'card'];
this.autorun(() => {
FlowRouter.watchPathChange();
const onBoardCanvas = boardCanvasRoutes.includes(FlowRouter.getRouteName());
Tracker.afterFlush(() => {
if (onBoardCanvas) {
disablePageDragscroll();
} else {
enablePageDragscroll();
}
});
});
});
async function authentication(event, templateInstance) {
+1 -1
View File
@@ -94,7 +94,7 @@ template(name="myCards")
td
.div
each label in card.labelIds
span.card-label(class="card-label-{{labelColor board label}}" title=name)
span.card-label(class="{{labelColorClass (labelColor board label)}}" style="{{labelColorStyle (labelColor board label)}}" title=name)
| {{labelName board label}}
td
if card.dueAt
+2 -10
View File
@@ -1,6 +1,5 @@
import { CardSearchPaged } from '../../lib/cardSearch';
import { Utils } from '/client/lib/utils';
import { enablePageDragscroll, disablePageDragscroll } from '/client/lib/pageDragscroll';
Template.myCardsHeaderBar.helpers({
myCardsSort() {
@@ -41,15 +40,8 @@ Template.myCards.onCreated(function () {
Meteor.subscribe('setting');
});
Template.myCards.onRendered(function () {
// My Cards renders into <body>'s page scroll area (.wrapper inside #content),
// so enable drag-to-scroll on <body> like the All Boards page does.
enablePageDragscroll();
});
Template.myCards.onDestroyed(function () {
disablePageDragscroll();
});
// Drag-to-scroll is handled centrally for all non-board pages by
// defaultLayout's route-aware autorun (see client/components/main/layouts.js).
Template.myCards.helpers({
userId() {
+15
View File
@@ -1,4 +1,5 @@
import { CSSEvents } from '/client/lib/cssEvents';
import { isMobileViewportNow } from '/client/lib/responsiveUtils';
Popup.template.events({
'click .js-back-view'() {
@@ -10,6 +11,20 @@ Popup.template.events({
'click .js-confirm'() {
this.__afterConfirmAction.call(this);
},
// #5942: On mobile/touch, tapping inside the card-detail sub-popups (assign
// user / set due date) made the popup DISAPPEAR. The document-level
// click-outside handler (EscapeActions in client/lib/popup.js) closes the
// popup, and on touch some freshly-rendered children (avatars, native date
// inputs) generated events that were not recognised as "inside the popup",
// closing it before the tap could register. Stop touch/pointer events that
// originate inside the popup from bubbling to that document handler so the
// popup stays open and usable on mobile. Scoped to mobile viewports so the
// desktop click-outside-to-close behaviour is untouched.
'touchstart .pop-over, pointerdown .pop-over'(evt) {
if (isMobileViewportNow()) {
evt.stopPropagation();
}
},
// This handler intends to solve a pretty tricky bug with our popup
// transition. The transition is implemented using a large container
// (.content-container) that is moved on the x-axis (from 0 to n*PopupSize)
+162
View File
@@ -0,0 +1,162 @@
/* ============================================================================
responsiveFixes.css
Global mobile / responsive corrective overrides. Meteor auto-includes every
.css file under client/, so simply creating this file loads it.
Everything here is ADDITIVE and scoped under (max-width) media queries so the
desktop layout is left untouched. It deliberately lives in one place so the
mobile regressions below are easy to find and tune.
Issues addressed:
#5942 card-detail sub-popups (assign user / due date) disappearing on
touch -> JS guard lives in client/components/main/popup.js; this
file just makes sure those popups can't be visually clipped.
#5902 minicards rendering two-per-row instead of one-per-row on phones;
tiny hard-to-tap Home button in the header.
#6018 enormous icons / menus / text below the menu bar after upgrade.
#5982 excessive padding / margins and tiny button labels.
============================================================================ */
/* ----------------------------------------------------------------------------
#5902 - One minicard per row on narrow screens.
The minicard width itself is owned by minicard.css; we only add a mobile
override here (per task constraints) so phones get a single full-width card
per row instead of two side by side.
---------------------------------------------------------------------------- */
@media (max-width: 768px) {
.minicard,
.minicard-wrapper {
width: 100% !important;
box-sizing: border-box !important;
}
/* The list/swimlane card container should stack cards vertically, not wrap
them into columns. */
.list-body .minicard-wrapper,
.swimlane .minicard-wrapper {
display: block !important;
float: none !important;
}
}
/* ----------------------------------------------------------------------------
#5902 - Make the header "Home / All Boards" button a proper tap target.
The home icon link was tiny. Apple/Material guidance is a >=44px touch
target; give it comfortable padding and a minimum size on touch widths.
---------------------------------------------------------------------------- */
@media (max-width: 768px) {
#header-quick-access .home-icon a {
min-height: 44px !important;
min-width: 44px !important;
display: inline-flex !important;
align-items: center !important;
justify-content: center !important;
padding: 6px 12px !important;
}
/* Keep the home glyph visible and tappable without it ballooning. */
#header-quick-access .home-icon .fa-home {
font-size: 18px !important;
line-height: 1 !important;
}
}
/* ----------------------------------------------------------------------------
#6018 - "text and icons are enormous" below the menu bar.
After the upgrade, em/vw cascades in the content area scaled icons, menus and
text far too large (zoom only affected task names). Re-anchor a sane base
font-size on mobile and cap runaway icon sizing in the content region so the
UI is usable again. Scoped to #content so the (separately tuned) header bar
is not affected.
---------------------------------------------------------------------------- */
@media (max-width: 768px) {
/* Anchor the root size so rem-based sizing can't drift huge. */
html {
font-size: 100% !important; /* 16px base */
}
/* Body text in the working area: a readable, non-enormous default. */
#content {
font-size: 14px !important;
}
/* Cap oversized Font Awesome icons in the content area. Many icons had
inherited a multiplied em size; clamp them to a sane range while still
allowing the explicit small/large fa-modifiers to scale relative to it. */
#content .fa {
font-size: 16px !important;
}
#content .fa.fa-lg {
font-size: 20px !important;
}
#content .fa.fa-2x {
font-size: 24px !important;
}
/* Sidebar and card-detail menus: keep labels at a readable size rather than
the blown-up post-upgrade sizing. */
#content .sidebar .fa,
.card-details .fa {
font-size: 16px !important;
}
/* Menu / list item labels should match their controls, not be tiny next to
oversized padding (#5982 symptom of the same cluster). */
#content .pop-over-list li > a,
#content .sidebar .board-sidebar-content a {
font-size: 14px !important;
}
}
/* ----------------------------------------------------------------------------
#5982 - Excessive padding / margins and lots of empty space on mobile.
Trim the inflated spacing so controls sit closer together and button labels
no longer look tiny inside huge padded boxes.
---------------------------------------------------------------------------- */
@media (max-width: 768px) {
#content .pop-over-list li > a {
padding-top: 4px !important;
padding-bottom: 4px !important;
line-height: 1.4 !important;
}
/* Generic over-padded buttons inside the content area. */
#content button,
#content .btn,
#content .js-submit {
padding: 6px 12px !important;
margin: 4px 0 !important;
}
/* Reduce empty space between sidebar sections. */
#content .sidebar .sidebar-list li,
#content .board-sidebar-content > * {
margin-top: 4px !important;
margin-bottom: 4px !important;
}
}
/* ----------------------------------------------------------------------------
#5942 - Keep card-detail sub-popups visible & usable on mobile.
The JS fix (popup.js) stops touch events inside the popup from bubbling to
the document close handler. As belt-and-braces, make sure the assign-user /
due-date popups are never clipped off-screen and can scroll their content.
---------------------------------------------------------------------------- */
@media (max-width: 768px) {
.pop-over[data-popup="cardAssigneesPopup"],
.pop-over[data-popup="cardMembersPopup"],
.pop-over[data-popup="editCardDueDatePopup"],
.pop-over[data-popup="editCardReceivedDatePopup"],
.pop-over[data-popup="editCardStartDatePopup"],
.pop-over[data-popup="editCardEndDatePopup"] {
max-height: 100vh !important;
overflow-y: auto !important;
-webkit-overflow-scrolling: touch !important;
}
}
+43 -50
View File
@@ -4,6 +4,7 @@ import Actions from '/models/actions';
import Rules from '/models/rules';
import Triggers from '/models/triggers';
import { Utils } from '/client/lib/utils';
import { canSelectBoardInRules } from '/models/lib/rulesBoardSelector';
Template.boardActions.onCreated(function () {
this.subscribe('boards');
@@ -11,19 +12,30 @@ Template.boardActions.onCreated(function () {
Template.boardActions.helpers({
boards() {
const ret = ReactiveCache.getBoards(
{
archived: false,
'members.userId': Meteor.userId(),
_id: {
$ne: ReactiveCache.getCurrentUser().getTemplatesBoardId(),
},
},
// #5698: don't restrict to boards where the user is a DIRECT member — that
// hid every board reached through an Organization / Team / email-domain
// share (the reporter's whole board dropdown was empty, current board
// included). Filter the already access-scoped client cache with the same
// visibility rule as Boards.userBoards() so org/team/domain boards show too.
const user = ReactiveCache.getCurrentUser();
if (!user) return [];
const ctx = {
userId: user._id,
orgIds: typeof user.orgIds === 'function' ? user.orgIds() : [],
teamIds: typeof user.teamIds === 'function' ? user.teamIds() : [],
emailDomains:
typeof user.emailDomains === 'function' ? user.emailDomains() : [],
};
const templatesBoardId = user.getTemplatesBoardId();
const boards = ReactiveCache.getBoards(
{ archived: false },
{
sort: { sort: 1 /* boards default sorting */ },
},
);
return ret;
return boards.filter(board =>
canSelectBoardInRules(board, ctx, templatesBoardId),
);
},
loadingBoardsLabel() {
@@ -94,38 +106,19 @@ Template.boardActions.events({
const boardId = Session.get('currentBoard');
const destBoardId = tpl.find('#board-id').value;
const desc = Utils.getTriggerActionDesc(event, tpl);
if (actionSelected === 'top') {
const triggerId = Triggers.insert(trigger);
const actionId = Actions.insert({
actionType: 'moveCardToTop',
listName,
swimlaneName,
boardId: destBoardId,
desc,
});
Rules.insert({
title: ruleName,
triggerId,
actionId,
boardId,
});
}
if (actionSelected === 'bottom') {
const triggerId = Triggers.insert(trigger);
const actionId = Actions.insert({
actionType: 'moveCardToBottom',
listName,
swimlaneName,
boardId: destBoardId,
desc,
});
Rules.insert({
title: ruleName,
triggerId,
actionId,
boardId,
});
}
// #5536: create the rule on the server (see server/rulesButton.js →
// rules.createRule) instead of three optimistic client Collection.insert()
// calls. The optimistic writes landed in minimongo limbo once the wizard
// subscription stopped, so the cross-board move action rendered BLANK; and
// the client allow/deny rules rejected them outright for non-owner members.
// The action keeps its own destination `boardId` (the board to move to).
Meteor.call('rules.createRule', boardId, ruleName, trigger, {
actionType: actionSelected === 'bottom' ? 'moveCardToBottom' : 'moveCardToTop',
listName,
swimlaneName,
boardId: destBoardId,
desc,
});
},
'click .js-add-gen-move-action'(event, tpl) {
const desc = Utils.getTriggerActionDesc(event, tpl);
@@ -141,7 +134,11 @@ Template.boardActions.events({
// documents land in minimongo limbo when the wizard subscription stops.
Meteor.call('rules.createRule', boardId, ruleName, trigger, {
actionType,
listTitle: '*',
// #6472: was `listTitle: '*'` since the original rules implementation,
// but performAction reads action.listName/action.swimlaneName — so every
// generic "move to top/bottom" rule created by this wizard did nothing.
listName: '*',
swimlaneName: '*',
boardId,
desc,
});
@@ -191,20 +188,16 @@ Template.boardActions.events({
const boardId = Session.get('currentBoard');
const destBoardId = tpl.find('#board-id-link').value;
const desc = Utils.getTriggerActionDesc(event, tpl);
const triggerId = Triggers.insert(trigger);
const actionId = Actions.insert({
// #5536: create on the server so the cross-board link action does not land
// blank in minimongo limbo / get rejected by client allow/deny. The action
// keeps its own destination `boardId` (the board to link the card into).
Meteor.call('rules.createRule', boardId, ruleName, trigger, {
actionType: 'linkCard',
listName,
swimlaneName,
boardId: destBoardId,
desc,
});
Rules.insert({
title: ruleName,
triggerId,
actionId,
boardId,
});
},
'click .js-sort-list-action'(event, tpl) {
const data = Template.currentData();
@@ -100,8 +100,15 @@ template(name="cardActions")
option(value="receivedAt") {{_'r-df-received-at'}}
div.trigger-dropdown
input(id="reldate-days",type="number",value="0")
div.trigger-dropdown
select(id="reldate-unit")
option(value="minutes") {{_'r-unit-minutes'}}
option(value="hours") {{_'r-unit-hours'}}
option(value="days",selected="selected") {{_'r-unit-days'}}
option(value="weeks") {{_'r-unit-weeks'}}
option(value="months") {{_'r-unit-months'}}
div.trigger-text
| {{_'r-days-after'}}
| {{_'r-later'}}
div.trigger-button.js-set-reldate-action.js-goto-rules
i.fa.fa-plus
@@ -238,12 +238,16 @@ Template.cardActions.events({
const boardId = Session.get('currentBoard');
const desc = Utils.getTriggerActionDesc(event, tpl);
const dateField = tpl.find('#reldate-datefield').value;
// `days` keeps its name for backward compatibility: it is the numeric
// amount, interpreted together with `unit` (minutes/hours/days/weeks/months).
const days = parseInt(tpl.find('#reldate-days').value, 10) || 0;
const unit = tpl.find('#reldate-unit').value;
const triggerId = Triggers.insert(trigger);
const actionId = Actions.insert({
actionType: 'setDateRelative',
dateField,
days,
unit,
boardId,
desc,
});
+32 -6
View File
@@ -1,9 +1,6 @@
import { ReactiveCache } from '/imports/reactiveCache';
import { TAPi18n } from '/imports/i18n';
import Papa from 'papaparse';
import Actions from '/models/actions';
import Rules from '/models/rules';
import Triggers from '/models/triggers';
const RULES_FORMAT = 'wekan-rules-1.0.0';
const STRIP_FIELDS = ['_id', 'boardId', 'createdAt', 'modifiedAt', 'updatedAt'];
@@ -33,14 +30,43 @@ function collectBoardRules(boardId) {
.filter(Boolean);
}
// #6472: the trigger matcher (server/rulesHelper.js buildMatchingFieldsMap)
// queries every matching field of the trigger type with {$in: [value, '*']} —
// a trigger DOCUMENT that lacks one of those fields can never match. Hand-
// written or third-party JSON often omits fields like userId, so default every
// known matching field to the '*' wildcard when absent. Extra fields on
// trigger types that do not use them are harmless (never queried).
const TRIGGER_MATCHING_FIELDS = [
'userId', 'username', 'cardTitle', 'listName', 'oldListName',
'swimlaneName', 'checklistName', 'checklistItemName', 'labelId',
'attachmentName',
];
function normalizeTrigger(trigger) {
const out = { ...trigger };
TRIGGER_MATCHING_FIELDS.forEach(f => {
if (out[f] === undefined || out[f] === null || out[f] === '') out[f] = '*';
});
return out;
}
// Insert an array of {title, trigger, action} onto the given target board.
function importRules(rulesArray, boardId) {
let count = 0;
(rulesArray || []).forEach(entry => {
if (!entry || !entry.trigger || !entry.action) return;
const triggerId = Triggers.insert({ ...stripDoc(entry.trigger), boardId });
const actionId = Actions.insert({ ...stripDoc(entry.action), boardId });
Rules.insert({ title: entry.title || 'Imported rule', triggerId, actionId, boardId });
// #6472: create via the rules.createRule server method (like the rules
// wizard since #5536) instead of three optimistic client inserts — those
// are rejected by the board-admin-only allow() rules for non-admins and
// land in minimongo limbo: the imported rule LOOKS created but never
// exists on the server, so it silently does nothing until it vanishes.
Meteor.call(
'rules.createRule',
boardId,
entry.title || 'Imported rule',
normalizeTrigger(stripDoc(entry.trigger)),
stripDoc(entry.action),
);
count += 1;
});
return count;
+4 -5
View File
@@ -1,7 +1,5 @@
import { ReactiveCache } from '/imports/reactiveCache';
import Actions from '/models/actions';
import Rules from '/models/rules';
import Triggers from '/models/triggers';
function boardRuleIds() {
const boardId = Session.get('currentBoard');
@@ -62,9 +60,10 @@ Template.rulesList.events({
getSelected().forEach(ruleId => {
const rule = ReactiveCache.getRule(ruleId);
if (rule) {
Rules.remove(rule._id);
Actions.remove(rule.actionId);
Triggers.remove(rule.triggerId);
// Delete the rule + its trigger + action server-side (see
// server/rulesButton.js `rules.deleteRule`): three client-side
// Collection.remove() calls were rejected with 403 "Access denied".
Meteor.call('rules.deleteRule', rule._id);
}
});
setSelected([]);
+6 -6
View File
@@ -1,9 +1,6 @@
import { ReactiveCache } from '/imports/reactiveCache';
import { FlowRouter } from 'meteor/ostrio:flow-router-extra';
import { Utils } from '/client/lib/utils';
import Actions from '/models/actions';
import Rules from '/models/rules';
import Triggers from '/models/triggers';
Template.rulesMain.onCreated(function () {
this.rulesCurrentTab = new ReactiveVar('rulesList');
@@ -83,9 +80,12 @@ function sanitizeObject(obj) {
Template.rulesMain.events({
'click .js-delete-rule'() {
const rule = Template.currentData();
Rules.remove(rule._id);
Actions.remove(rule.actionId);
Triggers.remove(rule.triggerId);
// Delete the rule + its trigger + action in one server call. Doing this
// client-side as three separate Collection.remove() calls failed with 403
// "Access denied" whenever a trigger/action document's boardId did not
// resolve to a board in the allow() rule; the method authorizes once and
// removes all three server-side.
Meteor.call('rules.deleteRule', rule._id);
},
'click .js-goto-trigger'(event, tpl) {
event.preventDefault();
+2 -2
View File
@@ -12,7 +12,7 @@ template(name="rulesWorkflow")
.workflow-node.workflow-node-when
span.workflow-node-label {{_ 'r-when'}}
span.workflow-node-text= builderTriggerLabel
a.workflow-slot-clear.js-clear-when(title="{{_ 'remove'}}") &#10005;
a.workflow-slot-clear.js-clear-when(title="{{_ 'r-remove'}}") &#10005;
else
span.workflow-slot-placeholder {{_ 'r-when'}}: {{_ 'r-drop-trigger'}}
.workflow-arrow
@@ -22,7 +22,7 @@ template(name="rulesWorkflow")
.workflow-node.workflow-node-then
span.workflow-node-label {{_ 'r-action'}}
span.workflow-node-text= builderActionLabel
a.workflow-slot-clear.js-clear-then(title="{{_ 'remove'}}") &#10005;
a.workflow-slot-clear.js-clear-then(title="{{_ 'r-remove'}}") &#10005;
else
span.workflow-slot-placeholder {{_ 'r-action'}}: {{_ 'r-drop-action'}}
.workflow-builder-controls
+46 -32
View File
@@ -12,31 +12,44 @@ import Triggers from '/models/triggers';
// can be built entirely by dragging. Parameterized rules (specific list, label,
// member, schedule time, …) are still created with the form builder on the
// List view.
// Each palette entry carries an i18n `labelKey` (translated at render time via
// TAPi18n.__) instead of a hardcoded English string, so the whole workflow view
// follows the UI language. `labelParams` is passed to TAPi18n.__ for labels that
// need a placeholder (e.g. the scheduled time). Existing rule keys are reused
// where they fit; workflow-only labels use new `r-w-*` keys (see en.i18n.json).
const TRIGGER_PALETTE = [
{ label: 'Card is created', doc: { activityType: 'createCard', listName: '*', swimlaneName: '*', cardTitle: '*', userId: '*' } },
{ label: 'Card is moved', doc: { activityType: 'moveCard', listName: '*', oldListName: '*', swimlaneName: '*', cardTitle: '*', userId: '*' } },
{ label: 'Card is archived', doc: { activityType: 'archivedCard', userId: '*' } },
{ label: 'Card is unarchived', doc: { activityType: 'restoredCard', userId: '*' } },
{ label: 'Any label is added', doc: { activityType: 'addedLabel', labelId: '*', userId: '*' } },
{ label: 'Any label is removed', doc: { activityType: 'removedLabel', labelId: '*', userId: '*' } },
{ label: 'A member is added', doc: { activityType: 'joinMember', username: '*', userId: '*' } },
{ label: 'A member is removed', doc: { activityType: 'unjoinMember', username: '*', userId: '*' } },
{ label: 'A checklist is added', doc: { activityType: 'addChecklist', checklistName: '*', userId: '*' } },
{ label: 'An attachment is added', doc: { activityType: 'addAttachment', userId: '*' } },
{ label: 'Every day at 09:00', doc: { activityType: 'scheduledTrigger', scheduleKind: 'calendar', scheduleType: 'daily', atTime: '09:00', listName: '*', swimlaneName: '*' } },
{ labelKey: 'r-w-card-created', doc: { activityType: 'createCard', listName: '*', swimlaneName: '*', cardTitle: '*', userId: '*' } },
{ labelKey: 'r-when-a-card-is-moved', doc: { activityType: 'moveCard', listName: '*', oldListName: '*', swimlaneName: '*', cardTitle: '*', userId: '*' } },
{ labelKey: 'r-w-card-archived', doc: { activityType: 'archivedCard', userId: '*' } },
{ labelKey: 'r-w-card-unarchived', doc: { activityType: 'restoredCard', userId: '*' } },
{ labelKey: 'r-w-label-added', doc: { activityType: 'addedLabel', labelId: '*', userId: '*' } },
{ labelKey: 'r-w-label-removed', doc: { activityType: 'removedLabel', labelId: '*', userId: '*' } },
{ labelKey: 'r-w-member-added', doc: { activityType: 'joinMember', username: '*', userId: '*' } },
{ labelKey: 'r-w-member-removed', doc: { activityType: 'unjoinMember', username: '*', userId: '*' } },
{ labelKey: 'r-w-checklist-added', doc: { activityType: 'addChecklist', checklistName: '*', userId: '*' } },
{ labelKey: 'r-w-attachment-added', doc: { activityType: 'addAttachment', userId: '*' } },
{ labelKey: 'r-w-every-day-at', labelParams: { time: '09:00' }, doc: { activityType: 'scheduledTrigger', scheduleKind: 'calendar', scheduleType: 'daily', atTime: '09:00', listName: '*', swimlaneName: '*' } },
];
const ACTION_PALETTE = [
{ label: 'Move card to top', doc: { actionType: 'moveCardToTop', listName: '*', swimlaneName: '*' } },
{ label: 'Move card to bottom', doc: { actionType: 'moveCardToBottom', listName: '*', swimlaneName: '*' } },
{ label: 'Archive card', doc: { actionType: 'archive' } },
{ label: 'Unarchive card', doc: { actionType: 'unarchive' } },
{ label: 'Mark card complete', doc: { actionType: 'markCardComplete' } },
{ label: 'Mark card incomplete', doc: { actionType: 'markCardIncomplete' } },
{ label: 'Remove all members', doc: { actionType: 'removeMember', username: '*' } },
{ label: 'Set received date to now', doc: { actionType: 'setDate', dateField: 'receivedAt' } },
{ labelKey: 'r-d-move-to-top-gen', doc: { actionType: 'moveCardToTop', listName: '*', swimlaneName: '*' } },
{ labelKey: 'r-d-move-to-bottom-gen', doc: { actionType: 'moveCardToBottom', listName: '*', swimlaneName: '*' } },
{ labelKey: 'r-d-archive', doc: { actionType: 'archive' } },
{ labelKey: 'r-d-unarchive', doc: { actionType: 'unarchive' } },
{ labelKey: 'r-mark-complete', doc: { actionType: 'markCardComplete' } },
{ labelKey: 'r-mark-incomplete', doc: { actionType: 'markCardIncomplete' } },
{ labelKey: 'r-remove-all', doc: { actionType: 'removeMember', username: '*' } },
{ labelKey: 'r-w-set-received-now', doc: { actionType: 'setDate', dateField: 'receivedAt' } },
];
// Translate a palette entry's label for display / storage in the current UI
// language (matches the classic Rules view, which also stores already-translated
// description text at creation time).
function paletteLabel(entry) {
if (!entry) return '';
return TAPi18n.__(entry.labelKey, entry.labelParams);
}
Template.rulesWorkflow.onCreated(function () {
this.builderTrigger = new ReactiveVar(null);
this.builderAction = new ReactiveVar(null);
@@ -52,24 +65,22 @@ Template.rulesWorkflow.helpers({
return Utils.getCurrentBoard();
},
triggerPalette() {
return TRIGGER_PALETTE.map((t, idx) => ({ idx, label: t.label }));
return TRIGGER_PALETTE.map((t, idx) => ({ idx, label: paletteLabel(t) }));
},
actionPalette() {
return ACTION_PALETTE.map((a, idx) => ({ idx, label: a.label }));
return ACTION_PALETTE.map((a, idx) => ({ idx, label: paletteLabel(a) }));
},
builderTrigger() {
return Template.instance().builderTrigger.get();
},
builderTriggerLabel() {
const t = Template.instance().builderTrigger.get();
return t ? t.label : '';
return paletteLabel(Template.instance().builderTrigger.get());
},
builderAction() {
return Template.instance().builderAction.get();
},
builderActionLabel() {
const a = Template.instance().builderAction.get();
return a ? a.label : '';
return paletteLabel(Template.instance().builderAction.get());
},
createDisabled() {
const tpl = Template.instance();
@@ -96,9 +107,11 @@ function persistRule(tpl) {
if (!t || !a) return;
const boardId = Session.get('currentBoard');
const titleField = tpl.find('.js-workflow-rule-title');
const title = (titleField.value || '').trim() || `${t.label} → ${a.label}`;
const triggerId = Triggers.insert({ ...t.doc, boardId, desc: t.label });
const actionId = Actions.insert({ ...a.doc, boardId, desc: a.label });
const tLabel = paletteLabel(t);
const aLabel = paletteLabel(a);
const title = (titleField.value || '').trim() || `${tLabel} → ${aLabel}`;
const triggerId = Triggers.insert({ ...t.doc, boardId, desc: tLabel });
const actionId = Actions.insert({ ...a.doc, boardId, desc: aLabel });
Rules.insert({ title, triggerId, actionId, boardId });
tpl.builderTrigger.set(null);
tpl.builderAction.set(null);
@@ -140,7 +153,7 @@ Template.rulesWorkflow.events({
const a = ACTION_PALETTE[tpl.dragItem.idx];
const boardId = Session.get('currentBoard');
const oldActionId = rule.actionId;
const newActionId = Actions.insert({ ...a.doc, boardId, desc: a.label });
const newActionId = Actions.insert({ ...a.doc, boardId, desc: paletteLabel(a) });
Rules.update(ruleId, { $set: { actionId: newActionId } });
if (oldActionId) Actions.remove(oldActionId);
tpl.dragItem = null;
@@ -163,8 +176,9 @@ Template.rulesWorkflow.events({
const ruleId = node && node.dataset.ruleId;
const rule = ReactiveCache.getRule(ruleId);
if (!rule) return;
Rules.remove(rule._id);
Actions.remove(rule.actionId);
Triggers.remove(rule.triggerId);
// Delete the rule + its trigger + action server-side (see
// server/rulesButton.js `rules.deleteRule`): three client-side
// Collection.remove() calls were rejected with 403 "Access denied".
Meteor.call('rules.deleteRule', rule._id);
},
});
@@ -106,6 +106,9 @@ template(name="boardCardTitlePopup")
form
label
| {{_ 'boardCardTitlePopup-title'}}
input.js-card-filter-name(type="text" value=title autofocus)
//- #2345: cardTitleFilter is passed as the popup's data context by the
//- js-open-card-title-popup handler so reopening the popup shows the
//- filter that is already set (it used to always render empty).
input.js-card-filter-name(type="text" value=cardTitleFilter autofocus)
input.js-card-filter-button.primary.wide(type="submit" value="{{_ 'set-filter'}}")
@@ -1,4 +1,31 @@
import { TAPi18n } from '/imports/i18n';
import { Utils } from '/client/lib/utils';
import {
cardTitleFilterOrWildcard,
appendCardTitleFilterToDesc,
} from '/models/lib/ruleCardTitleFilter';
// #2345: fallback reference to the live boardTriggers template instance, so the
// card-title-filter popup can still store its value even if the Blaze
// data-context walk in Popup.getOpenerComponent() does not resolve (same
// module-level pattern as cardActions.js' sharedCardColorButtonValue).
let activeBoardTriggersTemplate = null;
// #2345: the trigger description is assembled from the wizard's DOM text, which
// never includes the card-title filter (it lives in a popup). Append it so the
// created rule's details actually show the filter.
function descWithCardTitleFilter(desc, cardTitle) {
let label = 'card title filter';
try {
const translated = TAPi18n.__('boardCardTitlePopup-title');
if (translated && translated !== 'boardCardTitlePopup-title') {
label = translated.toLowerCase();
}
} catch (e) {
// keep the English fallback label
}
return appendCardTitleFilterToDesc(desc, cardTitle, label);
}
Template.boardTriggers.onCreated(function () {
this.provaVar = new ReactiveVar('');
@@ -7,6 +34,13 @@ Template.boardTriggers.onCreated(function () {
this.setNameFilter = (name) => {
this.cardTitleFilters[this.currentPopupTriggerId] = name;
};
activeBoardTriggersTemplate = this;
});
Template.boardTriggers.onDestroyed(function () {
if (activeBoardTriggersTemplate === this) {
activeBoardTriggersTemplate = null;
}
});
Template.boardTriggers.events({
@@ -14,16 +48,24 @@ Template.boardTriggers.events({
const funct = Popup.open('boardCardTitle');
const divId = $(event.currentTarget.parentNode.parentNode).attr('id');
tpl.currentPopupTriggerId = divId;
funct.call(this, event);
// #2345: hand the already-stored filter to the popup as its data context so
// reopening it shows the current value instead of an empty input.
funct.call({ cardTitleFilter: tpl.cardTitleFilters[divId] || '' }, event);
},
'click .js-add-create-trigger'(event, tpl) {
const desc = Utils.getTriggerActionDesc(event, tpl);
const datas = Template.currentData();
const listName = tpl.find('#create-list-name').value;
const swimlaneName = tpl.find('#create-swimlane-name').value;
const boardId = Session.get('currentBoard');
const divId = $(event.currentTarget.parentNode).attr('id');
const cardTitle = tpl.cardTitleFilters[divId];
// #2345: an unset/empty filter is stored as the '*' wildcard so the trigger
// document always carries a cardTitle field (the server matches with
// cardTitle: { $in: [...] }, which a document missing the field never satisfies).
const cardTitle = cardTitleFilterOrWildcard(tpl.cardTitleFilters[divId]);
const desc = descWithCardTitleFilter(
Utils.getTriggerActionDesc(event, tpl),
cardTitle,
);
// move to generic funciont
datas.triggerVar.set({
activityType: 'createCard',
@@ -36,13 +78,16 @@ Template.boardTriggers.events({
},
'click .js-add-moved-trigger'(event, tpl) {
const datas = Template.currentData();
const desc = Utils.getTriggerActionDesc(event, tpl);
const swimlaneName = tpl.find('#create-swimlane-name-2').value;
const actionSelected = tpl.find('#move-action').value;
const listName = tpl.find('#move-list-name').value;
const boardId = Session.get('currentBoard');
const divId = $(event.currentTarget.parentNode).attr('id');
const cardTitle = tpl.cardTitleFilters[divId];
const cardTitle = cardTitleFilterOrWildcard(tpl.cardTitleFilters[divId]);
const desc = descWithCardTitleFilter(
Utils.getTriggerActionDesc(event, tpl),
cardTitle,
);
if (actionSelected === 'moved-to') {
datas.triggerVar.set({
activityType: 'moveCard',
@@ -68,27 +113,44 @@ Template.boardTriggers.events({
},
'click .js-add-gen-moved-trigger'(event, tpl) {
const datas = Template.currentData();
const desc = Utils.getTriggerActionDesc(event, tpl);
const boardId = Session.get('currentBoard');
const divId = $(event.currentTarget.parentNode).attr('id');
// #2345: this trigger ignored the card-title-filter popup entirely AND
// stored no cardTitle field at all — and since the server matches triggers
// with cardTitle: { $in: [...] }, a moveCard trigger without the field
// never fired for any card. Store the filter (or the '*' wildcard).
const cardTitle = cardTitleFilterOrWildcard(tpl.cardTitleFilters[divId]);
const desc = descWithCardTitleFilter(
Utils.getTriggerActionDesc(event, tpl),
cardTitle,
);
datas.triggerVar.set({
activityType: 'moveCard',
boardId,
cardTitle,
swimlaneName: '*',
listName: '*',
oldListName: '*',
desc,
});
},
'click .js-add-arc-trigger'(event, tpl) {
'click .js-add-arch-trigger'(event, tpl) {
const datas = Template.currentData();
const desc = Utils.getTriggerActionDesc(event, tpl);
const actionSelected = tpl.find('#arch-action').value;
const boardId = Session.get('currentBoard');
const divId = $(event.currentTarget.parentNode).attr('id');
// #2345: the archive/unarchive trigger also dropped the card-title filter.
const cardTitle = cardTitleFilterOrWildcard(tpl.cardTitleFilters[divId]);
const desc = descWithCardTitleFilter(
Utils.getTriggerActionDesc(event, tpl),
cardTitle,
);
if (actionSelected === 'archived') {
datas.triggerVar.set({
activityType: 'archivedCard',
boardId,
cardTitle,
desc,
});
}
@@ -96,6 +158,7 @@ Template.boardTriggers.events({
datas.triggerVar.set({
activityType: 'restoredCard',
boardId,
cardTitle,
desc,
});
}
@@ -104,15 +167,27 @@ Template.boardTriggers.events({
Template.boardCardTitlePopup.events({
submit(event) {
// #2345: preventDefault FIRST — if anything below throws, a real form
// submit would reload the page and silently drop the filter.
event.preventDefault();
const title = $(event.target)
.find('.js-card-filter-name')
.val()
.trim();
const opener = Popup.getOpenerComponent();
if (opener?.setNameFilter) {
let opener = null;
try {
opener = Popup.getOpenerComponent();
} catch (e) {
opener = null;
}
if (!opener || typeof opener.setNameFilter !== 'function') {
// #2345: fall back to the live boardTriggers instance when the Blaze
// data-context walk cannot resolve the opener.
opener = activeBoardTriggersTemplate;
}
if (opener && typeof opener.setNameFilter === 'function') {
opener.setNameFilter(title);
}
event.preventDefault();
Popup.back();
},
});
@@ -0,0 +1,101 @@
template(name="adminFeatures")
.setting-content
unless currentUser.isAdmin
| {{_ 'error-notAuthorized'}}
else
.content-title.ext-box
span
span.emoji-icon
i.fa.fa-flask
| {{_ 'features'}}
.content-body
.side-menu
ul
li(class="{{#if isPerformanceActive}}active{{/if}}")
a.js-features-menu(data-id="performance")
span.emoji-icon
i.fa.fa-tachometer
| {{_ 'features-performance'}}
li(class="{{#if isSecurityActive}}active{{/if}}")
a.js-features-menu(data-id="security")
span.emoji-icon
i.fa.fa-shield
| {{_ 'features-security'}}
li(class="{{#if isNotificationsActive}}active{{/if}}")
a.js-features-menu(data-id="notifications")
span.emoji-icon
i.fa.fa-bell
| {{_ 'features-notifications'}}
.main-body
if isPerformanceActive
ul.setting-detail
li.layout-form
.title {{_ 'cards-loading'}}
.form-group
select#cards-loading.js-cards-loading
each cardsLoadingOptions
if this.selected
option(value="{{value}}" selected) {{_ label}}
else
option(value="{{value}}") {{_ label}}
p.description {{_ 'cards-loading-description'}}
p.description {{_ 'cards-loading-lazy-note'}}
if isSecurityActive
ul.setting-detail
li
a.flex.js-toggle-render-links-as-plain-text
.materialCheckBox(class="{{#if renderLinksAsPlainText}}is-checked{{/if}}")
span {{_ 'render-links-as-plain-text'}}
p.description {{_ 'render-links-as-plain-text-description'}}
li
a.flex.js-toggle-always-show-code-as-text
.materialCheckBox(class="{{#if alwaysShowCodeAsText}}is-checked{{/if}}")
span {{_ 'always-show-code-as-text'}}
p.description {{_ 'always-show-code-as-text-description'}}
li
a.flex.js-toggle-disable-all-import
.materialCheckBox(class="{{#if disableAllImport}}is-checked{{/if}}")
span {{_ 'disable-all-import'}}
p.description {{_ 'disable-all-import-description'}}
li
a.flex.js-toggle-disable-all-export
.materialCheckBox(class="{{#if disableAllExport}}is-checked{{/if}}")
span {{_ 'disable-all-export'}}
p.description {{_ 'disable-all-export-description'}}
li
a.flex.js-toggle-disable-import-avatars
.materialCheckBox(class="{{#if disableImportAvatars}}is-checked{{/if}}")
span {{_ 'disable-import-avatars'}}
p.description {{_ 'disable-import-avatars-description'}}
li
a.flex.js-toggle-disable-export-avatars
.materialCheckBox(class="{{#if disableExportAvatars}}is-checked{{/if}}")
span {{_ 'disable-export-avatars'}}
p.description {{_ 'disable-export-avatars-description'}}
li
a.flex.js-toggle-anonymize-import-users
.materialCheckBox(class="{{#if anonymizeImportUsers}}is-checked{{/if}}")
span {{_ 'anonymize-import-users'}}
p.description {{_ 'anonymize-import-users-description'}}
li
a.flex.js-toggle-anonymize-export-users
.materialCheckBox(class="{{#if anonymizeExportUsers}}is-checked{{/if}}")
span {{_ 'anonymize-export-users'}}
p.description {{_ 'anonymize-export-users-description'}}
if isNotificationsActive
ul.setting-detail
li
a.flex.js-toggle-disable-activities
.materialCheckBox(class="{{#if disableActivities}}is-checked{{/if}}")
span {{_ 'disable-activities'}}
p.description {{_ 'disable-activities-description'}}
li
a.flex.js-toggle-disable-notifications
.materialCheckBox(class="{{#if disableNotifications}}is-checked{{/if}}")
span {{_ 'disable-notifications'}}
p.description {{_ 'disable-notifications-description'}}
li
a.flex.js-toggle-disable-watch
.materialCheckBox(class="{{#if disableWatch}}is-checked{{/if}}")
span {{_ 'disable-watch'}}
p.description {{_ 'disable-watch-description'}}
+118
View File
@@ -0,0 +1,118 @@
import { ReactiveCache } from '/imports/reactiveCache';
import { ReactiveVar } from 'meteor/reactive-var';
import Settings from '/models/settings';
// Admin Panel / Features — a home for optional / performance / tier-gated
// capabilities. First entry: "Card loading" (all | lazy), which also mirrors the
// CARDS_LOADING env var. Grouped by category in the side menu so more feature
// toggles (and, later, pricing-tier gating) can be added here.
Template.adminFeatures.onCreated(function () {
this.activePane = new ReactiveVar('performance');
Meteor.subscribe('setting');
});
Template.adminFeatures.helpers({
isPerformanceActive() {
return Template.instance().activePane.get() === 'performance';
},
isSecurityActive() {
return Template.instance().activePane.get() === 'security';
},
isNotificationsActive() {
return Template.instance().activePane.get() === 'notifications';
},
cardsLoadingOptions() {
const current = (ReactiveCache.getCurrentSetting() || {}).cardsLoading || 'all';
return [
{ value: 'all', label: 'cards-loading-all', selected: current === 'all' },
{ value: 'lazy', label: 'cards-loading-lazy', selected: current === 'lazy' },
];
},
renderLinksAsPlainText() {
return (ReactiveCache.getCurrentSetting() || {}).renderLinksAsPlainText;
},
alwaysShowCodeAsText() {
return (ReactiveCache.getCurrentSetting() || {}).alwaysShowCodeAsText;
},
disableAllImport() {
return (ReactiveCache.getCurrentSetting() || {}).disableAllImport;
},
disableAllExport() {
return (ReactiveCache.getCurrentSetting() || {}).disableAllExport;
},
disableImportAvatars() {
return (ReactiveCache.getCurrentSetting() || {}).disableImportAvatars;
},
disableExportAvatars() {
return (ReactiveCache.getCurrentSetting() || {}).disableExportAvatars;
},
anonymizeImportUsers() {
return (ReactiveCache.getCurrentSetting() || {}).anonymizeImportUsers;
},
anonymizeExportUsers() {
return (ReactiveCache.getCurrentSetting() || {}).anonymizeExportUsers;
},
disableActivities() {
return (ReactiveCache.getCurrentSetting() || {}).disableActivities;
},
disableNotifications() {
return (ReactiveCache.getCurrentSetting() || {}).disableNotifications;
},
disableWatch() {
return (ReactiveCache.getCurrentSetting() || {}).disableWatch;
},
});
// Toggle one boolean setting field, saving immediately.
function toggleSettingField(field) {
const setting = ReactiveCache.getCurrentSetting();
if (setting) {
Settings.update(setting._id, { $set: { [field]: !setting[field] } });
}
}
Template.adminFeatures.events({
'click .js-features-menu'(event, tpl) {
tpl.activePane.set(event.currentTarget.dataset.id);
},
'change .js-cards-loading'(event) {
const value = event.currentTarget.value === 'lazy' ? 'lazy' : 'all';
const setting = ReactiveCache.getCurrentSetting();
if (setting) {
Settings.update(setting._id, { $set: { cardsLoading: value } });
}
},
'click .js-toggle-render-links-as-plain-text'() {
toggleSettingField('renderLinksAsPlainText');
},
'click .js-toggle-always-show-code-as-text'() {
toggleSettingField('alwaysShowCodeAsText');
},
'click .js-toggle-disable-all-import'() {
toggleSettingField('disableAllImport');
},
'click .js-toggle-disable-all-export'() {
toggleSettingField('disableAllExport');
},
'click .js-toggle-disable-import-avatars'() {
toggleSettingField('disableImportAvatars');
},
'click .js-toggle-disable-export-avatars'() {
toggleSettingField('disableExportAvatars');
},
'click .js-toggle-anonymize-import-users'() {
toggleSettingField('anonymizeImportUsers');
},
'click .js-toggle-anonymize-export-users'() {
toggleSettingField('anonymizeExportUsers');
},
'click .js-toggle-disable-activities'() {
toggleSettingField('disableActivities');
},
'click .js-toggle-disable-notifications'() {
toggleSettingField('disableNotifications');
},
'click .js-toggle-disable-watch'() {
toggleSettingField('disableWatch');
},
});
Loaded 100 of 913 files, more files were not shown because too many files have changed in this diff. Show more