Simon Zünd
3f6e810067
This change adds an optional 'scopeNumber' parameter to the
'Debugger.evaluateOnCallFrame' CDP command.
The 'scopeNumber' parameter specifies the 0-based index of the scope
to evaluate in. The index matches the scope chain from the
'Debugger.paused' event. If you do not provide a 'scopeNumber',
the default value is 0 (the innermost scope).
Key changes:
- CDP Protocol: Add optional integer 'scopeNumber' to the
'Debugger.evaluateOnCallFrame' command in js_protocol.pdl.
- Inspector: Validate 'scopeNumber' in 'V8DebuggerAgentImpl'.
If 'scopeNumber' is not valid, the command returns an error:
"Could not find scope with given number".
- Debug Evaluate: Update 'ContextBuilder' to start evaluation from
the specified scope.
- For an inner scope, the builder excludes block scopes that are
deeper than 'scopeNumber'.
- For an outer scope (closure, script, or global), the builder
evaluates in the context of that scope. Variables in inner
scopes are not visible.
- Tests: Add '.evaluate(expression)' to 'Scope' objects in
test-api.js. Add tests in test/inspector/debugger/ and
test/debugger/debug/ to verify evaluation across different scopes.
TAG=agy
CONV=881baa05-e1f7-4dbe-a278-ce57441c77bc
Fixed: 542461144
Change-Id: Ida16237e8418bfc5422f48cad3e6a4052b3b282d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8200344
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Cr-Commit-Position: refs/heads/main@{#109062}
94 lines
3.4 KiB
JavaScript
94 lines
3.4 KiB
JavaScript
// Copyright 2013 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
|
|
Debug = debug.Debug;
|
|
var listened = false;
|
|
|
|
function listener(event, exec_state, event_data, data) {
|
|
if (event != Debug.DebugEvent.Break) return;
|
|
try {
|
|
assertEquals("goo", exec_state.frame(0).evaluate("goo").value());
|
|
assertEquals("goo", exec_state.frame(0).scope(1).evaluate("goo").value());
|
|
assertThrows(() => exec_state.frame(0).scope(1).evaluate("w").value());
|
|
exec_state.frame(0).evaluate("goo = 'goo foo'");
|
|
assertEquals("bar return", exec_state.frame(0).evaluate("bar()").value());
|
|
assertEquals("inner bar", exec_state.frame(0).evaluate("inner").value());
|
|
assertEquals("outer bar", exec_state.frame(0).evaluate("outer").value());
|
|
|
|
assertEquals("baz inner", exec_state.frame(0).evaluate("baz").value());
|
|
assertEquals("baz outer", exec_state.frame(1).evaluate("baz").value());
|
|
exec_state.frame(0).evaluate("w = 'w foo'");
|
|
exec_state.frame(0).evaluate("inner = 'inner foo'");
|
|
exec_state.frame(0).evaluate("outer = 'outer foo'");
|
|
exec_state.frame(0).evaluate("baz = 'baz inner foo'");
|
|
exec_state.frame(1).evaluate("baz = 'baz outer foo'");
|
|
listened = true;
|
|
} catch (e) {
|
|
print(e);
|
|
print(e.stack);
|
|
}
|
|
}
|
|
|
|
Debug.setListener(listener);
|
|
|
|
var outer = "outer";
|
|
var baz = "baz outer";
|
|
|
|
function foo() {
|
|
var inner = "inner";
|
|
var baz = "baz inner";
|
|
var goo = "goo";
|
|
var withw = { w: "w" };
|
|
var withv = { v: "v" };
|
|
|
|
with (withv) {
|
|
var bar = function bar() {
|
|
assertEquals("goo foo", goo);
|
|
inner = "inner bar";
|
|
outer = "outer bar";
|
|
v = "v bar";
|
|
return "bar return";
|
|
};
|
|
}
|
|
|
|
with (withw) {
|
|
debugger;
|
|
}
|
|
|
|
assertEquals("inner foo", inner);
|
|
assertEquals("baz inner foo", baz);
|
|
assertEquals("w foo", withw.w);
|
|
assertEquals("v bar", withv.v);
|
|
}
|
|
|
|
foo();
|
|
assertEquals("outer foo", outer);
|
|
assertEquals("baz outer foo", baz);
|
|
assertTrue(listened);
|
|
Debug.setListener(null);
|