Kateryna Prokopenko
84d5d70742
Original change's description:
> [profiler] Relax AllocationNode name DCHECK for script functions
>
> In SamplingHeapProfiler::FindOrAddChildNode, nodes with a valid
> script_id are keyed solely by (script_id, start_position), so the
> debug name is not invariant: an anonymous function's inferred name can
> change after bytecode flushing and SFI reclamation, and default class
> constructors at offset 0 share (script_id, 0) with the top-level script.
>
> Narrow the assertion with DCHECK_IMPLIES so name equality is only
> checked for kNoScriptId nodes (which are keyed by name pointer). This
> is safe because insertion and OnWeakCallback erasure both key script
> nodes solely by (script_id, start_position), and node names remain
> valid in StringsStorage for the lifetime of the profiler.
>
> Bug: 577245772
> Change-Id: I269b8b7858a53b0038f02c6211a3dfba8be8e88b
> Fixed: 577245772
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8714539
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
> Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
> Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#111568}
(cherry picked from commit 0095512e3a)
Bug: 582139904,577245772,577245772
Change-Id: I269b8b7858a53b0038f02c6211a3dfba8be8e88b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8743396
Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/15.8@{#31}
Cr-Branched-From: 50e276f4a8110c6458b7a8db41bd0ab91298741d-refs/heads/15.8.62@{#1}
Cr-Branched-From: 325ad4b6259f4235ee5322c6d3bca9be85be564b-refs/heads/main@{#111169}