Release 2.7.15

Replace the warning of null owner on shutdown with null checks of the owner uuid
Cache the landlord instead of parsing it twice in GeneralRegion#isLandLord
2026-11-07 01:42:34 -05:00 · 2023-11-24 21:38:48 +11:00 · 2023-11-15 13:06:22 +11:00 · 2023-11-15 13:01:34 +11:00 · 2023-11-15 12:40:17 +11:00 · 2023-11-14 03:46:28 +11:00
84 changed files with 558 additions and 410 deletions
@@ -1,5 +1,5 @@
 plugins {
-    id("com.github.johnrengelman.shadow") version "7.1.2"
+    id("com.github.johnrengelman.shadow") version "8.1.1"
 }

 description = "AreaShop"
@@ -24,15 +24,14 @@ dependencies {
    }

    // 3rd party libraries
-    implementation(libs.findbugs)
-    implementation("io.papermc:paperlib:1.0.7")
+    implementation("io.papermc:paperlib:1.0.8")
    implementation("com.github.NLthijs48:InteractiveMessenger:e7749258ca")
    implementation("com.github.NLthijs48:BukkitDo:819d51ec2b")
-    implementation("io.github.baked-libs:dough-data:1.0.3")
-    implementation("com.google.inject:guice:5.1.0") {
+    implementation("io.github.baked-libs:dough-data:1.2.0")
+    implementation("com.google.inject:guice:7.0.0") {
        exclude("com.google.guava", "guava")
    }
-    implementation("com.google.inject.extensions:guice-assistedinject:5.1.0") {
+    implementation("com.google.inject.extensions:guice-assistedinject:7.0.0") {
        exclude("com.google.guava", "guava")
    }

@@ -41,15 +40,22 @@ dependencies {
    implementation(projects.areashopNms)
    implementation(projects.adapters.platform.platformInterface)
    implementation(projects.adapters.platform.paper)
-    // Adapters
+
    runtimeOnly(projects.adapters.plugins.worldedit)
    runtimeOnly(projects.adapters.plugins.worldguard)
    runtimeOnly(projects.adapters.plugins.fastasyncworldedit)
-    runtimeOnly(project(":adapters:platform:bukkit-1-17", "reobf"))
-    runtimeOnly(project(":adapters:platform:bukkit-1-18", "reobf"))
-    runtimeOnly(project(":adapters:platform:bukkit-1-19", "reobf"))
+    // Adapters
+    if (!providers.environmentVariable("JITPACK").isPresent) {
+        runtimeOnly(project(":adapters:platform:bukkit-1-17", "reobf"))
+    }
+    runtimeOnly(projects.adapters.platform.bukkitModern)
+    testImplementation("com.github.seeseemelk:MockBukkit-v1.20:3.9.0")
+    testImplementation("org.junit.jupiter:junit-jupiter-api:5.8.1")
+    testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:5.8.1")
 }

+
+
 repositories {
    mavenCentral()
 }
@@ -62,7 +68,9 @@ tasks {
    }

    assemble {
-        dependsOn(shadowJar)
+        if (!providers.systemProperty("JITPACK").isPresent) {
+            dependsOn(shadowJar)
+        }
    }

    jar {
@@ -89,8 +97,9 @@ tasks {
        relocate("io.papermc.lib", "${base}.paperlib")
        relocate("io.github.bakedlibs.dough", "${base}.dough")
        relocate("com.google.inject", "${base}.inject")
+        relocate("com.google.errorprone", "${base}.errorprone")
        relocate("org.aopalliance", "${base}.aopalliance")
        relocate("javax.annotation", "${base}.javax.annotation")
-        relocate("javax.inject", "${base}.javax.inject")
+        relocate("jakarta.inject", "${base}.jakarta.inject")
    }
 }
@@ -25,11 +25,14 @@ import me.wiefferink.areashop.modules.AreaShopModule;
 import me.wiefferink.areashop.modules.BukkitModule;
 import me.wiefferink.areashop.modules.DependencyModule;
 import me.wiefferink.areashop.modules.PlatformModule;
-import me.wiefferink.areashop.nms.NMS;
+import me.wiefferink.areashop.platform.adapter.PlatformAdapter;
 import me.wiefferink.areashop.tools.GithubUpdateCheck;
 import me.wiefferink.areashop.tools.SimpleMessageBridge;
 import me.wiefferink.areashop.tools.SpigotPlatform;
 import me.wiefferink.areashop.tools.Utils;
+import me.wiefferink.areashop.tools.version.Version;
+import me.wiefferink.areashop.tools.version.VersionData;
+import me.wiefferink.areashop.tools.version.VersionUtil;
 import me.wiefferink.bukkitdo.Do;
 import me.wiefferink.interactivemessenger.source.LanguageManager;
 import net.milkbowl.vault.economy.Economy;
@@ -70,7 +73,7 @@ public final class AreaShop extends JavaPlugin implements AreaShopApi {
 	private WorldGuardInterface worldGuardInterface = null;
 	private WorldEditPlugin worldEdit = null;
 	private WorldEditInterface worldEditInterface = null;
-	private NMS nms;
+	private PlatformAdapter platformAdapter;
 	private MessageBridge messageBridge;
 	private IFileManager fileManager = null;
 	private LanguageManager languageManager = null;
@@ -172,18 +175,34 @@ public final class AreaShop extends JavaPlugin implements AreaShopApi {
 		signErrorLogger = new SignErrorLogger(new File(getDataFolder(), signLogFile));

 		// Setup NMS Impl
-		String rawServerVersion = Bukkit.getServer().getClass().getPackageName();
-		String[] split = rawServerVersion.split("\\.");
-		String serverVersion = split[3];
-		try {
-			Class<?> nmsImpl = Class.forName("me.wiefferink.areashop.adapters.platform." + serverVersion + ".NMSImpl");
-			this.nms = nmsImpl.asSubclass(NMS.class).getConstructor().newInstance();
-		} catch (ReflectiveOperationException ex) {
-			ex.printStackTrace();
-			error("Failed to initialize NMS implementation!");
+		Version currentServerVersion = VersionUtil.parseMinecraftVersion(Bukkit.getBukkitVersion());
+		if (currentServerVersion.versionData().isOlderThan(VersionUtil.MC_1_17_1)) {
+			error("Unsupported minecraft version: " + currentServerVersion + "! Minimum is 1.17.1");
 			shutdownOnError();
 			return;
 		}
+		if (currentServerVersion.versionData().equals(VersionUtil.MC_1_17_1)) {
+			try {
+				Class<?> adapterImpl = Class.forName("me.wiefferink.areashop.adapters.platform.legacy.LegacyPlatformAdapter");
+				this.platformAdapter = adapterImpl.asSubclass(PlatformAdapter.class).getConstructor().newInstance();
+			} catch (ReflectiveOperationException ex) {
+				ex.printStackTrace();
+				error("Failed to initialize legacy PlatformAdapter implementation!");
+				shutdownOnError();
+				return;
+			}
+		} else {
+			try {
+				Class<?> adapterImpl = Class.forName("me.wiefferink.areashop.adapters.platform.modern.ModernPlatformAdapter");
+				this.platformAdapter = adapterImpl.asSubclass(PlatformAdapter.class).getConstructor().newInstance();
+			} catch (ReflectiveOperationException ex) {
+				ex.printStackTrace();
+				error("Failed to initialize modern PlatformAdapter implementation!");
+				shutdownOnError();
+				return;
+			}
+		}
+
 		final MinecraftPlatform platform;
 		if (PaperLib.isPaper()) {
 			platform = new PaperPlatform(this);
@@ -192,7 +211,7 @@ public final class AreaShop extends JavaPlugin implements AreaShopApi {
 			platform = new SpigotPlatform(this);
 			info("Detected Spigot; using the SpigotPlatform impl");
 		}
-		final PlatformModule platformModule = new PlatformModule(platform, this.nms);
+		final PlatformModule platformModule = new PlatformModule(platform, this.platformAdapter);

 		// Check if Vault is present
 		if(getServer().getPluginManager().getPlugin("Vault") == null) {
@@ -254,7 +273,8 @@ public final class AreaShop extends JavaPlugin implements AreaShopApi {
 			return;
 		}

-		AreaShopModule asModule = new AreaShopModule(this, messageBridge, nms, worldEditInterface, worldGuardInterface, signErrorLogger, platformModule, dependencyModule);
+		AreaShopModule asModule = new AreaShopModule(this, messageBridge,
+				platformAdapter, worldEditInterface, worldGuardInterface, signErrorLogger, platformModule, dependencyModule);
 		injector = Guice.createInjector(Stage.PRODUCTION, new BukkitModule(getServer()), asModule);

 		// Load all data from files and check versions
@@ -271,7 +291,7 @@ public final class AreaShop extends JavaPlugin implements AreaShopApi {
 		featureManager = injector.getInstance(FeatureManager.class);
 		featureManager.initializeFeatures(injector);
 		managers.add(featureManager);
-		signManager = new SignManager();
+		signManager = injector.getInstance(SignManager.class);
 		managers.add(signManager);

 		// Register the event listeners
@@ -296,15 +316,18 @@ public final class AreaShop extends JavaPlugin implements AreaShopApi {
 					this,
 					"md5sha256",
 					"AreaShop"
-			).withVersionComparator((latestVersion, currentVersion) ->
-					!cleanVersion(latestVersion).equals(cleanVersion(currentVersion))
+			).withVersionComparator((latestVersion, currentVersion) -> {
+				Version latest = Version.parse(cleanVersion(latestVersion));
+				Version current = Version.parse(cleanVersion(currentVersion));
+				return latest.versionData().isNewerThan(current.versionData());
+			}
 			).checkUpdate(result -> {
 				AreaShop.debug("Update check result:", result);
 				if(!result.hasUpdate()) {
 					return;
 				}

-				AreaShop.info("Update from AreaShop V" + cleanVersion(result.getCurrentVersion()) + " to AreaShop V" + cleanVersion(result.getLatestVersion()) + " available, get the latest version at https://github.com/md5sha256/releases");
+				AreaShop.info("Update from AreaShop V" + cleanVersion(result.getCurrentVersion()) + " to AreaShop V" + cleanVersion(result.getLatestVersion()) + " available, get the latest version at https://github.com/md5sha256/AreaShop/releases");
 				for(Player player : Utils.getOnlinePlayers()) {
 					notifyUpdate(player);
 				}
@@ -409,8 +432,8 @@ public final class AreaShop extends JavaPlugin implements AreaShopApi {
 		this.chatprefix = chatprefix;
 	}

-	public NMS getNms() {
-		return nms;
+	public PlatformAdapter getPlatformAdapter() {
+		return platformAdapter;
 	}

 	public SignErrorLogger getSignErrorLogger() {
@@ -1,6 +1,8 @@
 package me.wiefferink.areashop.commands;

 import com.sk89q.worldguard.protection.regions.ProtectedRegion;
+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.events.ask.AddingRegionEvent;
@@ -24,8 +26,6 @@ import org.bukkit.World;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.Calendar;
 import java.util.HashMap;
@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.adapters.platform.OfflinePlayerHelper;
 import me.wiefferink.areashop.managers.IFileManager;
@@ -12,8 +14,6 @@ import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;
 import org.bukkit.plugin.Plugin;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.features.signs.RegionSign;
 import me.wiefferink.areashop.features.signs.SignManager;
@@ -15,8 +17,6 @@ import org.bukkit.entity.Player;
 import org.bukkit.plugin.Plugin;
 import org.bukkit.util.BlockIterator;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Optional;
@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.BuyRegion;
@@ -8,8 +10,6 @@ import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;
 import org.bukkit.plugin.Plugin;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.events.ask.DeletingRegionEvent;
 import me.wiefferink.areashop.interfaces.WorldEditInterface;
@@ -12,8 +14,6 @@ import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.TreeSet;
@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.adapters.platform.OfflinePlayerHelper;
 import me.wiefferink.areashop.managers.IFileManager;
@@ -8,16 +10,11 @@ import me.wiefferink.areashop.regions.GeneralRegion;
 import me.wiefferink.areashop.regions.RentRegion;
 import me.wiefferink.areashop.tools.BukkitSchedulerExecutor;
 import me.wiefferink.areashop.tools.Utils;
-import org.bukkit.Bukkit;
-import org.bukkit.OfflinePlayer;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;
-import java.util.stream.Collectors;

@Singleton
 public class DelfriendCommand extends CommandAreaShop {
@@ -1,9 +1,10 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.features.signs.RegionSign;
 import me.wiefferink.areashop.features.signs.SignManager;
-import me.wiefferink.areashop.features.signs.SignsFeature;
 import me.wiefferink.areashop.tools.Materials;
 import org.bukkit.Material;
 import org.bukkit.block.Block;
@@ -11,8 +12,6 @@ import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;
 import org.bukkit.util.BlockIterator;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Optional;
@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.BuyRegion;
@@ -11,13 +13,12 @@ import net.milkbowl.vault.economy.Economy;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Random;
+import java.util.concurrent.ThreadLocalRandom;

@Singleton
 public class FindCommand extends CommandAreaShop {
@@ -96,7 +97,7 @@ public class FindCommand extends CommandAreaShop {
 			}
 			if(!results.isEmpty()) {
 				// Draw a random one
-				BuyRegion region = results.get(new Random().nextInt(results.size()));
+				BuyRegion region = results.get(ThreadLocalRandom.current().nextInt(results.size()));
 				Message onlyInGroup = Message.empty();
 				if(group != null) {
 					onlyInGroup = Message.fromKey("find-onlyInGroup").replacements(args[3]);
@@ -136,7 +137,7 @@ public class FindCommand extends CommandAreaShop {
 			}
 			if(!results.isEmpty()) {
 				// Draw a random one
-				RentRegion region = results.get(new Random().nextInt(results.size()));
+				RentRegion region = results.get(ThreadLocalRandom.current().nextInt(results.size()));
 				Message onlyInGroup = Message.empty();
 				if(group != null) {
 					onlyInGroup = Message.fromKey("find-onlyInGroup").replacements(args[3]);
@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.interfaces.WorldEditInterface;
 import me.wiefferink.areashop.interfaces.WorldEditSelection;
@@ -11,8 +13,6 @@ import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.TreeSet;
@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.interfaces.WorldEditInterface;
 import me.wiefferink.areashop.interfaces.WorldEditSelection;
@@ -11,8 +13,6 @@ import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.TreeSet;
@@ -1,13 +1,13 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.RegionGroup;
 import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Set;
@@ -1,12 +1,12 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,13 +1,12 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
-import me.wiefferink.areashop.regions.ImportJob;
 import me.wiefferink.areashop.regions.ImportJobFactory;
 import me.wiefferink.interactivemessenger.processing.Message;
 import org.bukkit.command.CommandSender;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,6 +1,8 @@
 package me.wiefferink.areashop.commands;

 import io.github.bakedlibs.dough.blocks.BlockPosition;
+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.BuyRegion;
@@ -12,8 +14,6 @@ import me.wiefferink.interactivemessenger.processing.Message;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashSet;
@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.adapters.platform.OfflinePlayerHelper;
 import me.wiefferink.areashop.managers.IFileManager;
@@ -8,13 +10,10 @@ import me.wiefferink.areashop.regions.GeneralRegion;
 import me.wiefferink.areashop.regions.RentRegion;
 import me.wiefferink.areashop.tools.BukkitSchedulerExecutor;
 import me.wiefferink.areashop.tools.Utils;
-import org.bukkit.Bukkit;
 import org.bukkit.OfflinePlayer;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.HashSet;
 import java.util.List;
@@ -67,40 +66,44 @@ public class MeCommand extends CommandAreaShop {
 			this.offlinePlayerHelper.lookupOfflinePlayerAsync(args[1]).thenAcceptAsync(offlinePlayer -> {
 				if (!offlinePlayer.hasPlayedBefore()) {
 					messageBridge.message(sender, "me-noPlayer", args[1]);
+				} else {
+					sendMessageAboutRegions(sender, offlinePlayer);
 				}
 			}, this.executor);
 			return;
 		}
-		if(!player.hasPlayedBefore()) {
-			return;
-		}
+		sendMessageAboutRegions(sender, player);
+	}

+	private void sendMessageAboutRegions(CommandSender sender, OfflinePlayer target) {
 		// Get the regions owned by the player
 		Set<RentRegion> rentRegions = new HashSet<>();
 		for(RentRegion region : fileManager.getRentsRef()) {
-			if(region.isOwner(player)) {
+			if(region.isOwner(target)) {
 				rentRegions.add(region);
 			}
 		}
 		Set<BuyRegion> buyRegions = new HashSet<>();
 		for(BuyRegion region : fileManager.getBuysRef()) {
-			if(region.isOwner(player)) {
+			if(region.isOwner(target)) {
 				buyRegions.add(region);
 			}
 		}
 		// Get the regions the player is added as friend
 		Set<GeneralRegion> friendRegions = new HashSet<>();
 		for(GeneralRegion region : fileManager.getRegionsRef()) {
-			if(region.getFriendsFeature().getFriends().contains(player.getUniqueId())) {
+			if(region.getFriendsFeature().getFriends().contains(target.getUniqueId())) {
 				friendRegions.add(region);
 			}
 		}

 		// Send messages
 		boolean foundSome = !rentRegions.isEmpty() || !buyRegions.isEmpty() || !friendRegions.isEmpty();
-		if(foundSome) {
-			messageBridge.message(sender, "me-header", player.getName());
+		if(!foundSome) {
+			messageBridge.message(sender, "me-nothing", target.getName());
+			return;
 		}
+		messageBridge.message(sender, "me-header", target.getName());
 		if(!rentRegions.isEmpty()) {
 			for(RentRegion region : rentRegions) {
 				messageBridge.messageNoPrefix(sender, "me-rentLine", region);
@@ -116,12 +119,7 @@ public class MeCommand extends CommandAreaShop {
 				messageBridge.messageNoPrefix(sender, "me-friendLine", region);
 			}
 		}
-
-		if(!foundSome) {
-			messageBridge.message(sender, "me-nothing", player.getName());
-		} else {
-			messageBridge.messageNoPrefix(sender, "me-clickHint");
-		}
+		messageBridge.messageNoPrefix(sender, "me-clickHint");
 	}

 	@Override
@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.tools.Utils;
 import me.wiefferink.interactivemessenger.processing.Message;
@@ -8,8 +10,6 @@ import org.bukkit.Bukkit;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,12 +1,11 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.MessageBridge;
 import org.bukkit.command.CommandSender;

-import javax.inject.Inject;
-import javax.inject.Singleton;
-
@Singleton
 public class ReloadCommand extends CommandAreaShop {

@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.RentRegion;
@@ -7,8 +9,6 @@ import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.BuyRegion;
@@ -7,8 +9,6 @@ import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.BuyRegion;
@@ -8,8 +10,6 @@ import me.wiefferink.areashop.regions.RentRegion;
 import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.BuyRegion;
@@ -8,8 +10,6 @@ import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.RentRegion;
@@ -8,8 +10,6 @@ import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;
 import org.bukkit.plugin.Plugin;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.adapters.platform.OfflinePlayerHelper;
 import me.wiefferink.areashop.managers.IFileManager;
@@ -9,8 +11,6 @@ import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.adapters.platform.OfflinePlayerHelper;
 import me.wiefferink.areashop.managers.IFileManager;
@@ -8,13 +10,9 @@ import me.wiefferink.areashop.regions.GeneralRegion;
 import me.wiefferink.areashop.regions.RentRegion;
 import me.wiefferink.areashop.tools.BukkitSchedulerExecutor;
 import me.wiefferink.areashop.tools.Utils;
-import org.bukkit.Bukkit;
-import org.bukkit.OfflinePlayer;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.Calendar;
 import java.util.List;
@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.BuyRegion;
@@ -9,8 +11,6 @@ import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,6 +1,7 @@
 package me.wiefferink.areashop.commands;

-import me.wiefferink.areashop.AreaShop;
+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.GeneralRegion;
@@ -8,8 +9,6 @@ import org.bukkit.command.CommandSender;
 import org.bukkit.configuration.ConfigurationSection;
 import org.bukkit.plugin.Plugin;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,6 +1,8 @@
 package me.wiefferink.areashop.commands;

 import com.sk89q.worldguard.protection.regions.ProtectedRegion;
+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.BuyRegion;
@@ -10,8 +12,6 @@ import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -2,6 +2,8 @@ package me.wiefferink.areashop.commands;

 import com.sk89q.worldguard.protection.managers.RegionManager;
 import com.sk89q.worldguard.protection.regions.ProtectedCuboidRegion;
+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.events.ask.AddingRegionEvent;
@@ -22,8 +24,6 @@ import org.bukkit.plugin.Plugin;
 import org.bukkit.scheduler.BukkitRunnable;
 import org.bukkit.util.Vector;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.BuyRegion;
@@ -7,8 +9,6 @@ import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,13 +1,13 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.GeneralRegion;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.commands;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.regions.GeneralRegion;
@@ -8,8 +10,6 @@ import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;

@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.features;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.events.ask.AddingRegionEvent;
 import me.wiefferink.areashop.events.ask.BuyingRegionEvent;
@@ -21,8 +23,6 @@ import org.bukkit.configuration.ConfigurationSection;
 import org.bukkit.event.EventHandler;
 import org.bukkit.event.EventPriority;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.List;

@Singleton
@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.features;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.events.ask.BuyingRegionEvent;
 import me.wiefferink.areashop.events.ask.RentingRegionEvent;
@@ -20,8 +22,6 @@ import me.wiefferink.areashop.tools.Utils;
 import org.bukkit.event.EventHandler;

 import javax.annotation.Nonnull;
-import javax.inject.Inject;
-import javax.inject.Singleton;

@Singleton
 public class DebugFeature extends RegionFeature {
@@ -3,6 +3,7 @@ package me.wiefferink.areashop.features;
 import com.google.inject.assistedinject.Assisted;
 import com.google.inject.assistedinject.AssistedInject;
 import com.sk89q.worldguard.protection.regions.ProtectedRegion;
+import jakarta.inject.Inject;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.features.signs.RegionSign;
 import me.wiefferink.areashop.features.signs.SignManager;
@@ -19,7 +20,6 @@ import org.bukkit.entity.Player;
 import org.bukkit.util.Vector;

 import javax.annotation.Nonnull;
-import javax.inject.Inject;
 import java.util.Collection;
 import java.util.EnumSet;
 import java.util.Iterator;
@@ -5,6 +5,8 @@ import com.sk89q.worldguard.protection.flags.Flag;
 import com.sk89q.worldguard.protection.flags.InvalidFlagFormat;
 import com.sk89q.worldguard.protection.flags.RegionGroupFlag;
 import com.sk89q.worldguard.protection.regions.ProtectedRegion;
+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.events.notify.UpdateRegionEvent;
 import me.wiefferink.areashop.interfaces.RegionAccessSet;
@@ -15,8 +17,6 @@ import org.bukkit.configuration.ConfigurationSection;
 import org.bukkit.event.EventHandler;

 import javax.annotation.Nonnull;
-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.Objects;
 import java.util.Set;
 import java.util.UUID;
@@ -7,7 +7,7 @@ import io.github.bakedlibs.dough.blocks.BlockPosition;
 import io.papermc.lib.PaperLib;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.managers.SignErrorLogger;
-import me.wiefferink.areashop.nms.BlockBehaviourHelper;
+import me.wiefferink.areashop.platform.adapter.BlockBehaviourHelper;
 import me.wiefferink.areashop.regions.GeneralRegion;
 import me.wiefferink.areashop.tools.Materials;
 import me.wiefferink.areashop.tools.SignUtils;
@@ -3,6 +3,7 @@ package me.wiefferink.areashop.features.signs;
 import io.github.bakedlibs.dough.blocks.BlockPosition;
 import io.github.bakedlibs.dough.blocks.ChunkPosition;
 import org.bukkit.Location;
+import org.bukkit.World;

 import java.util.ArrayList;
 import java.util.Collection;
@@ -52,8 +53,9 @@ public class SignCache {
    public Optional<RegionSign> removeSign(BlockPosition position) {
        RegionSign removed = this.allSigns.remove(position.getPosition());
        if (removed != null) {
-            Location location = position.toLocation();
-            this.signsByChunk.remove(new ChunkPosition(location).getPosition());
+            World world = position.getWorld();
+            ChunkPosition chunkPosition = new ChunkPosition(world, position.getChunkX(), position.getChunkZ());
+            this.signsByChunk.remove(chunkPosition.getPosition());
            // Remove the sign from the region
        }
        return Optional.ofNullable(removed);
@@ -10,7 +10,7 @@ import me.wiefferink.areashop.events.notify.UpdateRegionEvent;
 import me.wiefferink.areashop.interfaces.WorldGuardInterface;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.managers.SignLinkerManager;
-import me.wiefferink.areashop.nms.BlockBehaviourHelper;
+import me.wiefferink.areashop.platform.adapter.BlockBehaviourHelper;
 import me.wiefferink.areashop.regions.BuyRegion;
 import me.wiefferink.areashop.regions.GeneralRegion;
 import me.wiefferink.areashop.regions.RegionFactory;
@@ -36,7 +36,6 @@ import org.bukkit.event.world.ChunkLoadEvent;
 import javax.annotation.Nonnull;
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.HashSet;
 import java.util.List;
 import java.util.Optional;
 import java.util.Set;
@@ -73,8 +72,8 @@ public class SignListener implements Listener {

    @EventHandler(ignoreCancelled = true, priority = EventPriority.MONITOR)
    public void regionUpdate(UpdateRegionEvent event) {
-        Optional<SignsFeature> signsFeature = event.getRegion().getFeature(SignsFeature.class);
-        signsFeature.map(SignsFeature::signManager).ifPresent(SignManager::update);
+        SignsFeature signsFeature = event.getRegion().getSignsFeature();
+        signsFeature.signManager().update();
    }


@@ -64,7 +64,11 @@ public class SignManager extends Manager {
        if (location == null || location.getWorld() == null) {
            return Optional.empty();
        }
-        return getCacheForWorld(location.getWorld()).flatMap(cache -> cache.removeSign(location));
+        return removeSign(new BlockPosition(location));
+    }
+
+    public Optional<RegionSign> removeSign(BlockPosition blockPosition) {
+        return getCacheForWorld(blockPosition.getWorld()).flatMap(cache -> cache.removeSign(blockPosition));
    }

    /**
@@ -73,9 +77,10 @@ public class SignManager extends Manager {
     */
    public boolean update() {
        boolean result = true;
-        for (SignCache signCache : this.signCacheMap.values())
-        for(RegionSign sign : signCache.allSigns()) {
-            result &= sign.update();
+        for (SignCache signCache : this.signCacheMap.values()) {
+            for (RegionSign sign : signCache.allSigns()) {
+                result &= sign.update();
+            }
        }
        return result;
    }
@@ -102,6 +107,7 @@ public class SignManager extends Manager {


    public void shutdown() {
+        update();
        this.signCacheMap.values().forEach(SignCache::clear);
        this.signCacheMap.clear();
    }
@@ -9,7 +9,7 @@ import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.interfaces.WorldGuardInterface;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.managers.SignLinkerManager;
-import me.wiefferink.areashop.nms.BlockBehaviourHelper;
+import me.wiefferink.areashop.platform.adapter.BlockBehaviourHelper;
 import me.wiefferink.areashop.regions.RegionFactory;

 import javax.annotation.Nonnull;
@@ -1,6 +1,8 @@
 package me.wiefferink.areashop.managers;

 import com.google.inject.Injector;
+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.commands.AddCommand;
@@ -43,8 +45,6 @@ import org.bukkit.command.CommandSender;
 import org.bukkit.command.TabCompleter;

 import javax.annotation.Nonnull;
-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.SortedSet;
@@ -2,6 +2,8 @@ package me.wiefferink.areashop.managers;

 import com.google.inject.Injector;
 import com.google.inject.ProvisionException;
+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.features.CommandsFeature;
 import me.wiefferink.areashop.features.DebugFeature;
@@ -14,8 +16,6 @@ import me.wiefferink.areashop.features.signs.SignsFeature;
 import me.wiefferink.areashop.regions.GeneralRegion;

 import javax.annotation.Nonnull;
-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.HashMap;
@@ -1,16 +1,19 @@
 package me.wiefferink.areashop.managers;

-import com.google.common.base.Charsets;
 import com.google.common.io.Files;
 import com.sk89q.worldguard.protection.managers.RegionManager;
 import com.sk89q.worldguard.protection.regions.ProtectedRegion;
 import io.github.bakedlibs.dough.blocks.BlockPosition;
+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.events.ask.AddingRegionEvent;
 import me.wiefferink.areashop.events.ask.DeletingRegionEvent;
 import me.wiefferink.areashop.events.notify.AddedRegionEvent;
 import me.wiefferink.areashop.events.notify.DeletedRegionEvent;
+import me.wiefferink.areashop.features.signs.SignManager;
+import me.wiefferink.areashop.features.signs.SignsFeature;
 import me.wiefferink.areashop.interfaces.WorldGuardInterface;
 import me.wiefferink.areashop.regions.BuyRegion;
 import me.wiefferink.areashop.regions.GeneralRegion;
@@ -32,8 +35,6 @@ import org.bukkit.entity.Player;

 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.FileOutputStream;
@@ -53,6 +54,7 @@ import java.util.List;
 import java.util.Locale;
 import java.util.Map;
 import java.util.Set;
+import java.util.UUID;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;

@@ -78,6 +80,8 @@ public class FileManager extends Manager implements IFileManager {
 	private HashMap<String, Integer> versions = null;
 	private final String versionPath;
 	private final String schemFolder;
+
+	private final SignManager signManager;
 	private final WorldGuardInterface worldGuardInterface;
 	private final MessageBridge messageBridge;
 	private final RegionFactory regionFactory;
@@ -90,12 +94,14 @@ public class FileManager extends Manager implements IFileManager {
 			@Nonnull AreaShop plugin,
 			@Nonnull WorldGuardInterface worldGuardInterface,
 			@Nonnull MessageBridge messageBridge,
-			@Nonnull RegionFactory regionFactory
+			@Nonnull RegionFactory regionFactory,
+			@Nonnull SignManager signManager
 	) {
 		this.plugin = plugin;
 		this.worldGuardInterface = worldGuardInterface;
 		this.messageBridge = messageBridge;
 		this.regionFactory = regionFactory;
+		this.signManager = signManager;
 		regions = new HashMap<>();
 		buys = new HashMap<>();
 		rents = new HashMap<>();
@@ -118,7 +124,11 @@ public class FileManager extends Manager implements IFileManager {
 	public void shutdown() {
 		// Update lastactive time for players that are online now
 		for(GeneralRegion region : this.regions.values()) {
-			Player player = Bukkit.getPlayer(region.getOwner());
+			UUID ownerUuid = region.getOwner();
+			if (ownerUuid == null) {
+				continue;
+			}
+			Player player = Bukkit.getPlayer(ownerUuid);
 			if(player != null) {
 				region.updateLastActiveTime();
 			}
@@ -466,8 +476,11 @@ public class FileManager extends Manager implements IFileManager {

 		// Delete the signs
 		if(region.getWorld() != null) {
-			for(BlockPosition sign : region.getSignsFeature().signManager().allSignLocations()) {
+			SignManager regionSignManager = region.getSignsFeature().signManager();
+			for(BlockPosition sign : regionSignManager.allSignLocations()) {
 				sign.getBlock().setType(Material.AIR);
+				regionSignManager.removeSign(sign);
+				this.signManager.removeSign(sign);
 			}
 		}

@@ -940,7 +953,9 @@ public class FileManager extends Manager implements IFileManager {
 	 */
 	@Override
 	public void loadRegionFiles() {
-		regions.clear();
+		this.regions.clear();
+		this.buys.clear();
+		this.rents.clear();
 		final File file = new File(regionsPath);
 		if(!file.exists()) {
 			if(!file.mkdirs()) {
@@ -96,9 +96,9 @@ public interface IFileManager {
    Collection<RentRegion> getRents();

    /**
-     * Get all rental regions.
+     * Get all rental regions (readonly)
     *
-     * @return List of all rental regions
+     * @return Unmodifiable collection of all rental regions
     */
    Collection<RentRegion> getRentsRef();

@@ -109,6 +109,10 @@ public interface IFileManager {
     */
    List<BuyRegion> getBuys();

+    /**
+     * Get all buy regions (readonly)
+     * @return Unmodifiable collection of all buy regions
+     */
    Collection<BuyRegion> getBuysRef();

    /**
@@ -119,9 +123,9 @@ public interface IFileManager {
    List<GeneralRegion> getRegions();

    /**
-     * Get all regions.
+     * Get all regions (readonly)
     *
-     * @return List of all regions (it is safe to modify the list)
+     * @return Unmodifiable collection of all regions
     */
    Collection<GeneralRegion> getRegionsRef();

@@ -1,5 +1,7 @@
 package me.wiefferink.areashop.managers;

+import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.features.signs.RegionSign;
@@ -23,8 +25,6 @@ import org.bukkit.event.player.PlayerInteractEvent;
 import org.bukkit.event.player.PlayerQuitEvent;
 import org.bukkit.util.BlockIterator;

-import javax.inject.Inject;
-import javax.inject.Singleton;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
@@ -6,6 +6,7 @@ import com.google.inject.assistedinject.FactoryModuleBuilder;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.MessageBridge;
 import me.wiefferink.areashop.features.FeatureFactory;
+import me.wiefferink.areashop.features.signs.SignManager;
 import me.wiefferink.areashop.features.signs.SignsModule;
 import me.wiefferink.areashop.interfaces.WorldEditInterface;
 import me.wiefferink.areashop.interfaces.WorldGuardInterface;
@@ -15,7 +16,7 @@ import me.wiefferink.areashop.managers.FileManager;
 import me.wiefferink.areashop.managers.IFileManager;
 import me.wiefferink.areashop.managers.SignErrorLogger;
 import me.wiefferink.areashop.managers.SignLinkerManager;
-import me.wiefferink.areashop.nms.NMS;
+import me.wiefferink.areashop.platform.adapter.PlatformAdapter;
 import me.wiefferink.areashop.regions.ImportJobFactory;
 import me.wiefferink.areashop.regions.RegionModule;
 import me.wiefferink.areashop.tools.Utils;
@@ -29,14 +30,14 @@ public class AreaShopModule extends AbstractModule {
    private final AreaShop instance;
    private final WorldGuardInterface worldGuardInterface;
    private final WorldEditInterface worldEditInterface;
-    private final NMS nms;
+    private final PlatformAdapter platformAdapter;
    private final MessageBridge messageBridge;
    private final SignErrorLogger signErrorLogger;
    private final AbstractModule[] extras;

    public AreaShopModule(@Nonnull AreaShop instance,
                          @Nonnull MessageBridge messageBridge,
-                          @Nonnull NMS nms,
+                          @Nonnull PlatformAdapter platformAdapter,
                          @Nonnull WorldEditInterface worldEditInterface,
                          @Nonnull WorldGuardInterface worldGuardInterface,
                          @Nonnull SignErrorLogger signErrorLogger,
@@ -44,7 +45,7 @@ public class AreaShopModule extends AbstractModule {
    ) {
        this.instance = instance;
        this.messageBridge = messageBridge;
-        this.nms = nms;
+        this.platformAdapter = platformAdapter;
        this.signErrorLogger = signErrorLogger;
        this.worldEditInterface = worldEditInterface;
        this.worldGuardInterface = worldGuardInterface;
@@ -58,6 +59,7 @@ public class AreaShopModule extends AbstractModule {
        bind(AreaShop.class).toInstance(this.instance);
        bind(MessageBridge.class).toInstance(this.messageBridge);
        bind(WorldGuardInterface.class).toInstance(this.worldGuardInterface);
+        bind(SignManager.class).asEagerSingleton();
        bind(WorldEditInterface.class).toInstance(this.worldEditInterface);
        bind(SignErrorLogger.class).toInstance(this.signErrorLogger);
        // Setup managers
@@ -3,27 +3,27 @@ package me.wiefferink.areashop.modules;
 import com.google.inject.AbstractModule;
 import me.wiefferink.areashop.adapters.platform.MinecraftPlatform;
 import me.wiefferink.areashop.adapters.platform.OfflinePlayerHelper;
-import me.wiefferink.areashop.nms.BlockBehaviourHelper;
-import me.wiefferink.areashop.nms.NMS;
+import me.wiefferink.areashop.platform.adapter.BlockBehaviourHelper;
+import me.wiefferink.areashop.platform.adapter.PlatformAdapter;
 import me.wiefferink.areashop.tools.BukkitSchedulerExecutor;
 import org.jetbrains.annotations.NotNull;

 public class PlatformModule extends AbstractModule {

    private final MinecraftPlatform minecraftPlatform;
-    private final NMS nms;
+    private final PlatformAdapter platformAdapter;

    public PlatformModule(@NotNull MinecraftPlatform platform,
-                          @NotNull NMS nms) {
+                          @NotNull PlatformAdapter platformAdapter) {
        this.minecraftPlatform = platform;
-        this.nms = nms;
+        this.platformAdapter = platformAdapter;
    }
    @Override
    protected void configure() {
        bind(MinecraftPlatform.class).toInstance(this.minecraftPlatform);
        bind(OfflinePlayerHelper.class).toInstance(this.minecraftPlatform.offlinePlayerHelper());
-        bind(NMS.class).toInstance(this.nms);
-        bind(BlockBehaviourHelper.class).toInstance(this.nms.blockBehaviourHelper());
+        bind(PlatformAdapter.class).toInstance(this.platformAdapter);
+        bind(BlockBehaviourHelper.class).toInstance(this.platformAdapter.blockBehaviourHelper());
        bind(BukkitSchedulerExecutor.class).asEagerSingleton();
    }
 }
@@ -58,6 +58,21 @@ public class BuyRegion extends GeneralRegion {
 		this.economy = economy;
 	}

+	@Override
+	public boolean isOwner(UUID player) {
+		return isBuyer(player);
+	}
+
+	@Override
+	public UUID getOwner() {
+		return getBuyer();
+	}
+
+	@Override
+	public void setOwner(UUID player) {
+		setBuyer(player);
+	}
+
 	@Override
 	public RegionType getType() {
 		return RegionType.BUY;
@@ -393,8 +408,6 @@ public class BuyRegion extends GeneralRegion {
 			if(r == null || !r.transactionSuccess()) {
 				AreaShop.warn("Something went wrong with paying '" + oldOwnerName + "' " + getFormattedPrice() + " for his resell of region " + getName() + " to " + offlinePlayer.getName());
 			}
-			// Resell is done, disable that now
-			disableReselling();

 			// Set the owner
 			setBuyer(offlinePlayer.getUniqueId());
@@ -406,6 +419,9 @@ public class BuyRegion extends GeneralRegion {
 			// Notify about updates
 			this.notifyAndUpdate(new ResoldRegionEvent(this, oldOwner));

+			// Resell is done, disable that now
+			disableReselling();
+			
 			// Send message to the player
 			message(offlinePlayer, "buy-successResale", oldOwnerName);
 			Player seller = Bukkit.getPlayer(oldOwner);
@@ -43,6 +43,7 @@ import java.util.HashSet;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
 import java.util.UUID;
@@ -435,33 +436,18 @@ public abstract class GeneralRegion implements GeneralRegionInterface, Comparabl
 	 * @param player Player to check ownership for
 	 * @return true if the player currently rents or buys this region
 	 */
-	public boolean isOwner(UUID player) {
-		return (this instanceof RentRegion && ((RentRegion)this).isRenter(player)) || (this instanceof BuyRegion && ((BuyRegion)this).isBuyer(player));
-	}
+	public abstract boolean isOwner(UUID player);

 	/**
 	 * Get the player that is currently the owner of this region (either bought or rented it).
 	 * @return The UUID of the owner of this region
 	 */
-	public UUID getOwner() {
-		if(this instanceof RentRegion) {
-			return ((RentRegion)this).getRenter();
-		} else {
-			return ((BuyRegion)this).getBuyer();
-		}
-	}
-
+	public abstract UUID getOwner();
 	/**
 	 * Change the owner of the region.
 	 * @param player The player that should be the owner
 	 */
-	public void setOwner(UUID player) {
-		if(this instanceof RentRegion) {
-			((RentRegion)this).setRenter(player);
-		} else {
-			((BuyRegion)this).setBuyer(player);
-		}
-	}
+	public abstract void setOwner(UUID player);

 	/**
 	 * Get the landlord of this region (the player that receives any revenue from this region).
@@ -532,7 +518,8 @@ public abstract class GeneralRegion implements GeneralRegionInterface, Comparabl
 	 * @return true if the player is the landlord, otherwise false
 	 */
 	public boolean isLandlord(UUID landlord) {
-		return landlord != null && getLandlord() != null && getLandlord().equals(landlord);
+		UUID ourLandlord = getLandlord();
+		return Objects.equals(landlord, ourLandlord);
 	}

 	/**
@@ -72,6 +72,22 @@ public class RentRegion extends GeneralRegion {
 		this.economy = economy;
 	}

+
+	@Override
+	public boolean isOwner(UUID player) {
+		return isRenter(player);
+	}
+
+	@Override
+	public UUID getOwner() {
+		return getRenter();
+	}
+
+	@Override
+	public void setOwner(UUID player) {
+		setRenter(player);
+	}
+
 	@Override
 	public RegionType getType() {
 		return RegionType.RENT;
@@ -1,11 +1,11 @@
 package me.wiefferink.areashop.tools;


+import jakarta.inject.Inject;
 import org.bukkit.plugin.Plugin;
 import org.bukkit.scheduler.BukkitScheduler;
 import org.jetbrains.annotations.NotNull;

-import javax.inject.Inject;
 import java.util.concurrent.Executor;

 public class BukkitSchedulerExecutor implements Executor {
@@ -20,7 +20,7 @@ public class GithubUpdateCheck {

 	public static final String API_HOST = "https://api.github.com/repos";
 	public static final String API_LATEST_RELEASE = "releases/latest";
-	public static final String USER_AGENT = "GithubUpdateCheck by NLThijs48";
+	public static final String USER_AGENT = "md5sha256 AreaShop GithubUpdateCheck";
 	public static final boolean DEBUG = false;

 	private final String author;
@@ -2,6 +2,7 @@ package me.wiefferink.areashop.tools;

 import com.sk89q.worldguard.protection.managers.RegionManager;
 import com.sk89q.worldguard.protection.regions.ProtectedRegion;
+import jakarta.inject.Inject;
 import me.wiefferink.areashop.AreaShop;
 import me.wiefferink.areashop.interfaces.WorldEditSelection;
 import me.wiefferink.areashop.interfaces.WorldGuardInterface;
@@ -23,7 +24,6 @@ import org.bukkit.configuration.file.YamlConfiguration;
 import org.bukkit.entity.Player;
 import org.bukkit.util.Vector;

-import javax.inject.Inject;
 import java.lang.reflect.Method;
 import java.math.BigDecimal;
 import java.math.RoundingMode;
@@ -0,0 +1,40 @@
+package me.wiefferink.areashop.tools.version;
+
+import javax.annotation.Nullable;
+import java.util.Locale;
+
+public enum PreReleaseType {
+
+    UNKNOWN("unknown"),
+
+    ALPHA("alpha"),
+    BETA("beta"),
+    SNAPSHOT("snapshot"),
+    RELEASE_CANDIDATE("rc");
+
+    private static final PreReleaseType[] VALUES = values();
+
+    private final String asString;
+
+    PreReleaseType(String asString) {
+        this.asString = asString;
+    }
+
+    @Nullable
+    public static PreReleaseType parse(String release) {
+        if (release.isEmpty()) {
+            return null;
+        }
+        String sanitized = release.toLowerCase(Locale.ENGLISH);
+        for (PreReleaseType preReleaseType : VALUES) {
+            if (preReleaseType.asString.equals(sanitized)) {
+                return preReleaseType;
+            }
+        }
+        return UNKNOWN;
+    }
+
+    public String asString() {
+        return this.asString;
+    }
+}
@@ -0,0 +1,54 @@
+package me.wiefferink.areashop.tools.version;
+
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+public record Version(String original, VersionData versionData) {
+
+    /**
+     * Semver pattern, cg1 = major, cg2 = minor, cg3 = patch, cg4 = prerelease and cg5 = buildmetadata
+     * Taken from https://semver.org/ and https://regex101.com/r/vkijKf/1/
+     */
+    public static final Pattern SEMVER_PATTERN = Pattern.compile(
+            "^(0|[1-9]\\d*)\\.(0|[1-9]\\d*)\\.(0|[1-9]\\d*)(?:-((?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\\.(?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\\+([0-9a-zA-Z-]+(?:\\.[0-9a-zA-Z-]+)*))?$");
+
+
+    public static Version parse(String version) {
+        Matcher matcher = SEMVER_PATTERN.matcher(version);
+        if (!matcher.find()) {
+            throw new IllegalArgumentException("Invalid version: " + version);
+        }
+        String majorRaw = matcher.group(1);
+        String minorRaw = matcher.group(2);
+        String patchRaw = matcher.group(3);
+        String preReleaseRaw = matcher.group(4);
+        int major;
+        int minor;
+        try {
+            major = Integer.parseInt(majorRaw);
+            minor = Integer.parseInt(minorRaw);
+        } catch (NumberFormatException ex) {
+            throw new IllegalArgumentException("Invalid version: " + version);
+        }
+        if (patchRaw == null || patchRaw.isEmpty()) {
+            return new Version(version, new VersionData(major, minor, 0, null));
+        }
+        int patch;
+        try {
+            patch = Integer.parseInt(patchRaw);
+        } catch (NumberFormatException ex) {
+            throw new IllegalArgumentException("Invalid version: " + version);
+        }
+        if (preReleaseRaw == null || preReleaseRaw.isEmpty()) {
+            return new Version(version, new VersionData(major, minor, patch, null));
+        }
+        PreReleaseType releaseType = PreReleaseType.parse(preReleaseRaw);
+        return new Version(version, new VersionData(major, minor, patch, releaseType));
+    }
+
+    @Override
+    public String toString() {
+        return this.original;
+    }
+
+}
@@ -0,0 +1,54 @@
+package me.wiefferink.areashop.tools.version;
+
+import org.jetbrains.annotations.NotNull;
+
+public record VersionData(int major, int minor, int patch, PreReleaseType preReleaseType)
+        implements Comparable<VersionData> {
+
+
+    public VersionData(int major, int minor, int patch) {
+        this(major, minor, patch, null);
+    }
+
+    public VersionData(int major, int minor) {
+        this(major, minor, 0);
+    }
+
+    @Override
+    public String toString() {
+        return String.format("%d.%d.%d", major, minor, patch);
+    }
+
+    public boolean isNewerThan(VersionData other) {
+        return compareTo(other) > 0;
+    }
+
+    public boolean isOlderThan(VersionData other) {
+        return compareTo(other) < 0;
+    }
+
+
+    @Override
+    public int compareTo(@NotNull VersionData o) {
+        int majorComp = Integer.compare(this.major, o.major);
+        if (majorComp != 0) {
+            return majorComp;
+        }
+        int minorComp = Integer.compare(this.minor, o.minor);
+        if (minorComp != 0) {
+            return minorComp;
+        }
+        int patchComp = Integer.compare(this.patch, o.patch);
+        if (patchComp != 0) {
+            return patchComp;
+        }
+        if (this.preReleaseType == null && o.preReleaseType == null) {
+            return 0;
+        }
+        if (this.preReleaseType == null) {
+            return 1;
+        }
+        return this.preReleaseType.compareTo(o.preReleaseType);
+    }
+}
+
@@ -0,0 +1,22 @@
+package me.wiefferink.areashop.tools.version;
+
+public class VersionUtil {
+
+    public static VersionData MC_1_17_1 = new VersionData(1, 17, 1);
+
+    public static Version parseMinecraftVersion(String minecraftVersion) {
+        // Expecting 1.X.X-R0.1-SNAPSHOT
+        int stripLength = "-R0.1-SNAPSHOT".length();
+        int length = minecraftVersion.length();
+        if (length <= stripLength) {
+            throw new IllegalArgumentException("Invalid minecraft version: " + minecraftVersion);
+        }
+        String strippedVersion = minecraftVersion.substring(0, length - stripLength);
+        try {
+            return Version.parse(strippedVersion);
+        } catch (IllegalArgumentException ex) {
+            throw new IllegalArgumentException("Invalid minecraft version: " + minecraftVersion, ex);
+        }
+    }
+
+}
@@ -1,4 +1,6 @@
 ![AreaShop logo](https://cloud.githubusercontent.com/assets/6951068/9471294/f016d8ee-4b4f-11e5-9bda-d61b1c423ebb.png)<br/>
+[![](https://jitpack.io/v/md5sha256/AreaShop.svg)](https://jitpack.io/#md5sha256/AreaShop)
+<br>
 **Usage and configuration:**
 [►Download (releases)](https://github.com/md5sha256/AreasShop/releases)&nbsp;&nbsp;
 [►Commands and Permissions](https://github.com/NLthijs48/AreaShop/wiki/Commands-and-Permissions)
@@ -1,6 +1,6 @@
-package me.wiefferink.areashop.adapters.platform.v1_17_R1;
+package me.wiefferink.areashop.adapters.platform.legacy;

-import me.wiefferink.areashop.nms.BlockBehaviourHelper;
+import me.wiefferink.areashop.platform.adapter.BlockBehaviourHelper;
 import net.minecraft.core.BlockPos;
 import net.minecraft.server.level.ServerLevel;
 import net.minecraft.world.level.block.state.BlockState;
@@ -0,0 +1,15 @@
+package me.wiefferink.areashop.adapters.platform.legacy;
+
+import me.wiefferink.areashop.platform.adapter.BlockBehaviourHelper;
+import me.wiefferink.areashop.platform.adapter.PlatformAdapter;
+
+public class LegacyPlatformAdapter implements PlatformAdapter {
+
+    private final BlockBehaviourImpl blockBehaviourHelper = new BlockBehaviourImpl();
+
+    @Override
+    public BlockBehaviourHelper blockBehaviourHelper() {
+        return this.blockBehaviourHelper;
+    }
+
+}
@@ -1,15 +0,0 @@
-package me.wiefferink.areashop.adapters.platform.v1_17_R1;
-
-import me.wiefferink.areashop.nms.BlockBehaviourHelper;
-import me.wiefferink.areashop.nms.NMS;
-
-public class NMSImpl implements NMS {
-
-    private final BlockBehaviourImpl blockBehaviourHelper = new BlockBehaviourImpl();
-
-    @Override
-    public BlockBehaviourHelper blockBehaviourHelper() {
-        return this.blockBehaviourHelper;
-    }
-
-}
@@ -1,21 +0,0 @@
-plugins.apply("io.papermc.paperweight.userdev")
-
-dependencies {
-    paperDevBundle("1.18.2-R0.1-SNAPSHOT")
-    compileOnly(projects.areashopInterface)
-    compileOnly(projects.areashopNms)
-}
-
-description = "AreaShop NMS Helper 1-18"
-
-tasks {
-
-    assemble {
-        dependsOn("reobfJar")
-    }
-
-    named("reobfJar", io.papermc.paperweight.tasks.RemapJar::class) {
-        outputJar.set(file("build/libs/${project.name}-${project.version}.jar"))
-    }
-
-}
@@ -1,46 +0,0 @@
-package me.wiefferink.areashop.adapters.platform.v1_18_R2;
-
-import me.wiefferink.areashop.nms.BlockBehaviourHelper;
-import net.minecraft.core.BlockPos;
-import net.minecraft.server.level.ServerLevel;
-import net.minecraft.world.level.block.state.BlockState;
-import org.bukkit.Location;
-import org.bukkit.block.Block;
-import org.bukkit.block.data.BlockData;
-import org.bukkit.craftbukkit.v1_18_R2.CraftWorld;
-import org.bukkit.craftbukkit.v1_18_R2.block.CraftBlock;
-import org.bukkit.craftbukkit.v1_18_R2.block.CraftBlockState;
-import org.bukkit.craftbukkit.v1_18_R2.block.data.CraftBlockData;
-
-import java.util.Objects;
-
-public class BlockBehaviourImpl implements BlockBehaviourHelper {
-
-    @Override
-    public boolean canPlace(Location location, BlockData blockData) {
-        Objects.requireNonNull(location.getWorld(), "Null World!");
-        final BlockPos blockPosition = new BlockPos(location.getX(), location.getY(), location.getZ());
-        final CraftWorld craftWorld = (CraftWorld) location.getWorld();
-        final ServerLevel world = craftWorld.getHandle();
-        final CraftBlockData craftBlockData = (CraftBlockData) blockData;
-        final BlockState ibd = craftBlockData.getState();
-        return ibd.canSurvive(world, blockPosition);
-    }
-
-    @Override
-    public boolean isBlockValid(Block block) {
-        final CraftBlock craftBlock = (CraftBlock) block;
-        final CraftWorld craftWorld = (CraftWorld) craftBlock.getWorld();
-        final ServerLevel world = craftWorld.getHandle();
-        final BlockState ibd = craftBlock.getNMS();
-        return ibd.canSurvive(world, craftBlock.getPosition());
-    }
-
-    @Override
-    public boolean isBlockStateValid(org.bukkit.block.BlockState blockState) {
-        final CraftBlockState craftBlockState = (CraftBlockState) blockState;
-        final BlockState ibd = craftBlockState.getHandle();
-        return ibd.canSurvive(craftBlockState.getBlock().getCraftWorld().getHandle(), craftBlockState.getPosition());
-    }
-
-}
@@ -1,15 +0,0 @@
-package me.wiefferink.areashop.adapters.platform.v1_18_R2;
-
-import me.wiefferink.areashop.nms.BlockBehaviourHelper;
-import me.wiefferink.areashop.nms.NMS;
-
-public class NMSImpl implements NMS {
-
-    private final BlockBehaviourImpl blockBehaviourHelper = new BlockBehaviourImpl();
-
-    @Override
-    public BlockBehaviourHelper blockBehaviourHelper() {
-        return this.blockBehaviourHelper;
-    }
-
-}
@@ -1,21 +0,0 @@
-plugins.apply("io.papermc.paperweight.userdev")
-
-dependencies {
-    paperDevBundle("1.19.2-R0.1-SNAPSHOT")
-    compileOnly(projects.areashopInterface)
-    compileOnly(projects.areashopNms)
-}
-
-description = "AreaShop NMS Helper 1-19"
-
-tasks {
-
-    assemble {
-        dependsOn("reobfJar")
-    }
-
-    named("reobfJar", io.papermc.paperweight.tasks.RemapJar::class) {
-        outputJar.set(file("build/libs/${project.name}-${project.version}.jar"))
-    }
-
-}
@@ -1,46 +0,0 @@
-package me.wiefferink.areashop.adapters.platform.v1_19_R1;
-
-import me.wiefferink.areashop.nms.BlockBehaviourHelper;
-import net.minecraft.core.BlockPos;
-import net.minecraft.server.level.ServerLevel;
-import net.minecraft.world.level.block.state.BlockState;
-import org.bukkit.Location;
-import org.bukkit.block.Block;
-import org.bukkit.block.data.BlockData;
-import org.bukkit.craftbukkit.v1_19_R1.CraftWorld;
-import org.bukkit.craftbukkit.v1_19_R1.block.CraftBlock;
-import org.bukkit.craftbukkit.v1_19_R1.block.CraftBlockState;
-import org.bukkit.craftbukkit.v1_19_R1.block.data.CraftBlockData;
-
-import java.util.Objects;
-
-public class BlockBehaviourImpl implements BlockBehaviourHelper {
-
-    @Override
-    public boolean canPlace(Location location, BlockData blockData) {
-        Objects.requireNonNull(location.getWorld(), "Null World!");
-        final BlockPos blockPosition = new BlockPos(location.getX(), location.getY(), location.getZ());
-        final CraftWorld craftWorld = (CraftWorld) location.getWorld();
-        final ServerLevel world = craftWorld.getHandle();
-        final CraftBlockData craftBlockData = (CraftBlockData) blockData;
-        final BlockState ibd = craftBlockData.getState();
-        return ibd.canSurvive(world, blockPosition);
-    }
-
-    @Override
-    public boolean isBlockValid(Block block) {
-        final CraftBlock craftBlock = (CraftBlock) block;
-        final CraftWorld craftWorld = (CraftWorld) craftBlock.getWorld();
-        final ServerLevel world = craftWorld.getHandle();
-        final BlockState ibd = craftBlock.getNMS();
-        return ibd.canSurvive(world, craftBlock.getPosition());
-    }
-
-    @Override
-    public boolean isBlockStateValid(org.bukkit.block.BlockState blockState) {
-        final CraftBlockState craftBlockState = (CraftBlockState) blockState;
-        final BlockState ibd = craftBlockState.getHandle();
-        return ibd.canSurvive(craftBlockState.getBlock().getCraftWorld().getHandle(), craftBlockState.getPosition());
-    }
-
-}
@@ -1,15 +0,0 @@
-package me.wiefferink.areashop.adapters.platform.v1_19_R1;
-
-import me.wiefferink.areashop.nms.BlockBehaviourHelper;
-import me.wiefferink.areashop.nms.NMS;
-
-public class NMSImpl implements NMS {
-
-    private final BlockBehaviourImpl blockBehaviourHelper = new BlockBehaviourImpl();
-
-    @Override
-    public BlockBehaviourHelper blockBehaviourHelper() {
-        return this.blockBehaviourHelper;
-    }
-
-}
@@ -0,0 +1,11 @@
+dependencies {
+    compileOnly("io.papermc.paper:paper-api:1.18.2-R0.1-SNAPSHOT")
+    compileOnly(projects.areashopInterface)
+    compileOnly(projects.areashopNms)
+}
+
+description = "AreaShop NMS Helper 1-18"
+
+tasks {
+
+}
@@ -0,0 +1,28 @@
+package me.wiefferink.areashop.adapters.platform.modern;
+
+import me.wiefferink.areashop.platform.adapter.BlockBehaviourHelper;
+import org.bukkit.Location;
+import org.bukkit.block.Block;
+import org.bukkit.block.BlockState;
+import org.bukkit.block.data.BlockData;
+
+import java.util.Objects;
+
+public class BlockBehaviourImpl implements BlockBehaviourHelper {
+
+    @Override
+    public boolean canPlace(Location location, BlockData blockData) {
+        Objects.requireNonNull(location.getWorld(), "Null World!");
+        return location.getBlock().canPlace(blockData);
+    }
+
+    @Override
+    public boolean isBlockValid(Block block) {
+        return block.canPlace(block.getBlockData());
+    }
+
+    @Override
+    public boolean isBlockStateValid(BlockState blockState) {
+        return blockState.getBlock().canPlace(blockState.getBlockData());
+    }
+}
@@ -0,0 +1,15 @@
+package me.wiefferink.areashop.adapters.platform.modern;
+
+import me.wiefferink.areashop.platform.adapter.BlockBehaviourHelper;
+import me.wiefferink.areashop.platform.adapter.PlatformAdapter;
+
+public class ModernPlatformAdapter implements PlatformAdapter {
+
+    private final BlockBehaviourImpl blockBehaviourHelper = new BlockBehaviourImpl();
+
+    @Override
+    public BlockBehaviourHelper blockBehaviourHelper() {
+        return this.blockBehaviourHelper;
+    }
+
+}
@@ -34,7 +34,11 @@ public class PaperOfflinePlayerHelper implements OfflinePlayerHelper {
    @Override
    public CompletableFuture<OfflinePlayer> lookupOfflinePlayerAsync(String username) {
        final CompletableFuture<OfflinePlayer> future = new CompletableFuture<>();
-        this.server.getScheduler().runTaskAsynchronously(this.plugin, () -> future.complete(plugin.getServer().getPlayer(username)));
+        this.server.getScheduler().runTaskAsynchronously(this.plugin, () -> {
+            @SuppressWarnings("deprecation")
+            OfflinePlayer offlinePlayer = plugin.getServer().getOfflinePlayer(username);
+            future.complete(offlinePlayer);
+        });
        return future;
    }
 }
@@ -1,7 +0,0 @@
-package me.wiefferink.areashop.nms;
-
-public interface NMS {
-
-    BlockBehaviourHelper blockBehaviourHelper();
-
-}
@@ -1,4 +1,4 @@
-package me.wiefferink.areashop.nms;
+package me.wiefferink.areashop.platform.adapter;

 import org.bukkit.Location;
 import org.bukkit.block.Block;
@@ -0,0 +1,7 @@
+package me.wiefferink.areashop.platform.adapter;
+
+public interface PlatformAdapter {
+
+    BlockBehaviourHelper blockBehaviourHelper();
+
+}
@@ -1,14 +1,20 @@
+import com.github.spotbugs.snom.Effort
+import com.github.spotbugs.snom.SpotBugsPlugin
+
 plugins {
    java
    `java-library`
    `maven-publish`
-    id("io.papermc.paperweight.userdev") version "1.3.6" apply false
+    id("io.papermc.paperweight.userdev") version "1.5.5" apply false
+    id("com.github.spotbugs") version "5.1.3"
    idea
    eclipse
 }

 group = "me.wiefferink"
-version = "2.7.9"
+version = "2.7.15"
+
+java.toolchain.languageVersion.set(JavaLanguageVersion.of(17))

 subprojects {

@@ -23,8 +29,9 @@ subprojects {
        }
        plugin<IdeaPlugin>()
        plugin<EclipsePlugin>()
+        // plugin<SpotBugsPlugin>()
    }
-
+    
    repositories {
        mavenCentral()
        maven("https://oss.sonatype.org/content/groups/public/")
@@ -41,9 +48,10 @@ subprojects {
        maven("https://maven.enginehub.org/repo/")
    }

+    java.toolchain.languageVersion.set(JavaLanguageVersion.of(17))
+
    tasks {
        withType(JavaCompile::class) {
-            java.toolchain.languageVersion.set(JavaLanguageVersion.of(17))
            options.release.set(17)
            options.encoding = Charsets.UTF_8.name()
            options.isFork = true
@@ -1,21 +1,16 @@
 [versions]
 # Platforms
 minecraft = "1.17.1-R0.1-SNAPSHOT"
-findbugs = "3.0.2"

 # Minecraft Plugins
-worldedit = "7.2.12"
-worldguard = "7.0.7"
-fawe = "2.4.5"
-
-# Gradle plugins
-paperweight = "1.3.7"
+worldedit = "7.2.15"
+worldguard = "7.0.9"
+fawe = "2.7.1"

 [libraries]
 # Platform
 spigot = { group = "org.spigotmc", name = "spigot-api", version.ref = "minecraft" }
 paper = { group = "io.papermc.paper", name = "paper-api", version.ref = "minecraft" }
-findbugs = { group = "com.google.code.findbugs", name = "jsr305", version.ref = "findbugs" }

 # Minecraft Plugins
 worldeditBukkit = { group = "com.sk89q.worldedit", name = "worldedit-bukkit", version.ref = "worldedit" }
@@ -24,7 +19,3 @@ worldguardBukkit = { group = "com.sk89q.worldguard", name = "worldguard-bukkit",
 worldguardCore = { group = "com.sk89q.worldguard", name = "worldguard-core", version.ref = "worldguard" }
 fastasyncworldeditBukkit = { group = "com.fastasyncworldedit", name = "FastAsyncWorldEdit-Bukkit", version.ref = "fawe" }
 fastasyncworldeditCore = { group = "com.fastasyncworldedit", name = "FastAsyncWorldEdit-Core", version.ref = "fawe" }
-
-[plugins]
-# Gradle plugins
-paperweightUserdev = { id = "io.papermc.paperweight.userdev", version.ref = "paperweight" }
@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
@@ -205,6 +205,12 @@ set -- \
        org.gradle.wrapper.GradleWrapperMain \
        "$@"

+# Stop when "xargs" is not available.
+if ! command -v xargs >/dev/null 2>&1
+then
+    die "xargs is not available"
+fi
+
 # Use "xargs" to parse quoted args.
 #
 # With -n1 it outputs one arg per line, with the quotes and backslashes removed.
@@ -14,7 +14,7 @@
@rem limitations under the License.
@rem

-@if "%DEBUG%" == "" @echo off
+@if "%DEBUG%"=="" @echo off
@rem ##########################################################################
@rem
@rem  Gradle startup script for Windows
@@ -25,7 +25,7 @@
 if "%OS%"=="Windows_NT" setlocal

 set DIRNAME=%~dp0
-if "%DIRNAME%" == "" set DIRNAME=.
+if "%DIRNAME%"=="" set DIRNAME=.
 set APP_BASE_NAME=%~n0
 set APP_HOME=%DIRNAME%

@@ -40,7 +40,7 @@ if defined JAVA_HOME goto findJavaFromJavaHome

 set JAVA_EXE=java.exe
 %JAVA_EXE% -version >NUL 2>&1
-if "%ERRORLEVEL%" == "0" goto execute
+if %ERRORLEVEL% equ 0 goto execute

 echo.
 echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
@@ -75,13 +75,15 @@ set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar

 :end
@rem End local scope for the variables with windows NT shell
-if "%ERRORLEVEL%"=="0" goto mainEnd
+if %ERRORLEVEL% equ 0 goto mainEnd

 :fail
 rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of
 rem the _cmd.exe /c_ return code!
-if  not "" == "%GRADLE_EXIT_CONSOLE%" exit 1
-exit /b 1
+set EXIT_CODE=%ERRORLEVEL%
+if %EXIT_CODE% equ 0 set EXIT_CODE=1
+if not ""=="%GRADLE_EXIT_CONSOLE%" exit %EXIT_CODE%
+exit /b %EXIT_CODE%

 :mainEnd
 if "%OS%"=="Windows_NT" endlocal
@@ -0,0 +1,5 @@
+before_install:
+  - sdk install java 17.0.8-amzn
+  - sdk use java 17.0.8-amzn
+install:
+  - ./gradlew build publishToMavenLocal
@@ -1,10 +1,6 @@
 pluginManagement {
    repositories {
        gradlePluginPortal()
-        maven {
-            name = "paper-repo"
-            url = uri("https://papermc.io/repo/repository/maven-public/")
-        }
    }
 }

@@ -22,15 +18,20 @@ include(":areashop-interface")
 include(":areashop-nms")

 // Adapters
-include(":adapters:platform:bukkit-1-17")
-include(":adapters:platform:bukkit-1-18")
-include(":adapters:platform:bukkit-1-19")
 include(":adapters:platform:paper")
 include(":adapters:platform:platform-interface")
+
 include(":adapters:plugins:worldedit")
 include(":adapters:plugins:worldguard")
 include(":adapters:plugins:fastasyncworldedit")

+if (!providers.environmentVariable("JITPACK").isPresent) {
+    include(":adapters:platform:bukkit-1-17")
+}
+
+include(":adapters:platform:bukkit-modern")
+
+
 // Main project
 include(":areashop")
Author	SHA1	Message	Date
Andrew Wong	61828d3cfd	Release 2.7.15	2023-11-24 21:38:48 +11:00
Andrew Wong	54241d5ce3	Replace the warning of null owner on shutdown with null checks of the owner uuid	2023-11-15 13:06:22 +11:00
Andrew Wong	d048665530	Cache the landlord instead of parsing it twice in GeneralRegion#isLandLord	2023-11-15 13:01:34 +11:00
Andrew Wong	23de68431c	Replace Random instantiations with ThreadLocalRandom in FindCommand	2023-11-15 12:40:17 +11:00
Andrew Wong	95b4543f19	Fix null pointer when comparing null pre release types in VersionData	2023-11-14 03:46:28 +11:00
Andrew Wong	d058bb7271	Refactor platform adapters to legacy (1.17.1) and modern (1.18+). Add semver parsing utilities. Fix bug with github updater treating snapshot versions as newer	2023-11-13 22:30:34 +11:00
Andrew Wong	63d26be369	2.7.15-SNAPSHOT	2023-11-13 21:06:58 +11:00
Andrew Wong	1020388aae	Release 2.7.14	2023-11-12 18:04:01 +11:00
Andrew Wong	e56107ffd6	Fix signs not being deleted from the global sign cache in memory	2023-11-12 17:59:34 +11:00
Andrew Wong	06fceb4643	Drop support for 1.20 and 1.20.1	2023-11-12 15:50:51 +11:00
Andrew Wong	e2077c3b32	Fix region signs losing their interactivity after restart. Resolves #20	2023-11-12 15:40:03 +11:00
Andrew Wong	fcb64c2ddb	Merge pull request #22 from o0sh4d0w0o/ResoldRegionEvent-resellprice-fix Fixed getResellPrice unsetted when ResoldRegionEvent is notified	2023-10-04 21:35:03 +11:00
o0sh4d0w0o	cc51109720	Fixed getResellPrice unsetted when ResoldRegionEvent is notified	2023-10-01 16:03:07 +02:00
Andrew Wong	0b48f4dd2e	Fix not including 1.20.2 adapter	2023-09-25 11:37:12 +10:00
Andrew Wong	4d7f00b0ce	Add support for 1.20.2	2023-09-25 11:33:02 +10:00
Andrew Wong	b27ea83982	Include 1.18-1.20 adapters for jitpack	2023-09-03 08:47:21 +10:00
Andrew Wong	66da717a77	Fix relocations	2023-09-03 08:47:19 +10:00
Andrew Wong	7f779d2df8	Bump version to 2.7.14-SNAPSHOT	2023-09-03 08:47:16 +10:00
Andrew Wong	ed3bd01f2a	Fix bad release url Fixes #19	2023-09-03 07:22:58 +10:00
Andrew Wong	ef03501d1c	2.7.13 release	2023-08-30 22:09:28 +10:00
Andrew Wong	feb35cfd37	User api for BlockBehaviourImpl 1.18 onwards	2023-08-30 22:08:50 +10:00
Andrew Wong	b6a8dcc24c	Fix module desc for paper 1.20	2023-08-30 20:23:05 +10:00
Andrew Wong	5619612a6e	Update gradle wrapper	2023-08-28 23:10:54 +10:00
Andrew Wong	26ac52cc0a	Include plugin adapters in jitpack build	2023-08-28 22:46:14 +10:00
Andrew Wong	5f6bd55afe	Don't include nms impls if on jitpack	2023-08-28 22:34:28 +10:00
Andrew Wong	aba2e12c5d	Don't include nms impls if on jitpack	2023-08-28 22:26:28 +10:00
Andrew Wong	2906de11de	Fix merge conflicts	2023-08-28 22:17:42 +10:00
Andrew Wong	436672f85b	Don't shadowJar and don't include nms providers if building on jitpack	2023-08-28 22:12:09 +10:00
Andrew Wong	5ba8ed7ad8	Add spotbugs	2023-08-28 20:57:17 +10:00
Andrew Wong	00d97f1beb	Update dependencies	2023-08-28 20:36:52 +10:00
Andrew Wong	f530fa40af	Fix signs not being saved on server stop	2023-08-28 20:14:12 +10:00
Andrew Wong	a804df2257	Add jitpack logo	2023-08-09 14:08:12 +10:00
Andrew Wong	c96e0b464e	More jitpack tests	2023-08-09 13:58:44 +10:00
Andrew Wong	13e52aa4f1	More jitpack tests	2023-08-09 13:55:52 +10:00
Andrew Wong	9aeb531d16	More jitpack tests	2023-08-09 13:52:23 +10:00
Andrew Wong	44f83473d1	Add jitpack.yml	2023-08-09 13:46:05 +10:00
Andrew Wong	d7260998f5	Update Guice to 7.0.0 and use JakartaEE annotations	2023-06-12 00:59:16 +10:00
Andrew Wong	638382eacf	Snapshot 2.7.13	2023-06-12 00:58:34 +10:00
Andrew Wong	e18fe99161	Release 2.7.12	2023-06-12 00:40:46 +10:00
Andrew Wong	bdc9e32c13	Add support for 1.20	2023-06-12 00:40:08 +10:00
Andrew Wong	9a46d5ae3b	Bump version to 2.7.12-SNAPSHOT	2023-03-29 16:14:26 +11:00
Andrew Wong	6795fc43d9	Release 2.7.11	2023-03-29 16:13:54 +11:00
Andrew Wong	dd9bd2c434	Drop support for 1.19.3 and add support for 1.19.4	2023-03-29 16:13:23 +11:00
Andrew Wong	9438166180	Prepare for development 2.7.11	2023-02-27 21:58:41 +11:00
Andrew Wong	9e06b9f268	Release 2.7.10	2023-02-27 21:58:14 +11:00
Andrew Wong	4562bf23f6	Update libs	2023-02-27 21:57:49 +11:00
Andrew Wong	24edb01754	Refactor GeneralRegion#getOwner, #isOwner and #setOwner	2023-02-27 21:46:59 +11:00
Andrew Wong	2739bf6ad4	Fix javadocs for IFileManager	2023-02-27 21:41:28 +11:00
Andrew Wong	2ce84186ab	Use Server#getOfflinePlayer in PlayerOfflinePlayerHelper	2023-02-27 21:39:48 +11:00
Andrew Wong	279fa001ea	Only support 1.19.3	2023-02-27 11:56:41 +11:00
Andrew Wong	b56d5320a6	Add support for 1.19.3	2022-12-15 16:25:06 +08:00
Andrew Wong	30665908b9	Bump to 2.7.10-SNAPSHOT	2022-12-09 16:53:03 +08:00