Update version number to 6.8.1

VotingPlugin/Resources/Config.yml

@@ -443,6 +443,9 @@ UsePrimaryAccountForPlaceholders: false
 # Only affects placeholderapi placeholders
 AlwaysWaitForCachePlaceholders: false
 
+# Enable auto caching placeholders
+AutoCachePlaceholders: true
+
 # Set which placeholders to cache at all times
 # Use for placeholders to are pulled constantly or on the main thread
 # Mainly aimed for scoreboards

VotingPlugin/Resources/VoteSites.yml

@@ -26,7 +26,7 @@ VoteSites:
     ServiceSite: 'PlanetMinecraft.com'
 
     # vote url for /vote
-    # Format for this can be set in Format.yml
+    # Format for this can be set in Config.yml
     # Do not include colors here
     # If you need to force a url set the url as this:
     # VoteURL: '[Text="ANY TEXT TO CLICK ON HERE",url="URLHERE"]'
@@ -62,7 +62,7 @@ VoteSites:
       Amount: 1
 
     # Rewards to give
-    # https://github.com/Ben12345rocks/AdvancedCore/wiki/Rewards
+    # https://github.com/BenCodez/AdvancedCore/wiki/Rewards
     Rewards:
       # Execute console commands
       Commands:

VotingPlugin/pom.xml

@@ -2,7 +2,7 @@
 	<modelVersion>4.0.0</modelVersion>
 	<groupId>com.bencodez</groupId>
 	<artifactId>votingplugin</artifactId>
-	<version>6.8</version>
+	<version>6.8.1</version>
 	<packaging>jar</packaging>
 	<name>VotingPlugin</name>
 	<properties>

VotingPlugin/src/com/bencodez/votingplugin/VotingPluginMain.java

@@ -1346,114 +1346,117 @@ public class VotingPluginMain extends AdvancedCorePlugin {
 					update = false;
 
 					synchronized (plugin) {
-						getUserManager().getDataManager().clearCacheBasic();
+						if (plugin != null && plugin.isEnabled()) {
+							getUserManager().getDataManager().clearCacheBasic();
 
-						plugin.debug("Starting background task, current cached users: "
-								+ plugin.getUserManager().getDataManager().getUserDataCache().keySet().size());
-						
-						placeholders.onUpdate();
-
-						int dataLoadLimit = getConfigFile().getPlayerDataLoadLimit();
-						try {
-							boolean extraBackgroundUpdate = configFile.isExtraBackgroundUpdate();
-							long startTime = System.currentTimeMillis();
-
-							LinkedHashMap<TopVoterPlayer, HashMap<VoteSite, LocalDateTime>> voteToday = new LinkedHashMap<TopVoterPlayer, HashMap<VoteSite, LocalDateTime>>();
-							LinkedHashMap<TopVoter, LinkedHashMap<TopVoterPlayer, Integer>> tempTopVoter = new LinkedHashMap<TopVoter, LinkedHashMap<TopVoterPlayer, Integer>>();
-
-							ArrayList<TopVoter> topVotersToCheck = new ArrayList<TopVoter>();
-							for (TopVoter top : TopVoter.values()) {
-								if (plugin.getConfigFile().getLoadTopVoter(top)) {
-									topVotersToCheck.add(top);
-									tempTopVoter.put(top, new LinkedHashMap<TopVoterPlayer, Integer>());
-								}
-							}
-							boolean topVoterIgnorePermissionUse = plugin.getConfigFile().getTopVoterIgnorePermission();
-							ArrayList<String> blackList = plugin.getConfigFile().getBlackList();
-
-							ArrayList<String> uuids = UserManager.getInstance().getAllUUIDs();
-							int currentDay = LocalDateTime.now().getDayOfMonth();
-							int currentDataLoad = 0;
-							for (String uuid : uuids) {
-								if (uuid != null && !uuid.isEmpty()) {
-									VotingPluginUser user = UserManager.getInstance()
-											.getVotingPluginUser(UUID.fromString(uuid), false);
-									user.dontCache();
-									user.tempCache();
-									user.getUserData().updateCacheWithTemp();
-									if (!user.isBanned() && !blackList.contains(user.getPlayerName())) {
-
-										if (!topVoterIgnorePermissionUse || !user.isTopVoterIgnore()) {
-											for (TopVoter top : topVotersToCheck) {
-												int total = user.getTotal(top);
-												if (total > 0) {
-													tempTopVoter.get(top).put(user.getTopVoterPlayer(), total);
-												}
-											}
-										}
-
-										HashMap<VoteSite, LocalDateTime> times = new HashMap<VoteSite, LocalDateTime>();
-										for (Entry<VoteSite, Long> entry : user.getLastVotes().entrySet()) {
-											if (entry.getKey().isEnabled() && !entry.getKey().isHidden()) {
-												long time = entry.getValue();
-												if ((currentDay == MiscUtils.getInstance().getDayFromMili(time))
-														&& (LocalDateTime.now().getMonthValue() == MiscUtils
-																.getInstance().getMonthFromMili(time))
-														&& (LocalDateTime.now().getYear() == MiscUtils.getInstance()
-																.getYearFromMili(time))) {
-
-													times.put(entry.getKey(), LocalDateTime.ofInstant(
-															Instant.ofEpochMilli(time), ZoneId.systemDefault()));
-												}
-											}
-										}
-										if (times.keySet().size() > 0) {
-											voteToday.put(user.getTopVoterPlayer(), times);
-										}
-									}
-									if (!extraBackgroundUpdate) {
-										if (user.isOnline()) {
-											user.offVote();
-										}
-									}
-									plugin.getPlaceholders().onUpdate(user);
-									user.clearTempCache();
-									user = null;
-									if (dataLoadLimit > 0) {
-										currentDataLoad++;
-										if (currentDataLoad >= dataLoadLimit) {
-											currentDataLoad -= dataLoadLimit;
-											Thread.sleep(1000);
-										}
-									}
-								}
-							}
-							update = false;
-							long time1 = ((System.currentTimeMillis() - startTime) / 1000);
-							plugin.debug("Finished loading player data in " + time1 + " seconds, " + uuids.size()
-									+ " users, " + plugin.getStorageType().toString() + ", data load limit: "
-									+ dataLoadLimit);
-							time1 = System.currentTimeMillis();
-
-							topVoterHandler.updateTopVoters(tempTopVoter);
-							setVoteToday(voteToday);
-							serverData.updateValues();
-							getSigns().updateSigns();
-
-							tempTopVoter = null;
-
-							
-
-							time1 = ((System.currentTimeMillis() - time1) / 1000);
-							long totalTime = ((System.currentTimeMillis() - startTime) / 1000);
-							plugin.debug("Background task finished. Final processing took " + time1
-									+ " seconds. Total time: " + totalTime + " seconds");
-							plugin.extraDebug("Current cached users: "
+							plugin.debug("Starting background task, current cached users: "
 									+ plugin.getUserManager().getDataManager().getUserDataCache().keySet().size());
-							checkFirstTimeLoaded();
-						} catch (Exception ex) {
-							plugin.getLogger().info("Looks like something went wrong");
-							ex.printStackTrace();
+
+							placeholders.onUpdate();
+
+							int dataLoadLimit = getConfigFile().getPlayerDataLoadLimit();
+							try {
+								boolean extraBackgroundUpdate = configFile.isExtraBackgroundUpdate();
+								long startTime = System.currentTimeMillis();
+
+								LinkedHashMap<TopVoterPlayer, HashMap<VoteSite, LocalDateTime>> voteToday = new LinkedHashMap<TopVoterPlayer, HashMap<VoteSite, LocalDateTime>>();
+								LinkedHashMap<TopVoter, LinkedHashMap<TopVoterPlayer, Integer>> tempTopVoter = new LinkedHashMap<TopVoter, LinkedHashMap<TopVoterPlayer, Integer>>();
+
+								ArrayList<TopVoter> topVotersToCheck = new ArrayList<TopVoter>();
+								for (TopVoter top : TopVoter.values()) {
+									if (plugin.getConfigFile().getLoadTopVoter(top)) {
+										topVotersToCheck.add(top);
+										tempTopVoter.put(top, new LinkedHashMap<TopVoterPlayer, Integer>());
+									}
+								}
+								boolean topVoterIgnorePermissionUse = plugin.getConfigFile()
+										.getTopVoterIgnorePermission();
+								ArrayList<String> blackList = plugin.getConfigFile().getBlackList();
+
+								ArrayList<String> uuids = UserManager.getInstance().getAllUUIDs();
+								int currentDay = LocalDateTime.now().getDayOfMonth();
+								int currentDataLoad = 0;
+								for (String uuid : uuids) {
+									if (uuid != null && !uuid.isEmpty()) {
+										VotingPluginUser user = UserManager.getInstance()
+												.getVotingPluginUser(UUID.fromString(uuid), false);
+										user.dontCache();
+										user.tempCache();
+										user.getUserData().updateCacheWithTemp();
+										if (!user.isBanned() && !blackList.contains(user.getPlayerName())) {
+
+											if (!topVoterIgnorePermissionUse || !user.isTopVoterIgnore()) {
+												for (TopVoter top : topVotersToCheck) {
+													int total = user.getTotal(top);
+													if (total > 0) {
+														tempTopVoter.get(top).put(user.getTopVoterPlayer(), total);
+													}
+												}
+											}
+
+											HashMap<VoteSite, LocalDateTime> times = new HashMap<VoteSite, LocalDateTime>();
+											for (Entry<VoteSite, Long> entry : user.getLastVotes().entrySet()) {
+												if (entry.getKey().isEnabled() && !entry.getKey().isHidden()) {
+													long time = entry.getValue();
+													if ((currentDay == MiscUtils.getInstance().getDayFromMili(time))
+															&& (LocalDateTime.now().getMonthValue() == MiscUtils
+																	.getInstance().getMonthFromMili(time))
+															&& (LocalDateTime.now().getYear() == MiscUtils.getInstance()
+																	.getYearFromMili(time))) {
+
+														times.put(entry.getKey(), LocalDateTime.ofInstant(
+																Instant.ofEpochMilli(time), ZoneId.systemDefault()));
+													}
+												}
+											}
+											if (times.keySet().size() > 0) {
+												voteToday.put(user.getTopVoterPlayer(), times);
+											}
+										}
+										if (!extraBackgroundUpdate) {
+											if (user.isOnline()) {
+												user.offVote();
+											}
+										}
+										plugin.getPlaceholders().onUpdate(user);
+										user.clearTempCache();
+										user = null;
+										if (dataLoadLimit > 0) {
+											currentDataLoad++;
+											if (currentDataLoad >= dataLoadLimit) {
+												currentDataLoad -= dataLoadLimit;
+												Thread.sleep(1000);
+											}
+										}
+									}
+								}
+								update = false;
+								long time1 = ((System.currentTimeMillis() - startTime) / 1000);
+								plugin.debug("Finished loading player data in " + time1 + " seconds, " + uuids.size()
+										+ " users, " + plugin.getStorageType().toString() + ", data load limit: "
+										+ dataLoadLimit);
+								time1 = System.currentTimeMillis();
+
+								topVoterHandler.updateTopVoters(tempTopVoter);
+								setVoteToday(voteToday);
+								serverData.updateValues();
+								getSigns().updateSigns();
+
+								tempTopVoter = null;
+
+								time1 = ((System.currentTimeMillis() - time1) / 1000);
+								long totalTime = ((System.currentTimeMillis() - startTime) / 1000);
+								plugin.debug("Background task finished. Final processing took " + time1
+										+ " seconds. Total time: " + totalTime + " seconds");
+								plugin.extraDebug("Current cached users: "
+										+ plugin.getUserManager().getDataManager().getUserDataCache().keySet().size());
+								checkFirstTimeLoaded();
+							} catch (Exception ex) {
+								if (plugin != null) {
+									plugin.getLogger().info("Looks like something went wrong");
+								}
+								ex.printStackTrace();
+							}
 						}
 					}
 

VotingPlugin/src/com/bencodez/votingplugin/config/Config.java

@@ -41,6 +41,10 @@ public class Config extends YMLFile {
 	@Getter
 	private boolean preloadSkulls = false;
 
+	@ConfigDataBoolean(path = "AutoCachePlaceholders")
+	@Getter
+	private boolean autoCachePlaceholders = true;
+
 	@ConfigDataBoolean(path = "AllowUnJoinedCheckServer")
 	@Getter
 	private boolean allowUnJoinedCheckServer = true;

VotingPlugin/src/com/bencodez/votingplugin/events/PlayerPostVoteEvent.java

@@ -0,0 +1,81 @@
+package com.bencodez.votingplugin.events;
+
+import org.bukkit.event.Event;
+import org.bukkit.event.HandlerList;
+
+import com.bencodez.votingplugin.bungee.BungeeMessageData;
+import com.bencodez.votingplugin.objects.VoteSite;
+import com.bencodez.votingplugin.user.VotingPluginUser;
+
+import lombok.Getter;
+import lombok.Setter;
+
+// TODO: Auto-generated Javadoc
+/**
+ * The Class PlayerVoteEvent.
+ */
+public class PlayerPostVoteEvent extends Event {
+
+	/** The Constant handlers. */
+	private static final HandlerList handlers = new HandlerList();
+
+	/**
+	 * Gets the handler list.
+	 *
+	 * @return the handler list
+	 */
+	public static HandlerList getHandlerList() {
+		return handlers;
+	}
+
+	@Getter
+	@Setter
+	private boolean bungee = false;
+
+	@Getter
+	@Setter
+	private BungeeMessageData bungeeTextTotals;
+
+	@Getter
+	@Setter
+	private boolean cancelled;
+
+	@Getter
+	@Setter
+	private boolean forceBungee = false;
+
+	@Getter
+	@Setter
+	private VotingPluginUser user;
+
+	@Getter
+	@Setter
+	private boolean realVote = true;
+
+	@Getter
+	@Setter
+	private VoteSite voteSite;
+
+	@Getter
+	@Setter
+	private VotingPluginUser votingPluginUser;
+
+	public PlayerPostVoteEvent(VoteSite voteSite, VotingPluginUser user, boolean realVote, boolean forceBungee) {
+		super(true);
+		this.user = user;
+		this.voteSite = voteSite;
+		this.realVote = realVote;
+		this.forceBungee = forceBungee;
+	}
+
+	/*
+	 * (non-Javadoc)
+	 *
+	 * @see org.bukkit.event.Event#getHandlers()
+	 */
+	@Override
+	public HandlerList getHandlers() {
+		return handlers;
+	}
+
+}

VotingPlugin/src/com/bencodez/votingplugin/listeners/PlayerVoteListener.java

@@ -13,6 +13,7 @@ import com.bencodez.advancedcore.api.misc.ArrayUtils;
 import com.bencodez.advancedcore.api.misc.PlayerUtils;
 import com.bencodez.votingplugin.VotingPluginMain;
 import com.bencodez.votingplugin.bungee.BungeeMethod;
+import com.bencodez.votingplugin.events.PlayerPostVoteEvent;
 import com.bencodez.votingplugin.events.PlayerVoteEvent;
 import com.bencodez.votingplugin.objects.VoteSite;
 import com.bencodez.votingplugin.user.UserManager;
@@ -44,6 +45,9 @@ public class PlayerVoteListener implements Listener {
 	 */
 	@EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true)
 	public void onplayerVote(PlayerVoteEvent event) {
+		if (!plugin.isEnabled()) {
+			return;
+		}
 		String playerName = event.getPlayer();
 		if (!PlayerUtils.getInstance().isValidUser(playerName, plugin.getConfigFile().isAllowUnJoinedCheckServer())) {
 			if (!plugin.getConfigFile().isAllowUnjoined()) {
@@ -109,6 +113,9 @@ public class PlayerVoteListener implements Listener {
 		}
 
 		synchronized (object) {
+			if (!plugin.isEnabled()) {
+				return;
+			}
 			// reupdate cache
 			user.clearCache();
 			user.cache();
@@ -214,6 +221,10 @@ public class PlayerVoteListener implements Listener {
 			}
 		}
 
+		PlayerPostVoteEvent postVoteEvent = new PlayerPostVoteEvent(voteSite, user, event.isRealVote(),
+				event.isForceBungee());
+		plugin.getServer().getPluginManager().callEvent(postVoteEvent);
+
 		plugin.setUpdate(true);
 	}
 

VotingPlugin/src/com/bencodez/votingplugin/placeholders/PlaceHolders.java

@@ -58,23 +58,33 @@ public class PlaceHolders {
 	}
 
 	public String getPlaceHolder(OfflinePlayer p, String identifier, boolean javascript) {
-		if (plugin.getConfigFile().isUseJavascriptPlaceholders() && javascript) {
+		if (plugin.getConfigFile().isUseJavascriptPlaceholders() && javascript && p != null) {
 			identifier = StringParser.getInstance().replaceJavascript(p, identifier);
 		}
 
-		for (NonPlayerPlaceHolder<VotingPluginUser> placeholder : nonPlayerPlaceholders) {
-			if (placeholder.matches(identifier)) {
-				return placeholder.placeholderRequest(identifier);
+		if (!identifier.endsWith("Position")) {
+			for (NonPlayerPlaceHolder<VotingPluginUser> placeholder : nonPlayerPlaceholders) {
+				if (placeholder.matches(identifier)) {
+					String str = placeholder.placeholderRequest(identifier);
+					if (str != null) {
+						return str;
+					}
+				}
 			}
 		}
 
+		if (p == null) {
+			return "no player";
+		}
 		VotingPluginUser user = UserManager.getInstance().getVotingPluginUser(p);
 		if (!cachedPlaceholders.contains(identifier)) {
 			if (Bukkit.isPrimaryThread() || plugin.getConfigFile().isAlwaysWaitForCachePlaceholders()) {
 				user.setWaitForCache(false);
 				if (!user.isCached()) {
 					user.loadCache();
-					placeholdersToSetCacheOn.add(identifier);
+					if (plugin.getConfigFile().isAutoCachePlaceholders()) {
+						placeholdersToSetCacheOn.add(identifier);
+					}
 					return "..";
 				}
 			}
@@ -378,6 +388,9 @@ public class PlaceHolders {
 
 			@Override
 			public String placeholderRequest(String identifier) {
+				if (!StringParser.getInstance().isInt(identifier.split("_")[2])) {
+					return null;
+				}
 				int num = 1;
 				int number = Integer.parseInt(identifier.split("_")[2]);
 				for (Entry<TopVoterPlayer, Integer> entry : plugin.getTopVoter(TopVoter.AllTime).entrySet()) {
@@ -410,6 +423,9 @@ public class PlaceHolders {
 
 			@Override
 			public String placeholderRequest(String identifier) {
+				if (!StringParser.getInstance().isInt(identifier.split("_")[2])) {
+					return null;
+				}
 				int num = 1;
 				int number = Integer.parseInt(identifier.split("_")[2]);
 				for (Entry<TopVoterPlayer, Integer> entry : plugin.getTopVoter(TopVoter.Monthly).entrySet()) {
@@ -458,6 +474,9 @@ public class PlaceHolders {
 
 			@Override
 			public String placeholderRequest(String identifier) {
+				if (!StringParser.getInstance().isInt(identifier.split("_")[2])) {
+					return null;
+				}
 				int num = 1;
 				int number = Integer.parseInt(identifier.split("_")[2]);
 				for (Entry<TopVoterPlayer, Integer> entry : plugin.getTopVoter(TopVoter.Weekly).entrySet()) {
@@ -506,6 +525,9 @@ public class PlaceHolders {
 
 			@Override
 			public String placeholderRequest(String identifier) {
+				if (!StringParser.getInstance().isInt(identifier.split("_")[2])) {
+					return null;
+				}
 				int num = 1;
 				int number = Integer.parseInt(identifier.split("_")[2]);
 				for (Entry<TopVoterPlayer, Integer> entry : plugin.getTopVoter(TopVoter.Daily).entrySet()) {
@@ -690,7 +712,9 @@ public class PlaceHolders {
 
 		Set<String> placeholdersSet = new HashSet<String>();
 		placeholdersSet.addAll(plugin.getConfigFile().getCachedPlaceholders());
-		placeholdersSet.addAll(plugin.getServerData().getAutoCachedPlaceholder());
+		if (plugin.getConfigFile().isAutoCachePlaceholders()) {
+			placeholdersSet.addAll(plugin.getServerData().getAutoCachedPlaceholder());
+		}
 
 		for (String toCache : placeholdersSet) {
 			if (toCache.startsWith("VotingPlugin")) {
@@ -816,7 +840,14 @@ public class PlaceHolders {
 		for (NonPlayerPlaceHolder<VotingPluginUser> placeholder : nonPlayerPlaceholders) {
 			if (placeholder.isUsesCache()) {
 				for (String ident : placeholder.getCache().keySet()) {
-					placeholder.getCache().put(ident, placeholder.placeholderRequest(ident));
+					if (ident != null) {
+						String str = placeholder.placeholderRequest(ident);
+						if (str != null) {
+							placeholder.getCache().put(ident, str);
+						}
+					} else {
+						plugin.debug("ident null: " + placeholder.getIdentifier());
+					}
 				}
 			}
 		}
@@ -827,8 +858,12 @@ public class PlaceHolders {
 				if (placeholder.isUsesCache()) {
 					if (placeholder.getIdentifier().startsWith("Top_")) {
 						for (String ident : placeholder.getCache().keySet()) {
-							placeholder.getCache().get(ident).put(user.getJavaUUID(),
-									placeholder.placeholderRequest(user, ident));
+							if (ident != null) {
+								placeholder.getCache().get(ident).put(user.getJavaUUID(),
+										placeholder.placeholderRequest(user, ident));
+							} else {
+								plugin.debug("ident null: " + placeholder.getIdentifier());
+							}
 						}
 					}
 				}