Bump version

README.md

@@ -1,4 +1,4 @@
-# ViaVersion 0.5.9
+# ViaVersion 0.6.0
 [![Build Status](https://travis-ci.org/MylesIsCool/ViaVersion.svg?branch=master)](https://travis-ci.org/MylesIsCool/ViaVersion)
 **Allows the connection of 1.9 clients to 1.8**
 

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>us.myles</groupId>
     <artifactId>viaversion</artifactId>
-    <version>0.6.0-SNAPSHOT</version>
+    <version>0.6.2-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>ViaVersion</name>

src/main/java/us/myles/ViaVersion/ViaVersionPlugin.java

@@ -116,23 +116,28 @@ public class ViaVersionPlugin extends JavaPlugin implements ViaVersionAPI {
             if (connection != null) {
                 for (Field field : connection.getClass().getDeclaredFields()) {
                     field.setAccessible(true);
-                    Object value = field.get(connection);
+                    final Object value = field.get(connection);
                     if (value instanceof List) {
                         // Inject the list
-                        field.set(connection, new ListWrapper((List) value) {
+                        List wrapper = new ListWrapper((List) value) {
                             @Override
-                            public void handleAdd(Object o) {
-                                if (o instanceof ChannelFuture) {
-                                    inject((ChannelFuture) o);
+                            public synchronized void handleAdd(Object o) {
+                                synchronized (this) {
+                                    if (o instanceof ChannelFuture) {
+                                        inject((ChannelFuture) o);
+                                    }
                                 }
                             }
-                        });
+                        };
+                        field.set(connection, wrapper);
                         // Iterate through current list
-                        for (Object o : (List) value) {
-                            if (o instanceof ChannelFuture) {
-                                inject((ChannelFuture) o);
-                            } else {
-                                break; // not the right list.
+                        synchronized (wrapper) {
+                            for (Object o : (List) value) {
+                                if (o instanceof ChannelFuture) {
+                                    inject((ChannelFuture) o);
+                                } else {
+                                    break; // not the right list.
+                                }
                             }
                         }
                     }
@@ -221,6 +226,10 @@ public class ViaVersionPlugin extends JavaPlugin implements ViaVersionAPI {
         return getConfig().getBoolean("suppress-metadata-errors", false);
     }
 
+    public boolean isShieldBlocking() {
+        return getConfig().getBoolean("shield-blocking", true);
+    }
+
     public boolean isAutoTeam() {
         // Collision has to be enabled first
         if (!isPreventCollision()) return false;

src/main/java/us/myles/ViaVersion/transformers/IncomingTransformer.java

@@ -16,6 +16,7 @@ import us.myles.ViaVersion.util.PacketUtil;
 import java.io.IOException;
 
 public class IncomingTransformer {
+    private final ViaVersionPlugin plugin = (ViaVersionPlugin) ViaVersion.getInstance();
     private final ConnectionInfo info;
     private boolean startedBlocking = false;
 
@@ -34,7 +35,7 @@ public class IncomingTransformer {
         if (packet.getPacketID() != -1) {
             packetID = packet.getPacketID();
         }
-        if (ViaVersion.getInstance().isDebug()) {
+        if (plugin.isDebug()) {
             if (packet != PacketType.PLAY_PLAYER_POSITION_LOOK_REQUEST && packet != PacketType.PLAY_KEEP_ALIVE_REQUEST && packet != PacketType.PLAY_PLAYER_POSITION_REQUEST && packet != PacketType.PLAY_PLAYER_LOOK_REQUEST) {
                 System.out.println("Direction " + packet.getDirection().name() + " Packet Type: " + packet + " New ID: " + packetID + " Original: " + original + " Size: " + input.readableBytes());
             }
@@ -267,7 +268,7 @@ public class IncomingTransformer {
             output.writeByte(face);
             PacketUtil.readVarInt(input);
 
-            ItemStack inHand = ViaVersionPlugin.getHandItem(info);
+            ItemStack inHand = plugin.getHandItem(info);
             try {
                 ItemSlotRewriter.ItemStack item = ItemSlotRewriter.ItemStack.fromBukkit(inHand);
                 ItemSlotRewriter.fixIdsFrom1_9To1_8(item);
@@ -291,8 +292,8 @@ public class IncomingTransformer {
             output.writeLong(-1L);
             output.writeByte(255);
             // write item in hand
-            ItemStack inHand = ViaVersionPlugin.getHandItem(info);
-            if (inHand != null) {
+            ItemStack inHand = plugin.getHandItem(info);
+            if (inHand != null && plugin.isShieldBlocking()) {
                 if (inHand.getType().name().endsWith("SWORD")) {
                     // blocking?
                     if (hand == 0) {

src/main/java/us/myles/ViaVersion/transformers/OutgoingTransformer.java

@@ -830,17 +830,18 @@ public class OutgoingTransformer {
             if (entry.getOldID() == 0) {
                 // Byte
                 byte data = (byte) entry.getValue();
-
-                if ((data & 0x10) == 0x10) {
-                    if (validBlocking.contains(entityID)) {
-                        ItemSlotRewriter.ItemStack shield = new ItemSlotRewriter.ItemStack();
-                        shield.id = 442;
-                        shield.amount = 1;
-                        shield.data = 0;
-                        sendSecondHandItem(entityID, shield);
+                if (entityID != info.getEntityID() && plugin.isShieldBlocking()) {
+                    if ((data & 0x10) == 0x10) {
+                        if (validBlocking.contains(entityID)) {
+                            ItemSlotRewriter.ItemStack shield = new ItemSlotRewriter.ItemStack();
+                            shield.id = 442;
+                            shield.amount = 1;
+                            shield.data = 0;
+                            sendSecondHandItem(entityID, shield);
+                        }
+                    } else {
+                        sendSecondHandItem(entityID, null);
                     }
-                } else {
-                    sendSecondHandItem(entityID, null);
                 }
             }
         }

src/main/java/us/myles/ViaVersion/util/ListWrapper.java

@@ -15,43 +15,43 @@ public abstract class ListWrapper implements List {
     public abstract void handleAdd(Object o);
 
     @Override
-    public int size() {
+    public synchronized int size() {
         return this.list.size();
     }
 
     @Override
-    public boolean isEmpty() {
+    public synchronized boolean isEmpty() {
         return this.list.isEmpty();
     }
 
     @Override
-    public boolean contains(Object o) {
+    public synchronized boolean contains(Object o) {
         return this.list.contains(o);
     }
 
     @Override
-    public Iterator iterator() {
+    public synchronized Iterator iterator() {
         return this.list.iterator();
     }
 
     @Override
-    public Object[] toArray() {
+    public synchronized Object[] toArray() {
         return this.list.toArray();
     }
 
     @Override
-    public boolean add(Object o) {
+    public synchronized boolean add(Object o) {
         handleAdd(o);
         return this.list.add(o);
     }
 
     @Override
-    public boolean remove(Object o) {
+    public synchronized boolean remove(Object o) {
         return this.list.remove(o);
     }
 
     @Override
-    public boolean addAll(Collection c) {
+    public synchronized boolean addAll(Collection c) {
         for (Object o : c) {
             handleAdd(o);
         }
@@ -59,7 +59,7 @@ public abstract class ListWrapper implements List {
     }
 
     @Override
-    public boolean addAll(int index, Collection c) {
+    public synchronized boolean addAll(int index, Collection c) {
         for (Object o : c) {
             handleAdd(o);
         }
@@ -67,72 +67,72 @@ public abstract class ListWrapper implements List {
     }
 
     @Override
-    public void clear() {
+    public synchronized void clear() {
         this.list.clear();
     }
 
     @Override
-    public Object get(int index) {
+    public synchronized Object get(int index) {
         return this.list.get(index);
     }
 
     @Override
-    public Object set(int index, Object element) {
+    public synchronized Object set(int index, Object element) {
         return this.list.set(index, element);
     }
 
     @Override
-    public void add(int index, Object element) {
+    public synchronized void add(int index, Object element) {
         this.list.add(index, element);
     }
 
     @Override
-    public Object remove(int index) {
+    public synchronized Object remove(int index) {
         return this.list.remove(index);
     }
 
     @Override
-    public int indexOf(Object o) {
+    public synchronized int indexOf(Object o) {
         return this.list.indexOf(o);
     }
 
     @Override
-    public int lastIndexOf(Object o) {
+    public synchronized int lastIndexOf(Object o) {
         return this.list.lastIndexOf(o);
     }
 
     @Override
-    public ListIterator listIterator() {
+    public synchronized ListIterator listIterator() {
         return this.list.listIterator();
     }
 
     @Override
-    public ListIterator listIterator(int index) {
-        return this.listIterator(index);
+    public synchronized ListIterator listIterator(int index) {
+        return this.list.listIterator(index);
     }
 
     @Override
-    public List subList(int fromIndex, int toIndex) {
+    public synchronized List subList(int fromIndex, int toIndex) {
         return this.list.subList(fromIndex, toIndex);
     }
 
     @Override
-    public boolean retainAll(Collection c) {
+    public synchronized boolean retainAll(Collection c) {
         return this.list.retainAll(c);
     }
 
     @Override
-    public boolean removeAll(Collection c) {
+    public synchronized boolean removeAll(Collection c) {
         return this.list.removeAll(c);
     }
 
     @Override
-    public boolean containsAll(Collection c) {
+    public synchronized boolean containsAll(Collection c) {
         return this.list.containsAll(c);
     }
 
     @Override
-    public Object[] toArray(Object[] a) {
+    public synchronized Object[] toArray(Object[] a) {
         return this.list.toArray(a);
     }
 }

src/main/resources/config.yml

@@ -9,4 +9,6 @@ prevent-collision: true
 # If the above is true, should we automatically team players until you do?
 auto-team: true
 # When enabled if certain metadata can't be read we won't tell you about it
-suppress-metadata-errors: false
+suppress-metadata-errors: false
+# When enabled 1.9 will be able to block by using shields
+shield-blocking: true