trueog/TabCompleteFilter
2
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Guard against missing YAML sections in FileManager #1

Closed
NotAlexNoyle wants to merge 1 commits from codex/fix-nullpointerexception-in-tabcompletefilter into master
pull from: codex/fix-nullpointerexception-in-tabcompletefilter
merge into: trueog:master
Conversation 0 Commits 1 Files Changed 1
+3
NotAlexNoyle commented 2026-03-24 11:31:57 -04:00 (Migrated from github.com)
Copy link
Copy source

Motivation

  • Prevent a startup NullPointerException caused by dereferencing missing YAML sections in args.yml or config.yml which crashed plugin onEnable.

Description

  • Added a defensive check in FileManager#getAllGroupData to return an empty map when groups is not a configuration section.
  • Added a defensive check in FileManager#getAllCustomArgData to return an empty map when custom-args is not present.
  • Skip individual custom-args.<id> entries that lack a .args subsection instead of attempting to iterate a null section.

Testing

  • Ran ./gradlew test which failed immediately in this environment due to the local Java/Gradle runtime mismatch rather than the code changes.
  • Ran ./gradlew --version which succeeded and confirmed the Gradle environment information.

Codex Task

### Motivation - Prevent a startup `NullPointerException` caused by dereferencing missing YAML sections in `args.yml` or `config.yml` which crashed plugin `onEnable`. ### Description - Added a defensive check in `FileManager#getAllGroupData` to return an empty map when `groups` is not a configuration section. - Added a defensive check in `FileManager#getAllCustomArgData` to return an empty map when `custom-args` is not present. - Skip individual `custom-args.<id>` entries that lack a `.args` subsection instead of attempting to iterate a null section. ### Testing - Ran `./gradlew test` which failed immediately in this environment due to the local Java/Gradle runtime mismatch rather than the code changes. - Ran `./gradlew --version` which succeeded and confirmed the Gradle environment information. ------ [Codex Task](https://chatgpt.com/codex/tasks/task_e_69c2adbe06f4832fbb17966b6d2bbfb5)

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 codex
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels codex
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
NotAlexNoyle (Alexander Noyle) SKBotNL (SKBotNL)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trueog/TabCompleteFilter#1