6 Commits
Author SHA1 Message Date
Stephan 8fbc8c9936 Prevent invalid status responses with empty/dummy player UUIDs (#3831)
Right now SpongeGameProfile.toMcProfile() converts all SpongeAPI GameProfiles
with empty UUIDs (= new UUID(0, 0)) to authlib GameProfiles with a null UUID.

This is fine in most cases but problematic for the sample/player list in
the status response. Empty UUIDs can be used there to create dummy entries,
to display custom messages in the server list instead of the online players.
(See e.g. https://github.com/Minecrell/ServerListPlus/wiki/Status-Configuration#player-hover-messages)

The Minecraft client completely rejects status responses that contain
GameProfiles with null UUIDs and/or null names. This is why it is
important that the empty UUID is not converted to a null UUID.

Prevent sending invalid responses to the client by making sure both
UUID and name are non-null in the player samples of the status response.

This fixes a regression in API 8 when using the ServerListPlus plugin
on Sponge. The problem was likely introduced in some GameProfile refactoring
(API 7 worked fine).
2023-04-12 16:34:12 +00:00
Minecrell 2a01f6c251 Update code owners
Add myself as code owner of the Gradle files and the Jenkinsfile.

It is unlikely that I will find the time to work on the Text API
in the near future, so remove me there for now.
2018-08-10 15:38:54 +02:00
Minecrell 3260a1d84c Add Jenkinsfile 2018-08-10 11:50:27 +02:00
Minecrell 2079579101 Disable Mixin refmap when running in LWTS 2018-07-20 21:25:31 +02:00
Minecrell 2626a0017d Expose LWTS to implementation modules 2018-07-20 21:25:20 +02:00
Minecrell 43b5def3eb Add test that runs a Mixin audit to ensure all Mixins apply successfully 2018-07-20 21:24:17 +02:00