trueog/QuickShop-OG
2
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Skip virtual display self-test when displays are disabled #2

Merged
NotAlexNoyle merged 1 commits from agent/skip-disabled-virtual-display-check into main 2026-07-22 17:06:07 -04:00
Conversation 0 Commits 1 Files Changed 1
+12
NotAlexNoyle commented 2026-07-22 16:29:36 -04:00 (Migrated from github.com)
Copy link
Copy source

What changed

  • Skip the AFTER_ON_ENABLE virtual display self-test when display items are disabled.
  • Also skip it when the selected display type is not VIRTUALITEM.

Why

The earlier ON_ENABLE check already treats those configurations as valid, but the later check still expected a VirtualDisplayItemManager. Because that manager is intentionally absent when virtual displays are not active, startup logged a misleading warning:

VirtualDisplayItemManager is null, this shouldn't happen...

Impact

Servers with shop.display-items: false no longer receive the false-positive warning. Active virtual display configurations retain the existing manager and packet self-tests.

Validation

  • Compared the branch against main.
  • Exactly one file changed with 12 inserted lines and no deletions.
  • The added guards mirror the existing pre-enable checks.

This change is based solely on the existing GPL-era QuickShop-OG source. No post-license-change AGPL code was referenced or used.

## What changed - Skip the `AFTER_ON_ENABLE` virtual display self-test when display items are disabled. - Also skip it when the selected display type is not `VIRTUALITEM`. ## Why The earlier `ON_ENABLE` check already treats those configurations as valid, but the later check still expected a `VirtualDisplayItemManager`. Because that manager is intentionally absent when virtual displays are not active, startup logged a misleading warning: `VirtualDisplayItemManager is null, this shouldn't happen...` ## Impact Servers with `shop.display-items: false` no longer receive the false-positive warning. Active virtual display configurations retain the existing manager and packet self-tests. ## Validation - Compared the branch against `main`. - Exactly one file changed with 12 inserted lines and no deletions. - The added guards mirror the existing pre-enable checks. This change is based solely on the existing GPL-era QuickShop-OG source. No post-license-change AGPL code was referenced or used.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
NotAlexNoyle (Alexander Noyle) SKBotNL (SKBotNL)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trueog/QuickShop-OG#2