trueog/QuickShop-OG
2
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3 from true-og/agent/harden-disabled-virtual-display-check

Browse Source 
Harden disabled virtual display self-test
This commit was merged in pull request #3.
This commit is contained in:
NotAlexNoyle authored and GitHub committed 2026-07-23 18:27:28 -04:00
2 parents 4a671fbe05 f382bd16d0
commit 6427569420
1 file changed
+5 -4
Download Patch File Download Diff File Expand all files Collapse all files
quickshop-bukkit/src/main/java/com/ghostchu/quickshop/util/envcheck/EnvironmentChecker.java
+5 -4
View File
@@ -510,7 +510,7 @@ public final class EnvironmentChecker {
@EnvCheckEntry(name = "Virtual DisplayItem Support Test", priority = 7, stage = EnvCheckEntry.Stage.AFTER_ON_ENABLE)
public ResultContainer virtualDisplayWorkingTest() {
if (!plugin.isDisplayEnabled()) {
if (!plugin.isDisplayEnabled() || !plugin.getConfig().getBoolean("shop.display-items")) {
return new ResultContainer(CheckResult.PASSED, "The display are disabled.");
@@ -522,7 +522,8 @@ public final class EnvironmentChecker {
}
if (plugin.getVirtualDisplayItemManager() == null) {
var virtualDisplayItemManager = plugin.getVirtualDisplayItemManager();
if (virtualDisplayItemManager == null) {
AbstractDisplayItem.setVirtualDisplayDoesntWork(true);
return new ResultContainer(CheckResult.WARNING,
@@ -530,10 +531,10 @@ public final class EnvironmentChecker {
}
Throwable testResult = plugin.getVirtualDisplayItemManager().getPacketFactory().testFakeItem();
Throwable testResult = virtualDisplayItemManager.getPacketFactory().testFakeItem();
if (testResult != null) {
plugin.getVirtualDisplayItemManager().setTestPassed(false);
virtualDisplayItemManager.setTestPassed(false);
AbstractDisplayItem.setVirtualDisplayDoesntWork(true);
plugin.logger().warn("Failed to load the VirtualDisplayItem, self-test failure", testResult);
return new ResultContainer(CheckResult.WARNING,