trueog/Purpur
2
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent server.properties from being overwritten #5

Merged
NotAlexNoyle merged 1 commits from codex/patch-purpur-server-to-protect-server.properties into ver/1.19.4 2026-01-27 22:47:55 -05:00
Conversation 0 Commits 1 Files Changed 1
+28
NotAlexNoyle commented 2026-01-27 22:47:31 -05:00 (Migrated from github.com)
Copy link
Copy source

Motivation

  • Ensure the server never overwrites an existing server.properties file so admin/customized values are preserved.
  • Avoid accidental configuration resets during server startup or config updates.

Description

  • Add a guard to DedicatedServerSettings.update to skip saving if this.path already exists by checking java.nio.file.Files.exists(this.path).
  • Add the same existence check to DedicatedServerSettings.save so server.properties is only written when it does not already exist.
  • Changes are delivered as a patch file at patches/server/0313-Prevent-server-properties-from-being-overwritten.patch that modifies src/main/java/net/minecraft/server/dedicated/DedicatedServerSettings.java.

Testing

  • No automated tests were executed for this patch because it is a small, patch-only change intended to alter save behavior.

Codex Task

### Motivation - Ensure the server never overwrites an existing `server.properties` file so admin/customized values are preserved. - Avoid accidental configuration resets during server startup or config updates. ### Description - Add a guard to `DedicatedServerSettings.update` to skip saving if `this.path` already exists by checking `java.nio.file.Files.exists(this.path)`. - Add the same existence check to `DedicatedServerSettings.save` so `server.properties` is only written when it does not already exist. - Changes are delivered as a patch file at `patches/server/0313-Prevent-server-properties-from-being-overwritten.patch` that modifies `src/main/java/net/minecraft/server/dedicated/DedicatedServerSettings.java`. ### Testing - No automated tests were executed for this patch because it is a small, patch-only change intended to alter save behavior. ------ [Codex Task](https://chatgpt.com/codex/tasks/task_e_69798521b7d8832f80d0d7ce7b824450)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 codex
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels codex
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
NotAlexNoyle (Alexander Noyle) SKBotNL (SKBotNL)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trueog/Purpur#5