trueog/PlayerBounties-OG
2
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use LuckPerms ranks in bounty GUI and add global celebration on claim #8

Merged
NotAlexNoyle merged 1 commits from codex/implement-bounty-gui-enhancements into main 2026-03-09 07:43:03 -04:00
Conversation 0 Commits 1 Files Changed 4
+83 -6
NotAlexNoyle commented 2026-03-09 07:42:49 -04:00 (Migrated from github.com)
Copy link
Copy source

Motivation

  • Surface LuckPerms rank/prefix information in the bounty GUI so player names show their rank styling and group info.
  • Ensure running /bounties or /bounty with no arguments opens the bounty GUI for players.
  • Provide clear celebratory feedback (particles + global sound) when a bounty is successfully claimed.

Description

  • Added a getLuckPerms() accessor to PlayerBountiesOG to expose the LuckPerms API to other classes.
  • Extended BountyTopCmd to resolve a target's rank text via LuckPerms (prefer prefix, fall back to primaryGroup, then return Unranked) and include that rank value when building GUI entries.
  • Updated MainBountyGui to include the resolved rank in the BountyGuiEntry record, show the rank in the item display name and lore, and keep position sorting/behavior intact.
  • Added playGlobalCelebrationEffects in DeathListener and call it when a bounty announcement is broadcast; this plays a global celebration sound and spawns fireworks/totem particles around the killer and victim.

Testing

  • Attempted ./gradlew spotlessApply compileJava which failed in this environment due to a toolchain/Kotlin parsing error (IllegalArgumentException: 25.0.1) before compilation could proceed.
  • Attempted ./gradlew compileJava --stacktrace which produced the same parsing failure and confirmed the build could not be validated here.

Codex Task

### Motivation - Surface LuckPerms rank/prefix information in the bounty GUI so player names show their rank styling and group info. - Ensure running `/bounties` or `/bounty` with no arguments opens the bounty GUI for players. - Provide clear celebratory feedback (particles + global sound) when a bounty is successfully claimed. ### Description - Added a `getLuckPerms()` accessor to `PlayerBountiesOG` to expose the LuckPerms API to other classes. - Extended `BountyTopCmd` to resolve a target's rank text via LuckPerms (prefer `prefix`, fall back to `primaryGroup`, then return `Unranked`) and include that rank value when building GUI entries. - Updated `MainBountyGui` to include the resolved rank in the `BountyGuiEntry` record, show the rank in the item display name and lore, and keep position sorting/behavior intact. - Added `playGlobalCelebrationEffects` in `DeathListener` and call it when a bounty announcement is broadcast; this plays a global celebration sound and spawns fireworks/totem particles around the killer and victim. ### Testing - Attempted `./gradlew spotlessApply compileJava` which failed in this environment due to a toolchain/Kotlin parsing error (`IllegalArgumentException: 25.0.1`) before compilation could proceed. - Attempted `./gradlew compileJava --stacktrace` which produced the same parsing failure and confirmed the build could not be validated here. ------ [Codex Task](https://chatgpt.com/codex/tasks/task_e_69aeb12ecd0c832f9c3231376813e999)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 codex
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels codex
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
NotAlexNoyle (Alexander Noyle) SKBotNL (SKBotNL)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trueog/PlayerBounties-OG#8