Remove ability to unload default worlds.

config/mv_checks.xml

@@ -69,7 +69,7 @@
         <module name="TypeName"/>
         <module name="AvoidStarImport">
             <property name="severity" value="warning"/>
-            <property name="excludes" value="com.onarandombox.MultiverseCore.utils,com.onarandombox.MultiverseCore.configuration,com.onarandombox.MultiverseCore.commands_old,com.onarandombox.MultiverseCore.destination"/>
+            <property name="excludes" value="com.onarandombox.MultiverseCore.utils,com.onarandombox.MultiverseCore.configuration,com.onarandombox.MultiverseCore.commands,com.onarandombox.MultiverseCore.destination"/>
         </module>
         <module name="IllegalImport"/>
         <module name="RedundantImport"/>

pom.xml

@@ -38,10 +38,6 @@
             <id>CodeMC</id>
             <url>https://repo.codemc.org/repository/maven-public</url>
         </repository>
-        <repository>
-            <id>aikar</id>
-            <url>https://repo.aikar.co/content/groups/aikar/</url>
-        </repository>
     </repositories>
 
     <pluginRepositories>
@@ -260,14 +256,6 @@
                                     <pattern>de.themoep.idconverter</pattern>
                                     <shadedPattern>com.onarandombox.idconverter</shadedPattern>
                                 </relocation>
-                                <relocation>
-                                    <pattern>co.aikar.commands</pattern>
-                                    <shadedPattern>com.onarandombox.acf</shadedPattern> <!-- Replace this -->
-                                </relocation>
-                                <relocation>
-                                    <pattern>co.aikar.locales</pattern>
-                                    <shadedPattern>com.onarandombox.locales</shadedPattern> <!-- Replace this -->
-                                </relocation>
                             </relocations>
                         </configuration>
                     </execution>
@@ -324,11 +312,6 @@
         </dependency>
         <!-- End of Economy Dependency -->
         <!-- Start of CommandHandler Dependency -->
-        <dependency>
-            <groupId>co.aikar</groupId>
-            <artifactId>acf-paper</artifactId>
-            <version>0.5.0-SNAPSHOT</version>
-        </dependency>
         <dependency>
             <groupId>com.pneumaticraft.commandhandler</groupId>
             <artifactId>CommandHandler</artifactId>

src/main/java/com/onarandombox/MultiverseCore/MultiverseCore.java

@@ -7,6 +7,21 @@
 
 package com.onarandombox.MultiverseCore;
 
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.io.UnsupportedEncodingException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.logging.Level;
+
 import buscript.Buscript;
 import com.dumptruckman.minecraft.util.Logging;
 import com.onarandombox.MultiverseCore.MVWorld.NullLocation;
@@ -18,7 +33,41 @@ import com.onarandombox.MultiverseCore.api.MVWorldManager;
 import com.onarandombox.MultiverseCore.api.MultiverseCoreConfig;
 import com.onarandombox.MultiverseCore.api.MultiverseMessaging;
 import com.onarandombox.MultiverseCore.api.SafeTTeleporter;
-import com.onarandombox.MultiverseCore.commandtools.MVCommandManager;
+import com.onarandombox.MultiverseCore.commands.AnchorCommand;
+import com.onarandombox.MultiverseCore.commands.CheckCommand;
+import com.onarandombox.MultiverseCore.commands.CloneCommand;
+import com.onarandombox.MultiverseCore.commands.ConfigCommand;
+import com.onarandombox.MultiverseCore.commands.ConfirmCommand;
+import com.onarandombox.MultiverseCore.commands.CoordCommand;
+import com.onarandombox.MultiverseCore.commands.CreateCommand;
+import com.onarandombox.MultiverseCore.commands.DebugCommand;
+import com.onarandombox.MultiverseCore.commands.DeleteCommand;
+import com.onarandombox.MultiverseCore.commands.EnvironmentCommand;
+import com.onarandombox.MultiverseCore.commands.GameruleCommand;
+import com.onarandombox.MultiverseCore.commands.GamerulesCommand;
+import com.onarandombox.MultiverseCore.commands.GeneratorCommand;
+import com.onarandombox.MultiverseCore.commands.HelpCommand;
+import com.onarandombox.MultiverseCore.commands.ImportCommand;
+import com.onarandombox.MultiverseCore.commands.InfoCommand;
+import com.onarandombox.MultiverseCore.commands.ListCommand;
+import com.onarandombox.MultiverseCore.commands.LoadCommand;
+import com.onarandombox.MultiverseCore.commands.ModifyAddCommand;
+import com.onarandombox.MultiverseCore.commands.ModifyClearCommand;
+import com.onarandombox.MultiverseCore.commands.ModifyCommand;
+import com.onarandombox.MultiverseCore.commands.ModifyRemoveCommand;
+import com.onarandombox.MultiverseCore.commands.ModifySetCommand;
+import com.onarandombox.MultiverseCore.commands.PurgeCommand;
+import com.onarandombox.MultiverseCore.commands.RegenCommand;
+import com.onarandombox.MultiverseCore.commands.ReloadCommand;
+import com.onarandombox.MultiverseCore.commands.RemoveCommand;
+import com.onarandombox.MultiverseCore.commands.ScriptCommand;
+import com.onarandombox.MultiverseCore.commands.SetSpawnCommand;
+import com.onarandombox.MultiverseCore.commands.SilentCommand;
+import com.onarandombox.MultiverseCore.commands.SpawnCommand;
+import com.onarandombox.MultiverseCore.commands.TeleportCommand;
+import com.onarandombox.MultiverseCore.commands.UnloadCommand;
+import com.onarandombox.MultiverseCore.commands.VersionCommand;
+import com.onarandombox.MultiverseCore.commands.WhoCommand;
 import com.onarandombox.MultiverseCore.destination.AnchorDestination;
 import com.onarandombox.MultiverseCore.destination.BedDestination;
 import com.onarandombox.MultiverseCore.destination.CannonDestination;
@@ -45,14 +94,14 @@ import com.onarandombox.MultiverseCore.utils.MVMessaging;
 import com.onarandombox.MultiverseCore.utils.MVPermissions;
 import com.onarandombox.MultiverseCore.utils.MVPlayerSession;
 import com.onarandombox.MultiverseCore.utils.MaterialConverter;
+import com.onarandombox.MultiverseCore.utils.TestingMode;
+import com.onarandombox.MultiverseCore.utils.metrics.MetricsConfigurator;
 import com.onarandombox.MultiverseCore.utils.SimpleBlockSafety;
 import com.onarandombox.MultiverseCore.utils.SimpleLocationManipulation;
 import com.onarandombox.MultiverseCore.utils.SimpleSafeTTeleporter;
-import com.onarandombox.MultiverseCore.utils.TestingMode;
 import com.onarandombox.MultiverseCore.utils.UnsafeCallWrapper;
 import com.onarandombox.MultiverseCore.utils.VaultHandler;
 import com.onarandombox.MultiverseCore.utils.WorldManager;
-import com.onarandombox.MultiverseCore.utils.metrics.MetricsConfigurator;
 import com.pneumaticraft.commandhandler.CommandHandler;
 import me.main__.util.SerializationConfig.NoSuchPropertyException;
 import me.main__.util.SerializationConfig.SerializationConfig;
@@ -60,6 +109,7 @@ import org.bukkit.ChatColor;
 import org.bukkit.Difficulty;
 import org.bukkit.GameMode;
 import org.bukkit.Location;
+import org.bukkit.command.Command;
 import org.bukkit.command.CommandSender;
 import org.bukkit.configuration.Configuration;
 import org.bukkit.configuration.ConfigurationSection;
@@ -72,19 +122,6 @@ import org.bukkit.plugin.PluginManager;
 import org.bukkit.plugin.java.JavaPlugin;
 import org.bukkit.plugin.java.JavaPluginLoader;
 
-import java.io.BufferedReader;
-import java.io.File;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.InputStreamReader;
-import java.io.UnsupportedEncodingException;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.LinkedHashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.logging.Level;
-
 /**
  * The implementation of the Multiverse-{@link Core}.
  */
@@ -166,7 +203,7 @@ public class MultiverseCore extends JavaPlugin implements MVPlugin, Core {
     }
 
     // Setup our Map for our Commands using the CommandHandler.
-    private MVCommandManager commandManager;
+    private CommandHandler commandHandler;
 
     private static final String LOG_TAG = "[Multiverse-Core]";
 
@@ -250,7 +287,9 @@ public class MultiverseCore extends JavaPlugin implements MVPlugin, Core {
         this.ph = new MVPermissions(this);
 
         // Setup the command manager
-        this.commandManager = new MVCommandManager(this);
+        this.commandHandler = new CommandHandler(this, this.ph);
+        // Call the Function to assign all the Commands to their Class.
+        this.registerCommands();
 
         // Initialize the Destination factor AFTER the commands
         this.initializeDestinationFactory();
@@ -705,6 +744,51 @@ public class MultiverseCore extends JavaPlugin implements MVPlugin, Core {
         return this.messaging;
     }
 
+    /**
+     * Register Multiverse-Core commands to Command Manager.
+     */
+    private void registerCommands() {
+        // Intro Commands
+        this.commandHandler.registerCommand(new HelpCommand(this));
+        this.commandHandler.registerCommand(new VersionCommand(this));
+        this.commandHandler.registerCommand(new ListCommand(this));
+        this.commandHandler.registerCommand(new InfoCommand(this));
+        this.commandHandler.registerCommand(new CreateCommand(this));
+        this.commandHandler.registerCommand(new CloneCommand(this));
+        this.commandHandler.registerCommand(new ImportCommand(this));
+        this.commandHandler.registerCommand(new ReloadCommand(this));
+        this.commandHandler.registerCommand(new SetSpawnCommand(this));
+        this.commandHandler.registerCommand(new CoordCommand(this));
+        this.commandHandler.registerCommand(new TeleportCommand(this));
+        this.commandHandler.registerCommand(new WhoCommand(this));
+        this.commandHandler.registerCommand(new SpawnCommand(this));
+        // Dangerous Commands
+        this.commandHandler.registerCommand(new UnloadCommand(this));
+        this.commandHandler.registerCommand(new LoadCommand(this));
+        this.commandHandler.registerCommand(new RemoveCommand(this));
+        this.commandHandler.registerCommand(new DeleteCommand(this));
+        this.commandHandler.registerCommand(new RegenCommand(this));
+        this.commandHandler.registerCommand(new ConfirmCommand(this));
+        // Modification commands
+        this.commandHandler.registerCommand(new ModifyCommand(this));
+        this.commandHandler.registerCommand(new PurgeCommand(this));
+        this.commandHandler.registerCommand(new ModifyAddCommand(this));
+        this.commandHandler.registerCommand(new ModifySetCommand(this));
+        this.commandHandler.registerCommand(new ModifyRemoveCommand(this));
+        this.commandHandler.registerCommand(new ModifyClearCommand(this));
+        this.commandHandler.registerCommand(new ConfigCommand(this));
+        this.commandHandler.registerCommand(new AnchorCommand(this));
+        // Misc Commands
+        this.commandHandler.registerCommand(new EnvironmentCommand(this));
+        this.commandHandler.registerCommand(new DebugCommand(this));
+        this.commandHandler.registerCommand(new SilentCommand(this));
+        this.commandHandler.registerCommand(new GeneratorCommand(this));
+        this.commandHandler.registerCommand(new CheckCommand(this));
+        this.commandHandler.registerCommand(new ScriptCommand(this));
+        this.commandHandler.registerCommand(new GameruleCommand(this));
+        this.commandHandler.registerCommand(new GamerulesCommand(this));
+    }
+
     /**
      * {@inheritDoc}
      */
@@ -735,6 +819,30 @@ public class MultiverseCore extends JavaPlugin implements MVPlugin, Core {
         return this.ph;
     }
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
+    public boolean onCommand(CommandSender sender, Command command, String commandLabel, String[] args) {
+        if (!this.isEnabled()) {
+            sender.sendMessage("This plugin is Disabled!");
+            return true;
+        }
+        ArrayList<String> allArgs = new ArrayList<String>(Arrays.asList(args));
+        allArgs.add(0, command.getName());
+        try {
+            return this.commandHandler.locateAndRunCommand(sender, allArgs, getMVConfig().getDisplayPermErrors());
+        } catch (Exception e) {
+            e.printStackTrace();
+            sender.sendMessage(ChatColor.RED + "An internal error occurred when attempting to perform this command.");
+            if (sender.isOp())
+                sender.sendMessage(ChatColor.RED + "Details were printed to the server console and logs, please add that to your bug report.");
+            else
+                sender.sendMessage(ChatColor.RED + "Try again and contact the server owner or an admin if this problem persists.");
+            return true;
+        }
+    }
+
     /**
      * {@inheritDoc}
      *
@@ -805,8 +913,8 @@ public class MultiverseCore extends JavaPlugin implements MVPlugin, Core {
      * {@inheritDoc}
      */
     @Override
-    public MVCommandManager getCommandManager() {
-        return this.commandManager;
+    public CommandHandler getCommandHandler() {
+        return this.commandHandler;
     }
 
     /**

src/main/java/com/onarandombox/MultiverseCore/api/Core.java

@@ -8,7 +8,6 @@
 package com.onarandombox.MultiverseCore.api;
 
 import buscript.Buscript;
-import com.onarandombox.MultiverseCore.commandtools.MVCommandManager;
 import com.onarandombox.MultiverseCore.destination.DestinationFactory;
 import com.onarandombox.MultiverseCore.utils.AnchorManager;
 import com.onarandombox.MultiverseCore.utils.MVEconomist;
@@ -80,12 +79,12 @@ public interface Core {
     MVPermissions getMVPerms();
 
     /**
-     * Multiverse uses {@link MVCommandManager} to make adding and using commands
+     * Multiverse uses {@link CommandHandler} to make adding and using commands
      * a piece of cake.
      *
-     * @return A non-null {@link MVCommandManager}.
+     * @return A non-null {@link CommandHandler}.
      */
-    MVCommandManager getCommandManager();
+    CommandHandler getCommandHandler();
 
     /**
      * Gets the factory class responsible for loading many different destinations

src/main/java/com/onarandombox/MultiverseCore/api/MVWorldManager.java

@@ -219,6 +219,38 @@ public interface MVWorldManager {
      */
     boolean isMVWorld(World world);
 
+    /**
+     * Checks if a world name is the servers default world.
+     *
+     * Generally, default world is defined in level-name of server properties file along with
+     * it's 2 dimensions: [world]_nether, [world]_the_end.
+     *
+     * @param world The world to check.
+     * @return True if world name is a default world, else false.
+     */
+    boolean isDefaultWorld(MultiverseWorld world);
+
+    /**
+     * Checks if a world name is the servers default world.
+     *
+     * Generally, default world is defined in level-name of server properties file along with
+     * it's 2 dimensions: [world]_nether, [world]_the_end.
+     *
+     * @param worldName The name of the world to check.
+     * @return True if world name is a default world, else false.
+     */
+    boolean isDefaultWorld(String worldName);
+
+    /**
+     * Gets all the default world names of the server.
+     *
+     * Generally, default world is defined in level-name of server properties file along with
+     * it's 2 dimensions: [world]_nether, [world]_the_end.
+     *
+     * @return Collection of default world names.
+     */
+    Collection<String> getDefaultWorldNames();
+
     /**
      * Load the Worlds &amp; Settings from the configuration file.
      *

src/main/java/com/onarandombox/MultiverseCore/api/MultiversePlugin.java

@@ -96,6 +96,25 @@ public abstract class MultiversePlugin extends JavaPlugin implements MVPlugin {
      */
     protected abstract void onPluginEnable();
 
+    /**
+     * You can register commands here.
+     * @param handler The CommandHandler.
+     */
+    protected abstract void registerCommands(CommandHandler handler);
+
+    @Override
+    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
+        if (!this.isEnabled()) {
+            sender.sendMessage("This plugin is Disabled!");
+            return true;
+        }
+
+        ArrayList<String> allArgs = new ArrayList<String>(args.length + 1);
+        allArgs.add(command.getName());
+        allArgs.addAll(Arrays.asList(args));
+        return this.getCore().getCommandHandler().locateAndRunCommand(sender, allArgs);
+    }
+
     @Override
     public void log(Level level, String msg) {
         int debugLevel = this.getCore().getMVConfig().getGlobalDebug();

src/main/java/com/onarandombox/MultiverseCore/api/PermissionsInterface.java

@@ -1,13 +0,0 @@
-package com.onarandombox.MultiverseCore.api;
-
-import org.bukkit.command.CommandSender;
-
-import java.util.List;
-
-public interface PermissionsInterface {
-    public boolean hasPermission(CommandSender sender, String node, boolean isOpRequired);
-
-    public boolean hasAnyPermission(CommandSender sender, List<String> allPermissionStrings, boolean opRequired);
-
-    public boolean hasAllPermission(CommandSender sender, List<String> allPermissionStrings, boolean opRequired);
-}

src/main/java/com/onarandombox/MultiverseCore/commands/AnchorCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.ChatColor;

src/main/java/com/onarandombox/MultiverseCore/commands/CheckCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MVDestination;

src/main/java/com/onarandombox/MultiverseCore/commands/CloneCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import java.util.List;
 

src/main/java/com/onarandombox/MultiverseCore/commands/ConfigCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.ChatColor;

src/main/java/com/onarandombox/MultiverseCore/commands/ConfirmCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.command.CommandSender;
@@ -33,7 +33,7 @@ public class ConfirmCommand extends MultiverseCommand {
 
     @Override
     public void runCommand(CommandSender sender, List<String> args) {
-        // this.plugin.getCommandHandler().confirmQueuedCommand(sender);
+        this.plugin.getCommandHandler().confirmQueuedCommand(sender);
     }
 
 }

src/main/java/com/onarandombox/MultiverseCore/commands/CoordCommand.java

@@ -5,12 +5,13 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MVWorldManager;
 import com.onarandombox.MultiverseCore.api.MultiverseWorld;
 import org.bukkit.ChatColor;
+import org.bukkit.Material;
 import org.bukkit.World;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;

src/main/java/com/onarandombox/MultiverseCore/commands/CreateCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MVWorldManager;

src/main/java/com/onarandombox/MultiverseCore/commands/DebugCommand.java

@@ -1,58 +1,67 @@
+/******************************************************************************
+ * Multiverse 2 Copyright (c) the Multiverse Team 2011.                       *
+ * Multiverse 2 is licensed under the BSD License.                            *
+ * For more information please check the README.md file included              *
+ * with this project.                                                         *
+ ******************************************************************************/
+
 package com.onarandombox.MultiverseCore.commands;
 
-import co.aikar.commands.CommandIssuer;
-import co.aikar.commands.annotation.CommandAlias;
-import co.aikar.commands.annotation.CommandCompletion;
-import co.aikar.commands.annotation.CommandPermission;
-import co.aikar.commands.annotation.Conditions;
-import co.aikar.commands.annotation.Description;
-import co.aikar.commands.annotation.Subcommand;
-import co.aikar.commands.annotation.Syntax;
 import com.dumptruckman.minecraft.util.Logging;
 import com.onarandombox.MultiverseCore.MultiverseCore;
-import com.onarandombox.MultiverseCore.messaging.CoreMessageKeys;
 import org.bukkit.ChatColor;
 import org.bukkit.command.CommandSender;
-import org.jetbrains.annotations.NotNull;
+import org.bukkit.permissions.PermissionDefault;
 
-@CommandAlias("mv")
-public class DebugCommand extends MultiverseCoreCommand {
+import java.util.List;
+import java.util.logging.Level;
+
+/**
+ * Enables debug-information.
+ */
+public class DebugCommand extends MultiverseCommand {
 
     public DebugCommand(MultiverseCore plugin) {
         super(plugin);
+        this.setName("Turn Debug on/off?");
+        this.setCommandUsage("/mv debug" + ChatColor.GOLD + " [1|2|3|off|silent]");
+        this.setArgRange(0, 1);
+        this.addKey("mv debug");
+        this.addKey("mv d");
+        this.addKey("mvdebug");
+        this.addCommandExample("/mv debug " + ChatColor.GOLD + "2");
+        this.setPermission("multiverse.core.debug", "Spams the console a bunch.", PermissionDefault.OP);
     }
 
-    @Subcommand("debug")
-    @CommandPermission("multiverse.core.debug")
-    @Description("{@@mv-core.debug_info_description}")
-    public void onShowDebugCommand(@NotNull CommandIssuer issuer) {
-        this.displayDebugMode(issuer);
-    }
-
-    @Subcommand("debug")
-    @CommandPermission("multiverse.core.debug")
-    @Syntax("<{@@mv-core.debug_change_syntax}>")
-    @CommandCompletion("@range:3")
-    @Description("{@@mv-core.debug_change_description}")
-    public void onChangeDebugCommand(@NotNull CommandIssuer issuer,
-
-                                     @Conditions("debuglevel")
-                                     @Syntax("<{@@mv-core.debug_change_syntax}>")
-                                     @Description("{@@mv-core.debug_change_level_description}")
-                                     int level) {
-
-        this.plugin.getMVConfig().setGlobalDebug(level);
-        this.saveMVConfigs(issuer);
-        this.displayDebugMode(issuer);
-    }
-
-    private void displayDebugMode(@NotNull CommandIssuer issuer) {
-        final int debugLevel = this.plugin.getMVConfig().getGlobalDebug();
-        if (debugLevel == 0) {
-            issuer.sendInfo(CoreMessageKeys.DEBUG_INFO_OFF);
-            return;
+    @Override
+    public void runCommand(CommandSender sender, List<String> args) {
+        if (args.size() == 1) {
+            if (args.get(0).equalsIgnoreCase("off")) {
+                plugin.getMVConfig().setGlobalDebug(0);
+            } else {
+                try {
+                    int debugLevel = Integer.parseInt(args.get(0));
+                    if (debugLevel > 3 || debugLevel < 0) {
+                        throw new NumberFormatException();
+                    }
+                    plugin.getMVConfig().setGlobalDebug(debugLevel);
+                } catch (NumberFormatException e) {
+                    sender.sendMessage(ChatColor.RED + "Error" + ChatColor.WHITE
+                            + " setting debug level. Please use a number 0-3 " + ChatColor.AQUA + "(3 being many many messages!)");
+                }
+            }
+            plugin.saveMVConfigs();
+        }
+        this.displayDebugMode(sender);
+    }
+
+    private void displayDebugMode(CommandSender sender) {
+        final int debugLevel = plugin.getMVConfig().getGlobalDebug();
+        if (debugLevel == 0) {
+            sender.sendMessage("Multiverse Debug mode is " + ChatColor.RED + "OFF");
+        } else {
+            sender.sendMessage("Multiverse Debug mode is " + ChatColor.GREEN + debugLevel);
+            Logging.fine("Multiverse Debug ENABLED");
         }
-        issuer.sendInfo(CoreMessageKeys.DEBUG_INFO_ON, "{level}", String.valueOf(debugLevel));
-        Logging.fine("Multiverse Debug ENABLED.");
     }
 }

src/main/java/com/onarandombox/MultiverseCore/commands/DeleteCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.ChatColor;
@@ -37,9 +37,9 @@ public class DeleteCommand extends MultiverseCommand {
 
         Class<?>[] paramTypes = {String.class};
         List<Object> objectArgs = new ArrayList<Object>(args);
-//        this.plugin.getCommandHandler()
-//                   .queueCommand(sender, "mvdelete", "deleteWorld", objectArgs,
-//                                 paramTypes, ChatColor.GREEN + "World '" + worldName + "' Deleted!",
-//                                 ChatColor.RED + "World '" + worldName + "' could NOT be deleted!");
+        this.plugin.getCommandHandler()
+                   .queueCommand(sender, "mvdelete", "deleteWorld", objectArgs,
+                                 paramTypes, ChatColor.GREEN + "World '" + worldName + "' Deleted!",
+                                 ChatColor.RED + "World '" + worldName + "' could NOT be deleted!");
     }
 }

src/main/java/com/onarandombox/MultiverseCore/commands/EnvironmentCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.ChatColor;

src/main/java/com/onarandombox/MultiverseCore/commands/GameruleCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.Bukkit;

src/main/java/com/onarandombox/MultiverseCore/commands/GamerulesCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.Bukkit;

src/main/java/com/onarandombox/MultiverseCore/commands/GeneratorCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.dumptruckman.minecraft.util.Logging;
 import com.onarandombox.MultiverseCore.MultiverseCore;

src/main/java/com/onarandombox/MultiverseCore/commands/HelpCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.pneumaticraft.commandhandler.Command;
@@ -74,7 +74,7 @@ public class HelpCommand extends PaginatedCoreCommand<Command> {
 
         FilterObject filterObject = this.getPageAndFilter(args);
 
-        List<Command> availableCommands = new ArrayList<Command>(); // this.plugin.getCommandHandler().getCommands(sender));
+        List<Command> availableCommands = new ArrayList<Command>(this.plugin.getCommandHandler().getCommands(sender));
         if (filterObject.getFilter().length() > 0) {
             availableCommands = this.getFilteredItems(availableCommands, filterObject.getFilter());
             if (availableCommands.size() == 0) {

src/main/java/com/onarandombox/MultiverseCore/commands/ImportCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MVWorldManager;

src/main/java/com/onarandombox/MultiverseCore/commands/InfoCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.FancyText;

src/main/java/com/onarandombox/MultiverseCore/commands/ListCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MultiverseWorld;

src/main/java/com/onarandombox/MultiverseCore/commands/LoadCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.ChatColor;

src/main/java/com/onarandombox/MultiverseCore/commands/ModifyAddCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MVWorldManager;

src/main/java/com/onarandombox/MultiverseCore/commands/ModifyClearCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MVWorldManager;

src/main/java/com/onarandombox/MultiverseCore/commands/ModifyCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.enums.Action;

src/main/java/com/onarandombox/MultiverseCore/commands/ModifyRemoveCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MVWorldManager;

src/main/java/com/onarandombox/MultiverseCore/commands/ModifySetCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MVWorldManager;

src/main/java/com/onarandombox/MultiverseCore/commands/MultiverseCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MultiverseMessaging;

src/main/java/com/onarandombox/MultiverseCore/commands/MultiverseCoreCommand.java

@@ -1,26 +0,0 @@
-package com.onarandombox.MultiverseCore.commands;
-
-import co.aikar.commands.CommandIssuer;
-import com.onarandombox.MultiverseCore.MultiverseCore;
-import com.onarandombox.MultiverseCore.commandtools.MultiverseCommand;
-import com.onarandombox.MultiverseCore.messaging.CoreMessageKeys;
-
-/**
- * Generic multiverse core command with handy reference to the plugin instance.
- */
-public abstract class MultiverseCoreCommand extends MultiverseCommand {
-
-    protected final MultiverseCore plugin;
-
-    protected MultiverseCoreCommand(MultiverseCore plugin) {
-        this.plugin = plugin;
-    }
-
-    protected boolean saveMVConfigs(CommandIssuer issuer) {
-        if (this.plugin.saveMVConfigs()) {
-            return true;
-        }
-        issuer.sendError(CoreMessageKeys.CONFIG_SAVE_FAILED);
-        return false;
-    }
-}

src/main/java/com/onarandombox/MultiverseCore/commands/PaginatedCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.pneumaticraft.commandhandler.Command;
 import org.bukkit.command.CommandSender;

src/main/java/com/onarandombox/MultiverseCore/commands/PaginatedCoreCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 

src/main/java/com/onarandombox/MultiverseCore/commands/PurgeCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MVWorldManager;

src/main/java/com/onarandombox/MultiverseCore/commands/RegenCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.ChatColor;
@@ -47,7 +47,7 @@ public class RegenCommand extends MultiverseCommand {
         objectArgs.add(useseed);
         objectArgs.add(randomseed);
         objectArgs.add(seed);
-//        this.plugin.getCommandHandler().queueCommand(sender, "mvregen", "regenWorld", objectArgs,
-//                paramTypes, ChatColor.GREEN + "World Regenerated!", ChatColor.RED + "World could NOT be regenerated!");
+        this.plugin.getCommandHandler().queueCommand(sender, "mvregen", "regenWorld", objectArgs,
+                paramTypes, ChatColor.GREEN + "World Regenerated!", ChatColor.RED + "World could NOT be regenerated!");
     }
 }

src/main/java/com/onarandombox/MultiverseCore/commands/ReloadCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.event.MVConfigReloadEvent;

src/main/java/com/onarandombox/MultiverseCore/commands/RemoveCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.ChatColor;

src/main/java/com/onarandombox/MultiverseCore/commands/ScriptCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.ChatColor;

src/main/java/com/onarandombox/MultiverseCore/commands/SetSpawnCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.BlockSafety;

src/main/java/com/onarandombox/MultiverseCore/commands/SilentCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.ChatColor;

src/main/java/com/onarandombox/MultiverseCore/commands/SleepCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.command.CommandSender;

src/main/java/com/onarandombox/MultiverseCore/commands/SpawnCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MultiverseWorld;

src/main/java/com/onarandombox/MultiverseCore/commands/TeleportCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.dumptruckman.minecraft.util.Logging;
 import com.onarandombox.MultiverseCore.MultiverseCore;
@@ -164,8 +164,8 @@ public class TeleportCommand extends MultiverseCommand {
             }
             String message = String.format("%sMultiverse %sdid not teleport %s%s %sto %s%s %sbecause it was unsafe.",
                     ChatColor.GREEN, ChatColor.WHITE, ChatColor.AQUA, player, ChatColor.WHITE, ChatColor.DARK_AQUA, d.getName(), ChatColor.WHITE);
-//            this.plugin.getCommandHandler().queueCommand(sender, "mvteleport", "teleportPlayer", items,
-//                    paramTypes, message, "Would you like to try anyway?", "", "", UNSAFE_TELEPORT_EXPIRE_DELAY);
+            this.plugin.getCommandHandler().queueCommand(sender, "mvteleport", "teleportPlayer", items,
+                    paramTypes, message, "Would you like to try anyway?", "", "", UNSAFE_TELEPORT_EXPIRE_DELAY);
         }
         // else: Player was teleported successfully (or the tp event was fired I should say)
     }

src/main/java/com/onarandombox/MultiverseCore/commands/UnloadCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import org.bukkit.ChatColor;

src/main/java/com/onarandombox/MultiverseCore/commands/VersionCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.dumptruckman.minecraft.util.Logging;
 import com.onarandombox.MultiverseCore.MultiverseCore;

src/main/java/com/onarandombox/MultiverseCore/commands/WhoCommand.java

@@ -5,7 +5,7 @@
  * with this project.                                                         *
  ******************************************************************************/
 
-package com.onarandombox.MultiverseCore.commands_old;
+package com.onarandombox.MultiverseCore.commands;
 
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MVWorldManager;

src/main/java/com/onarandombox/MultiverseCore/commands/package-info.java

@@ -0,0 +1,4 @@
+/**
+ * This package contains all Commands.
+ */
+package com.onarandombox.MultiverseCore.commands;

src/main/java/com/onarandombox/MultiverseCore/commands_old/DebugCommand.java

@@ -1,66 +0,0 @@
-/******************************************************************************
- * Multiverse 2 Copyright (c) the Multiverse Team 2011.                       *
- * Multiverse 2 is licensed under the BSD License.                            *
- * For more information please check the README.md file included              *
- * with this project.                                                         *
- ******************************************************************************/
-
-package com.onarandombox.MultiverseCore.commands_old;
-
-import com.dumptruckman.minecraft.util.Logging;
-import com.onarandombox.MultiverseCore.MultiverseCore;
-import org.bukkit.ChatColor;
-import org.bukkit.command.CommandSender;
-import org.bukkit.permissions.PermissionDefault;
-
-import java.util.List;
-
-/**
- * Enables debug-information.
- */
-public class DebugCommand extends MultiverseCommand {
-
-    public DebugCommand(MultiverseCore plugin) {
-        super(plugin);
-        this.setName("Turn Debug on/off?");
-        this.setCommandUsage("/mv debug" + ChatColor.GOLD + " [1|2|3|off|silent]");
-        this.setArgRange(0, 1);
-        this.addKey("mv debug");
-        this.addKey("mv d");
-        this.addKey("mvdebug");
-        this.addCommandExample("/mv debug " + ChatColor.GOLD + "2");
-        this.setPermission("multiverse.core.debug", "Spams the console a bunch.", PermissionDefault.OP);
-    }
-
-    @Override
-    public void runCommand(CommandSender sender, List<String> args) {
-        if (args.size() == 1) {
-            if (args.get(0).equalsIgnoreCase("off")) {
-                plugin.getMVConfig().setGlobalDebug(0);
-            } else {
-                try {
-                    int debugLevel = Integer.parseInt(args.get(0));
-                    if (debugLevel > 3 || debugLevel < 0) {
-                        throw new NumberFormatException();
-                    }
-                    plugin.getMVConfig().setGlobalDebug(debugLevel);
-                } catch (NumberFormatException e) {
-                    sender.sendMessage(ChatColor.RED + "Error" + ChatColor.WHITE
-                            + " setting debug level. Please use a number 0-3 " + ChatColor.AQUA + "(3 being many many messages!)");
-                }
-            }
-            plugin.saveMVConfigs();
-        }
-        this.displayDebugMode(sender);
-    }
-
-    private void displayDebugMode(CommandSender sender) {
-        final int debugLevel = plugin.getMVConfig().getGlobalDebug();
-        if (debugLevel == 0) {
-            sender.sendMessage("Multiverse Debug mode is " + ChatColor.RED + "OFF");
-        } else {
-            sender.sendMessage("Multiverse Debug mode is " + ChatColor.GREEN + debugLevel);
-            Logging.fine("Multiverse Debug ENABLED");
-        }
-    }
-}

src/main/java/com/onarandombox/MultiverseCore/commands_old/package-info.java

@@ -1,4 +0,0 @@
-/**
- * This package contains all Commands.
- */
-package com.onarandombox.MultiverseCore.commands_old;

src/main/java/com/onarandombox/MultiverseCore/commandtools/MVCommandManager.java

@@ -1,104 +0,0 @@
-package com.onarandombox.MultiverseCore.commandtools;
-
-import co.aikar.commands.BaseCommand;
-import co.aikar.commands.BukkitCommandCompletionContext;
-import co.aikar.commands.BukkitCommandExecutionContext;
-import co.aikar.commands.CommandCompletions;
-import co.aikar.commands.CommandContexts;
-import co.aikar.commands.PaperCommandManager;
-import com.onarandombox.MultiverseCore.MultiverseCore;
-import com.onarandombox.MultiverseCore.commands.DebugCommand;
-
-import java.util.Locale;
-
-/**
- * Main class to manage permissions.
- */
-public class MVCommandManager extends PaperCommandManager {
-
-    private final MultiverseCore plugin;
-
-    public MVCommandManager(MultiverseCore plugin) {
-        super(plugin);
-        this.plugin = plugin;
-
-        // Setup locale
-        this.addSupportedLanguage(Locale.ENGLISH);
-        this.locales.addMessageBundles("multiverse-core");
-        this.locales.loadLanguages();
-
-        // Register commands
-        this.registerCommand(new DebugCommand(plugin));
-    }
-
-    /**
-     * Gets class responsible for parsing string args into objects.
-     *
-     * @return A not-null {@link CommandContexts}.
-     */
-    @Override
-    public synchronized CommandContexts<BukkitCommandExecutionContext> getCommandContexts() {
-        if (this.contexts == null) {
-            this.contexts = new MVCommandParser(this);
-        }
-        return this.contexts;
-    }
-
-    /**
-     * Gets class responsible for tab-completion handling.
-     *
-     * @return A not-null {@link CommandCompletions}.
-     */
-    @Override
-    public synchronized CommandCompletions<BukkitCommandCompletionContext> getCommandCompletions() {
-        if (this.completions == null) {
-            this.completions = new MVCommandSuggestion(this);
-        }
-        return this.completions;
-    }
-
-    /**
-     * Registers an {@link MultiverseCommand}.
-     *
-     * @param command   Command to register. This need to extend {@link MultiverseCommand}.
-     * @param force     Specify of command should be forcefully registered.
-     */
-    @Override
-    public void registerCommand(BaseCommand command, boolean force) {
-        ensureIsMultiverseCommand(command);
-        super.registerCommand(command, force);
-    }
-
-    /**
-     * Registers an {@link MultiverseCommand} without force.
-     *
-     * @param command   Command to register. This need to extend {@link MultiverseCommand}.
-     */
-    @Override
-    public void registerCommand(BaseCommand command) {
-        ensureIsMultiverseCommand(command);
-        super.registerCommand(command);
-    }
-
-    /**
-     * Unregister a command from Multiverse's knowledge.
-     *
-     * @param command   Command to unregister. This need to extend {@link MultiverseCommand}.
-     */
-    @Override
-    public void unregisterCommand(BaseCommand command) {
-        ensureIsMultiverseCommand(command);
-        super.unregisterCommand(command);
-    }
-
-    /**
-     * Validate that the {@link BaseCommand} is an extension of {@link MultiverseCommand}.
-     *
-     * @param command   The command to check on.
-     */
-    private void ensureIsMultiverseCommand(BaseCommand command) {
-        if (!(command instanceof MultiverseCommand)) {
-            throw new IllegalArgumentException(command.getName() + " is not a MultiverseCommand!");
-        }
-    }
-}

src/main/java/com/onarandombox/MultiverseCore/commandtools/MVCommandParser.java

@@ -1,34 +0,0 @@
-package com.onarandombox.MultiverseCore.commandtools;
-
-import co.aikar.commands.BukkitCommandExecutionContext;
-import co.aikar.commands.BukkitCommandIssuer;
-import co.aikar.commands.ConditionContext;
-import co.aikar.commands.ConditionFailedException;
-import co.aikar.commands.PaperCommandContexts;
-import org.bukkit.ChatColor;
-import org.jetbrains.annotations.NotNull;
-
-/**
- * Class to parse command arguments into its object and validate them.
- */
-public class MVCommandParser extends PaperCommandContexts {
-
-    public MVCommandParser(MVCommandManager manager) {
-        super(manager);
-
-        // Contexts
-
-        // Conditions
-        manager.getCommandConditions().addCondition(int.class, "debuglevel", this::checkDebugLevel);
-    }
-
-    private void checkDebugLevel(@NotNull ConditionContext<BukkitCommandIssuer> context,
-                                 @NotNull BukkitCommandExecutionContext executionContext,
-                                 int level) {
-
-        if (level < 0 || level > 3) {
-            throw new ConditionFailedException("Invalid debug mode level. Please use a number 0-3 "
-                + ChatColor.AQUA + "(3 being many many messages!)");
-        }
-    }
-}

src/main/java/com/onarandombox/MultiverseCore/commandtools/MVCommandSuggestion.java

@@ -1,13 +0,0 @@
-package com.onarandombox.MultiverseCore.commandtools;
-
-import co.aikar.commands.PaperCommandCompletions;
-
-/**
- * Class to handle tab-complete suggestions.
- */
-public class MVCommandSuggestion extends PaperCommandCompletions {
-
-    public MVCommandSuggestion(MVCommandManager manager) {
-        super(manager);
-    }
-}

src/main/java/com/onarandombox/MultiverseCore/commandtools/MultiverseCommand.java

@@ -1,10 +0,0 @@
-package com.onarandombox.MultiverseCore.commandtools;
-
-import co.aikar.commands.BaseCommand;
-
-/**
- * Class that all Multiverse commands extends from.
- */
-public abstract class MultiverseCommand extends BaseCommand {
-    public MultiverseCommand() { }
-}

src/main/java/com/onarandombox/MultiverseCore/destination/DestinationFactory.java

@@ -7,22 +7,24 @@
 
 package com.onarandombox.MultiverseCore.destination;
 
-import com.dumptruckman.minecraft.util.Logging;
 import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MVDestination;
+import com.onarandombox.MultiverseCore.commands.TeleportCommand;
 import com.onarandombox.MultiverseCore.utils.PermissionTools;
 import com.onarandombox.MultiverseCore.utils.PlayerFinder;
+import com.pneumaticraft.commandhandler.Command;
 import org.bukkit.Bukkit;
+import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;
 import org.bukkit.permissions.Permission;
 import org.bukkit.permissions.PermissionDefault;
 import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.Collection;
 import java.util.HashMap;
-import java.util.HashSet;
+import java.util.List;
 import java.util.Map;
-import java.util.Set;
 import java.util.regex.Pattern;
 
 /** A factory class that will create destinations from specific strings. */
@@ -30,16 +32,19 @@ public class DestinationFactory {
 
     private static final Pattern CANNON_PATTERN = Pattern.compile("(?i)cannon-[\\d]+(\\.[\\d]+)?");
 
-    private final MultiverseCore plugin;
-    private final Map<String, Class<? extends MVDestination>> destList;
-    private final Set<String> destPermissions;
-    private final PermissionTools permTools;
+    private MultiverseCore plugin;
+    private Map<String, Class<? extends MVDestination>> destList;
+    private Command teleportCommand;
 
     public DestinationFactory(MultiverseCore plugin) {
         this.plugin = plugin;
         this.destList = new HashMap<String, Class<? extends MVDestination>>();
-        this.destPermissions = new HashSet<>();
-        this.permTools = new PermissionTools(plugin);
+        List<Command> cmds = this.plugin.getCommandHandler().getAllCommands();
+        for (Command c : cmds) {
+            if (c instanceof TeleportCommand) {
+                this.teleportCommand = c;
+            }
+        }
     }
 
     /**
@@ -141,40 +146,27 @@ public class DestinationFactory {
         if (identifier.equals("")) {
             identifier = "w";
         }
-        addDestPerm("multiverse.teleport.self." + identifier,
-                "Permission to teleport yourself for the " + identifier + " destination.");
-        addDestPerm("multiverse.teleport.other." + identifier,
-                "Permission to teleport other for the " + identifier + " destination.");
-        return true;
-    }
-
-    /**
-     * Registers a single destination permission.
-     *
-     * @param permNode      Permission node to register.
-     * @param description   Info on what the permission node is used for.
-     */
-    private void addDestPerm(String permNode, String description) {
-        if (this.plugin.getServer().getPluginManager().getPermission(permNode) != null) {
-            Logging.fine("Destination permission node " + permNode + " already added.");
-            return;
+        Permission self = this.plugin.getServer().getPluginManager().getPermission("multiverse.teleport.self." + identifier);
+        Permission other = this.plugin.getServer().getPluginManager().getPermission("multiverse.teleport.other." + identifier);
+        PermissionTools pt = new PermissionTools(this.plugin);
+        if (self == null) {
+            self = new Permission("multiverse.teleport.self." + identifier,
+                    "Permission to teleport yourself for the " + identifier + " destination.", PermissionDefault.OP);
+            this.plugin.getServer().getPluginManager().addPermission(self);
+            pt.addToParentPerms("multiverse.teleport.self." + identifier);
         }
-        Permission perm = new Permission(permNode, description, PermissionDefault.OP);
-        this.plugin.getServer().getPluginManager().addPermission(perm);
-        this.permTools.addToParentPerms(permNode);
-        this.destPermissions.add(permNode);
+        if (other == null) {
+            other = new Permission("multiverse.teleport.other." + identifier,
+                    "Permission to teleport others for the " + identifier + " destination.", PermissionDefault.OP);
+            this.plugin.getServer().getPluginManager().addPermission(other);
+            pt.addToParentPerms("multiverse.teleport.other." + identifier);
+        }
+        this.teleportCommand.addAdditonalPermission(self);
+        this.teleportCommand.addAdditonalPermission(other);
+        return true;
     }
     
     public Collection<String> getRegisteredIdentifiers() {
         return this.destList.keySet();
     }
-
-    /**
-     * Gets all registered permissions relating to usages of {@link MVDestination} on teleport.
-     *
-     * @return A set of permission nodes.
-     */
-    public Set<String> getDestPermissions() {
-        return destPermissions;
-    }
 }

src/main/java/com/onarandombox/MultiverseCore/messaging/CoreMessageKeys.java

@@ -1,20 +0,0 @@
-package com.onarandombox.MultiverseCore.messaging;
-
-import co.aikar.locales.MessageKey;
-import co.aikar.locales.MessageKeyProvider;
-
-import java.util.Locale;
-
-public enum CoreMessageKeys implements MessageKeyProvider {
-
-    CONFIG_SAVE_FAILED,
-    DEBUG_INFO_OFF,
-    DEBUG_INFO_ON;
-
-    private final MessageKey key = MessageKey.of("mv-core." + this.name().toLowerCase(Locale.ENGLISH));
-
-    @Override
-    public MessageKey getMessageKey() {
-        return this.key;
-    }
-}

src/main/java/com/onarandombox/MultiverseCore/utils/MVPermissions.java

@@ -12,7 +12,7 @@ import com.onarandombox.MultiverseCore.MultiverseCore;
 import com.onarandombox.MultiverseCore.api.MVDestination;
 import com.onarandombox.MultiverseCore.api.MVWorldManager;
 import com.onarandombox.MultiverseCore.api.MultiverseWorld;
-import com.onarandombox.MultiverseCore.api.PermissionsInterface;
+import com.pneumaticraft.commandhandler.PermissionsInterface;
 import org.bukkit.ChatColor;
 import org.bukkit.Location;
 import org.bukkit.command.CommandSender;
@@ -21,6 +21,7 @@ import org.bukkit.permissions.Permission;
 import org.bukkit.permissions.PermissionDefault;
 
 import java.util.List;
+import java.util.logging.Level;
 
 /**
  * Multiverse's {@link PermissionsInterface}.

src/main/java/com/onarandombox/MultiverseCore/utils/WorldManager.java

@@ -40,6 +40,7 @@ import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Random;
@@ -59,6 +60,7 @@ public class WorldManager implements MVWorldManager {
     private final WorldPurger worldPurger;
     private final Map<String, MultiverseWorld> worlds;
     private Map<String, WorldProperties> worldsFromTheConfig;
+    private Set<String> defaultWorldNames;
     private FileConfiguration configWorlds = null;
     private Map<String, String> defaultGens;
     private String firstSpawn;
@@ -383,6 +385,11 @@ public class WorldManager implements MVWorldManager {
      */
     @Override
     public boolean unloadWorld(String name, boolean unloadBukkit) {
+        if (this.isDefaultWorld(name)) {
+            Logging.warning("You cannot unload the default worlds.");
+            Logging.warning("Default worlds on your server are: %s", this.defaultWorldNames);
+            return false;
+        }
         if (this.worlds.containsKey(name)) {
             this.worldsFromTheConfig.get(name).cacheVirtualProperties();
             if (unloadBukkit && this.unloadWorldFromBukkit(name, true)) {
@@ -707,6 +714,7 @@ public class WorldManager implements MVWorldManager {
     public void loadDefaultWorlds() {
         this.ensureConfigIsPrepared();
         List<World> myWorlds = this.plugin.getServer().getWorlds();
+        this.defaultWorldNames = new HashSet<>(myWorlds.size());
         for (World w : myWorlds) {
             String name = w.getName();
             if (!worldsFromTheConfig.containsKey(name)) {
@@ -714,9 +722,15 @@ public class WorldManager implements MVWorldManager {
                 if (this.defaultGens.containsKey(name)) {
                     generator = this.defaultGens.get(name);
                 }
-                this.addWorld(name, w.getEnvironment(), String.valueOf(w.getSeed()), w.getWorldType(), w.canGenerateStructures(), generator);
+                if (!this.addWorld(name, w.getEnvironment(), String.valueOf(w.getSeed()), w.getWorldType(), w.canGenerateStructures(), generator)) {
+                    Logging.warning("Error loading default world '%s'!", w.getName());
+                    continue;
+                }
             }
+            this.defaultWorldNames.add(name);
         }
+        this.defaultWorldNames = Collections.unmodifiableSet(this.defaultWorldNames);
+        Logging.fine("Loaded default worlds: %s", this.defaultWorldNames);
     }
 
     private void ensureConfigIsPrepared() {
@@ -726,6 +740,21 @@ public class WorldManager implements MVWorldManager {
         }
     }
 
+    @Override
+    public boolean isDefaultWorld(MultiverseWorld world) {
+        return world != null && this.isDefaultWorld(world.getName());
+    }
+
+    @Override
+    public boolean isDefaultWorld(String worldName) {
+        return this.defaultWorldNames != null && this.defaultWorldNames.contains(worldName);
+    }
+
+    @Override
+    public Collection<String> getDefaultWorldNames() {
+        return this.defaultWorldNames;
+    }
+
     /**
      * {@inheritDoc}
      */

src/main/resources/multiverse-core_en.properties

@@ -1,7 +0,0 @@
-mv-core.config_save_failed=§cUnable to save Multiverse-Core config.yml. Your changes will be temporary!
-mv-core.debug_info_description=Show the current debug level.
-mv-core.debug_info_off=§fMultiverse Debug mode is §cOFF§f.
-mv-core.debug_info_on=§fMultiverse Debug mode is at §alevel {level}§f.
-mv-core.debug_change_description=Change debug level.
-mv-core.debug_change_syntax=level
-mv-core.debug_change_level_description=Debug level to set to.

src/test/java/com/onarandombox/MultiverseCore/TestDebugMode.java

@@ -11,6 +11,7 @@ import com.onarandombox.MultiverseCore.api.Core;
 import com.onarandombox.MultiverseCore.utils.TestInstanceCreator;
 import junit.framework.Assert;
 import org.bukkit.Server;
+import org.bukkit.command.Command;
 import org.bukkit.command.CommandSender;
 import org.bukkit.plugin.Plugin;
 import org.bukkit.plugin.PluginDescriptionFile;
@@ -27,6 +28,8 @@ import java.io.File;
 
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
 
 @RunWith(PowerMockRunner.class)
 @PrepareForTest({ MultiverseCore.class, PluginDescriptionFile.class, JavaPluginLoader.class})
@@ -65,11 +68,16 @@ public class TestDebugMode {
         File serverDirectory = new File(creator.getCore().getServerFolder(), "world");
         serverDirectory.mkdirs();
 
+        // Initialize a fake command
+        Command mockCommand = mock(Command.class);
+        when(mockCommand.getName()).thenReturn("mv");
+
         // Assert debug mode is off
         Assert.assertEquals(0, core.getMVConfig().getGlobalDebug());
 
         // Send the debug command.
-        this.creator.dispatch(mockCommandSender, "mv debug 3");
+        String[] debugArgs = new String[] { "debug", "3" };
+        plugin.onCommand(mockCommandSender, mockCommand, "", debugArgs);
 
         Assert.assertEquals(3, core.getMVConfig().getGlobalDebug());
     }

src/test/java/com/onarandombox/MultiverseCore/TestModifyCommand.java

@@ -10,7 +10,6 @@ import org.bukkit.plugin.PluginDescriptionFile;
 import org.bukkit.plugin.java.JavaPluginLoader;
 import org.junit.After;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.powermock.core.classloader.annotations.PowerMockIgnore;
@@ -25,7 +24,6 @@ import static org.mockito.Mockito.when;
 @RunWith(PowerMockRunner.class)
 @PrepareForTest({ MultiverseCore.class, PluginDescriptionFile.class, JavaPluginLoader.class })
 @PowerMockIgnore("javax.script.*")
-@Ignore
 public class TestModifyCommand {
     TestInstanceCreator creator;
     Server mockServer;

src/test/java/com/onarandombox/MultiverseCore/TestWorldProperties.java

@@ -42,7 +42,6 @@ import org.bukkit.plugin.PluginManager;
 import org.bukkit.plugin.java.JavaPluginLoader;
 import org.junit.After;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.internal.verification.VerificationModeFactory;
@@ -64,7 +63,6 @@ import static org.mockito.Mockito.*;
         PlayerJoinEvent.class, PlayerRespawnEvent.class, EntityRegainHealthEvent.class,
         FoodLevelChangeEvent.class, WorldManager.class, PluginDescriptionFile.class, JavaPluginLoader.class })
 @PowerMockIgnore("javax.script.*")
-@Ignore
 public class TestWorldProperties {
     private TestInstanceCreator creator;
     private MultiverseCore core;

src/test/java/com/onarandombox/MultiverseCore/TestWorldStuff.java

@@ -27,7 +27,6 @@ import org.bukkit.plugin.PluginManager;
 import org.bukkit.plugin.java.JavaPluginLoader;
 import org.junit.After;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.ArgumentMatchers;
@@ -46,7 +45,6 @@ import static org.mockito.Mockito.*;
 @PrepareForTest({ PluginManager.class, MultiverseCore.class, Permission.class, Bukkit.class, WorldManager.class,
         PluginDescriptionFile.class, JavaPluginLoader.class })
 @PowerMockIgnore("javax.script.*")
-@Ignore
 public class TestWorldStuff {
 
     private TestInstanceCreator creator;

src/test/java/com/onarandombox/MultiverseCore/utils/DummyCraftServer.java

@@ -1,8 +0,0 @@
-package com.onarandombox.MultiverseCore.utils;
-
-import org.bukkit.Server;
-import org.bukkit.command.SimpleCommandMap;
-
-public abstract class DummyCraftServer implements Server {
-    public abstract SimpleCommandMap getCommandMap();
-}

src/test/java/com/onarandombox/MultiverseCore/utils/TestInstanceCreator.java

@@ -20,8 +20,6 @@ import org.bukkit.Server;
 import org.bukkit.World;
 import org.bukkit.WorldCreator;
 import org.bukkit.command.CommandSender;
-import org.bukkit.command.SimpleCommandMap;
-import org.bukkit.help.HelpMap;
 import org.bukkit.permissions.Permission;
 import org.bukkit.plugin.Plugin;
 import org.bukkit.plugin.PluginDescriptionFile;
@@ -60,7 +58,6 @@ public class TestInstanceCreator {
     private MultiverseCore core;
     private Server mockServer;
     private CommandSender commandSender;
-    private SimpleCommandMap simpleCommandMap;
 
     public static final File pluginDirectory = new File("bin/test/server/plugins/coretest");
     public static final File serverDirectory = new File("bin/test/server");
@@ -75,19 +72,14 @@ public class TestInstanceCreator {
             MockGateway.MOCK_STANDARD_METHODS = false;
 
             // Initialize the Mock server.
-            mockServer = PowerMockito.mock(DummyCraftServer.class);
+            mockServer = mock(Server.class);
             JavaPluginLoader mockPluginLoader = PowerMock.createMock(JavaPluginLoader.class);
             Whitebox.setInternalState(mockPluginLoader, "server", mockServer);
             when(mockServer.getName()).thenReturn("TestBukkit");
-            when(mockServer.getVersion()).thenReturn("TestBukkit V1");
             Logger.getLogger("Minecraft").setParent(Util.logger);
             when(mockServer.getLogger()).thenReturn(Util.logger);
             when(mockServer.getWorldContainer()).thenReturn(worldsDirectory);
 
-            // Add an internal command map (needed for ACF)
-            this.simpleCommandMap = new SimpleCommandMap(mockServer);
-            PowerMockito.when(mockServer, "getCommandMap").thenReturn(this.simpleCommandMap);
-
             // Return a fake PDF file.
             PluginDescriptionFile pdf = PowerMockito.spy(new PluginDescriptionFile("Multiverse-Core", "2.2-Test",
                     "com.onarandombox.MultiverseCore.MultiverseCore"));
@@ -216,10 +208,6 @@ public class TestInstanceCreator {
                 }});
             when(mockServer.getScheduler()).thenReturn(mockScheduler);
 
-            // add dummy help map
-            HelpMap helpMap = mock(HelpMap.class);
-            when(mockServer.getHelpMap()).thenReturn(helpMap);
-
             // Set server
             Field serverfield = JavaPlugin.class.getDeclaredField("server");
             serverfield.setAccessible(true);
@@ -336,8 +324,4 @@ public class TestInstanceCreator {
     public CommandSender getCommandSender() {
         return commandSender;
     }
-
-    public boolean dispatch(CommandSender sender, String commandLine) {
-        return this.simpleCommandMap.dispatch(sender, commandLine);
-    }
 }