80 Commits
Author SHA1 Message Date
Malavan Sotheeswaran de3c218a02 add release notes up to 6.3.4 2023-10-29 17:39:55 -07:00
Malavan Sotheeswaran 05945b60a8 missed a refernce to isRocksdbSnapshotRepl 2023-10-26 11:40:50 -07:00
Malavan Sotheeswaran 486a6bb7b1 Merge remote-tracking branch 'internal/main' 2023-10-26 11:21:46 -07:00
Malavan Sotheeswaran 47f635ee16 Fix tls auditlog tests and enable tls for CI (#234)
* fix auditlog test titles, and enable tls tests for CI

* fix tls auditlog key string
2023-10-23 14:34:23 -04:00
Malavan SotheeswaranandJohn Sully dfcc848e1c enable level_compaction_dynamic_level_bytes after flush, and flush expires for FLASH (#229)
* enable level_compaction_dynamic_level_bytes after flush, and flush expires

* update debug reload for flash

* update debug reload for flash complete

* missing forward declare

* commit existing changes then track changes for debug reload

* missing args

* commitChanges is conditional

Co-authored-by: John Sully <jsully@snapchat.com>
2023-09-28 16:59:23 -04:00
Malavan Sotheeswaran 596c513d3e only use internal locks when multithreaded (#205) 2023-09-25 15:53:47 -04:00
Malavan Sotheeswaran ace783a00e Flash expiration (#197)
Design Doc: https://docs.google.com/document/d/1NmnYGnHLdZp-KOUCUatX5iXpF-L3YK4VUc9Lm3Tqxpo/edit?usp=sharing
2023-09-08 16:25:53 -04:00
Malavan Sotheeswaran 7d4f461562 Make propagating before freeing module context optional (#225)
* don't propogate on module context free for rdb load

* default in wrong place
2023-09-08 15:51:48 -04:00
Malavan Sotheeswaran 441b74a936 Merge remote-tracking branch 'origin/main' 2023-07-25 21:44:27 -07:00
c17b9f47ac Cherry picking keydb changes from keydbpro to main (#203)
* Audit Logging for KeyProxy and KeyDB (#144)

* Audit Log: log cert fingerprint (#151)

* Add more flash storage stats to info command.

* Remove unneeded libs when not building FLASH

* Fix mem leak

* Allow the reservation of localhost connections to ensure health checks always succeed even at maxclients (#181)

* Enable a force option for commands (#183)

* Fix missing newline and excessive logging in the CLI

* Support NO ONE for "CLUSTER REPLICATE" command.

Co-authored-by: Jacob Bohac <jbohac@snapchat.com>
Co-authored-by: Sergey Kolosov <skolosov@snapchat.com>
Co-authored-by: John Sully <jsully@snapchat.com>
Co-authored-by: John Sully <john@csquare.ca>
2023-06-27 16:23:20 -04:00
Malavan Sotheeswaran dcd623b079 Merge remote-tracking branch 'internal/main' 2023-06-21 16:31:55 -07:00
Malavan Sotheeswaran a77548e44a Make inserts in flight a shared_ptr to avoid double free (#198)
* remove keyproxy test from machamp

* Update build.yaml

* make insertsinflight shared
2023-06-21 16:28:57 -07:00
Malavan Sotheeswaran dde2c27a7e have FreeMemoryLazyFree increment dict refcount so it doesn't try to use a dict that has already been released (#199) 2023-06-21 16:28:57 -07:00
Malavan Sotheeswaran b258322f9e Fix propagate in transaction crash (#200)
* ignore propagate_in_transaction in processCommand if command is async

* make propogate_in_transaction thread local

* forgot module.cpp

* move client_pause_in_transaction to thread local

* don't do async commands while in eval or exec

* don't do keys or scan async if in transaction
2023-06-21 16:28:57 -07:00
Malavan Sotheeswaran 9e310b1bea Make inserts in flight a shared_ptr to avoid double free (#198)
* remove keyproxy test from machamp

* Update build.yaml

* make insertsinflight shared
2023-06-21 16:47:21 -04:00
Malavan Sotheeswaran 2adf93ba0e have FreeMemoryLazyFree increment dict refcount so it doesn't try to use a dict that has already been released (#199) 2023-06-21 16:47:12 -04:00
Malavan Sotheeswaran 8242ba5b47 Fix propagate in transaction crash (#200)
* ignore propagate_in_transaction in processCommand if command is async

* make propogate_in_transaction thread local

* forgot module.cpp

* move client_pause_in_transaction to thread local

* don't do async commands while in eval or exec

* don't do keys or scan async if in transaction
2023-06-21 16:40:35 -04:00
Malavan Sotheeswaran 45b41fbde6 Merge remote-tracking branch 'origin/main' 2023-06-15 15:06:45 -07:00
Malavan Sotheeswaran 163f903f3f remove keyproxy test from machamp
* Update build.yaml
2023-05-30 14:49:06 -04:00
Malavan Sotheeswaran ef8b1bf373 add fPreSnapshot to evictionTimeProc 2023-05-25 00:03:39 -07:00
Malavan Sotheeswaran e4dacb467f add config to disable storage key cache 2023-04-25 11:15:57 -07:00
Malavan Sotheeswaran a8c0f9b1c4 limit number of random elements returned based on config, exit loop early if client is being closed 2023-04-18 17:08:27 -07:00
Malavan Sotheeswaran 36d515ef39 ptrFromObj to szFromObj 2023-04-18 17:08:27 -07:00
Malavan Sotheeswaran 525c97d6cd ->ptr to ptrFromObj 2023-04-18 17:08:27 -07:00
Malavan Sotheeswaran 045cc52c1f don't use sizeof on malloc'd pointer 2023-02-14 18:23:35 -08:00
Malavan Sotheeswaran 819bcc1f2a don't sizeof on a pointer 2023-02-14 17:51:26 -08:00
Malavan Sotheeswaran 7fcbfac103 snprintf fix 2023-02-14 17:51:19 -08:00
Malavan Sotheeswaran 9f4c6e6f15 using forked bg save causes more harm than good 2023-02-10 01:23:52 -08:00
Malavan Sotheeswaran 6c26f91bcd rdb_child_pid isn't the correct value 2023-02-10 01:13:12 -08:00
Malavan Sotheeswaran 932fc207ea make bgsave fork by default 2023-02-09 12:22:29 -08:00
Malavan Sotheeswaran 0cba0ed30b refactor aeReleaseForkLockChild to capture releaseRead case 2023-02-09 12:06:27 -08:00
Malavan Sotheeswaran b5ab1d64e2 need child specific release that doesn't trigger cv 2023-02-09 10:28:22 -08:00
Malavan Sotheeswaran 3492615c6a don't release lock on child as it can hang 2023-02-09 09:39:25 -08:00
Malavan Sotheeswaran f3a9d2e0cd technically possible for child_type == CHILD_TYPE_AOF without active child 2023-02-06 20:33:21 -08:00
Malavan Sotheeswaran 694fc59f2a move memory check before rocksdb to avoid crash in child 2023-01-23 13:26:27 -08:00
Malavan Sotheeswaran 7e91711086 fix debian 12 test failure 2023-01-23 13:26:24 -08:00
Malavan Sotheeswaran 23f92fa94c Merge pull request #87 from Snapchat/fix_ftracking_bug
Check tracking on every db in rdbLoadRio
2022-08-17 15:33:09 -04:00
Malavan Sotheeswaran c5cd0d89f8 fix warnings 2022-08-17 10:31:30 -07:00
Malavan Sotheeswaran a8f6132862 check tracking per db 2022-08-17 09:50:16 -07:00
Malavan Sotheeswaran 6afeef0291 Update build-and-publish.sh 2022-06-14 17:26:00 -04:00
Malavan Sotheeswaran bdfd34cf10 use atomic_load for g_pserver->mstime 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran 4af996e32e use atomic_load for g_pserver->mstime 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran 8f6c6bb6a4 need to include stdint for uintptr_t 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran eb46be3685 need to include stdint for uintptr_t 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran 2c881b390a cannot mod a pointer 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran 0f187c7465 cannot mod a pointer 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran f189bbb4e4 remove nullptr subtraction 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran d63c5acb20 remove nullptr subtraction 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran e0548b4722 check ziplist len to avoid crash on empty ziplist convert 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran 8f3f127203 check ziplist len to avoid crash on empty ziplist convert 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran 60a85737e6 remove unused var in networking.cpp 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran 203e4e228f remove unused var in networking.cpp 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran 78086d6293 set thread as offline when waiting for time thread lock 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran 5e2d3fafae set thread as offline when waiting for time thread lock 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran aa07287c05 time thread lock uses fastlock instead of std::mutex 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran 6d1cd00f15 time thread lock uses fastlock instead of std::mutex 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran 24a586cdf1 only need to include readwritelock in ae 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran fa0a60240b only need to include readwritelock in ae 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran 4d4acaa155 hide forklock object in ae 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran f35baf8e7d hide forklock object in ae 2022-04-26 01:55:22 +00:00
Malavan Sotheeswaran dfeeee040d use atomic_load for g_pserver->mstime 2022-04-13 14:10:58 -04:00
Malavan Sotheeswaran 9486f16857 use atomic_load for g_pserver->mstime 2022-04-13 14:10:58 -04:00
Malavan Sotheeswaran cc8c82b530 need to include stdint for uintptr_t 2022-04-13 14:10:58 -04:00
Malavan Sotheeswaran b2a1b8cd0c need to include stdint for uintptr_t 2022-04-13 14:10:58 -04:00
Malavan Sotheeswaran b320dd0178 cannot mod a pointer 2022-04-13 14:10:58 -04:00
Malavan Sotheeswaran 7d3c604280 cannot mod a pointer 2022-04-13 14:10:58 -04:00
Malavan Sotheeswaran 1a2a3e730a remove nullptr subtraction 2022-04-13 14:10:58 -04:00
Malavan Sotheeswaran b0f4454851 remove nullptr subtraction 2022-04-13 14:10:58 -04:00
Malavan Sotheeswaran 114c94dc57 check ziplist len to avoid crash on empty ziplist convert 2022-04-13 14:08:44 -04:00
Malavan Sotheeswaran 8f02c51f2e check ziplist len to avoid crash on empty ziplist convert 2022-04-13 14:08:44 -04:00
Malavan Sotheeswaran 2f9b429071 remove unused var in networking.cpp 2022-04-13 14:08:43 -04:00
Malavan Sotheeswaran b73ece90f5 remove unused var in networking.cpp 2022-04-13 14:08:43 -04:00
Malavan Sotheeswaran 3d4429fca1 set thread as offline when waiting for time thread lock 2022-04-13 14:06:58 -04:00
Malavan Sotheeswaran b1f0d8ddf5 set thread as offline when waiting for time thread lock 2022-04-13 14:06:58 -04:00
Malavan Sotheeswaran 0290964b8d time thread lock uses fastlock instead of std::mutex 2022-04-13 14:05:26 -04:00
Malavan Sotheeswaran 395eb1fd3a time thread lock uses fastlock instead of std::mutex 2022-04-13 14:05:26 -04:00
Malavan Sotheeswaran 5bec423b25 only need to include readwritelock in ae 2022-04-13 14:04:07 -04:00
Malavan Sotheeswaran 2e4d50fbc4 only need to include readwritelock in ae 2022-04-13 14:04:07 -04:00
Malavan Sotheeswaran 6dcd4ca0fc hide forklock object in ae 2022-04-13 14:04:02 -04:00
Malavan Sotheeswaran 09c1b0d5fc hide forklock object in ae 2022-04-13 14:04:02 -04:00