trueog/IllegalStack-OG
2
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove all hardcoded OP bypass checks from plugin #3

Merged
GWServer merged 3 commits from fix/remove-op-bypass into master 2026-07-23 17:40:18 -04:00
Conversation 2 Commits 3 Files Changed 6
+13 -29
GWServer commented 2026-07-20 03:43:13 -04:00 (Migrated from github.com)
Copy link
Copy source
  • Removed isOp() checks from all protection modules:
    • pLisbListener.java - fixed syntax error in creative tab check
    • fListener.java - removed OP bypass from 7 locations
    • Listener113.java - removed OP bypass from spawner check
    • fTimer.java - removed OP bypass from notification and item checks
    • Protections.java - removed OP bypass from overstack permission
  • Updated build.gradle.kts to use system Java 17 (removed GraalVM vendor requirement)
  • Plugin now fully respects permission system without OP override
- Removed isOp() checks from all protection modules: * pLisbListener.java - fixed syntax error in creative tab check * fListener.java - removed OP bypass from 7 locations * Listener113.java - removed OP bypass from spawner check * fTimer.java - removed OP bypass from notification and item checks * Protections.java - removed OP bypass from overstack permission - Updated build.gradle.kts to use system Java 17 (removed GraalVM vendor requirement) - Plugin now fully respects permission system without OP override
GWServer commented 2026-07-22 07:28:20 -04:00 (Migrated from github.com)
Copy link
Copy source
  1. Remove OP Bypass Checks (Your Changes)
    Removed all hardcoded player.isOp() checks from protection modules

Plugin now fully respects the permission system without automatic OP override

Fixed syntax errors in pLisbListener.java creative tab check

Updated build.gradle.kts to use system Java 17 (removed GraalVM vendor requirement)

Files Modified:

src/main/java/main/java/me/dniym/enums/Protections.java

src/main/java/main/java/me/dniym/listeners/Listener113.java

src/main/java/main/java/me/dniym/listeners/fListener.java (7 locations)

src/main/java/main/java/me/dniym/listeners/pLisbListener.java

src/main/java/main/java/me/dniym/timers/fTimer.java (2 locations)

  1. Upstream Merge (From commit 508277b)
    Refactored BlockBadItemsFromCreativeTab protection

Added new CreativeItemCheck class for safer creative item validation

Improved logging for creative item blocks

Added unit tests for CreativeItemCheck

Updated version to 2.9.15-SNAPSHOT

Added test dependencies (JUnit 5, Mockito)

1. Remove OP Bypass Checks (Your Changes) Removed all hardcoded player.isOp() checks from protection modules Plugin now fully respects the permission system without automatic OP override Fixed syntax errors in pLisbListener.java creative tab check Updated build.gradle.kts to use system Java 17 (removed GraalVM vendor requirement) Files Modified: src/main/java/main/java/me/dniym/enums/Protections.java src/main/java/main/java/me/dniym/listeners/Listener113.java src/main/java/main/java/me/dniym/listeners/fListener.java (7 locations) src/main/java/main/java/me/dniym/listeners/pLisbListener.java src/main/java/main/java/me/dniym/timers/fTimer.java (2 locations) 2. Upstream Merge (From commit 508277b) Refactored BlockBadItemsFromCreativeTab protection Added new CreativeItemCheck class for safer creative item validation Improved logging for creative item blocks Added unit tests for CreativeItemCheck Updated version to 2.9.15-SNAPSHOT Added test dependencies (JUnit 5, Mockito)
NotAlexNoyle commented 2026-07-23 17:40:00 -04:00 (Migrated from github.com)
Copy link
Copy source

Thanks for your contribution, all these changes look good to me. I fixed the only conflict by bumping the version number.

Thanks for your contribution, all these changes look good to me. I fixed the only conflict by bumping the version number.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
NotAlexNoyle (Alexander Noyle) SKBotNL (SKBotNL)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trueog/IllegalStack-OG#3