trueog/DiamondBank-OG
2
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix issues found in review #48

Merged
SKBotNL merged 7 commits from master into master 2026-09-17 17:33:57 -04:00
Conversation 0 Commits 7 Files Changed 7
+80 -66
SKBotNL commented 2026-09-17 17:33:21 -04:00 (Migrated from github.com)
Copy link
Copy source
  • Fix incorrect count of currency in InventorySnapshotUtils by using PlayerInventoryExtensions' implementations instead
  • Don't count currency in shulker boxes until logic to actually handle them is added
  • Fix player being seen as invalid during first session
  • wait -> block in Javadoc of API functions
  • Prevent deadlock in internalAddToPlayerShards by introducing internalGetShardTypeShards
  • Set maxActiveConnections for PostgreSQL to 6
  • Check that sender isn't equal to receiver in playerPayPlayer
- Fix incorrect count of currency in InventorySnapshotUtils by using PlayerInventoryExtensions' implementations instead - Don't count currency in shulker boxes until logic to actually handle them is added - Fix player being seen as invalid during first session - wait -> block in Javadoc of API functions - Prevent deadlock in internalAddToPlayerShards by introducing internalGetShardTypeShards - Set maxActiveConnections for PostgreSQL to 6 - Check that sender isn't equal to receiver in playerPayPlayer
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
NotAlexNoyle (Alexander Noyle) SKBotNL (SKBotNL)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trueog/DiamondBank-OG#48