Upgrade to 2.4.1

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>me.dadus33</groupId>
     <artifactId>chatitem</artifactId>
-    <version>2.4</version>
+    <version>2.4.1</version>
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
@@ -73,13 +73,13 @@
         <dependency>
             <groupId>org.apache.logging.log4j</groupId>
             <artifactId>log4j-api</artifactId>
-            <version>2.17.1</version>
+            <version>2.17.2</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
             <groupId>org.apache.logging.log4j</groupId>
             <artifactId>log4j-core</artifactId>
-            <version>2.17.1</version>
+            <version>2.17.2</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
@@ -133,7 +133,7 @@
         <dependency>
             <groupId>net.kyori</groupId>
             <artifactId>adventure-api</artifactId>
-            <version>4.10.1</version>
+            <version>4.11.0</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
@@ -145,7 +145,7 @@
         <dependency>
             <groupId>com.discordsrv</groupId>
             <artifactId>discordsrv</artifactId>
-            <version>1.24.1-SNAPSHOT</version>
+            <version>1.25.1</version>
             <scope>provided</scope>
         </dependency>
         <dependency>

src/main/java/me/dadus33/chatitem/ChatItem.java

@@ -145,7 +145,7 @@ public class ChatItem extends JavaPlugin {
         
 
         getServer().getMessenger().registerIncomingPluginChannel(this, brandChannelName, (chan, p, msg) -> {
-            String client = new String(msg);
+            String client = new String(msg).substring(1);
             ChatItem.debug("Detected client " + client + " for " + p.getName());
             ItemPlayer.getPlayer(p).setClientName(client);
         });

src/main/java/me/dadus33/chatitem/chatmanager/v1/basecomp/hook/AdventureComponentGetter.java

@@ -27,8 +27,8 @@ public class AdventureComponentGetter implements IBaseComponentGetter {
 			return false;
 		}
 		try {
-			PacketUtils.getNmsClass("PacketPlayOutChat", "network.protocol.game.").getField("adventure$message");
-		} catch (NoSuchFieldException e) {
+			PacketUtils.getNmsClass("PacketPlayOutChat", "network.protocol.game.", "ClientboundSystemChatPacket").getField("adventure$message");
+		} catch (Exception e) {
 			return false;
 		}
 		return true;

src/main/java/me/dadus33/chatitem/chatmanager/v1/listeners/ChatPacketManager.java

@@ -83,11 +83,13 @@ public class ChatPacketManager extends PacketHandler {
 		String json = "{}";
 		IBaseComponentGetter choosedGetter = null;
 		if (version.isNewerOrEquals(Version.V1_19)) {
-			if(packet.getIntegers().readSafely(0) != 1)
+			if(packet.getIntegers().readSafely(0, 0) != 1)
 				return;
-			String foundedJson = packet.getStrings().read(0); // for final things
-			json = foundedJson;
-			choosedGetter = new StringComponentGetter();
+			String foundedJson = packet.getStrings().readSafely(0);
+			if(foundedJson != null) {
+				json = foundedJson;
+				choosedGetter = new StringComponentGetter();
+			}
 		} else if (version.isNewerOrEquals(Version.V1_12)) {
 			// only if action bar messages are supported in this version of minecraft
 			try {

src/main/java/me/dadus33/chatitem/chatmanager/v1/packets/custom/CustomPacketManager.java

@@ -10,7 +10,6 @@ import org.bukkit.event.player.PlayerJoinEvent;
 import org.bukkit.event.player.PlayerQuitEvent;
 import org.bukkit.plugin.Plugin;
 
-import me.dadus33.chatitem.ChatItem;
 import me.dadus33.chatitem.chatmanager.v1.packets.ChatItemPacket;
 import me.dadus33.chatitem.chatmanager.v1.packets.PacketManager;
 import me.dadus33.chatitem.chatmanager.v1.packets.PacketType;
@@ -83,10 +82,8 @@ public class CustomPacketManager extends PacketManager implements Listener {
 	}
 
 	public ChatItemPacket onPacketSent(PacketType type, Player sender, Object packet) {
-		if(type == null) {
-			ChatItem.debug("Failed to find packet type for " + packet.getClass().getSimpleName());
+		if(type == null)
 			return null;
-		}
 		ChatItemPacket customPacket = new ChatItemPacket(type, packet, sender);
 		notifyHandlersSent(customPacket);
 		return customPacket;

src/main/java/me/dadus33/chatitem/commands/ChatItemCommand.java

@@ -20,10 +20,10 @@ import net.md_5.bungee.api.chat.ClickEvent;
 import net.md_5.bungee.api.chat.ComponentBuilder;
 import net.md_5.bungee.api.chat.HoverEvent;
 import net.md_5.bungee.api.chat.TextComponent;
+import net.md_5.bungee.api.chat.hover.content.Text;
 
 public class ChatItemCommand implements CommandExecutor, TabExecutor {
 
-	@SuppressWarnings("deprecation")
 	@Override
 	public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 		if (!(sender instanceof Player)) {
@@ -47,7 +47,7 @@ public class ChatItemCommand implements CommandExecutor, TabExecutor {
 				String hover = Storage.color(linkConfig.getString("hover"));
 				if (hover != null)
 					linkComp.setHoverEvent(
-							new HoverEvent(HoverEvent.Action.SHOW_TEXT, new ComponentBuilder(hover).create()));
+							new HoverEvent(HoverEvent.Action.SHOW_TEXT, new Text(new ComponentBuilder(hover).create())));
 				String link = linkConfig.getString("link");
 				if (link != null)
 					linkComp.setClickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, link));

src/main/java/me/dadus33/chatitem/listeners/JoinListener.java

@@ -12,10 +12,10 @@ import net.md_5.bungee.api.chat.ClickEvent;
 import net.md_5.bungee.api.chat.ComponentBuilder;
 import net.md_5.bungee.api.chat.HoverEvent;
 import net.md_5.bungee.api.chat.TextComponent;
+import net.md_5.bungee.api.chat.hover.content.Text;
 
 public class JoinListener implements Listener {
 
-	@SuppressWarnings("deprecation")
 	@EventHandler
 	public void onJoin(PlayerJoinEvent e) {
 		Player p = e.getPlayer();
@@ -24,7 +24,7 @@ public class JoinListener implements Listener {
 		ChatItem pl = ChatItem.getInstance();
 		if(pl.isHasNewVersion()) {
 			TextComponent text = new TextComponent(pl.getStorage().JOIN_UPDATE_MESSAGE);
-			text.setHoverEvent(new HoverEvent(HoverEvent.Action.SHOW_TEXT, new ComponentBuilder(pl.getStorage().JOIN_UPDATE_HOVER).create()));
+			text.setHoverEvent(new HoverEvent(HoverEvent.Action.SHOW_TEXT, new Text(new ComponentBuilder(pl.getStorage().JOIN_UPDATE_HOVER).create())));
 			text.setClickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, "https://www.spigotmc.org/resources/19064/"));
 			p.spigot().sendMessage(text);
 		}