Revert "Issue #1909 - Guard against empty update manifest URL"

This reverts commit d7fadcdef9.
Merge branch 'master' into release
2022-06-07 11:59:07 +00:00 · 2022-06-03 21:50:44 +00:00 · 2022-06-01 13:54:11 +00:00 · 2022-05-29 11:13:44 +00:00 · 2022-05-07 14:40:14 +00:00 · 2022-05-06 12:43:43 +00:00
3 changed files with 2 additions and 14 deletions
@@ -8,4 +8,4 @@
 # Referenced by milestone.py.
 #--------------------------------------------------------

-5.1.0+
+5.1.0
@@ -611,14 +611,6 @@ function UpdateParser(aId, aUpdateKey, aUrl, aObserver) {
  let requireBuiltIn = Services.prefs.getBoolPref(PREF_UPDATE_REQUIREBUILTINCERTS, true);

  logger.debug("Requesting " + aUrl);
-
-  if (!aUrl) {
-    logger.warn("Request failed: empty update manifest URL");
-    this._doneAt = new Error("UP_emptyManifestURL");
-    this.notifyError(AddonUpdateChecker.ERROR_DOWNLOAD_ERROR);
-    return;
-  }
-
  try {
    this.request = new ServiceRequest();
    this.request.open("GET", this.url, true);
@@ -6129,11 +6129,7 @@ function UpdateChecker(aAddon, aListener, aReason, aAppVersion, aPlatformVersion
  if ("onUpdateAvailable" in this.listener)
    aReason |= UPDATE_TYPE_NEWVERSION;

-  // Don't perform substitutions on the update URL if we still don't
-  // have one at this point.
-  let url = updateURL ?
-            escapeAddonURI(aAddon, url, aReason, aAppVersion) :
-            updateURL;
+  let url = escapeAddonURI(aAddon, updateURL, aReason, aAppVersion);
  this._parser = AddonUpdateChecker.checkForUpdates(aAddon.id, aAddon.updateKey,
                                                    url, this);
 }
Author	SHA1	Message	Date
Moonchild	cfc0eeca53	Revert "Issue #1909 - Guard against empty update manifest URL" This reverts commit `d7fadcdef9`.	2022-06-07 11:59:07 +00:00
Moonchild	ebd3dd9228	Merge branch 'master' into release	2022-06-03 21:50:44 +00:00
Moonchild	cb40e4e7ef	Merge branch 'master' into release	2022-06-01 13:54:11 +00:00
Moonchild	662dba55fd	Merge branch 'master' into release	2022-05-29 11:13:44 +00:00
Moonchild	8760ce023c	Issue #1895 - Implement queueMicroTask(callback()) (uplift)	2022-05-07 14:40:14 +00:00
Moonchild	b86e148bb7	Roll back milestone version to release.	2022-05-06 12:43:43 +00:00
Moonchild	9e83721e5e	Merge branch 'master' into release	2022-05-06 12:43:00 +00:00
Moonchild	dc2d6c2e60	Revert "No Issue - Make content-type on JAR channels behave the same as HTTP channels." This reverts commit `425677ada7`.	2022-05-03 17:38:19 +00:00
Moonchild	4ada6f6762	Update 7zSD for v31	2022-05-03 17:38:12 +00:00