mirror of
https://github.com/wekan/wekan.git
synced 2026-11-20 09:45:04 -05:00
v10.89's snap-launchpad armhf, ppc64el and s390x jobs published the snap and
then failed on the line that attaches it to the GitHub Release:
Revision 3661 created for 'wekan' and released to 'beta', 'candidate',
'edge', and 'stable'
no git remotes found
Error: Process completed with exit code 1
Those jobs flatten history so the Launchpad push stays small, and the git
remote goes with it - so gh had nothing to infer the repository from. The snap
was in the store and not on the release, which reads like a failed build.
Every `gh release upload|view|edit` in every workflow now passes
--repo "${GITHUB_REPOSITORY:-wekan/wekan}", so the call does not depend on what
the checkout looks like, and tests/workflowRepoScripts.test.cjs fails a bare
one.
Thanks to xet7 !
211 lines
9.1 KiB
JavaScript
211 lines
9.1 KiB
JavaScript
'use strict';
|
|
|
|
// A workflow step that runs a script from THIS repository can only run it if the
|
|
// repository is there, at the path that job checked it out to.
|
|
// Run: node tests/workflowRepoScripts.test.cjs
|
|
//
|
|
// The v10.88 release found both halves of that the hard way, in one run:
|
|
//
|
|
// bash: /home/runner/work/wekan/wekan/releases/apt-install.sh: No such file or directory
|
|
// bash: D:\a\wekan\wekan/releases/npm-retry.sh: No such file or directory
|
|
//
|
|
// The first is build-extra-arches, whose "Install dependencies" was the FIRST
|
|
// step of the job - before actions/checkout, which is fine when the step is a
|
|
// plain `apt-get install` and fatal the moment it becomes a repo script. The
|
|
// second is the Windows jobs, which check the repository out to `path: src`, so
|
|
// $GITHUB_WORKSPACE/releases is a directory that does not exist there.
|
|
//
|
|
// Seven jobs failed on it. This suite is the cheap version of finding that out:
|
|
// it reads every workflow and reports a step that calls releases/<something>.sh
|
|
// before its job has a checkout, or through a prefix that does not match where
|
|
// that job put the repository.
|
|
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const repoRoot = path.resolve(__dirname, '..');
|
|
const dir = path.join(repoRoot, '.github/workflows');
|
|
|
|
let passed = 0;
|
|
function test(name, fn) { fn(); passed += 1; console.log(' ok -', name); }
|
|
|
|
console.log('workflowRepoScripts:');
|
|
|
|
// `releases/foo.sh`, `bash "$GITHUB_WORKSPACE/releases/foo.sh"`, `./wekan/releases/foo.sh`.
|
|
// NOT https://…/releases/latest, which is the GitHub API and not a file here.
|
|
const SCRIPT = /(?:^|[\s"'(])((?:[^\s"']*\/)?releases\/[\w./-]+\.(?:sh|mjs|py))/gm;
|
|
|
|
// A line reader rather than a YAML parser: js-yaml is not a dependency of this
|
|
// repo, and what is needed here is only "which steps does this job have, in
|
|
// order, and what does each one run" - which these files spell at fixed indents.
|
|
function jobs() {
|
|
const out = [];
|
|
for (const file of fs.readdirSync(dir).filter(f => /\.ya?ml$/.test(f))) {
|
|
const lines = fs.readFileSync(path.join(dir, file), 'utf8').split('\n');
|
|
let job = null;
|
|
let step = null;
|
|
for (const line of lines) {
|
|
const jobStart = /^ ([A-Za-z0-9_-]+):\s*$/.exec(line);
|
|
if (jobStart && !/^ /.test(line)) {
|
|
job = { file, name: jobStart[1], steps: [] };
|
|
out.push(job);
|
|
step = null;
|
|
continue;
|
|
}
|
|
if (!job) continue;
|
|
if (/^ - /.test(line)) { // a new step
|
|
step = { text: line };
|
|
job.steps.push(step);
|
|
continue;
|
|
}
|
|
// Anything indented deeper belongs to the step that is open.
|
|
if (step && /^ /.test(line)) step.text += '\n' + line;
|
|
else if (/^\S/.test(line)) { job = null; step = null; } // left the jobs block
|
|
}
|
|
}
|
|
return out;
|
|
}
|
|
|
|
const stepName = step => (/- (?:name|uses):\s*(.+)/.exec(step.text) || [, '?'])[1].trim();
|
|
|
|
function checkoutOf(steps) {
|
|
for (let i = 0; i < steps.length; i++) {
|
|
if (/uses:\s*actions\/checkout/.test(steps[i].text)) {
|
|
const m = /\n\s+path:\s*(\S+)/.exec(steps[i].text);
|
|
return { at: i, path: m ? m[1] : null };
|
|
}
|
|
}
|
|
return null;
|
|
}
|
|
|
|
test('no step runs a repo script before its job checks the repo out', () => {
|
|
const bad = [];
|
|
for (const job of jobs()) {
|
|
const co = checkoutOf(job.steps);
|
|
job.steps.forEach((step, i) => {
|
|
const run = step.text;
|
|
if (!SCRIPT.test(run)) { SCRIPT.lastIndex = 0; return; }
|
|
SCRIPT.lastIndex = 0;
|
|
// A URL is not a file: https://api.github.com/repos/wekan/wekan/releases/latest
|
|
const real = run.split('\n').some(l => /(^|[\s"'(])(\.?\/?[\w.${}/-]*\/)?releases\/[\w./-]+\.(sh|mjs|py)/.test(l)
|
|
&& !/https?:\/\//.test(l));
|
|
if (!real) return;
|
|
if (!co || i < co.at) {
|
|
bad.push(`${job.file}:${job.name} step ${i} "${stepName(step)}" `
|
|
+ (co ? `runs a repo script before the checkout at step ${co.at}` : 'runs a repo script and the job never checks out'));
|
|
}
|
|
});
|
|
}
|
|
assert.deepStrictEqual(bad, [],
|
|
'the script is not on disk yet - the step fails with "No such file or directory"');
|
|
});
|
|
|
|
test('a job that checks out to a subdirectory addresses the scripts there', () => {
|
|
// The Windows jobs use `path: src` and the UCS job `path: univention`, because
|
|
// they check out other repositories beside this one. $GITHUB_WORKSPACE is then
|
|
// the PARENT of the checkout, and $GITHUB_WORKSPACE/releases does not exist.
|
|
const bad = [];
|
|
for (const job of jobs()) {
|
|
const co = checkoutOf(job.steps);
|
|
if (!co || !co.path) continue;
|
|
job.steps.forEach((step, i) => {
|
|
const run = step.text;
|
|
if (/\$\{?GITHUB_WORKSPACE\}?\/releases\//.test(run)) {
|
|
bad.push(`${job.file}:${job.name} step ${i} "${stepName(step)}" uses `
|
|
+ `$GITHUB_WORKSPACE/releases but the checkout is at ${co.path}/`);
|
|
}
|
|
});
|
|
}
|
|
assert.deepStrictEqual(bad, [], 'use <checkout path>/releases/... in those jobs');
|
|
});
|
|
|
|
test('the helper scripts the release depends on are executable files here', () => {
|
|
// A path that is right and a file that is missing look the same at runtime.
|
|
const named = new Set();
|
|
for (const job of jobs()) {
|
|
for (const step of job.steps) {
|
|
const run = step.text;
|
|
let m;
|
|
SCRIPT.lastIndex = 0;
|
|
while ((m = SCRIPT.exec(run)) !== null) {
|
|
const p = m[1].replace(/^.*?releases\//, 'releases/');
|
|
if (!/^releases\//.test(p)) continue;
|
|
if (/[${}*]/.test(p)) continue; // built from a variable at runtime
|
|
named.add(p);
|
|
}
|
|
}
|
|
}
|
|
const missing = [...named].filter(p => !fs.existsSync(path.join(repoRoot, p)));
|
|
assert.deepStrictEqual(missing, [], 'a workflow names a script that is not in the repo');
|
|
assert.ok(named.has('releases/apt-install.sh') && named.has('releases/fetch.sh')
|
|
&& named.has('releases/npm-retry.sh'),
|
|
'and the three that wait out an outage are actually used');
|
|
});
|
|
|
|
test('a step that changes directory addresses the scripts absolutely', () => {
|
|
// The Windows jobs check out to `src/` and their bcrypt step does
|
|
// `pushd "$TMP"` before installing - so `bash src/releases/npm-retry.sh`
|
|
// resolved against a temp directory and died with "No such file or
|
|
// directory", twice in one release. The path has to be fixed BEFORE anything
|
|
// moves: SRC="$PWD/src" at the top of the block, then "$SRC/releases/...".
|
|
const bad = [];
|
|
for (const job of jobs()) {
|
|
job.steps.forEach((step, i) => {
|
|
const run = step.text;
|
|
if (!/\b(pushd|cd )\b/.test(run)) return;
|
|
const rel = run.split('\n').filter(l =>
|
|
/(^|[\s"'])(src|univention|wekan)\/releases\/[\w.-]+\.(sh|mjs|py)/.test(l)
|
|
&& !/\$\{?(SRC|UNIV|GITHUB_WORKSPACE|PWD)/.test(l));
|
|
if (rel.length) {
|
|
bad.push(`${job.file}:${job.name} step ${i} "${stepName(step)}": ${rel[0].trim().slice(0, 60)}`);
|
|
}
|
|
});
|
|
}
|
|
assert.deepStrictEqual(bad, [],
|
|
'a relative path stops resolving the moment the step changes directory');
|
|
});
|
|
|
|
test('the snap build and the Sandstorm deps download through fetch.sh too', () => {
|
|
// Both are outside the workflows and both lost a v10.89 job to a 503: the
|
|
// caddy part ("curl: (56) Connection died"), and build-deps.sh at "[4/7]
|
|
// FerretDB v1". The snap build has the project mounted, so it can reach the
|
|
// same helper the jobs use.
|
|
const snapcraft = fs.readFileSync(path.join(repoRoot, 'snapcraft.yaml'), 'utf8');
|
|
assert.ok(/CRAFT_PROJECT_DIR[^\n]*releases\/fetch\.sh/.test(snapcraft),
|
|
'snapcraft parts call releases/fetch.sh through the project directory');
|
|
for (const what of ['caddy.tar.gz', 'mongodb.tgz']) {
|
|
const line = snapcraft.split('\n').find(l => l.includes(what) && /curl|wget|fetch\.sh/.test(l));
|
|
assert.ok(/fetch\.sh/.test(line || ''), `${what} must not be a bare download: ${line}`);
|
|
}
|
|
const deps = fs.readFileSync(path.join(repoRoot, 'sandstorm-src/build-deps.sh'), 'utf8');
|
|
assert.ok(/FETCH=/.test(deps) && !/curl -fsSL "\$FERRETDB_URL"/.test(deps),
|
|
'build-deps.sh downloads through fetch.sh');
|
|
});
|
|
|
|
test('every gh release call names the repository', () => {
|
|
// The snap-launchpad jobs flatten history for the Launchpad push, and the git
|
|
// remote goes with it. gh then has nothing to infer from:
|
|
//
|
|
// Revision 3661 created for 'wekan' and released to 'beta', ... 'stable'
|
|
// no git remotes found
|
|
// Error: Process completed with exit code 1
|
|
//
|
|
// - a job that failed AFTER publishing the snap, on the line that attaches it
|
|
// to the GitHub Release. --repo makes the call independent of the checkout.
|
|
const workflows = fs.readdirSync(dir).filter(f => /\.ya?ml$/.test(f));
|
|
const bad = [];
|
|
for (const file of workflows) {
|
|
const text = fs.readFileSync(path.join(dir, file), 'utf8');
|
|
text.split('\n').forEach((line, i) => {
|
|
if (!/gh release (upload|view|edit|create|delete-asset)/.test(line)) return;
|
|
if (/--repo/.test(line)) return;
|
|
if (/^\s*#/.test(line)) return; // a comment quoting the command
|
|
bad.push(`${file}:${i + 1}: ${line.trim().slice(0, 70)}`);
|
|
});
|
|
}
|
|
assert.deepStrictEqual(bad, [],
|
|
'gh needs --repo when the checkout has no remote');
|
|
});
|
|
|
|
console.log(`\nworkflowRepoScripts: ${passed} tests passed`);
|