mirror of
https://github.com/wekan/wekan.git
synced 2026-11-20 14:45:01 -05:00
Three things, as asked. NO DUPLICATE BOARD NAME. The second bar drew the board's title in an `h1` of its own, under the same name in the bar above it. The first bar has said it since the first step of this work; the h1 is gone. THE PENCIL IS BESIDE THE NAME. Renaming a board belongs next to the board's name, not in a bar of its own, so `boardEditTitleButton` renders immediately right of the title in the first bar. Board admins only, as before. EVERYTHING ELSE IS AN ICON, LEFT OF THE BELL. Visibility, watch, star, sort, the board's rule buttons, filter, search, dependencies and Multi-Selection, each named by a tooltip and none carrying a visible label. The bar is one row shared with the logo, the starred boards, the view menu, the bell and the user menu; ten labelled buttons do not fit at any width. The desktop/mobile duplication went with it. The old bar wrote the whole set out TWICE - `unless isMiniScreen` and `if isMiniScreen` - because a row of labelled buttons does not fit on a phone. Icons do, so one copy serves both, and the two switches that had to be kept in step are gone rather than kept in step. headerBarControls.jade is deleted. It held one Search button and one Multi-Selection button, written for this bar and All Boards'; both bars are gone now, so a template shared by nobody was indirection rather than sharing. Every route reference goes with the bar: config/router.js names no headerBar at all any more. Six guards followed, and four of them existed only to measure this bar: the title-plus-buttons row that a long board title split across two lines, the wrapper that fixed it, the phone layout, and the hamburger that shared the first row with the title. All of that was one problem, and the problem is gone with the row. Each says so where it used to measure it, rather than being deleted. Thanks to xet7 !
71 lines
3.2 KiB
JavaScript
71 lines
3.2 KiB
JavaScript
'use strict';
|
|
|
|
// The All Boards Multi-Selection button should look the same as in the Swimlanes
|
|
// View (board header): an icon + a text label, with the reset X nested inside the
|
|
// button. This guards that parity and that the nested reset stops event propagation
|
|
// (otherwise the click bubbles to the activate handler and re-enables it).
|
|
//
|
|
// Run: node tests/multiSelectionButton.test.cjs
|
|
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const repoRoot = path.resolve(__dirname, '..');
|
|
const read = rel => fs.readFileSync(path.join(repoRoot, rel), 'utf8');
|
|
|
|
let passed = 0;
|
|
function test(name, fn) {
|
|
fn();
|
|
passed += 1;
|
|
console.log(' ok -', name);
|
|
}
|
|
|
|
// The Multi-Selection button was a shared template for two header bars. Both
|
|
// bars are gone: All Boards offers Multi-Selection as a sidebar row, and the
|
|
// board draws it as an icon in the first header bar. A template shared by
|
|
// nobody is not shared, so it was folded back into the one place that draws it.
|
|
|
|
test('the board draws Multi-Selection as an icon, once', () => {
|
|
const header = read('client/components/boards/boardHeader.jade');
|
|
const buttons = header.slice(header.indexOf('template(name="boardHeaderButtons")'),
|
|
header.indexOf('template(name="boardVisibilityList")'));
|
|
assert.ok(/js-multiselection-activate/.test(buttons), 'the board has the control');
|
|
assert.strictEqual((buttons.match(/js-multiselection-activate/g) || []).length, 1,
|
|
'written once - there is no desktop/mobile copy any more');
|
|
|
|
// Icon only, named by a tooltip: the first bar is one row shared with a great
|
|
// deal else, and these are ten controls.
|
|
assert.ok(/i\.fa\.fa-check-square-o/.test(buttons), 'the check-square glyph');
|
|
assert.ok(/title="\{\{#if MultiSelection\.isActive\}\}/.test(buttons),
|
|
'and a tooltip that says which way it goes');
|
|
assert.ok(!/span \{\{#if MultiSelection\.isActive\}\}/.test(buttons),
|
|
'with no visible label');
|
|
|
|
// Its ✕ says what it does, and turns Multi-Selection off.
|
|
assert.ok(/js-multiselection-reset\(title="\{\{_ 'multi-selection-off'\}\}"\)/.test(buttons),
|
|
'the reset is named for what it does');
|
|
|
|
// All Boards offers the same control as a sidebar row instead.
|
|
assert.ok(/js-all-boards-sidebar-multiselection/.test(
|
|
read('client/components/boards/allBoardsSidebar.jade')),
|
|
'All Boards has it as a sidebar row');
|
|
assert.ok(!fs.existsSync(path.join(repoRoot, 'client/components/boards/headerBarControls.jade')),
|
|
'and the shared template is gone, having no users left');
|
|
});
|
|
|
|
test('the nested reset stops propagation so it does not re-activate', () => {
|
|
// One handler per page, each on the bar that renders its copy: a Blaze event
|
|
// map catches events from the templates inside it.
|
|
for (const js of ['client/components/boards/boardsList.js',
|
|
'client/components/boards/boardHeader.js']) {
|
|
const src = read(js);
|
|
const i = src.indexOf("'click .js-multiselection-reset'");
|
|
assert.notStrictEqual(i, -1, `${js} must handle the reset`);
|
|
assert.ok(/stopPropagation\(\)/.test(src.slice(i, i + 400)),
|
|
`${js}: reset must not bubble to activate`);
|
|
}
|
|
});
|
|
|
|
console.log(`\nAll ${passed} multi-selection button tests passed`);
|