mirror of
https://github.com/wekan/wekan.git
synced 2026-11-20 21:45:01 -05:00
A feature's guide now sits under the menu it is used from, read from the templates rather than from where somebody once put it: Header-Bar, All-Boards, Pages, Board-Header (search and every Board View), Board-Sidebar (Board Settings, Filter, Members, Labels, Archive), Rules, Swimlanes, Lists, Cards, Member-Settings, Admin-Panel and Login-Page. Topics used from several menus (editor, history, theme, translations, email, troubleshooting) are in General. - Each area has a README mapping its menu entries to their guides and to the template or server module that implements them. Board-Header/README.md lists all 40 Board View entries with the template boardBody.jade renders; five views (Table, Calendar Mode, Time, Timeline, Map) have no guide of their own yet and say so. - Board-View.md listed 25 views while BOARD_VIEWS has 40; it now lists all of them with their English labels. - Pages keep their file names. Where a released changelog links an old path, a "# Moved" page stays there and points to the new one; test-menu.sh skips folders holding only those. - Undo was filed under Login; it is General/Undo now. - Every link in docs, code comments, scripts and tests follows the move; docsLinksResolve checks them all. Tests that read a doc follow it to its new place. boardViewSettings now fails when Board-View.md or Board-Header/README.md differs from BOARD_VIEWS, or names a template boardBody.jade does not render. Thanks to xet7 !
219 lines
8.7 KiB
JavaScript
219 lines
8.7 KiB
JavaScript
'use strict';
|
|
|
|
// Plain-Node unit test (no Meteor) for LDAP_ENCRYPTION value normalization.
|
|
// Run: node tests/ldapEncryptionSetting.test.cjs
|
|
//
|
|
// Regression guard for #4158 ("Documentation/configuration of
|
|
// LDAP_ENCRYPTION"). Historically only the magic strings 'ssl' (= LDAPS) and
|
|
// 'tls' (= STARTTLS) did anything; the DOCUMENTED value 'true' was silently
|
|
// ignored (settings_get() JSON-parses it into boolean true, which matched
|
|
// neither string), and any typo/unknown value silently meant "no encryption".
|
|
//
|
|
// normalizeLdapEncryption(value) must:
|
|
// - map 'true'/boolean true -> LDAPS ('tls' mode);
|
|
// - keep the legacy values working with their HISTORICAL meaning
|
|
// ('ssl' -> LDAPS, 'tls' -> STARTTLS) plus a one-line deprecation notice
|
|
// naming the preferred value;
|
|
// - map 'starttls' -> STARTTLS;
|
|
// - map 'false'/''/unset/boolean false -> no encryption, no warning;
|
|
// - map anything else -> no encryption WITH a clear warning listing the
|
|
// accepted values (never silently treat an unknown value as enabled).
|
|
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const {
|
|
normalizeLdapEncryption,
|
|
} = require('../packages/wekan-ldap/server/encryptionSetting');
|
|
|
|
let passed = 0;
|
|
function test(name, fn) {
|
|
fn();
|
|
passed += 1;
|
|
console.log(' ok -', name);
|
|
}
|
|
|
|
// --- POSITIVE: LDAPS (immediate TLS) -----------------------------------------
|
|
|
|
test("'true' means LDAPS, no warning", () => {
|
|
const r = normalizeLdapEncryption('true');
|
|
assert.strictEqual(r.mode, 'tls');
|
|
assert.strictEqual(r.warning, undefined);
|
|
});
|
|
|
|
test('boolean true (settings_get JSON-parses the env string) means LDAPS', () => {
|
|
// ldap.js settings_get() turns the env string 'true' into boolean true;
|
|
// this is exactly the value that used to be silently ignored (#4158).
|
|
const r = normalizeLdapEncryption(true);
|
|
assert.strictEqual(r.mode, 'tls');
|
|
assert.strictEqual(r.warning, undefined);
|
|
});
|
|
|
|
test("'TRUE' (any case) means LDAPS", () => {
|
|
assert.strictEqual(normalizeLdapEncryption('TRUE').mode, 'tls');
|
|
assert.strictEqual(normalizeLdapEncryption('True').mode, 'tls');
|
|
});
|
|
|
|
test("legacy 'ssl' still means LDAPS (backwards compatible)", () => {
|
|
const r = normalizeLdapEncryption('ssl');
|
|
assert.strictEqual(r.mode, 'tls');
|
|
});
|
|
|
|
test("legacy 'ssl' logs a deprecation notice naming 'true'", () => {
|
|
const r = normalizeLdapEncryption('ssl');
|
|
assert.ok(typeof r.warning === 'string' && r.warning.length > 0);
|
|
assert.ok(r.warning.includes("'true'"), 'must name the preferred value');
|
|
assert.ok(/deprecat/i.test(r.warning), 'must say it is deprecated');
|
|
});
|
|
|
|
test("legacy 'SSL' (any case) still means LDAPS", () => {
|
|
const r = normalizeLdapEncryption('SSL');
|
|
assert.strictEqual(r.mode, 'tls');
|
|
assert.ok(r.warning, 'still deprecated regardless of case');
|
|
});
|
|
|
|
// --- POSITIVE: STARTTLS ------------------------------------------------------
|
|
|
|
test("'starttls' means STARTTLS, no warning", () => {
|
|
const r = normalizeLdapEncryption('starttls');
|
|
assert.strictEqual(r.mode, 'starttls');
|
|
assert.strictEqual(r.warning, undefined);
|
|
});
|
|
|
|
test("'StartTLS' (any case) means STARTTLS", () => {
|
|
assert.strictEqual(normalizeLdapEncryption('StartTLS').mode, 'starttls');
|
|
assert.strictEqual(normalizeLdapEncryption('STARTTLS').mode, 'starttls');
|
|
});
|
|
|
|
test("legacy 'tls' still means STARTTLS (its historical behavior)", () => {
|
|
// Backwards compatibility: 'tls' has ALWAYS meant STARTTLS in WeKan.
|
|
// Remapping it to LDAPS would break every existing STARTTLS setup.
|
|
const r = normalizeLdapEncryption('tls');
|
|
assert.strictEqual(r.mode, 'starttls');
|
|
});
|
|
|
|
test("legacy 'tls' logs a deprecation notice naming 'starttls'", () => {
|
|
const r = normalizeLdapEncryption('tls');
|
|
assert.ok(typeof r.warning === 'string' && r.warning.length > 0);
|
|
assert.ok(r.warning.includes("'starttls'"), 'must name the preferred value');
|
|
assert.ok(/deprecat/i.test(r.warning), 'must say it is deprecated');
|
|
});
|
|
|
|
// --- POSITIVE: no encryption -------------------------------------------------
|
|
|
|
test("'false' means no encryption, no warning", () => {
|
|
const r = normalizeLdapEncryption('false');
|
|
assert.strictEqual(r.mode, 'off');
|
|
assert.strictEqual(r.warning, undefined);
|
|
});
|
|
|
|
test('boolean false (settings_get JSON-parses the env string) means no encryption', () => {
|
|
const r = normalizeLdapEncryption(false);
|
|
assert.strictEqual(r.mode, 'off');
|
|
assert.strictEqual(r.warning, undefined);
|
|
});
|
|
|
|
test('empty string means no encryption, no warning', () => {
|
|
const r = normalizeLdapEncryption('');
|
|
assert.strictEqual(r.mode, 'off');
|
|
assert.strictEqual(r.warning, undefined);
|
|
});
|
|
|
|
test('unset (undefined) means no encryption, no warning', () => {
|
|
const r = normalizeLdapEncryption(undefined);
|
|
assert.strictEqual(r.mode, 'off');
|
|
assert.strictEqual(r.warning, undefined);
|
|
});
|
|
|
|
test('null means no encryption, no warning', () => {
|
|
const r = normalizeLdapEncryption(null);
|
|
assert.strictEqual(r.mode, 'off');
|
|
assert.strictEqual(r.warning, undefined);
|
|
});
|
|
|
|
test('surrounding whitespace is tolerated', () => {
|
|
assert.strictEqual(normalizeLdapEncryption(' true ').mode, 'tls');
|
|
assert.strictEqual(normalizeLdapEncryption(' starttls ').mode, 'starttls');
|
|
assert.strictEqual(normalizeLdapEncryption(' false ').mode, 'off');
|
|
});
|
|
|
|
// --- NEGATIVE: unknown values must warn, never silently enable/disable -------
|
|
|
|
test('NEGATIVE: unknown value means no encryption plus a clear warning', () => {
|
|
const r = normalizeLdapEncryption('bogus');
|
|
assert.strictEqual(r.mode, 'off');
|
|
assert.ok(typeof r.warning === 'string' && r.warning.length > 0,
|
|
'unknown values must warn, never fail silently');
|
|
assert.ok(r.warning.includes("'bogus'"), 'warning must echo the bad value');
|
|
});
|
|
|
|
test('NEGATIVE: the warning for unknown values lists all accepted values', () => {
|
|
const w = normalizeLdapEncryption('yes').warning;
|
|
assert.ok(w.includes("'true'"), "must list 'true'");
|
|
assert.ok(w.includes("'starttls'"), "must list 'starttls'");
|
|
assert.ok(w.includes("'false'"), "must list 'false'");
|
|
assert.ok(w.includes("'ssl'"), "must mention legacy 'ssl'");
|
|
assert.ok(w.includes("'tls'"), "must mention legacy 'tls'");
|
|
});
|
|
|
|
test('NEGATIVE: unknown value is never treated as encryption enabled', () => {
|
|
for (const bad of ['yes', 'on', '1', 'ldaps', 'sttarttls', 'enable', 'TLSv1.2']) {
|
|
const r = normalizeLdapEncryption(bad);
|
|
assert.strictEqual(r.mode, 'off', `'${bad}' must not silently enable encryption`);
|
|
assert.ok(r.warning, `'${bad}' must produce a warning`);
|
|
}
|
|
});
|
|
|
|
test('NEGATIVE: numeric values (settings_get converts digits) warn and stay off', () => {
|
|
// settings_get() turns '1'/'0' into Numbers; neither is a valid setting.
|
|
for (const bad of [1, 0]) {
|
|
const r = normalizeLdapEncryption(bad);
|
|
assert.strictEqual(r.mode, 'off');
|
|
assert.ok(r.warning, `${bad} must produce a warning`);
|
|
}
|
|
});
|
|
|
|
test("NEGATIVE: 'starttls' must NOT map to LDAPS and 'true' must NOT map to STARTTLS", () => {
|
|
assert.notStrictEqual(normalizeLdapEncryption('starttls').mode, 'tls');
|
|
assert.notStrictEqual(normalizeLdapEncryption('true').mode, 'starttls');
|
|
});
|
|
|
|
test('NEGATIVE: valid values never carry the invalid-value warning', () => {
|
|
for (const good of ['true', 'starttls', 'false', '', undefined, true, false]) {
|
|
const r = normalizeLdapEncryption(good);
|
|
assert.strictEqual(r.warning, undefined,
|
|
`'${good}' is valid and must not warn`);
|
|
}
|
|
});
|
|
|
|
test('#4158 wiring uses normalized LDAPS and STARTTLS modes', () => {
|
|
const source = fs.readFileSync(path.join(
|
|
__dirname, '..', 'packages', 'wekan-ldap', 'server', 'ldap.js',
|
|
), 'utf8');
|
|
assert.match(source, /encryption\s*:\s*normalizeLdapEncryption\(/);
|
|
assert.match(source, /if \(this\.options\.encryption === 'tls'\) \{\s*url = `ldaps:\/\//);
|
|
assert.match(source, /if \(this\.options\.encryption === 'starttls'\) \{[\s\S]*client\.startTLS/);
|
|
});
|
|
|
|
test('#4158 wiring logs normalization warnings instead of failing silently', () => {
|
|
const source = fs.readFileSync(path.join(
|
|
__dirname, '..', 'packages', 'wekan-ldap', 'server', 'ldap.js',
|
|
), 'utf8');
|
|
assert.match(source, /warnOnceAboutEncryption\(\s*normalizeLdapEncryption/);
|
|
assert.match(source, /Log\.warn\(warning\)/);
|
|
});
|
|
|
|
test('#4158 documentation names all preferred modes without the false security claim', () => {
|
|
const documentation = fs.readFileSync(path.join(
|
|
__dirname, '..', 'docs', 'Features', 'Login-Page', 'LDAP.md',
|
|
), 'utf8');
|
|
assert.match(documentation, /`LDAP_ENCRYPTION`/);
|
|
assert.match(documentation, /`true`[^\n]*LDAPS/);
|
|
assert.match(documentation, /`starttls`[^\n]*STARTTLS/);
|
|
assert.match(documentation, /`false`[^\n]*unencrypted/);
|
|
assert.match(documentation, /ldap-encryption='starttls'/);
|
|
assert.doesNotMatch(documentation, /STARTTLS is more secure than (?:standard )?LDAPS/i);
|
|
});
|
|
|
|
console.log(`\n${passed} tests passed`);
|