Files
wekan/tests/editCardWebhook.test.cjs
T
Lauri Ojansivu b01c233269 Moving a card with an outgoing webhook no longer counts as HookBleed or disables the mover's account.
The activity hook delivered webhooks through Meteor.call('outgoingWebhooks'),
and that method trusted a call without this.connection as the server's own.
Meteor gives a server-side Meteor.call the userId AND connection of the method
it runs in (ddp-server applyAsync), and a card moved from a browser runs in
that browser's method. So the server's own act-moveCard delivery arrived as a
client forging one: it was recorded as ssrf.webhook-forge (high) with the
mover's userId, and blockOnSecurityEvent set loginDisabled.

- deliverActivityWebhook() in server/notifications/outgoing.js is the server's
  delivery: a function, not a method, so no client reaches it and no inherited
  context changes it. It reads the integration again (enabled) and names the
  activity's actor. server/models/activities.js calls it through safeDeliver.
- The outgoingWebhooks method treats every call as a client's: only the
  card-opened notification, rebuilt from the card, as before for clients.
- Server deliveries no longer need the actor to be a member of the hook's
  board, which also skipped a global webhook ('_global' is no board) and an
  activity with no method behind it (REST, timers).
- securityLog.record() now passes the catalog key and blocksAccount to the
  block decision. The stored row carries neither, so every 'high' blocked row
  disabled whoever it named: a hook refused for its own internal address
  disabled the mover too, and ssrf.redirect/ssrf.attachment's
  blocksAccount: false never applied. ssrf.webhook is now blocksAccount:
  false - the person whose move sent it did not write the hook's URL.

tests/hookBleedServerDelivery.test.cjs: the move delivered with nothing
logged, in an inherited context too; a forged call still refused, logged and
blocking; the card-opened notification; failing and internal hooks blocking
nobody, through record() itself; and a whole-tree scan that no server code
calls a this.connection-gated method from inside a client's method without
clearing the invocation. tests/playwright/specs/hook-bleed.e2e.js moves a
card through the Move dialog with a webhook enabled.

Thanks to do4me and xet7 !

Fixes #6782.
2026-10-18 14:28:19 +03:00

67 lines
4.2 KiB
JavaScript

'use strict';
// #4912: `act-editCard` is an opt-in alternative to the per-field edit events,
// decided on 2026-10-02. One delivery per webhook per activity, always.
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const {
EDIT_CARD_EVENT, webhookActivitySelection, webhookDescriptionFor, webhookParamsFor,
} = require('../models/lib/editCardWebhook');
const ROOT = path.join(__dirname, '..');
const read = file => fs.readFileSync(path.join(ROOT, file), 'utf8');
const hook = activities => ({ activities });
// Positive: a webhook that names act-editCard gets it for title and
// description edits, with the field that changed.
assert.equal(webhookDescriptionFor(hook([EDIT_CARD_EVENT]), 'act-a-changedTitle'), EDIT_CARD_EVENT);
assert.equal(webhookDescriptionFor(hook([EDIT_CARD_EVENT, 'act-createCard']), 'act-a-changedDescription'), EDIT_CARD_EVENT);
assert.deepEqual(webhookParamsFor({ cardId: 'c' }, 'act-a-changedTitle', EDIT_CARD_EVENT), { cardId: 'c', field: 'title' });
assert.deepEqual(webhookParamsFor({ cardId: 'c' }, 'act-a-changedDescription', EDIT_CARD_EVENT),
{ cardId: 'c', field: 'description' });
assert.deepEqual(webhookActivitySelection('act-a-changedTitle'), ['act-a-changedTitle', 'all', EDIT_CARD_EVENT]);
// Negative: nothing changes for a webhook that did not opt in, and an
// existing receiver never gets the edit twice.
assert.equal(webhookDescriptionFor(hook(['all']), 'act-a-changedTitle'), 'act-a-changedTitle');
assert.equal(webhookDescriptionFor(hook(['act-a-changedTitle']), 'act-a-changedTitle'), 'act-a-changedTitle');
assert.equal(webhookDescriptionFor(hook(['all', EDIT_CARD_EVENT]), 'act-a-changedTitle'), 'act-a-changedTitle');
assert.equal(webhookDescriptionFor(hook(['act-a-changedTitle', EDIT_CARD_EVENT]), 'act-a-changedTitle'),
'act-a-changedTitle');
assert.equal(webhookDescriptionFor(hook(undefined), 'act-a-changedTitle'), 'act-a-changedTitle');
// Other activities never become act-editCard and never select its subscribers.
assert.equal(webhookDescriptionFor(hook([EDIT_CARD_EVENT]), 'act-moveCard'), 'act-moveCard');
assert.deepEqual(webhookActivitySelection('act-moveCard'), ['act-moveCard', 'all']);
const params = { cardId: 'c' };
assert.equal(webhookParamsFor(params, 'act-a-changedTitle', 'act-a-changedTitle'), params);
// Negative, tree-wide: every place that selects or renders activity webhooks
// uses the shared choice, so no path can deliver the per-field event to an
// opted-in webhook, or select webhooks without the opt-in.
const activities = read('server/models/activities.js');
assert.ok(!/activities:\s*\{\s*\$in:\s*\[description,\s*'all'\]/.test(activities),
'webhook selection must go through webhookActivitySelection');
assert.match(activities, /deliverActivityWebhook\(integration, delivered, deliveredParams/);
const prepare = read('server/notifications/prepareWebhooks.js');
assert.match(prepare, /webhookDescriptionFor\(integration, context\.description\)/);
assert.ok(!/description:\s*context\.description/.test(prepare), 'the stored plan renders the per-webhook event');
for (const dir of ['server', 'models']) {
const walk = d => fs.readdirSync(d, { withFileTypes: true }).flatMap(e =>
e.isDirectory() ? (e.name === 'tests' ? [] : walk(path.join(d, e.name))) : [path.join(d, e.name)]);
for (const file of walk(path.join(ROOT, dir)).filter(f => f.endsWith('.js'))) {
const src = fs.readFileSync(file, 'utf8');
if (/activityWebhookIntegrations\(/.test(src) && !/export async function activityWebhookIntegrations/.test(src)) {
assert.match(src, /webhookDescriptionFor/, `${path.relative(ROOT, file)} selects webhooks without the act-editCard choice`);
}
}
}
// The one-way payload names the field; the event has English text.
// #3695: the one-way body is built by models/lib/webhookPayload.js now, for
// every payload setting; the edit event's `field` is still always added.
assert.match(read('models/lib/webhookPayload.js'), /description === 'act-editCard'.*value\.field = params\.field/);
assert.match(read('server/notifications/outgoing.js'), /buildWebhookBody\(\{/);
const en = JSON.parse(read('imports/i18n/data/en.i18n.json'));
assert.match(en['act-editCard'], /__card__/);
console.log('editCardWebhook: ok');