models/lib/cardBoardConsistency.js and models/lib/restArrayParam.js are
CommonJS (module.exports), but being under models/ they were eagerly bundled
into the client by rspack, which classifies a no-import/require .js as an ES
module and threw at load time:
Uncaught Error: ES Modules may not assign module.exports or exports.*
... ./models/lib/cardBoardConsistency.js -> ./models/cards.js
This aborted the client bundle on every page. (filenameSanitizer.js uses the
same module.exports pattern without issue only because it is never imported
into the client bundle.)
Both helpers are server-only logic (a REST handler and a Cards.before.update
hook), so they are moved to server/lib/ (excluded from the client rspack
bundle, CommonJS is fine on the Node server) and enforceCardBoardConsistency
is relocated from the isomorphic models/cards.js into server/models/cards.js.
The isomorphic models/cards.js no longer imports either helper.
Verified in a real headless Chromium against a running dev server: the page
now loads with window.Meteor present and zero console/page errors (previously
one PAGEERROR from cardBoardConsistency.js). Node unit tests updated to the new
paths and pass (npm run test:unit:node, 11 passing).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Clearing a card's members/assignees over the REST API left the field
uneditable in the UI. The card PUT handler guarded with `if (req.body.members)`
— falsy for the natural clear payloads (null and "") — so removing the last
member was a silent no-op, and its string branch wrote null instead of [];
a card with members:null then breaks UI code that treats it as an array.
The handler now uses an `!== undefined` guard plus a shared coercion helper so
any clear payload (null / "" / []) stores a clean String[] (never null), a
single id is wrapped into an array, and stray non-string entries are dropped.
getMembers()/getAssignees() also coerce a legacy null to [] on read, healing
existing corrupted documents.
Pure logic in models/lib/restArrayParam.js with a Meteor-free Node unit test
(tests/restArrayParam.test.cjs, incl. a negative test reproducing the old
null-writing logic) wired into `npm run test:unit:node`, plus a REST regression
in tests/playwright/specs/17-rest-api.e2e.js. Changelog: documents #3697 and
moves #2292 (archive-swimlane) to verified-resolved (archive() does not delete
cards; restore brings them back).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Lauri OjansivuandClaude Opus 4.8