This is a reland of commit ac7c47e253
One wrong DCHECK was fixed.
Original change's description:
> [base,heap] Record thread stack start at thread entry
>
> On Linux, pthread_attr_getstack returns the base and size of the
> thread's entire mmap allocation, where glibc places static TLS and the
> TCB at the top of the region. This causes conservative stack scanning
> on worker threads to scan TLS, leading to false positives and possible
> crashes during heap verification.
>
> This CL:
>
> 1. Introduces and exposes cppgc::StackStartScope (aliased as
> v8::StackStartScope) for embedder threads and uses it in LocalHeap
> for background threads. This will replace cppgc::StackStartMarker in
> follow-up CLs.
> 2. Introduces methods in base::Stack for setting and resetting a custom
> stack start (used at v8::base::Thread entry and by StackStartScope),
> along with Stack::GetEffectiveStackStart which returns the effective
> stack start (overridden or not) for Heap and CppHeap.
> 3. Introduces base::Stack::ValidateStackSegment to check stack segment
> bounds and, when marking verification is enabled, ensure that stack
> segments do not contain TLS data.
>
> Design doc: https://docs.google.com/document/d/10d8E1MlLwSrrII5TuC10HsLCulfWzh02Kouy7W7-6nc
>
> TAG=agy
> CONV=3c50cafd-8b7d-4358-b569-9070d961402f
>
> Bug: 540324230
> Change-Id: I62faeffdcbd0bae0bdd966d8fe35494a33d382df
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8380481
> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org>
> Reviewed-by: Omer Katz <omerkatz@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#110891}
Bug: 540324230
Bug: 41480448
Change-Id: Ie068fe129eb496a0ea43fcb1f7da78ed9e4b5362
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8605449
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110928}
220 lines
6.9 KiB
C++
220 lines
6.9 KiB
C++
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef INCLUDE_V8_CPPGC_H_
|
|
#define INCLUDE_V8_CPPGC_H_
|
|
|
|
#include <cstdint>
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
#include "cppgc/common.h"
|
|
#include "cppgc/custom-space.h"
|
|
#include "cppgc/heap-statistics.h"
|
|
#include "cppgc/visitor.h"
|
|
#include "v8-internal.h" // NOLINT(build/include_directory)
|
|
#include "v8-platform.h" // NOLINT(build/include_directory)
|
|
#include "v8-traced-handle.h" // NOLINT(build/include_directory)
|
|
|
|
namespace cppgc {
|
|
class AllocationHandle;
|
|
class AllocationSampler;
|
|
class HeapHandle;
|
|
} // namespace cppgc
|
|
|
|
namespace v8 {
|
|
|
|
class Object;
|
|
|
|
namespace internal {
|
|
class CppHeap;
|
|
} // namespace internal
|
|
|
|
class CustomSpaceStatisticsReceiver;
|
|
|
|
struct V8_EXPORT CppHeapCreateParams {
|
|
explicit CppHeapCreateParams(
|
|
std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces)
|
|
: custom_spaces(std::move(custom_spaces)) {}
|
|
|
|
CppHeapCreateParams(const CppHeapCreateParams&) = delete;
|
|
CppHeapCreateParams& operator=(const CppHeapCreateParams&) = delete;
|
|
|
|
std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces;
|
|
/**
|
|
* Specifies which kind of marking are supported by the heap. The type may be
|
|
* further reduced via runtime flags when attaching the heap to an Isolate.
|
|
*/
|
|
cppgc::Heap::MarkingType marking_support =
|
|
cppgc::Heap::MarkingType::kIncrementalAndConcurrent;
|
|
/**
|
|
* Specifies which kind of sweeping is supported by the heap. The type may be
|
|
* further reduced via runtime flags when attaching the heap to an Isolate.
|
|
*/
|
|
cppgc::Heap::SweepingType sweeping_support =
|
|
cppgc::Heap::SweepingType::kIncrementalAndConcurrent;
|
|
/**
|
|
* Optional marker representing the stack start of the thread creating the
|
|
* heap.
|
|
* TODO(540324230): Remove once embedders migrate to StackStartScope.
|
|
*/
|
|
V8_DEPRECATE_SOON("Use StackStartScope instead.")
|
|
std::optional<cppgc::StackStartMarker> stack_start_marker = std::nullopt;
|
|
/**
|
|
* Optional allocation sampler.
|
|
*/
|
|
cppgc::AllocationSampler* allocation_sampler = nullptr;
|
|
};
|
|
|
|
/**
|
|
* A heap for allocating managed C++ objects.
|
|
*
|
|
* Similar to v8::Isolate, the heap may only be accessed from one thread at a
|
|
* time. The heap may be used from different threads using the
|
|
* v8::Locker/v8::Unlocker APIs which is different from generic Oilpan.
|
|
*/
|
|
class V8_EXPORT CppHeap {
|
|
public:
|
|
static std::unique_ptr<CppHeap> Create(v8::Platform* platform,
|
|
const CppHeapCreateParams& params);
|
|
|
|
virtual ~CppHeap() = default;
|
|
|
|
/**
|
|
* \returns the opaque handle for allocating objects using
|
|
* `MakeGarbageCollected()`.
|
|
*/
|
|
cppgc::AllocationHandle& GetAllocationHandle();
|
|
|
|
/**
|
|
* \returns the opaque heap handle which may be used to refer to this heap in
|
|
* other APIs. Valid as long as the underlying `CppHeap` is alive.
|
|
*/
|
|
cppgc::HeapHandle& GetHeapHandle();
|
|
|
|
/**
|
|
* \param detail_level specifies whether should return detailed
|
|
* statistics or only brief summary statistics.
|
|
* \returns current CppHeap statistics regarding memory consumption
|
|
* and utilization.
|
|
*/
|
|
cppgc::HeapStatistics CollectStatistics(
|
|
cppgc::HeapStatistics::DetailLevel detail_level);
|
|
|
|
/**
|
|
* Collects statistics for the given spaces and reports them to the receiver.
|
|
*
|
|
* \param custom_spaces a collection of custom space indices.
|
|
* \param receiver an object that gets the results.
|
|
*/
|
|
void CollectCustomSpaceStatisticsAtLastGC(
|
|
std::vector<cppgc::CustomSpaceIndex> custom_spaces,
|
|
std::unique_ptr<CustomSpaceStatisticsReceiver> receiver);
|
|
|
|
/**
|
|
* Enables a detached mode that allows testing garbage collection using
|
|
* `cppgc::testing` APIs. Once used, the heap cannot be attached to an
|
|
* `Isolate` anymore.
|
|
*/
|
|
void EnableDetachedGarbageCollectionsForTesting();
|
|
|
|
/**
|
|
* Performs a stop-the-world garbage collection for testing purposes.
|
|
*
|
|
* \param stack_state The stack state to assume for the garbage collection.
|
|
*/
|
|
void CollectGarbageForTesting(cppgc::EmbedderStackState stack_state);
|
|
|
|
/**
|
|
* Performs a stop-the-world minor garbage collection for testing purposes.
|
|
*
|
|
* \param stack_state The stack state to assume for the garbage collection.
|
|
*/
|
|
void CollectGarbageInYoungGenerationForTesting(
|
|
cppgc::EmbedderStackState stack_state);
|
|
|
|
/**
|
|
* Controls whether forced garbage collections sweep atomically.
|
|
*
|
|
* A forced garbage collection (including
|
|
* `Isolate::RequestGarbageCollectionForTesting()`) normally sweeps
|
|
* atomically, so finalizers have already run by the time the collection
|
|
* returns. When this is enabled, forced collections instead sweep according
|
|
* to the heap's sweeping support, leaving finalization deferred as it would
|
|
* be in a natural garbage collection. This lets a test observe an object in
|
|
* the window between being discovered unreachable and being finalized.
|
|
*
|
|
* Note that sweeping may then be concurrent; pass `--single-threaded-gc` for
|
|
* sweeping that only makes progress on the main thread, and use
|
|
* `FinishSweepingForTesting()` to close the window deterministically.
|
|
*/
|
|
void SetForceIncrementalSweepingForTesting(bool value);
|
|
|
|
/**
|
|
* Finishes any in-progress sweeping, running the finalizers it discovers.
|
|
*/
|
|
void FinishSweepingForTesting();
|
|
|
|
private:
|
|
CppHeap() = default;
|
|
|
|
friend class internal::CppHeap;
|
|
};
|
|
|
|
class JSVisitor : public cppgc::Visitor {
|
|
public:
|
|
explicit JSVisitor(cppgc::Visitor::Key key) : cppgc::Visitor(key) {}
|
|
~JSVisitor() override = default;
|
|
|
|
void Trace(const TracedReferenceBase& ref) {
|
|
if (ref.IsEmptyThreadSafe()) return;
|
|
Visit(ref);
|
|
}
|
|
|
|
protected:
|
|
using cppgc::Visitor::Visit;
|
|
|
|
virtual void Visit(const TracedReferenceBase& ref) {}
|
|
};
|
|
|
|
/**
|
|
* Provided as input to `CppHeap::CollectCustomSpaceStatisticsAtLastGC()`.
|
|
*
|
|
* Its method is invoked with the results of the statistic collection.
|
|
*/
|
|
class CustomSpaceStatisticsReceiver {
|
|
public:
|
|
virtual ~CustomSpaceStatisticsReceiver() = default;
|
|
/**
|
|
* Reports the size of a space at the last GC. It is called for each space
|
|
* that was requested in `CollectCustomSpaceStatisticsAtLastGC()`.
|
|
*
|
|
* \param space_index The index of the space.
|
|
* \param bytes The total size of live objects in the space at the last GC.
|
|
* It is zero if there was no GC yet.
|
|
*/
|
|
virtual void AllocatedBytes(cppgc::CustomSpaceIndex space_index,
|
|
size_t bytes) = 0;
|
|
};
|
|
|
|
} // namespace v8
|
|
|
|
namespace cppgc {
|
|
|
|
template <typename T>
|
|
struct TraceTrait<v8::TracedReference<T>> {
|
|
static cppgc::TraceDescriptor GetTraceDescriptor(const void* self) {
|
|
return {nullptr, Trace};
|
|
}
|
|
|
|
static void Trace(Visitor* visitor, const void* self) {
|
|
static_cast<v8::JSVisitor*>(visitor)->Trace(
|
|
*static_cast<const v8::TracedReference<T>*>(self));
|
|
}
|
|
};
|
|
|
|
} // namespace cppgc
|
|
|
|
#endif // INCLUDE_V8_CPPGC_H_
|