Update test/benchmarks/cpp/BUILD.gn and test/benchmarks/cpp/cppgc/BUILD.gn
so that fast_api_benchmark and other C++ benchmarks can be built in a
Chrome checkout (build_with_chromium) in addition to a standalone V8
checkout:
- Use relative paths (../../..:v8, ../../..:v8_libbase, etc.) instead of
root-relative paths (//:v8) which point to the Chromium root in a
Chrome checkout.
- Add ../../..:internal_config_base to benchmark targets so V8 include
paths are configured when building in Chromium.
- Depend on //third_party/google_benchmark when build_with_chromium is
true instead of //third_party/google_benchmark_chrome.
- Add //build/config/compiler:no_exit_time_destructors to cppgc
benchmarks.
- Include "benchmark/benchmark.h" via the benchmark_config include_dirs
instead of hardcoding the third_party/google_benchmark_chrome path.
TAG=agy
CONV=33ee5221-0921-45d8-bcc0-6413b5599ef7
Change-Id: Ia6cf7c1b8651b7808046003c16139b9c48570d01
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8657242
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#111149}
Rename the internal cppgc directory to src/heap/cppgc-internal/ to
clearly distinguish it from the public include/cppgc/ headers and
avoid potential naming confusion.
The collision occurs on Windows builds where -Wmicrosoft-include
is enabled by Clang in MSVC compatible mode. MSVC on Windows uses
different order of directories where the files are searched by the
compiler and `#include "cppgc/blah.h"` in public headers might end up
including "src/heap/cppgc/blah.h" if it exists.
All internal #include paths, include guards, and build configurations
(BUILD.gn and BUILD.bazel) have been updated to reflect the new path.
TAG=agy
CONV=47b06028-d652-41a8-b4f1-39e3cc478096
Bug: 515252150
Change-Id: Idf7ca1d193a8b6bb9d53b22f01320f4363df36f4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7963663
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Auto-Submit: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com>
Cr-Commit-Position: refs/heads/main@{#108143}
Using the same path for DEPS'ed and previously checked-in files
causes conflicts when going back and forth between new and old
revisions. Since all references here are v8 stand-alone, the
exact location shouldn't be important. Therefore we use some
new name to avoid conflicts when locally running `gclient sync`.
Bug: chromium:1513046
Change-Id: Icf1ecc4d9b1f9c7e67b5a542c2be08ff9738d045
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5184217
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Liviu Rau <liviurau@google.com>
Cr-Commit-Position: refs/heads/main@{#91760}
Otherwise, DCHECKs complain that the PageAllocator used for the
GlobalGCInfoTable may differ when setting up the platform repeatedly
through benchmarking SetUp().
Change-Id: I7e87e8c9d8c283105e1bd75a4cd176df7f304315
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3283075
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77920}
Andreas Haas
Igor Sheludko
Michael Achenbach
Matthias Liedtke
Michael Lippautz