Victor Gomes
b62f5b2878
[tests] Remove mentions of --no-always-turbofan
...
Bug: 431974094
Change-Id: I065cfcb8e0639b1a4b7b0c2c28beb6d217bbcb71
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6780589
Commit-Queue: Victor Gomes <victorgomes@chromium.org >
Reviewed-by: Marja Hölttä <marja@chromium.org >
Cr-Commit-Position: refs/heads/main@{#101613}
2025-07-24 01:45:38 -07:00
Simon Zünd
39852e0b06
Reland "[debug] Remove 'value unavailble' experiment"
...
This is a reland of commit c7cbb4139bhttps://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8758034788224082417/overview
Original change's description:
> [debug] Remove 'value unavailble' experiment
>
> The experiment was enabled in July 2023 and we haven't heard any
> negative feedback so we can safely remove the experiment now.
>
> R=bmeurer@chromium.org
>
> Bug: chromium:1328681
> Change-Id: I6613a4e8e741d8c16881ec1adeb01e039244fac7
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5224284
> Commit-Queue: Simon Zünd <szuend@chromium.org >
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#91968}
Bug: chromium:1328681
Change-Id: I651e2a20c6612fc138246aa7e61daab285b57795
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5233640
Commit-Queue: Simon Zünd <szuend@chromium.org >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Auto-Submit: Simon Zünd <szuend@chromium.org >
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#91978}
2024-01-24 10:43:56 +00:00
Michael Achenbach
e2ed1b9071
Revert "[debug] Remove 'value unavailble' experiment"
...
This reverts commit c7cbb4139bhttps://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20debug/48674/overview
Original change's description:
> [debug] Remove 'value unavailble' experiment
>
> The experiment was enabled in July 2023 and we haven't heard any
> negative feedback so we can safely remove the experiment now.
>
> R=bmeurer@chromium.org
>
> Bug: chromium:1328681
> Change-Id: I6613a4e8e741d8c16881ec1adeb01e039244fac7
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5224284
> Commit-Queue: Simon Zünd <szuend@chromium.org >
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#91968}
Bug: chromium:1328681
Change-Id: If487de6e5d934ff4f65b2deb582d530858e77fc3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5233501
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Owners-Override: Michael Achenbach <machenbach@chromium.org >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Auto-Submit: Michael Achenbach <machenbach@chromium.org >
Cr-Commit-Position: refs/heads/main@{#91969}
2024-01-24 07:50:12 +00:00
Simon Zünd
c7cbb4139b
[debug] Remove 'value unavailble' experiment
...
The experiment was enabled in July 2023 and we haven't heard any
negative feedback so we can safely remove the experiment now.
R=bmeurer@chromium.org
Bug: chromium:1328681
Change-Id: I6613a4e8e741d8c16881ec1adeb01e039244fac7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5224284
Commit-Queue: Simon Zünd <szuend@chromium.org >
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org >
Cr-Commit-Position: refs/heads/main@{#91968}
2024-01-24 05:56:49 +00:00
Simon Zünd
768f0fe63e
[debug] Prepare tests for enabling the 'value unavailable' experiment
...
We re-baseline the tests but also include the flag explicitly in the
tests themselves. This way we can switch the flag on or off without
touching the test files.
Note that we also have to massage the test harness a bit, as it is
currently not used to getting serialized properties where the
'value' is missing.
R=jarin@chromium.org
Bug: chromium:1328681, chromium:1449925
Change-Id: I8255b797b55b0b014c41afcc89da23df2d439079
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681253
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org >
Commit-Queue: Simon Zünd <szuend@chromium.org >
Cr-Commit-Position: refs/heads/main@{#88928}
2023-07-14 04:08:52 +00:00
Camillo Bruni
e3e8ea5d65
[flags] Rename --opt to --turbofan
...
To be consistent with the all the other tiers and avoid confusion, we
rename --opt to ---turbofan, and --always-opt to --always-turbofan.
Change-Id: Ie23dc8282b3fb4cf2fbf73b6c3d5264de5d09718
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3610431
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Commit-Queue: Camillo Bruni <cbruni@chromium.org >
Reviewed-by: Jakob Linke <jgruber@chromium.org >
Cr-Commit-Position: refs/heads/main@{#80336}
2022-05-03 12:10:30 +00:00
jarin
a957b0f424
Make non-Module generators only context allocate parameters.
...
In particular, local variables should be allocated on stack (in bytecode register), and stored/loaded to the generator object on generator suspend/resume.
The CL is based on @adamk's change to scoping/parsers (https://chromium-review.googlesource.com/c/498538/ ), I only made the debugger cope with this change.
I should note that the CL changes the scope type of suspended generators from ScopeType.Closure to ScopeType.Local. In the future we might want to introduce ScopeType.SuspendedGenerator to make the distinction explicit.
Some of the changes in the tests have been made because the debugger functions do not return scopes of closed generators anymore. Generators should be allowed to throw away their internal state when they finish.
BUG=v8:6368
Review-Url: https://codereview.chromium.org/2898163002
Cr-Commit-Position: refs/heads/master@{#45515}
2017-05-24 13:54:57 +00:00
adamk
66178c8f53
Remove --harmony-async-await runtime flag
...
It shipped with Chrome 55 stable.
R=littledan@chromium.org
Review-Url: https://codereview.chromium.org/2621173002
Cr-Commit-Position: refs/heads/master@{#42203}
2017-01-10 23:27:02 +00:00
Victor Gomes
Simon Zünd
Michael Achenbach
Camillo Bruni
jarin
adamk