6 Commits
Author SHA1 Message Date
Simon Zünd 39852e0b06 Reland "[debug] Remove 'value unavailble' experiment"
This is a reland of commit c7cbb4139b

Relanding as is. Was reverted due to a test failure that turned out
to be a flake that still reproduced after the revert landed.

Flako run: https://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8758034788224082417/overview

Original change's description:
> [debug] Remove 'value unavailble' experiment
>
> The experiment was enabled in July 2023 and we haven't heard any
> negative feedback so we can safely remove the experiment now.
>
> R=bmeurer@chromium.org
>
> Bug: chromium:1328681
> Change-Id: I6613a4e8e741d8c16881ec1adeb01e039244fac7
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5224284
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#91968}

Bug: chromium:1328681
Change-Id: I651e2a20c6612fc138246aa7e61daab285b57795
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5233640
Commit-Queue: Simon Zünd <szuend@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#91978}
2024-01-24 10:43:56 +00:00
Michael Achenbach e2ed1b9071 Revert "[debug] Remove 'value unavailble' experiment"
This reverts commit c7cbb4139b.

Reason for revert:
https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20debug/48674/overview

Original change's description:
> [debug] Remove 'value unavailble' experiment
>
> The experiment was enabled in July 2023 and we haven't heard any
> negative feedback so we can safely remove the experiment now.
>
> R=bmeurer@chromium.org
>
> Bug: chromium:1328681
> Change-Id: I6613a4e8e741d8c16881ec1adeb01e039244fac7
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5224284
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#91968}

Bug: chromium:1328681
Change-Id: If487de6e5d934ff4f65b2deb582d530858e77fc3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5233501
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Michael Achenbach <machenbach@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#91969}
2024-01-24 07:50:12 +00:00
Simon Zünd c7cbb4139b [debug] Remove 'value unavailble' experiment
The experiment was enabled in July 2023 and we haven't heard any
negative feedback so we can safely remove the experiment now.

R=bmeurer@chromium.org

Bug: chromium:1328681
Change-Id: I6613a4e8e741d8c16881ec1adeb01e039244fac7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5224284
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#91968}
2024-01-24 05:56:49 +00:00
Simon Zünd 768f0fe63e [debug] Prepare tests for enabling the 'value unavailable' experiment
We re-baseline the tests but also include the flag explicitly in the
tests themselves. This way we can switch the flag on or off without
touching the test files.

Note that we also have to massage the test harness a bit, as it is
currently not used to getting serialized properties where the
'value' is missing.

R=jarin@chromium.org

Bug: chromium:1328681, chromium:1449925
Change-Id: I8255b797b55b0b014c41afcc89da23df2d439079
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681253
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#88928}
2023-07-14 04:08:52 +00:00
Ross McIlroy c0720d28db [Test] Add PrepareForOptimization to debugger/ tests.
BUG=v8:8801

Change-Id: Id5ef6219ba2dca2be0603dd0d45e7b27136836e9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587391
Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61085}
2019-04-29 13:47:16 +00:00
jgruber b32ee40de8 [debug-wrapper] Conditional breaks, locals, evaluate, scopes
This CL adds support for:
* conditional breaks in setBreakpoint,
* locals in frame.local{Count,Name,Value},
* evaluation on a frame in frame.evaluate,
* and more detailed scope information in scopeObject.

Uses of several functions that are not covered by the
inspector protocol and are only used in tests have been removed.

Local handling has been modified to also include arguments as locals.
Inspector differs in this regard from our FrameDetails in that
arguments are always shown as locals. Argument-related functions
were removed.

BUG=v8:5530

Review-Url: https://codereview.chromium.org/2491543002
Cr-Commit-Position: refs/heads/master@{#40917}
2016-11-11 12:08:34 +00:00