upstream/v8
2
0 Fork 1
mirror of https://github.com/v8/v8.git synced 2026-11-07 02:22:37 -05:00
Code Releases Activity
105,708 Commits 17,156 Branches 46,261 Tags
beta
Commit Graph
7 Commits
Author SHA1 Message Date
Jakob Kummerow cd814c4e87 [agents] Write "Fixed: <issue_id>" when fixing bugs 
Instruct agents in git-commit.md and workflow-debugging/SKILL.md to
use `Fixed:` rather than `Bug:` when a CL resolves an issue, reserving
`Bug:` for CLs that are related without fully fixing the bug.

TAG=agy
CONV=7104f2d9-0fbf-420b-a2a4-cb945d590701

Change-Id: I1bcdcc7dcf3d8683ffc3a41c4acddedc5e713925
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8617103
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110966}
 2026-10-20 11:47:26 -07:00
Clemens Backes 50ac9be7af [agents] Align V8 git-cl rules with shared Chromium skills 
Remove V8's custom upload_cl.sh, edit_cl_description.sh, and
validate_cl_description.py scripts and align V8's git-cl and git-commit
rules with Chromium's shared git-cl-helper skill (72-char title limit,
git cl description -n +).

Retain V8's worktree isolation, mandatory regression test, stacked CL,
and WIP-by-default guardrails in git-cl.md.

TAG=agy
R=leszeks@chromium.org

Change-Id: Ieee756f06b183204c941f4d063ded32036048d88
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8617944
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110946}
 2026-10-20 06:54:15 -07:00
Clemens Backes 84176e930a [agents] Unify commit message line-length limits 
Unify commit message line-length limits across rules, skills, and
validation scripts to at most 64 characters for the title (following
https://crrev.com/c/8517730) and 72 characters for body lines, removing
the undocumented 78-character limit in git-cl.md and
validate_cl_description.py.

TAG=agy
R=mrcvtl@chromium.org

Change-Id: Ied3de955595c8dd7126d1cad9c058d1161871886
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8559340
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Marco Vitale <mrcvtl@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110658}
 2026-10-13 22:55:08 -07:00
Clemens Backes a7bc2f93c9 [agents] Encourage short and punchy commit titles 
Add a guideline to git-commit.md instructing agents to keep commit
titles concise and punchy (aiming for ~50 characters, strictly under 65
characters including component prefix).

TAG=agy
R=jkummerow@chromium.org

Change-Id: Id262e6e5272188ab5a0adbc6b4e001e95f665d1a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8517730
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110378}
 2026-10-07 00:47:42 -07:00
Clemens Backes b3bc61d715 [agents] Mandate concise commit descriptions in git-commit rule 
Instruct agents to keep commit description bodies concise (aiming for at
most 10 lines) and include only essential information without restating
details obvious from the diff.

TAG=agy
R=leszeks@chromium.org

Change-Id: I987eecb533be7836280ff72cf114b0c334bf71df
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8492273
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110206}
 2026-09-30 08:27:49 -07:00
Camillo Bruni 40d445ecdb [agents] Update git-commit rules for public vs internal Bug footers 
Update agents/rules/git-commit.md to clarify that:
- Public bugs (e.g., on issues.chromium.org) must use the plain
  numerical bug ID format without any prefixes like "chromium:".
- Internal bugs (e.g., on Google-internal Buganizer) must continue to
  use the "b: prefix format.

Drive-by-fix:
- Format git-commit.md

TAG=agy
CONV=1ff8ce35-b85d-4fdb-be25-b0df39001958

No-Try: true
Change-Id: I70ec93090655d8462dbbbc254096a95a4b202c27
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7807096
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Marco Vitale <mrcvtl@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107050}
 2026-05-05 02:52:16 -07:00
Leszek Swirski 0a5439db6c [agents] Apply writing skills rule to all skills and rules 
This CL applies the principles from writing_skills.md (positive
phrasing, clear structure, API-style precision) to all remaining
skills in agents/skills and rules in agents/rules.

BUG=None
TAG=agy
CONV=c140a242-13de-4fa7-9bf1-8b9c10551804

Change-Id: Ic843ea8ba2d3d6e238ddf34adf5802e2c0ddca52
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7781188
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106776}
 2026-04-23 07:41:18 -07:00