sandcats_configure_https is dead code, as of 9ac0360311
In the current install script, the only effect of the value of
SANDCATS_GETCERTIFICATE is to conditionally tell
the user that we're going to "Configure auto-renewing HTTPS if you use
a subdomain of sandcats.io", so going forward we just provide this message
always on a full server install.
Details:
- Stop using curl args from the future, e.g. use data-ascii
- Text change: Clarify that failure is failure.
- Logic change: When asking if the user wants to report failures to us, insist
on prompting them.
- IMPORTANT CHANGE: Pass ENVVARS when running script from current working
directory. The lack of this was prevent the CURL_USER_AGENT environment
variable from being passed into the script when it re-exec'd itself as
root, if and only if the script decided it was being run from a local
filename. However, this presumably does affect the test suite.
- While at it, adjust prepare-for-tests.sh to request a few more dependencies.
- Adjust existing installer-tests to not report errors, for simplicity.
- Adjust install.sh reference docs to remark on REPORT=no.
Jim Garrison
Kenton Varda
Ian Denhardt
Jacob Weisz
Asheesh Laroia
Ross Light
Asheesh Laroia