Josh Kang
390ac33d00
Summary: Pull Request resolved: https://github.com/meta/rocksdb/pull/15560 ## Summary clang's `-Wswitch-enum` warning (`clang-diagnostic-switch-enum`) fires when a `switch` over an enum doesn't name every enumerator, even if the switch has a `default:`. A full clang-tidy scan reports 79 such switches in existing code, and they get flagged whenever nearby lines change. Naming the remaining enumerators also means that a newly added enumerator triggers the warning, instead of silently falling into `default:`. This diff fixes 47 of them by adding the missing `case X:` labels right before the existing `default:` (or next to the branch that already handles them). Behavior is unchanged: no existing case is reordered and no branch body changes. `default:` is kept wherever the value can come from disk, a cast, or user options, so out-of-range values are still handled as before. Examples: cache entry roles and admission policies in `SecondaryCacheAdapter`, `FileType` in `corruption_test`, `ChecksumType` in `ComputeBuiltinChecksum*` (with `kNoChecksum` now named explicitly), and trace/IO enums in several tools. Not changed (31; upstream has since removed one): switches where listing everything would hurt readability and `default:` is the intended handler. That covers `ValueType` switches on the read path (`DBIter`, `MemTable::SaveValue`, `GetContext`) with about 20 unhandled values each, `CompressionType` and `IOActivity` switches with more than 100 custom/reserved values, and test trace handlers that accept one `TraceType`. Upstream has since added two more test trace switches (five and three `TraceType`s) in `db_etc2_test`, also left unchanged. Reviewed By: xingbowang Differential Revision: D123186312 fbshipit-source-id: 5f6571bb68e28f1caa201bb20524714da18cc63d
RocksDB: A Persistent Key-Value Store for Flash and RAM Storage
RocksDB is developed and maintained by Facebook Database Engineering Team. It is built on earlier work on LevelDB by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)
This code is a library that forms the core building block for a fast key-value server, especially suited for storing data on flash drives. It has a Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor (WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). It has multi-threaded compactions, making it especially suitable for storing multiple terabytes of data in a single database.
Start with example usage here: https://github.com/meta/rocksdb/tree/main/examples
See the github wiki for more explanation.
The public interface is in include/. Callers should not include or
rely on the details of any other header files in this package. Those
internal APIs may be changed without warning.
Questions and discussions are welcome on the RocksDB Developers Public Facebook group and email list on Google Groups.
License
RocksDB is dual-licensed under both the GPLv2 (found in the COPYING file in the root directory) and Apache 2.0 License (found in the LICENSE.Apache file in the root directory). You may select, at your option, one of the above-listed licenses.