mirror of
https://github.com/FerretDB/documentdb.git
synced 2026-11-06 19:12:50 -05:00
Vinod Sridharan
1c433c472b
### Does this PR have any customer impact? Yes ### Type (Feature, Refactoring, Bugfix, DevOps, Testing, Perf, etc) Bugfix ### Does it involve schema level changes? (Table, Column, Index, UDF, etc level changes) No ### Are you introducing any new config? If yes, do you have tests with and without them being set? No ### ChangeLog (Refer [Template](../oss/CHANGELOG.md)) ### Description 1) There were order by tests not running but had the sql files in there. This was catching contracts related to arrays with null values where 2 cases were ordered later than they should be. This fixes that. As part of that we noticed that this breaks when there's paths that have array indexes (e.g. a.b.0). This also fixes that contract. 2) Add checks to say all tests must run or exist in a schedule file and fix the output 3) There's flakeyness in currentop due to tracking the version refresh query - skip the version refresh query in currentop. ---- #### AI description (iteration 1) #### PR Classification This pull request fixes correctness issues in composite order-by functionality and improves associated testing. #### PR Summary The changes refine the handling of intermediate arrays in order-by operations by updating traversal and comparison logic, while enhancing the test suite and validation scripts for composite order-by scenarios. - `pg_documentdb/src/query/bson_dollar_operators.c` and related files were modified to correctly process nested arrays and compare composite order-by values. - Test files in `pgmongo/src/test/regress/expected/` and `pgmongo/src/test/regress/sql/` were updated to add new order-by cases and remove obsolete tests. - Validation scripts (e.g. in `oss/internal/pg_documentdb_distributed/src/test/regress/validate_test_output.sh` and `oss/pg_documentdb/src/test/regress/validate_test_output.sh`) were enhanced for more reliable schedule checks and collection ID extraction. - Several BSON traversal and update operator functions were updated to include an `isArrayIndexSearch` parameter for finer control during array element processing. - `pg_documentdb/src/commands/current_op.c` and `pg_documentdb/src/utils/version_utils.c` were updated to skip version refresh queries appropriately. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
30 lines
808 B
C
30 lines
808 B
C
/*-------------------------------------------------------------------------
|
|
* Copyright (c) Microsoft Corporation. All rights reserved.
|
|
*
|
|
* include/utils/version_utils.h
|
|
*
|
|
* Utilities that Provide extension functions to handle version upgrade
|
|
* scenarios.
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#include <postgres.h>
|
|
|
|
#ifndef VERSION_UTILS_H
|
|
#define VERSION_UTILS_H
|
|
|
|
typedef enum DocumentsMajorVersion
|
|
{
|
|
DocDB_V0 = 0,
|
|
} MajorVersion;
|
|
|
|
bool IsClusterVersionAtleast(MajorVersion major, int minor, int patch);
|
|
bool IsClusterVersionAtLeastPatch(MajorVersion major, int minor, int patch);
|
|
void InvalidateVersionCache(void);
|
|
void InitializeVersionCache(void);
|
|
Size VersionCacheShmemSize(void);
|
|
|
|
bool IsVersionRefreshQueryString(const char *queryString);
|
|
|
|
#endif
|