mirror of
https://github.com/FerretDB/documentdb.git
synced 2026-11-07 03:22:46 -05:00
Vinod Sridharan
4bcd774983
### Does this PR have any customer impact? Yes ### Type (Feature, Refactoring, Bugfix, DevOps, Testing, Perf, etc) Perf ### Does it involve schema level changes? (Table, Column, Index, UDF, etc level changes) No ### Are you introducing any new config? If yes, do you have tests with and without them being set? Yes ### ChangeLog (Refer [Template](../oss/CHANGELOG.md)) ### Description 1) Use prepared statements with UpdateAllMatchingDocuments 2) Don't pass shard_key_value by default if using the `@@` operator 3) Do something similar for SELECT update candidate. ---- #### AI description (iteration 1) #### PR Classification Performance optimization and bug fix for update query execution. #### PR Summary This PR enhances update performance by refining shard key filter handling and optimizing SPI plan selection, while also introducing new query plan cache keys and a configuration flag for legacy behavior. - `oss/pg_documentdb/src/commands/update.c`: Refactors update candidate selection by conditionally adding shard key filters, adjusting argument indexing, and using the full collection object instead of separate identifiers. - `oss/pg_documentdb/include/infrastructure/documentdb_plan_cache.h`: Introduces new constants for query plan caching to support optimized update queries. - `oss/pg_documentdb/src/configs/feature_flag_configs.c`: Adds the `UseLegacyShardKeyFilterOnUpdate` flag to offer backward compatibility with the previous shard key filtering behavior. - Test files in the distributed module: Update expected SQL query strings to match the revamped query construction logic. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Signed-off-by: Shuai Tian <shuaitian@microsoft.com>
104 lines
4.1 KiB
C
104 lines
4.1 KiB
C
/*-------------------------------------------------------------------------
|
|
* Copyright (c) Microsoft Corporation. All rights reserved.
|
|
*
|
|
* include/planner/documentdb_plan_cache.h
|
|
*
|
|
* Common declarations for the pg_documentdb plan cache.
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
|
|
#ifndef BSON_PLAN_CACHE_H
|
|
#define BSON_PLAN_CACHE_H
|
|
|
|
#include <executor/spi.h>
|
|
|
|
/*
|
|
* ID prefixes for different types of query.
|
|
*
|
|
* The first 32 bits of a query ID are used to identity the operation,
|
|
* and the latter 32 bits to identify different query variants.
|
|
*/
|
|
#define QUERY_ID_INSERT (1L << 32)
|
|
#define QUERY_ID_UPDATE_BY_TID (2L << 32)
|
|
#define QUERY_ID_DELETE_BY_TID (3L << 32)
|
|
|
|
/* TODO: remove once we fully support let and collation with delete */
|
|
#define QUERY_DELETE_WITH_FILTER (4L << 32);
|
|
#define QUERY_DELETE_WITH_FILTER_SHARDKEY (5L << 32)
|
|
#define QUERY_DELETE_WITH_FILTER_ID (6L << 32)
|
|
#define QUERY_DELETE_WITH_FILTER_SHARDKEY_ID (7L << 32)
|
|
|
|
#define QUERY_CALL_UPDATE_ONE (8L << 32)
|
|
|
|
#define QUERY_DELETE_ONE (9L << 32)
|
|
#define QUERY_DELETE_ONE_ID (10L << 32)
|
|
#define QUERY_DELETE_ONE_ID_RETURN_DOCUMENT (11L << 32)
|
|
|
|
/* TODO: remove once we fully support let and collation with delete */
|
|
#define QUERY_UPDATE_SELECT_UPDATE_CANDIDATE (12L << 32)
|
|
#define QUERY_UPDATE_SELECT_UPDATE_CANDIDATE_NON_OBJECT_ID (13L << 32)
|
|
#define QUERY_UPDATE_SELECT_UPDATE_CANDIDATE_ONLY_OBJECT_ID (14L << 32)
|
|
#define QUERY_UPDATE_SELECT_UPDATE_CANDIDATE_BOTH_FILTER (15L << 32)
|
|
|
|
|
|
#define QUERY_ID_RETRY_RECORD_INSERT (20L << 32)
|
|
#define QUERY_ID_RETRY_RECORD_DELETE (21L << 32)
|
|
#define QUERY_ID_RETRY_RECORD_SELECT (22L << 32)
|
|
|
|
#define QUERY_ID_INSERT_OR_REPLACE (23L << 32)
|
|
|
|
#define QUERY_DELETE_WITH_FILTER_LET_AND_COLLATION (30L << 32)
|
|
#define QUERY_DELETE_WITH_FILTER_SHARDKEY_LET_AND_COLLATION (31L << 32)
|
|
#define QUERY_DELETE_WITH_FILTER_ID_LET_AND_COLLATION (32L << 32)
|
|
#define QUERY_DELETE_WITH_FILTER_SHARDKEY_ID_LET_AND_COLLATION (33L << 32)
|
|
|
|
#define QUERY_DELETE_ONE_LET_AND_COLLATION (34L << 32)
|
|
#define QUERY_DELETE_ONE_ID_LET_AND_COLLATION (35L << 32)
|
|
|
|
|
|
#define QUERY_UPDATE_SELECT_UPDATE_CANDIDATE_LET_AND_COLLATION (36L << 32)
|
|
#define QUERY_UPDATE_SELECT_UPDATE_CANDIDATE_NON_OBJECT_ID_LET_AND_COLLATION (37L << 32)
|
|
#define QUERY_UPDATE_SELECT_UPDATE_CANDIDATE_BOTH_FILTER_LET_AND_COLLATION (38L << 32)
|
|
|
|
|
|
#define QUERY_UPDATE_MANY_SHARD_KEY_QUERY_OFFSET (1L << 32)
|
|
#define QUERY_UPDATE_MANY_OBJECTID_QUERY_OFFSET (2L << 32)
|
|
#define QUERY_UPDATE_MANY_SHARD_KEY_OBJECT_ID_QUERY_OFFSET \
|
|
QUERY_UPDATE_MANY_SHARD_KEY_QUERY_OFFSET + QUERY_UPDATE_MANY_OBJECTID_QUERY_OFFSET
|
|
|
|
#define QUERY_UPDATE_MANY_WITH_QUERY_FILTER_FUNCTION (40L << 32)
|
|
#define QUERY_UPDATE_MANY_WITH_QUERY_FILTER_FUNCTION_WITH_SHARD_KEY \
|
|
QUERY_UPDATE_MANY_WITH_QUERY_FILTER_FUNCTION + \
|
|
QUERY_UPDATE_MANY_SHARD_KEY_QUERY_OFFSET
|
|
#define QUERY_UPDATE_MANY_WITH_QUERY_FILTER_FUNCTION_WITH_OBJECT_ID \
|
|
QUERY_UPDATE_MANY_WITH_QUERY_FILTER_FUNCTION + QUERY_UPDATE_MANY_OBJECTID_QUERY_OFFSET
|
|
#define QUERY_UPDATE_MANY_WITH_QUERY_FILTER_FUNCTION_WITH_SHARD_KEY_AND_OBJECT_ID \
|
|
QUERY_UPDATE_MANY_WITH_QUERY_FILTER_FUNCTION + \
|
|
QUERY_UPDATE_MANY_SHARD_KEY_OBJECT_ID_QUERY_OFFSET
|
|
|
|
#define QUERY_UPDATE_MANY_WITH_QUERY_FILTER_OPERATOR (44L << 32)
|
|
#define QUERY_UPDATE_MANY_WITH_QUERY_FILTER_OPERATOR_WITH_SHARD_KEY \
|
|
QUERY_UPDATE_MANY_WITH_QUERY_FILTER_OPERATOR + \
|
|
QUERY_UPDATE_MANY_SHARD_KEY_QUERY_OFFSET
|
|
#define QUERY_UPDATE_MANY_WITH_QUERY_FILTER_OPERATOR_WITH_OBJECT_ID \
|
|
QUERY_UPDATE_MANY_WITH_QUERY_FILTER_OPERATOR + QUERY_UPDATE_MANY_OBJECTID_QUERY_OFFSET
|
|
#define QUERY_UPDATE_MANY_WITH_QUERY_FILTER_OPERATOR_WITH_SHARD_KEY_AND_OBJECT_ID \
|
|
QUERY_UPDATE_MANY_WITH_QUERY_FILTER_OPERATOR + \
|
|
QUERY_UPDATE_MANY_SHARD_KEY_OBJECT_ID_QUERY_OFFSET
|
|
|
|
|
|
/* GUC that controls the query plan cache size */
|
|
extern int QueryPlanCacheSizeLimit;
|
|
|
|
|
|
void InitializeQueryPlanCache(void);
|
|
SPIPlanPtr GetSPIQueryPlan(uint64 collectionId, uint64 queryId,
|
|
const char *query, Oid *argTypes, int argCount);
|
|
|
|
SPIPlanPtr GetSPIQueryPlanWithLocalShard(uint64 collectionId, const char *shardTableName,
|
|
uint64 queryId,
|
|
const char *query, Oid *argTypes, int argCount);
|
|
|
|
#endif
|