[Forge/NeoForge] Workaround to fix tablist tracking not working properly caused by events being fired too late (#1623)

README.md

@@ -1,55 +1,3 @@
 # About
-TAB aims to be a superior all-in-one minecraft plugin for displaying information that outperforms all 
-similar plugins in terms of features, performance and compatibility.  
-More information can be found at [Why TAB?](https://github.com/NEZNAMY/TAB/wiki/Why-TAB%3F) wiki page.
-
-# Download
-### Releases
-You can download full releases from [GitHub releases](https://github.com/NEZNAMY/TAB/releases), 
-[SpigotMC](https://www.spigotmc.org/resources/57806/), [Modrinth](https://modrinth.com/plugin/tab-was-taken), [BuiltByBit](https://builtbybit.com/resources/20631) or [CurseForge](https://www.curseforge.com/minecraft/mc-mods/tab).
-
-### Dev builds
-Plugin's development is continuous and contains lots of small changes/fixes not worthy of being called a full
-update, therefore development builds are being created and eventually a full update is released when enough changes are made.  
-If you want to benefit from a recent change in the code before official release, you can download development builds
-from [GitHub actions](https://github.com/NEZNAMY/TAB/actions) (you must be logged into GitHub to be able to download it).  
-
-# Compiling
-Compilation requires JDK 21 and up.  
-To compile the plugin, run `./gradlew build` from the terminal.  
-Once the plugin compiles, grab the jar from `/jar/build/libs/` folder.  
-The universal jar contains all modules for all supported platforms.
-
-# Documentation
-You can find everything about the plugin on the [Wiki](https://github.com/NEZNAMY/TAB/wiki). This includes a detailed description
-of all features, as well as information regarding compatibility or limitations of each feature.  
-
-# Issues
-The [Issues](https://github.com/NEZNAMY/TAB/issues) section is an issue tracker for all the kind of problems covered in issue templates.
-Please refrain from attempting to use it to receive help with your server, such issues will be closed immediately.  
-When opening an issue, provide as much information as possible. The difference between a bug getting fixed in 1 week vs 1 hour
-is in quality of the report. Bug reports where steps to reproduce are "idk" have no value and will not help to get the bug fixed at all.  
-
-# Contributing
-See [CONTRIBUTING.md](https://github.com/NEZNAMY/TAB/blob/master/CONTRIBUTING.md)
-
-# Provided services
-The plugin is being used by a large amount of servers, which also means the demand for my attention is high. Unfortunately, 
-I am no longer able to keep up with the demand since I don't want to dedicate my whole existence to a free plugin. 
-In order to provide the best quality of all provided services, the amount of services provided may vary over time. 
-Here is the full list of potential services and their status:
-
-| Service type                  | Availability |
-|-------------------------------|--------------|
-| Updates for new MC versions   | ✔            |
-| Bug fixes                     | ✔            |
-| Wiki improvements             | ✔            |
-| Performance optimizations     | ✔            |
-| Feature requests              | ❌            |
-| Customer support<sup>1</sup>  | ✔            |
-| Free user support<sup>2</sup> | ❌*           |
-
-<sup>1</sup> - Unrestricted assistance with the plugin for those, who bought a copy of the plugin when it was purchasable.  
-<sup>2</sup> - Unlimited access to my free time for everyone in the world.  
-  
-*Instead, you can use [this fresh new community discord](https://discord.gg/YPqXt63YQj) made by a nice person who will provide this service.  
+This is an archived source code of the latest release with full MC 1.x support on Bukkit and backporting services on modded platforms - 5.5.0.  
+Starting with 6.0.0, support for old unused Bukkit versions will start disappearing and modded platforms will only support MC 26+ without offering backport services to 1.x.

forge/src/main/java/me/neznamy/tab/platforms/forge/ForgeTabListEntryTracker.java

@@ -27,4 +27,19 @@ public class ForgeTabListEntryTracker extends TabListEntryTracker {
             }
         }
     }
+
+    /**
+     * Override to always return true, because join event is called too late, so TAB
+     * is not able to catch all packets, thus it is not able to track tablist entries properly.
+     * Return true to avoid not applying features. May result in client warnings if using a vanish
+     * mod or similar, but that's a tradeoff.
+     *
+     * @param   uuid
+     *          UUID of player to check
+     * @return  true
+     */
+    @Override
+    public boolean containsEntry(@NotNull UUID uuid) {
+        return true;
+    }
 }

forge/src/main/resources/META-INF/mods.toml

@@ -1,5 +1,5 @@
 modLoader = "javafml"
-loaderVersion = "[47,)"
+loaderVersion = "*"
 issueTrackerURL = "https://github.com/NEZNAMY/TAB/issues"
 license = "Apache License Version 2.0"
 
@@ -12,13 +12,6 @@ credits = "@credits@"
 description = '''@description@'''
 displayURL = "@website@"
 
-[[dependencies.tab]]
-modId = "forge"
-mandatory = true
-versionRange = "*"
-ordering = "NONE"
-side = "SERVER"
-
 [[dependencies.tab]]
 modId = "minecraft"
 mandatory = true

neoforge/src/main/java/me/neznamy/tab/platforms/neoforge/NeoForgeTabListEntryTracker.java

@@ -27,4 +27,19 @@ public class NeoForgeTabListEntryTracker extends TabListEntryTracker {
             }
         }
     }
+
+    /**
+     * Override to always return true, because join event is called too late, so TAB
+     * is not able to catch all packets, thus it is not able to track tablist entries properly.
+     * Return true to avoid not applying features. May result in client warnings if using a vanish
+     * mod or similar, but that's a tradeoff.
+     *
+     * @param   uuid
+     *          UUID of player to check
+     * @return  true
+     */
+    @Override
+    public boolean containsEntry(@NotNull UUID uuid) {
+        return true;
+    }
 }

neoforge/src/main/resources/META-INF/neoforge.mods.toml

@@ -1,5 +1,5 @@
 modLoader = "javafml"
-loaderVersion = "[3,)"
+loaderVersion = "*"
 issueTrackerURL = "https://github.com/NEZNAMY/TAB/issues"
 license = "Apache License Version 2.0"
 displayURL = "@website@"
@@ -12,12 +12,6 @@ authors = "@author@"
 credits = "@credits@"
 description = '''@description@'''
 
-[[dependencies.tab]]
-modId = "neoforge"
-type = "required"
-ordering = "NONE"
-side = "SERVER"
-
 [[dependencies.tab]]
 modId = "minecraft"
 type = "required"