Paul Chen and Paul Chen
37fd5d25fe
[BUG] Moves key to another DB, the source key was removed if the move failed due to the key exists in the destination db #497 ( #498 )
...
Co-authored-by: Paul Chen <mingchen@Mings-MacBook-Pro.local >
2022-10-20 18:06:58 -04:00
John Sully
e8e3666dcb
Workaround bug in snapshot sync - abort don't crash
2022-09-28 19:00:26 +00:00
John Sully
597b5669e3
Fix Issue #486
2022-09-14 14:48:28 +00:00
Ilya Shipitsin
772bf47ef7
src\redis-cli.c: fix potential null pointer dereference found by cppcheck
...
src\redis-cli.c:5488:35: warning: Either the condition
'!table' is redundant or there is possible null pointer dereference:
table. [nullPointerRedundantCheck]
2022-09-14 10:03:08 -04:00
root
7bf9c02954
avoid from instatiating EpochHolder multiple times to improve performance and cpu utilization
2022-09-14 10:02:02 -04:00
root
8661cfe7bd
avoid from instatiating EpochHolder multiple times to improve performance and cpu utilization
2022-09-14 10:02:02 -04:00
Karthick Ariyaratnam (A)
2173975aaf
Remove old assertion which is commented out.
2022-09-14 10:01:21 -04:00
Karthick Ariyaratnam (A)
b989cd80c1
Fixes a crash where the server assertion failed when the key exists in DB during RDB load
2022-09-14 10:01:21 -04:00
John Sully
79b6c65185
Prevent crash on load in long running KeyDB instances
2022-09-01 15:26:26 +00:00
John Sully
e114f41d5c
Fix race removing key cache
2022-09-01 15:16:27 +00:00
John Sully
a2e6e35d5e
Fix crash running INFO command while a disk based backlog is set
2022-08-01 04:53:56 +00:00
John Sully
9e5d1c8ec9
Fix issue #480
2022-08-01 03:14:09 +00:00
John Sully
1948f21d0d
Do not allow commands to run in background when in eval, Issue #452
2022-07-06 04:26:13 +00:00
John Sully
3cba0e0ba4
Fix issue #454 (BSD build break)
2022-07-06 04:04:47 +00:00
guybe7
3a4f46104c
lpGetInteger returns int64_t, avoid overflow ( #10068 )
...
Fix #9410
Crucial for the ms and sequence deltas, but I changed all
calls, just in case (e.g. "flags")
Before this commit:
`ms_delta` and `seq_delta` could have overflown, causing `currid` to be wrong,
which in turn would cause `streamTrim` to trim the entire rax node (see new test)
2022-07-06 03:44:24 +00:00
John Sully
38310ec9f6
On Alpine we must have a reasonable stack size
2022-05-20 16:40:20 -04:00
John Sully
ea4941a3e7
Fix crash in expire when a snapshot is in flight. Caused by a perf optimization getting the expire map out of sync with the val
2022-05-20 13:07:26 -04:00
John Sully
5dbf1f6bd6
Fix O(n^2) algorithm in the GC cleanup logic
2022-05-19 21:46:55 -04:00
John Sully
ba1275f653
Fix TSAN warnings on the repl backlog
2022-05-17 15:37:22 -04:00
John Sully
20766a02b8
Disable async commands by default
2022-05-17 15:37:22 -04:00
John Sully
a9d3490f9c
Silence TSAN errors on ustime and mstime. Every CPU we support is atomic on aligned ints, but correctness matters
2022-05-17 15:37:22 -04:00
John Sully
8405c99017
Add fence barriers for the repl backlog (important for AARCH64 and other weak memory models)
2022-05-17 15:37:22 -04:00
John Sully
027ad50581
Dictionary use correct acquire/release semantics
2022-05-17 15:37:22 -04:00
John Sully
e38537202e
Avoid unnecessary rehashing when a rehash is abandoned
2022-05-17 15:37:22 -04:00
John Sully
8d8aabb978
Prevent us from starting a rehash when one wasn't already in progress. This can cause severe issues for snapshots
2022-05-17 15:37:22 -04:00
John Sully
418356c03a
Initialize noshrink, it was dangling
2022-05-17 15:37:22 -04:00
John Sully
3caf6060c4
Prevent crash on shutdown by avoiding dtors (they are unnecessary anyways)
2022-05-17 15:37:22 -04:00
John Sully
9e138815a1
Fix assertion in async rehash
2022-05-17 15:37:22 -04:00
John Sully
51d3e2cbbc
Fix reference counting failure in the dict. This is caused by std::swap also swapping refcounts
2022-05-17 15:37:22 -04:00
John Sully
442c3de350
Limit max overage to 20% during RDB save
2022-05-10 18:30:12 +00:00
benschermel
1b22cebe02
remove Enterprise references
2022-05-10 12:58:59 -04:00
John Sully
481ab76987
Remove unnecessary libs
2022-05-06 17:34:14 +00:00
John Sully
b423e1050e
Fix musl/Alpine build failures
2022-05-06 17:05:04 +00:00
John Sully
4141746f8f
Fix crash in save of masterinfo
2022-05-06 16:29:27 +00:00
John Sully
39974223eb
Disable FLASH
2022-05-06 01:20:06 +00:00
John Sully
1f958ac63d
Disable async for hget commands as it is not ready
2022-05-05 20:50:44 +00:00
John Sully
41b282803a
Fix PSYNC test crashes
2022-05-04 01:37:40 +00:00
John Sully
cfcb9df71c
Merge branch 'keydbpro' into psync_multimaster_fixes
2022-05-02 22:19:22 +00:00
John Sully
63e5507dfe
Merge branch 'keydbpro' of https://github.sc-corp.net/Snapchat/keydb-internal into keydbpro
2022-05-02 22:14:31 +00:00
Vivek Saini
faf9359e10
Merge pull request #60 from Snapchat/merge_os_apr_13
...
Merge in changes from Open Source.
For the most part, this encompasses two changes:
- Adding partial sync capabilities to multi-master
- Adding ReadWrite locks to prevent global lock issues when forking threads, specifically with regards to the time thread.
2022-05-02 13:26:21 -04:00
John Sully
6e4e75af9c
Ensure recreated tables use the same settings as ones made at boot
2022-04-27 23:38:55 +00:00
John Sully
cfa9ba8eb1
Ensure we are responsive during storagecache clears
2022-04-27 17:32:40 +00:00
John Sully
b37a68c8f1
PSYNC production fixes
2022-04-26 02:07:28 +00:00
John Sully
1bf92015dc
acceptTLS is threadsafe like the non TLS version
2022-04-26 01:55:22 +00:00
John Sully
914da1f62c
With TLS throttle accepts if server is under heavy load - do not change non TLS behavior
2022-04-26 01:55:22 +00:00
John Sully
dcaca5d79c
Make active client balancing a configurable option
2022-04-26 01:55:22 +00:00
Vivek Saini
54f746f99b
Removed mergeReplicationId
2022-04-26 01:55:22 +00:00
Vivek Saini
78efb2f629
call aeThreadOnline() earlier
2022-04-26 01:55:22 +00:00
Vivek Saini
d441901c39
Inclusive language
2022-04-26 01:55:22 +00:00
Vivek Saini
09f216fb03
Remove asserts, RW lock can go below zero in cases of aeAcquireLock
2022-04-26 01:55:22 +00:00
Paul ChenandPaul Chen
John Sully
Ilya Shipitsin
root
Karthick Ariyaratnam (A)
guybe7
benschermel
Vivek Saini