Always process non-ByteBuf messages

Release ByteBuf on invalid handshake data
2025-03-31 15:50:13 +02:00 · 2025-03-31 15:50:01 +02:00
1 changed files with 3 additions and 0 deletions
@@ -122,6 +122,7 @@ final class FallbackBukkitInboundHandler extends FallbackInboundHandlerAdapter {
            updateRegistry(FallbackPacketRegistry.LOGIN, Objects.requireNonNull(protocolVersion));
            break;
          default:
+            byteBuf.release();
            throw ProtocolUtil.DEBUG ? new DecoderException("Bad handshake intent " + handshake.getIntent())
              : QuietDecoderException.INSTANCE;
        }
@@ -146,6 +147,8 @@ final class FallbackBukkitInboundHandler extends FallbackInboundHandlerAdapter {

      byteBuf.readerIndex(originalReaderIndex);
      ctx.fireChannelRead(byteBuf);
+    } else {
+      ctx.fireChannelRead(msg);
    }
  }
 }
Author	SHA1	Message	Date
Jones	4e109850e9	Always process non-ByteBuf messages	2025-03-31 15:50:13 +02:00
Jones	dfd0314cba	Release ByteBuf on invalid handshake data	2025-03-31 15:50:01 +02:00