From 315a987f4f661e0f74623cc73f80e16fbf4e17a6 Mon Sep 17 00:00:00 2001 From: RK_01 <50594595+RaphiMC@users.noreply.github.com> Date: Fri, 1 May 2026 22:31:07 +0200 Subject: [PATCH] Fix edge case in DataPaletteImpl#replaceIds (#4930) --- .../viaversion/api/minecraft/chunks/DataPaletteImpl.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/api/src/main/java/com/viaversion/viaversion/api/minecraft/chunks/DataPaletteImpl.java b/api/src/main/java/com/viaversion/viaversion/api/minecraft/chunks/DataPaletteImpl.java index 71fdf60da..22223917c 100644 --- a/api/src/main/java/com/viaversion/viaversion/api/minecraft/chunks/DataPaletteImpl.java +++ b/api/src/main/java/com/viaversion/viaversion/api/minecraft/chunks/DataPaletteImpl.java @@ -25,7 +25,6 @@ package com.viaversion.viaversion.api.minecraft.chunks; import it.unimi.dsi.fastutil.ints.Int2IntMap; import it.unimi.dsi.fastutil.ints.Int2IntOpenHashMap; import it.unimi.dsi.fastutil.ints.IntArrayList; -import it.unimi.dsi.fastutil.ints.IntList; import java.util.function.IntUnaryOperator; public final class DataPaletteImpl implements DataPalette { @@ -42,7 +41,7 @@ public final class DataPaletteImpl implements DataPalette { } public DataPaletteImpl(final int valuesLength, final int initialSize) { - values = new EmptyChunkData(valuesLength); + values = new SingleChunkData(valuesLength); sizeBits = Integer.numberOfTrailingZeros(valuesLength) / 3; // Pre-size the palette array/map palette = new IntArrayList(initialSize); @@ -127,7 +126,7 @@ public final class DataPaletteImpl implements DataPalette { @Override public void replaceIds(final IntUnaryOperator mapper) { final int oldSize = palette.size(); - if (oldSize == 0 || values instanceof EmptyChunkData) { + if (oldSize == 0) { return; } @@ -191,11 +190,11 @@ public final class DataPaletteImpl implements DataPalette { int size(); } - private final class EmptyChunkData implements ChunkData { + private final class SingleChunkData implements ChunkData { private final int size; - public EmptyChunkData(int size) { + public SingleChunkData(int size) { this.size = size; }