From 65c42b9b09be6510992c29b2f29b67bffb740232 Mon Sep 17 00:00:00 2001
From: Luck <git@lucko.me>
Date: Sat, 23 Aug 2025 15:39:49 +0100
Subject: [PATCH] Micro-optimize temporary node audit (#4155)

---
 .../java/me/lucko/luckperms/common/event/EventDispatcher.java | 4 ++--
 .../me/lucko/luckperms/common/model/PermissionHolder.java     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/src/main/java/me/lucko/luckperms/common/event/EventDispatcher.java b/common/src/main/java/me/lucko/luckperms/common/event/EventDispatcher.java
index 5262b9a41..4a7b9387c 100644
--- a/common/src/main/java/me/lucko/luckperms/common/event/EventDispatcher.java
+++ b/common/src/main/java/me/lucko/luckperms/common/event/EventDispatcher.java
@@ -231,11 +231,11 @@ public final class EventDispatcher {
     }
 
     public void dispatchNodeChanges(PermissionHolder target, DataType dataType, Difference<Node> changes) {
-        if (!this.eventBus.shouldPost(NodeAddEvent.class) && !this.eventBus.shouldPost(NodeRemoveEvent.class)) {
+        if (changes.isEmpty()) {
             return;
         }
 
-        if (changes.isEmpty()) {
+        if (!this.eventBus.shouldPost(NodeAddEvent.class) && !this.eventBus.shouldPost(NodeRemoveEvent.class)) {
             return;
         }
 
diff --git a/common/src/main/java/me/lucko/luckperms/common/model/PermissionHolder.java b/common/src/main/java/me/lucko/luckperms/common/model/PermissionHolder.java
index 700f04403..21af4b045 100644
--- a/common/src/main/java/me/lucko/luckperms/common/model/PermissionHolder.java
+++ b/common/src/main/java/me/lucko/luckperms/common/model/PermissionHolder.java
@@ -431,8 +431,8 @@ public abstract class PermissionHolder {
         Difference<Node> result = getData(dataType).removeIf(Node::hasExpired);
         if (!result.isEmpty()) {
             invalidateCache();
+            this.plugin.getEventDispatcher().dispatchNodeChanges(this, dataType, result);
         }
-        this.plugin.getEventDispatcher().dispatchNodeChanges(this, dataType, result);
         return !result.isEmpty();
     }