trueog/IllegalStack-OG
2
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix version detection and filter logging #5

Merged
NotAlexNoyle merged 3 commits from agent/fix-version-detection-logging into master 2026-07-23 17:36:05 -04:00
Conversation 0 Commits 3 Files Changed 2
+3 -3
NotAlexNoyle commented 2026-07-23 17:22:15 -04:00 (Migrated from github.com)
Copy link
Copy source

What changed

  • Correct the 1.19 and 1.21 checks to match the lowercased server-version string.
  • Summarize configured item-name and item-lore filters by count instead of dumping every entry into the startup log.

Root cause

fListener lowercases IllegalStack.getVersion(), but the modern-version guard checked uppercase V1_19 and V1_21. As a result, 1.19.x and 1.21.x servers could enter the legacy < 1.13 initialization branch before modern listeners were enabled.

Impact

Modern servers now use the intended material initialization path, and startup logs no longer expose large configured filter lists.

Validation

  • Confirmed the final diff contains only the two intended Java files.
  • Confirmed the supplied full files matched the current repository blobs before applying the three exact replacements.
  • Repository CI is expected to run on this pull request.
## What changed - Correct the 1.19 and 1.21 checks to match the lowercased server-version string. - Summarize configured item-name and item-lore filters by count instead of dumping every entry into the startup log. ## Root cause `fListener` lowercases `IllegalStack.getVersion()`, but the modern-version guard checked uppercase `V1_19` and `V1_21`. As a result, 1.19.x and 1.21.x servers could enter the legacy `< 1.13` initialization branch before modern listeners were enabled. ## Impact Modern servers now use the intended material initialization path, and startup logs no longer expose large configured filter lists. ## Validation - Confirmed the final diff contains only the two intended Java files. - Confirmed the supplied full files matched the current repository blobs before applying the three exact replacements. - Repository CI is expected to run on this pull request.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
NotAlexNoyle (Alexander Noyle) SKBotNL (SKBotNL)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trueog/IllegalStack-OG#5