trueog/EternalCombat-OG
2
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use bundled plugin config.yml as canonical resource #4

Merged
NotAlexNoyle merged 1 commits from codex/use-existing-config-in-plugin-jar into master 2026-03-23 13:32:15 -04:00
Conversation 0 Commits 1 Files Changed 3
+43 -32
NotAlexNoyle commented 2026-03-23 13:32:00 -04:00 (Migrated from github.com)
Copy link
Copy source

Motivation

  • Stop generating defaults at runtime and treat the checked-in config.yml as the canonical plugin configuration that should be shaded into the plugin JAR and copied to the data folder on first run.

Description

  • Add src/resources as a resources source set in eternalcombat-plugin/build.gradle.kts so eternalcombat-plugin/src/resources/config.yml is packaged into the plugin artifact.
  • Change startup in CombatPlugin to copy the bundled config.yml into the plugin data folder with saveResource("config.yml", false) when the file is missing and then load that file via ConfigService.
  • Remove saveDefaults() from ConfigService.create(...) so the Okaeri loader does not create or overwrite defaults and the checked-in file remains the source of truth.

Testing

  • Ran git diff --check successfully after the changes.
  • Attempted to run ./gradlew :eternalcombat-plugin:shadowJar (and :processResources) but the Gradle build could not complete in this environment due to a Java toolchain requirement for Java 17 (environment has Java 25), so packaging could not be validated here.

Codex Task

### Motivation - Stop generating defaults at runtime and treat the checked-in `config.yml` as the canonical plugin configuration that should be shaded into the plugin JAR and copied to the data folder on first run. ### Description - Add `src/resources` as a resources source set in `eternalcombat-plugin/build.gradle.kts` so `eternalcombat-plugin/src/resources/config.yml` is packaged into the plugin artifact. - Change startup in `CombatPlugin` to copy the bundled `config.yml` into the plugin data folder with `saveResource("config.yml", false)` when the file is missing and then load that file via `ConfigService`. - Remove `saveDefaults()` from `ConfigService.create(...)` so the Okaeri loader does not create or overwrite defaults and the checked-in file remains the source of truth. ### Testing - Ran `git diff --check` successfully after the changes. - Attempted to run `./gradlew :eternalcombat-plugin:shadowJar` (and `:processResources`) but the Gradle build could not complete in this environment due to a Java toolchain requirement for Java 17 (environment has Java 25), so packaging could not be validated here. ------ [Codex Task](https://chatgpt.com/codex/tasks/task_e_69c177ae0544832f9ee8dd0cf268e867)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 codex
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels codex
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
NotAlexNoyle (Alexander Noyle) SKBotNL (SKBotNL)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trueog/EternalCombat-OG#4