trueog/Chat-OG
2
0 Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

Many fixes (with the help of claude) #13

Merged
NotAlexNoyle merged 6 commits from main into main 2026-05-10 14:35:56 -04:00
Conversation 4 Commits 6 Files Changed 16
+128 -116
NotAlexNoyle commented 2026-05-06 16:12:02 -04:00 (Migrated from github.com)
Copy link
Copy source
  • Port all PlaceholderAPI usage to MiniPlaceholders / Utilities-OG APIs
  • Fix Unions-OG union colors breaking the MC -> Discord link
  • Drop per-Discord-role suffix configuration
  • Use each player's individual LuckPerms suffix for message suffixes
  • Fix LuckPerms spacing so exactly one space appears between player names and prefixes/suffixes
  • Configure color code roles

This just leaves multi-world support and replacing essentials mail on the Chat-OG TODO list. The latter is not required for 1.19.

- Port all PlaceholderAPI usage to MiniPlaceholders / Utilities-OG APIs - Fix Unions-OG union colors breaking the MC -> Discord link - Drop per-Discord-role suffix configuration - Use each player's individual LuckPerms suffix for message suffixes - Fix LuckPerms spacing so exactly one space appears between player names and prefixes/suffixes - Configure color code roles This just leaves multi-world support and replacing essentials mail on the Chat-OG TODO list. The latter is not required for 1.19.
SKBotNL (Migrated from github.com) reviewed 2026-05-06 16:15:03 -04:00
src/main/kotlin/nl/skbotnl/chatog/config/discord/DiscordConfig.kt
SKBotNL (Migrated from github.com) commented 2026-05-06 16:15:04 -04:00
Copy link
Copy source

Why?

Why?
NotAlexNoyle (Migrated from github.com) reviewed 2026-05-06 16:33:05 -04:00
src/main/kotlin/nl/skbotnl/chatog/config/discord/DiscordConfig.kt
NotAlexNoyle (Migrated from github.com) commented 2026-05-06 16:33:05 -04:00
Copy link
Copy source

This is an artifact from roleSuffixes, the old config file with roleSuffixes was causing a crash. Can be removed.

This is an artifact from roleSuffixes, the old config file with roleSuffixes was causing a crash. Can be removed.
SKBotNL (Migrated from github.com) reviewed 2026-05-07 18:30:37 -04:00
src/main/kotlin/nl/skbotnl/chatog/util/ChatUtil.kt
@@ -25,14 +25,14 @@ import org.bukkit.Sound
import org.bukkit.entity.Player
internal object ChatUtil {
SKBotNL (Migrated from github.com) commented 2026-05-07 18:30:38 -04:00
Copy link
Copy source

This looks very overengineered

This looks very overengineered
NotAlexNoyle (Migrated from github.com) reviewed 2026-05-08 00:26:19 -04:00
src/main/kotlin/nl/skbotnl/chatog/util/ChatUtil.kt
@@ -25,14 +25,14 @@ import org.bukkit.Sound
import org.bukkit.entity.Player
internal object ChatUtil {
NotAlexNoyle (Migrated from github.com) commented 2026-05-08 00:26:19 -04:00
Copy link
Copy source

Its like that because it has to detect if union placeholder is "None" (including color codes) so union name is hidden along with its surrounding brackets. It can be simplified if those things can be hidden in a more elegant way when the player has no union.

Its like that because it has to detect if union placeholder is "None" (including color codes) so union name is hidden along with its surrounding brackets. It can be simplified if those things can be hidden in a more elegant way when the player has no union.
Sign in to join this conversation.
Reviewers
No Reviewers
SKBotNL
NotAlexNoyle
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
NotAlexNoyle (Alexander Noyle) SKBotNL (SKBotNL)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trueog/Chat-OG#13