Suppress no-data warnings for disabled trackers #1

2026-07-22T18:27:09-04:00

NotAlexNoyle commented

2026-07-22 18:27:09 -04:00

(Migrated from github.com)

What changed

Treat trackers with an explicit enabled: false as disabled and skip loading them silently.
Preserve compatibility with existing configs by treating a tracker with no enabled key and an empty tracked-statistics list as disabled.
Continue warning when a tracker is explicitly enabled but still has no tracked statistics.
Avoid validating the rating calculator for a disabled tracker.

Why

A disabled PvE or PvP tracker currently produces a misleading startup warning:

No tracked data found for tracker PvE!

That warning should represent a misconfigured enabled tracker, not an intentionally disabled one.

Behavior

Configuration	Result
`enabled: false`	Silently skipped
no `enabled` key + empty `tracked-statistics`	Silently skipped for backward compatibility
`enabled: true` + empty `tracked-statistics`	Logs the no-data warning
non-empty `tracked-statistics`	Loads normally

Validation

Reviewed the resulting one-file diff and confirmed the branch is one commit ahead of master. A local Gradle build was not available because the GitHub CLI/local checkout tooling is unavailable in this environment.

## What changed - Treat trackers with an explicit `enabled: false` as disabled and skip loading them silently. - Preserve compatibility with existing configs by treating a tracker with no `enabled` key and an empty `tracked-statistics` list as disabled. - Continue warning when a tracker is explicitly enabled but still has no tracked statistics. - Avoid validating the rating calculator for a disabled tracker. ## Why A disabled PvE or PvP tracker currently produces a misleading startup warning: ```text No tracked data found for tracker PvE! ``` That warning should represent a misconfigured enabled tracker, not an intentionally disabled one. ## Behavior | Configuration | Result | |---|---| | `enabled: false` | Silently skipped | | no `enabled` key + empty `tracked-statistics` | Silently skipped for backward compatibility | | `enabled: true` + empty `tracked-statistics` | Logs the no-data warning | | non-empty `tracked-statistics` | Loads normally | ## Validation Reviewed the resulting one-file diff and confirmed the branch is one commit ahead of `master`. A local Gradle build was not available because the GitHub CLI/local checkout tooling is unavailable in this environment.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: trueog/BattleTracker#1