athenian200
18a693a8ab
Reviewed-on: https://repo.palemoon.org/MoonchildProductions/UXP/pulls/3039 I reviewed and tested this PR on Fedora 43 two days ago. Gave it an r+. Was admittedly hoping Travis (our main Linux guy) would confirm my results, but Basilisk-Dev already tested Oracle Linux and I already tested Fedora, so that is likely good enough. Looked at the patch visually and see nothing that could go wrong on Windows or any other platform, since all the changes appear confined to Linux and WebRTC code paths that we don't use for Windows or Mac. Looks correct, and should be low-risk even if there are issues. **Justification for merge into master on own initiative:** 1. I have enough Linux experience to confirm the patch shouldn't break our official Linux builds. 2. Patch mostly touches WebRTC related stuff in Basilisk-Dev's area of concern, so he is the most qualified to sign off on such changes. 3. The patch has been tested twice. 4. MC is a bit preoccupied with the server move. 5. Travis also appears to have been busy. 6. 10 days have passed since PR was first submitted. If master breaks or anything unusual happens as a result of this merge, I am prepared to accept the blame and consequences. Sincerely, Jeremy Andrews (athenian200)
# Mozharness ## Docs * https://developer.mozilla.org/en-US/docs/Mozharness_FAQ * https://wiki.mozilla.org/ReleaseEngineering/Mozharness * http://moz-releng-mozharness.readthedocs.org/en/latest/mozharness.mozilla.html * http://moz-releng-docs.readthedocs.org/en/latest/software.html#mozharness ## Submitting changes Like any Gecko change, please create a patch or submit to Mozreview and open a Bugzilla ticket under the Mozharness component: https://bugzilla.mozilla.org/enter_bug.cgi?product=Release%20Engineering&component=Mozharness This bug will get triaged by Release Engineering ## Run unit tests To run the unit tests of mozharness the `tox` package needs to be installed: ``` pip install tox ``` There are various ways to run the unit tests. Just make sure you are within the `$gecko_repo/testing/mozharness` directory before running one of the commands below: ``` tox # run all unit tests tox -- -x # run all unit tests but stop after first failure tox -- test/test_base_log.py # only run the base log unit test ``` Happy contributing! =)