From 7c614f331f4cd7070fa9e1fcd635c2fe0c0a6e18 Mon Sep 17 00:00:00 2001 From: NotAlexNoyle Date: Fri, 7 Apr 2017 01:38:26 -0400 Subject: [PATCH] Fixes "divide by zero" crash --- Alex's Aspect Ratio Calculator.jar | Bin 3963 -> 3927 bytes README.md | 6 +++--- bin/notalexnoyle/AARC$1.class | Bin 2531 -> 2379 bytes src/notalexnoyle/AARC.java | 22 +++++++++++----------- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/Alex's Aspect Ratio Calculator.jar b/Alex's Aspect Ratio Calculator.jar index 29528fd919ba0efdbd6052dadf3ac3c1d4d80c83..230b25fbb91b79c9c4c8d35ad20ee91765f9505e 100644 GIT binary patch delta 1384 zcmV-u1(*8!9@icWP)h>@6aWYa2mqA~kqos0Obn63D}RMm?Qc_69DdGPxTRd&)-gaF za2XR?l$HsiQZ`+;PK(`(42#1TJZsO|3wQU{dr#T$gE8@w=m%p=3?vd`Vn|GkGGjL- z@q@+~jWH%_OpGSRul@-p>hIjHqhlR3xjpBe^PK1YUZ3;bzn^~r;4ms0S{OQPM{-Nd z+0F$^B!315P7L<+Y6vp4o#p3w!s2!@F*bEp;cu^dBi&?$&80@$cSLx`a@YuaM8GBYLIlYGh&43Vsp=T?rprg~pm z49b$}F?42|SeGOg?tgY%xYLe1BMJ<=qS>aFrGM2t8Ov=z2Rb!uW@ukUsbdSaGK6Q% zf-I$N>0V&i=F`n3yjhb1aQvj0lf$O43du0;#9bP;Gi+&&(9wk*3|di0wZ^bH8q3~@ z<%DzzPc*x*TZ2LN+}O+5QWS-&qZ@mO;XJo0Vr-gWUvxD=Bj?h&q;m3Z9eb5G8%x40 zmVc!0P6$zk)VL+MCk%>*a1Cw{yIC-NpABvoj2b>}q#Rn9sd&}Ob)c3sB}<6guy9AMbGA`D|?KQY`EIubZY?s+9=c0_m{FNz_PTTYSTSVOV~otd&@ zt0ZM_F1X}suQRb+2=_4@S=*Vok&(;x^M4f{kOPO;I$L*t&BH2VM|3=Z2N^=9EpsY6 zew}ARILgp_6Yb5BH7xE@k_=hmw(+8H9kS*a!``OHnqd1^W7i;7W$=iO0aXT@T;WwL zIb?cei(k+%xRkKQsHQ5WRS<3nY4Yp@rvw^(Mi?nPs+#sOYQtvrmkZNpj_Y_FS%1}# zUYRoHA0FYdMBNe1WSZ7}3Zpv4Fiu**%Vl9x^B%ZOeXlUnr#PWwLUmb4I<-yJmQU)) zDRVWi)_NMAq5v#c+OT8G5Khznl8<4W!ZXUnXDKL6Odtnxiua6;=fP{dii9+)p@7v2 zMMFcLROkjrP2+}1p14fU<%QoD)PFs`I5BkHO0Mc!l<`uW!oyB4xAW3U>#XCR6K(_V z?(A(oO{AM9B+s84;bmWBHOw$(qrqU`JbG3v^mkoC$Bs*AWs!Z6Sa1>dT*cr1+GVxYTVMON>vA1;sJ`~q zGJ6&Gzk{92-2N*eAF3lS-G2gkMIn=Qq_dJ_XX8O1*;hxV=kf4$q$VRn3m9&MH8LzB zQ^iOXPgHTz$Df*vOa|NZ1w38FbJr-SK?-3zrqD^E*G*%<5BE#-23(~5*9h?jVcsOv zTciVT6Y>h}zDwx$(1Z8s68Zpfd`Nov5sue)|7Dn7+1s??>Q;eQOS6YrOJ8DHa7 ze1q5VEuHwDP(KjjNBoSR@CSaupZJZn;dj=Jzx)*UQz9viODR^f0t6+wh3&>PipqAj z3niKb$gUQcI7_znEYHr-p*`669~mChz%*ElsbMORRev2F9kE#K9}>?1Y`@MNlxYkS z*$a?<&DBbge*XhdOBx3VJnS)#^aKC^O9=n~P)h>@6aWYa2mnkBvmypU2m+N1lV%Qo q4NMG&N<8c_kMslp085kd4mtu%43jPo90KwMlS~gO1~d);0002d5QQ!P delta 1424 zcmV;B1#kM-9{U~)P)h>@6aWYa2mojckqos0{R)x8D}R+$?Qc_69DdGPc1yW9*mx7S zae*l<$_j$0lug&sX|ZFIVR86^XYHZAaCdLL_jDUyjESEVKNw?TKx2%FAu%z^j0Gj} zgT@$*F(ztEj3&mf{s|`P@0_lqWgX~}?wothbDr~iea<(3fBG4KeW(~{W9V`{$sIB0 zdS@Mx7=Ic%I^4I%K$v08X+Faf4tI-*v8mG{FAcOa^ypPSD-&WyxH2)6m$v6-?LZ1w z_zdj_ZP%8A453&&#}FR&3L=USR+%smVd%)(t~gSeo)Z2sKII68&a9W`PLBJw`d(NJ z%aR>1tk1TvE=eq0Upp@RQ=UI93JhCf*_M{2)qgx0&#gok)*D#IuyzThi4EAu5S_IP zvXpkEf0kjBrkhIyvo;0b@G&tbM{MB~l2P1>+YD@G*w7kbq8mL7Mo~z$#;`6H&t8k= zg!BndG+VIMfJOFP+sn986oqeM8@3a}40kGG>=eU}*iwQ<&V_SH<>c)q?oi&WDhaz- zl7HHr2x1JWaYyh#SQHQ8TihacyI^UbE$$Yq8ou93d9*NH38Xb8tl5(12+P&^3i>11 z$*>~r`<@@gUFbKki(z9^7{uetc3@F;S!FK>Y^q~RdRB?gC?;1FxwL7zG~i9<&{13Cbn*iYqzqcT$ZePG zKgcloKQ6kConOblgnsZp)3>z##{8;0A2czf%5$|Zf{G&#*+JRiXAKN56jEchQ-2lP zDF{D;G)4RVJ%4H98SomfA|WkpXe_lt(J+uFb-cz=)7}x1O)k@O zd7=B2x>}1SL-&njw62kvAjK&>?8KtXEUa|Qdj1*VH}G!F-sEZ`T|FUr{>&&ZYw^lrA%k6tqRT1m6LG%^}j?7WQVCB1FZ z|EPw&fG};YrkPm-;TCkzNN+3F)(F~mqg~Om?V*9t;5<63*mMQG$1lP-5DpK_qpxXU zu=_l^dd{PRb?)elhp*tyi+}i2uU$}Ud+KXHcVDRE_SVRF z0l(oV{ElDP8vM$(;SZhSK}sa0aUsQOR)C-+x3R4_g`%>ZZ9$1R_4KM=^V?Jt_3T4&5uCA_lJpLDnX9%vYGY@4N!$kHhq^`MIDbnA+P)i30 zG9J1q7zF?T;|Tx&P)h>@6aWYa2mt*Gv;GA_2m)velR^%E4gCs-N-`e0DHsI+0OOO+ e4mtw;3X=*C90C>wli>~%lRFO<23QUN0001qouf?v diff --git a/README.md b/README.md index 8122e0b..d7259b7 100644 --- a/README.md +++ b/README.md @@ -5,6 +5,7 @@ Should work on any desktop operating system that can run Java 8. Designed and bu Changelog: +- Version 0.4 Alpha - Fixes crash when calculating aspect ratio with "0" as input for width/height - Version 0.3 Alpha - Adds input validation for negative numbers - Version 0.2 Alpha - Bugfix: Crash when entering non-integer characters - Version 0.1 Alpha - Initial Release @@ -12,12 +13,11 @@ Changelog: Known Bugs: - UI elements can be misaligned -- Running "calculate" with "0" in fields crashes the application TODO: -- Toggle switch for dark mode -- Add dark mode in error messages +- Add a toggle switch for dark mode +- Add dark mode style inside of error messages - Evaluate whether logic to reject numbers that are too large is needed - Come up with a way to auto-merge AARC.jar //TODO(s) into readme diff --git a/bin/notalexnoyle/AARC$1.class b/bin/notalexnoyle/AARC$1.class index 04ae5363c5fe2ee229781b98249b1f9e91ed94cc..2906a58075bca2fad49b5463601d496581d203b7 100644 GIT binary patch delta 237 zcmaDXd|GHj1arM%Ku&66ajHUUUP)?^LZU)>W=cthLSkNuLPlz4dPa#tPGV6yP^Kg! zF;Af?wJ2YYgTaQ8K@F=mENbmA)gl|rjb!rXDwb|$tGNtvn;2BKF-YuSklV&!I+uZ; oQOHtAlVt~k_Hu@qn;3+Uq)=4On{3Y^B>>irP&03HCPx(`0GxtK$p8QV delta 390 zcmX>t^jLU91ap0|XNf{)u|i&ci9$hsadBo+PO3slzCuP~S*k*!LSAZmVo4^DS)Q3v zlA(~8m!go7nwg$aqNfm$lbTqZs*svjl3E1Pnh91{mY7qTS`1cLQdFssn4XxKr^mry z!^jYc)uMXrHlZ1xh-LwX`F6O>$1onv`6>|iqfjJCvn;2BKF-YuSklV&! qI%je%yOb50;A{qdMj>k= 0) { + // If only width is negative or zero: do this + else if(Integer.valueOf(widthEntry.getText()) <= 0 && Integer.valueOf(heightEntry.getText()) > 0) { // Display error message with formatted title - JOptionPane.showMessageDialog(null, "It is not possible to have a negative width. Please enter a positive value and try again.", "Error", JOptionPane.INFORMATION_MESSAGE); + JOptionPane.showMessageDialog(null, "Please enter a width larger than zero.", "Error", JOptionPane.INFORMATION_MESSAGE); } - // If only height is negative: do this - else if(Integer.valueOf(heightEntry.getText()) < 0 && Integer.valueOf(widthEntry.getText()) >= 0) { + // If only height is negative or zero: do this + else if(Integer.valueOf(heightEntry.getText()) <= 0 && Integer.valueOf(widthEntry.getText()) > 0) { // Display error message with formatted title - JOptionPane.showMessageDialog(null, "It is not possible to have a negative height. Please enter a positive value and try again", "Error", JOptionPane.INFORMATION_MESSAGE); + JOptionPane.showMessageDialog(null, "Please enter a height larger than zero", "Error", JOptionPane.INFORMATION_MESSAGE); } - // Final negative number conditional --> If both fields are both valid, positive numbers: do this + // Final negative or zero number conditional --> If both fields are both valid, positive, non-zero numbers: do this else { // Set display label to result { pass in user entry Integer derived from String to math methods };